- 17 Apr, 2020 40 commits
-
-
Sadrul Habib Chowdhury authored
Add some DCHECK()s in the code to validate some assumptions (e.g. make sure the reporters are terminated predictably), and update tests accordingly. BUG=none Change-Id: Id01bd571ad1d59b90c297f71097edcf3e6edc59b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128448 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#760220}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/414782d132e8..b0aab2c7d1dc git log 414782d132e8..b0aab2c7d1dc --date=short --first-parent --format='%ad %ae %s' 2020-04-17 bsalomon@google.com Reland "Revert "Revert "GrDisplacementEffect uses GrTextureEffect.""" 2020-04-17 fmalita@chromium.org [skottie] Initial inner shadow layer style support 2020-04-17 michaelludwig@google.com Revert "Rename GrShape to GrStyledShape" 2020-04-17 ethannicholas@google.com Revert "Converted texture and runtime effects to use GrMatrixEffect" 2020-04-17 bsalomon@google.com Put top level FPs into their own functions 2020-04-17 mtklein@google.com support JITMode::Stack on ARM 2020-04-17 ethannicholas@google.com Converted texture and runtime effects to use GrMatrixEffect Created with: gclient setdep -r src/third_party/skia@b0aab2c7d1dc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: Ica8d598edd28bf51aeb04e33dcbcb4db3e9a5920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155187Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760219}
-
Maciek Kumorek authored
Add --simulate-update-hresult and --simulate-update-error-code switches. The first switch can take the HRESULT error code value, the second one specifies a value that corresponds to the GoolgeUpdateErrorCode enum. With these switches, when using VersionUpdaterWin, one can simulate errors in the about page to debug how the UI reflects certain errors conditions. Bug: 1066529 Change-Id: I6500b81108c69d252087ebcdb1cba0ffba86dbed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131019 Commit-Queue: Maciek Kumorek <makumo@microsoft.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#760218}
-
Philip Rogers authored
This patch marks the following test as flaky: virtual/form-controls-refresh-disabled/fast/forms/form-control-with-state-eager-tracing-crashTest.html The non-forms-refresh version is already listed as flaky. TBR=masonfreed Bug: 1042694 Change-Id: I682a326b97860e08ebcbc1fd23d163b874c116d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155245Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#760217}
-
Francois Beaufort authored
This change will allow us to measure image capture constraints usage and to decide if we can put the existing "zoom" constraint behind a permission prompt without much difficulty. Test: Go to beaufortfrancois.github.io/sandbox/image-capture/playground and check chrome://histograms/Blink.UseCounter.Features is updated with requested constraints. Bug: 934063 Change-Id: I4f5bcb6fc2b9b0c860127c4167fd2258fbaee975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151586Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#760216}
-
phillis authored
Add UKM metric that records SetBadge call per web app to track the Badging API usage on SetAppBadge. Review doc is at https://docs.google.com/document/d/1XNamCi2kjjGLQQ3uJtpYcZpxDTY1NlDnMBFBFjlybGk/edit Bug: 1051682 Change-Id: Ia6a1829cd275f873bc5a72d087b873f3f301959e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108537Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Phillis Tang <phillis@chromium.org> Cr-Commit-Position: refs/heads/master@{#760215}
-
Yuchen Liu authored
Add ClearKey test. ClearKey is handled in renderer process. It should be supported on all the cast builds. Bug: internal b/119043784 Test: CQ Change-Id: I736cb4a6e863d3d92a5c31ab259624b395f550d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155246 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Auto-Submit: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#760214}
-
Natalie Chouinard authored
Render tests are flaky on this bot, and contribute to its consistently red state. No plans to re-enable on this bot in future. Bug: 1068294 Change-Id: I06ff45c4f981e6fb0708dd08a5c711e4fc958de6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154730 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#760213}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c572fb7d..d1705a0f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia0d0ee3281be0b39dcb5bb4cdd5cf64ffbf24c7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153274Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760212}
-
Brian Sheedy authored
Switches the win10_intel_hd_630_experimental mixin to trigger tests in either chromium.tests.gpu.template or chromium.tests.gpu.experimental.template. The experimental machines will soon be upgraded to Windows 10 1909 for testing, so we want to move them to a separae pool so they don't pick up general traffic. TBR=kbr@chromium.org Bug: 1053803, 1065505 Change-Id: I9596a030ba089f824654ec610a9bed102641fc1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154855Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#760211}
-
Xida Chen authored
This particular test case was changed here: https://chromium-review.googlesource.com/c/chromium/src/+/2022618 And that CL made a mistake. In particular, it added a shouldDelay which is meant to be used to delay the start of the main-thread animation, but shouldDelay is not used. This CL fixes that. Bug: None Change-Id: Ia8c2c1fea0918aee69ff07808969d7ac70f48cd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154819 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#760210}
-
Thomas Tellier authored
Bug: 993653 Change-Id: I3cf5cf8596b9bb9f576af3b53723c03bd161a74e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153077 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#760209}
-
Lei Zhang authored
- Initialize variables in the header; make some const. - Use = delete. - Remove unused Initialize(). - Use more specific DCHECKs. Change-Id: I1a9e2a35882193d7aae216ba09803bb3f8d620ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154230 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#760208}
-
Istiaque Ahmed authored
Instead of a RepeatingClosure, pass OnceClosure as the method would call it at most once and is the correct thing to do. Bug: None Change-Id: I9ad50e31117f0fc677e21878b7c4787431cb8422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154586 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#760207}
-
Xinghui Lu authored
Bug: 1041912 Change-Id: If0fe4bf63bb8787cee2b53ad6a3d306406f578e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153939Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#760206}
-
Dominic Farolino authored
This CL cleans up the image lazy loading cross-origin iframe tests. The tests assert that lazy loading works even for images in cross-origin iframes. Before this CL, the main test files didn't make use of promise_test correctly, so the tests would just timeout for implementations that didn't support lazy load. This happened because none of the promises the test awaits actually perform assertions, so in the error case, they never resolve or reject. This CL fixes that by refactoring the tests to use a chain of promises that correctly employ assertions, and return a final fulfilled promise. R=sclittle@chromium.org Bug: N/A Change-Id: I4462cf7fd3d2a67fc1ccfb18ec8196bfdb50891f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154820Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#760205}
-
Dave Tapuska authored
Define GestureDevice, InertialPhaseState, Button, DispatchType in mojom. This allows the removal of the typemappings. TBR=avi@chromium.org Change-Id: Iefe74aebbb49d3155c8cc2f36282575d0b879276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152777 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#760204}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/00032698ac99..87eece9421e1 git log 00032698ac99..87eece9421e1 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 hbos@webrtc.org [Adaptation] Introducing call/adaptation/ResourceAdaptationProcessor. 2020-04-17 hbos@webrtc.org [Adaptation] Rename the processor "VideoStreamEncoderResourceManager". 2020-04-17 hbos@webrtc.org [Adaptation] Report AdaptationCounters OnVideoSourceRestrictionsUpdated. Created with: gclient setdep -r src/third_party/webrtc@87eece9421e1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Icf0f594cbb47687d10ef248a1753e2b687b1b3e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153021Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760203}
-
Sahel Sharify authored
This reverts commit 7d5271d9. Reason for revert: Compile error: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/4945 Original change's description: > Migrate moar tests to LoginManagerMixin > > Bug: 1067260 > Change-Id: Ic86579fd50c5815c9adadbd3feade22cbd1c37a7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144146 > Reviewed-by: Roman Aleksandrov <raleksandrov@google.com> > Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#760159} TBR=rsorokin@chromium.org,raleksandrov@google.com Change-Id: Icbd2a6a47c85fe307b93efd769ef4a85800759d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1067260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155019Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#760202}
-
Dominic Farolino authored
R=yhirano@chromium.org,yoavweiss@chromium.org Bug: N/A Change-Id: I2a7475dc78061f4b4205461e9c40975f781de8b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154817Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#760201}
-
Tom Hughes authored
Bug: none Change-Id: Ic30fb42695fd427a142af051cd7aa617ba70bba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154850 Auto-Submit: Tom Hughes <tomhughes@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#760200}
-
Luum Habtemariam authored
We recently starting sourcing the maximum copies value used in Chrome from the printers; this change implements this for non-ChromeOS platforms using CUPS. Bug: chromium:1027830 Test: added/modified tests pass Change-Id: I860c25f4e1d468b3785d27d6288398c8c3c83196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130887Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#760199}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c090ea78b262..13e4cdb26a25 git log c090ea78b262..13e4cdb26a25 --date=short --first-parent --format='%ad %ae %s' 2020-04-17 geofflang@chromium.org Accept b/ for bug IDs in ANGLE CLs. Created with: gclient setdep -r src/third_party/angle@13e4cdb26a25 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: Ia70b7dc314f87388410a02b47e424a0ade9e2bb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154976Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#760198}
-
Peter Kotwicz authored
This CL disables ContextualSearchManagerTest#testLivePrefetchFailoverRequestMadeAfterOpen with out-of-process network service BUG=1071721 Change-Id: Iab5b71d2a2850431ece89c1a6d22f1a522e99b90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154376Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#760197}
-
Meilin Wang authored
This reverts commit b3f1a19a. Reason for revert: The original CL broke the test because the expected behavior has been updated for that test case. The try bot didn't alert this failure as the failed test was flaky. Patchset 3 fixed this temporarily by deleting the obsolete test case. I will add more test cases to guard the updated behavior and deflake the original test in a follow-up CL. Original change's description: > Revert "ambient: Show lockscreen contents on detecting user interaction." > > This reverts commit 660c9cef. > > Reason for revert: AmbientContainerViewTest.MouseClickClosesWidgetAndStopsTimer failing deterministically on several linux-chromeos bots. Please see https://crbug.com/1068745 for more information. > > Original change's description: > > ambient: Show lockscreen contents on detecting user interaction. > > > > In ambient mode, when user interacting with the background image by > > mouse or gesture, lock screen contents (login pod and media control > > view) need be shown on top for users to either do re-authentication, > > or media control. > > > > This CL implements a prototype of this view transaction by: > > 1. Show the lock screen contents, and > > 2. Fade-out the current shown image. > > > > Bug: b/149246238 > > Test: manually. > > Change-Id: Ie31c666cdfaddefc863ff8173dc185d73ef19178 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110689 > > Commit-Queue: Meilin Wang <meilinw@chromium.org> > > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#757120} > > Change-Id: I395a7c02c6aa292f66ca5d9b4aefa9156e057773 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: b/149246238, 1068745 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139369 > Reviewed-by: Darwin Huang <huangdarwin@chromium.org> > Commit-Queue: Darwin Huang <huangdarwin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#757223} Bug: b/149246238, 1068745 Change-Id: I196c60cb21917dd84f9e7018950d5bf1b788b1ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141067 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#760196}
-
Brandon Wylie authored
The current logic is setup in such a way that it's called along with #setShowIconsWhenUrlFocused. The result of this is it's called more often then it needs to be. Some calls are setup where status view icon is the first focusable view. When the status view icon is set to GONE, Android goes looking for the next focusable view and focused it. This just happens to be the urlbar, which focuses the entire omnibox. Moving this to the tab model changed callback guarantees that when it's called, the status view icon won't have focus (either on the NTP or the tab switcher). Bug: 1063203 Change-Id: Ie9501da027b23133a4a4f2d78ed5c11225147d0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138263 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#760195}
-
Kyle Horimoto authored
(1) Added relevance score, which indicates how well the result matches the user's query. (2) Added settings page hierarchy, an array of strings to be used for breadcrumbs. The implementation adds dummy values for this field and has a TODO to implement them properly. These changes are required by the Launcher UI code and unblock their team's development. Bug: 1059099 Change-Id: I46e9a6ca3bad830446eb0d415d368b4fb750b335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153271Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#760194}
-
Becca Hughes authored
Add a last display time field that is used for picking feeds that have not been shown recently. BUG=1053599 Change-Id: Ia6e9cf7c8023b04294d6c4cc88d22b8dd11a0af4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145568Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#760193}
-
Sergio Collazos authored
This reverts commit 21eb2224. Reason for revert: Causing failures on ios_web_unittests on iOS12 https://ci.chromium.org/p/chrome/builders/ci/iphone-device/7949 Original change's description: > [iOS] Restore the user agent only on iOS 13+ > > This CL restrict the user agent restoration to iOS 13 and further as > iOS 12 has an issue getting the right User Agent. > > Bug: 1070593 > Change-Id: Ie4570efcb9931ccb8662511b16a1298570f0a297 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154189 > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Commit-Queue: Gauthier Ambard <gambard@chromium.org> > Cr-Commit-Position: refs/heads/master@{#760057} TBR=justincohen@chromium.org,gambard@chromium.org Change-Id: I0458f2cea4df855599dd8fa72692b7ff4840ef06 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1070593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153733Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#760192}
-
Lily Chen authored
In CanonicalCookie, the string member |domain_| is a combination of the cookie's domain (as defined in RFC 6265bis) and the negation of the cookie's host-only-flag, which is indicated by the presence of a leading dot. The Domain() accessor returns the |domain_| string whereas many consumers actually want the RFC's definition of the cookie domain, leading to many of them manually stripping off a leading dot. This CL moves CanonicalCookie::DomainWithoutDot() from private to public so that users can directly access the domain without worrying about how it's internally represented, and organizes some functions in cookie_util to avoid redundant string operations. Bug: 1071291 Change-Id: If1db8ece3d436956696951ed4eafeb6fa3784bfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151310Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#760191}
-
phillis authored
PWA is treated same as general websites and thus it doesn't need to check additionally if extensions sync is turned on for UKM logging. Bug: 1068404 Change-Id: I4fee2bdf53527a8f8693be27205e7fb4d68142b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152895Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Phillis Tang <phillis@chromium.org> Cr-Commit-Position: refs/heads/master@{#760190}
-
Joshua Pawlicki authored
Bug: 1071965 Change-Id: I68ab432d4a0835e15cbca2467c507316ce4dcdf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154740 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#760189}
-
https://crrev.com/c/2137925Bence Béky authored
Change-Id: I98010947ff6f74fa7cabcb0e86dece1412a9974e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147632 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Auto-Submit: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#760188}
-
Devlin Cronin authored
Adjust the CHECKs in BrowserView to avoid triggering a CHECK failure when there is no extensions container (which can happen in the case of app windows). This fixes AppBrowserControllerBrowserTest.NoExtensionsContainerExists with the menu enabled. Bug: 943702 Change-Id: Id14113c456934f5e7984d142f97104929080da32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153745Reviewed-by:
Caroline Rising <corising@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#760187}
-
Kevin McNee authored
When a page is orphaned, it is still considered to be in a portal, so the PortalNavigationThrottle can still enforce its restrictions. Bug: 1043777 Change-Id: I56fb835570d8d81b8e4befacbf37a86b61429f93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154812Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#760186}
-
Roberto Carrillo authored
Also, enable test results export to BQ on CI builders in the dev instance of buildbucket. R=vadimsh,nodir,chanli Bug: 1048825 Change-Id: I8135072708114962306b21f6293767c7db23368a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153932 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#760185}
-
Adrian Taylor authored
Also, removing conflicting wording about what to do if there's no CPE available. R=dcheng@chromium.org Bug: 895969 Change-Id: I17916054d78882b9a57a0067de5507a592292727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144611Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Adrian Taylor <adetaylor@chromium.org> Auto-Submit: Adrian Taylor <adetaylor@chromium.org> Cr-Commit-Position: refs/heads/master@{#760184}
-
Elly Fong-Jones authored
Bug: None Change-Id: I5cdc27a89236b163d232f2f8360147ded353f796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154858 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#760183}
-
Eric Roman authored
Bug: 1054414 Change-Id: Iede646dd272413fcc8c2f9951a9ff7d663708b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151887Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#760182}
-
Kevin Marshall authored
Adds an additional minor version suffix to the hardcoded CrKey version string. Bug: 1071138, b/143307063 Change-Id: Iacbc48bd90e8d9bbdf725e57209a654ef68afc4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150061 Auto-Submit: Kevin Marshall <kmarshall@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#760181}
-