- 21 Aug, 2020 40 commits
-
-
George Steel authored
https://drafts.csswg.org/css-transitions/#interface-globaleventhandlers-idl Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/dxDGBFKvO3A Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1797226 Original Revert: https://chromium-review.googlesource.com/c/chromium/src/+/1816818 Bug: 868224 Change-Id: I1f83765f31ba7f0902b0fdb1688e206f509f5664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258467Reviewed-by:
Kevin Ellis <kevers@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Joey Arhar <jarhar@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#800689}
-
Richard Townsend authored
Removes an unnecessary state-assertion DCHECK. The consequences of doing this are relatively small (since PumpTokenizer checks IsStopped() anyway). Bug: 901056, 1112544 Change-Id: Ie59b6d3ba34afc0de63aa3780e6ee889f8f93c81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366893Reviewed-by:
-
Justin Cohen authored
Bug: 1120723 Change-Id: Id1a510e5bd318df12207169a06c58dd2090ff297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369437 Commit-Queue: Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#800687}
-
Ian Kilpatrick authored
As above. There should be no behaviour change. Change-Id: I3848546f7e634e40bb06a327b21497f45052f22f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369453Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9d8fd36d3b95..682f9141d174 2020-08-21 jmadill@chromium.org Remove feedback loop support from back-end. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I36479a4e58127a37908c2befe15b3cc11d33d7a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369295Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800685}
-
Owen Min authored
Also fix an issue in the presubmit script when supported_on is empty. Change-Id: Ic72f06e05e11052fecba8dd013f28ba77a37848c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368174 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#800684}
-
Jie Dai authored
Test: On device with both silent and normal boot Bug: internal b/165025541 Change-Id: I20fdbf94399daa5c1c4e843539685a1027d5ff37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363370Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Jie Dai <jied@google.com> Cr-Commit-Position: refs/heads/master@{#800683}
-
Andrey Kosyakov authored
This reverts commit 5a809a08. Reason for revert: I don't think the test failure is related. Please note it stopped before the revert landed (build no 91007 vs. 91010). This must have been a flake, or a independent failure that has been fixed by one of the front-end rolls. Original change's description: > Revert "Add more checks for chrome.debugger extensions" > > This reverts commit 4838b76a. > > Reason for revert: 1119297 > > Original change's description: > > Add more checks for chrome.debugger extensions > > > > Bug: 1113558, 1113565 > > Change-Id: I99f2e030f9a38f1ffd6b6adc760ba15e5d231f96 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342277 > > Commit-Queue: Andrey Kosyakov <caseq@chromium.org> > > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > > Reviewed-by: Yang Guo <yangguo@chromium.org> > > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#799514} > > TBR=dgozman@chromium.org,rdevlin.cronin@chromium.org,caseq@chromium.org,yangguo@chromium.org,sigurds@chromium.org > > Change-Id: I01ad12ca99ac75197f9073e2c6c9d0eaa0d95147 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1113558 > Bug: 1113565 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362920 > Reviewed-by: Christian Dullweber <dullweber@chromium.org> > Commit-Queue: Christian Dullweber <dullweber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799558} TBR=dgozman@chromium.org,rdevlin.cronin@chromium.org,caseq@chromium.org,yangguo@chromium.org,sigurds@chromium.org,dullweber@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1113558 Bug: 1113565 Change-Id: Ic98fc037028a210204b7935b0b8e50e4e36e2397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368446Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#800682}
-
dpapad authored
Bug: 1062154 Change-Id: Ibdba6f78836ac153f2ce4bbe905891a25e759cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368083Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#800681}
-
Garrett Beaty authored
Bug: 1120401 Change-Id: If45c62f4959968fb020520632c5d73008ad49339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368448Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#800680}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/85132f3cbf67..a0cf0214eefa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xhwang@google.com,nektar@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1041781,chromium:1075562 Tbr: xhwang@google.com,nektar@google.com Change-Id: I598e071f930217d3ff57f7e18985c3efa1c3120c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368148Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800679}
-
Xianzhu Wang authored
"Full screen within tab" [1] is to let an element requesting full screen to fill the tab space instead of the screen space. It allows the user to operate the tab (e.g. switching to another tab, dragging the tab) using the non-full-screen browser UI when capturing a screenshot or video of the full screen rendering of a web page. These capturers are operated by the user to capture a visible tab. They start capturing by calling WebContents::IncrementCaptureCount(size, /*stay_hidden*/false). These capturers are called "visible capturer" in WebContents. Internal capturers capture tab rendering (either visible or invisible) for internal use (e.g. to generate a tab thumbnail), without user awareness, so they should never have side-effects, thus should never cause full screen to enter the "within tab" mode. These captures start capturing by calling WebContents::IncrementCaptureCount(size, /*stay_hidden*/true). These capturers are called "hidden capturer" in WebContents. This CL prevents the tab from entering the "full screen within tab" mode when there is no visible capturer. [1] https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/ui/exclusive_access/fullscreen_within_tab_helper.h;drc=4f51d5d775713e1b428ad8fa5ee131c411753f3c;l=15 Bug: 1112607 Change-Id: I1b910eeb68077f02be00c56c86f9a5bf0f0bcfc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365226Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#800678}
-
Yue Zhang authored
http://crrev.com/c/2242222 sets the dialog visibility into false in TabGridDialog constructor as a default value for this field. Setting this in PropertyModel will emit a signal to hide the dialog, but the signal should be no-op as the dialog is not showing. Otherwise this will break a assumption in ScrimView and crash. http://crrev.com/c/2242222 enforces this is no-op by ignoring the signal when mScrimPropertyModel is not setup. The assumption here is that the dummy signal will always arrive earlier than the mScrimPropertyModel setup, which happens when dialog is first shown. However, this assumption no longer holds for StartSurface, because for StartSurface, the initialization of TabGridDialog (which is controlled by the initialization of TabSwitcher) can happen later than the first show of TabGridDialog. Such a flow can be: Step1) Open dialog from strip and dismiss. (This is when mScrimPropertyModel sets up.) Step2) Click the tab switcher button to enter tab switcher. (This is when the dummy hide dialog signal is sent out.) This CL fixes this issue by switching to a more stable way to filter out dummy signal: whether the dialog is showing. This way we make sure that the signals that should be no-op on dialog side are in fact no-op. Bug: 1096358 Change-Id: I6847b3d2545238933a42a6b610c07e4a9623d066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362970 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#800677}
-
chromium-internal-autoroll authored
Release_Notes:http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202008210800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/vM9bho-P099cq08wxl7KsIWL5LU4hoPBEucxexnc_0IC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: I26d45b72323c47de47d307f9e4da05554454d9f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369168Reviewed-by:
-
Daniel Classon authored
Adds deep links to the People page and 6 subpages, missing only the old sync page which is in another CL. Bug: 1084154 Change-Id: I5acad5040eac889e25705c1eef29ed717e546a85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358310 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#800675}
-
Juanmi Huertas authored
The clear method in CanvasResourceProvider (that ensures that buffers are initialized correnctly) was being called from the constructor in several places. Now the clear method is going to be called internally when creating a CanvasResourceProvider, so it has been removed from the places where it was called to ensure the buffer was initialized. The method CanvasResourceProvider::Clear was kept as a public method as there is still an instance of Clear in Canvas2DLayerBridge, in a method that seems to explicitly clear the canvas: Canvas2DLayerBridge::EnsureCleared() This CL addes a new parameter that can be set to kCallClear to initialize the Provider on creation. Reordering some parameters of the Creator of ResourceProvider to make all methods more similar among themselves. Bug: 1090081 Change-Id: Ibc130af381523173a40a962054645d60fa8971c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236462Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#800674}
-
Yuke Liao authored
Add an example to show how to use the test runner with xvfb Change-Id: I8ccf0750024e8ae4a8e68e8178faf38d9aa37974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368415 Auto-Submit: Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#800673}
-
Xing Liu authored
We nearly never check these metrics any more, so remove them as they expired. Bug: 1109824,1089721,1088736,1052968 Change-Id: I183912ed813b0d0fa1a56f6da108fb0568d8f358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364129Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#800672}
-
Francois Doray authored
This is a pre-requisite for Beta and Stable experiments. Bug: 1101731 Change-Id: Ib127de8a4e67b2ea55b87b6053ce2ae4673566be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364819Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#800671}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6a4e145832a9..be1455850c3c 2020-08-21 rmistry@google.com Temporary workaround for Canary-Chromium finishing too early If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: stani@google.com Change-Id: I8fc0b5bc629996ba0ed3f6d0bbd1f806187c9419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369293Reviewed-by:
-
Vladimir Levin authored
The spec has changed to ensure that 'auto' content-visibility intersection observations are synchronous (after lifecycle) on the first frame. The test change is to expect new behavior as well as test previous behavior by making a container off-screen first. R=chrishtr@chromium.org, jarhar@chromium.org Change-Id: I0ef3182b04a2a8731a80a044689581f2a5ac3c2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368509Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/66d1f73e2c9d..aba65a8e1ce1 2020-08-21 msisov@igalia.com X11 and Ozone: Try to check for display type when creating framebuf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1119303 Tbr: swiftshader-team+autoroll@google.com Change-Id: I9eef17ae34b70c0ab75037f8a3f44752d0a08fe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368087Reviewed-by:
-
Josh Nohle authored
Adds class to download user's contacts from Nearby Share server via the ListContactPeople RPC. It handles the paginated ListContactPeople responses, aggregates the contacts into a single list, and fails if a complete list cannot be downloaded. The process will also fail if any individual RPC call exceeds the input timeout. We leave space for the soon-to-be-implemented RPC that checks if contacts have changed since the last upload via the UpdateDevice RPC. A fake class and factory are also added for use in unit tests. Bug: b/154861518 Change-Id: I8d91d7667d2325b7f9b0c8f02deb7ee3757c18fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309670 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#800667}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9869f187b5ea..c86d8fb76ac3 2020-08-21 primiano@google.com Add ignore_result for fuchsia in vm_test_utils.cc 2020-08-21 treehugger-gerrit@google.com Merge "ui: handle thread state conversion in the controller itself" 2020-08-21 primiano@google.com Merge "De-hardcode kPageSize in the cross-platform core tracing code" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I2002b8e8db496c99f01929759454e09bf30978b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369413Reviewed-by:
-
Xiaohan Wang authored
This reverts commit 3166ebf7. Reason for revert: Causing compile failure https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8871331944681332016/+/steps/compile/0/stdout Original change's description: > Remove unnecessary min_sdk_version from //chrome > > Having these causes apks to disable dex merging, making builds a bit > slower. > > Bug: None > Change-Id: I33903834529b5c2e1fec43cb81c3d076ca899055 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367648 > Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800658} TBR=agrieve@chromium.org,pkotwicz@chromium.org Change-Id: Iaa31715b3e3421a10a87ce0d7699ecd8f5d5dc71 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368316Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#800665}
-
Miguel Casas authored
crrev.com/c/2339787 refactored the UMAs tracking VAAPI errors, but had a few naming inconsistencies/mistakes. This CL fixes those. Bug: b:162962069 Change-Id: I820565cb94c61b33be73b0f8301205a0c3308a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367734Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
-
Nicolas Arciniega authored
This change implements the following edits to the Fetch spec: https://github.com/whatwg/fetch/pull/560 https://github.com/whatwg/fetch/pull/1076 Existing web tests cover the new functionality. Bug: 847428 Change-Id: Ie63704769e99d4b8d26d8903edf4cc4e3466c124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339761 Commit-Queue: Nicolas Arciniega <niarci@microsoft.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#800663}
-
Becca Hughes authored
Modules currently have a fixed height of 150px. The Kaleidoscope module is taller so we should update the height to match. Change-Id: Ic6cd15e6b9ec9b66a52d69a9ded7e85430687128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364772 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#800662}
-
Weilun Shi authored
This histograms_index file will be used by the histograms expiry job. As we split up histograms, we need a way to locate all available histograms xmls and thus we need this index file. This cl also adds a PRESUBMIT check to make sure this index file is up-to-date. Bug: 1116807 Change-Id: I59844e10a15f053e9435f1a6c9bb85445ddf8718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368140 Auto-Submit: Weilun Shi <sweilun@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
chinsenj authored
When a user highlights an active desk in overview mode, ChromeVox announces "Desk 1 (Active Desk) ...". However, when a user highlights an inactive desk, ChromeVox announces "Desk 2 ...". To make it more clear that the inactive desk is inactive, this CL adds an indication that the desk is inactive. I.e. ChromeVox now announces "Desk 2 (Inactive Desk) ...". Test: manual Bug: 1111988 Change-Id: I7e47ecd923fbfd2d7f8fe86531a03c87419cf23d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364558Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Cr-Commit-Position: refs/heads/master@{#800660}
-
Mohamed Amir Yosef authored
... CompromisedCredentialsManager Bug: 1108422 Change-Id: I750c63612bb68b9156b89fe2f7b4961f324a3067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367099Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#800659}
-
Andrew Grieve authored
Having these causes apks to disable dex merging, making builds a bit slower. Bug: None Change-Id: I33903834529b5c2e1fec43cb81c3d076ca899055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367648Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#800658}
-
Andrew Grieve authored
This reverts commit f05ab16d. Reason for reland: Repro'ed locally. Increased -Xmx flag. > > > Original change's description: > > > > Add -noverify to build commands to improve runtime (local builds only) > > > > > > > > The flag is guarded by treat_warnings_as_errors=false so that it > > > > will apply only to local developer builds. > > > > > > > > Results from //tools/android/build_speed/benchmark.py base_java_sig: > > > > With change: > > > > base_java_sig: 68.0s avg (68.8s, 67.2s) > > > > base_java_sig: 68.4s avg (68.6s, 68.2s) > > > > > > > > Without change: > > > > base_java_sig: 69.4s avg (69.3s, 69.5s) > > > > base_java_sig: 69.7s avg (69.7s, 69.7s) > > > > > > > > time out/Debug/bin/run_base_junit_tests: > > > > With Change: > > > > real 0m22.741s > > > > real 0m23.543s > > > > > > > > Without change: > > > > real 0m23.176s > > > > real 0m24.328s > > > > > > > > Bug: 1117222 > > > > Change-Id: I4bfd742165468bf9538e6fa0dc8f35daa9e0f23f > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313299 > > > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > > > Auto-Submit: Andrew Grieve <agrieve@chromium.org> > > > > Reviewed-by: Peter Wen <wnwen@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#799285} > > > > > > TBR=wnwen@chromium.org,agrieve@chromium.org > > > > > > Change-Id: I82f411e5dab89c361a30c33e9103bd8561f19765 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 1117222 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362493 > > > Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org> > > > Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#799471} > > > > Bug: 1117222 > > Change-Id: Ib43bfe72869def7da43b237360df0e155149a963 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363975 > > Reviewed-by: Peter Wen <wnwen@chromium.org> > > Commit-Queue: Peter Wen <wnwen@chromium.org> > > Auto-Submit: Andrew Grieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#800233} > > TBR=wnwen@chromium.org,agrieve@chromium.org > > Change-Id: I0d617bcfc7a311bfae743445fccaaab26364511e > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1117222 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368541 > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800435} Bug: 1117222 Change-Id: I48b3b0349490241cca1d7d7aa33004ed55bf887f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368928 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#800657}
-
adoneria authored
Bug: 1109373 Change-Id: If658d897a110ffc266b1dc96648fa7b626aa3466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367977Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Anjali Doneria <adoneria@google.com> Cr-Commit-Position: refs/heads/master@{#800656}
-
Koji Ishii authored
The hyphenation language alias map in AOSP was updated and moved to native in CL[1]. This patch changes the map in Blink to match the one in AOSP. [1] https://android.googlesource.com/platform/frameworks/base/+/f90c9b6437304d95344a1b29448ed1a0f2b95f76 Change-Id: I47471a93d4c56f9623b37dd25182f28f392ba46b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359309Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#800655}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ce9f3a41..6733ced7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I65578a87505dbff42d25e6ee31a520dd317b72b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367400Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800654}
-
Mohamed Amir Yosef authored
Bug: 1108422 Change-Id: Ib42812e5f4af6e4d5b346b9612cd03b4713091f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367723Reviewed-by:
-
Brian Sheedy authored
Adds the --code-review-system flag to the Android test runner and adds the necessary code to handle it for use with Gold. This is necessary because we will be specifying 'gerrit-internal' when running tryjobs for internal CLs so that Gold knows where to comment if new images are generated. Bug: 1077274 Change-Id: I5ce089a511275afed0c06378d9d49e977e330f85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366072 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
-
Eric Roman authored
NOTRY=true Change-Id: Ic72612b4fded10735379978d3e828aba80888b85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369355 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#800651}
-
mark a. foltz authored
Followup from https://chromium-review.googlesource.com/c/chromium/src/+/2361025 Bug: 1116706 Change-Id: I337b41b74d9a74c825d6b83a25eab29891c83008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363705 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#800650}
-
