- 27 Feb, 2020 40 commits
-
-
Tim Song authored
BUG=1040648 Change-Id: Ifb92fcb180c8b6a504cc2d22165b9b7bf96499bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072821Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#745215}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/0363c3e46d35..e299afa9ec11 git log 0363c3e46d35..e299afa9ec11 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 enga@chromium.org Support CPU adapters in dawn_end2end_tests Created with: gclient setdep -r src/third_party/dawn@e299afa9ec11 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ic838b8d59801bdc7b883e07af475864ee3f24cfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078602Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745214}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/4112d4f0c61a..840d5db64e4d git log 4112d4f0c61a..840d5db64e4d --date=short --first-parent --format='%ad %ae %s' 2020-02-27 rwkeane@google.com mDNS: Update MdnsQuerier Relevant Answer Filtering Created with: gclient setdep -r src/third_party/openscreen/src@840d5db64e4d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I4f22dc4e0ccfe2682ffa21f1fb8e5227b85ca20b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079271Reviewed-by:
-
dpapad authored
Bug: 1026426 Change-Id: I3c8f1da0776a279d250969a2c2384339b405ae51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076544 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#745212}
-
Kevin McNee authored
These imports were almost ordered alphabetically and had some duplicates. Bug: None Change-Id: I3ada8bcbc9d8956ca74c6bb37c358b96f7f3975b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079136Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#745211}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/29d5cf85ac28..a4f9aa037585 git log 29d5cf85ac28..a4f9aa037585 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 iannucci@chromium.org Refactor OWNERS for LUCI-related tools. Created with: gclient setdep -r src/third_party/depot_tools@a4f9aa037585 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Idc7d60aab072dbde783f4049a8b654d12fd6c144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078608Reviewed-by:
-
Jarryd authored
Add calls to QuotaManagerProxy::NotifyWriteFailed() where ServiceWorker write errors might occur. With this information, the quota system can reasonably guess if the disk storing the user's profile is out of space, and decide if any actions should be taken. Bug: 997258 Change-Id: I2d2216d69cbfb9609d895c28afc8af18d444e243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050752 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#745209}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/6e167903252f..4745a47b272f git log 6e167903252f..4745a47b272f --date=short --first-parent --format='%ad %ae %s' 2020-02-27 thestig@chromium.org Clean up ReportUnsupportedFeatures(). 2020-02-27 thestig@chromium.org Make ReportUnsupportedXFA() more efficient. 2020-02-27 dhoss@chromium.org Space-efficiently destroy chained CXFA_FMSimpleExpression instances 2020-02-27 dhoss@chromium.org Create abstract class CXFA_FMChainableExpression 2020-02-27 thestig@chromium.org Handle case of nothing to restore in SkiaState::ClipRestore(). 2020-02-26 thestig@chromium.org Roll DEPS for build/ and tools/clang/ Created with: gclient setdep -r src/third_party/pdfium@4745a47b272f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1052724,chromium:986108 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I4345a5910c260f0309fbd45efc25e2627469c669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079036Reviewed-by:
-
Manu Cornet authored
Separate logic of calculating target bounds and actually updating layout. Bug: 1047012, 1042918, 1056514 Change-Id: Iffba0d8b691ed45a04447274a3e8ed174268c70c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076421 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#745207}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c93595b4b916..729310aa1810 git log c93595b4b916..729310aa1810 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 alessiob@webrtc.org iSAC fixed|float encoder fuzzers 2020-02-27 alessiob@webrtc.org Opus Encoder fuzzer: separate target for FuzzAudioEncoder 2020-02-27 srte@webrtc.org Adds binary proto ANA support in scenario tests. 2020-02-27 srte@webrtc.org Use the last video stream for scenario tests stats. 2020-02-27 danilchap@webrtc.org Make ProcessThread be a TaskQueue implementation 2020-02-27 alessiob@webrtc.org iSAC API wrapper unit test fix 2020-02-27 titovartem@webrtc.org Add ability to enable AV sync in PC level tests 2020-02-27 hta@webrtc.org Remove deprecated "description" field of cricket::ContentInfo Created with: gclient setdep -r src/third_party/webrtc@729310aa1810 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I49a95c0aa208406bd182c9a8c8f1dc503fdfcebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079333Reviewed-by:
-
James Cook authored
The crash is a CHECK failure that the user's email and gaia ID are non-empty. I introduced the regression in this CL: cros: Migrate assistant off the identity service http://crrev.com/c/2033572 The CHECK was moved to its current location in this CL: Reland "assistant: Fix mic button doesn't work with fake gaia account." http://crrev.com/c/2053284 It's not clear if Assistant is supposed to work in Active Directory accounts. AD accounts don't seed the IdentityManager with an email or gaia ID, so it's unclear to me if/how Assistant ever worked. I did not add a unit test for the fix because it's not clear if the empty email/gaia ID is expected behavior or not, so I don't want to enforce support for it in tests. Bug: 1056717 Change-Id: Ib17100c6b2f403d8782f5f7faed79b7d64aac1ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078841 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@google.com> Cr-Commit-Position: refs/heads/master@{#745205}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5084b4ef. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I8e82f9856f2ea6572fe9ea95043f02370b628a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079094Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745204}
-
Peng Huang authored
Bug: 1053239 Change-Id: Icb94e544439360bc34d709755702ebf731f21100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070558 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#745203}
-
Ahmed Fakhry authored
The windows of removed desks should be demoted to be LRU across all desks. That's why they're appended at the end of the overview grid list. However, their relative order should be maintained. This CL makes sure the MRU order is updated to match the above expectation, as well as the windows' stacking order (that is windows of the removed desk should be stacked at the bottom of the target desk's container's children). BUG=1048271 TEST=Expanded existing tests. Change-Id: I400b2ac3ce2b5de1f1d8defaff7c4d155e4fab29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076670 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#745202}
-
Scott Violet authored
This patch makes it possible (guarded by flag) for block-flow to handle -webkit-line-clamp. Change-Id: I6b64d7402892578344a1c30e8ac167fa87e258d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034898 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#745201}
-
Vadim Bendebury authored
The util/tpm_hash_gen.py script from Chrome OS EC tree cr50_stab branch was used to generate version strings for all images. BUG=chromium:728134 TEST=None Change-Id: If12f3f8924fdc43140c76797607ab8423214e27a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076014Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#745200}
-
Sorin Jianu authored
This change uses prefs to store and retrieve app ids for the apps registered for updates. Bug: 1020285 Change-Id: I92f08bbc31979fa80e5621e2bd00d1c83cb5c11b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079142Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#745199}
-
Becca Hughes authored
Add support for clearing media history if we clear it by origin. BUG=1024352 Change-Id: I8c053d8cca11b0a63b1e4cc9168acf8fbc3b3e73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057634Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#745198}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/29c52f9cafce..4665866ae8db git log 29c52f9cafce..4665866ae8db --date=short --first-parent --format='%ad %ae %s' 2020-02-27 jacktfranklin@chromium.org Typescriptify FormattedContentBuilder + move tests 2020-02-27 kahinds@microsoft.com Remove transparent border-top from Elements tree rows 2020-02-27 tvanderlippe@chromium.org Run TypeScript without building mode 2020-02-27 jacktfranklin@chromium.org Update screenshot testing to enable element screenshots Created with: gclient setdep -r src/third_party/devtools-frontend/src@4665866ae8db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1048378,chromium:1051458 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I256e61998f62ceac547d1f7c42dbed56f70ff533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078606Reviewed-by:
-
Nico Weber authored
Bug: 1056189 Change-Id: Iee607dda6c4788d836115c53e43c5c93f63486a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078426 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#745196}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f99345291868..9b194b7a67c8 Created with: gclient setdep -r src-internal@9b194b7a67c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1012975 Tbr: jbudorick@google.com Change-Id: I7cf8aa119cde51c7b3ed4df83ba525df3830f1a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079045Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745195}
-
evliu authored
This CL adds a histogram metric to track the percentage of caption settings that come from the system settings. Bug: 1056381 Change-Id: Ia8e7dee0e521f986e6bcbfcd887702d6ef63dd1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076542Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#745194}
-
Nico Weber authored
This reverts commit bf1f5892. Reason for revert: It's not clear why we want this, see discussion on bug. (And it prevents typing suggestions and emojis in gmail.) Original change's description: > Make autocorrect=off and spellcheck=false disable Touch Bar typing suggestions. > > Bug: 1024914 > Change-Id: I3ff68438b028fe38ad7270d7f90772b595f4f46e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917603 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Sidney San Martín <sdy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715401} TBR=avi@chromium.org,sdy@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1024914 Change-Id: Ib14cd55fde1af09cd2485d86724ce480fa431c10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079174 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#745193}
-
Nicolas Ouellet-Payeur authored
This reverts commit a1b98ca7. Reason for revert: https://crbug.com/1054895#c27 Original change's description: > Traffic annotation auditor: fix Python 3 compat > > filter() results are not subscriptable in Python 3, so we need to use > next() to retrieve the first element instead. > > Bug: 1056747, 941669 > Change-Id: I003eda9a8044d18bf7a2aae82086693aa0386c90 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079191 > Reviewed-by: Martin Šrámek <msramek@chromium.org> > Commit-Queue: Domenic Denicola <domenic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745163} TBR=msramek@chromium.org,domenic@chromium.org Change-Id: I973a3fb59a7a678031a0bbfe239657d300512c87 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1056747, 941669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079256Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#745192}
-
Findit authored
This reverts commit 70bd5cca. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 745168 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzcwYmQ1Y2NhZDg1MWE3ZmRhODBkZDA1MWRkNmQ2OThhNWRkMjA5MzcM Sample Failed Build: https://ci.chromium.org/b/8887267928809703632 Sample Failed Step: compile Original change's description: > Add androidx_espresso to android_deps. > > Bug: 1005891,1054152 > Change-Id: I28da67e1d4d1b92a4953a8ae72f9565055cc2afb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064823 > Reviewed-by: Peter Wen <wnwen@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Commit-Queue: benjamin joyce <bjoyce@google.com> > Cr-Commit-Position: refs/heads/master@{#745168} Change-Id: Ia179914525b4c56faa5f7f8faed9d59fc80e29b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1005891,1054152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079147 Cr-Commit-Position: refs/heads/master@{#745191}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f0d32401cf06..4d2040a6f973 git log f0d32401cf06..4d2040a6f973 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 geofflang@chromium.org Make GLSLTest_ES31.MixOfAllResources more lenient. Created with: gclient setdep -r src/third_party/angle@4d2040a6f973 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: geofflang@google.com Change-Id: I39c544cbbec5153f0d8b7e4d62abf08bd44de337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078601Reviewed-by:
-
Sam Maier authored
Added keeps required to keep Mockito happy - revert happened here: https://crbug.com/1056619. This is a reland of 2d6ff560 Original change's description: > Roll R8 2.0.2 -> 2.1.8 > > I checked to ensure crbug.com/1050440 was fixed. > https://issuetracker.google.com/149831282 > > Bug: 1040534 > Change-Id: I3894f4316f2dde2527a35ad6e919ee8cdc86c2b9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075039 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Auto-Submit: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#744708} Bug: 1040534 Change-Id: Ia991b83ef942d6655f9e1ba561ab1b407025ccae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078591 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#745189}
-
Robert Sesek authored
This was originally attempted in a8a9ff46, but PartitionAlloc unconditionally supplied MAP_JIT to mmap() if it was allocating pages for V8, even though V8 was running in --jitless mode. Because MAP_JIT can only be used from a process that has the allow-jit entitlement, this resulted in the process crashing due to a code signing validation error. Instead of unconditionally supplying MAP_JIT, PartitionAlloc now will only do so if the process has the allow-jit entitlement. Test: Configured a Proxy PAC file, did local signing of Chromium, verified that the proxy resolver utility process does not crash. Bug: 961592, 1052853 Change-Id: Icd1c2db42c208272f36c7d4c0fc1c1c3c6a3520f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078792Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#745188}
-
Domenic Denicola authored
This is the first step at implementing the new fetching semantics from the updated origin policy specification. It also deletes some parts that are no longer in the spec and would have needed updating anyway. In particular, this removes: * The distinction between default origin policies and versioned origin policies, and along with it, the "latest version map". This removes, for now, the application of origin policies to pages without an Origin-Policy header; that will be added back as part of the caching work in crbug.com/1042040. * Redirect-handling logic for default policies. Redirects are now always an error. * Parsing of the response header from the server. We currently just check for its presence, and will do parsing according to the new spec as part of crbug.com/1042036. * Sending Sec-Origin-Policy: 0 on the request. We may add this back later, but it is still under discussion: https://github.com/WICG/origin-policy/issues/51 * A good amount of C++ "unit tests" that were rather integration test-ey, and would have had to be rewritten anyway. Instead they are replaced with web platform test integration tests. * A thorough web platform test of the origin policy installation/deletion cycle, which would have had to be rewritten, and then rewritten again once we tackle crbug.com/1042049. We'll want to refer to it in version history once those foundations are stable. * Reporting, for now. We need to first spec this and then add it back. See https://github.com/WICG/origin-policy/issues/62. Additionally, although we removed all parsing of the response header, we changed the code to look for the presence of Origin-Policy instead of Sec-Origin-Policy per the latest spec. Apart from removals, this CL's biggest changes are to the web platform tests. This implements the plan discussed at https://github.com/web-platform-tests/wpt/issues/20773 and https://github.com/web-platform-tests/rfcs/pull/44 which allows us to serve different origin policies per subdomain. The test origin policies also now contain "id" members, but those are not used or tested for now; that will occur in https://crbug.com/1042036. Bug: 1042034 Change-Id: I4674fe2cfbc1f3e174c76415d86a487e750cdb0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020488 Commit-Queue: Domenic Denicola <domenic@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#745187}
-
Devlin Cronin authored
Add an interactive ui test for clicking twice on an action in the toolbar, verifying the second click closes the popup. This provides parity with the test coverage in the old ui (where this was exercised in ToolbarActionViewInteractiveUITest.DoubleClickToolbarActionToClose). Bug: 984654 Change-Id: I6ad9cb8fe3a67fcdab4b905796dc6aa91f458622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022977 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#745186}
-
Chris Hall authored
R=aboxhall, dmazzoni Change-Id: Ibbd5f6b9e8ad6ec954265b9c7eeb5b798055530b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066486 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#745185}
-
Toni Barzic authored
The test was asserting that an animation is still in progress just after running loop. If test is slow enough, it's possible that the animation completes before RunUntilIdle does its job. Downgrade ASSET_TRUE(is_animating()) StopAnimating() to if (is_animating()) StopAnimating() Whether the app list is animating or not at this point is not really focus of this test - the main point was to make sure that the test verifies the state after the animation completes. BUG=1056302 Change-Id: Ib0e0b912c5cc316df667a62c8c13e494c3a45df4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078845Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/65dd8440ec78..9db20bb3437e git log 65dd8440ec78..9db20bb3437e --date=short --first-parent --format='%ad %ae %s' 2020-02-27 crouleau@chromium.org [Devil] Set up logging level based on --verbose. Created with: gclient setdep -r src/third_party/catapult@9db20bb3437e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:383566 Tbr: oysteine@google.com Change-Id: I14566ad2e3a2da3104b9c78b478b2a66b2d55ef9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079038Reviewed-by:
-
Misha Efimov authored
Bug: 1010286 Change-Id: I66aa3617ee5e16c751a47d7f36f91925d89107d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835160Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Auto-Submit: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#745182}
-
Deepanjan Roy authored
There was a circular dependency that broke run_tbmv3_metric.py: core.tbmv3.trace_processor imported core.results_processor.perfetto_binary_roller, which meant we had to import core.results_processor.__init__, which imported core.results_processor.command_line, which imported core.tbmv3.trace_processor. perfetto_binary_roller is quite independent of any other results processor code, so there is no reason to make users of it import results_processor.__init__.py which pulls in all the results_processor. Change-Id: I4990edbce41b8e06867c30bab1bb7d27f3c5b57f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076418Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Commit-Queue: Deep Roy <dproy@chromium.org> Cr-Commit-Position: refs/heads/master@{#745181}
-
Mason Freed authored
The [1] CL enabled the FormControlsRefresh feature by default for Mac. (The [2] CL enabled it earlier for Windows, Linux, and ChromeOS.) In the process, many layout tests were disabled, because the form controls have a different appearance with the feature enabled. This is one of several patches rebaselining those disabled tests. [1] http://crrev.com/c/2063530 [2] http://crrev.com/c/1967608 Bug: 1053725 Change-Id: Ibb1f8bc0baabc9cbe5326208cda1d12014e0d433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071583 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#745180}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a4b8c86e94ba..2f0b41d4e7f8 git log a4b8c86e94ba..2f0b41d4e7f8 --date=short --first-parent --format='%ad %ae %s' 2020-02-27 lalitm@google.com tp: split systrace trace parser into pieces 2020-02-27 lalitm@google.com tp: print stats before entering HTTP mode Created with: gclient setdep -r src/third_party/perfetto@2f0b41d4e7f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:150213213 Tbr: perfetto-bugs@google.com Change-Id: I7cadab7dcc6e17e0a06a55e17f7ce1330b6458ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079034Reviewed-by:
-
Ken Buchanan authored
There have been occasional instances of marshals responding to security emails and removing the list outright, rather than bcc'ing. This makes it hard to distinguish between emails that have had responses and those that have not. Change-Id: I55feedc97450149a5dac69b6dd79c29eb5b44d3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079331Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#745178}
-
Darwin Huang authored
Bug: 1052575, 1056154 Change-Id: Ic54bb72742ee3e8b8b94f63e5468319e289a8fb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076539 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#745177}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f4467316..bfa4dadb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9e9722345ce60aff3e10b9383631754d07b0ce78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078552Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745176}
-
