- 23 Jan, 2021 30 commits
-
-
Sean Topping authored
Some targets only exercised by Chromecast internal builds were broken by the following change: https://chromium-review.googlesource.com/c/chromium/src/+/2515787 Bug: 1169966 Tets: Cast internal CQ Change-Id: I39957eb7f2b7d813b1f00a03598155e9c729c3f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643698 Commit-Queue: Sean Topping <seantopping@chromium.org> Auto-Submit: Sean Topping <seantopping@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#846433}
-
Piotr Bialecki authored
This is a reland of 6674e06c Changes from the original CL: The test will not be compiled in case there are no AR devices available, since it is not possible to distinguish failure due to an issue with enterprise policy preventing creation of immersive-ar sessions, from a failure due to not having a device that supports AR. Original change's description: > WebXR: add enterprise policy for immersive-ar sessions > > This CL adds new enterprise policy that is used to gate access to > immersive-ar sessions in WebXR Device API. The enterprise policy is > per-profile, and is implemented by propagating the pref value from > browser process to blink via WebPreferences. > > Additionally, the CL also introduces new AndroidBrowserTest that > exercises the added glue code, with the assumption that the enterprise > policy code that controls the pref is correct. > > Other changes: > - add manifest entry in test jinja template in order for them to work on > newer Android versions > - add DVLOGs in WebXR code paths to assist with debugging > > Bug: 1159067 > Change-Id: I27eba5fc0e7bae3dca2d47ca3fb2e935facbd37c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627778 > Commit-Queue: Piotr Bialecki <bialpio@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Owen Min <zmin@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Alexander Cooper <alcooper@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845521} Bug: 1159067 Change-Id: I36f955dba6ad4e6f6bc3f88c53875052f6eb19a9 TBR: dcheng@chromium.org, zmin@chromium.org, alcooper@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642995 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#846432}
-
Scott Violet authored
If the supplied id doesn't identify a crash file, then an NPE is triggered. This adds an early out. BUG: 1169894 TEST: CrashReporterTest.testBogusCrashId Change-Id: I78defd46f82c22f79ece02d5191b27342e1144c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644464 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#846431}
-
Tom Anderson authored
This is a reland of 3fe154df Original change's description: > [X11] Split PutImage requests into multiple requests if necessary > > R=sky > > Change-Id: I1befaef494c74797333d6bf02e204bcdc721e752 > Bug: 1164669 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643711 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#846344} Bug: 1164669 Change-Id: I932bbeb1dd8be92067ab69ebf22ac19d95daa3e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644750Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#846430}
-
Victor Costan authored
QuotaManager will move behind a mojo interface. This interface's methods must all be async, in order to avoid deadlock (storage service -> browser access may be synch, so browser -> storage service access must be async). In preparation for this change, only the quota system may access QuotaManager directly. All other features will use QuotaManagerProxy, which will only expose async methods. This CL applies the plan to PepperFileSystemBrowserHost. Bug: 1168597 Change-Id: I227b0ee9aad87b59a569f469370be4d0903280cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645492Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#846429}
-
Lily Chen authored
Bug: 1157010 Change-Id: Iacdc534afaa513914db168267d6446619bfd3dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644531 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#846428}
-
Katie Dektar authored
http/tests/devtools/profiler/cpu-profiler-bottom-up-large-tree-search.js is failing flakily with timeout on msan. Suspect due to https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2632164 but difficult to roll back as the autoroller has continued rolling for nearly 24 hours. Bug: 1169908 Change-Id: I0dbac554ad186227272ed18aee31ed262b81ee66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645496 Commit-Queue: Katie Dektar <katie@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Katie Dektar <katie@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846427}
-
Nick Burris authored
This patch ensures that the InternalAuthenticator created by SecurePaymentConfirmationAppFactory is always owned by a WebContentsObserver, to ensure that the authenticator is outlived by its RenderFrameHost. Bug: 1169317 Change-Id: Ie22c3796d642589f912b880bcdadeb3badde8180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644743 Commit-Queue: Nick Burris <nburris@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Auto-Submit: Nick Burris <nburris@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#846426}
-
Ken Rockot authored
Minimal set of changes needed to move these tests to WPT. This is in preparation to have them load JS modules. Bug: 1004256 Change-Id: I34445236a11c7dffc39ef1ffbe2540566a7dddfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639070 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#846425}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/910cb2c9006f..20d925a81d53 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC katydek@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1150968,chromium:1169382,chromium:1169852 Tbr: katydek@google.com Change-Id: I902c3e73ea8a607f6ab50f4b2bb94d841872b586 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645081Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846424}
-
rbpotter authored
Bug: 1164004 Change-Id: I39400a6f97693ecda7c28b24e4e2af203fedc69b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642921 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#846423}
-
Kai Ninomiya authored
The previous entry only disabled acceleration on swrast, but softpipe and llvmpipe shouldn't be used for "GPU" acceleration either. This should apply to Linux but not ChromeOS, AFAICT. This only improves an existing software rendering list entry, but here is the rationale: We prefer to rely on our own (domain specific, so more efficient) software paths, at least for everything other than WebGL. And for WebGL, SwiftShader avoids unknown factors like llvmpipe/softpipe/swrast. If you are running a Mesa GL driver (not e.g. NVIDIA) then you can force these configurations with: - LIBGL_ALWAYS_SOFTWARE=1 https://docs.mesa3d.org/envvars.html#libgl-environment-variables:~:text=LIBGL_ALWAYS_SOFTWARE - GALLIUM_DRIVER=llvmpipe, softpipe, or swr (though swr didn't work for me) https://docs.mesa3d.org/envvars.html#gallium-environment-variables:~:text=GALLIUM_DRIVER The GL_RENDERER strings are: - swrast: "Software Rasterizer" (couldn't test this locally; found this online) - softpipe: "softpipe" (on one machine) - llvmpipe: "llvmpipe (LLVM 10.0.0, 256 bits)" (on one machine) Drive-by updates the description of another item to be more accurate (SVGA3D is virtualized over hardware; it's not a software renderer). Bug: 1155974 Change-Id: I0571c1a1bf526260f7ea6cd53f88eec768973b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645491 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Auto-Submit: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#846422}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/57144c8685d3..44860edcd260 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6b4fca29205652b1023ade400647ab29884e678a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645606Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846421}
-
Ryan Chung authored
This allows protobuf_full to be used. The intention is to remove this after migrating away from protobuf_lite. Bug: internal/167603683 Change-Id: Ida1171fb4d27b4a03f1de6dcf654e09e535f8cfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401332Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Ryan Chung <ryanchung@chromium.org> Auto-Submit: Ryan Chung <ryanchung@chromium.org> Cr-Commit-Position: refs/heads/master@{#846420}
-
Taylor Bergquist authored
Bug: 1153030 Change-Id: Ia35b8f19e40ee312289e709ff23df5be66a71067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639231 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#846419}
-
Gil Dekel authored
This CL changes the fallback strategy in ConfigureDisplaysTask to submit requests individually when an atomic modeset test fails. More particularly, it groups displays by the physical connectors they are attached to and submit these request groups for atomic modesetting. For example, if the request {internal display, MST1-1, MST1-2, HDMI} fails as a whole, the next configuration attempt would repeatedly try each of the following groups until a modeset succeeds: {internal display}, {MST1-1, MST1-2} and {HDMI}. When a request group fails modeset, the request with the highest bandwidth requirement is downgraded first. Finally, if any of the request groups exhausts all its alternative modes, the entire configuration attempt terminates and signals back an ERROR status. In addition, this CL adds extensive testing for multiple display configurations, including multiple MST hubs, nested MST structures, MST and non-MST (i.e. independent) external displays, bad MST hubs, and configurations with no internal displays, such as a Chromebox. Bug: b:176819129, b:177356832 Test: display_unittests && ozone_unittests Change-Id: Iac2b7f0330a74396c72f8d3867552dde593800e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621674 Commit-Queue: Gil Dekel <gildekel@chromium.org> Reviewed-by:Gil Dekel <gildekel@chromium.org> Cr-Commit-Position: refs/heads/master@{#846418}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ia146ffa25cd93e0a34d38418fe6d277f21c23890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645330Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/57144c8685d3..44860edcd260 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I1d9a3528debd94305a46d92cbcd0fc1fbd37f671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645495Reviewed-by:
-
Song Fangzhen authored
Track how often each permission check cause Permission Denied failures. Now only record Permission Denied failures caused by CORS. TODO: Record other Permission Denied failures. Explainer: https://github.com/WICG/raw-sockets/blob/master/docs/explainer.md Bug: 1119681 Change-Id: I70e697143fac58e99cf1006c6326de00ebda2f6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638956 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#846415}
-
Shane Fitzpatrick authored
I also removed the line clamp since the max name you can set the device to will be shown on 3 lines (screenshot). With the line clamp, more characters get replaced with '...'. Happy to revert though. Fixed: 1161289 Change-Id: I9ce43875a62f044bb0c6060af8b135b0ff85fe1b Screenshot: https://screenshot.googleplex.com/8u4NqQjsQ2L6dpq Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645040Reviewed-by:
Josh Nohle <nohle@chromium.org> Commit-Queue: Shane Fitzpatrick <shanefitz@google.com> Cr-Commit-Position: refs/heads/master@{#846414}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Id3c6bab0755508c05f350cba34349fe1d04547d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645566Reviewed-by:
-
David Benjamin authored
content/browser/loader/resource_loader.cc is no more. Bug: 934009 Change-Id: I71f507175cdfcd0618b1176e38122f73c7dc0db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645163 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
-
Junbo Ke authored
Also migrated off base::DictionaryValue. Bug: internal b/156555613 Merge-With: eureka-internal/514526 Merge-With: eureka-internal/514525 Merge-With: eureka-internal/514524 Merge-With: eureka-internal/514186 Merge-With: eureka-internal/513401 Merge-With: eureka-internal/513298 Merge-With: eureka-internal/513381 Merge-With: eureka-internal/513294 Merge-With: eureka-internal/513296 Merge-With: eureka-internal/513299 Test: cast_base_unittests Change-Id: If06e412cd0d8eab2374e6567a87832d6a225d9a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612108 Commit-Queue: Junbo Ke <juke@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#846411}
-
Reilly Grant authored
This change converts callbacks from base::Bind and base::Callback to Once/Repeating in //chrome/browser/chromeos/policy. Bug: 1148570 Change-Id: Icdf25846737b2621b11e51f676e9a098e021a930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641478 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#846410}
-
Mason Freed authored
This CL implements the basics of the new <popup> element, including the HTMLPopupElement prototype, the UA stylesheet CSS including open/hidden and position:fixed, promotion of content to the top-layer, and a Runtime Enabled flag to turn it on. Some basic WPT tests are included. See the explainer here: https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/Popup/explainer.md Bug: 1168738 Change-Id: If9f8279c01a7055da49c51670804400d621deb95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644061Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#846409}
-
Maks Orlovich authored
In some case there are aliases to a node being inserted into a rankings chain already in-memory (e.g. due to an iterator active while an entry is being moved between different eviction list), but Ranking::Insert failed to update them, making things confused. Fix that. Bug: 1156288 Change-Id: I1a1bd5fb7aedf5ee6e45071606825b266e5e3b9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639218Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#846408}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3fe96b789504..413f7cb17c77 2021-01-22 sugoi@google.com Flip samples to their correct position If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: If67804c05f17e06aeed30ddfcfa52bd4fe67bc07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645334Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d272110d7181..eeeaae9a029b 2021-01-22 johnstiles@google.com Consolidate SkSL CPU and GPU test code. 2021-01-22 bungeman@google.com Remove SK_SHAPER_HARFBUZZ_USE_BAD_SCALE 2021-01-22 johnstiles@google.com Run unit tests to verify SkSL folding behavior. 2021-01-22 michaelludwig@google.com Fix lighting image filters 2021-01-22 bungeman@google.com Roll freetype If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I9340893ed4bff9613c4ff7337c6cdaac0090ee4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645373Reviewed-by:
-
Abigail Klein authored
Bug: 1055150, 1167349 Change-Id: I33c8f137bd15bfe971817d154ca18947ddfc5b38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645061Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#846405}
-
Mustaq Ahmed authored
Bug: 1164347 Change-Id: I3c04a4ba3a8beee7cabf1f7823e249e66738d75a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644706Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#846404}
-
- 22 Jan, 2021 10 commits
-
-
Thomas Guilbert authored
This CL allows a MediaStreamTrackProcessor to be created from an audio track. This will allow AudioFrames to be read from an audio track, via a ReadableStream interface. Bug: 1157608 Change-Id: Id0406309a42dd76896c8481c83a85d5a376cad42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602598 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#846403}
-
Brandon Wylie authored
Combines all the setup/lifecycle management of UUD (UnownedUserData) and Supplier, which removes a bunch of boilerplate code for setting up and tearing down separate UUD/ObservableSuppliers. It works by providing an abstract base class, which is then subclassed by the specific type being supplied through UUD. This is similar to how we currently encapsulate UUD keys to keep them private. The base class, UnownedUserDataSupplier, stores an ObservableSupplier<E> in UUD during construction. After construction, users can immediately take a reference to the ObservableSupplier through the type subclass mentioned above. This UnownedUserDataSupplier will act like a normal ObservableSupplier until it's destroyed. Change-Id: I72d466e6b34fb8e634d23a6f99ab49ee1ace1dc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442011Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#846402}
-
Liquan (Max) Gu authored
Since OverviewModeBehavior has been deprecated in favor of LayoutStateProvider, this CL replace PaymentUiService's OverviewModeBehavior with LayoutStateProvider. In order to do that, this CL also provides an accessor for ChromeTabbedActivity's LayoutStateProvider. Related: * The CL that introduced OverviewModeBehavior to payment code: https://crrev.com/c/1506374 Bug: 1161560 Change-Id: Ied65a51953602bd3176449074297cd99ae54deb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622316Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
Nathan Zabriskie authored
crrev.com/c/2642765 just landed which fixed some broken web tests with CanvasOOPR enabled. This CL just updates the TestExpectations file with the now passing tests. Bug: 1081534 Change-Id: I6630d78f8c8663ceda50a63899212687d2e32441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644465 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Nathan Zabriskie <nazabris@microsoft.com> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#846400}
-
Nic Hollingum authored
This reverts commit c9c1768b. Reason for revert: b/175932227 Original change's description: > Remove redundant call to determine crostini app id > > This is done by AppServiceAppWindowCrostiniTracker::GetShelfAppId before > this point always, and the subsequent call will always return the same > thing. > > The claim in the comment is probably legacy, as empty-app-id windows > will be filtered out by > AppServiceAppWindowLauncherController::OnWindowVisibilityChanged. > > Bug: b/172979315 > Change-Id: I38121c68cb48c9840831b83665fdf7e33285cc44 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552327 > Reviewed-by: Nancy Wang <nancylingwang@chromium.org> > Commit-Queue: Nic Hollingum <hollingum@google.com> > Cr-Commit-Position: refs/heads/master@{#830097} TBR=hollingum@google.com,nancylingwang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/172979315 Change-Id: I6c064cdb82d35d99f383207cd98975271ddf5b6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642845Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#846399}
-
Hui Yingst authored
This CL migrates `deferred_invalidates_` to PdfViewPluginBase so that Invalidate() and InvalidateAfterPaintDone() can be migrated as well, which will allow these two methods to be shared by both OutOfProcessInstance and PdfViewWebPlugin. This CL also removed PdfViewPluginBase::in_paint() since all uses of `in_paint_` are within the same class. Bug: 1140629 Change-Id: I819687e402b3a0687b597194e2210c9282772c22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639169 Commit-Queue: Hui Yingst <nigi@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#846398}
-
Garrett Beaty authored
Bug: 1169257 Change-Id: I9eefd704939aa586476f9d0590b7e6cdb154a1d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645036 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#846397}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 50ebf37e. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I139dc6891040b5fff774409576d193c09b4dae6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643549Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846396}
-
Eugene But authored
Change-Id: I4a54a22b4bd957051697c34b74f72e30f208e4f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643043Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
-
Michael Bai authored
Adding ContentCaptureFrame makes the code more clear and also ready to send the metadata such as title, favicon and etc. This patch also add the title to frame. Bug: 1168827 Change-Id: I66d97f2ef50d644e0a0dbf1c8fa67d6b2aba557a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641301 Commit-Queue: Michael Bai <michaelbai@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#846394}
-
