- 02 Oct, 2019 40 commits
-
-
chrome://flagsJeffrey Chen authored
This reverts commit 3f622b5a. Reason for revert: This was an improper fix. Proper fix is here: https://chromium-review.googlesource.com/c/chromium/src/+/1835274 Original change's description: > Fix chrome://flags search box placeholder visibility in dark mode > > Default placeholder text color in input boxes was changed to a color with > transparency, which may cause placeholder text to be unreadable by default > if the input box background is a dark color. This change adds explicit > styling to the placeholder color. > > Bug: 1001957 > Change-Id: I7b24ab1e01a96cc5b7caa0f22ade8ab712951fe9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799997 > Reviewed-by: Colin Blundell <blundell@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Commit-Queue: Jeffrey Chen <jeffreyca16@gmail.com> > Cr-Commit-Position: refs/heads/master@{#696060} TBR=asvitkine@chromium.org,blundell@chromium.org,jeffreyca16@gmail.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1001957 Change-Id: Ia470faa1c7193dbdb2643348d7c8b421e2c1b416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835276Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#702036}
-
Eric Stevenson authored
This CL was partially created by //base/android/jni_generator/jni_refactorer.py. The conversion also required converting unit tests to use the new JNI mocking approach provided by JniMocker. Also removed a couple of unused methods. Bug: 929661 Change-Id: Ic34608693e7c48313512c8ef7e48943023de2af5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833078Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#702035}
-
Harald Alvestrand authored
While waiting for "connected" state on PC2, PC1 may sometimes have time to transit to "completed" state. This CL accepts both event sequences. Due to the bug on not completing, this will only happen in plan B. Delete the mac-specific expectations files. Bug: 997201 Change-Id: I7aab5566c7868990d840bda9afc16516cf147425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834225 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#702034}
-
Maksim Moskvitin authored
Old implementation of GetData() encrypted keystore_decryptor_token with current default encryption key, which is wrong for backward compatible keystore Nigori, since it uses non-keystore key as the default encryption key. Now we always use most recent keystore key to encrypt keystore_decryptor_token. The old behavior shouldn't cause any issues, since it should be impossible to reach GetData() in commit codepath, while Nigori is in backward compatible keystore mode. But it's still better to fix, to avoid data corruption in case it overlaps with other bugs and to not violate invariants. Bug: 922900 Change-Id: Ic2455b5e1875cb18c4a9278598999dc47025bc23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834081Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#702033}
-
James Cook authored
The user is likely to try re-entering their passphrase, so ensure focus stays in the input field. Convert the Print Preview PIN settings element to use the same approach to focus, so callers aren't depending on internal implementation details of cr-input. Bug: 805829 Test: See bug. sign in to account with sync passphrase, enter incorrect phrase, focus returns to input field. Tested with both Chrome OS and Linux. Change-Id: I012f5b5368654c8b0f36b66f9fd07124d394c9a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832632Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#702032}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8c3bb48f5870..f03259ad7205 git log 8c3bb48f5870..f03259ad7205 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 courtneygo@google.com Vulkan: lineloop support for DrawElementsIndirect 2019-10-02 ianelliott@google.com Vulkan: Divide 3188 KHR failures into 2 known root causes + cleanup. Created with: gclient setdep -r src/third_party/angle@f03259ad7205 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Bug: None Change-Id: I7d40b569c62dfcb74a3a32704a6d51f0849b8ab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834975Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702031}
-
Eric Seckler authored
To aid debugging data loss issues. Bug: 914092, 1008424 Change-Id: I06b91acd892970b6bba251c1893247debf61b16a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835577Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#702030}
-
Alex Chau authored
- device_last_updated is unused after https://crrev.com/c/1742158, but still causing prefs::kSharingSyncedDevices to update on every reboot Bug: 1006153 Change-Id: I62e86791a58e8c5ca63ae9127895ecb4b813b1d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835578 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#702029}
-
Henrik Boström authored
See bug. TBR=sky@chromium.org NOTRY=True Bug: 1010182 Change-Id: I7017fbb995398a4a1d43caa7acac78c72fd00612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835368Reviewed-by:
-
Antonio Gomes authored
The use seems pointless now that the class uses Mojo for IPC. This CL prepares to Onion souping this class. BUG=787254 R=guidou@chromium.org Change-Id: If36a51b8ff724d6a70aecc884f296e594d3fd2a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834362 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#702027}
-
Peter Collingbourne authored
We can allow generate_jni_registration targets to appear in multiple toolchains by moving the default_toolchain dependency into the template. This will eventually be needed to build bundles that include HWASAN splits, which will employ three toolchains (32-bit, 64-bit and HWASAN) instead of the usual two. Bug: 916828 Change-Id: I4edb22263d6feb432034be41f2cfea5cafafc60f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832713 Auto-Submit: Peter Collingbourne <pcc@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#702026}
-
Arthur Hemery authored
Filter content_unittests crashing on android_bfcache_debug fyi bot. Bug: 1007276 Change-Id: I7510c423da49fc9821e9910b3e2b51b63017edc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835366Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#702025}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fa5193a394a7..1e470360678b git log fa5193a394a7..1e470360678b --date=short --no-merges --format='%ad %ae %s' 2019-10-02 eseckler@google.com base: Output a debug message if temp file creation fails Created with: gclient setdep -r src/third_party/perfetto@1e470360678b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:931138 Change-Id: I7af9324c9867ec36bf5bb9355d55712ae4a06da3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835696Reviewed-by:
-
Mason Freed authored
In the case that the element with backdrop-filter also has opacity set to zero, there is no need to perform the backdrop filtering operation. This also avoids degradation of the painted output when backdrop_filter_quality is < 1 and opacity is 0, as in crbug.com/1002225. Bug: 1002225 Change-Id: I8334f6cc46f18eeda412cab7b885b1612c0315a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833925 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#702023}
-
Antonio Gomes authored
This CL prepares MediaStreamTrackMetrics to be Onion souped. BUG=787254 R=guidou@chromium.org Change-Id: I9c31edef1cc690afcbc08b0cde2b18faec866558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834363 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Roman Sorokin authored
It fixes missing back button Bug: 1000606, 1009340 Change-Id: If7839758f51f39315317cb7d8c4616ef27736295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829199Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#702021}
-
Benedikt Meurer authored
The current popover feature is supposed to be able to handle property accesses (in the current scope) and show a preview of the value. This triggers when you hover an identifier with the mouse. DevTools will then try to find the full sequence of preceeding tokens for the property access and send that to debug-evaluate. However for template literals, this doesn't work properly, since a template literal is not necessarily a single token (in CodeMirror), but for example `a${x}b` is a sequence of three tokens. So instead of just assuming that looking at tokens is enough here, we search for the preceeding ` when we find a template literal and include everything in between. This is merely a work-around for the bigger issue that we should probably implement this feature via a dedicated parser (or ideally reusing V8's AST) to find the correct, innermost subexpression that forms the property access. Hence there's a TODO left in the code to eventually address the bigger issue. Bug: chromium:995036 Change-Id: I4191a54c7ec6ee768f213076c22d575e1ac8438b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835573Reviewed-by:Yang Guo <yangguo@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#702020}
-
Philip Jägenstedt authored
It's the upstream CI configuration and we don't need it. Stop ignoring .travis.yml since that's gone upstream. Change-Id: I1c1fb6f4f7f6658082406fd3e19a4d0456d614f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835359Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#702019}
-
Robert Kaplow authored
This is reverting the disabling from here: https://chromium-review.googlesource.com/c/chromium/src/+/1278543 Bug: 838549 Change-Id: Ia354b294aee539ba59d6d4aa160c38f9de7773b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637051Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#702018}
-
Bret Sepulveda authored
This reverts commit e9e520a3. Reason for revert: Flakiness unlikely to be caused by the test itself. Original change's description: > sheriff: Disable BrowserNonClientFrameViewPopupTest.HitTestPopupTopChrome. > > Flaky on Linux ASAN and TSAN. > > TBR=bsep > > Bug: 998946 > Change-Id: Iead970e3ca6738c495a9b922c19f24294b9093e4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774006 > Reviewed-by: Darren Shen <shend@chromium.org> > Commit-Queue: Darren Shen <shend@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691478} TBR=shend@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 998946 Change-Id: Id164a193c1182b71d002b66b4e8b328fddde7402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835619Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#702017}
-
sczs authored
Since Settings might embed 3rd party ViewControllers, the only interface we could expect from them in order to clean up or rubberband when swiping down to dismiss are the AdaptivePresentationControllerDelegate instance methods. For this reason SettingsRootTableVC now conforms to AdaptivePresentationControllerDelegate, and any subclass can override or implement any of the these methods. This CL also forwards all AdaptivePresentationControllerDelegate method calls into the currently presented Settings VC. Bug: 1006304 Change-Id: I0ff47d755e5c3e67029e210dfb94d21d700520cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832104Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#702016}
-
Alan Screen authored
The Windows VS_FIXEDFILEINFO structure includes fields to represent the version number of a file. Allow these to be provided as a standard base::Version object. Update base::FileVersionInfoWin to make use of this API update. Drop exposure of internal VS_FIXEDFILEINFO structure, and propagate cleanup to gpu/config to use cleaned up API. Bug: 1008222 Change-Id: I94beaf8f8d2d3d90ebb19c3c44acacf7027903f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828219 Commit-Queue: Alan Screen <awscreen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#702015}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Id79e18139e4f6f2986b58a0ed9d290e8dbff8e30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835695Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f4e0c29ed1d7..f1e97b9ebd23 git log f4e0c29ed1d7..f1e97b9ebd23 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 sprang@webrtc.org Reland "Prepares RtpSenderVideo for batch forwarding of generated packets" 2019-10-02 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4ce9e096..1fdb019b (701829:701929) 2019-10-02 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 443491f4..4ce9e096 (701518:701829) Created with: gclient setdep -r src/third_party/webrtc@f1e97b9ebd23 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None Change-Id: If109a6b99f49b58eea78ebabf6199fd3b2b39ec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835464Reviewed-by:
-
Arthur Hemery authored
Filter unit_tests crashing on android_bfcache_debug fyi bot. Bug: 1007276 Change-Id: I01720d8ed406d82e0e728ab5a8012a590676227c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835615Reviewed-by:
-
sczs authored
If a Message Banner is being presented and the user taps on its picture/ initial letter Disc, the settings screen wouldn't be presented. This happens because BVC is actually not the presenter VC and it can't dismiss the Banner. This CL uses the existent functionality for showGoogleServicesSettingsFromViewController where BVC is used instead of the parameter VC. This also takes us closer to not sending a VC through the dispatcher. It also removes a DCHECK since a presentedVC should leave that decision to the presenterVC. This is something we currently lack and I hope to work on this after Messages. I didn't add an integration test since we don't have a good way to trigger an Infobar on NTP in an integration test. Bug: 961343 Change-Id: I85ea8047f5b55abd6e5606b4046d7dd7ad158625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834206 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#702011}
-
Xida Chen authored
TBR=hbos@chromium.org NOTRY=true Bug: 1010483 Change-Id: I095aedfdefe38c62cd3ba9fb8b4a49f1b7c65c75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834875Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#702010}
-
Nico Weber authored
-Wpessimizing-move missed a few calls for a while. Now it finds them again, so clean them up. Bug: 1010458 Change-Id: I143cc6f1421f505aeb56858182860018a75051f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835672 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#702009}
-
Mikhail Khokhlov authored
Bug: 981349, 956308 Change-Id: I887cd6752df75d33babfb187d8da1ad78112f4f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824088Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#702008}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5740a8e03413..dbfa96532ab0 git log 5740a8e03413..dbfa96532ab0 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 perezju@chromium.org [py_utils] Fix pylint errors Created with: gclient setdep -r src/third_party/catapult@dbfa96532ab0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:1010304 Change-Id: If4dbef916b2e69a3d11ab9085e60427c5969f156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834873Reviewed-by:
-
Geoff Lang authored
When running on top of ANGLE, ES2 contexts are often used because the exact context version requested is returned. BUG=989194 Change-Id: Iedd673a7c5bee7a291991145f3f7d30552b34d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727169Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#702006}
-
Annie Sullivan authored
This had been missed when updating FirstInputDelay over the summer. Change-Id: I9f635708265c009b4e89d1152c3388a499a78858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834116Reviewed-by:
-
Justin Cohen authored
This reverts commit ceff1a21. Reason for revert: Fixed. Original change's description: > Revert "[ios] Enable preload with slim-navigation-manager." > > This reverts commit 101b5ae0. > > Reason for revert: Needs some more work, some last minute > refactoring introduced some crashes. > > Original change's description: > > [ios] Enable preload with slim-navigation-manager. > > > > Previously, preload required CopyStateFromAndPrune and > > CanPruneAllButLastCommittedItem within NavigationManager, but those > > are not supported with SlimNav. Here, preload is implemented by > > creating a preload WebState with navigation history by restoring the > > current WebState. > > > > The performance of this implementation depends on Slim > > Navigation Manager's session restoration performance which can be > > measured with existing kRestoreNavigationTime metric. > > > > Original implementation of this CL was written by eugenebut@, > > simply updated in this resurrected CL. > > > > Bug: 834116 > > Change-Id: I86c9ecf7e3ed213ebaeddce6264dff3bbb8a8c94 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815702 > > Commit-Queue: Justin Cohen <justincohen@chromium.org> > > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > > Reviewed-by: Eugene But <eugenebut@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#701228} > > TBR=rohitrao@chromium.org,justincohen@chromium.org,eugenebut@chromium.org,gambard@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 834116 > Change-Id: I16beb96bc2d1eab9a9c36a8e03728fd3cc23f035 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833743 > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701746} Change-Id: I52889208ed3a84c08c66742e72b524adce0560af Bug: 834116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833706Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#702004}
-
Tim van der Lippe authored
This issue went unnoticed because of two different CLs touching the same kind of code in unrelated parts of DevTools. It is likely that no tests covered this codepath, blocking one of the CLs from being submitted. Bug: chromium:1006759 Tbr: yangguo@chromium.org Change-Id: If3ef1d86e3ab1d887ece3372649705c96e0b0ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834144Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8d2930613094..cf0a9a628490 git log 8d2930613094..cf0a9a628490 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@cf0a9a628490 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: None Change-Id: Ic359821741312538e99e24d499d38f02f2556da0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834670Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/17fcc592..3dc289df Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I990fa92ded61f5977b00d18392ca308dfe34acf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835293Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702001}
-
Geoff Lang authored
This reverts commit c8b3d68a. Reason for revert: <INSERT REASONING HERE> Original change's description: > When binding an image to a texture, make sure the texture is bound. > > The the passthrough command decoder did deferred image bindings, it didn't > ensure that the correct GL texture was bound first. This caused canvas -> > WebGL copies to fail when they are using IOSurface backed canvases. > > BUG=990368 > TBR=true > > Change-Id: I5d555c7a715d0f47382053840c3db78576dc4e82 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819520 > Commit-Queue: Geoff Lang <geofflang@chromium.org> > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701645} TBR=zmo@chromium.org,geofflang@chromium.org,khushalsagar@chromium.org Change-Id: I0b62b0c97243c76eec8364f2e5a2220466e999e3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 990368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835193Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#702000}
-
Fredrik Söderquist authored
This test doesn't appear to be flaky any longer. Tbr: schenney@chromium.org Bug: 981522 Change-Id: I5d39dd67cec50c6e467417dca38d112660f1012d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834350Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#701999}
-
Xida Chen authored
TBR=hbos@chromium.org NOTRY=true Bug: 1010472 Change-Id: Idd6a3e1a0c13241801d93cb8956aa406b4713fbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835698Reviewed-by:
-
Arthur Hemery authored
Excluding a few extra tests that are currently failing on the android_bfcache_debug fyi bot. Bug: 1007276 Change-Id: I8f80af27b6f0deee4dff340d1e1befbdab68a315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835613 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
-
