- 25 Sep, 2019 40 commits
-
-
Finnur Thorarinsson authored
Bug: 1005572 Change-Id: Ic9979148323f55835e00fa85066d2b996ad81943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821899 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#699850}
-
Rakina Zata Amni authored
Also changes the test to use updateRendering() Bug: 1000702 Change-Id: Id679ac65da9898cff4b62b214b816884a9f9beba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824720Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#699849}
-
Stephen McGruer authored
Previously we would change the composite member, but wouldn't actually invalidate any of the (many) layers of caching we have. This meant that the changed composite mode wouldn't actually take effect. Bug: 1005915 Change-Id: I684ccb5011736edbc8b38cba5d2174095ccff9a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815608Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#699848}
-
Alex Chau authored
Change-Id: Ia86df13d10e9f9af609c71abe0afc0acb31b7c09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825600Reviewed-by:
-
Jan Krcal authored
This CL removes age watermark directive treatment from ClientTagBasedModelTypeProcessor. This is not needed as all relevant data types do expiry on their own. Bug: 877951 Change-Id: I0f7b075b57de3e6cb1ac53f4223b6289b2acd8a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821157 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#699846}
-
Gavin Williams authored
-Add a callback to check to see if a user already exists before attempting to save the user. -When user attempts to add a duplicate user show appropriate error message using conditional logic. -Right now no error message exists for an invalid email format error. Can be easily added if/when needed. Bug: 768798 Change-Id: I1231d219e09ccd4cf9177676bdbaf3ac19714c15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794272 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#699845}
-
Dana Fried authored
Method was declared but not implemented or called. Change-Id: Ia01eabfd96bb4aea46212d00e77a3215e4e086ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825637 Commit-Queue: Dana Fried <dfried@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Auto-Submit: Dana Fried <dfried@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#699844}
-
danakj authored
webwidget_ was renamed to webwidget_internal_ because there were two WebWidgets - one in RenderWidget and one in RenderViewImpl. Now there is one again, so rename it back. Update comments about lifetimes of WebWidget wrt RenderWidget and RenderViewImpl. R=avi@chromium.org Bug: 419087 Change-Id: Ib65d0bd223203109181b4e3be6a5e8f9136cd710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824289Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#699843}
-
Yue Zhang authored
Bug: 980647 Change-Id: I96012acd92ebfac6c438b682544bb1fc5931eaf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817330 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#699842}
-
Mohsen Izadi authored
Since r699788, OzonePlatform::AfterSandboxEntry() should not be called when ozone is single-process. BUG=998113 TEST=./video_decode_accelerator_tests on eve Change-Id: Ib4432dd82d92630f19e9d3e75730e8e25440c757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825298 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#699841}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f2723363e181..09aa96cf69bd Created with: gclient setdep -r src-internal@09aa96cf69bd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None,chromium:None Change-Id: Ic54c5eaec2f3c471b84ddef261760e6a959b56c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824287Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699840}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6abaff3041a3..c712e962b647 git log 6abaff3041a3..c712e962b647 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 mtklein@google.com poor man's contention profiler Created with: gclient setdep -r src/third_party/skia@c712e962b647 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: None Change-Id: I527d242ad7fa26bf7adaa4eb41859fe7929a79f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825377Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699839}
-
Eric Roman authored
The latest code optimizes IsCapturing() making polling through a timer harmful. Tested on x64, however should be similar for Arm. Bug: 1006900, 1007502 Change-Id: I6013090a230e42abc60b7db32c44d27e8fa7d0ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821860Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#699838}
-
James Cook authored
Ensure the app window is at least 200x100 DIPs, which ensures the user can see the "Settings" label in the top-left corner. Bug: 1001466 Test: added to browser_tests Change-Id: If2edeb232b07f4fb294b862143891c8ec0d124dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815905 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#699837}
-
Nikita Podguzov authored
This CL doesn't contain any API tests. These will be added in follow-up CLs. Bug: 992889 Change-Id: I2a3ce22c42a1c656e68ba377df52540ce17c17a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798702 Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
-
Brandon Goddard authored
This reverts commit e0645533. Reason for revert: Memory tool fails to take heap snapshots with this error: https://imgur.com/hzR9Eqw Original change's description: > [DevTools]: Moves common to ES modules > > This CL converts the contents of the common/ folder over to ES modules > from the current custom module system. It includes statements in each > file that will pollute the global namespace, allowing the non-ESM code > to continue working as before. > > Bug: 1006759 > Change-Id: Ib591e49155000381f85999a5da6c467ad0160996 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816563 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Paul Lewis <aerotwist@chromium.org> > Cr-Commit-Position: refs/heads/master@{#699728} TBR=yangguo@chromium.org,aerotwist@chromium.org,tvanderlippe@chromium.org Change-Id: Ic0d526780451e8bb4de538f11c85859a3badfb0f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1006759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825463 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#699835}
-
Yun Liu authored
Coverage was off for module_installer_java because of crbug/965606 Specifically, ModuleInstaller.java caused different files with same package and class name. As this issue was resolved, coverage can turn on now. Bug: 843307 Change-Id: I91080b9a5b9c29bb2444dc1591d6877f4aad9f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819862Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Fred Mello <fredmello@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#699834}
-
Mohamed Heikal authored
trybot_commit_size_checker.py outputs a json dict to be used by the gerrit binary size plugin. This cl changes some text as well as adds what the actual limits are for the metrics being measured so that they are displayed to the user. Bug: 921090 Change-Id: Ifbfc7d19e6d3de1d099875f48973fa0520bcd80b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819970 Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#699833}
-
Mustafa Emre Acer authored
This CL changes the title, header text, and the primary action button. Screenshot: https://drive.google.com/file/d/1SdjbX8Jd7pEB0PDYDh_jAGEmmk5s7law/view?usp=sharing Bug: 1006867 Change-Id: Ibe3a98d59b598efd930ed20d6d92a44702860770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824027 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#699832}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7e19ed73. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: iclelland@chromium.org: external/wpt/feature-policy timvolodine@chromium.org: external/wpt/battery-status NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I2c7c033a4618be2fd1a3a42a80617bc9c644c4c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824253Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699831}
-
Alex Keng authored
The change shrinks the size of the chevron of <select> based on the latest design. Bug: 1001577 Change-Id: I8edcee70a42bfbf13ab9c80a183764951251828f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820013 Commit-Queue: Alex Keng <shihken@microsoft.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#699830}
-
Gabriel Charette authored
As discussed @ https://crbug.com/878356#c39 R=thestig@chromium.org Bug: 878356 Change-Id: I7f9df5e84384c4f0c61a4ac02624fec54e6d9a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822419Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#699829}
-
Thomas Tangl authored
- To reduce conversions from gfx::ImageSkia to gfx::Image - To make image parameters of the ProfileMenuViewBase API consistent Bug: 995720 Change-Id: I4230d93714a6cf0b6d01bcfef574e5159e983e40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825337 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#699828}
-
sczs authored
Creates Strings needed for Rubberband action sheet per: https://bugs.chromium.org/p/chromium/issues/detail?id=980037#c10 Bug: 1006304 Change-Id: I421372e09285804acce07540099f79d15646d491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816746Reviewed-by:
-
Lily Chen authored
This change causes |attach_same_site_cookies|, which is used for requests initiated by extensions, always attach SameSite cookies (as the name implies). Previously, it would only attach SameSite cookies if the request context was Lax or better, which would cause cross-site requests (i.e. most requests initiated by extensions) to exclude SameSite cookies. Bug: 1007973 Change-Id: Ic5d04df3915e812b743bad8b44efff30fd2de795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824553Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#699826}
-
Sebastien Lalancette authored
This reverts commit 147e1d3b. Reason for revert: compare_build_artifacts step is flaky on Windows deterministic builder. File that failed diff check: ppapi_nacl_tests_pnacl_newlib_x64.nexe (Linux looks good though.) Original change's description: > Remove using directives ("using namespace x") from ppapi/, take 2. > > Testing to see if this route avoids breaking the Linux Deterministic bot. > > TBR=bbudge > > Bug: 82078 > Change-Id: I1512141cc886dafa6683f5ff38c6a50f35be067a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818998 > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698817} TBR=pkasting@chromium.org,bbudge@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1007979 Change-Id: I6b24cc229ac48f5838b230b74d5022a34e1c6415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824673Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#699825}
-
Thanh Nguyen authored
This CL adds more support functions for FuzzyTokenizedStringMatch and finalizes the implementation of WeightedRatio. Bug: 990684 Change-Id: I4d9632d42f391085a654d92ec450a51c31db5b26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807638Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#699824}
-
Stephen Nusko authored
This ensures that all processes are available for tracing since the data sources will be registered. Before only the browser process registered data sources, and thus you had to run a local trace before a system trace to get data from the renderer. This fixes that so all processes will register the TraceEvent and TraceSampler data sources (TraceMetadata remains browser only). Since the trace processor doesn't support proto traces yet I can't write an integration tests for this behaviour change. Bug: 979576,1007275 Change-Id: Ibb5aed2725ed2eae3672a3fddd5a31db7804f247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821602Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#699823}
-
Anastasia Helfinstein authored
The Switch Access menu currently contains a button to activate dictation. However, if the user has not already enabled the feature, the button does nothing. This change has Switch Access enable dictation when activated. If they used dictation previously, it enables and activates immediately. If they have not used dictation before, it opens a confirmation dialog. Bug: None Change-Id: I981ba4666a89909055d27996e256d6ca8a89aa13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824318 Commit-Queue: David Tseng <dtseng@chromium.org> Auto-Submit: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#699822}
-
Rahul Arakeri authored
This CL implements shift + click on a composited scrollbar. The idea here is that when user does shift click, the scroller needs to do a non animated scroll to that location. This is done by first calculating the pointer co-ordinates relative to the scrollbar and then, by using the current pointer's location as the mid-point of the thumb, we can determine the "desired" location of the parent scroller (such that the thumb ends up centered on the pointer). Bug: 999577 Change-Id: Id9823945de33eba510f11fe614ef497590e1aff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810255 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#699821}
-
Julie Jeongeun Kim authored
This CL converts PagePtr and PageRequest to new Mojo types using PendingRemote or Remote and PendingReceiver. Bug: 955171 Change-Id: Ia33151c7f0e8324e3bf6dab853fc6d22b98e4584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816243Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
-
Matthias Körber authored
Change-Id: If34a5e85087efd2822d6bf9e91f30983f548d5ee Bug: 875768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824086Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#699819}
-
Karolina Soltys authored
This is a reland of a689aa50 Bug: 872236 Change-Id: I6ab54fe95459c294358913bf6a78a6a73e8cb449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787606 Commit-Queue: Karolina Soltys <ksolt@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Auto-Submit: Karolina Soltys <ksolt@chromium.org> Cr-Commit-Position: refs/heads/master@{#699818}
-
Yasmin authored
Shared Clipboard feature is available in Win, Mac, Linux, Android and ChromeOS. The default value for this policy should be True. It's up to the admins to make sure this value is set consistently across all platforms. Bug: 1005288 Change-Id: Ida556ccf633aa4cedc62d46cfe35ffa3123bc77b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819443Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#699817}
-
Henrique Nakashima authored
Leaving a dummy build target back so that clank dependencies on chrome/lib/util don't break. Will remove them and then delete the dummy target. Bug: 995916 Change-Id: I9842f4f74f7035718d16d79d0469c52b09cc37f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804036 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#699816}
-
Matthias Körber authored
Change-Id: I37bd0562cd3b66147764c4edbe6c0c5d9c0ea52d Bug: 875768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824892 Auto-Submit: Matthias Körber <koerber@google.com> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
-
Thomas Tangl authored
...depending on the sync state. Screenshot: https://drive.google.com/file/d/1npd-N8-jGzMws9PtzpKZYyXrpeyGCRzj/view?usp=sharing Bug: 995720 Change-Id: I47a3df36c5051526dec03616871a4ba01eadfcad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823869 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
-
Michael Thiessen authored
No functional changes intended, please revert if things break. This function is a large, and hard to follow. I'm hoping to break out a bunch of functions that are clearer about what they're doing and make ordering clearer. Bug: 1006927 Change-Id: Id5a263f1e0a26a443091f54a3cd6e6f86919e854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821965 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#699813}
-
Chris Lu authored
This replaces accepted state properties in badges with a new BadgeState enum. This will allow for more states to be added that help the UI to handle more complex arrangements such as temporarily showing a badge whose banner is presenting when there are multiple badges. When BadgeItems are initialized, they will take a BadgeStateNone state for now. It will likely change as more states are added. Bug: 976901 Change-Id: I0eb0755cbf4fd41cd883aecc10a767d781af70d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810766 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#699812}
-
John Emau authored
All usages of markAsDialog also mark the element as a modal making all usages modal dialogs. Change-Id: Ie8c407475a75ac9d569ac00d2b782de96dcd573c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704585 Commit-Queue: John Emau <johnemau@microsoft.com> Reviewed-by:
-
