- 20 Mar, 2020 40 commits
-
-
Mario Sanchez Prada authored
Create a dedicated method in content::mojom::RenderAccessibility to perform hit testing over an accessibility object that expects a reply that might include the required information to perform another hit testing, if a child frame was found to exist at the especified point. By doing this we can remove the HandleAXChildFrameHitTestResult() method, previously added to content::mojom::RenderAccessibilityHost, and fix the current situation where a message from an untrusted renderer would be sent to the browser when a child frame is found, since now such information would be shared as a reply to the original HitTest() method invoked from the browser process. Bug: 1010831, 1060223 Change-Id: I5b60d8a5e4b9f7fb2fc658c4f9156d7721b38db9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105217Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#752001}
-
Elly Fong-Jones authored
This change: 1) Moves the bulk of CocoaTest to a separate class, CocoaTestHelper, that can be held as a member 2) Removes CocoaTest::Init, which was misnamed and mostly unused, and replaces it with MarkCurrentWindowsAsInitial for the one use case that does need it 3) Removes a lot of testing macros from the CocoaTest header since they are either unused or only used in a single place 4) Also creates a //chrome CocoaTestHelper analog that bootstraps the Cocoa app bundle, for use in tests that need Cocoa but don't inherit from CocoaTest (eg because they inherit from another fixture) Bug: 39725 Change-Id: I463480fbdbe4942561269478dc2f396db8ea8fb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107766Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#752000}
-
Denis Kuznetsov authored
Bug: 955194 Change-Id: I39b6c4c28ce1ee69f078b3875308b6ca486f749e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110871Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#751999}
-
Mikhail Khokhlov authored
Change-Id: Ia2333c6856de7e9bb8ff1ddd26fba3d0af62d6f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112358Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#751998}
-
Luciano Pacheco authored
Use requestAnimationFrame() to change the CSS to collapsed the search box to give the chance for the button to process the collapse at the click. Add a test so we don't regress on this again. Test: browser_tests --gtest_filter="*searchButtonToggles*" Bug: 1062148 Change-Id: I628fb0b22f0a0223d659743618e7077ff0a7007d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112171 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#751997}
-
Elly Fong-Jones authored
This change removes the last BubbleDelegate subclass in //chrome. Specifically: 1) ChooserBubbleUiViewDelegate is now a subclass of LocationBarBubbleDelegateView, so that it will close on cross-origin navigations and fullscreen transitions; this behavior was previously provided by ChromeBubbleManager 2) ChooserBubbleUi is now removed, along with all references to it The next steps in this refactor are: 1) Removing the now-dead ChromeBubbleManager and all references to it 2) Removing BubbleUi itself, since ChromeBubbleManager is the last reference to it Bug: 496955 Change-Id: I558cecf89dee6c1dce987a678e2f25805f6f1f82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109972 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#751996}
-
Mugdha Lakhani authored
A delegate interface PageInfoDelegate has been introduced to allow the embedder to customize PageInfo. ChromePageInfoDelegate is Chrome's implementation of it. There will be follow up work to clean up chrome dependencies from PageInfo, after which, PageInfo can be moved to components. Bug: 1052375 Change-Id: I9b2ac5811ede505171787f23120cc46927e90f4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089710 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#751995}
-
Ben Joyce authored
This is a reland of: https://chromium-review.googlesource.com/c/chromium/src/+/2064823 After it was reverted: https://chromium-review.googlesource.com/c/chromium/src/+/2079147 This was caused by needing a new .info file because of breakage on https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/9669 . Apparently the uploaded .info file had an extra newline character. Bug: 1005891,1054152 Change-Id: Ibe273671811a7e772b4a6a5dbafcf5ec97c0b820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079436Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Auto-Submit: benjamin joyce <bjoyce@google.com> Cr-Commit-Position: refs/heads/master@{#751994}
-
Brian White authored
Also converted all other calls from macros to functions which is the recommended method for any histogram emitted more than 1 per second or so. Bug: 1053105 Change-Id: Id9af6e33098de961f5e8cebf334615a12a0602e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108802 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#751993}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I1bc03528cd22546c780b61002c290f23028b89aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112511Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751992}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/03867b5533b7..e3bc20cd8816 git log 03867b5533b7..e3bc20cd8816 --date=short --first-parent --format='%ad %ae %s' 2020-03-20 tvanderlippe@chromium.org Typecheck workspace/ with TypeScript Created with: gclient setdep -r src/third_party/devtools-frontend/src@e3bc20cd8816 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1061125 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib8374b36058e90db87b36ccaf49fb3c3a1ace14b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112405Reviewed-by:
-
Stephen McGruer authored
According to FlakePortal[0] and the legacy dashboard[1] this hasn't flaked since 2019/09/09. It seems worth attempting to renable it. [0]: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVybwsSBUZsYWtlImRjaHJvbWl1bUBibGlua193ZWJfdGVzdHNfZXhwYXJjaGl2ZUBleHRlcm5hbC93cHQvY3NzL2Nzcy1tYXNraW5nL2NsaXAtcGF0aC9jbGlwLXBhdGgtaW5saW5lLTAwMS5odG1sDA [1]: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests%20(with%20patch)&tests=external/wpt/css/css-masking/clip-path/clip-path-inline-001.html Bug: 1001936 Change-Id: I85bbf8ec315c708244d42f9793d598865ad196f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110218Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#751990}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic6127a4255dbb7852234f90a28c102f537a60cd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112403Reviewed-by:
-
Demetrios Papadopoulos authored
It was previously failing because it was asserting on the value of a cr-link-row's sublabel before it was actually updated in the prod code. Introducing a 'site-settings-list-labels-updated-for-testing' event to give a singal on the test code on when to assert fixes the issue. Bug: 1061249 Change-Id: Ia9c31229da79ac83acb38254ccee053b26f3ec1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111778 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#751988}
-
Anatoliy Potapchuk authored
This reverts commit cf2d38fa. Reason for revert: let's have it in. Original change's description: > Revert "Reland "[Ash] Simplify AccessibilityControllerImpl to remove duplications"" > > This reverts commit 181c9ba9. > > Reason for revert: reland by mistake, will reland it together with the fix > > Original change's description: > > Reland "[Ash] Simplify AccessibilityControllerImpl to remove duplications" > > > > This reverts commit 812f314f. > > > > Reason for revert: culprit found > > > > Original change's description: > > > Revert "[Ash] Simplify AccessibilityControllerImpl to remove duplications" > > > > > > This reverts commit 2f2a33d5. > > > > > > Reason for revert: <INSERT REASONING HERE> > > > It looks like this CL breaks some test case > > > https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/18262?blamelist=1#blamelist-tab > > > https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8885542762262570176/+/steps/exo_unittests/0/logs/Deterministic_failure:_All__x2f_SurfaceTest.AcquireFence__x2f_0__status_CRASH_/0 > > > > > > > > > Original change's description: > > > > [Ash] Simplify AccessibilityControllerImpl to remove duplications > > > > > > > > AccessibilityControllerImpl had a lot of duplications. Let's fix that. > > > > Also, now it controls fullscreen and docked magnifiers. Before that, > > > > we have to go AccessibilityDelegate and MagnificationManager to do > > > > this. > > > > > > > > Change-Id: I6a5d827ded2a88a56eb173fed67e010aa002070d > > > > Bug: 1051892 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050688 > > > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > > > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > > > > Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#751086} > > > > > > TBR=xiyuan@chromium.org,dmazzoni@chromium.org,nektar@chromium.org,apotapchuk@chromium.org,burunduk@chromium.org,amraboelkher@google.com > > > > > > Change-Id: Ifbd8e25594790d7417af06c84651d3837ad17b5d > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 1051892 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107028 > > > Reviewed-by: Nancy Wang <nancylingwang@chromium.org> > > > Commit-Queue: Nancy Wang <nancylingwang@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#751181} > > > > TBR=xiyuan@chromium.org,dmazzoni@chromium.org,nektar@chromium.org,apotapchuk@chromium.org,burunduk@chromium.org,amraboelkher@google.com,nancylingwang@chromium.org > > > > Change-Id: If1d69e1f28c1e850c55c038ea7138c75da9ea885 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1051892 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107545 > > Reviewed-by: Anatoliy Potapchuk <apotapchuk@chromium.org> > > Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#751188} > > TBR=xiyuan@chromium.org,dmazzoni@chromium.org,nektar@chromium.org,apotapchuk@chromium.org,burunduk@chromium.org,amraboelkher@google.com,nancylingwang@chromium.org > > Change-Id: I382410f4fabc53c4ae5045310b22b729d5ec6cc7 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1051892 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107546 > Reviewed-by: Anatoliy Potapchuk <apotapchuk@chromium.org> > Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751189} TBR=xiyuan@chromium.org,dmazzoni@chromium.org,nektar@chromium.org,apotapchuk@chromium.org,burunduk@chromium.org,amraboelkher@google.com,nancylingwang@chromium.org Change-Id: I3143d661b24e4995161cd358b0a778562b292539 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1051892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108544Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#751987}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/02c1ddad..a0199a91 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ica0b20de175c18f1d3e0608b2594ea5734bcfd29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111574Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751986}
-
Noel Gordon authored
I believe "gear-menu" becomes before "install_linux_package_dialog" so be consistent with alpha-ordering in this BUILD.gn file. I was about to put "focus_visibilty.js" in this file, until I realized I don't need that file anymore, but it would have been adjacent to the gear_menu rule, from which I noted this minor alpha-order-disorder. Tbr: alex, lucmult Bug: Consult a dictionary. Change-Id: I84404d9c20054634552f1b9ed03e866594e27652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111514Reviewed-by:
-
Mark Brand authored
This adds the standalone code for MojoLPM; it's not functional by itself but it is a dependency for the generated code. This is a cherrypick/split from https://chromium-review.googlesource.com/c/chromium/src/+/2108507 Change-Id: I71deba7182adc31acde2546b42808a959a87b8a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109698Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Mark Brand <markbrand@google.com> Cr-Commit-Position: refs/heads/master@{#751984}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/005d0fff3b9c..835dde17a0c9 git log 005d0fff3b9c..835dde17a0c9 --date=short --first-parent --format='%ad %ae %s' 2020-03-20 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 578730be..2a41e24b (751777:751948) Created with: gclient setdep -r src/third_party/webrtc@835dde17a0c9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib84096f51a79c6626942ac79d5aea4ae21c51085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112398Reviewed-by:
-
Stepan Khapugin authored
Instead of using deferred initialization, show the account selector when a scene becomes active. This means if there are multiple scenes, the user will always have to go through this dialog even if they switch to another window. Also completely get rid of AppNavigation, as it's not used anymore. Bug: 1045663 Change-Id: Idbbd19f1e188b033e39ce318def6b1338ad3ac6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107581 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#751982}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bf995d913927..4432f93ff194 Created with: gclient setdep -r src-internal@4432f93ff194 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:995903 Tbr: jbudorick@google.com Change-Id: I92854a65d4fcb54abddc6f00ab1e62d86135f4b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112392Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751981}
-
Karandeep Bhatia authored
Currently the ruleset checksum for each extension using the declarativeNetRequest API is stored as an entry corresponding to the "dnr_ruleset_checksum" or "dnr_dynamic_ruleset_checksum" key. This CL replaces them with the "dnr_static_ruleset" and "dnr_dynamic_ruleset" keys respectively, corresponding to which we store a dictionary mapping ruleset IDs to their prefs. The prefs for each ruleset is a dictionary storing just the ruleset checksum for now. This CL helps move the code away from the assumption of a single static ruleset and will aid in the transition towards multiple static rulesets. A side effect of this change is that existing extensions using declarativeNetRequest will fail to load their rulesets with an install warning. Users will have to reinstall the extension. However that's ok given that the API is only in beta and has seen limited usage as of now. BUG=754526 Change-Id: Iaa77fca18322320dea4c7b02b0b9d6edea123975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103547 Commit-Queue: Sergey Poromov <poromov@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#751980}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0e069b42b334..12a1c373822e git log 0e069b42b334..12a1c373822e --date=short --first-parent --format='%ad %ae %s' 2020-03-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 18d3896a15fc..60104cd97446 (2 commits) 2020-03-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader bc98fbeec99b..1c9f24263e6c (2 commits) Created with: gclient setdep -r src/third_party/angle@12a1c373822e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: I8c62e29a53fece57d300cf9e765399459c635ffd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112394Reviewed-by:
-
Nico Weber authored
(But not in use_libfuzzer builds.) Suppress the last few issues. This doesn't always go for the nicest fix for now, but instead for the simplest behavior-preserving change. The hope is to get this in while the codebase builds with the warning on, to make sure that no new regressions land. I'll then clean things up a bit on linux (e.g. make nice conversion functions for skia to libyuv and libpng color formats), and gradually enable on androidchromeosfuchsiaiosmacwindows in follow-ups. Bug: 346399 Change-Id: Ic920d3b63ac83aa59c2bf862f60662196d0b28e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093537 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#751978}
-
Jinsuk Kim authored
For some of the callsites of TabImpl.getActivity(), what they actually need is not ChromeActivity, but either Context or Activity. This CL replaces them with Tab.getContext(). TabImpl.getActivity() and Tab.getContext() is different in that the former returns null if the tab is not attached to ChromeActivity (or not attached at all) while the latter returns the application context for such case. The callsites updated in this CL are not affected by the difference due to one of following reasons: - a null check to see if the tab is detached is already in place (ModuleInstallUi) - it is okay to proceed with the application context (ContextualSearchTabHelper - works for ChromeActivity only. For non-ChromeActivity, its scaleFactor could be set wrongly but CS won't be activated anyway) - getActivity() is always returning a non-null activity i.e. Tab.getContext() returns activity contenxt (LayerTitleCache, ExploreSitesPage, SurveyInfoBar, PictureInPictureActivity, TabParentIntent, ArConteInstallUtils) - a null check was added newly to check if the tab is in the detached state (AddToHomescreenInstaller - it is used by ChromeActivity-inherited activity only, therefore TabImpl.getActivity() returning null due to the tab being attached to non-ChromeActivity won't happen). Bug: 995903 Change-Id: I763787c57db62e3af61ee7f88bf172b1b93c45ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109392 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#751977}
-
Jan Wilken Dörrie authored
This change modifies StartPasswordCheck to wait for the initialization of the PasswordCheckDelegate, which requires waiting for the initial response from the PasswordStore. In order to support this async API, the method now takes a callback, rather than synchronously returning a value. Bug: 1062985 Change-Id: I878bade15d06d1a564836566898a3d748fe82590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110230 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#751976}
-
Side Yilmaz authored
|Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates ConsentAuditorBridge class. Note: This change is only code clean-up, does not change any behavior. Bug: 1041781 Change-Id: I5b4908a03d576ebfccfeb83bae4ac84baf455daa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107488Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#751975}
-
Fredrik Söderqvist authored
* Const qualify referenced objects (SVGPreserveAspectRatio, TreeScope). * Have ReferencedLayoutObject() return a const LayoutObject. * Rearrange the code in FEImage::MapInputs() and CreateImageFilter() to get the same general structure (element reference, external image, failure). * Reorder PaintRecord recording in CreateImageFilterForLayoutObject(). * Mark local helper MakeMapBetweenRects() static. Split out "magic viewport"-mapping into a helper function. * Use DynamicTo<>() where applicable. Change-Id: If9fe1cf076257cd680c05bb1c97e14ab2fe7c1c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110013 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
-
David Jean authored
Bug: 1045455 Change-Id: I8e72c9466ae00d87141c4fcea30ee817a1fbfb55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106166 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#751973}
-
Tanmoy Mollik authored
This cl removes ChromeSigninController code from the ClearBrowsingDataFragmentBasic and cleans up a test for it. Bug: 1049540, 1051000 Change-Id: Iaa8feb9a7f951f147a484e520462a90570c650a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044111 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Reviewed-by:
-
Vadym Doroshenko authored
This reverts commit 39bb3cd1. Reason for revert: It looks it breaks test CrSettingsPasswordsCheckTest.All on Windows https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29 Original change's description: > [Passwords] No result view fix in password check > > This CL changes the way visibility of 'No result view' is calculated. > The label will be shown only if: > - user had successful check with 0 compromised passwords found > - user is signed in > - breach detection is turned on in settings > > Bug: 1061496 > Change-Id: I9f1e4b5f7aef51749b970964c2b701ee2193ba53 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108501 > Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751674} TBR=jdoerrie@chromium.org,vsemeniuk@google.com Change-Id: I20479f59c5a3e97c2f8d70a3a96179faff861624 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1061496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111294Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#751971}
-
Rohit Agarwal authored
We currently don't have extensive tests on java side which checks any leakage of data across activities. This CL adds browser tests to check browsing and navigation history leaks. Browsing history leaks are checked from incognito to regular mode. Navigation history leaks are checked across all tabbed and CCT activity types. Bug: 1035770 Change-Id: Ideb21008b901b0e1297d2a845602e7a9865b9b24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096641Reviewed-by:
Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/7c24b6b2ff19..69c5dd70e796 git log 7c24b6b2ff19..69c5dd70e796 --date=short --first-parent --format='%ad %ae %s' 2020-03-20 cwallez@chromium.org Fix depth-only render pipeline creation on Metal. Created with: gclient setdep -r src/third_party/dawn@69c5dd70e796 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I0a5b4e7e9b57657f3131eec9ed876b8c48964a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112393Reviewed-by:
-
Vadym Doroshenko authored
This reverts commit 034be017. Reason for revert: it looks that it breaks tests: OutOfProcessPPAPITest.BrowserFont FontList.GetFontList FontList.GetFontListDoesNotIncludeHiddenFonts https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/52253?blamelist=1#blamelist-tab Original change's description: > fonts: Use Core Text in macOS version of GetFontList_SlowBlocking(). > > Bug: 1062925 > Change-Id: I075bd135bf334f511480bcdccd04e91f99ad54ea > Tested: Compared old and new output on macOS 10.15.3, via DLOGs. > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104102 > Commit-Queue: Victor Costan <pwnall@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Dominik Röttsches <drott@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751919} TBR=drott@chromium.org,rsesek@chromium.org,pwnall@chromium.org Change-Id: I10c8098f5d2b361a5aacd69c562fd15f372169c2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1062925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111093Reviewed-by:
-
Mark Cogan authored
This CL is the eighth in a series of changes needed to complete this refactor: 1. (crrev.com/c/2089687) Add a new provider API upstream that passes both a Browser and temporary URL loading shim to CreateLogoVendor. 2. Implement this new API downstream and add support for initializing the LogoController with both Browser and the loading shim. Use the loading shim for loading URLs if it is present. 3. (crrev.com/c/2089785) Upstream, call the new CreateLogoVendor() API. 4. Downstream, remove support for the old CreateLogoVendor() API and update LogoController to only be initialized with a Browser and the shim loader. Remove downstream use of the URLLoadingService. 5. (crrev.com/c/2105314) Upstream, refactor URLLoadingService to be URLLoadingBrowserAgent, updating the upstream implementation of the loading shim passed downstream in CreateLogoVendor(). 6. (crrev.com/c/2106182) Upstream, add a new provider API that no longer passes the loading shim into CreateLogoVendor(). Delete the now- unused provider API that was removed downstream in step 4. 7. Downstream, remove use of the loading shim from LogoController and have it fetch the URLLoadingBrowserAgent from its Browser parameter. Implement the new shim-less CreateLogoVendor() API. Have the old shimmed API call the new shimless one. 8. Upstream, call only the new shimless API. Remove the shim implemen- tation in calling code. 9. Downstream, remove the shimmed API. 10.Upstream, remove the shimmed API, including the shim definition. Specifically, this CL removes the implementation of the URLLoadingBridge protocol in ContentSuggestionsCoordinator, and has it call the bridge- less CreateLogoVendor() API. Bug: 1046374 Change-Id: I071659526f5e54842ed865ad4cfb8d04f3b788b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106578 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#751967}
-
Mikel Astiz authored
In the error-handling codepath where a mismatch is found on the cache GUID, when sync is starting for Nigori, the new cache GUID should be stored in the ModelTypeState. Otherwise, it would remain empty, which means the next sync start the mismatch detection doesn't take place. This can explain cache-GUID mismatches being ignored, and bad consequences such as violating the sync protocol by sending a non-empty progress marker despite the sync birthday being empty. Change-Id: I48d4b35a61dd20f56c416779bee686e1d582606d Bug: 1063021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111090 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#751966}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/362becca1ff2..eb7bd643ef43 git log 362becca1ff2..eb7bd643ef43 --date=short --first-parent --format='%ad %ae %s' 2020-03-20 jiawei.shao@intel.com Extract texture dimension for storage textures (#1008) Created with: gclient setdep -r src/third_party/shaderc/src@eb7bd643ef43 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I754b3ada297d6b2496222fba2151f316e1371c27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112391Reviewed-by:
-
Felipe Andrade authored
The AuthpolicyErrorType UMA enum was missing the value ERROR_OU_CONSTRAINT_VIOLATION, in order to match the ErrorType message defined in active_directory_info.proto. Bug: 1063026 Change-Id: Id0b36a8a43d5e02bf9d3d360e93c11f713820b0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109702Reviewed-by:
-
Alex Danilo authored
The action icon buttons and open button have an active color when the menu is shown - suppresses the background color on hover when the 'menu-shown' attribute is set. Add a TODO about the placement of :focus. Bug: 1061819 Change-Id: I70cc84784f1e8025f2dcc064c3ce52ca936add66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111513 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
TBR=kojii@chromium.org Change-Id: I1ec54bfce0e20ee267808575f49a1f3842805f6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111672Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#751962}
-
