- 09 Dec, 2020 40 commits
-
-
Thiemo Nagel authored
This reverts commit 258f8486. Reason for revert: failure in browser_tests/TabStripTabListTest.All As unlikely as it looks (to me), I've bisected test failure to this CL Builder Linux Tests (dbg)(1): https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29 Original change's description: > IO: Use pre-margin target rect for an empty check for intersection threshold > > This patch ensures that we use a pre-margin version of the target rect > if we are checking whether it was empty. This is to make sure that we > compute a "1" intersection ratio in cases where an ancestor of a > margin-padded target causes it to be empty. > > In this case, we should report 1 intersection, because we are intersecting > and target is an empty rect. However, because we padded the target > with a margin, we ended up doing the wrong check and ultimately compute > 0 intersection in a different conditional branch (before this patch). > > This patch restores correct behavior. > > R=szager@chromium.org, chrishtr@chromium.org > Fixed: 1156815 > > Change-Id: I1697388dd127737a0203d1c3ff15095de4ab41df > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580046 > Reviewed-by: Stefan Zager <szager@chromium.org> > Commit-Queue: vmpstr <vmpstr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#834930} TBR=szager@chromium.org,vmpstr@chromium.org,chrishtr@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Idf7927cbd535d91db51da4f3f97280c2359e9b97 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582059Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#835216}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607471901-d1b17db4d547397f57796df9fcd9057f4117af9e.profdata to chrome-win64-master-1607493425-f89e2101ace78ecc71e64b80849cb2e4ad48ac79.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I49ca1de91d840636e22a293415660b15756943e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581407Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835215}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5e744acfad58..8670c9887529 2020-12-09 bsalomon@google.com Remove SkImage::MakeFromYUVATexturesCopyToExternal If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jmbetancourt@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jmbetancourt@google.com Change-Id: Ib5c69c877655b8e1e5479140b1954fbc76147d6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581881Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/30805557e651..99d6c14a3b34 2020-12-09 cwallez@chromium.org CMake: set DAWN_ENABLE_WGSL to ON by default. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: I65429f8b7174b593364bf12104db67cbe7d9ca6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582000Reviewed-by:
-
arthursonzogni authored
From the browser process point of view: - javascript-url document. - XSLT document. - document.open document. Are all a no-op. (e.g. no IPC sent to the browser process). The security properties of the document shouldn't change. There was a bug about sandbox_flags inheritance and javascript-url. We weren't inheriting from the right flags. Bug: 1151954 Change-Id: I7dc3cdfff4eaa8d0db02a2aaab6963a6aa3c8ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577211Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#835212}
-
Clemens Arbesser authored
This fixes a bug where the trigger prompt would stay visible in non-interactable tabs (such as during tab selection). To keep things simple, changing from interactable to non-interactable and vice-versa is treated the same as a change to a tab's visibility. Trigger scripts will now only be offered if a tab is both visible and interactable. Bug: b/175132318 Change-Id: Ie25831ecd16220e351ec1cc231fda470d34873dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579784Reviewed-by:
Michele Mancina <micantox@google.com> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#835211}
-
Jan Wilken Dörrie authored
This change replaces mentions of Blacklist with Blocklist in CredentialCache and OriginCredentialStore. Bug: 1147799 Change-Id: I3aa875d0bd6c2e54039202348435576da86af4f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579794Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#835210}
-
Sahir Vellani authored
Through experimentation, it is found that enabling SmoothnessModeForAnimatedScrolls results in an improvement in scroll latency but a regression in throughput. To investigate this, we are enabling this feature on the bots so that benchmark traces can be collected. Bug: 1056460 Change-Id: I46845f214b6524f92f2329abc0d8c60e3d6413d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574956Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Cr-Commit-Position: refs/heads/master@{#835209}
-
Liquan (Max) Gu authored
Since Chrome is moving away for having UI code depend on ChromeActivity, this CL replaces some ChromeActivity use cases with Context. Bug: 1155788 Change-Id: I3cdf464758e0b639cd1edec26fb00ddfbd27bc6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579726 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#835208}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d19d663924f1..4c1463884785 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tnagel@google.com,anthonyvd@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tnagel@google.com,anthonyvd@google.com Change-Id: Iff397fbc0af138a2f8ffd2400dc2aab498ab6b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581898Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835207}
-
Michael Savigny authored
Adds 'checkout_reclient' and 'reclient_version' to the vars to check for consistency between DEPS and buildtools/DEPS. Bug: 1149386 Change-Id: I708ba052914dc7bda6f38f1dd4198d859318b970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579809 Commit-Queue: Michael Savigny <msavigny@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#835206}
-
Mihai Sardarescu authored
When the user clicks on "Cancel" on the sync confirmation dialog, only the sync consent is revoked (the primary acount is *not* cleared), so it naming the corresponding enum entry ABORT_SYNC instead of ABORT_SIGNIN is more accurate. Bug: 1155505 Change-Id: Ibc032c1c7f7e9b5493cdb1f8b4f996152f9d7f8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578842 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#835205}
-
Ilya Sherman authored
R=chromium-metrics-reviews@google.com Bug: 954310 Change-Id: I4a612300989a1aee0ed03ab859e0a132ac91ff0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581518 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Auto-Submit: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#835204}
-
Benoit Lize authored
This is possibly the cause of browser process crashes on Windows. Disable it only on this platform to ease investigation. Bug: 1155905 Change-Id: I6a5330479cb701c4b74da1986c2620d41056960c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582018Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#835203}
-
Maria Kazinova authored
VotesUploader uploades password votes on form submission. These votes are used to generate server predictions that are requested and received on the pageload. Thus if the form is changed dynamically, it makes sense to send votes for the form signature that is seen on the pageload. This CL starts using initial form signatures instead of signatures seen at the moment of submission. Bug: 1157048 Change-Id: I13f51852c2b9447625ae6d20cd335e481dcab4e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578900Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#835202}
-
Caitlin Fischer authored
This partially reverts crrev.com/c/2247706 and crrev.com/c/2245049. A couple of the Android tests that were ported to chrome/browser/metrics/ukm_browsertest.cc are flaky. Temporarily re-adding this test file ensures we have coverage while we fix the tests. The tests being re-added are consentAddedButNoSyncCheck and singleSyncSignoutCheck. Also, note that mSyncTestRule.startMainActivityOnBlankPage(); is being removed from setUp() because this is done before setUp() here [1]. Calling startMainActivityOnBlankPage() twice, once via SyncTestRule and again via setUp(), results in a TimeoutException [2] the second time startMainActivityOnBlankPage() is called. A log is in [3]. [1] https://source.chromium.org/chromium/chromium/src/+/master:chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTestRule.java;l=358 [2] java.lang.RuntimeException: java.util.concurrent.TimeoutException: No Activity reached target state. [3] https://paste.googleplex.com/6459114528964608 Original change's description: > Remove a UKM test that should have been deleted. > > In the below comment, it was requested that the corresponding Android > test be removed. > https://chromium-review.googlesource.com/c/chromium/src/+/1869007/12/chrome/browser/metrics/ukm_browsertest.cc#b646 > > Bug: 1049736 > Change-Id: Iac3ff27fc4d8145bef53d45aecb54efeda5e55f6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245049 > Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779285} TBR=rkaplow@chromium.org,treib@chromium.org,caitlinfischer@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1049736 Change-Id: I7dbc36f70ec7b9a567c7c0bb1594081c5e08dadd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578057Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
-
Ben Wagner authored
This is a reland of 9c270678 Fixed invalid unit and improved the error message for an invalid unit. `./tools/perf/run_benchmark run webrtc --browser=system` passes locally on Mac. Original change's description: > Mark some WebRTC perf measurements as biggerIsBetter > > Change-Id: I95a145f0380b0f413a71ef5a9bbacf840eb20b9f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577205 > Commit-Queue: John Chen <johnchen@chromium.org> > Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com> > Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#834889} Change-Id: Id7220dafb11faab2cb3e28b36aed3c6a526575c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580072Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com> Cr-Commit-Position: refs/heads/master@{#835200}
-
Thomas Lukaszewicz authored
This CL sets initial focus for the TaskManagerView dialog to |table_view_|. Currently this is set to nullptr and this means screen readers are unable to navigate the UI without first having to manually assign focus via the tab button. This change allows for screen readers to navigate the UI as soon as the dialog opens without needing to tab to assign focus. Bug: 1106544 Change-Id: I6f96b0ae024eee8e99d66f7a34c609d063e1cb36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580137Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#835199}
-
danakj authored
These bitmaps are safer for transport from untrustworthy sources since all bitmaps should be in N32 format and the browser can make bad assumptions as a result. R=dcheng@chromium.org, sebsg@chromium.org Bug: 1144462 Change-Id: I308ab745a5bfac1696be89e181b100d33db5d602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580026Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#835198}
-
Justin Donnelly authored
Bug: 1107581, 1056384 Change-Id: I2bad60bde8f5ccffeb7e63dedc22e123c74011ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580065Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#835197}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202012090600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/ZueO-HxBTDWZN-HMbvrJcn0XYxqL_NdiiGI2U_5ui9IC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138961540,b/158963860,b/167637550,b/169112730,b/174421354 Tbr: media-app@grotations.appspotmail.com Change-Id: Ia34e36225758d849b566acd5bd0d19e57c013fbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581880Reviewed-by:
-
Jeremy Roman authored
This was wrong but probably harmless (both because it has zero length and because it's in a NOTREACHED path), but was introduced in: https://chromium-review.googlesource.com/c/chromium/src/+/2562819 Spotted by jdoerrie@ using bugprone-dangling-handle: https://docs.google.com/document/d/1LxxcYJSQGcc2dxdLAjpyZt6Rar00i_du7cfvX0UBtP4/edit Change-Id: I49722848a159bb8330362b5932199bff23cc476b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580086 Auto-Submit: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#835195}
-
edchin authored
This was originally created in Nov 2017 in this CL: https://chromium-review.googlesource.com/760036 This metric is no longer being used and has already expired since M77. Per go/histogram-expiry-guidelines: "If the histogram is not in use now, but might be useful in the far future, remove it." Change-Id: Ic8e899f850f8cea0774500eabe43e87f0aaf87d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581003 Auto-Submit: edchin <edchin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#835194}
-
Mohsen Izadi authored
To be able to report main thread event dispatch breakdowns for EventLatency metrics, this CL adds relevant timestamps to cc::EventMetrics. The actual breakdowns will be added to UMAs and UKMs in follow-up CLs. Bug: 1054009 Change-Id: Ia78d2614d4a3e2e4e5de75e2305e16888acbeeb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568936Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#835193}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2523885b..7e546be6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I111ed178f0e22739afdc39f7297eb74ce363b65c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581445Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835192}
-
Eugene But authored
There is a significant discrepancy between number of UKM records uploaded to google servers and numbder of UKM.LogSize.Success records. This either means that UMA data was not written to disk or that app was terminated after server received the data, but before UMA was recorded. Data loss caused by failure to write on disk is highly plausible if the app is running in the background. This CL adds another metric, which counts the number of times UKM.LogSize.Success is emitted. The counter is stored in NSUserDefaults (hence have higher chance to persist). The counter is recorded as UMA when the app starts or foregrounded, hence have higher changes to get written to disk. Bug: 1154678 Change-Id: Ifa71355e02f568713f9d87f45692ae70fd496b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576077 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
-
kylechar authored
There is a bug where SkiaRenderer doesn't handle the nearest_neighbor flag set on quads correctly. If the quad is in a render pass that is bypassed then SkiaRenderer will draw the quad directly using a higher filter quality than nearest-neighbor. There can actually be two different scaling operations, one when the quad is copied into the render pass with nearest-neighbour scaling and the second when the render pass is copied into the framebuffer (or other another render pass) most likely with bilinear interpolation. If there are two scaling operations at different qualities, it's not going to be possible to bypass the render pass without changing the resulting pixels. To simplify things, don't bypass a render pass where the only quad specifies nearest-neighbour scaling. Bug: 1155338 Change-Id: If476bfb2ce027772aaa6a153ba108d341c354423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577706Reviewed-by:
Michael Ludwig <michaelludwig@google.com> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#835190}
-
Yi Gu authored
For privacy, metrics from inner frames are recorded with the top frame's origin. Given that WebOTP is supported in cross-origin iframes, it's better to indicate such information in the |Outcome| metrics to understand the impact and implications. e.g. does user decline more often if the API is used in an cross-origin iframe. UKM collection review: https://docs.google.com/document/d/12-cSbZ2_ztM4u2USo7cVBlZ5rIiQefkdGxz-XdQfa7Q/edit# Bug: 1136506, 1127397 Change-Id: I08d9f720ab8b3832bb47d1fb3575ef7093d8fc57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576588Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#835189}
-
Mirko Bonadei authored
TBR=jansson@chromium.org Bug: 1033483 Change-Id: I8c13d4c5be855176d0ce2efa5d36d0d7ab758161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579968 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#835188}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/bb1a28de3cf1..d7808f1c464a 2020-12-08 landrey@webrtc.org Add DVQA support for scenarios with new participants joining 2020-12-08 alessiob@webrtc.org RNN VAD: GRU layer optimized 2020-12-08 philipp.hancke@googlemail.com sdp: log unhandled lines at LS_VERBOSE level 2020-12-08 gustaf@webrtc.org AEC3: Prevent diverging coarse filter from influencing the refined filter 2020-12-08 kron@webrtc.org Change LS_ERROR to LS_WARNING for unsupported decoder formats 2020-12-08 phancke@nvidia.com use [35,65] rtp payload type range for new codecs 2020-12-08 hta@webrtc.org Don't log errors on a=rtcp lines 2020-12-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3d828369..2be5b61c (834461:834670) 2020-12-08 henrika@webrtc.org Removes spammy SDP log 2020-12-08 peah@webrtc.org Make the static variable kChunkSizeMs constexpr 2020-12-08 philipel@webrtc.org Clean up RtpVp9RefFinder unittests. 2020-12-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision eb89725d..3d828369 (834328:834461) 2020-12-07 hta@webrtc.org Stop threadjumping to get RTP transport in channel.cc 2020-12-07 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision c24aab83..eb89725d (834189:834328) 2020-12-07 phancke@nvidia.com allow dynamic payload types <= 95 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1155477 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie20f4b1daf046a350b4543cf74096d27f4477e38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580000Reviewed-by:
-
Roman Sorokin authored
This CL introduces new screen which extracts locale from identity manager for Gaia users. For public session users it gets locale from the prefs which is set by locale chosen in the login pod. The screen switches the system language and reloads OOBE strings. This is done right after the login (Gaia or public session pod). Bug: 1141289 Change-Id: I235598b5524a1983336980301c4c9ab2833562ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523206Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#835186}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I6c7b0a25ff78e651f32fbaa2fb32afdc8c92a453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581402Reviewed-by:
-
Nohemi Fernandez authored
Because MockSyncSetupService is defined within the iOS libraries we can define a static initializer that constructs a KeyedService using the BrowserState. This will reduce the overhead for adding Sync services to tests in iOS. Bug: N/A Change-Id: Ia142c70ebc605029c8677285f994151a1e1bc961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575029Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#835184}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b1f0d11f4233..34e5f31b2cb0 2020-12-09 alexrudenko@chromium.org Click on a tree element to make sure the element is focused If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5aa69733ca57ec5ab319ee51f1ab8263b9fccb33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581416Reviewed-by:
-
Rodney Ding authored
Bug: 1124361 Change-Id: I3a901dc1f77e59783406043a7bded2c983e9b6d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542597 Commit-Queue: Rodney Ding <rodneyding@google.com> Reviewed-by:
Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#835182}
-
Alexander Surkov authored
mac tree formatter class Bug: 1133330 Change-Id: I826a1844302e294d7f1758fd078d467574749d63 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568988 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#835181}
-
Dominic Mazzoni authored
I wanted to see those to compare against the colindex: and rowindex: attributes (which expose ARIA only) but they weren't being printed. No actual bug here, just adding a bit of test coverage. Bug: 1078623 Change-Id: I1e4079b61adf7c5d0e0f8b3320e05cae930a0db7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580443 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#835180}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/016711efbb5d..d19d663924f1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tnagel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tnagel@google.com Change-Id: Ie15928a4ca5aca3e07f4c24ff8de03ea175f668c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581414Reviewed-by:
-
Guido Urdaneta authored
When the promise of a getUserMedia() call is settled, it can result in the detachment of the execution context. The idenfiability metrics for getUserMedia() require a valid execution context and therefore should run before the getUserMedia() call ends. Bug: 1156510 Change-Id: I29975c9d779858b1574506f5d60ecfe4ae6a1690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580070 Auto-Submit: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Reviewed-by:
Chris Fredrickson <cfredric@chromium.org> Cr-Commit-Position: refs/heads/master@{#835178}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607493425-af0aa6c36468b9d0e6f03a33932dae6d4017f80e.profdata to chrome-mac-master-1607515179-092361bc7a185424dad74bccdfea645817af1d61.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4a1f73e54f5a5c7eae2dfc0912ead8004840a97f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581415Reviewed-by:
-
