- 25 Jul, 2018 40 commits
-
-
Justin Cohen authored
Various safe area tweaks to correct the layout of fakebox on rotation when presented under another view controller. Bug: 866864, 862208 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7fda5c1ae564825c203566add4c7e738bcb38eb8 Reviewed-on: https://chromium-review.googlesource.com/1149100Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#577826}
-
Michael van Ouwerkerk authored
Bug: 866937 Change-Id: Ifc6e7824491f6b89de24d97800852d2288cc9d28 Reviewed-on: https://chromium-review.googlesource.com/1148565Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#577825}
-
Maajid authored
Bug: 865912 Change-Id: I6dee22391a7216d183aad06831c6db25e4dff2d7 Reviewed-on: https://chromium-review.googlesource.com/1145080 Commit-Queue: Maajid <maajid@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Elijah Taylor <elijahtaylor@chromium.org> Cr-Commit-Position: refs/heads/master@{#577824}
-
Matthew Cary authored
Uses the new WritableUnalignedMapping class, which changes the ownership semantics. See the bug for details on the overall plan. Bug: 849207 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie3379f1dabb0c0fa7fae7451534bd5fa1b01416e Reviewed-on: https://chromium-review.googlesource.com/1117696Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#577823}
-
Timothy Loh authored
This patch adds support for app icons when used as file handlers in the file manager. As there is no place to store the CrostiniAppIcon objects, a IconLoadWaiter is added which manually manages it's lifetime and deletes itself after an icon is loaded (or fails to load). This is a re-land of https://crrev.com/c/1127204, but with the longer deletion time-out removed. It turns out the longer time-out is not needed, and it was causing LSAN to detect a leak as the objects were not cleaned up by test completion. BUG=822513 Change-Id: Id04730ee2ea18f6f5004624471e40bcd13e9974b Reviewed-on: https://chromium-review.googlesource.com/1149432Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#577822}
-
Wei-Yin Chen (陳威尹) authored
Bug: 866720 Change-Id: Ie3de731b94e6db978acbb0ef2d951b4399c2e25b Reviewed-on: https://chromium-review.googlesource.com/1147670 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#577821}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dbe25137..90d0244a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic7f1083de5b8e0eccb2554c2bda57f48eeb13f21 Reviewed-on: https://chromium-review.googlesource.com/1149613Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577820}
-
Vasilii Sukhanov authored
The CL is a next stage of removing "Smart Lock" branch from the password UI. We do the following: - Change the behavior of IsSmartLockUser(). Those syncing with the custom passphrase should see the same UI as normal sync users. - Use "passwords.google.com" site from the string resource instead of the constant. Thus, it's possible to change it via Finch. - Add a footer to the save/update password bubble. For signed-in users it clarifies that the credentials are stored in the Google Account. TBR=hcarmona@chromium.org Bug: 865437,862269 Change-Id: I3a58e26319191b0e24fbc1ac793d6028b1828e1e Reviewed-on: https://chromium-review.googlesource.com/1146648 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#577819}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/df0e48fed437..096c5296c3b0 git log df0e48fed437..096c5296c3b0 --date=short --no-merges --format='%ad %ae %s' 2018-07-25 jmadill@chromium.org Blit11: Refactor for error returning. 2018-07-25 jmadill@chromium.org TextureStorage11: Pass more Context around. 2018-07-25 jmadill@chromium.org TextureStorage11: Don't use gl::ErrorOrResult. 2018-07-25 jmadill@chromium.org D3D11: Don't use ErrorOrResult in TransformFeedback11. 2018-07-25 jmadill@chromium.org D3D: Make computeOffset not use ErrorOrResult. 2018-07-25 jmadill@chromium.org D3D11: Make createStagingTexture return Error. Created with: gclient setdep -r src/third_party/angle@096c5296c3b0 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Ia94edca7552266bd5af8b9f42cba47f430d01844 Reviewed-on: https://chromium-review.googlesource.com/1149344Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577818}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4c7a750e5543..15020ea2cf44 git log 4c7a750e5543..15020ea2cf44 --date=short --no-merges --format='%ad %ae %s' 2018-07-25 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 ddd6e8746851..096c5296c3b0 (10 commits) Created with: gclient setdep -r src/third_party/skia@15020ea2cf44 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I6f5bd3bcd69200d8ffea74d85ede5e179c5a72f9 Reviewed-on: https://chromium-review.googlesource.com/1149543Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577817}
-
Jinsuk Kim authored
A few callsites of |Tab.getContentViewCore| were replaced by |Tab.getWebContents| in https://crrev.com/c/989515 but the former was not simply returning the required object but also checked if the tab is showing native page or not, in which case returns null. This check should have been preserved in those callsites to show some resources like icons correctly in tab switcher mode. This CL fixes it by putting back the checks. Bug: 863841, 863809 Change-Id: I423d637687cf6140196fc525f7f2cc29aa4c8002 Reviewed-on: https://chromium-review.googlesource.com/1146130Reviewed-by:
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I2b60ed9e4394eb7c72d3219f025a5a44e11ed1de Reviewed-on: https://chromium-review.googlesource.com/1149702 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577815}
-
Noel Gordon authored
Add support enabling zip/unzip in the integration test base class. Any derived class can request support in test by overriding method: GetNeedsZipSupport() The default implementation returns false. Add ZipCase derived from the TestCase class, and an overriden method, in the FileManagerBrowserTest class. Future TODO: write test to exercise zip/unzip support. Bug: 864256,865197,836412 Change-Id: I3dc5b17023506ef3a2fa57611fff16ee68ead43e Reviewed-on: https://chromium-review.googlesource.com/1149438Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#577814}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/70ddc1ca22ad..84d3394d88c4 git log 70ddc1ca22ad..84d3394d88c4 --date=short --no-merges --format='%ad %ae %s' 2018-07-25 art-snake@yandex-team.ru Fix hint tables parsing. Created with: gclient setdep -r src/third_party/pdfium@84d3394d88c4 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I708980aaec069480a78688ef7c527dc2f2b6a206 Reviewed-on: https://chromium-review.googlesource.com/1149542Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577813}
-
Giovanni Ortuño Urquidi authored
Adds code to BookmarkAppShortcutInstallationTask to get the necessary icons from the DataRetriever. And Adds code to BookmarkAppDataRetriever to generate all icons necessary to install a Bookmark App. In the future, BookmarkAppDataRetriever will take a list of icon URLs to download, download the icons, resize them and generate icons for any missing sizes. But for now we just generate all icons. Bug: 864904 Change-Id: Ia90e67174e89fa6e92b54bee812ab337fed821c6 Reviewed-on: https://chromium-review.googlesource.com/1147899Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#577812}
-
Ricky Liang authored
We should clone the capture settings in CameraDeviceDelegate::TakePhoto(). Also identify the TakePhotoCallbacks that have a corresponding buffer registered in StreamBufferManager to remove a race condition that may lead to duplicated buffers being registered for the same TakePhoto request. While we're at it, change the video_capture_unittests to only start CameraHalDispatcher once. BUG=b:111661065 TEST=unit tests TEST=Make sure continuous shots works in camera app. Change-Id: I8ce8028f902c14d8b955d1b72af185097ddf5451 Reviewed-on: https://chromium-review.googlesource.com/1145980Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Wu-Cheng Li <wuchengli@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#577811}
-
Sam McNally authored
Change-Id: I98704eca528ed2ab56c96f6688e7232b92c831fd Reviewed-on: https://chromium-review.googlesource.com/1149660Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#577810}
-
Scott Violet authored
And move some code to test only. BUG=852439 TEST=none Change-Id: I690fa56d770b27aa147c32e4d5634208d95a6786 Reviewed-on: https://chromium-review.googlesource.com/1149099 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Ross McIlroy authored
Enables tracking of why a particular script was not parsed / compiled by the ScriptStreamer. BUG=865098 Change-Id: I1a1b033689d0f12df4f28ff5c4bb21243cbec197 Reviewed-on: https://chromium-review.googlesource.com/1143762 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#577808}
-
Takuto Ikuta authored
By this CL, we remove absolute path from obj files in windows build with goma. And this allows to share build result even if it is built in different directory. This will give faster build time to windows developers and also let goma team focus on cache hit build more. This change removes absolute path from obj files, but lld linker absolutizes the path not to confuse debugger. Also this CL enables the feature by default only for lld with goma build on windows. Build stats of chrome on Z840 windows with -j1000 * is_debug=true and symbol_level=2 cache hit: 658 seconds non-cache hit: 728 seconds * is_debug=false and symbol_level=0 cache hit: 275 seconds non-cache hit: 411 seconds TODO: add build speed comparison of cache hit/no-hit build in symbol_level = 0 and symbol_level = 2 Bug: 712796 Change-Id: I88532a43addf693f93b30c96d08c8e93515d4344 Reviewed-on: https://chromium-review.googlesource.com/1143663 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#577807}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0359b6977caf..df0e48fed437 git log 0359b6977caf..df0e48fed437 --date=short --no-merges --format='%ad %ae %s' 2018-07-25 jmadill@chromium.org Buffer11: Don't use ErrorOrResult. Created with: gclient setdep -r src/third_party/angle@df0e48fed437 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Icf4f5652eddb34fbff190c8478093a5c274bf0b3 Reviewed-on: https://chromium-review.googlesource.com/1149343Reviewed-by:
-
Ramin Halavati authored
Policy preferences are removed from the persistent storage list for incognito mode. This means that after this CL, these preferences are only stored in memory in incognito mode. Bug: 861722 Bug: 866422 Change-Id: I3d5eea500c6801a89547bb38608f187675b73681 Reviewed-on: https://chromium-review.googlesource.com/1148053Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#577805}
-
Marina Ciocea authored
This flag will be reused to enable sandbox on Mac in an experiment, hence dropping the "Windows" from flag name. Bug: 850878 Change-Id: Idc46f244b29425b60c42bf1b7288023206cffc19 Reviewed-on: https://chromium-review.googlesource.com/1148449Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 8260 8263 8272 8276 8279 8292 2 lines were removed and 4 lines were deflaked by consecutive results since 8217. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I4c26c84bee0225b5ed6bb1e72e0f40fe84b60b41 Reviewed-on: https://chromium-review.googlesource.com/1147892 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#577803}
-
Nigel Tao authored
Upcoming changes will refer to these types without being associated with "policy" per se. Change-Id: I1d3e98592686ee640fb5a22f24b180f267d43381 Reviewed-on: https://chromium-review.googlesource.com/1149422 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/36b2059cae7f..70ddc1ca22ad git log 36b2059cae7f..70ddc1ca22ad --date=short --no-merges --format='%ad %ae %s' 2018-07-25 art-snake@yandex-team.ru Use document size instead of file size while parsing. Created with: gclient setdep -r src/third_party/pdfium@70ddc1ca22ad The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I528ab175def896454e1680319e4b2a9dfaab7a4a Reviewed-on: https://chromium-review.googlesource.com/1149540Reviewed-by:
-
Daniel Bratell authored
MakeFunctionUnique and MockInvalidFunction are functions that are generated twice by ui/gl/generate_bindings.py. With that double generation the code can't be jumbo compiled because of the resulting symbol clash when the code ends up in a single translation unit. This patch gives the functions unique names by adding the "set_name" (gl, egl) to their names. Bug: 864986 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia08d42a86b99bddc808d1ac7c921f6801eb07782 Reviewed-on: https://chromium-review.googlesource.com/1148453Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#577800}
-
Daniel Bratell authored
gl_enums used Khronos to get a definition of GL_NONE but that broke jumbo build experiments because you cannot have khronos headers and ui/gl headers in the same translation unit. This patch switches gl_enums.cc to use ui/gl/gl_bindings.h like the rest of the code. Bug: 864986 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id239ca4aa55278ac012c066d6a6f8e243b3ec319 Reviewed-on: https://chromium-review.googlesource.com/1148442Reviewed-by:
-
Javier Ernesto Flores Robles authored
Also creates a protocol with the move. This changes are needed so it can be reused for manual fill. Bug: 845472 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I54bc740454dbc58ba8c1997daa05fc4dff99dccd Reviewed-on: https://chromium-review.googlesource.com/1147675 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#577798}
-
Ria Jiang authored
Currently in Shell::CreateShell, we create platform window in PlatformCreateWindow and then set its contents in PlatformSetContents. However, we can be setting two different bounds ([1] and [2]); if we are trying to get the window bounds and it happens to be between these two set-bounds requests (e.g. to x11), we are getting the wrong bounds, which is why the test in the bug report failed. This CL moves window-> show to be after PlatformSetContents so we only set the correct bounds once. [1] https://cs.chromium.org/chromium/src/content/shell/browser/shell_views.cc?type=cs&sq=package:chromium&g=0&l=420 [2] https://cs.chromium.org/chromium/src/content/shell/browser/shell_views.cc?type=cs&sq=package:chromium&g=0&l=91 Bug: 865919 Change-Id: I936148a6236804ff0b01c0a9ec5ad5143cfbd071 Reviewed-on: https://chromium-review.googlesource.com/1149440 Commit-Queue: Ria Jiang <riajiang@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#577797}
-
Eliot Courtney authored
Bug: b/109716842 Test: Able to free resize PIP windows with Android side patch. Change-Id: If27051f3edc27cebc5f2e27f78daf8ea2f60f60e Reviewed-on: https://chromium-review.googlesource.com/1134810Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#577796}
-
Chris Lu authored
Move offset calculation away from -viewDidLayoutSubviews and into -viewDidAppear and -viewWillTransitionIntoSize so that the logic lies in places where the newly rotated frame has been defined. -viewDidAppear covers first-time calculations and -viewWillTransitionIntoSize handles rotations. Video: https://drive.google.com/open?id=1ziE4y_N4FYZuR5cR10i-wuJ1Zkmqzdyv Bug: 862544 Change-Id: Ib493e7395041d498abb5b77d6c8732dc443b01e3 Reviewed-on: https://chromium-review.googlesource.com/1141287Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
Jonathan Metzman authored
https://chromium.googlesource.com/chromium/llvm-project/compiler-rt/lib/fuzzer.git/+log/2f72894d302e..d62662686b22 $ git log 2f72894d3..d62662686 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 dor1s [libFuzzer] Handle unstable edges by disregarding unstable edges 2018-07-24 phosek [sanitizer][fuzzer] Temporarily transition to ZX_TIME_INFINITE_OLD 2018-07-24 phosek Revert "[Fuzzer] Update path to libc++ headers" 2018-07-23 phosek [Fuzzer] Update path to libc++ headers 2018-07-23 dor1s [libFuzzer] Handle unstable edges by using minimum hit counts 2018-07-19 kcc [libFuzzer] when -print_coverage=1 is given, print more stats (the number of seeds that hit every given function) 2018-07-19 kcc [libFuzzer] fix the bot (the no-assert build) 2018-07-19 kcc [libFuzzer] first experimental attempt at DFT-based mutations (DFT=data-flow-trace) 2018-07-18 phosek [Fuzzer] Improve crash unwinding on Fuchsia 2018-07-18 dor1s [libFuzzer] Create single template for visiting Inline8bitCounters Created with: roll-dep src/third_party/libFuzzer/src Bug: 539572,854276 Change-Id: Iadeb2d7c4c5cbd6ba51e257bc2b0fa662a44050e Reviewed-on: https://chromium-review.googlesource.com/1149444Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#577794}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1032259c..dbe25137 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8e52443991ff95ac83bcaef7af98edf39e132d93 Reviewed-on: https://chromium-review.googlesource.com/1149445Reviewed-by:
-
Yue Li authored
Also: - update logic for Assistant settings. - update timeout for loading the flow. Bug: 866141, b/111704810, b/111796422 Test: Manual Test Change-Id: Ibb3ba413992ee92b2e334dddeaf7d714d500ffcb Reviewed-on: https://chromium-review.googlesource.com/1148768 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#577792}
-
Peter Kasting authored
IMO he's done enough work on the tabstrip during the Refresh cycle to be able to review changes here. TBR=sky Bug: none Change-Id: I1522042e5244e225a7ce2c86d87397729a2086fe Reviewed-on: https://chromium-review.googlesource.com/1147661 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#577791}
-
Giovanni Ortuño Urquidi authored
Introduces the BookmarkAppInstallationTask. This class purpose is to perform the necessary steps to install an BookmarkApp from a WebContents or a WebApplicationInfo. This class will have two subclasses BookmarkAppShortcutInstallation task and BookmarkAppWebAppInstallationTask. The former is included in this CL and installs BookmarkApp-based Shortcuts. The latter will install BookmarkApp-based Web Apps. Bug: 864904 Change-Id: I5b5b9f44ff0984b0138663cb7c84abcba1062c77 Reviewed-on: https://chromium-review.googlesource.com/1131024 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
Ian Kilpatrick authored
This allows NGLineInfo to return a Width which isn't clamped to zero for negative values. This allows alignment of text to work correctly for these values. Additionally, when adjusting the inline static position of abs-pos children, we use the resulting fragment inline size, instead of the line width, as this may be different. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I0876f148d285147c3b5cec658ebd7831e97b11aa Bug: 636993 Reviewed-on: https://chromium-review.googlesource.com/1147875Reviewed-by:
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6cf86b3c343e..f79ab3845a7e git log 6cf86b3c343e..f79ab3845a7e --date=short --no-merges --format='%ad %ae %s' 2018-07-25 nednguyen@google.com Make sure Telemetry browser attempts to log symbolizaztion of all unsymbolized dumps upon test failures Created with: gclient setdep -r src/third_party/catapult@f79ab3845a7e The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:865895 TBR=sullivan@chromium.org Change-Id: I0632a93297b85b3e5ca364eb908176c39acf9466 Reviewed-on: https://chromium-review.googlesource.com/1149541Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577788}
-
Matt Falkenhagen authored
This comment seems outdated. S13nSW without NetworkService is supported. The TODO is a bit vague about what was planned to be done. I assume it was to merge the S13nSW without NetworkService code with the non-S13nSW without NetworkService code, but there is not a viable path for that, and as the code will be removed after S13nSW it's not worth it. Change-Id: I85097d207af340173508004249e6eebe317a2cfa Reviewed-on: https://chromium-review.googlesource.com/1149424Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#577787}
-
