- 03 Sep, 2014 40 commits
-
-
nyquist authored
The CL https://codereview.chromium.org/415343002/ accidentally introduced new files in //chrome/chrome_browser.gypi without adding a newline. This CL just cleans up the style of the .gypi. BUG=383630 Review URL: https://codereview.chromium.org/533173003 Cr-Commit-Position: refs/heads/master@{#293204}
-
elijahtaylor authored
This keeps the "Visit Website" link from showing up in chrome://extensions, which makes sense because shared modules are automatically installed. BUG=408927 Review URL: https://codereview.chromium.org/532973002 Cr-Commit-Position: refs/heads/master@{#293203}
-
Sadrul Habib Chowdhury authored
The notable changes: . Do not allow horizontal dragging of the split windows. . Do not show the 'Split' button when dragging a non-split window. Instead, highlight the split windows as drop targets. . When a window is dropped on top of a left/right split window, switch to that window in that part of the split. BUG=404119 R=oshima@chromium.org Review URL: https://codereview.chromium.org/537073002 Cr-Commit-Position: refs/heads/master@{#293202}
-
zhaoqin authored
TBR=xians@chromium.org BUG=409485 NOTRY=true Review URL: https://codereview.chromium.org/534373002 Cr-Commit-Position: refs/heads/master@{#293201}
-
kelvinp authored
This dialog explains the implications of accepting remote assistance and provides a way for the user to decline assistance. This ensures that even if the caller (Hangouts) is compromised, it won't be able to control the user's desktop without user interaction. BUG=405139 Review URL: https://codereview.chromium.org/503063004 Cr-Commit-Position: refs/heads/master@{#293200}
-
scherkus authored
Some checkouts have the build directory mounted, which causes the script to throw an exception when it attempts to remove the directory itself. Review URL: https://codereview.chromium.org/532323002 Cr-Commit-Position: refs/heads/master@{#293199}
-
binjin authored
Initial ExtensionManagement class implementation, with legacy preference parsing and interface for obtaining basic structure of extension management settings. BUG=177351 TEST=new unit test Review URL: https://codereview.chromium.org/499313002 Cr-Commit-Position: refs/heads/master@{#293198}
-
fsamuel authored
This CL removes the passed parameter of device_scale_factor and in BrowserPlugin::UpdateDeviceScaleFactor since it's not used. This CL also removes GetSizeParams because it's only used once. Repaints are now set whenever the device scale factor changes. Also remove all calls to .get() on scoped_ptrs which are unnecessary. BUG=none TBR=creis@chromium.org for trivial render_view_impl change. Review URL: https://codereview.chromium.org/528383003 Cr-Commit-Position: refs/heads/master@{#293197}
-
Sadrul Habib Chowdhury authored
When in overview mode, if a window is closed, then the rest of the windows that behind the closed window in the stack are moved on step forward. However, if there are no windows behind the closed window, then move the windows in front of the closed window backward one step. BUG=408280 R=oshima@chromium.org Review URL: https://codereview.chromium.org/531093003 Cr-Commit-Position: refs/heads/master@{#293196}
-
kouhei authored
We are removing the corresponding runtime flag in Blink, as it currently has no effect. This patch removes its usage in Chromium side. Blink side: https://codereview.chromium.org/535463002/ BUG=None Review URL: https://codereview.chromium.org/530353002 Cr-Commit-Position: refs/heads/master@{#293195}
-
scherkus authored
The gmock log spam was annoying. Review URL: https://codereview.chromium.org/535253002 Cr-Commit-Position: refs/heads/master@{#293194}
-
lliabraa authored
The iOS6-style APIs have been deprecated, but the replacements are more verbose and brittle so this category wraps the replacements in methods similar to the iOS6-style APIs. This category lives in a new target and directory: src/ui/ios, so this CL sets up all the gyp/DEPS stuff and only adds a single method. There will be more methods added in subsequent CLs. BUG=364419 Review URL: https://codereview.chromium.org/497503004 Cr-Commit-Position: refs/heads/master@{#293193}
-
scherkus authored
DVLOG(0) is way too spammy for such a low-level function. BUG=376450 TBR=dalecurtis Review URL: https://codereview.chromium.org/537653002 Cr-Commit-Position: refs/heads/master@{#293192}
-
clamy authored
This CL makes sure that the renderer is initialized before being used to handle a navigation that has just committed. BUG=376082 Review URL: https://codereview.chromium.org/536473002 Cr-Commit-Position: refs/heads/master@{#293191}
-
skia-deps-roller authored
https://skia.googlesource.com/skia/+log/937c9c7eb4e06d4d3bc495e129c7b8103a5d6c0f..74364c97740eb48c86d6e7b42520c77130eb1486 CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=jvanverth@google.com Review URL: https://codereview.chromium.org/533263002 Cr-Commit-Position: refs/heads/master@{#293190}
-
blink-deps-roller authored
https://chromium.googlesource.com/chromium/blink/+log/104ecc5a02c328914490c6c17ccc8a17d8e40fca..9d34a87dee82cbdcd5876669aa1cd1a430289e09 TBR=tkent@chromium.org,arv@chromium.org Review URL: https://codereview.chromium.org/535233002 Cr-Commit-Position: refs/heads/master@{#293189}
-
tonyg authored
The underlying issue has been fixed. BUG=273986 TBR=andrewhayden@chromium.org Review URL: https://codereview.chromium.org/534313002 Cr-Commit-Position: refs/heads/master@{#293188}
-
sky authored
Revert of Changes exception for gyp files to only gyp files in build/ (patchset #1 id:1 of https://codereview.chromium.org/512693004/) Reason for revert: *SIGH* Encountered another problem. See http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_... . Reverting again. Original issue's description: > Changes exception for gyp files to only gyp files in build/ > > I changed analyzer such that if a gyp file (or an included gypi file) > changes all targets in the gyp file are marked as changed. This means > I should no longer have to special case gyp files. I'm leaving the > exception in place for any gyp files in build as any change to those > really needs to recompile the world. > > BUG=109173 > TEST=none > R=thakis@chromium.org > > Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/5110e8b > > Committed: https://chromium.googlesource.com/chromium/src/+/e53e29fc161f96871160f6db39919752a0376333 TBR=thakis@chromium.org NOTREECHECKS=true NOTRY=true BUG=109173 Review URL: https://codereview.chromium.org/537683002 Cr-Commit-Position: refs/heads/master@{#293187}
-
Erik Arvidsson authored
Last commit (#293147) got the boolean logic wrong. BUG=410327 TBR=tkent,rvargas Review URL: https://codereview.chromium.org/541443002 Cr-Commit-Position: refs/heads/master@{#293186}
-
Monica Dinculescu authored
This reverts commit 6087f972. I reverted this on trunk instead of on branch-heads/2125. >.< BUG=405056 TBR=noms@chromium.org Review URL: https://codereview.chromium.org/533303002 Cr-Commit-Position: refs/heads/master@{#293185}
-
Brett Wilson authored
The outputs of a target were not previously considered when doing header checks. Also, adds the new check_includes, testonlg, and allow_circular_includes_from variables to the "desc" command. R=jamesr@chromium.org Review URL: https://codereview.chromium.org/537013002 Cr-Commit-Position: refs/heads/master@{#293184}
-
mukai authored
BUG=None R=oshima@chromium.org TEST=buid chrome with use_athena=1 NOTRY=TRUE Review URL: https://codereview.chromium.org/534353002 Cr-Commit-Position: refs/heads/master@{#293183}
-
kmadhusu authored
Server side bug: b/17140979 BUG=none TEST=none Review URL: https://codereview.chromium.org/532283003 Cr-Commit-Position: refs/heads/master@{#293182}
-
divya.bansal authored
Browser should go back to video page(having inline video) through escape key of BT keyboard instead of goig back to main page. BUG=396996 Review URL: https://codereview.chromium.org/439433004 Cr-Commit-Position: refs/heads/master@{#293181}
-
flackr authored
BUG=408962 TEST=SplitSplitViewControllerTest.LandscapeOnly Review URL: https://codereview.chromium.org/535973002 Cr-Commit-Position: refs/heads/master@{#293180}
-
gcasto authored
This requirement only exists on this implementation of PasswordStore. BUG=408783 Review URL: https://codereview.chromium.org/536783002 Cr-Commit-Position: refs/heads/master@{#293179}
-
magjed authored
BUG=410202 TEST=Use Kinect camera on Linux. Go to page https://src.chromium.org/svn/trunk/src/chrome/test/data/webrtc/manual/peerconnection.html. Press button "Get devices". An entry "Microsoft Kinect Camera" should show up in the "Video source" list. Press button "Request GetUserMedia". You should get a stream with size 640x480 in the preview. Review URL: https://codereview.chromium.org/539443003 Cr-Commit-Position: refs/heads/master@{#293178}
-
dhnishi authored
profile is updated. BUG=409093 Review URL: https://codereview.chromium.org/519883002 Cr-Commit-Position: refs/heads/master@{#293177}
-
hubbe authored
Revert of Enable castv2 perf tests again (patchset #1 id:1 of https://codereview.chromium.org/511393007/) Reason for revert: Fails with low event counts on several platforms: crbug.com/410391 Original issue's description: > Enable castv2 perf tests again > > .. and switch evil network profile for bad network profile > > BUG=356842 > > Committed: https://chromium.googlesource.com/chromium/src/+/18b429984ee371349c4f80b215896098ede8d9f3 TBR=miu@chromium.org NOTREECHECKS=true NOTRY=true BUG=356842 Review URL: https://codereview.chromium.org/540433002 Cr-Commit-Position: refs/heads/master@{#293176}
-
spang authored
This crashes inside GbmBuffer::CreateBuffer due to NULL gbm_device. We should check this earlier for a more informative crash. BUG=410002 TEST=run chrome on link_freon NOTRY=true Review URL: https://codereview.chromium.org/532873002 Cr-Commit-Position: refs/heads/master@{#293175}
-
aiolos authored
Revert of Simplify IOSurface CoreAnimation code: Part 2 (patchset #13 id:240001 of https://codereview.chromium.org/490393002/) Reason for revert: crbug.com/410360 (Browser crashing on IOSurfaceLayer release in tab_switching.typical_25) Original issue's description: > Simplify IOSurface CoreAnimation code: Part 2 > > It isn't necessary to mess around with sharing CGLContextObjs anymore, > they were necessary only to share data between the frame subscriber > and the RenderWidgetHostViewMac. Just give each IOSurfaceLayer its > own CGLContextObj, and draw using immediate mode (using shaders > resulted in an increase in startup time). > > BUG=314190 > TBR=pfeldman@chromium.org > R=kbr@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/a83898264f64ad83bb98139e5e0dcb2c77db1997 TBR=kbr@chromium.org,ccameron@chromium.org NOTREECHECKS=true NOTRY=true BUG=314190 Review URL: https://codereview.chromium.org/528403002 Cr-Commit-Position: refs/heads/master@{#293174}
-
asvitkine authored
This can happen, for example, when a user used the --force-fieldtrials= command-line to set a different group than what they have selected from chrome://flags. Includes a test. BUG=409976 Review URL: https://codereview.chromium.org/529183002 Cr-Commit-Position: refs/heads/master@{#293173}
-
cmasone authored
The Mojo code on CrOS needs to accept inbound connections on a unix domain socket, and then 'promote' the resulting sockets to Mojo MessagePipes. This really requires access to the underying file descriptor, so provide a mechanism to accept a connection and get back a SocketDescriptor. BUG=407782 TEST=UnixDomain*SocketTest R=mmenke@chromium.org Review URL: https://codereview.chromium.org/509133002 Cr-Commit-Position: refs/heads/master@{#293172}
-
jmedley authored
BUG=none R= teravest@chromium.org TEST=none NOTRY=true (documentation only change) Review URL: https://codereview.chromium.org/530173003 Cr-Commit-Position: refs/heads/master@{#293171}
-
dcheng authored
BUG=110610 Review URL: https://codereview.chromium.org/535723002 Cr-Commit-Position: refs/heads/master@{#293170}
-
Monica Dinculescu authored
This reverts commit 9ed04f3e258e8f1ffdef74be2418fd87b1a47dfc. Reason for revert: did a bad git merge in the original branch merge. :( BUG=405056 TBR=noms@chromium.org Review URL: https://codereview.chromium.org/533153003 Cr-Commit-Position: refs/heads/master@{#293169}
-
simonb authored
Annotate postCallbackOnMainThread() method with @CalledByNative, and LibInfo fields with @AccessedByNative, for ProGuard. BUG= Review URL: https://codereview.chromium.org/539523003 Cr-Commit-Position: refs/heads/master@{#293168}
-
tsepez authored
This brings in: 5f8a503 Check m_nComponents when using JBIG2Decode 1d7dc1b Add m_pDocument in CPDF_Color and check if page date has been forced clear 49c41ac Tidy up opj_ callback functions in fx_codec_jpx_obj.cpp 9f810e7 Remove the GetValidBpc check in application callers and move it to where m_bpc is assigned. d0c3650 Remove unused fields and stack locals. TBR=thakis@chromium.org TBR=inferno@chromium.org Review URL: https://codereview.chromium.org/535623003 Cr-Commit-Position: refs/heads/master@{#293167}
-
kpschoedel authored
BUG=380349 Review URL: https://codereview.chromium.org/479873002 Cr-Commit-Position: refs/heads/master@{#293166}
-
Adam Langley authored
(By request of the site.) BUG=410377 Cr-Commit-Position: refs/heads/master@{#293165}
-