- 20 Jul, 2020 40 commits
-
-
Maksim Moskvitin authored
This reverts commit d0b5f5ca. Reason for revert: likely the culprit for compile failure (https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/15899?) Original change's description: > Roll DevTools Frontend from 270e6f332c41 to edad8321ca15 (4 revisions) > > https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/270e6f332c41..edad8321ca15 > > 2020-07-20 pfaffe@chromium.org [wasm debug] Add an API for Language Plugins Extensions > 2020-07-20 jacktfranklin@chromium.org Migrate `front_end/bindings` to `devtools_entrypoint` > 2020-07-20 alexrudenko@chromium.org Add showTrackSizes to the grid overlay > 2020-07-20 petermarshall@chromium.org tests: Always specify a timeout for waitFor/Function > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/devtools-frontend-chromium > Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Bug: chromium:1083146,chromium:1101738,chromium:1105808 > Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com > Change-Id: Ifb947b680923d8f750a5d3d8ef575c47d70334d7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307350 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#789900} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7687a2d49c07b3020bb897e1d324c0f80b2b1c1f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1083146 Bug: chromium:1101738 Bug: chromium:1105808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306045Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#789906}
-
Yi Gu authored
This reverts commit fb77bf14. Reason for revert: Test is still flaky: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&tests=AtMostOneSmsRequestPerOriginPerTab Original change's description: > [WebOTP] Tentatively re-enable SmsBrowserTests > > There were 3 tests disabled in Feb due to flakiness (RunLoop timeout). > This patch re-enables one of them to verify whether the flakiness has > been fixed by recent changes and gather up-to-date failure logs if not. > > Bug: 1052385 > Change-Id: Ib9dcabf769a4ff03d31e1ec1601c69717f590040 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302409 > Reviewed-by: Sam Goto <goto@chromium.org> > Commit-Queue: Yi Gu <yigu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789789} TBR=yigu@chromium.org,goto@chromium.org Change-Id: I9dc46de890dd869ccc1324e72065beac7713471d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1052385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305831Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#789905}
-
Rohit Agarwal authored
This CL adds a UI placeholder for going incognito mode from MICE account picker dialog. The process of going incognito gated behind the incognito interstitial would be followed up in later CLs. This CL also adds an instrumentation test to verify the button is shown after the bottom sheet is expanded and update the existing unit tests in AccountPickerMediatorTest. Bug: 1103262 Change-Id: I3762747ebb7b9bb50ebc32447635daf858876336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288498Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#789904}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8ee58ef3895b..de55e0b54668 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mmoskvitin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mmoskvitin@google.com Change-Id: I1af7a22fdbff7e1fedf11c02e9a076cd427b5bc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307136Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789903}
-
Stepan Khapugin authored
This reverts commit 90cc207c. Reason for revert: These tests (testLookalikeUrlPageNoSuggestionClosePage, testLookalikeUrlPageNoSuggestion) are failing on the waterfall: https://ci.chromium.org/p/chrome/builders/ci/iphone-device/10094 https://ci.chromium.org/p/chrome/builders/ci/ipad-device/10820 https://ci.chromium.org/p/chrome/builders/ci/iphone-simulator/12443 Original change's description: > [iOS] Add lookalike_url_egtest and update comments > > Bug: 1058898 > Change-Id: I80883ee1258493eb0ac56950d654606c393ee65e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284144 > Commit-Queue: Livvie Lin <livvielin@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#788917} TBR=eugenebut@chromium.org,livvielin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1058898 Change-Id: Iac4277e189e737c9afa6d1de65fdaf966dfabf8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306091Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789902}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1860aed6436d..3ba1777cebcd 2020-07-20 kjlubick@google.com [npm] Support npm publish flow If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I5fedde0ea6d45caef944fbb4eb9fdee1b959675a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307352Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789901}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/270e6f332c41..edad8321ca15 2020-07-20 pfaffe@chromium.org [wasm debug] Add an API for Language Plugins Extensions 2020-07-20 jacktfranklin@chromium.org Migrate `front_end/bindings` to `devtools_entrypoint` 2020-07-20 alexrudenko@chromium.org Add showTrackSizes to the grid overlay 2020-07-20 petermarshall@chromium.org tests: Always specify a timeout for waitFor/Function If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1083146,chromium:1101738,chromium:1105808 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifb947b680923d8f750a5d3d8ef575c47d70334d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307350Reviewed-by:
-
Andrew Shulaev authored
Bug: 160139330 Change-Id: Ida257b6075deaebb37f95296ad8df50dd182f2a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294660 Commit-Queue: Andrew Shulaev <ddrone@google.com> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#789899}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d1e8e6122c75..741a98d1bbcf 2020-07-20 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 046ea7f6..9a6944e0 (789730:789857) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I34dcda3d64d47bc62b693d09b2c99ba766977c34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307349Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f3d231ec..c3cb2d92 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6d09346df705e8848993562edba316ba4fa8562c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305917Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789897}
-
Bartek Nowierski authored
Technically, it shouldn't make a difference for CheckedPtr2 from performance point of view, but just in case, let's make it equal to MTECheckedPtr. Bug: 1092288 Change-Id: Ic4295450e984ac2263608e17a499e9b4dc4154d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305828 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#789896}
-
Mugdha Lakhani authored
The following now-irrelevant Prerender tests have been deleted: PrerenderServerRedirectInIframe SafeBrowsingTest:Iframe The following have equivalent tests in NoStatePrefetch tests and have been deleted: SafeBrowsingTest:TopLevel SafeBrowsingTest:Subresource The following test has been ported over: SafeBrowsingTest:ServerRedirect Please see this spreadsheet for details: https://docs.google.com/spreadsheets/d/1LFPB4UhPWQkBRz481lz49zmS25znhjSDUtagtTTSPQo/edit?usp=sharing Bug: 898955 Change-Id: Ib99d58fc833f7c65adb3a908fc12d239ec635b28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300118Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#789895}
-
sandromaggi authored
It appears that waiting for the URL is flaky. This check is not really required for the test, as we only want to see the error appearing once the URL is committed (we can assume that the URL being entered into the location bar will eventually load). Bug: 1105146 Change-Id: I68ac2f5c5591dbcf8f85665429720152df9889b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306090Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#789894}
-
Alice Boxhall authored
This reverts commit f28b7fc7. Reason for revert: Seems to have caused breakages of tests: LookalikeUrlTestCase/testLookalikeUrlPageNoSuggestionClosePage LookalikeUrlTestCase/testLookalikeUrlPageNoSuggestion Flake dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=ios_chrome_web_eg2tests_module_iPhone%20(with%20patch)&tests=LookalikeUrlTestCase/testLookalikeUrlPageNoSuggestion Original change's description: > [omnibox] [rich-autocompletion] Unelide omnibox before setting focus. > > With the 1-line UI, rich autocompletion adds a label adjacent to the > omnibox and then resizes the two as the autocompletion length changes. > > On location bar focus, the omnibox is unelided; e.g. google.com is > unelided to https://www.google.com. > > Before this CL, unelision occurs *after* the location bar is given focus > and its layout computed. > > With this CL, unelision occurs *before* the location bar is given focus > so that it can reserve sufficient width for the unelided URL when > updating its layout. > > Bug: 1062446 > Change-Id: Id78d635255de69d9af97a5589a9e001eee3d0feb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304666 > Commit-Queue: manuk hovanesian <manukh@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#789698} TBR=tommycli@chromium.org,manukh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1062446 Change-Id: I0e46e30a07082a3ebb239dd6d05c65d46de64fd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306136Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#789893}
-
Jan Wilken Dörrie authored
This change updates the Password Check UI to use PasswordForm::url::GetOrigin() rather than PasswordForm::signon_realm for displaying origins. Bug: 1106042 Change-Id: If8a8c19539c5c3f58a7e81422879903bb07a4d43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301977 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#789892}
-
Bartek Nowierski authored
Tags aren't implemented for direct-map, hence remove the unit test entirely. Technically, we should also prevent allocate size from being increased by kInSlotTagBufferSize on that path, but that's too much effort. Bug: 1092288 Change-Id: Iecffe61120bd4f9c0e9321040338eda44b3dbc66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306121 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#789891}
-
Aya ElAttar authored
1. Changed TestClipboard to support DLP controller. 2. Added unittests to cover allowed/disallowed clipboard read based on the DLP controller. Bug: 1103215 Change-Id: Ibb6c7bf575dd0e514349c395fb965af203fe3b1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283207 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789890}
-
Viviane Yang authored
to PushManager This CL adds the capability to pass an expirationTime attribute from PushMessagingServiceImpl down to PushManager, when PushManager::get Subscription is called. It is an optional parameter specified in milliseconds from 1st January 1970 UTC according to the standard. https://w3c.github.io/push-api/#dfn-subscription-expiration-time When PushManager::getSubscription is called, expiration_time should be retrieved in PushMessagingServiceImpl from the app_identifier and sent back as a callback to PushMessagingManager, which sents it to PushPro- vider, converts it from a mojom::blink::PushSubscriptionPtr to a PushSubscription object and returned to PushManager. The expiration time will be stored in PushMessagingAppIdentifier, which is currently not implemented yet but WIP. It will then call PushMessagingServiceImpl::SubscribeEnd with a non-null value for expir- ation_time and pass the expiration time in SubscriptionInfoCallback. WIP Issue: 2302610 Change-Id: I1e6c69a930def902cd6f08813de5856ae08729fc Bug: 1104215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302192Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Viviane Yang <viviy@google.com> Cr-Commit-Position: refs/heads/master@{#789889}
-
Tanmoy Mollik authored
This cl adds new icons to show in the main settings page. The icons are used when MOBILE_IDENTITY_CONSISTENCY flag is on. Screenshot: https://crbug.com/1092857#c1 Bug: 1092857 Change-Id: Ibb56b4f4586d2ef9dcd29a198fdb9a50049140f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236406Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/559e6e50d226..270e6f332c41 2020-07-20 aerotwist@chromium.org Migrates a11y to devtools_entrypoint If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101738 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic89d2f4115c10acf073950d936ccae1e4dcb94b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307137Reviewed-by:
-
Matthias Körber authored
The CL introduces a data structure to manage address components that must support the duality of an structured and unstructured representation. Change-Id: I435d82f608718c29821671dd1fa303c5fb3caa24 Bug: 1099202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238191 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#789886}
-
Andrey Zaytsev authored
UI mocks: https://docs.google.com/presentation/d/13qExIGI7BDaSUGBAXR0B02VzKcIqVt5Y_vo0lC7nC04/edit#slide=id.g8b3f4ba7b6_2_7 Order: 1. Updates 2. Passwords 3. Safe Browsing Bug: 1070620 Change-Id: Ic2f97a2c6fdb088b5fa5ed107507eb7b2803e2f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307289 Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#789885}
-
Miyoung Shin authored
This CL converts FrameMsg_VisualStateRequest to FrameWidget Mojo message and FrameHostMsg_VisualStateResponse to the return callback of FrameWidget mojo message. The legacy IPC message sent a single IPC with the multiple sub IPC messages in reply, but this CL invokes each mojo message's callback queued in the queue when the frame swap has occurred. This CL also includes to - add WidgetCompositorHost interface bound on the compositor thread. - move the implementation of |visual_state_callbacks_| from RenderFrameHost to RenderWidgetHost. - introduce WidgetSwapQueue queuing |id| having the same source frame number to invoke the callbacks. Bug: 1071588 Change-Id: If8c4db40be397921d19ca6a9a9287760879f3ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2178480 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#789884}
-
Mark Cogan authored
The eg2 test target build of Chrome wasn't adding in the plist entries for multiwindow when the multiwindow gn flags were enabled, causing the tests to immediately crash if run with those flags. This CL copies the logic in i/c/app/BUILD.gn for including those plist fragments into the eg2 test .gni. Test: Compiled and ran an eg2 sub-suite with the multiwindow flags; it ran as expected (with some test failures, but no immediate crashes). Bug: 1105529 Change-Id: Ieb2541104fb70e7036497242f1df07cd93f2595e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299344 Auto-Submit: Mark Cogan <marq@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#789883}
-
Takashi Sakamoto authored
Bug: 1092288 Change-Id: I0b0f32d16a01128087fecf2c6b1b3b32ca07d4ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299941 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#789882}
-
Alice Wang authored
This CL removes the redundant argument accountName in the method AccountManagerTestRule#addAccount as this method is only responsible of adding an account and its corresponding profile data to the fake AccountManagerFacade and fake ProfileDataSource, so the accountName always equals the one in ProfileData. We can make this easier to have only one argument for this method. Bug: 1094298 Change-Id: I7a6136bf1f0d2e41376828dd95ddd91921bbe013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303398 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789881}
-
Mikel Astiz authored
crrev.com/c/2296420 recently introduced some heuristics that use the notion of when bookmarks were sync-ed for the last time. In such patch, the persistence of this time was overlooked, fixed here. Change-Id: I9eb5046e1dcae1affb99fe2fc732678c7d922dce Bug: 1032052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306033 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#789880}
-
Monica Basta authored
Screenshot: https://drive.google.com/file/d/1TVPFiVBhgMFsdfOHSL9AvrJqF_cHKFBC/view?usp=sharing Bug: 1063856 Change-Id: Ibaa987e941d11269eacfe1dc091dab234f8b206e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302034Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#789879}
-
Hiroki Nakagawa authored
For code simplification, this CL... - merges WebSharedWorker::Create() and StartWorkerContext() into CreateAndStart(), and - removes |worker_thread_| check from WebSharedWorkerImpl because it is always alive. Bug: 911415 Change-Id: If1921be5587c823562d4481e0bbf827b55bcb94f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307009 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#789878}
-
Philip Pfaffe authored
Test disabled to land https://crrev.com/c/2245146. Bug: chromium:1083146, chromium:1107339 Change-Id: I49fccfeed94c655b2a5f2893fe3b16cd25c90ca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306036Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Philip Pfaffe <pfaffe@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Auto-Submit: Philip Pfaffe <pfaffe@chromium.org> Cr-Commit-Position: refs/heads/master@{#789877}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8815d8ec324d..559e6e50d226 2020-07-20 aerotwist@chromium.org Moves generated scripts to devtools_module If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101738 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I66c43a51e9662d3dc4fad81a2e7b5025d0fd1e4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307133Reviewed-by:
-
Maggie Cai authored
This CL adds a version number in the preferred apps file to indication which format the preferred apps are stored. This will avoid going through the whole list over and over again to see if we need to upgrade the list. BUG=1092784 Test: Unit test PreferredAppsConverterTest Change-Id: I3c9aa33beded325fd8d9bb6713c8ea797cc0f8c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303741 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#789875}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/680c77fa6c81..717e7877cac1 2020-07-17 alanbaker@google.com Store location values sparsely (#3488) 2020-07-17 dneto@google.com Permit Simple and GLSL450 memory model in WEBGPU_0 (#3463) 2020-07-17 antonikarp@google.com spirv-fuzz: support floating-point in TransformationInvertComparisonOperator (#3551) 2020-07-17 stefanomil@google.com Change MaybeApplyTransformation to return a boolean (#3555) 2020-07-17 stefanomil@google.com spirv-fuzz: Implement MaybeApplyTransformation helper function (#3540) 2020-07-17 stefanomil@google.com spirv-fuzz: Assert false in IsApplicable method of TransformationAccessChain (#3528) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,timvp@google.com Change-Id: Ibe52f2f1d4c911df089c58c4ebdc59721a412b1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307130Reviewed-by:
-
Alex Rudenko authored
Adds a new option to GridHighlightConfig to display grid track sizes. Screenshot: https://i.imgur.com/JjSr5v2.png Frontend CL: https://crrev.com/c/2300099 Change-Id: Ic2a105128bce8c67ee41c3a153808ac171e5ea98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299343 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Brandon Goddard <brgoddar@microsoft.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#789873}
-
Eric Willigers authored
share() requests fail with a rejected promise if the 'web-share' feature is not enabled. We define 'self' as the default feature policy for web-share. The spec has been updated https://github.com/w3c/web-share/pull/166 Intent to Ship https://groups.google.com/a/chromium.org/g/blink-dev/c/fgme9KOd8CU/m/TCYPKQAXAwAJ Bug: 1079104 Change-Id: Id4030448a54589eddb45185cbd6fd8970aee34c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299791 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
-
Rob Buis authored
Setting URL.hash to '#' should set empty fragment identifier [1], unlike setting it to the empty string which drops the fragment identifier. Behavior matches Firefox. [1] https://html.spec.whatwg.org/#dom-hyperlink-hash Change-Id: Ibb577d0e362798bd81ce727f633e36f0be6c68fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302696Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#789871}
-
Anand K Mistry authored
DictionaryValue::RemoveWithoutPathExpansion() is deprecated. For the case where nullptr is passed for the output argument, Value::RemoveKey() is a trivial replacement. Mostly done with the following command line, plus a bit of finesse: % git grep -l RemoveWithoutPathExpansion | \ xargs sed -E -i 's/RemoveWithoutPathExpansion\((.*), nullptr/RemoveKey\(\1/g' Bug: 646113 This CL was uploaded by git cl split. R=fernandex@chromium.org Change-Id: I230ddff389ed6baeede4e0e95455f8aafe68f592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298880 Auto-Submit: Anand K Mistry <amistry@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#789870}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I95d79a293e50b13c7fa29449f14cdd96861eb86a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307131Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d969ac13d806..8ee58ef3895b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mmoskvitin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mmoskvitin@google.com Change-Id: I129d7f2eb30918068723aeba69ccc8080a4cae3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307129Reviewed-by:
-
Marc Treib authored
This helps recover from cases where the account store should have been cleared, but wasn't (e.g. badly-timed crash). Bug: 1079297 Change-Id: I57e6a53c4de7807aba7346531c7b2056b5ac100f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292518Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#789867}
-
