- 25 Sep, 2020 40 commits
-
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600991906-4a92707280f1746bc65f64969bacfc1c677580e0.profdata to chrome-linux-master-1601013503-f7b4ef4ea11cbf75355e6e56711fd1614dd080c3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: I3ae3142b139adec7e4ca40820482f86d065f90c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430663Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810552}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e11be3c4ad04..d4499bd576da 2020-09-25 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If9d4abe09c005149a31d2ad5fb367cbb1c8ac45a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430353Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium f0759378. With Chromium commits locally applied on WPT: 8f02a380 "Use allow attribute for delegation in web serial WPT" c1a7d15a "[LayoutNG] Multicol baseline propagation support." f30daabb "[COOP] access reporting: test with redirects." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools hbos@chromium.org, hta@chromium.org, guidou@chromium.org, philipp.hancke@googlemail.com: external/wpt/webrtc iclelland@chromium.org: external/wpt/feature-policy jsbell@chromium.org: external/wpt/resources lanwei@chromium.org: external/wpt/infrastructure/testdriver/actions nzolghadr@chromium.org: external/wpt/pointerlock NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I568c48ca68952a65c16500d747e4ab973ba04fd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429591Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810550}
-
Ehimare Okoyomon authored
Screenshot: https://crbug.com/1077766#c54 Bug: 1077766 Change-Id: I623a2b2e206b5b9471ed11c46af811c7786ba4b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428895Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#810549}
-
Clemens Arbesser authored
This is done in preparation for an upcoming new UKM where we need to know not just when the UI was shown, but also when the lite script started. I opted to rename the existing callback instead of introducing a new one. This is a refactoring only and should have no user-facing changes. Bug: b/169052568 Change-Id: I44d4033e20a8c7dfd4cca96be5a3c36388c8b1f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424319 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#810548}
-
Jan Wilken Dörrie authored
This reverts commit 404b7cc4. Reason for revert: Breaks tests on Win 7 Builder: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/108048 Original change's description: > FontAccess: Sort fonts in lexicographical order > > This change ensures fonts are sorted before being cached. This change is > due to a concern about fingerprinting: > https://github.com/w3ctag/design-reviews/issues/399#issuecomment-530679815 > > This change ensures that fonts are sorted in lexicographical order. > > Bug: 1043306 > Change-Id: Ia3acf2a45cb473124df4e489683bdc7bac15dde4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427040 > Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> > Reviewed-by: Joshua Bell <jsbell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810519} TBR=jsbell@chromium.org,oyiptong@chromium.org Change-Id: I75926b99ebb7e663875e0eae3d89d877f623a6ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1043306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431025Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#810547}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Ic882d1902635a141a73ea1d2248842ef70dc8ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429649Reviewed-by:
-
Tanmoy Mollik authored
Sync promo always shows the first account returned by AccountManagerFacade which might not be signed in. This cl makes sure that the account that is shown is the first signed in account. This cl also refactors some of the tests regrading sync promos. The behavior of the tests are not changed. Bug: 1131465 Change-Id: I46f2e607494c68d3b0608543095da4b22471f710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426485 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#810545}
-
Ravjit Singh Uppal authored
Add metrics that will record - Elapsed time between grant and permission use - Elapsed time between grant and revoke Only for Geolocation, mic and camera permission Bug: 1119738 Change-Id: Ia01cee7921b246844e90d789761f3beebebb98de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367832 Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#810544}
-
David Schinazi authored
This CL exists to work around an issue where some users are being configured with an outdated Finch config. It will ensure that we cannot accidentally configure Chrome to use these old obsolete versions. This CL includes an escape-hatch, it will be possible to add the obsolete_versions_allowed flag in Finch in case we want to intentionally enable obsolete versions for some future reason. This CL also applies to cronet, though with the exception that cronet currently allows Q043 as some cronet applications currently rely on it. R=renjietang@chromium.org Change-Id: I275e1797c3cab1e0ddd411520e113cb957365896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429868 Commit-Queue: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#810543}
-
Jit Yao Yap authored
Sync server-side changes from cl/331193690. Change-Id: I52afbafc55b5dc3804034acaaea08a31aa9cfd23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418660 Auto-Submit: Jit Yao Yap <jityao@google.com> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#810542}
-
Taylor Bergquist authored
Previously, this calculation used LayoutManager::GetAvailableSize, which relied on cached information that was cleared during layout. An extra layout was added to fill this cache, which caused no end of complexities in tabstrip layout. This is totally unnecessary, as all of the siblings of TabStrip are simple fixed-width controls - NTB, grab handle, tab search button, and scroll controls. A wee bit of arithmetic suffices. Bug: 1093972 Change-Id: I7758bd80ba37b31d5efeeafd208e093094ef5e17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426978Reviewed-by:
Connie Wan <connily@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#810541}
-
Richard Knoll authored
This test passes on local machines that have a real display attached to them but fail on bots without. Disable them for now until we find a way to run them without needing a display. The tests seem to be happy on Linux at least so keeping them for coverage. TBR=peter Bug: 1132058 Change-Id: I0b54d975957c4bc2ff3186a512f04f8f01135768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428899 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#810540}
-
Josiah K authored
(Fixing accessibilityPrivate.on* names to only be used for events 3/3) No functional changes - should be mechanical only. Also rename onAutoclickScrollableBoundsFound to handleAutoclickScrollableBoundsFound. AX-Relnotes: N/A Change-Id: I12806a694a94e58fa6fdb48280cc4cc3a4d44b52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422677 Commit-Queue: Josiah Krutz <josiahk@google.com> Auto-Submit: Josiah Krutz <josiahk@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#810539}
-
tby authored
Bug: 1034842 Change-Id: I49d8f211495f1ff3a95563ac184ed5ed69a511b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427606 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#810538}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d59bccb5df72..962e347302d7 2020-09-25 jmadill@chromium.org Fix return code of restricted trace tests. 2020-09-25 lehoangq@gmail.com Metal: Use shared memory for small dynamic buffers. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: I54128f0d1ad06d05cf543846aea083e14259a941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430654Reviewed-by:
-
Jan Wilken Dörrie authored
This reverts commit 64875586. Reason for revert: Speculatively reverting due to https://crbug.com/1132229. Original change's description: > Add Crash Restoration support for multi-window > > After a crash info bar will be presented on all foreground scenes > if the user choose to restore all foreground windows will be restored. > if not all windows tabs for all windows which were opened on the last > run will be added to the recent closed tabs. > > Bug: 1126311, 1114179 > Change-Id: I80623012dc132e2702004d2dbc0bbcb410a7d91c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415929 > Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> > Reviewed-by: Mark Cogan <marq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810406} TBR=marq@chromium.org,mrefaat@chromium.org Change-Id: I4045617e7eb138e0212f8b1d1062df7ce0b45f74 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1126311 Bug: 1114179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428972Reviewed-by:
-
Benoit Lize authored
When PartitionAlloc is malloc(), stats reporting cannot allocate memory. Make sure this is the case. Bug: 998048 Change-Id: If5198de1586de814844c1ca2d86abd65516e6716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428595 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#810535}
-
minch authored
Color of the ripple is no longer the opposite color of the background color, but either WHITE or BLACK based on the current color mode now. - Update AshColorProvider::GetRippleAttributes with default value to simplify most of the call sites. The default background color is GetBackgroundColor() for Shield and Base layer. - Hard code the logic of notification related, which will not going to support dark mode at the first stage. - Clean up. Removed some unnecessary functions and arguments. Bug: 1107056 Change-Id: I1adb4232f66c5433eb52920ac5b48c329ade35f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427623 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
-
Lingqi Chi authored
https://chromium-review.googlesource.com/c/chromium/src/+/821796 stopped using Net.ResourceLoader.ResponseStartToEnd..*. This CL adds the <obsolete> tag to remove these histograms. Bug: 686984 Change-Id: I30890e37016a6a30a5bfd8955aaed681f51f6011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423676 Commit-Queue: Lingqi Chi <lingqi@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#810533}
-
harrisonsean authored
Safety Check on iOS has an update check, to support this we are adding the ability to do one off checks to Omaha for iOS. If there is an ongoing scheduled ping, or one is scheduled during the one off check, it is taken by the one off check. Otherwise it will send its own ping. The one off check updates all user defaults for update status, and makes Chrome think that it has just shown an update infobar (if an update is available) so that users triggering an update check aren't shown an update infobar soon after being told they are out of date by the update check. Adds another user default to track if the device is up to date as of the last check (scheduled or one off). A device that is unable to update is considered up to date in this user default. Bug: 1078782 Change-Id: I2e4a1982dd0b34258c78c85ecf23e2f199630f1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398725 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#810532}
-
Alice Wang authored
This CL renames the sign-in methods in AccountManagerTestRule to signinAndEnableSync to be consistent with the new sign-in API. Bug: 1131936 Change-Id: I6507712ad38b37c987507bea549b4c9371946a2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429065 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#810531}
-
Ben Mason authored
Change-Id: I8ee6fc5e097c47b53fa8fd576ff60e97cbeca06c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429343 Commit-Queue: Ben Mason <benmason@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#810530}
-
Dom Schulz authored
Change-Id: I402355cc184d62341cdb6d2604113c6f7642d104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426369 Auto-Submit: Dominic Schulz <dominicschulz@google.com> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#810529}
-
Nick Harper authored
Change-Id: I960a85c72784e1cce26c69455fe28dd51d97cd35 Bug: 1127947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428536 Commit-Queue: Nick Harper <nharper@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Nick Harper <nharper@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#810528}
-
Kramer Ge authored
Using a 4x4 sized opaque background will not regress performance in underlay cases because the root surface is still opaque. The background will be stretched out by wayland viewporter extension. This is 6/? CL for overlay forwarding using wl_subsurface. Change-Id: I59b0d4cdbfbb6727d578e286c9d19cf69a9bff32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352523 Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#810527}
-
Rune Lillesveen authored
We have a DCHECK that ensures we start with initial style as the parent style if the element is the document root element, or if we are computing styles outside the flat tree, in which case we start at unassigned host children. A similar case is for fallback children of slots which are not part of the flat tree because the slot has assigned nodes from the host. Add that condition to the DCHECK along with a test. Bug: 1131767 Change-Id: Ic8a44f52273cc10a3a6936bf80b3b25ac0cb85d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426450Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#810526}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ibd795dce801aa79c63c0f33f75a0221ccec696fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429536Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810525}
-
Jan Wilken Dörrie authored
This reverts commit 349707ef. Reason for revert: Suspected culprit of https://crbug.com/1132219. Original change's description: > Create separate class to handle creation of holding space bubble > > This class will own pinned_files_container and recent_files_container. > It will also be responsible for setting the max size for the pinned > files container based on available screen space and update it when > screen space changes. > > Bug: 1131268 > Change-Id: If09810570e59f7beeac0667e84d4cd558ee67bc0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427081 > Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> > Reviewed-by: David Black <dmblack@google.com> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810423} TBR=xiyuan@chromium.org,dmblack@google.com,amehfooz@chromium.org Change-Id: Ia221abfb393dcd7f9cdfa7e539133477bd7852ca No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1131268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429275Reviewed-by:
-
Yuta Hijikata authored
g_log_format has to be set within BaseInitLoggingImpl regardless of the log target. BUG: None TEST: base_unittests Change-Id: I4690d537600eb0eb7e88e897435cf014e013e251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417738 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#810523}
-
Gyuyoung Kim authored
As discussed on platform-architecture-dev ML[1], this CL adds the guideline to public/README.md file for claryfing the naming conventions in public/web/, platform/, and common/ [1] https://groups.google.com/a/chromium.org/g/platform-architecture-dev/c/qrZLqP4ndJE/m/uiBiljN9BwAJ Bug: None Change-Id: I51eceae18b16a282b61a65f7ff4d0f16c566c114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429982Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#810522}
-
Josh Simmons authored
Replaced the existing icons with new icons that have a different style. Test: Looked at Files.app icon in launcher, shelf and switcher Bug: 1128673 Change-Id: I55e3a586dd6ea9ab7f03134d4992eb6e7e2ae92d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430564Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Josh Simmons <simmonsjosh@google.com> Cr-Commit-Position: refs/heads/master@{#810521}
-
Nela Kaczmarek authored
[Passwords] Use OneShotTimer to wait for the result of Affiliation Service prefetch before the redirect action. This change implements OneShotTimer that waits for the result of Affiliation Service prefetch. The result or timeout is followed by redirection to change password url or origin. The facet to be requested in Affiliation Service is now created from SchemeHostPort type which removes the relative path. Bug: 1108279 Change-Id: I2c47dc3b0b70bc9768b967441762b80a965386cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401165 Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com> Reviewed-by:
-
Olivier Yiptong authored
This change ensures fonts are sorted before being cached. This change is due to a concern about fingerprinting: https://github.com/w3ctag/design-reviews/issues/399#issuecomment-530679815 This change ensures that fonts are sorted in lexicographical order. Bug: 1043306 Change-Id: Ia3acf2a45cb473124df4e489683bdc7bac15dde4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427040 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#810519}
-
Sebastien Marchand authored
The BrowserContextKeyedServiceFactory are leaked between tests (by design) and this is problematic with the SiteDataCacheFacadeFactory because it owns an SiteDataCacheFactory object in a SequenceBound wrapper. Leaking this between tests causes UAFs on the task runner used by this SequenceBound wrapper. The solution consists in tracking the number of alive SiteDataCacheFacade instances and releasing the SiteDataCacheFactory when this count reaches 0. As profiles always get destroyed before terminating a test this ensures that we don't leak the SiteDataCacheFactory anymore. Bug: 1127928 Change-Id: I88777d8761f60aeeb90322234f861d196ed9e548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422079 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#810518}
-
Jan Wilken Dörrie authored
This reverts commit 5c550b35. Reason for revert: Suspected culprit of https://crbug.com/1132207. Original change's description: > Improve name calc handling of hidden objects, relation traversal > > - Display: none objects should not get an accessible name. > - EnsureComputedStyle() should not be called during a potentially unsafe > time. This is fixed by calling it during Init(), in cases where it > will likely be needed (inside a display:none subtree). > - Remove unnecessary and often incorrect heuristic for determining when > inside an aria-labelledby or aria-describedy calculation. This flag is > already passed in via recursion when following that kind of relation. > - Do not recurse into children that are explicitly hidden > - Improve explicitly hidden computation for CSS visibility. Explicitly > hidden means that the element was specifically hidden, and that it > didn't just inherit the fact that it's hidden. > - Improve results in name-calc-visibility, where an element explicitly > referenced by aria-labelledby wasn't included in the name because it > was visibility:hidden element. Elements that are explicitly referenced > must be included in a name or description even if they are hidden. > > Bug: 1130436 > Change-Id: I58b7b70b53c5c1d37ec1407bc2ecb35de3d17d4a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212795 > Reviewed-by: vmpstr <vmpstr@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810426} TBR=dmazzoni@chromium.org,vmpstr@chromium.org,aleventhal@chromium.org Change-Id: Ia243d9fe2495af7646f6af6deb79b967bf4b0bec No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1130436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428969Reviewed-by:
-
Ayu Ishii authored
This change ships the Cookie Store API to stable. It also removes some IDL changes that were necessary to get around an issue caused by the combination of Expose, partial interface and Origin Trial integration. More details on this can be found here [1], [2]. Intent 2 Ship: https://groups.google.com/u/2/a/chromium.org/g/blink-dev/c/zOsGZGMGiM4 [1] Work around implementation: https://crrev.com/c/2191240 [2] IDL crbug: https://crbug.com/839117 Bug: 729800 Change-Id: I26ffdabb316ef49f560d78945d818123fd64b39d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411149 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#810516}
-
Colin Blundell authored
This API was removed in https://chromium-review.googlesource.com/c/chromium/src/+/2225821. The continued presence of this permissions check for the deleted API causes a crash in debug builds. This CL removes the check, adjusts associated unittests, and deprecates the permission. Bug: 986981 Change-Id: I1b9a6596d8dd0af5a80f0fd2348b11569273cbaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428923Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#810515}
-
Trent Apted authored
Usage was removed in r801695 Bug: 909963 Change-Id: I57d8b7faabede399f62911e58c40c833a60312a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430684Reviewed-by:
-
harrisonsean authored
Add support for a timestamp of when safety check last found issues. Add support for initial unsafe states to only show if a safety check has previously found isses. Bug: 1078782 Change-Id: Ica710b284c066684cfad8488ada996295756ac29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421310 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#810513}
-
