- 09 Dec, 2020 40 commits
-
-
Stephan Hartmann authored
https://chromium-review.googlesource.com/c/chromium/src/+/1687411 renamed ideographicSpaceCharacter to kIdeographicSpaceCharacter. Bug: None Change-Id: I5f74dfa489cdca4927a8132bed209549702ca947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574740Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#835231}
-
Marijn Kruisselbrink authored
A significant amount of time is spent doing blob related things in these tests, so including Blob trace events in the recorded traces should make it easier to figure out what is going on with performance regressions. Bug: 1156511 Change-Id: I09d0455561a5a01b71f618d7a1de368ea5fd3cf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580520Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#835230}
-
Clark DuVall authored
This creates a new throwaway instance of ChromeTabbedActivity in a background thread to warm up the chrome ClassLoader, and mitigate some of the effects of having chrome/base in separate dex files. This runs right after the context is created in the background to give maximum time for the activity preload, otherwise it would have to wait until SplitPreloader.wait() was called or the UI thread task was run. Pinpoint runs: Pixel 2: https://pinpoint-dot-chromeperf.appspot.com/job/17167144d20000 -12.2% messageloop_start_time -3.4% first_contentful_paint_time -4.3% navigation_commit_time Android Go: https://pinpoint-dot-chromeperf.appspot.com/job/124ca260d20000 -3.9% messageloop_start_time -0.8% first_contentful_paint_time -1.6% navigation_commit_time Bug: 1150600 Change-Id: I60ee5469c8a67ff5c27854fb09b4eeea80f43047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577627 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#835229}
-
Joshua Pawlicki authored
As usual, its callers must be made async as well (except in tests), all the way back up to the nearest PostTask. To avoid too many PostTasks, its methods now accept batches of ids. Bug: 1142591 Change-Id: I53be2948dbe46ab020da1cd096ee59b775ac842c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569779 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#835228}
-
Adrian Taylor authored
Change-Id: I7042ac6e24e8ed1ba8a1cedee9da73a2819196c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578750 Commit-Queue: Adrian Taylor <adetaylor@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Adrian Taylor <adetaylor@chromium.org> Cr-Commit-Position: refs/heads/master@{#835227}
-
Javier Ernesto Flores Robles authored
Bug: N/A Change-Id: I33bf48d8b8b692dece0ffc672e0163aec7d04634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580400 Commit-Queue: Javier Flores <javierrobles@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#835226}
-
Charlie Hu authored
Bug: 1151954 Change-Id: Id0f261a003367bb43ba149c4aa41a598b0a701ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577010 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#835225}
-
Primiano Tucci authored
Also add method signature changes to deal with r.android.com/1517038. https://android.googlesource.com/platform/external/perfetto.git/+log/b5c844554e30..83448c4da727 2020-12-09 lalitm@google.com Merge "tp: fix ub of modifying vector while iterating through it" 2020-12-09 khokhlov@google.com Fix NaCl build 2020-12-09 lalitm@google.com Merge "ui: fix cpu time canned query" 2020-12-09 fmayer@google.com Merge "Wrap path data in quotes before passing to llvm-symbolizer" 2020-12-09 marcinoc@google.com Add SysUI CUJ jank causes to Perfetto UI 2020-12-09 primiano@google.com Merge changes I22de67b3,Ief3ea5d6 Bug: chromium:161781469 Change-Id: I43a2cb360bce49be578862ca907db8d0bd751703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582038 Auto-Submit: Primiano Tucci <primiano@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#835224}
-
danakj authored
These bitmaps are safer for transport from untrustworthy sources since all bitmaps should be in N32 format and the browser can make bad assumptions as a result. R=dcheng@chromium.org, rsesek@chromium.org Bug: 1144462 Change-Id: Ib88b2e6ffacf214e5ff1880419cf0ff48ff15aac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580583Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#835223}
-
Yann Dago authored
Bug: 1149462 Change-Id: I1c2742a29e46cef8f30f02c942ba0ec8a34eff54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561528Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#835222}
-
Javier Ernesto Flores Robles authored
Bug: 1110296 Change-Id: I36f85d4b2c03dfb433ec886aaf5189d9bbb7d11d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580844Reviewed-by:
-
edchin authored
This was originally created in Dec 2017 in this CL: https://chromium-review.googlesource.com/838303 This metric is no longer being used and has already expired since M77. Per go/histogram-expiry-guidelines: "If the histogram is not in use now, but might be useful in the far future, remove it." Change-Id: If9050d662980fd38bcf8c89cb77ea95c1b2c74ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580405 Auto-Submit: edchin <edchin@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#835220}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/2a46c6172edb..ed88fdb2f824 2020-12-09 chrome-bot@chromium.org Update config settings by config-updater. 2020-12-09 drinkcat@chromium.org Revert "build api push_image endpoint" 2020-12-09 jackneus@google.com build api push_image endpoint 2020-12-09 vapier@chromium.org sdk: start new dir for holding supplemental sdk files 2020-12-09 vbendeb@google.com trigger_cr50_signing: make it generic for gsc 2020-12-09 boleynsu@google.com image_test.py: fix TestBlockedFileTypes accidentally blocking csh files 2020-12-09 engeg@google.com Freshen API bindings 2020-12-09 chrome-bot@chromium.org Update config settings by config-updater. 2020-12-09 bmgordon@chromium.org cros_sdk: Check for mounted chroot image 2020-12-09 chrome-bot@chromium.org Update config settings by config-updater. 2020-12-08 mmortensen@google.com GatherSymbolFiles: Specify that file collision handling is not needed. 2020-12-08 vapier@chromium.org lint_unittest: drop Python 2 coverage If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I818064ea9244e27cbe8541c05892836e2dd90819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581998Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835219}
-
Xi Han authored
The bug was caused by setting a null TabProperties.TAB_CLOSED_LISTENER when Instant start is enabled. Bug: 1155682 Change-Id: I95190faaf544bea8e524f2a1b2dbe50d66f68430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575209Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#835218}
-
Mason Freed authored
Bug: 966758,937746 Change-Id: Ic1c231091f9f0644594ad7df70c60cac09183f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580820 Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#835217}
-
Thiemo Nagel authored
This reverts commit 258f8486. Reason for revert: failure in browser_tests/TabStripTabListTest.All As unlikely as it looks (to me), I've bisected test failure to this CL Builder Linux Tests (dbg)(1): https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29 Original change's description: > IO: Use pre-margin target rect for an empty check for intersection threshold > > This patch ensures that we use a pre-margin version of the target rect > if we are checking whether it was empty. This is to make sure that we > compute a "1" intersection ratio in cases where an ancestor of a > margin-padded target causes it to be empty. > > In this case, we should report 1 intersection, because we are intersecting > and target is an empty rect. However, because we padded the target > with a margin, we ended up doing the wrong check and ultimately compute > 0 intersection in a different conditional branch (before this patch). > > This patch restores correct behavior. > > R=szager@chromium.org, chrishtr@chromium.org > Fixed: 1156815 > > Change-Id: I1697388dd127737a0203d1c3ff15095de4ab41df > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580046 > Reviewed-by: Stefan Zager <szager@chromium.org> > Commit-Queue: vmpstr <vmpstr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#834930} TBR=szager@chromium.org,vmpstr@chromium.org,chrishtr@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Idf7927cbd535d91db51da4f3f97280c2359e9b97 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582059Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#835216}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1607471901-d1b17db4d547397f57796df9fcd9057f4117af9e.profdata to chrome-win64-master-1607493425-f89e2101ace78ecc71e64b80849cb2e4ad48ac79.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I49ca1de91d840636e22a293415660b15756943e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581407Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5e744acfad58..8670c9887529 2020-12-09 bsalomon@google.com Remove SkImage::MakeFromYUVATexturesCopyToExternal If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jmbetancourt@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jmbetancourt@google.com Change-Id: Ib5c69c877655b8e1e5479140b1954fbc76147d6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581881Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/30805557e651..99d6c14a3b34 2020-12-09 cwallez@chromium.org CMake: set DAWN_ENABLE_WGSL to ON by default. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: I65429f8b7174b593364bf12104db67cbe7d9ca6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582000Reviewed-by:
-
arthursonzogni authored
From the browser process point of view: - javascript-url document. - XSLT document. - document.open document. Are all a no-op. (e.g. no IPC sent to the browser process). The security properties of the document shouldn't change. There was a bug about sandbox_flags inheritance and javascript-url. We weren't inheriting from the right flags. Bug: 1151954 Change-Id: I7dc3cdfff4eaa8d0db02a2aaab6963a6aa3c8ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577211Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#835212}
-
Clemens Arbesser authored
This fixes a bug where the trigger prompt would stay visible in non-interactable tabs (such as during tab selection). To keep things simple, changing from interactable to non-interactable and vice-versa is treated the same as a change to a tab's visibility. Trigger scripts will now only be offered if a tab is both visible and interactable. Bug: b/175132318 Change-Id: Ie25831ecd16220e351ec1cc231fda470d34873dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579784Reviewed-by:
Michele Mancina <micantox@google.com> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#835211}
-
Jan Wilken Dörrie authored
This change replaces mentions of Blacklist with Blocklist in CredentialCache and OriginCredentialStore. Bug: 1147799 Change-Id: I3aa875d0bd6c2e54039202348435576da86af4f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579794Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#835210}
-
Sahir Vellani authored
Through experimentation, it is found that enabling SmoothnessModeForAnimatedScrolls results in an improvement in scroll latency but a regression in throughput. To investigate this, we are enabling this feature on the bots so that benchmark traces can be collected. Bug: 1056460 Change-Id: I46845f214b6524f92f2329abc0d8c60e3d6413d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574956Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Cr-Commit-Position: refs/heads/master@{#835209}
-
Liquan (Max) Gu authored
Since Chrome is moving away for having UI code depend on ChromeActivity, this CL replaces some ChromeActivity use cases with Context. Bug: 1155788 Change-Id: I3cdf464758e0b639cd1edec26fb00ddfbd27bc6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579726 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#835208}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d19d663924f1..4c1463884785 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tnagel@google.com,anthonyvd@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tnagel@google.com,anthonyvd@google.com Change-Id: Iff397fbc0af138a2f8ffd2400dc2aab498ab6b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581898Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835207}
-
Michael Savigny authored
Adds 'checkout_reclient' and 'reclient_version' to the vars to check for consistency between DEPS and buildtools/DEPS. Bug: 1149386 Change-Id: I708ba052914dc7bda6f38f1dd4198d859318b970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579809 Commit-Queue: Michael Savigny <msavigny@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#835206}
-
Mihai Sardarescu authored
When the user clicks on "Cancel" on the sync confirmation dialog, only the sync consent is revoked (the primary acount is *not* cleared), so it naming the corresponding enum entry ABORT_SYNC instead of ABORT_SIGNIN is more accurate. Bug: 1155505 Change-Id: Ibc032c1c7f7e9b5493cdb1f8b4f996152f9d7f8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578842 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#835205}
-
Ilya Sherman authored
R=chromium-metrics-reviews@google.com Bug: 954310 Change-Id: I4a612300989a1aee0ed03ab859e0a132ac91ff0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581518 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
-
Benoit Lize authored
This is possibly the cause of browser process crashes on Windows. Disable it only on this platform to ease investigation. Bug: 1155905 Change-Id: I6a5330479cb701c4b74da1986c2620d41056960c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582018Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
-
Maria Kazinova authored
VotesUploader uploades password votes on form submission. These votes are used to generate server predictions that are requested and received on the pageload. Thus if the form is changed dynamically, it makes sense to send votes for the form signature that is seen on the pageload. This CL starts using initial form signatures instead of signatures seen at the moment of submission. Bug: 1157048 Change-Id: I13f51852c2b9447625ae6d20cd335e481dcab4e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578900Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#835202}
-
Caitlin Fischer authored
This partially reverts crrev.com/c/2247706 and crrev.com/c/2245049. A couple of the Android tests that were ported to chrome/browser/metrics/ukm_browsertest.cc are flaky. Temporarily re-adding this test file ensures we have coverage while we fix the tests. The tests being re-added are consentAddedButNoSyncCheck and singleSyncSignoutCheck. Also, note that mSyncTestRule.startMainActivityOnBlankPage(); is being removed from setUp() because this is done before setUp() here [1]. Calling startMainActivityOnBlankPage() twice, once via SyncTestRule and again via setUp(), results in a TimeoutException [2] the second time startMainActivityOnBlankPage() is called. A log is in [3]. [1] https://source.chromium.org/chromium/chromium/src/+/master:chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTestRule.java;l=358 [2] java.lang.RuntimeException: java.util.concurrent.TimeoutException: No Activity reached target state. [3] https://paste.googleplex.com/6459114528964608 Original change's description: > Remove a UKM test that should have been deleted. > > In the below comment, it was requested that the corresponding Android > test be removed. > https://chromium-review.googlesource.com/c/chromium/src/+/1869007/12/chrome/browser/metrics/ukm_browsertest.cc#b646 > > Bug: 1049736 > Change-Id: Iac3ff27fc4d8145bef53d45aecb54efeda5e55f6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245049 > Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779285} TBR=rkaplow@chromium.org,treib@chromium.org,caitlinfischer@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1049736 Change-Id: I7dbc36f70ec7b9a567c7c0bb1594081c5e08dadd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578057Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
-
Ben Wagner authored
This is a reland of 9c270678 Fixed invalid unit and improved the error message for an invalid unit. `./tools/perf/run_benchmark run webrtc --browser=system` passes locally on Mac. Original change's description: > Mark some WebRTC perf measurements as biggerIsBetter > > Change-Id: I95a145f0380b0f413a71ef5a9bbacf840eb20b9f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577205 > Commit-Queue: John Chen <johnchen@chromium.org> > Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com> > Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#834889} Change-Id: Id7220dafb11faab2cb3e28b36aed3c6a526575c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580072Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com> Cr-Commit-Position: refs/heads/master@{#835200}
-
Thomas Lukaszewicz authored
This CL sets initial focus for the TaskManagerView dialog to |table_view_|. Currently this is set to nullptr and this means screen readers are unable to navigate the UI without first having to manually assign focus via the tab button. This change allows for screen readers to navigate the UI as soon as the dialog opens without needing to tab to assign focus. Bug: 1106544 Change-Id: I6f96b0ae024eee8e99d66f7a34c609d063e1cb36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580137Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#835199}
-
danakj authored
These bitmaps are safer for transport from untrustworthy sources since all bitmaps should be in N32 format and the browser can make bad assumptions as a result. R=dcheng@chromium.org, sebsg@chromium.org Bug: 1144462 Change-Id: I308ab745a5bfac1696be89e181b100d33db5d602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580026Reviewed-by:
-
Justin Donnelly authored
Bug: 1107581, 1056384 Change-Id: I2bad60bde8f5ccffeb7e63dedc22e123c74011ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580065Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202012090600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/ZueO-HxBTDWZN-HMbvrJcn0XYxqL_NdiiGI2U_5ui9IC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138961540,b/158963860,b/167637550,b/169112730,b/174421354 Tbr: media-app@grotations.appspotmail.com Change-Id: Ia34e36225758d849b566acd5bd0d19e57c013fbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581880Reviewed-by:
-
Jeremy Roman authored
This was wrong but probably harmless (both because it has zero length and because it's in a NOTREACHED path), but was introduced in: https://chromium-review.googlesource.com/c/chromium/src/+/2562819 Spotted by jdoerrie@ using bugprone-dangling-handle: https://docs.google.com/document/d/1LxxcYJSQGcc2dxdLAjpyZt6Rar00i_du7cfvX0UBtP4/edit Change-Id: I49722848a159bb8330362b5932199bff23cc476b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580086 Auto-Submit: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#835195}
-
edchin authored
This was originally created in Nov 2017 in this CL: https://chromium-review.googlesource.com/760036 This metric is no longer being used and has already expired since M77. Per go/histogram-expiry-guidelines: "If the histogram is not in use now, but might be useful in the far future, remove it." Change-Id: Ic8e899f850f8cea0774500eabe43e87f0aaf87d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581003 Auto-Submit: edchin <edchin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#835194}
-
Mohsen Izadi authored
To be able to report main thread event dispatch breakdowns for EventLatency metrics, this CL adds relevant timestamps to cc::EventMetrics. The actual breakdowns will be added to UMAs and UKMs in follow-up CLs. Bug: 1054009 Change-Id: Ia78d2614d4a3e2e4e5de75e2305e16888acbeeb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568936Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#835193}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2523885b..7e546be6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I111ed178f0e22739afdc39f7297eb74ce363b65c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581445Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835192}
-
