- 21 Mar, 2018 40 commits
-
-
Sebastien Marchand authored
Bug: 822265 Change-Id: I673454d4761e51389039c4f17332125e13487dd3 Reviewed-on: https://chromium-review.googlesource.com/973461Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#544820}
-
Gabriel Charette authored
I'm tired of having to call a static method deep into content/test just to RunUntilIdle. This brings TestBrowserThreadBundle to feature parity with ScopedTaskEnvironment in this space which makes sense as the two are interchangeable. This also comes closer to robliao's goal of getting rid of TaskScheduler::FlushForTesting() (used by content::RunAllTasksUntilIdle()). And lastly, it makes cleanups in crbug.com/823797 less ugly as some of them will need to go from using a ScopedTaskEnvironment to a TestBrowserThreadBundle and reverting them back to static global flush is ugly. R=jam@chromium.org, robliao@chromium.org Bug: 823797, 824431 Change-Id: I9f3127f3e46a520fd2d7105ed8139f1046cb3f73 Reviewed-on: https://chromium-review.googlesource.com/971821 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#544819}
-
Hiroki Nakagawa authored
Bug: 624696 Change-Id: I1a501ec3b90dc135fef41274818b94dd80557cc1 Reviewed-on: https://chromium-review.googlesource.com/972782Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#544818}
-
Jun Cai authored
This CL updates PlatformSensorProviderLinux to construct a ABSOLUTE_ORIENTATION_* fusion sensor using ACCELEROMETER and MAGNETOMETER by using the existing AbsoluteOrientationEulerAnglesFusionAlgorithmUsingAccelerometerAndMagnetometer and OrientationQuaternionFusionAlgorithmUsingEulerAngles fusion sensor algorithms. Bug: 777739 Change-Id: I179a7096a205affadaac9ac2ac42c40747f7f67d Reviewed-on: https://chromium-review.googlesource.com/972452 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#544817}
-
https://skia.googlesource.com/skia.git/+log/e65a5cd3fc34..ca37f32c7014 $ git log e65a5cd3f..ca37f32c7 --date=short --no-merges --format='%ad %ae %s' 2018-03-08 reed change canvas-state to just record clip bounds 2018-03-21 halcanary GrGLExtensions: remove unneded unique_ptr 2018-03-21 djsollen Update Android build file for SkQP to point to ndk compliant libjsoncpp 2018-03-16 egdaniel Fix version check for vulkan layers 2018-03-21 robertphillips Add texture-specific flags for External & Rectangle textures Created with: roll-dep src/third_party/skia BUG=chromium:b/74442448 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I331333d4c93630a485bf1ea018139774dba82d97 Reviewed-on: https://chromium-review.googlesource.com/973758Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544816}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b2c284af..ab2ca46a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I0b3cff8883b0fcfc39ec0aebe26951377e2a84ce Reviewed-on: https://chromium-review.googlesource.com/973582Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#544815}
-
Charles Harrison authored
We forgot to launch this by default, and the experiment ended in M63. Launch now and optionally ramp up M65+. Bug: 599875 Change-Id: I0e49ec389ab4aa679bd3e98e3493facef04e02b5 Reviewed-on: https://chromium-review.googlesource.com/973559Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#544814}
-
https://pdfium.googlesource.com/pdfium.git/+log/a17ac192c043..36bbc24e2d7e $ git log a17ac192c..36bbc24e2 --date=short --no-merges --format='%ad %ae %s' 2018-03-21 thestig Use more const pointers in CPDF_ContentMarkItem. 2018-03-21 thestig Rename foo_{wid,hei} to foo_{width,height}. 2018-03-21 dsinclair Move declarations in pdfium_test closer to usage 2018-03-21 thestig Rename "des_foo" to "dest_foo". 2018-03-21 thestig Add helpers to work with FXDIB_Format. 2018-03-21 thestig Add a regression test for bug 821454. Created with: roll-dep src/third_party/pdfium BUG=chromium:823369 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I10bca8d9dffb4b94a8c031e738d5bf27eb13f89e Reviewed-on: https://chromium-review.googlesource.com/973891 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544813}
-
Charles Harrison authored
Bug: 822624 Change-Id: I1ffee8e38bee2e016dc6beddd3eb05464def68a8 Reviewed-on: https://chromium-review.googlesource.com/966494 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#544812}
-
erikchen authored
In order to accomplish this, I added a non-lock based mechanism [TLS] to acquire the name of the current thread. In the process, I updated the SetName() API to only allow name-setting for the current thread. Bug: 809221 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ic3e63c396c6ddda6da4b8d74abb3083ff22cfa8c Reviewed-on: https://chromium-review.googlesource.com/969403 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#544811}
-
Sunny Sachanandani authored
Remove the DCHECK for wait order number, and remove the spammy invalid client wait logging. R=piman BUG=797137,824430 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I9bcdcab80c01b708817c31a4d7ad5f5e885226c9 Reviewed-on: https://chromium-review.googlesource.com/969968 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#544810}
-
Zhongyi Shi authored
- connection will not be closed if there's any packet write error when sending connectivity probes as those are sent on a different path; - connection will not be blocked if the connectivity probe is sent by a non-default packet writer. Flag protected by quic_handle_write_results_for_connectivity_probe. Manually merge internal change: 189676976. Change-Id: Ie0389f3342365ed93d1c12c414e90a5118a004de Reviewed-on: https://chromium-review.googlesource.com/972349Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#544809}
-
Xiaoqian Dai authored
Previously, we updated the split view's state when a SnapWindow() request comes in. We should update it after the window is actually snapped. This CL is the first step of crbug.com/822487. Bug: 822487 Change-Id: I476aa18982094f182f19b752bf91daa76f47fef7 Reviewed-on: https://chromium-review.googlesource.com/967362 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#544808}
-
Reza.Zakerinasab authored
TBR=junov@chromium.org Bug: 823260 Change-Id: I9851d6ff38c36c16edbdfa1cb715957e8e6e3eed Reviewed-on: https://chromium-review.googlesource.com/973554Reviewed-by:
Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#544807}
-
liberato@chromium.org authored
Previously, we would use the (optional) CommandBufferIdPtr when building a MojoVideoDecoder. However, this is not such a good idea when it's null. This CL causes MojoVideoDecoder construction to fail gracefully for all platforms, since all platforms currently require it. Bug: 813245 Change-Id: Ia513da0ab64e06a0c5a586515c82009ecc3ffaf6 Reviewed-on: https://chromium-review.googlesource.com/973557Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#544806}
-
Aleks Totic authored
Broken image was caused by not positioning of placed floats Bug: 635619 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ifb60bee7defeaa9e4ca2bacab9c6607b482b5e8f Reviewed-on: https://chromium-review.googlesource.com/973700 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#544805}
-
Harald Alvestrand authored
This verifies that the sender throws the right error when called after the connection closing. Bug: chromium:822799 Change-Id: Id3ab4ddc65b1510526fa49b7bfe3f9f95a7f2d65 Reviewed-on: https://chromium-review.googlesource.com/968927Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#544804}
-
Yuke Liao authored
content_browsertests is slow on Linux Chromium OS ASan LSan Tests (1), causing test timeout. This CL shards the test target. Bug: 822461 Change-Id: I5924dc7deaae63b3a0709a0c97b4d1b46d1fbbe8 Reviewed-on: https://chromium-review.googlesource.com/973555 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#544803}
-
Tom Anderson authored
libX11-xcb.so.1 is required to generate the v8 context shapshot. This was causing the LUCI version of Linux Build (dbg)(32) to fail [1]. Patch adapted from [2] from timbrown@. [1] https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8951515267836408512%2F%2B%2Fsteps%2Fcompile%2F0%2Fstdout [2] https://chromium-review.googlesource.com/c/chromium/src/+/940196 BUG=823962 R=dpranke CC=timbrown Change-Id: I8fa8f8d8281613193bc9faf2f2c0c86d900ac401 Reviewed-on: https://chromium-review.googlesource.com/972590Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#544802}
-
Alex Moshchuk authored
This CL fixes a bug where IsSwappedOut() always marked the RVH as inactive and swapped-out. This is incorrect in the case where the RVH has been reused by another navigation that has already made it active. The timing for that is hard to nail: usually, reusing a renderer process for another navigation implies that the new navigation needs to wait for a previous unload handler to finish running before a new navigation can be started/committed. However, if the navigation that reuses the RVH is coming off of a cross-site sad tab page, it will commit the pending RFH in the browser immediately, before the navigation actually takes places in the renderer, which makes it possible for a late swapout ACK from an unload handler to arrive after CommitPending() has already marked the reused RVH as active. Bug: 823567 Change-Id: I934ad70d3bd92d03f795291d603fb584f24b6c54 Reviewed-on: https://chromium-review.googlesource.com/971304 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#544801}
-
Yuqian Li authored
Please also see https://skia-review.googlesource.com/c/skia/+/115583 Change-Id: Icbf5a077d9b364c25b6d0be1e1f0c68607d3747c Reviewed-on: https://chromium-review.googlesource.com/973382Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Yuqian Li <liyuqian@chromium.org> Cr-Commit-Position: refs/heads/master@{#544800}
-
Evan Stade authored
The default ctor is used for mojo. These fields are not copied over so they need to be initialized. Bug: 824097 Change-Id: I2f37acfbc36790c53064d2c467989878674c6e43 Reviewed-on: https://chromium-review.googlesource.com/973541Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#544799}
-
Joy Ming authored
When small files are downloaded on Pixel 2 running Android P, the call to stop the foreground is called to closely to the call to start the foreground, resulting in a race condition that causes the notification to continue to be pinned to the foreground and remain sticky. This issue has been reported to the Android notifications team, but this CL provides a workaround that waits a few milliseconds after the foreground has started before stoppping it. Bug: b/74236718 Change-Id: I6f24cb5e8b84b4c3f6868c00aa4ce1797141ea87 Reviewed-on: https://chromium-review.googlesource.com/969752 Commit-Queue: Joy Ming <jming@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544798}
-
Christian Dullweber authored
The CHECK() in tab_restore_service is still failing because there are SerializedNavigationEntries where index() is not consistent with their position in Tab::navigations. This will be fixed by not relying on the index at all. Bug: 822628 Change-Id: Ie428b838fee6eeb8ba4147136d13a61aeb5fe97a Reviewed-on: https://chromium-review.googlesource.com/966030Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#544797}
-
Eugene But authored
This adds animations for the following state transitioning: - In Progress -> Succeeded (done badge scaled up) - In Progress -> Failed (error badge scaled up) - Failed -> In Progress (error badge scaled down) The badge is CALayer backed up by CGImage. Bug: 820178 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I65b96457449d462c76b5c4f1e93fede15e658731 Reviewed-on: https://chromium-review.googlesource.com/972563Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#544796}
-
https://chromium.googlesource.com/angle/angle.git/+log/115b2c4a2fc6..40b1c77070fd $ git log 115b2c4a2..40b1c7707 --date=short --no-merges --format='%ad %ae %s' 2018-03-19 oetuaho Fix asserts related to writing nameless parameters in HLSL 2018-03-15 jiawei.shao ES31: Support queries on primitives generated by geometry shader 2018-03-19 oetuaho Share parameter arrays more between built-in functions Created with: roll-dep src/third_party/angle BUG=chromium:823041 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I262820d80f2f8c21158bf71c42c4136c47a8ab09 Reviewed-on: https://chromium-review.googlesource.com/973842 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544795}
-
Andrey Lushnikov authored
This patch starts skipping indexing for excluded folders. R=pfeldman, dgozman, caseq Change-Id: I862b45b56afe8798d9b54772014ffe8002f12007 Reviewed-on: https://chromium-review.googlesource.com/972579 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#544794}
-
Martin Sramek authored
...by replacing it with an empty string. This happens automatically in TextView#setText(), but must be now also done explicitly when putting it into |mTextViewToMetadataMap|. This CL only remedies the crash, does not yet attempt to investigate the issue which seems to have existed before the crash was introduced. See the linked bug for more details. Bug: 821908 Change-Id: I4ae1c2467a3ac2d24a63f0e56fc6353b427c8e38 Reviewed-on: https://chromium-review.googlesource.com/967202Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#544793}
-
Peter Wen authored
Use apk analyzer to parse dex files in apks. Make use of .jar.info files to attribute size to source files. Bug: 723820 Change-Id: I5cdbff6000d585d7903a40bccaaf95ead0370b34 Reviewed-on: https://chromium-review.googlesource.com/949452 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#544792}
-
chaopeng authored
This issue is caused by force_enable_zoom is not updated to the recreated input router when open the new tab. In this patch, we record the force_enable_zoom in RenderWidgetHostImpl, then update the state to new input router when we create. Bug: 821447 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I33308abe484de70f1e4d2189de4896a04b05d7ef Reviewed-on: https://chromium-review.googlesource.com/961781 Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#544791}
-
Nasko Oskov authored
When a content script is injected into a document, it can make requests to origins in its manifest. With recent changes to allow Chrome to block cross-site documents, the initiator of content scripts requests was changed to reflect the extension origin. This change meant that SameSite cookies were not attached to those requests. This CL introduces a check for content scripts making subresource requests and tags those requests to allow attaching SameSite cookies. Bug: 796480 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I021156e346035267d98802cfb0205fc419e970bd Reviewed-on: https://chromium-review.googlesource.com/896690 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#544790}
-
Qiang Xu authored
changes: Do not clear kPreMinimizedShowStateKey in tablet mode, instead let it persist before/after tablet mode. Bug: 823175, 783310 Test: manual test and added test coverage. Change-Id: Icec1675da9c7d1b5b955ae5c05a71d96547afeee Reviewed-on: https://chromium-review.googlesource.com/969455Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#544789}
-
Bret Sepulveda authored
In order to kick off the launch process, this patch changes the single value flag to a proper base::Feature and enables it by default. Bug: 822111 Change-Id: I33779ba96d2dd40300a3877355b0045f1e2d761d Reviewed-on: https://chromium-review.googlesource.com/972607 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#544788}
-
Kevin Marshall authored
This roll incorporates a recent fix with the SDK blobstore FVM size. (This remedies the roll in commit 4b825d77, which used a SDK hash that was cut too soon.) TBR=sergeyu Bug: 707030 Change-Id: I14e3dc7e7db0e3c3e832a815f1e91e9c7315494a Reviewed-on: https://chromium-review.googlesource.com/972446Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#544787}
-
Samuel Huang authored
By defaulti, Zucchini deletes the output (patch or patched "new") file upon failure. The "-keep" debug flag overrides this behavior, so the bad output file can be examined. This CL adds the flag for Zucchini-gen and Zucchini-apply. This CL also removes a duplicated call to Ensemble::CheckOldFile(), which checks the CRC32 of the "old" file. This removal prevents redundant work and slightly speed up Zucchini-apply (by ~5%). Bug: 729154 Change-Id: I9ba8e9b00b7783661de06b39fae010761bedc6e6 Reviewed-on: https://chromium-review.googlesource.com/973746Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#544786}
-
Eric Karl authored
Skia currently dumps wrapped objects, and Chrome tries to alias these objects with Chrome's own dumps. This isn't always possible, so instead this change uses a new Skia API to ask Skia to skip dumping these. Bug: 795358 Change-Id: I143082aa340495f083a651532c8bbce621516490 Reviewed-on: https://chromium-review.googlesource.com/969709Reviewed-by:
Brian Salomon <bsalomon@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#544785}
-
Juan Antonio Navarro Perez authored
- No need to mention installing psutil anymore. Point to .vpython file for dependencies. - Simplify instructions for deaing with WebView. - Few style nits. Bug: 711073 Change-Id: Iebb0b2946a1e668704229f29861b2044cec92512 Reviewed-on: https://chromium-review.googlesource.com/973371Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#544784}
-
Sandra Sun authored
As specified in the spec, when the snap-container has scroll-snap-type: proximity, we should only consider snap positions that are close to the current scroll offset. https://drafts.csswg.org/css-scroll-snap-1/#snap-strictness Bug: 823820 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I6312f98df421e303eb538f422ede39cea8dd5d38 Reviewed-on: https://chromium-review.googlesource.com/971466 Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#544783}
-
Dmitry Gozman authored
This reverts commit 250e22d9. Reason for revert: Not needed anymore, since another fix was landed. Original change's description: > Null-check LocalFrame::Client() before accessing in LocalWindowProxy > > When the frame has already been detached, Client() will be nullptr. > Since we can call LocalWindowProxy methods even when detached, > e.g. through ToV8ContextEvenIfDetached(), we should null-check the client. > > This is a band-aid fix, because we actually should not initialize context > on a detached frame and change ToV8ContextEvenIfDetached to never force > context. However, the proper solution has many risks and needs additional > investigation. > > Bug: 805882 > Change-Id: Idcd6bbc0e6eec9b2de53acfb646b30bd9636d797 > Reviewed-on: https://chromium-review.googlesource.com/949603 > Commit-Queue: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543266} TBR=dgozman@chromium.org,dcheng@chromium.org,peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 805882 Change-Id: Ia9bf73134c13c3f0bb2c29e69f9d88dbed336ce6 Reviewed-on: https://chromium-review.googlesource.com/973468Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#544782}
-
braveyao authored
This CL adds support for MEDIASUBTYPE_RGB32 back in Windows platform. It's firstly added in cl https://codereview.chromium.org/1036063002. But a next cl, https://codereview.chromium.org/1039383002, might remove it due to merge error very soon. TEST=WebRTC sample with DXTory capturing on Solitaire. Bug: 819947 Change-Id: Ifaddb682090f738ecc8879078d8e0426bf3def4c Reviewed-on: https://chromium-review.googlesource.com/972543Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#544781}
-