- 14 May, 2019 40 commits
-
-
Hui Yingst authored
Changed the parameter type for ProfileManager::AddProfile() from raw pointer to std::unique_ptr. Also changed return value type for Profile::CreateProfile() from raw pointer to std::unique_ptr. BUG=959492 Change-Id: I64909b8f672aef78ef095d03aefda51337dcea4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598177Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Hui Yingst <nigi@chromium.org> Cr-Commit-Position: refs/heads/master@{#659324}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/114240247a61..95764ff31ecd git log 114240247a61..95764ff31ecd --date=short --no-merges --format='%ad %ae %s' 2019-05-13 rmhasan@google.com [Typ] Use the same pool for all enabled tests and their retries Created with: gclient setdep -r src/third_party/catapult@95764ff31ecd The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Change-Id: I75453da99025230d11a3c16532b145301c30ecc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610787Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659323}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0a1eeb80641a..7d7985589b8f git log 0a1eeb80641a..7d7985589b8f --date=short --no-merges --format='%ad %ae %s' 2019-05-13 shrekshao@google.com Skip validating draw buffers when RASTERIZER_DISCARD is enabled. Created with: gclient setdep -r src/third_party/angle@7d7985589b8f The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:962555,chromium:962636 TBR=syoussefi@google.com Change-Id: I7acedd7db695f360ff5ce4970b41ac140ba79097 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610781Reviewed-by:
-
Julian Watson authored
Bug: 932339 Change-Id: I609be5c7589b1171bd6016f758f1f2acfa0cd04d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609004 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Julian Watson <juwa@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#659321}
-
Yue Zhang authored
This change enables dragging to reorganize tabs in grid tab switcher with groups. It is now behind the flag TabGroupsAndroidUiImprovements. Bug: 961433 Change-Id: I1c5b873984574a4e860baea7145c514f8fe7c610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604499 Commit-Queue: Yue Zhang <yuezhanggg@google.com> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#659320}
-
rbpotter authored
Update PDF viewer zoom buttons in the new Print Preview to have background-color google-grey-600 and icon color white, per UX feedback. No changes requested for dark mode, so there should be no change to the buttons' appearance in dark mode. Bug: none Change-Id: I3df248338283f53ca307dd2e9997b5533019e5c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610309Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#659319}
-
Tsuyoshi Horo authored
This CL introduces PrefetchedSignedExchangeInfo struct, which keeps the information about a prefetched signed exchange. It is created in PrefetchedSignedExchangeCache and passed to SubresourceLoaderParams and will be passed to the renderer process in CommitNavigation IPC's CommitNavigationParams. Bug: 935267 Change-Id: Id67c2ce99801f6c89d679cf9efaf65617d68cdfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600438Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#659318}
-
Rakib M. Hasan authored
Bug: chromium:937516 Change-Id: Id7055ac6221a94caa3af8928cfa0478eccfb4abf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610482Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#659317}
-
Donn Denman authored
This CL sets expires_after="never" for the metrics used in the Contextual Search dashboard (at go/cs-metrics-dashboard) and adds a comment to that effect in each entry. Also sets expiry for a key UMA metric needed for chronav calculation to M-80. BUG=953453, 621669 Change-Id: I1d3a5bba857c275a69b911f283c8182fa47cb2ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604314Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#659316}
-
Matthew Wang authored
Shill's portal state is being split into three new states: - kStateNoConnectivity: no internet connectivity - kStateRedirectFound: shill is behind a portal and was able to find a redirect URL - kStatePortalSuspected: shill suspects that it is behind a portal but wasn't able to find a redirect URL Since these states are communicated to Chrome via D-Bus, we need to update Chrome to recognize and handle these new states. Bug: 946866 Change-Id: Ifc933be0368aafb46d8d07d707489c70e3e924d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586474 Commit-Queue: Matthew Wang <matthewmwang@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#659315}
-
Chris Palmer authored
ajwong pointed out that `PartitionRootBase::max_allocation` was used only in tests. This CL additionally `DCHECK`s that it is not being mis-used in the most simple ways. In the future, we might be able to change the API such that `SizeSpecificPartitionAllocator` 'knows' its allocation size and just allocates it, without needing a `size` parameter. This CL also does some code cleanup. This involved making sure we always observe `PartitionAllocReturnNull` in every case where `MEMORY_TOOL_REPLACES_ALLOCATOR` is defined; previously we did not. Bug: None Change-Id: I04aa797176851e15ef3a0b803b85ddd038e0f772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607149Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#659314}
-
Aidan Wolter authored
Do not filter ethernet interfaces if --require-wlan=false. Previously, no matter the value, we ignored ethernet interfaces. Bug: b/132300724 Test: Set --require-wlan=false, observe connected Change-Id: Ia00fa0da562fb3abb7a80be4688e87dbdab23dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610654Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Aidan Wolter <awolter@chromium.org> Cr-Commit-Position: refs/heads/master@{#659313}
-
Toni Barzic authored
Added test for enabling and disabling virtual keyboard and docked magnifier accessibility features. BUG=953020 Change-Id: I380baa5ee34bdb3b006751d13e0566470b2f5dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607132Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#659312}
-
Michael Spang authored
Add a new FYI bot for Fuchsia that builds with angle_top_of_tree. Bug: angleproject:3146 Change-Id: I993faf11739c6074c60b8dc7613489110fb15d40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610748Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#659311}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/417f2332fcf4..06f5b2262451 git log 417f2332fcf4..06f5b2262451 --date=short --no-merges --format='%ad %ae %s' 2019-05-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial). 2019-05-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial). Created with: gclient setdep -r src/third_party/depot_tools@06f5b2262451 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I94465acd5d47f66f3e572b63be905a9eb4744aa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610782Reviewed-by:
-
Meredith Lane authored
Due to changes in the API, AccessibleNode will no longer be able to modify the underlying accessibility tree. For more information on the motivations for this, see: https://github.com/WICG/aom/blob/gh-pages/explainer.md#what-happened-to-accessiblenode BUG=746523 Change-Id: I1b7b49fb04a62566295620e172e7d51078d6375f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598897Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#659309}
-
Simon Que authored
These builders have been updated to use the RBE Prod cluster. Bug: 947436 Change-Id: I72294b236a65e29c97d56f7eaf95fd3443c7b747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608964Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#659308}
-
Aaron Colwell authored
- Move the majority of set_process_reuse_policy() usage into creation functions since most calls are made almost immediately after a Create call. - Created SiteInstanceImpl::CreateReusableInstanceForTesting() to explicitly mark instances where tests are creating SiteInstances that they expect to be able to reuse a process AND are expecting to not ever receive a default SiteInstance. This method will make it easier to avoid breaking tests when SiteInstanceImpll::CreateForURL() is updated to allow the default SiteInstance to be returned. - Minor changes to make sure set_process_reuse_policy() is never called on the default SiteInstance. Bug: 958060 Change-Id: I3e6a2dc9eb1f3f2abaccc690b2d8b1edd7e2b182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603413Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#659307}
-
François Degros authored
Bug: 778674 Change-Id: I763c20ebc74902c2a3e633f63a804bebda5490ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610260 Auto-Submit: François Degros <fdegros@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#659306}
-
Sam Goto authored
Explainer: https://github.com/sso-google/sms-otp-retrieval Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Drmmb_t4eE8 Design Doc: https://docs.google.com/document/d/1TG7BzAPdt2DWNOmephxNf09kdzDKYq8l6Z126oSif8I/edit WICG Thread: https://discourse.wicg.io/t/sms-otp-retrieval/3499 Bug: 670299 Change-Id: I990c32cf248200277e50ffb127d9828a62ef3a22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590392Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Sam Goto <goto@chromium.org> Cr-Commit-Position: refs/heads/master@{#659305}
-
Vladislav Kaznacheev authored
While menu is being shown, it is preventing Chrome from exiting. However, if a menu is opening while Chrome is already shutting down, this currently causes a CHECK failure (see linked bug). The CL is adding shutdown detection logic to ChromeViewsDelegate and avoids showing a menu if a shutdown is detected. Note that no callbacks (such as OnMenuClosed) are called. Bug: 960925 Test: none Change-Id: Ie282f353b94a5c79a29ba5f770808d552d8e2980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601419 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/628604eefdb9..65b1e97d13eb git log 628604eefdb9..65b1e97d13eb --date=short --no-merges --format='%ad %ae %s' 2019-05-13 chrisforbes@google.com Only perform attachment load/store ops for used attachments Created with: gclient setdep -r src/third_party/swiftshader@65b1e97d13eb The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Change-Id: Ic492f9c3f2dcf402cba9c7d351a8f8eab75fb32d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610778Reviewed-by:
-
Jinsuk Kim authored
Uses image src url if alt text is missing. This is how image opened in a new tab works. Bug: 960130 Change-Id: Id592a091c445486f8ee81e4d7090366f5719301c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605380Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#659302}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b2d0ebdef207..8f877b2e3820 git log b2d0ebdef207..8f877b2e3820 --date=short --no-merges --format='%ad %ae %s' 2019-05-13 tsepez@chromium.org Replace CountedFaceCache with RetainPtr<CFX_FaceCache> 2019-05-13 tsepez@chromium.org Rename CXFA_Node::RemoveChild() to RemoveChildAndNotify() 2019-05-13 tsepez@chromium.org Add more helper methods to tree_node.h Created with: gclient setdep -r src/third_party/pdfium@8f877b2e3820 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: I49b6e97604e451bff16fa78806332f3f6cf78d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610783Reviewed-by:
-
Chris Palmer authored
Bug: None Change-Id: I7868559255a04fdf354fdd843c91ea0779a33072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603214Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Reviewed-by:
-
Darwin Huang authored
Ref: https://abseil.io/tips/131 https: //stackoverflow.com/questions/20828907/the-new-keyword-default-in-c11?lq=1 Change-Id: I10dffd5bd13d6f619e4f758ec154947bbef86d0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607185 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
-
Tommy C. Li authored
Separate the "More Info / Remove..." context menu entry for Suggestion Transparency into two context menu entries: - Why this suggestion - Remove suggestion This was vetted by our UX folks, and so we are also committing these strings to our translated strings. The implementation of the "Why this suggestion" info bubble will be in a separate CL. Bug: 929477 Change-Id: Ia406107bf9f6b50354f2b8f9ccf6b472571d799d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610846 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#659298}
-
Matthew Braithwaite authored
Change-Id: I78d857a03de71c27988793e50b143dd8f4523c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603403 Commit-Queue: Matt Braithwaite <mab@google.com> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#659297}
-
Vlad Tsyrklevich authored
Linux crashpad support is now sufficiently enabled to allow running the GWP-ASan crash handler unit tests under Linux. (The client tests are still blocked on allocator shim updates.) Change-Id: I409cebaa9cdaed5da546266d0af470d2b25a09ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610605 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#659296}
-
Erik Luo authored
Screenshot: https://imgur.com/a/bOoDTny Bug: 959001 Change-Id: Idc6e7303821e4180ec90831341a29aebe594fcc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597283Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#659295}
-
Nick Harper authored
Bug: 962666 Change-Id: Iadc9823c3e90d474d0e45c3e49494d29f038f13b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610705Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#659294}
-
Caleb Rouleau authored
The current code has an assumption that every official benchmark must be scheduled on either pixel2 or linux platform. However, we are hoping to allow benchmarks to choose when platforms are the most important for them instead of having them run across all platforms by default. Bug: 961830 Change-Id: I26de896c921a85213a867e89ff137fce81959550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610484Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4e4b7dee3c41..bbc5238c48bb git log 4e4b7dee3c41..bbc5238c48bb --date=short --no-merges --format='%ad %ae %s' 2019-05-13 yueherngl@google.com sarien: add firmware branch builder Created with: gclient setdep -r src/third_party/chromite@bbc5238c48bb The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I1064259818fae14928c9430650d8097840847c14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610786Reviewed-by:
-
Mike Wittman authored
We've captured enough data to answer the relevant questions about jankiness of this function. Bug: 903972, 955601 Change-Id: I23eaffbcb1dc1c41bb37b106e794e4a6e776f6bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610506 Commit-Queue: Mike Wittman <wittman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: Mike Wittman <wittman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#659291}
-
Darwin Huang authored
Ref: https://abseil.io/tips/131 Change-Id: I8673de91b4b0bac43d7a7c87fa4b69e45d181e9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606824 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
-
Hwanseung Lee authored
Use enum class instead of enum for BoxLayout::CrossAxisAlignment enum class is more type safety. Bug: 940736 Change-Id: I76bfd19f4b2b176e1c832590dce9c82c17d50093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605281Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#659289}
-
Rahul Arakeri authored
This CL renames "Enable Compositor Threaded Scrollbar Scrolling" to "Compositor Threaded Scrollbar Scrolling". The flag already has options to enable/disable it. Hence the "Enable" part of the flag name can be removed for improved readability. Bug: 962715 Change-Id: If955ec074b2bd77b7b1a22f4102068950d4c2dff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598344Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5fc28b11a029..e62a08a87a6f git log 5fc28b11a029..e62a08a87a6f --date=short --no-merges --format='%ad %ae %s' 2019-05-13 ssilkin@webrtc.org Request key frame on all layers. Created with: gclient setdep -r src/third_party/webrtc@e62a08a87a6f The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I6bea98df30884cc0d41612cf7664d34e33357131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609700Reviewed-by:
-
Aleks Totic authored
Fuzzer caught a NULL deref crash. Running with DCHECK, found a problem before the deref, we were cloning LayoutNGInsideListMarker inside LayoutInline::SplitInlines. This was triggering a DCHECK in LayoutInline::Clone. I am not very familiar with how LayoutInline line splitting works. I have a patch created with my shallow understanding that fixes the crash, but I am not sure if this is the right thing to do. Bug: 962242 Change-Id: I11e4cf3307c257e7c396b4112888bad0cd76ac5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610522 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#659286}
-
Ryan Sturm authored
This CL verifies we are not laying out when analyzing metrics elements. A lifecycle observer is used to wait to record and send metrics until the lifecycle is not in the middle of layout. Subframe anchors do not record size metrics anymore. Bug: 957026 Change-Id: I1fe67350d2c5c800697e412b4604b760fce2f859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592323Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#659285}
-
