- 11 Aug, 2020 40 commits
-
-
Xing Liu authored
It's possible that we may rollback download later feature. We should not load the download schedule data when the feature is disabled. Bug: 1114855 Change-Id: Iaca2998a85296f3a16f0b23d14215425356a4895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346932Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796912}
-
Yusuke Sato authored
BUG=1114931 TEST=try Change-Id: I5405f092efdd70f992e9165e4d40d08be863e58d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348333Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#796911}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 133 histograms that show frequent access in the past 90 days. These are the 90% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2021-02-07. TBR=chromium-metrics-reviews@google.com Change-Id: Id1ca3344fdb2f50fd0ad7ad9c4348d3c42a8e766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348697Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#796910}
-
zhaoyangli authored
Accept the request `"<app name>" would like to find and connect to devices on your local network.` Bug: 1114928, 1115099 Change-Id: I777b70c13c6b19c3fc0f30a9a67663afeaa7bc9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347201Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#796909}
-
Li Lin authored
Since there is no server side dependencies, we decided to enable the feature by default. The feature flag will be used as killer-switch in case anything goes wrong and clean up in future milestones. Bug: 921142 Test: manual tests Change-Id: Ibc849d549a394b6487626e6d71435a14e76e9ad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348010 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#796908}
-
Elly Fong-Jones authored
This reverts commit 659a4e4e. Reason for revert: Closed the tree with a compile failure: https://ci.chromium.org/p/chromium/builders/ci/mac-arm64-rel/334 [263/11988] OBJCXX clang_x64/obj/base/base/sdk_forward_declarations.o FAILED: clang_x64/obj/base/base/sdk_forward_declarations.o /opt/s/w/ir/cache/goma/client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -...(too long) In file included from ../../base/mac/sdk_forward_declarations.mm:5: ../../base/mac/sdk_forward_declarations.h:70:3: error: declaration shadows a variable in the global namespace [-Werror,-Wshadow] kCMVideoCodecType_VP9 = 'vp09' ^ ../../build/mac_files/xcode_binaries/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk/System/Library/Frameworks/CoreMedia.framework/Headers/CMFormatDescription.h:618:2: note: previous declaration is here Original change's description: > Reland: "Add support for creating VP9 format extensions for VTVDA." > > Creates a vpcc box based on the configuration info. Reland now uses > a forward declaration for the kCMVideoCodecType_VP9 which is in the > 11.0/10.16 SDK. > > R=avi, sandersd > > Bug: 1103432, 1105187 > Test: Updated unittests. > Change-Id: I15158ec3329054981cab4eefc3316283952f2f48 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348330 > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796873} TBR=avi@chromium.org,dalecurtis@chromium.org,sandersd@chromium.org Change-Id: I6b767665887cee003dea63c3b037769a34021ea7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1103432 Bug: 1105187 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346979Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#796907}
-
Karel Král authored
Implement support for auto-generated mojo method parameters of map types. Thus provide more information for developers while debugging. Bug: 1103623 Change-Id: I3223db2075b174b46e731ca43e1a783726084c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332713 Commit-Queue: Karel Král <karelkral@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#796906}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/59b4828f293e..72ea2ee4650f 2020-08-11 sugoi@google.com Prevent accessing deleted ImageView objects If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1110549 Tbr: swiftshader-team+autoroll@google.com Change-Id: I5e5dc5c0374c137fec31c999629a738fe2314ae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347402Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796905}
-
Erik Chen authored
This is no longer necessary now that deploy_chrome handles everything for the developer, including putting lacros-chrome onto an always executable mount point. Bug: 1115083 Change-Id: I1ecb39dd650bfca746bbb26c9a138e784eaadfbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349392 Commit-Queue: Erik Chen <erikchen@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#796904}
-
Randy Rossi authored
Added a id to replace tab_id as unique identifier for the webviews that are created from the platform views service. The tab_id was always 0 because is_root_frame is true on creation. Subsequent lookups for the ax tree id by tab id were only working by chance. The linear search for the tab id among the list of windows always matches the first one found, which was the correct one. This ensures tab ids will be unique. Bug: None Test: display assistant created webviews followed by navigation causing render frames to be swapped Change-Id: Ib6b9f1fd217367423f15965e5b760df1f170caa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342640 Commit-Queue: Randy Rossi <rmrossi@chromium.org> Reviewed-by:Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#796903}
-
Ryan Hansberry authored
Follow guidance by reillyg@ in crrev.com/c/2314024 to discourage clients other than Nearby from using [Sync] methods on adapter.mojom. Change-Id: Ic71e1330747b240ba3f153ac96f6cbab0f375701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347166Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#796902}
-
Arthur Eubanks authored
Bug: 1114873 Change-Id: Ie2a30e03680172546052c00b83e8f10bf1be0dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346974 Commit-Queue: Arthur Eubanks <aeubanks@google.com> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#796901}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5edf510941a3..49983ef4e7de 2020-08-11 brianosman@google.com Runtime effect: Gather uniforms in one pass 2020-08-11 jvanverth@google.com MSAA improvements for Direct3D. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: fmalita@google.com Change-Id: Ie8779aa37fed168e1549ddec4c253ca0c10c867e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348282Reviewed-by:
-
Mike Jackson authored
Takes into account the display_override manifest value when determining if the PWA is installable. For example, if the developer specifies: display: "browser" display_override: ["standalone"] This should be installable, but prior to this change, chromium would only evaluate the display property. Since unsupported values are ignored when parsing the manifest, only the first value in the parsed display_override array needs to be evaluated. To test the change use: chrome --enable-features=WebAppManifestDisplayOverride Example websites: - (not installable) https://mwjacksonmsft.github.io/pwa/display-override-browser/index.html - (installable) https://mwjacksonmsft.github.io/pwa/display-override-custom/index.html Explainer: https://github.com/WICG/display-override/blob/master/explainer.m Design document: https://docs.google.com/document/d/1hEmbGVHMN38q1YTaaGccQ-Y5CHr7xIURYPRWXTuvZLo/edit?usp=sharing I2P: https://groups.google.com/a/chromium.org/d/topic/blink-dev/WvIeZT8uSzw/discussion Bug: 1109520 Change-Id: Ib3f7465ed36474b1166f136c3cd6655cc34add0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333541 Commit-Queue: Mike Jackson <mjackson@microsoft.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#796899}
-
yilkal authored
This is a reland of b545f589 The original cl failed in the MSAN test in SupervisedUserNavigationThrottleTest:: AllowEDUCoexistenceInnerWebContents where the inner WebContents is not attached by the time it is expected to. This only happens in the MSAN test case. The fix simply delays the test until it is sure that the inner WebContent is attached. Bug: 1113054 Original change's description: > Use only SafeSearch filter for EduCoexistence webview. > > This cl fixes the bug where the child user is stuck > in EDU account addition flow when the user's parental > control setting is 'Only allow certain sites'. > > Inorder to prevent this error from happening we will do > only safe search filter for the EduCoexistence webview > and not enforce the 'Only allow certain cites' settings > potentially set by the child's parents. > > "https://accounts.google.com" is manually whitelisted. This > is because there is a race condition where we don't know > whether the WebContent is an inner WebContent belonging > to EduCoexistence flow or not by the time throttling happens. > This happens because navigation to accounts.google.com is > started before the <webview> WebContents is attached to > the outer WebContents hosted by the EduCoexistence flow WebUI. > > We are making this exception only to the webview that is present in > the EDUCoexistence flow. The exception is made because the parent is > present with the child during the flow. Extending this exception > to every inner webcontents will may allow the child to break parental > settings. > > Bug: 1079510 > Change-Id: I4f3e65e58537a845613b0c49b03f801f0a3caa08 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316443 > Reviewed-by: Marc Treib <treib@chromium.org> > Reviewed-by: Aga Wronska <agawronska@chromium.org> > Commit-Queue: Yilkal Abe <yilkal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#794661} Bug: 1079510 Change-Id: Ida69bb2fc63efbdbc3e06365290ddc2aed9790c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338856Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
-
Andrey Zaytsev authored
* Added logic to delay setting status icons on initialization * Removed unnecessary logic to invoke setInitialState in the Mediator constructor Bug: 1070620 Change-Id: I21174d0c874f56eb6ee218fa844bead1fe4a0451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346285 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#796897}
-
Andrew Grieve authored
This reverts commit 393e7114. Reason for revert: Proper fix landed (see bug). Original change's description: > Reduce link pool to stop android-archive-rel OOM'ing > > I'd like to still work on a fix that doesn't reduce the size for bots > with less RAM, but need something quick'ish to fix bot. > > Bug: 1098333 > Change-Id: Ifdfe8f07712e5073419ea0c0c0eb89092c31a1de > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347384 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Dirk Pranke <dpranke@google.com> > Auto-Submit: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Cr-Commit-Position: refs/heads/master@{#796585} TBR=dpranke@google.com,agrieve@chromium.org Change-Id: I6b445001d0a8ab57d16f3ba2623906da1b509d37 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1098333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349398Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#796896}
-
Rakib M. Hasan authored
instrumentation tests I temporarily need to remove GOMA compilation. I can't seem to start the GOMA proxy when running the recipe locally. I will be working with LUCI users in order to figure out what to do for that. For the time being I can work around this issue by removing GOMA compilation. Bug: 1041619 Change-Id: Idab34e78b2ec0f6c8ea7e5517bb709096ed1aef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346939Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#796895}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I9b6e20194d7697e70cf0e4a787d023ebe26af457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347316Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#796894}
-
Nektarios Paisios authored
This is the first step in the process of merging BrowserAccessibilityPosition and AXNodePosition into one class. We need to adopt the same definition of an embedded object in both places. This is the definition used by IA2 and ATK hypertext, which makes all non-textual nodes that are exposed to the platform APIs into embedded objects. Additionally, we include the definition used by UIA, which makes all empty leaf objects (objects with ignored descendants) as embedded objects. AX-Relnotes: n/a. R=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: I19bbc26f40d37a07b7dd6436fb0025505a0cfd89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346653Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#796893}
-
Dave Tapuska authored
This test was disabled due to flakiness. Flakiness was fixed in https://chromium-review.googlesource.com/c/chromium/src/+/2347392 BUG=1110429,1112931 Change-Id: Ia3eaa8c85d13761bc3934768e85a0faab6bc039c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347403Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#796892}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/01e0ccdc9b8b..21e5b4554a5f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5968ddcb8ea65eee86e30f71501716fbfb17f7f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347227Reviewed-by:
-
Joey Arhar authored
Bug: 1113521 Change-Id: I2eb4e2dfbe5de5d6b46ec1d22815cf014e90ec15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347979 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#796890}
-
Scott Violet authored
This crash happens under the following circumstances: 1. on android. 2. request manifest from WebContents. 3. ~WebContentsImpl As part of WebContentsImpl deletion any outstanding requests for manifests are run. The callback scheduled at 2 may trigger running code in ContentFaviconDriver that attempts to use web_contents(). Problem is at this time WebContentsImpl has already set the web_contents() of ContentFaviconDriver to null, and we crash. Fix is to route the callback to ContentFaviconDriver and have ContentFaviconDriver do nothing if web_contents() is null. BUG=1114237 TEST=ContentFaviconDriverTest.WebContentsDeletedWithInProgressManifestRequest Change-Id: I0e88884c1ea7a8ffacb443b65ba09786cf4f54c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343718Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#796889}
-
Yuly Novikov authored
Also flaky in Release and on Win10. TBR=kbr Bug: 772037 Change-Id: I6108376212d131c9972a47f3232614674b94beac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348696Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#796888}
-
George Steel authored
Add case for setting localTime to null after having it set to a number. Port to WPT infrastructure (testharness + reftest). Bug: 870711 Change-Id: Iae22083f63004153666f4e119cf350f86c65eb55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348008 Commit-Queue: George Steel <gtsteel@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#796887}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ad052807cdc7..0b969adbdff1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ellyjones@google.com,apotapchuk@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ellyjones@google.com,apotapchuk@google.com Change-Id: I109a39a9ec28e79bb7e1c9fb34ec698d68eb1727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349318Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796886}
-
Rushan Suleymanov authored
This CL adds a unit test for the case from CL https://crrev.com/c/2027407. There is also a fix of use-after-free bug in client tag based remote update handler. Bug: 1046309 Change-Id: I00302c5772aa960b1af5064d768bcd5e0f8dd45d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346431 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#796885}
-
Meilin Wang authored
Please see demo screenshot in the linked bug. Bug: b/161481969 Test: covered by unittests. Change-Id: I8e3d867220ff7e23e79ac807ce6929fd04a246ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342784 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#796884}
-
Ewann authored
Adding: - Open in New Tab - Open in New Incognito Tab - Open in New Window (if Multi-Window is supported and iPad) - Open all tabs for section header - Hide for now Bug: 1093302 Change-Id: I1c1e79e34b73ab7b03082bc7ff40764dc7f33b28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333827 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#796883}
-
Marc Treib authored
This was meant to be done in crrev.com/c/2220048, but a part of it was overlooked there (that CL added only a DEFINE_VARIATION_PARAM(..) but failed to also add the corresponding VARIATION_ENTRY(..) in the list). Bug: 1044038 Change-Id: I54d11b14073f4908c634ba8539b870a0f5c6ec8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346433 Auto-Submit: Marc Treib <treib@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#796882}
-
Joshua Pawlicki authored
There needs to be some thought devoted to how we are sharing prefs with update_client (and how and whether we should share code as well). This change is very limited in scope, specifically to fix issue 1092503 and unblock other changes, allowing the test app to function correctly. Bug: 1092503 Change-Id: I0500d3ae210a2a60e2991826432417a49ce88166 Fixed: 1092503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348537 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#796881}
-
Kent Tamura authored
Bug: 875235 Change-Id: Id85c0c5ad52bef9309e201416f9d47c30468efff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348231 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#796880}
-
chromium-internal-autoroll authored
Release_Notes:http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202008110800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/qm8oRNi8gU7naD1qdw0-8dq2k2YWuPswsrYsoz6u_n8C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/159394333,b/162906760 Tbr: help-app@grotations.appspotmail.com Change-Id: I1beff4b08702c8c390417f5062aef2aed2802628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349320Reviewed-by:
-
Muyao Xu authored
A new |error_msg| data member is added to LaunchSessionResponse struct to provide more descriptive error messages. Bug: 687380, b/154273698 Change-Id: If334dbfb0499cddcf3cfe36b3423ebf7005efb0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335879 Commit-Queue: Muyao Xu <muyaoxu@google.com> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#796878}
-
Nick Diego Yamane authored
Mechanical change renaming platform window's handlers subdir so making it more consistent with the other sub-directories. R=sky@chromium.org Bug: None Change-Id: I5a355b4ed70a30ae803ce96c6ffee60cbfdd0bbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347401 Auto-Submit: Nick Yamane <nickdiego@igalia.com> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Hirokazu Honda authored
media/gpu/video_encode_accelerator_tests: Settle target bitrate by the video resolution and framerate Originally video_encode_accelerator_tests tests a fixed bitrate with any video. This enables to settle a good bitrate for testing by determining it by the resolution and frame rate of a test video. Bug: 1045825 Test: video_encode_accelerator_tests on atlas Change-Id: I129158cf0e877a0d06ce304f201c01969abd3be0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325671 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#796876}
-
Jeffrey Young authored
BUG=none TEST=browser_tests --gtest_filter="OSSettingsAmbientModePageV3Test.All" Change-Id: Ia097fb823b0e5f828444befe64b50b8e677c71cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347344Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#796875}
-
Antonio Gomes authored
if (bleh) { (...) } else if (!bleh) { (...) } BUG=None R=sky@chromium.org Change-Id: I7e303732499e1cfc77a23e08186a921612cbff27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346608 Auto-Submit: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: -
Dale Curtis authored
Creates a vpcc box based on the configuration info. Reland now uses a forward declaration for the kCMVideoCodecType_VP9 which is in the 11.0/10.16 SDK. R=avi, sandersd Bug: 1103432, 1105187 Test: Updated unittests. Change-Id: I15158ec3329054981cab4eefc3316283952f2f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348330 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#796873}
-
