- 03 Apr, 2018 40 commits
-
-
Yoichi Osato authored
This patch adds a layout test that confirm no warning if imported document adds style to the main document by appendChild. Bug: 523952 Change-Id: Idd5a603d3e585378fc57958969b491d866abf997 Reviewed-on: https://chromium-review.googlesource.com/970046Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#547647}
-
Yoshifumi Inoue authored
This patch changes "transpose-empty.html" to utilize |selection_test()| for ease of maintenance. Note: "transpose-empty.html" is failed on layout_ng bot due by pixel test. Bug: 679977, 636993 Change-Id: Ibeb10cf4f7b6d0f270a30467060b9fba2891999d Reviewed-on: https://chromium-review.googlesource.com/991496Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#547646}
-
Yoshifumi Inoue authored
This patch changes "5272440.html" to utilize |selection_test()| for ease of maintenance. Following patch will rename "5272440.html" to "delete_all_contents_in_root_editable.html". Note: "5272440.html" is failed on layout_ng bot due by pixel test. Bug: 679977, 636993 Change-Id: I1455f820e8e0baf729fc8a1cca87705db4046674 Reviewed-on: https://chromium-review.googlesource.com/991493Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "type-delete-after-quote{1,-2}.html" to utilize |selection_test()| and integrate into "type-delete-after-quote.html", since both tests use similar test input, for ease of maintenance. Note: "type-delete-after-quote.html" is failed on layout_ng bot due by pixel test. Bug: 679977, 636993 Change-Id: I27db14fae0ab951df387e4d58c45f556470209c6 Reviewed-on: https://chromium-review.googlesource.com/991796Reviewed-by: -
Kenichi Ishibashi authored
This is failing because we don't support byte-for-byte update check to all service worker importScript() resources. Update test expectations to point an appropriate bug entry and remove the entry from S13nSW expectation as this failure isn't specific to S13nSW. Bug: 648295 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I65dca2a31baa500ae8f1d347af8c77d9e9fd8c29 Reviewed-on: https://chromium-review.googlesource.com/991472Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#547643}
-
Rune Lillesveen authored
Getting rid of another mutable style access. Bug: 813068 Change-Id: Ied084dcce6c9477ce43763ba42dd4256e87efa25 Reviewed-on: https://chromium-review.googlesource.com/983953Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#547642}
-
Yoichi Osato authored
This patch adds a layout test that confirms unintentionally warning if imported document adds style to the main document by appendChild after load. This simulates polymer's workaround for style deprecation: (Copy <custom-style> styles to main document: https://git.io/vxP3p) Bug: 523952 Change-Id: I2eb696b26af06000bc07af6ea9eeb87a67179368 Reviewed-on: https://chromium-review.googlesource.com/991655Reviewed-by:
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5d0fcc3fa3ad..87c1c3dbea9a $ git log 5d0fcc3fa..87c1c3dbe --date=short --no-merges --format='%ad %ae %s' 2018-03-25 lgoodby chromeos_config: Return gale-paladin to important. 2018-03-23 yueherngl eve-campfire: add eve-campfire-paladin 2018-03-08 phobbs cidb: Add Pre-CQ flake count query 2018-03-06 mortonm Adjust tester for new groups of which shill is a member. Created with: roll-dep src/third_party/chromite BUG=chromium:819287,chromium:820230,chromium:649417 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I41db1195a6cb655884268cbfb46050f8f09b96d8 Reviewed-on: https://chromium-review.googlesource.com/991609 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547640}
-
Yoichi Osato authored
This patch modifies the function so that it returns valid LayoutRect for line break. The function didn't work if (LayoutObject, offset) points after line break: 1. (LayoutBR, 1) 2. ("foo\n", 4) on white-space: pre. Because ComputeInlineBoxPositionForTextNode didn't receive such position. Historically, VisualPosition canonicalization updated Position not to point end of Node and LocalCaretRectOfPosition and ComputeInlineBoxPosition assumed that. This patch updates LocalCaretRectOfPositionTemplate to check if Position is after line break(NeedsLineEndAdjustment) and return the first InlineBoxPosition of next line(NextLinePositionOf). * Notes: This kind of adjustment should be done inside ComputeInlineBoxPosition. However, SelectionModifierCharacter and SelectionModifierWord depend on the current behavior of ComputeInlineBoxPosition that it returns null InlineBoxPosition for such position of line end (see L261 and L332 for each function). Since regression is about LocalCaretRectOfPositionTemplate, this patch only fixes the function. Bug: 807930 Change-Id: I46630d86401c165e0bb908d748adc069e03a5374 Reviewed-on: https://chromium-review.googlesource.com/906263 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#547639}
-
Yutaka Hirano authored
Some tests want to run all microtasks at the end of each test case, but I guess it is good for all tests. This CL adds v8::MicrotasksScope::PerformCheckpoint in ~V8TestingScope and removes ScriptPromiseTestTryCatchScope which is now needless. Bug: None Change-Id: Icb237c7bb58f1ec7cfe1ce80d03f1b8106459e1a Reviewed-on: https://chromium-review.googlesource.com/991615 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#547638}
-
https://skia.googlesource.com/skia.git/+log/873086957bdf..c0528e2418e0 $ git log 873086957..c0528e241 --date=short --no-merges --format='%ad %ae %s' 2018-04-03 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 5a7e61bbd..30b604d8d (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I00b638b049e06e1d17549baaa893ff891bac3890 Reviewed-on: https://chromium-review.googlesource.com/991732Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547637}
-
Karan Bhatia authored
This CL ensures that all the page whitelisting API functions (chrome.declarativeNetRequest.*) can't be called by extensions which don't have a declarative ruleset. It doesn't make sense for extensions to whitelist page patterns if they don't have a registered declarative ruleset. BUG=811460, 696822 Doc=https://docs.google.com/document/d/1Fhm-t0JCc3dcmwyBX_i7TGyuJ2QjqDechv1-VCRBo5o/edit?usp=sharing Change-Id: Id2822af5f258a32889e9217a3c63e13879984312 Reviewed-on: https://chromium-review.googlesource.com/987314 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#547636}
-
Vaclav Brozek authored
The PRESUBMIT test _CheckUniquePtr reported the following false-positive: std::unique_ptr<ParseResult> result = std::make_unique<ParseResult>(); suggesting that one uses nullptr instead. This CL fixes that bug and also adds regression tests for this presubmit check. Bug: 827961 Change-Id: I60a088f6590f01c51be7e3ffc0c6d65ad9e5c329 Reviewed-on: https://chromium-review.googlesource.com/989972Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#547635}
-
Kenichi Ishibashi authored
The method is similar to EnsureControllerServiceWorker but in some cases we can't make sure that the controller service worker is running (as existing comment described). Update the description of the method to state that this method doesn't guarantee that the controller is running. The method will be called during navigation when S13nSW is enabled. During navigation, we need to make sure that the controller is running before calling this method. Currently we make sure this by calling ServiceWorkerFetchDispatcher::StartWorker() in the following sequence: ServiceWorkerControlleeRequestHandler::MaybeCreateLoader() -> ServiceWorkerURLJobWrapper::ForwardToServiceWorker() -> ServiceWorkerNavigationLoader::ForwardToServiceWorker() -> ServiceWorkerFetchDispatcher::Run() -> ServiceWorkerFetchDispatcher::StartWorker() After creating a loader, we call GetControllerServiceWorkerPtr() in ServiceWorkerControlleeReuqestHandler::MaybeCreateSubresourceLoaderParams(). Bug: 797222 Change-Id: If7ef6dbe2e59c15e2f737f16d68f0c851d889556 Reviewed-on: https://chromium-review.googlesource.com/987832Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Alexander Yashkin authored
This fixes DCHECK caused by TemplateURLService::UpdateNoNotify incorrect update of search engines that have same keyword after update. Bug: 697745 Change-Id: Ib554ca3e1748a3827fdbbb06a2168bb41dbdc150 Reviewed-on: https://chromium-review.googlesource.com/989753 Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#547633}
-
btolsch authored
The text in the fullscreen exit toast is confusing on Chrome OS since it is not commonly known how to access the F11 key. It is not usually used in BrowserView since immersive mode is used instead. Additionally, Chromebooks have a hardware fullscreen toggle button which should be easily accessible for exiting fullscreen. Bug: 825803 Change-Id: I855c9920e37e4176140c874e4a7c357cc6ab3e22 Reviewed-on: https://chromium-review.googlesource.com/988940Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#547632}
-
Greg Thompson authored
Now that TickClock::NowTicks is a const function, change consumers so that they hold a const pointer to a clock. TBR=sky@chromium.org Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I698230dfd458eb7b6d1c4566c6ed8b12db097c0e Reviewed-on: https://chromium-review.googlesource.com/982621Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#547631}
-
Patti authored
Update the icon sizes used in the omnibox popup/dropdown to change dynamically depending on whether touch mode is on or off. For favicons and extension icons which have fixed sized 16x16 icons supplied by the developer, add extra padding around it to align them properly with the correctly sized vector icons. Bug: 801583 Change-Id: I23a9a2c5b5e3ae35b5c975ef1e3b7b6f5c7a9282 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/945294Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#547630}
-
Chris Morin authored
The StartArcInstance dbus method has been split into StartArcMiniContainer and UpgradeArcContainer. Both need to be called sequentially for the ARC container to boot fully. Bug: 65548422 Test: Ensure container starts fully Test: ./out/Debug/unit_tests --gtest_filter='*Arc*' Test: ./out/Debug/components_unittests --gtest_filter='*Arc*' Change-Id: I60879e0c8b4ec6e93ee30fbabe0ae5e83dce2fc5 Reviewed-on: https://chromium-review.googlesource.com/917669Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Christopher Morin <cmtm@google.com> Cr-Commit-Position: refs/heads/master@{#547629}
-
btolsch authored
The page info dialog shows information about the content settings and preferences set for the page shown by a given WebContents. This includes security information, cookies in use, etc. The implementation that shows it relies on the WebContents being contained in a Browser object. PresentationReceiverWindow introduced a scenario where we want to show the page info dialog but don't have a Browser object. This change adds a method for LocationBar to be called to show the page info dialog directly so it can be called from the presentation receiver window. Bug: 807885 Change-Id: I9981ab04e0982c5d01ed11e83437714e9d8e90b2 Reviewed-on: https://chromium-review.googlesource.com/924473 Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
-
Mitsuru Oshima authored
* Move CenterWindow/CycleSnap to BaseState * Updated CenterWindow to send event instead. This is is necessary in order for ClientControlledState to intercept bounds change request. * Added animate parameter to SetBoundsEvent. Animation on ARC++ windows are not implemented yet. It will be handled in a separate CL. BUG=b/30260227 TEST=covered by unittest Change-Id: I7d3940f82f84331a717013005255e165818a7deb Reviewed-on: https://chromium-review.googlesource.com/989837 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#547627}
-
Koji Ishii authored
Following bot results are included. 4497 4499 4505 4509 4513 4516 4521 4524 4526 8 lines were removed and 9 lines were deflaked by consecutive results since 4466. Following test was converted to testharness and that text dump was removed: editing/selection/extend-by-sentence-001.html TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I3541c45d6961f8ad9cc08f9ea095c64f66c56e0a Reviewed-on: https://chromium-review.googlesource.com/989520 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#547626}
-
https://skia.googlesource.com/skia.git/+log/1a291b354f54..873086957bdf $ git log 1a291b354..873086957 --date=short --no-merges --format='%ad %ae %s' 2018-04-02 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ ad0c4f19b..75dc22828 (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I378c5d27e98ca1032b6465c776df5b0c9c0ae2b6 Reviewed-on: https://chromium-review.googlesource.com/991335Reviewed-by:
-
John Abd-El-Malek authored
Bug: 825242 Change-Id: Id08270e339e5a7ae33d2374f77d56d2de0da2254 Reviewed-on: https://chromium-review.googlesource.com/988693 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#547624}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0f51564af246..5d0fcc3fa3ad $ git log 0f51564af..5d0fcc3fa --date=short --no-merges --format='%ad %ae %s' 2018-04-02 ihf chromeos_config: mark eve-arcnext-chrome-pfq important. Created with: roll-dep src/third_party/chromite BUG=chromium:826755 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I6d5ed64763d7d87533683ad14220a98e82d1b422 Reviewed-on: https://chromium-review.googlesource.com/991600Reviewed-by:
-
Takashi SAKAMOTO authored
[Sheriff] Mark fast/text/color-emoji.html, emoticons.html, fast/text/international/002.html, wrap-CJK-001.html as failure on Win10 The following tests are failing (Image failures) on Win10: fast/text/color-emoji.html fast/text/emoticons.html fast/text/international/002.html fast/text/international/wrap-CJK-001.html TBR=jam@chromium.org Bug: 828260 Change-Id: Iad45ebc9bf0db86515487d93a43eab94e41de434 Reviewed-on: https://chromium-review.googlesource.com/991618 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#547622}
-
John Abd-El-Malek authored
Also change network::TestURLLoaderFactory to behave more like net::FakeURLFetcherFactory to make test conversions simpler. In particular, now it has persistent setting of responses instead of being consumed once used. Bug: 825242 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: If49f1671979267aa1551c8e391e6a6aae41cb017 Reviewed-on: https://chromium-review.googlesource.com/989835 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#547621}
-
https://chromium.googlesource.com/angle/angle.git/+log/5a7e61bbda82..30b604d8d174 $ git log 5a7e61bbd..30b604d8d --date=short --no-merges --format='%ad %ae %s' 2018-03-12 jdarpinian Check that transform feedback will not overflow its buffers. Created with: roll-dep src/third_party/angle BUG=chromium:820639 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I5a67f73f69ce29fe55a8318a22b6bf5de941fe7e Reviewed-on: https://chromium-review.googlesource.com/991599Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547620}
-
Daniel Murphy authored
This change is necessary for mojo'd SessionStorage to manage observers for shallow copying. Bug: 716490 Change-Id: I5a899be566327decc3a447fe56b72bfba735ffd6 Reviewed-on: https://chromium-review.googlesource.com/984859Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#547619}
-
Wez authored
This reverts commit 2a112566. Reason for revert: Unfortunately the SDK this CL rolled us to is subtley but badly broken. The CL fell narrowly short of Breaking All The Things, because some of the Things just don't touch the broken bits. :( Original change's description: > Fuchsia: extend the size of the blobstore FVM at build time. > > This CL grows Fuchsia blobstore by a specified amount, large enough to > accommodate packaged executables installed at machine (QEMU) runtime. > > Roll SDK from 32a56ad5 to de50ae25 for "fvm extend" and the inclusion > of fvm.blk. > > Bug: 798851, 707030 > Change-Id: I5a6b6be21cc443e6ad46271918a2f40e191a26f6 > Reviewed-on: https://chromium-review.googlesource.com/987012 > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#547568} TBR=wez@chromium.org,kmarshall@chromium.org Bug: 828232, 828229, 798851, 707030 Change-Id: I3ac0d1586c1a70700fbbd88d9f5762728bedc868 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/991672Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#547618}
-
Patti authored
Omnibox autocomplete results show an icon next to the result listing. Often this is the favicon of the website or extension that was found, but sometimes this can also include default search engine searches, bookmarked results, or pages without a favicon. These latter autocomplete matches show VectorIcons instead of favicons, however, their size is hard-coded in OmniboxPopupView. Move the vector icon creation outside of components/omnibox/ so clients can control the vector icon size. Bug: 801583 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If80bbb64bc4021f0bdc8bc33744b3e0a157acc7b Reviewed-on: https://chromium-review.googlesource.com/928054 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
-
kristipark authored
The z-index fix for the theme attribution placed the OneGoogleBar behind the ntp-contents div, which made the OneGoogleBar unclickable. Removing the z-index of OneGoogleBar fixes it from being rendered below ntp-contents. Bug: 827969 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5d36f8b1c727a614ef6e2707a440af5413ecbc57 Reviewed-on: https://chromium-review.googlesource.com/990235 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#547616}
-
Chromium WPT Sync authored
Using wpt-import in Chromium cce37ea2. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15286 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=ajuma No-Export: true Change-Id: I410afda3411e51dc56a5e2f089135be2afd83f0a Reviewed-on: https://chromium-review.googlesource.com/991412 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#547615}
-
Yoshifumi Inoue authored
This patch changes "extend-by-sentence-002.html" to utilize |selection_test()| for ease of maintenance. Bug: 679977 Change-Id: I11ed2197c147ef589654c6e6899a4a0f84d9aad9 Reviewed-on: https://chromium-review.googlesource.com/989385Reviewed-by:
-
https://webrtc.googlesource.com/src.git/+log/3d954a6962e5..5b4f075f9c59 $ git log 3d954a696..5b4f075f9 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I515a0df8532c8906ca42a3b14d5137dc39a5f82b Reviewed-on: https://chromium-review.googlesource.com/991594 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547613}
-
Filip Gorski authored
* Wires evend reporting for Explore on Content from the bridge to the contextual content suggestions service Bug: 824185, 824186 Change-Id: Ie03931a90c6ad7bb2db204fe26ce2a769c81d141 Reviewed-on: https://chromium-review.googlesource.com/989410 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#547612}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: I6cc15c09a93ea06cb91a64a624ecc9d25226642d Reviewed-on: https://chromium-review.googlesource.com/991573Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#547611}
-
Charlie Harrison authored
This caused a spike in metrics tracking users allowing the redirect via native UI. Addionally, it seems plausible that it breaks legitimate auth cases (though I have no direct repro). It is unfortunate that it allows the popup-redirect case, but that is not an abused vector (yet), and we are trying to be conservative to increase the chances of launch. Bug: 733736 Change-Id: I3559fa6d9e050e476da4c22346ea3ca81526bf06 Reviewed-on: https://chromium-review.googlesource.com/990996 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#547610}
-
John Chen authored
ChromeDriver is only interested in Target.receivedMessageFromTarget events from iframe targets. Ignore messages from other types of targets, instead of returning errors. Bug: b:76419159 Change-Id: I1e8545aa780d35d2069e4443e674b892ad272151 Reviewed-on: https://chromium-review.googlesource.com/991597Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#547609}
-
Jun Mukai authored
Previously both TouchDevicesController and TouchpadAndKeyboardDisabler control the availability of the internal touchpad, which causes weird behaviors as reported. This CL moves the control into TouchDevicesController -- now it can recognize both the user prefs and the device configuration (i.e. tablet-mode). As the result, the lifetime control of TouchpadAndKeyboardDisabler becomes unnecessary, so the entire class is removed. The remaining code (i.e. keyboard disabling) moves to ScopedDisableInternalMouseAndKeyboardOzone. This also renames an enum of TouchscreenEnabledSource, because it's not only for touchscreen anymore but also for touchpad. Several files are edited because of this rename. Change-Id: I481388125a55aad9270b897f3f3a15f59d5ab0ac Bug: b/75019660 Reviewed-on: https://chromium-review.googlesource.com/990677Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
-
