- 24 Aug, 2020 40 commits
-
-
Dominik Röttsches authored
This reverts commit a96793a7. Reason for revert: Unittest seems to compare against uninitialized value in Linux MSAN tests: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8871321847226501376/+/steps/unit_tests/0/logs/Deterministic_failure:_VideoTutorialGroupTest.CopyAndCompareOperators__status_CRASH_/0 Original change's description: > [Video Tutorials] Add internal tutorial group. > > Bug: 1115755 > Change-Id: I481a8f6498188681216d13df32ee41436cd1306c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358056 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Hesen Zhang <hesen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800642} TBR=dtrainor@chromium.org,shaktisahu@chromium.org,hesen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1115755 Change-Id: I5f8b770dc4564fef953f31228c4bda5261dc6ec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371703Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#800932}
-
Roman Sorokin authored
It's been enabled since M84 Bug: 1068314 Change-Id: Id4da966c461c671f704d90ff68f88eaacfa52749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328906 Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#800931}
-
nancylingwang authored
From M86, we introduce the adaptive icon for all apps. So modify the icon url for FullTaskDescriptor, and use the AppService interface apps::AppIconSource::GetIconURL to fetch the adaptive icons for apps. DD: go/appservice-adaptive-icon BUG=1119545 Change-Id: Id5a67114b80127a23655f4a7087077a2eabb7543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368576 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#800930}
-
Maksim Sisov authored
This fixes *TrueTypeFont tests. Maybe, we want to use something else than pangocairo. A bug to track that has been created. PS: it's important to fix this now as long as use_x11 && use_ozone config breaks the above mentioned tests on linux-rel bot then. Bug: 1119772 Change-Id: I14a01e623a84510d8398171a58ecf45840f58a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366901Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#800929}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/60cf6748adae..3cdc259008b5 2020-08-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 44e1791f100c to 622558b02e1a (3 revisions) 2020-08-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from d3e800e9ad66 to 4f7edbe1f6f0 (15 revisions) 2020-08-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from d3d82066 to 65295ec3 (458 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:816629 Tbr: mtklein@google.com Test: Test: Test: Capture first 2000 frames of PUBG:MobileTest: Test: PUBG MOBILE on AndroidTest: Test: angle_deqp_gles3_tests --gtest_filter=dEQP.GLES3/functional_fbo_invalidate_* --use-angle=vulkanTest: Test: angle_white_box_tests --gtest_filter=VulkanPerformanceCounterTest.InvalidatingAndUsingDepthDoesNotBreakRenderPass/* Change-Id: Ie43a6fcfa8f50ee772961dbe4176ba26125f4bf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371279Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800928}
-
Himanshu Jaju authored
- Sets message type and class for message header - Sets api version to the same one as gmscore Bug: 1082305 Change-Id: I1eabab14af2ca97426a4246437c06fb7cfcbd1e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370982Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#800927}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f0c62371. With Chromium commits locally applied on WPT: 9f52c7e4 "COOP: add reporting to redirects" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I33ecba8b07f3c5374a3b3871f76ef2f78a02dbec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371564Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800926}
-
Eliot Courtney authored
The user data is written by add_listener, and having a separate call to set_user_data setting the same thing is confusing because it implies that you could use set_user_data to set a different value than to what you use in the listener. Bug: None Test: compiles Change-Id: I34f6b87367f8a34b96160169fc531113001267a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368619 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#800925}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/fbf13333b426..e8bde89026d6 2020-08-24 pdfium-autoroll@skia-public.iam.gserviceaccount.com Roll Catapult from 0606ae6f9a56 to a54f10f750ba (58 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I5f6f0e42c255c71bdbba3a47416c8c9fb50c6b7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370463Reviewed-by:
-
Aleks Totic authored
LocalFrameView was keeping a list of orthogonal fragment roots that was out of sync ater cell changed its writing mode. The fix is to keep it in sync. I believe fix is safe, because calling RemoveOrthogonalWritingModeRoot is safe if cell is not in the list. Bug: 1120956 Change-Id: I16ee0f8971a0ea17f78a9970913467a13d897c15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371308Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#800923}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/370cbc70e080..60cf6748adae 2020-08-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from e8dc820fbc1e to ef7447334713 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: mtklein@google.com Change-Id: I22c35fc3cbb366acbe55441123db8cdcd8e32c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371278Reviewed-by:
-
Maksim Sisov (GMT+3) authored
This reverts commit 2e54b5b0. Reason for revert: 1) we can't move the tests to x11_unittests as we wanted before. 2) they became flaky and require x11wmstartupcheck program to check if openbox started. This check only happens for x11_unittests and we don't want to other test suites to run that now. Original change's description: > X11 and Ozone: rework topwindowfinder tests > > Remove dependency on ui/views and ui/aura. This is required to be > able to move them down to ui/platform_window/x11/tests > > Bug: 789065 > Change-Id: Ie4c0bd3056f9627b13b4bdfc9511010aaf249515 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367072 > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800488} TBR=thomasanderson@chromium.org,msisov@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 789065 Change-Id: If7fcf7756d5e4da53d21d5b0ad29e2752c0f9bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371622Reviewed-by:
-
Rachel Wong authored
We are investigating some suspiciously long query lengths recorded by the launcher search. Search queries are issued incrementally when the user types into the search bar, but it is also possible to have a jump in the query length, such as by tabbing to a search result then continuing to type. This metric aims to measure how often jumps occur. Bug: 1113960 Change-Id: I7670114fd6a89c8c8a689506adc59893b3a135ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366393Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#800920}
-
Joey Scarr authored
I've also modified lint-luci-milo.py to not throw an error when we add new fields to Milo's project config proto. Having to manually update the generated proto here on every added field is pointless. Bug: 1071344 Change-Id: Ia625e4b92f38034ed4aebc8f2230c5d2f87ed829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289333 Auto-Submit: Joey Scarr <jsca@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Joey Scarr <jsca@chromium.org> Cr-Commit-Position: refs/heads/master@{#800919}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e6244ccef917..a54f10f750ba 2020-08-24 landrey@webrtc.org Add UploadCompletionToken experiment If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1114055 Tbr: wenbinzhang@google.com Change-Id: I5b890d2a6ea158a54d132ae76f68ae9fc69b84cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371315Reviewed-by:
-
My Nguyen authored
Added the wrong url last time :(. Bug: b/162293447 Change-Id: I6e3b8c5e12c9b0673ffe3aab5648fe04bf55acb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371446Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#800917}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/179ac2819139..d0114ee9c6d1 2020-08-24 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I46a35c1cb832482204dc1e3719a90f7ca0e7e7d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371314Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/24c2f0e74e00..4f7edbe1f6f0 2020-08-23 jmadill@chromium.org State: Add dirty object for active textures. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I059ad258423c150745bfafd42c02a9b0cdc0eaeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371313Reviewed-by:
-
Yutaka Hirano authored
https://github.com/web-platform-tests/wpt/pull/25177 modified wpt/html/COEP/reporting-to-endpoint.https.html, and that blocks the WPT autoroller because the output depends on onetime tokens. See https://chromium-review.googlesource.com/c/chromium/src/+/2371035 for example. Add a failure expectation to unblock the autoroller. Bug: 1119676 Change-Id: I99e17bee60d73ce6d2645693e8e48406092deb49 No-Try: True Tbr: foolip@google.com Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370685 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#800914}
-
My Nguyen authored
As per UXimpl feedback, remove showing indices for emoji suggestions. Bug: b/165761951 Change-Id: Idc5363b71a6992b31db0d450516332b929d3c73c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371423Reviewed-by:
-
Miyoung Shin authored
This CL moves content::RecordContentToVisibleTimeRequest to //blink/public/mojom/page/record_content_to_visible_time_request.mojom to pass it to Mojo interface. It's a precursor CL of WidgetMsg_WasShown mojofication. Bug: 1102446 Change-Id: I4bd80915a3c6e04a97dc8a16a7dfa0d9cc4b8745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345900Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#800912}
-
danielng authored
Adding an app publisher for Borealis and creating a default app to access its installer. For more context into Borealis, and the UI elements being added for it, please see the attached bug (or message me directly :) ). Tests: Tested manually on DUT and ran AppTest* unit tests. Bug: b:161650651 Change-Id: Ie73d612eb479185a382742bdcc9ab7ef780b9190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362102Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Daniel Ng <danielng@google.com> Cr-Commit-Position: refs/heads/master@{#800911}
-
Hidehiko Abe authored
crrev.com/c/2367797 removed use_cras=false, but it was not enough to enable cras. In Chrome OS, CRAS is enabled only on build for devices, i.e., linux-chromeos does not link against libcras. Lacros starts to follow it. Bug: 1118241 Change-Id: Ib7b788ba3a634620f79d1fde133332981a8d0749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368800Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#800910}
-
Yuzu Saijo authored
This CL removes ServiceWorkerOnUI flag from bfcache bots, because bfcache does not depend on SWonUI any more, and SWonUI has not shipped yet. This would better reflect the wild. Change-Id: Iea54eab632cf0e7c1e40fa8f5980bd22d10dfb2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359949Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#800909}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=pbommana@chromium.org Change-Id: Ibac05bea9a4162d5b92d196d0d7028964b43f5fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371404Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800908}
-
Kunihiko Sakamoto authored
This patch restricts subresource loading from WebBundles only to same-origin resources, i.e. origin of subresource URL must be same-origin with the origin of the enclosing WebBundle's URL. Bug: 11202527 Change-Id: Ic999c4582385560f22a1251c37bd3572f0ffd2bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368618Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#800907}
-
Jiewei Qian authored
This CL adds a EnableAllSystemWebApps chrome feature, when enabled SystemWebAppManager will enable and install all registered system apps, and ignoring each system app's respective feature flag. This is useful for testing. This CL migrates the existing g_enable_all_system_web_apps_for_testing to this new feature, and adds a kNumberOfRegisteredSystemApps to verify all the apps can be installed successfully. Bug: 1095524 Change-Id: Iba595e7d94ff20076a6bfb36e0a91cee09c897bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366952Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#800906}
-
Alice Boxhall authored
This reverts commit 4f00646f. Reason for revert: Broke feedback_common_test on lacros: https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/1305 Original change's description: > Enable Lacros to send a simple feedback report with all Lacros data. > > The simple lacros feedback report includes the following: > > 1. Lacros feedback reports are sent with ChromeOS product id, so > that they will be found under ChromeOS product on Listnr. > > 2. Prefix the chrome version string with "Lacros ", so that lacros > reports can be filtered by "Version" (for example "Lacros") on Listnr. > > 3. Attach lacros user log in the system log. > > Bug:1109387 > TEST: > 1. Open Lacros browser, send a feedback report by clicking > "Report an issue" under Help menu. > 2. Verify the report can be found at > http://listnr site. The chrome version string should have > a "Lacros " at the beginning, for example, "Lacros 86.0.4238.0". > 3. Verify the report contains both system_logs.zip and histograms.zip. > The system log should contain lacros log data from > /home/chronos/user/lacros/lacros.log under "lacros_user_log" section. > > > Change-Id: I98b381724866d163dc760147448a80e2249c0a1b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362977 > Commit-Queue: Jenny Zhang <jennyz@chromium.org> > Reviewed-by: Miriam Zimmerman <mutexlox@chromium.org> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800772} TBR=jamescook@chromium.org,jennyz@chromium.org,afakhry@chromium.org,mutexlox@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1109387 Change-Id: Ibc3fa78f5ddd42860d858e4f84d38ba87090a263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371422Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#800905}
-
Minggang Wang authored
This CL converts base::Bind to Once/Repeating in //chrome/browser/offline_pages/. After this CL, there should be no base::Callback, base::Closure and base::Bind in this directory. Bug: 1007635 Change-Id: I3e8eedc2b921e7dac46f155ae72be1b312887eae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345285Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Minggang Wang <minggang.wang@intel.com> Cr-Commit-Position: refs/heads/master@{#800904}
-
Bartek Nowierski authored
The migration is done by renaming LinkedHashSet->LegacyLinkedHashSet and NewLinkedHashSet->LinkedHashSet. In case of OrderedTrackIndexSet (in grid.h) adding custom hash traits is required too. The CL results in a binary size increase due to inlined code related to VectorBackedLinkedList, which does not exist in LegacyLinkedHashSet. Co-author: keinakashima@chromium.org Significant contributor: yukiy@chromium.org Bug: 1100257 Change-Id: Ieefb3fa8cd27110872aba932370b84dcfe41c8a4 Binary-Size: Size increase is unavoidable (see above). Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134039Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Yuki Yamada <yukiy@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#800903}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1598181082-a323a3869f8b20fd164f9443decd21a7c8228a7c.profdata to chrome-mac-master-1598226952-0b51be5d3acf41b4d5c1d696ddf01b10602a88d4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: Iad44c2b01d69c2a006edd104218ad844695e7e0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371311Reviewed-by:
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. This is changes for /chrome/browser/web_applications/components/web_app_file_handler_registration.h This CL was uploaded by git cl split. R=davidbienvenu@chromium.org Bug: 1110266 Change-Id: I3f6ea288380e5031072ac0d38288a6f44cffc389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370285 Auto-Submit: Sean McAllister <smcallis@google.com> Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#800901}
-
John Z Wu authored
This avoids a DCHECK on an empty frame during navigation that happens as part of state restoration, which usually occurs before the view hierarchy has had a chance to layout its subview for the first time. Change-Id: I0a5684b8ce6219ea073bc93f33f79e651ea7578a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369615 Auto-Submit: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#800900}
-
Yoichi Osato authored
Bug: 1007703 Change-Id: I921c65e5cac4d044499ae83366806e88d2006902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336432Reviewed-by:
Mark Seaborn <mseaborn@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#800899}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I7345cde23554b52f132e2b7cc869d84cab91c2ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371310Reviewed-by:
-
Jamie Madill authored
This test does not show up in the flakiness dashboard. Test: deqp/functional/gles3/fbomultisample* Bug: 631317 Change-Id: I1f439515b444cfe5314b36d807cc4d9b71d873e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371038Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#800897}
-
Alice Boxhall authored
This reverts commit 0dce55ff. Reason for revert: This has caused a crash in many CrOS tests: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/20119 Original change's description: > Chrome OS: Use layer animation browser window frame activation animation. > > This is a revised version of original attempt crrev.comc/c/2166804. > Instead of creating a new layers, this clone and animate the window's layer, > but makes sure that the animating layer is at the bottom of other layers > within the window. > > * It adds a invisible view with a layer > at the bottom of the non_client_view (no frame w/o this, so we can exclude such case). > * Adds the animating layer as a child of this view, with > "SetMasksToBounds(false)" so that it will not be clipped during animation. > * Once animation is done, this animating, old layer will be removed. > > Bug: 1073685 > Test: covered by unittests. > Change-Id: Ib9ae60694fb461dda354fea4fd52e4e01186a6a7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335811 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800827} TBR=sky@chromium.org,oshima@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1073685 Change-Id: I093849df58f25a46a021f923daab1ab1faa1efee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371383Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4f247baf66e1..24c2f0e74e00 2020-08-23 dpranke@google.com Set use_xvfb where needed in test wrappers. 2020-08-23 lehoangq@gmail.com Metal: Implement GL_OES_texture_3D 2020-08-23 lehoangq@gmail.com D3D11: Disable OES_texture_3D. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:816629 Tbr: cnorthrop@google.com Change-Id: I38ba0fd0ce389535bc873b3de463bd274ade74cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371116Reviewed-by:
-
Alice Boxhall authored
Add crash expectation for third_party/blink/web_tests/external/wpt/webcodecs/video-decoder.html on Linux TBR=chcunningham@chromium.org Bug: 1121015, 1120431 Change-Id: I92a35847d27b6893bd99e9a27fe25dc1233c0406 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370883 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
-
Mark Yacoub authored
Combine all displays requested to be enabled into 1 vector to the Screen Manager. When atomic modeset is enabled, this will allow the screen manager to maintain their combined state and modeset them together. BUG=1082882 TEST=no changes enabling, ozone_unittests. Change-Id: Ib8bf31b13f6877c6523aada5c56e5a37f2b64fe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316155 Commit-Queue: Mark Yacoub <markyacoub@google.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#800893}
-
