GitLab

Add a perf unit test and a unit test to make sure the small_map doesn't overflow.

Bug: 847237
Change-Id: I56bd58b75dacf42abb32b6ce091e5930ceebd203
Reviewed-on: https://chromium-review.googlesource.com/1166190
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583094}

Use the shell test api (mojo) instead of direct access to ash::Shell.

Bug: 760811
Change-Id: If8526428917d72eeeb852698cb6cb31498eef741
Reviewed-on: https://chromium-review.googlesource.com/1175068
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583093}

This is a follow up cleanup CL for ChromotingSession crash fixing:

* Make ChromotingSession::Core own the telemetry logger and responsible
  for providing feedback data.
* Make the logger and runtime their own parameter when constructing the
  core, since they don't share the same lifetime as |session_context_|.
* Add DCHECK for |audio_player|.
* Remove WeakPtr from ClientTelemetryLogger.

Bug: 840492
Change-Id: I054c9a3317cbf17f7a45e6eae61c0f34018f9ca1
Reviewed-on: https://chromium-review.googlesource.com/1173738Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583092}

Bug: 715697
Change-Id: Ia64e5e9929a85bccb1a0124a5eff7dd3c72e453a
Reviewed-on: https://chromium-review.googlesource.com/1175144Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583091}

This change updates the document to reflect the new naming convention.

Bug: 806965

Change-Id: I3b37e8eb66e732caddec2739b29ba9e5788f4f56
Reviewed-on: https://chromium-review.googlesource.com/1174799Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583090}

This change updates the GaiaCookieManagerService to use the
CookieManager Mojo interface provided by the Network Service rather than
the net::CookieManager. The setup for listening to cookie changes can be
drastically simplified because the CookieChangeListener pipe can be
bound directly on the main thread and so all the thread hopping provided
by SigninCookieChangeSubscription is no longer needed.

Bug: 792663
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic84f66cf780a7f6ca9f0c6f1ff8da3ea1df65875
Reviewed-on: https://chromium-review.googlesource.com/1170224Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583089}

This reverts commit b58ccf6d.

Reason for revert: Possibly introduced a use-after-free bug.

This is a speculative fix for a use-after-free bug in two ash_unittests:

1. OverflowButtonInkDropTest.MouseContextMenu
2. OverflowButtonActiveInkDropTest.MouseContextMenu

[ RUN      ] OverflowButtonInkDropTest.MouseContextMenu
=================================================================
==28149==ERROR: AddressSanitizer: heap-use-after-free on address 0x613000031f68 at pc 0x000008c82106 bp 0x7ffea3cd7190 sp 0x7ffea3cd7188
READ of size 8 at 0x613000031f68 thread T0
    #0 0x8c82105 in begin buildtools/third_party/libc++/trunk/include/vector:1479:30
    #1 0x8c82105 in begin<std::__1::vector<aura::WindowObserver *, std::__1::allocator<aura::WindowObserver *> > > buildtools/third_party/libc++/trunk/include/iterator:1670
    #2 0x8c82105 in ContainsValue<std::__1::vector<aura::WindowObserver *, std::__1::allocator<aura::WindowObserver *> >, const aura::WindowObserver *, 0> base/stl_util.h:168
    #3 0x8c82105 in HasObserver base/observer_list.h:267
    #4 0x8c82105 in aura::Window::HasObserver(aura::WindowObserver const*) const ui/aura/window.cc:543
    #5 0x8c9d363 in aura::WindowObserver::OnUnobservingWindow(aura::Window*) ui/aura/window_observer.cc:25:15
    #6 0x8c799d7 in aura::Window::RemoveObserver(aura::WindowObserver*) ui/aura/window.cc:538:13
    #7 0xc2f40e in RemoveAll ui/base/window_tracker_template.h:49:15
    #8 0xc2f40e in ui::WindowTrackerTemplate<aura::Window, aura::WindowObserver>::~WindowTrackerTemplate() ui/base/window_tracker_template.h:33
    #9 0x9225f3b in ~CompoundEventFilter ui/wm/core/compound_event_filter.cc:49:1
    #10 0x9225f3b in wm::CompoundEventFilter::~CompoundEventFilter() ui/wm/core/compound_event_filter.cc:45
    #11 0x6b0ae30 in operator() buildtools/third_party/libc++/trunk/include/memory:2321:5
    #12 0x6b0ae30 in reset buildtools/third_party/libc++/trunk/include/memory:2634
    #13 0x6b0ae30 in ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2588
    #14 0x6b0ae30 in ash::Shell::~Shell() ash/shell.cc:969
    #15 0x6b0c81d in ash::Shell::~Shell() ash/shell.cc:737:17
    #16 0xc26b344 in ash::AshTestHelper::TearDown() ash/test/ash_test_helper.cc:294:3
    #17 0xc26444c in ash::AshTestBase::TearDown() ash/test/ash_test_base.cc:192:21
    #18 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11
    #19 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28
    #20 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43
    #21 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
    #22 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46
    #23 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277
    #24 0x72b9892 in Run base/callback.h:99:12
    #25 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224
    #26 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10
    #27 0x178df94 in main ash/test/ash_unittests.cc:37:10
    #28 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287

0x613000031f68 is located 296 bytes inside of 328-byte region [0x613000031e40,0x613000031f88)
freed by thread T0 here:
    #0 0x6b9062 in operator delete(void*) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:167:3
    #1 0x6a547a0 in ash::RootWindowController::CloseChildWindows() ash/root_window_controller.cc:498:7
    #2 0x6b0c5cf in ash::Shell::CloseAllRootWindowChildWindows() ash/shell.cc:1387:19
    #3 0x6b06637 in ash::Shell::~Shell() ash/shell.cc:837:3
    #4 0x6b0c81d in ash::Shell::~Shell() ash/shell.cc:737:17
    #5 0xc26b344 in ash::AshTestHelper::TearDown() ash/test/ash_test_helper.cc:294:3
    #6 0xc26444c in ash::AshTestBase::TearDown() ash/test/ash_test_base.cc:192:21
    #7 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11
    #8 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28
    #9 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43
    #10 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
    #11 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46
    #12 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277
    #13 0x72b9892 in Run base/callback.h:99:12
    #14 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224
    #15 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10
    #16 0x178df94 in main ash/test/ash_unittests.cc:37:10
    #17 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287

previously allocated by thread T0 here:
    #0 0x6b8422 in operator new(unsigned long) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:106:3
    #1 0x91cb856 in views::NativeWidgetAura::NativeWidgetAura(views::internal::NativeWidgetDelegate*, bool, aura::Env*) ui/views/widget/native_widget_aura.cc:109:15
    #2 0x91d615d in views::internal::NativeWidgetPrivate::CreateNativeWidget(views::Widget::InitParams const&, views::internal::NativeWidgetDelegate*) ui/views/widget/native_widget_aura.cc:1113:14
    #3 0x917dabd in CreateNativeWidget ui/views/widget/widget.cc:73:10
    #4 0x917dabd in views::Widget::Init(views::Widget::InitParams const&) ui/views/widget/widget.cc:334
    #5 0x6af249a in ash::ShelfWidget::ShelfWidget(aura::Window*, ash::Shelf*) ash/shelf/shelf_widget.cc:216:3
    #6 0x6a96eaa in ash::Shelf::CreateShelfWidget(aura::Window*) ash/shelf/shelf.cc:73:27
    #7 0x6a5847a in ash::RootWindowController::InitLayoutManagers() ash/root_window_controller.cc:699:11
    #8 0x6a52166 in ash::RootWindowController::Init(ash::RootWindowController::RootWindowType) ash/root_window_controller.cc:663:3
    #9 0x68ef135 in ash::WindowTreeHostManager::InitHosts() ash/display/window_tree_host_manager.cc:238:3
    #10 0x6afadce in ash::Shell::Init(ui::ContextFactory*, ui::ContextFactoryPrivate*, std::__1::unique_ptr<base::Value, std::__1::default_delete<base::Value> >, std::__1::unique_ptr<ui::ws2::GpuInterfaceProvider, std::__1::default_delete<ui::ws2::GpuInterfaceProvider> >) ash/shell.cc:1250:30
    #11 0x6af7163 in ash::Shell::CreateInstance(ash::ShellInitParams) ash/shell.cc:276:14
    #12 0xc26ac31 in ash::AshTestHelper::CreateShell() ash/test/ash_test_helper.cc:390:3
    #13 0xc26a2a0 in ash::AshTestHelper::SetUp(bool, bool) ash/test/ash_test_helper.cc:245:3
    #14 0xc263f8d in ash::AshTestBase::SetUp() ash/test/ash_test_base.cc:159:21
    #15 0x1322b16 in ash::ShelfViewTest::SetUp() ash/shelf/shelf_view_unittest.cc:262:18
    #16 0x1326366 in SetUp ash/shelf/shelf_view_unittest.cc:2369:20
    #17 0x1326366 in ash::OverflowButtonInkDropTest::SetUp() ash/shelf/shelf_view_unittest.cc:2778
    #18 0x4722b42 in testing::Test::Run() third_party/googletest/src/googletest/src/gtest.cc
    #19 0x4724c64 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2682:11
    #20 0x4726036 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2800:28
    #21 0x474b566 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:5124:43
    #22 0x474a7b5 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
    #23 0x72b431a in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2331:46
    #24 0x72b431a in base::TestSuite::Run() base/test/test_suite.cc:277
    #25 0x72b9892 in Run base/callback.h:99:12
    #26 0x72b9892 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) base/test/launcher/unit_test_launcher.cc:224
    #27 0x72b9330 in base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) base/test/launcher/unit_test_launcher.cc:575:10
    #28 0x178df94 in main ash/test/ash_unittests.cc:37:10
    #29 0x7f78e2b62f44 in __libc_start_main /build/eglibc-ripdx6/eglibc-2.19/csu/libc-start.c:287

SUMMARY: AddressSanitizer: heap-use-after-free buildtools/third_party/libc++/trunk/include/vector:1479:30 in begin
Shadow bytes around the buggy address:
  0x0c267fffe390: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c267fffe3a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c267fffe3b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 fa
  0x0c267fffe3c0: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
  0x0c267fffe3d0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
=>0x0c267fffe3e0: fd fd fd fd fd fd fd fd fd fd fd fd fd[fd]fd fd
  0x0c267fffe3f0: fd fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c267fffe400: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
  0x0c267fffe410: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
  0x0c267fffe420: fd fd fd fd fd fd fd fd fd fd fd fd fa fa fa fa
  0x0c267fffe430: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07 
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
  Shadow gap:              cc
==28149==ABORTING

Original change's description:
> cros: Enable touchable app context menus by default.
> 
> This will enable:
>  - New context menu UI for:
>   - Application icons
>   - Shelf context menus
>   - Desktop context menus
> 
> Note:
>  - Removed tests whose functionality were already being tested.
>    - MouseContextMenu already tests whether the ink drop is being
>      shown, so there is no need for
>      ShelfButtonShowsInkDropHighlightOnMenuShow.
> 
> Bug: 871843
> Change-Id: I4c92ae52f75b25bc9edd1dd67778c4785d8f4058
> Reviewed-on: https://chromium-review.googlesource.com/1170985
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Alex Newcomer <newcomer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#582978}

TBR=xiyuan@chromium.org,sky@chromium.org,newcomer@chromium.org

Change-Id: Ib85676861251f41c84f48f956d36c01edb353266
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 871843
Reviewed-on: https://chromium-review.googlesource.com/1174641Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583088}

Previously we added some debugging instrumentation in TouchActionFilter,
when the allowed_touch_action_ is set or reset to non-Auto. The results
that we see is not enough to diagose the crash.

This CL adds more detailed debugging. In particular, whenever it is set
or reset, we add a string.

Bug: 851644
Change-Id: I2d19055c1008659365f9c3f54fcbdb30760b2166
Reviewed-on: https://chromium-review.googlesource.com/1174696Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583087}

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/a2a458bd5d69..c0be499563b8

$ git log a2a458bd5..c0be49956 --date=short --no-merges --format='%ad %ae %s'
2018-08-13 kerrnel cryptohome: Add MOUNT_ERROR_REMOVE_FAILED.
2018-08-07 chirantan seneschal: Add storage location field
2018-08-07 mcchou service_contants: Add kErrorAlreadyExists to bluetooth_device namespace
2018-07-25 hendrich shill: Remove PriorityWithinTechnology property
2018-06-18 akhouderchah shill: Added new error strings for Service::ConnectFailure additions
2018-07-13 ljusten dbus/login_manager: Add deletion error string
2018-06-13 lndmrk Add DBus constant permission_broker::kPowerCycleUsbPorts

Created with:
  roll-dep src/third_party/cros_system_api

Bug: 211405
Change-Id: Iffa3919af789c351199aba156ccea181adcb8fdb
Reviewed-on: https://chromium-review.googlesource.com/1175005Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583086}

ChromeDriver was not starting successfully on Mac when --whitelisted-ips
option was used. This CL fixes it, while ensuring that ChromeDriver
always listen on the same IPv4 and IPv6 ports

Bug: chromedriver:2541
Change-Id: I2024e3c27ea0fcf262c7b5c54791b86ae6a3e0c1
Reviewed-on: https://chromium-review.googlesource.com/1175059
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583085}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

The AutoRoll server is located here: https://afdo-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: I132e5ebea28a97bd88b82f0d421ca716468822f4
Reviewed-on: https://chromium-review.googlesource.com/1175213
Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#583084}

Previously, the login screen would crash in both these cases (e.g. if
the powerwash confirmation dialog popped up and the user pressed
left/right arrow).

Change-Id: I5880d72112508de93e77c507239ea28c475d86ae
Reviewed-on: https://chromium-review.googlesource.com/1174907
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583083}

The sanity test looks much more stable:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/chromeos-amd64-generic-rel-vm-tests

This should be safe to land now.

Bug: 869904
Change-Id: Ic0d7e5537e9212b7f7aaf0250041c5a73353279d
Reviewed-on: https://chromium-review.googlesource.com/1174968Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583082}

This is a bit closer to webui-login's behavior (although currently it doesn't
gracefully handle bubbles extending past the bottom of the screen). This also
prevents the auth error bubble from suddenly jumping to the right if it extends
into the shelf a bit.  This Cl also changes the error bubble bounds calculation
to include all of the black box, rather than just the internal content.

Bug: 873953
Change-Id: I13d670a208418f77232c59b756fb7854e1c88cc2
Reviewed-on: https://chromium-review.googlesource.com/1175196Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583081}

Line length should not exceed 376dip and should have a line height of
24dip.

See bug for spec/demo.

Bug: b:112597108
Change-Id: Ic0b920d33bc0d571b98f7622a0e9d0fb965c74f1
Reviewed-on: https://chromium-review.googlesource.com/1175057Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#583080}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/db93180205a6..a2f48ac5546b


git log db93180205a6..a2f48ac5546b --date=short --no-merges --format='%ad %ae %s'
2018-08-14 dgarrett@google.com chromeos_config: Disable chrome_binhost_only globally.


Created with:
  gclient setdep -r src/third_party/chromite@a2f48ac5546b

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I1355c118e89be711526f97554a00095b413eb52b
Reviewed-on: https://chromium-review.googlesource.com/1174798Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#583079}

Previously we thought this was only flaky on devices. It is also flaky
on simulator.

TBR=justincohen, javierrobles

Bug: 873633
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iddc823fc1034ba26db75da1b42a63a864e58878a
Reviewed-on: https://chromium-review.googlesource.com/1175194Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583078}

This CL removes unused SqlitePersistentCookieStore::Close().

Bug: 801910
Change-Id: Ibba90aaeb5c07215de73e85f33bb5c4067cf9f42
Reviewed-on: https://chromium-review.googlesource.com/1174948Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583077}

Tbr: tbuckley@google.com
Change-Id: Ia9079c26605d5cee901b46a13335985ca4ec9e49
Reviewed-on: https://chromium-review.googlesource.com/1174575
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583076}

Move AppListView::ExcludeWindowFromEventHandling from browser process
to app list code in ash process.

Bug: 854787
Change-Id: I7509fdd8c5cc4ea0db211bdc4c7fe8715fb10660
Reviewed-on: https://chromium-review.googlesource.com/1170036
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583075}

Firebase target depends on a Firebase resources target instead of a
file path. Build configurations that want Firebase enabled should
define a target to bundle GoogleService-Info.plist to application
bundle.

At the same time, unit test and Earl Grey test targets need Firebase
SDK too.

Bug: 848117
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I902437afc93dcef39ccdbc89287638ae9d761afe
Reviewed-on: https://chromium-review.googlesource.com/1162713
Commit-Queue: Peter Lee <pkl@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583074}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5ce57437..4f1630e3

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I40321b5e2126f7f905e77c76998acc5246e51e59
Reviewed-on: https://chromium-review.googlesource.com/1175088Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#583073}

Verified it works on a Paine. This is a regression caused by
https://chromium-review.googlesource.com/c/chromium/src/+/1138861

Bug: 873609
Change-Id: I929fb3be9f0f811d901811aebf34c8c52ea42bf2
Reviewed-on: https://chromium-review.googlesource.com/1175192Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583072}

This reverts commit 3dcaec6e.

Reason for revert: Failing Linux MSan tests

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20MSan%20Tests/11191

DevTools listening on ws://127.0.0.1:34267/devtools/browser/a12caedc-549b-4d49-b9bb-a0519f91f318
==14126==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x3c2bb23 in ExitFullscreenModeForTab ./../../content/browser/web_contents/web_contents_impl_browsertest.cc:1561:9

Original change's description:
> Security drop fullscreen for any nested WebContents level.
> 
> BUG=873080
> TEST=as in bug
> 
> Change-Id: Icd75715ac42789c84870967b11c9917a972ae086
> Reviewed-on: https://chromium-review.googlesource.com/1173342
> Commit-Queue: Avi Drissman <avi@chromium.org>
> Reviewed-by: Sidney San Martín <sdy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#582970}

TBR=avi@chromium.org,sdy@chromium.org

Change-Id: I52a9b29f2d17ea6e7db0128815653de624fa5b13
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 873080
Reviewed-on: https://chromium-review.googlesource.com/1174640Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583071}

Now that we display a wider range of web content, some sites are
serving desktop sites with images too large for our memory limits
and so on.

Longer-term, it may be possible to use this UA string for all products.

Bug: internal b/112465626
Change-Id: I5c30b1966f75143eb5d99efabfb9093bf6159e90
Reviewed-on: https://chromium-review.googlesource.com/1175087Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583070}

1. Employs a static local variable to store the single instance which is thread safe.
Also prevents destruction which is not thread safe.
2. Took the opportunity to do some cleanup:
Added "const" and "* const" to some places.
Move the COMInitializer to the tools module because there should only be one instance per module and content_browsertests already had one instance.
Used FAILED instead of !SUCCEEDED.
R=sdi@chromium.org, mcasas@chromium.org, aleventhal@chromium.org

Change-Id: Ie4ed3db74342e42c9325a647401b03a44aa0cba2
Reviewed-on: https://chromium-review.googlesource.com/1171562
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583069}

Devices using certain legacy Empia chips appear to get listed and report valid
formats in both DirectShow and MediaFoundation but only work in DirectShow when
actually trying to open them.

This CL adds a blacklisting mechanism that forces device models known to exhibit
this issue to always get opened with DirectShow instead of MediaFoundation.

Test: capture_unittests.exe --gtest_filter=VideoCaptureDeviceFactoryMFWinTest*
Bug: 792640, 849636, 862395
Change-Id: Ia70d13a45eb49ed185f27630d0e544f3a484b6f2
Reviewed-on: https://chromium-review.googlesource.com/1174902Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583068}

Crash dumps are unclear and the issue seems resolved on Pixel hardware,
but some earlier stack traces suggest we're getting a null TaskRunner
when attempting to BindToCurrentLoop during CreateCodec(). As such
move binding to a known good thread.

This should be reverted if the issue is not fixed. If it is fixed
there's additional work to be done to understand the consequences
of CreateCodec() being called on an unexpected thread.

BUG=873094
TEST=none

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I2928d7866c1f40de63f526ee7393d2d8b90884f2
Reviewed-on: https://chromium-review.googlesource.com/1175092Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583067}

This caps these devices support for hardware decoding to 1080p.

BUG=873996
TEST=none

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I4b640cf8537a33518d06994d9aaeac772e428b8e
Reviewed-on: https://chromium-review.googlesource.com/1175095
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583066}

Use network quality tracker instead of network quality estimator (NQE)
to obtain network quality in data reduction proxy component.

Network quality tracker can provide network service when network
service is enabled as well as when network service is disabled.

data_reduction_proxy_service.h receives network quality
estimates on UI thread from network quality tracker.
On receiving estimates, it posts them to d_r_p_io_data
which lives on IO thread, and consumes the estimates.

PS#2 is the original CL that got reverted.

Bug: 819244
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Id9f28abaea42a7eb55dd3647c88d13a427a4e5ae
TBR: xunjieli@chromium.org, sky@chromium.org, ryansturm@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1174698
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583065}

Bug: 866941
Change-Id: I1c5a6a8117eb347dbe838ae1818e726ff1dafcb7
Reviewed-on: https://chromium-review.googlesource.com/1175062Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583064}

This reverts commit 562c52f7.

Reason for revert: cc_unittests failing on Linux TSan:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20TSan%20Tests/24797

[ RUN      ] LayerTreeHostTilesTestPartialInvalidation.PartialRaster_SingleThread_OneCopy
[22487:22487:0814/143420.957209:26522082454:ERROR:pixel_comparator.cc(47)] Number of pixel with an error: 30000
[22487:22487:0814/143420.957442:26522082676:ERROR:pixel_comparator.cc(48)] Error Bounding Box : 0,0 200x200
[22487:22487:0814/143421.140401:26522265659:ERROR:pixel_test_utils.cc(79)] Pixels do not match!
[22487:22487:0814/143421.140586:26522265816:ERROR:pixel_test_utils.cc(80)] Actual: data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAMgAAADICAYAAACtWK6eAAACHUlEQVR4nO3VMRHAMBADwXf4ozUBh0DmWqfYRaDmRmvvOQN8em4PgD8TCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQBAIBIFAEAgEgUAQCASBQFgz+9weAX/lQSAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAIAgEgkAgCASCQCAIBIJAILygpAZjjfRdXgAAAABJRU5ErkJggg==
[22487:22487:0814/143421.140737:26522266017:ERROR:pixel_test_utils.cc(81)] Expected: data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAMgAAADICAIAAAAiOjnJAAACNklEQVR4nO3dsQ0DMQwEQb3hWP3XqQrcgEMvnm/MVMBgwfSutc6CX3vdfQD/SVgkhEVCWCSERUJYJIRFQlgkhEVCWCSERUJYJIRFQlgkhEVCWCSERUJYJIRFQlgkhEVCWCSERUJYJIRFQlgkhEVCWCSERUJYJIRFQlgkhEVCWCSERUJYJIRFQlgkhEVCWCSERUJYJIRFQlgkhEVCWCSERUJYJIRF4n33Ad+ds+8+4TH2nriR62OREBYJYZEQFglhkRAWCWGREBYJYZEQFglhkRAWCWGREBYJYZEQFglhkRAWCWGREBYJYZEQFglhkRAWCWGREBYJYZEQFglhkRAWCWGREBYJYZEQFglhkRAWCWGREBYJYZEQFglhkRAWCWGREBYJYZEQFglhkRAWCWGRuM7Eec6hq6EzzVyj9bFICIuEsEgIi4SwSAiLhLBICIuEsEgIi4SwSAiLhLBICIuEsEgIi4SwSAiLhLBICIuEsEgIi4SwSAiLhLBICIuEsEgIi4SwSAiLhLBICIuEsEgIi4SwSAiLhLBICIuEsEgIi4SwSAiLhLBICIuEsEgIi4SwSAiLhLBIDF1Y5el8LBLCIiEsEsIiISwSwiIhLBLCIiEsEsIiISwSwiIhLBLCIiEsEsIiISwSwiIhLBLCIiEsEsIiISwSwiIhLBLCIiEsEsIiISwSwiIhLBLCIiEsEsIiISwSwiIhLBLCIiEsEsIiISwSwiIhLBLCIiEsEsIiISwSwiIhLBIfCVIMShDYZKEAAAAASUVORK5CYII=
../../cc/test/layer_tree_pixel_test.cc:129: Failure
Value of: MatchesPNGFile(*result_bitmap_, ref_file_path, *pixel_comparator_)
  Actual: false
Expected: true
Stack trace:
#0 0x000001ceb5ff (/b/s/w/ir/out/Release/cc_unittests+0x1ceb5fe)
#1 0x0000017ae1e9 (/b/s/w/ir/out/Release/cc_unittests+0x17ae1e8)
#2 0x0000017bda1f (/b/s/w/ir/out/Release/cc_unittests+0x17bda1e)
#3 0x0000017bd178 (/b/s/w/ir/out/Release/cc_unittests+0x17bd177)
#4 0x000001a362be (/b/s/w/ir/out/Release/cc_unittests+0x1a362bd)
#5 0x000001a3b5ba (/b/s/w/ir/out/Release/cc_unittests+0x1a3b5b9)

[  FAILED  ] LayerTreeHostTilesTestPartialInvalidation.PartialRaster_SingleThread_OneCopy (4296 ms)

Original change's description:
> Roll src/third_party/skia 32c7d4dfcdca..d19fed1e291d (2 commits)
> 
> https://skia.googlesource.com/skia.git/+log/32c7d4dfcdca..d19fed1e291d
> 
> 
> git log 32c7d4dfcdca..d19fed1e291d --date=short --no-merges --format='%ad %ae %s'
> 2018-08-14 fmalita@chromium.org [skottie] Eliminate some temp SkString allocations
> 2018-08-14 mtklein@google.com pass sprite opacity to color xform when blitting.
> 
> 
> Created with:
>   gclient setdep -r src/third_party/skia@d19fed1e291d
> 
> The AutoRoll server is located here: https://autoroll.skia.org
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
> 
> If the roll is causing failures, please contact the current sheriff, who should
> be CC'd on the roll, and stop the roller if necessary.
> 
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> TBR=kjlubick@chromium.org
> 
> Change-Id: Ib608389718b76c94782e3415bcc82dc607902e82
> Reviewed-on: https://chromium-review.googlesource.com/1174793
> Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#583019}

TBR=kjlubick@chromium.org,skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com

Change-Id: I0e6bc9c3c8c052a0ae17eb292cad8bb5e579faf2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1174639Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583063}

Final cleanup after https://crrev.com/581931

Bug: internal b/73383411
Test: manual
Change-Id: I9407ebbaa7b189bf3b71aa1700451198ec5c5810
Reviewed-on: https://chromium-review.googlesource.com/1169586Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583062}

Port a couple related browser tests to ash unit tests.

Change-Id: Id1fcf3b823b3f470dc93d651c681738053cc3383
Reviewed-on: https://chromium-review.googlesource.com/1173152Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583061}

Bug: 874102
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I64ae721146a6ac631800bd0bbd1ca6cca9f522f8
Reviewed-on: https://chromium-review.googlesource.com/1172741
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583060}

Previously, "OK Google"
Now, "Ok Google"

This string is used in Chrome OS settings.

Bug: b:112326023
Change-Id: Ic69713f93518241ade199034bce0a0c1063e89e1
Reviewed-on: https://chromium-review.googlesource.com/1171219Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Xiao Yang <yanxiao@google.com>
Cr-Commit-Position: refs/heads/master@{#583059}

"Answering on another device":
  To display when disambiguating "Ok Google" and we lose devie
  selection to another surface.

"What's on my screen":
  show on suggestion chip in Assistant UI to initiate a contextual search

Bug: b:112464186
Change-Id: Ia61f12d3c39f5005486824ad7982736719dfd14b
Reviewed-on: https://chromium-review.googlesource.com/1173263Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Xiao Yang <yanxiao@google.com>
Cr-Commit-Position: refs/heads/master@{#583058}

Bug: 854704
Change-Id: If3326d678e53b3ccff89bcd2ba98d02a0611b605
Reviewed-on: https://chromium-review.googlesource.com/1172739Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583057}

SafeStack [1] introduces a secondary thread stack called the unsafe
stack that also needs to be scanned for object references. Introduce
matching logic in oilpan to scan the unsafe stack for heap references.

[1] https://clang.llvm.org/docs/SafeStack.html

Bug: 864705
Change-Id: I376077bd985e2077aa3771101c1822e1570c7807
Reviewed-on: https://chromium-review.googlesource.com/1169772Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583056}

This patch adds a flag indicating whether an iframe element is occluded
or has visual effects applied in the parent document; and adds the flag
to the IPC message containing the iframe's intersection with the
parent's viewport.

BUG=869049
R=kenrb@chromium.org,chrishtr@chromium.org

Change-Id: I0891a3e6740dbce39f0cf0120353feb8c9fca173
Reviewed-on: https://chromium-review.googlesource.com/1167960Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583055}