- 27 Oct, 2020 40 commits
-
-
ssid authored
Chained tasks and async tasks are traced using the wrapper class name. Add trace events to track these tasks BUG=1136635 Change-Id: Ibafce336fbfc4f7491bd196b93b92bf42ad143e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491402Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#821440}
-
Samuel Attard authored
This is done so that the arm64 and x64 v8 context snapshots can live side by side in a universal app build of a Chromium based application. All other files can be Mach-O universal binaries generated using "lipo" but these snapshot files have to be uniquely named so that both can exist in the Resources folder at the same time and the correct one is chosen at runtime. Bug: 1142017 Change-Id: I8449b72ba3a36e7ce69b9d9ec7768bd80ecc3e3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490980Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#821439}
-
Alex Moshchuk authored
The suspected cause of flakiness here is that the page used in the test scrolls an OOPIF, but doesn't properly wait for layout to finish and for visibility/viewport intersection changes to be propagated to the corresponding CrossProcessFrameConnector. This was verified by inserting an artificial delay into RemoteFrameView::VisibilityChanged(). Fix this by inserting a EvalJsAfterLifecycleUpdate, which will trigger requestAnimationFrame and should wait for layout to finish. This usage is similar to a few other uses of EvalJsAfterLifecycleUpdate for syncing viewport intersection changes in other tests in this file. Bug: 1135072 Change-Id: I49434044a617b1530ce121c24d97aa7071760c9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503316Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#821438}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ibb4639453b2d172dbdd4d8768be5d0083c66b198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503592Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821437}
-
Nicolás Peña Moreno authored
In this CL we upgrade ExperimentalLargestContentfulPaint to become the default version. To do this, we do the following: * Update the LargestContentfulPaintCalculator in Blink since the web API now should report according to the Experimental version, which is equivalent to reporting by the values in the detectors monotonically. That is, we just store the largest text or image size and we report a new entry whenever we find a candidate with a larger size. * In Blink's PaintTimingDetector, swap the experimental values with the non-experimental ones, so that ExperimentalLCP becomes the 'actual' LCP and the previous LCP becomes 'experimental'. * In the browser side, change the naming of the experimental vs current LCP histogram names in both UMA and UKM, so that the experimental name becomes LCP while the current version becomes LCP2. This means that the current 'experimental' histograms become obsolete as they are no longer reported. This is done to continue reporting LCP for some time to support Finch and other users of these metrics while the transition occurs. In a couple of months or so, we will stop reporting the 'experimental' version of LCP, which means not reporting the LCP (not LCP2) histograms. This will also enable simplifying the Image and Text PaintTimingDetectors in Blink, as we will no longer need to keep track of the paint timestamps of all nodes being painted. Ukm collection review: https://docs.google.com/document/d/1gIQ6XuUZtaRb-BmqW8QWpt_cJdIeCsHsAvPVQkiaOhM/edit Bug: 1045640 Change-Id: I2e27c0f940656b12766feeff3d506c90152f28d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480845 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#821436}
-
Alex Turner authored
base::Bind is deprecated and should be replaced with the more explicit Once/Repeating form. The majority of chrome/tools was already migrated, but one use remained. We fix that and enable the presubmit to avoid any future regressions. Bug: 1141533, 1007644 Change-Id: Iffd78f79fa65caeeb3f4a6764952a2eebd126361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495605Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Zhaoyang Li authored
Added 2 builders and 3% experiment ios-simulator-coverage-exp mirrors ios-simulator ios-simulator-full-configs-coverage-exp mirrors ios-simulator-full-configs Removed 3% experiment on ios-simulator-code-coverage try builder. Bug: 1090188 Change-Id: Ia797ef663b3ab448387057c77b939af3ed937c2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495962Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#821434}
-
Michael Hansen authored
This adds a "pulse" animation to the send discovery dialog, which gives a visual indication that scanning is underway to attempt to discover other devices to share with. This animation will also be added to the high-visibility receive dialog in a separate CL. Screenshot: https://screenshot.googleplex.com/4AYJTgtGcVHAuRi.png Spec: https://carbon.googleplex.com/cros-ux/pages/nearby-share/motion Bug: b:170890753 Change-Id: I7361021ba3ae4fbc03a01d055eb6ba10e5c65716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500279 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#821433}
-
Victor Costan authored
This CL replaces smart pointers (scoped_refptr) with references where the pointers are guaranteed to be non-null, and the objects are only used during the method call. This removes the test's reliance on QuotaClient being ref-counted, which will come in handy when QuotaClient gets mojofied. Bug: 1016065 Change-Id: I0ec5ea2f40c03bbdb4e6af504d6f2b4902115c31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496743 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#821432}
-
Hoch Hochkeppel authored
Adding support for IDataRequestDeferral to the FakeDataTransferManager, as well as adding a test-only PostDataRequested event for easily intercepting the data shared by a DataRequested handler. Also expanding the corresponding tests to validate this new behavior. Bug: 1035527 Change-Id: I44589302272e432b3ea7201b50faa2d90d254194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500947Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Hoch Hochkeppel <mhochk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#821431}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/57694c8dab3c..fcbc6efa8fd3 2020-10-27 rharrison@chromium.org [inspector] Extract storage-buffer information If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: rharrison@google.com Change-Id: Ia7fb9281e954f3a4e7d7291a73b1de5bb48ee25c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503771Reviewed-by:
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=kenrb@chromium.org Bug: 1142671 Change-Id: I0826f093bde1723c93139f7d4b7bb388aae7074e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500663 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#821429}
-
Shengfa Lin authored
The root level node could be a javascript Proxy object(https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Proxy) instead of the document itself. In this case, we cannot use "== document" to check if an element is reachable and generate the stale element error. Instead, we will use "== document.documentElement.parentNode", which should be document or the Proxy node. Bug: chromedriver:3628 Change-Id: Ie7c7c78e0e796dcf3023aa1d5385fa95bd139ba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502576Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#821428}
-
Victor Costan authored
This CL replaces smart pointers (scoped_refptr) with references where the pointers are guaranteed to be non-null, and the objects are only used during the method call. This removes the test's reliance on QuotaClient being ref-counted, which will come in handy when QuotaClient gets mojofied. Bug: 1016065 Change-Id: I03493aa3e62d8cac2b8b9d81ace5d44dbfa75915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496744Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#821427}
-
James Cook authored
Prior to this CL, files downloaded in Lacros would "disappear" -- they would not show up in the file manager. The downloads code would choose its default directory using the Chrome for Linux path provider, which does not know about Chrome OS paths, and the files would end up in a directory the file manager can't navigate to. Add chrome_paths_lacros.cc to supply the correct paths. Because Lacros does not support Chrome OS multi-signin, we make the decision that lacros-chrome does not need to know about the under-the- hood /home/chronos/u-{hash} multi-signin profile directories. It uses the hard-linked /home/chronos/user path for the system primary profile. This avoids exposing knowledge of the hash to Lacros. Bug: 1139082 Change-Id: I8836760632fd9a1a8f9d49d7f03f1e6f6dfb0841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500278Reviewed-by:Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#821426}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 655d04d4. With Chromium commits locally applied on WPT: 6eb4060f "Add WP test for referrer policy inheritance when navigating back" a9818a74 "Add epislon to matrix tests to fix 0 = -0 problem" 655d04d4 "Fix referrer policy inheritance WPT for javascript: URLs" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I43dfa9e6e04f3e251945589b674b0b1bef42dff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503428Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821425}
-
Jimmy Gong authored
- This change fixes a bug where we previously did not actually attach PhoneStatusProcessor as an observer to MultiDeviceSetupClient::Observer - Fixes a bug where the phone name was not being displayed in the phone hub tray Bug: 1106937 Fixed: 1141642 Test: chromeos_components_unittests Change-Id: I4a7b04e34a5b7950b63a4b32dc633fece7c52e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501063 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#821424}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=kenrb@chromium.org Bug: 1142671 Change-Id: I2be70e691cb316d4ac5ae5c48b309758d30cfd07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500493 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=hanxi@chromium.org Bug: 1142671 Change-Id: I527f1a4dda878d289ac3542336b87737bd377f8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500590 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#821422}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=hanxi@chromium.org Bug: 1142671 Change-Id: I28b7b2eb82e87e409f370d044f1aa2e4845d764d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500605 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ibfca948636ea19a4da798f38d5056088e93f1772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504028Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#821420}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/25eeaa3d39af..6b087819dd1e 2020-10-27 cwallez@chromium.org s/OutputAttachment/RenderAttachment/g If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: I14b1a1e9a97bbc6870e8346ffd2cb8970c412970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503589Reviewed-by:
-
ckitagawa authored
This CL restricts the number of outbound requests to the paint preview compositor for processing bitmaps to 4. This should limit the peak memory usage and might reduce OOM crashes. This CL also makes it possible to cancel queued requests. As a result, when flinging or zooming where many requests are made at once, it is possible to clear pending requests for tiles that exit the viewport before the request is served. Bug: 1142545 Change-Id: I8f4859c61e5ffd1fa017dd840fac57fe8deb79ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497825 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#821418}
-
Dave Tapuska authored
Move the allocation of the shared memory segment for ukm smoothness from RenderWidget to LocalFrameClientImpl. BUG=1097816 Change-Id: Ib95690ed560e80a4bd43da5be534ae82a5370fce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495612 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#821417}
-
Maggie Chen authored
From https://codepen.io/wesselkroos/pen/KKpGReq, we can clear see the blur the area modify by the blur effect is actually 3x of the blur radius. See the screen shot in crbug.com/1117235. Bug: 1117235 Change-Id: Ib38b70b28bc4bc181ea6366d9d84ad7f7e60b08a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493983Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#821416}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0fb0eb3e80c0..ee24eb66d23f 2020-10-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0cbcb123..473d43b3 (821065:821175) 2020-10-27 philipp.hancke@googlemail.com unify "control reaches end of non-void function" style 2020-10-27 ssilkin@webrtc.org Change SPS/PPS id update strategy to SPS_LISTING. 2020-10-27 terelius@webrtc.org Revert "Reland "Default enable WebRTC-SendSideBwe-WithOverhead."" 2020-10-27 fabien.vallee@netgem.com Fix "control reaches end of non-void function" warnings 2020-10-27 philipp.hancke@googlemail.com getstats: fix inbound-rtp audio level range 2020-10-27 hta@webrtc.org Make SdpOfferAnswerHandler be owned, not contained. 2020-10-27 asapersson@webrtc.org test::CreateVideoStreams: Use default unconfigured VideoStream if layer is missing in config. 2020-10-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision cd03b6f1..0cbcb123 (820940:821065) 2020-10-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 437e5d9a..cd03b6f1 (820819:820940) 2020-10-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4d9dbbae..437e5d9a (820701:820819) 2020-10-26 danilchap@webrtc.org Make ScalableVideoController::OnRatesUpdated pure virtual 2020-10-26 sprang@webrtc.org Tweaks videocodec_test threshold for arm vp8 simulcast 2020-10-26 hta@webrtc.org Const-declare 3 more PC member variables 2020-10-26 kron@webrtc.org Signaling for low-latency renderer algorithm 2020-10-26 jakobi@webrtc.org Reland "Default enable WebRTC-SendSideBwe-WithOverhead." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1111273,chromium:1138888,chromium:1142626 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Idb9d274c08946a2fe3381c73fded1b5dd16c860f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503773Reviewed-by:
-
Tom Anderson authored
This CL removes usage of XLookupString() that was temporarily introduced by [1]. The issue is that the XKB keyboard map wasn't being used when XKB was available -- the core keyboard map was always being used. This meant that XKB-specific features like keyboard groups and fifth-level shift became unsupported. This CL separates the XKB and non-XKB codepaths into 2 classes: XkbKeyboardState and CoreKeyboardState. This CL also moves the keyboard-related code out of connection.cc into keyboard_state.cc. [1] https://source.chromium.org/chromium/chromium/src/+/a2fd175c6a692351827aacd8e1285d2190ccd4e4 R=sky BUG=1066670 Change-Id: I26023f87c396f5728ce32c0d1fb0275e0335db15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464786 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Ioana Pandele authored
The editor should now be launched directly by tapping on the password entry in Settings > Password. This CL also separates the editing-specific tests from PasswordSettingsTest.java. Only integration tests that actually rely on PasswordSettings are left there. Bug: 1141409, 1122310 Change-Id: Ie8d742d64e40b9881b35bf24a333d59c9b4cef02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494922 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#821413}
-
Tom Anderson authored
This is required as a prerequisite for landing: https://chromium-review.googlesource.com/c/chromium/src/+/2464786/ BUG=1066670 R=yhodique@google.com,johnwedig@google.com,dpranke@chromium.org Change-Id: Id69ddf2b22f31d93b003a632b64f938b0ce3a55e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500268Reviewed-by:
-
John Delaney authored
What: Use a single LazyThreadPoolSequencedTaskRunner for all conversion storage operations. Why: Conversion Storage doesn't have strong ordering guarantees regarding databases being torn down and recreated for the same profile. E.g. Profile closed -> delete posted to task runner A Profile opened -> create posted to task runner B We assume that task runner A will finish executing the delete, freeing the database prior to task runner B trying to open it. However, if task runner A has a long running operation already sequenced, this isn't necessarily true. Using a unified task runner removes this edge case. This also removes the need to do any dependency injection which is discouraged for task runners. Bug: 1114783 Change-Id: If09d0a9a68ec0d461321744f2734c28b0ccbe068 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490256Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
-
Natalie Chouinard authored
This change is necessary to roll downstream GMS Core, which includes new proguard rules added via META-INF/proguard in google_play_services_basement_java. Change-Id: I0883ffe043a8dae267fa2e82757996e64cefd37f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503813Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#821410}
-
Steven Bennetts authored
This replaces the restricted_connectivity property to a more versitale portal_state property and enum. Bug: 1133376 Change-Id: I2229e2675b95ceea7184bdfd773b85be12e3217d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490252 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kartik Hegde <khegde@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#821409}
-
Tim Song authored
This CL implements 3 histograms for the phone connected screen: * Ash.PhoneHub.NotificationOptInEvents * Ash.PhoneHub.QuickActionResult.* * Ash.PhoneHub.TabContinuationChipClicked BUG=1138137,1106937 Change-Id: Ic6cb37d5dd5208a09dee1249540c8f3c877be3a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491243Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
Maggie Chen authored
A wrong transform metrix is picked when calling AddSurfaceDamageToDamageList(). Bug: 1117235 Change-Id: Icf6529448f6973395068ee0601ec975f5c5bdb20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500311Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#821407}
-
spdonghao authored
This CL makes startSurfaceToolbar act as if it's scrolling with start surface. And once the omnibox is scrolled up to the top, the real search box is pinned. Please see this doc for more information: http://doc/1m7MBIKFt1qPuv7grxgllAhb6Umaur_T6pwegeWHuDNI#heading=h.xcr03ehfori3 Following work needed to do: - Add an animation for showing the toolbar container view when omnibox is disappearing. - Remove the progress bar that sometimes shows. crbug.com//1136599 Bug: 1113852, 1041123 Change-Id: I7909bc2fe3caa46758c73e5a4d952ccfdec4fd96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426730 Commit-Queue: Hao Dong <spdonghao@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#821406}
-
Ievgen Rysai authored
This fix gives assistive software a fine-grained control over selection. In Safari this attribute is settable. Bug: 1139106 Change-Id: Ibff2665ee0bd2db77ce692385eb7f4965f15626b AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478782 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#821405}
-
Greg Thompson authored
The cleanup code was removed in r819537. This CL removes the handling of the --cleanup command line switch. BUG=none R=gab@chromium.org Change-Id: Iba5e9cd057378ccf2712f12f37589d6b84b0f7d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502161 Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#821404}
-
Solomon Kinard authored
Bug: 1133624 Change-Id: Ifc584797d31485ef53dbc5f29cbc7f97213705bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476516 Commit-Queue: Solomon Kinard <solomonkinard@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#821403}
-
Alexander Cooper authored
Screen Capture on Android hasn't been updated since it was only exposed via getUserMedia. This change: * Adds a UI flag to enable the feature * Expands the DCHECK to allow getDisplayMedia calls to work * Removes a DCHECK that width/height are even * There was no comment for this DCHECK and if there were a technical limitation, it appears to have been removed. With this change (and the flag enabled) getDisplayMedia seems to work, at least for a simple golden-path scenario. Bug: 487935 Change-Id: Ic340345d15798947ba22e9962d5a83a83a974a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495823Reviewed-by:Guido Urdaneta <guidou@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#821402}
-
Meilin Wang authored
This CL polishes the interstitial screen including: - Makes progress bar the same width as the bubble. - Updates constants to spec. Screenshot: https://screenshot.googleplex.com/73uEHo56GiKENdQ.png Misc: removes unused |AddSeparator| function. BUG=1106937,1126208 Change-Id: If44bd19b8347a0385dd0be975fd42189eb4a4a01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495977 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#821401}
-
