- 29 Aug, 2019 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/022a7c8d4980..25eb47ccf18f git log 022a7c8d4980..25eb47ccf18f --date=short --no-merges --format='%ad %ae %s' 2019-08-29 tommi@webrtc.org Make the RtpHeaderParserImpl available to tests and tools only. Created with: gclient setdep -r src/third_party/webrtc@25eb47ccf18f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:none Change-Id: I6f43e6abdfc68afa2898968048b2043c193b583f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776388Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691768}
-
Josh Nohle authored
Adds metrics to track the execution times of async function calls during the CryptAuth v2 DeviceSync flow. These values will be used for tuning timeout values. Bug: 951969, 933656 Change-Id: I9669429b0faf845f1f16fb82b53ba884cb4ab7fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743096 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#691767}
-
Evan Stade authored
This removes the notification from about half of the tests where it's used. Bug: 268984 Change-Id: I9478164ccaac46b07a57f8f80d43f053c2675506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773845Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#691766}
-
Tarun Bansal authored
Add hardcode denylist for DeferAllScript lite page. URL of the webpage is matched against a pre-compiled regex. The purpose of this change is to land a merge-able change to exclude many login and some banking pages from the preview treatment. Change-Id: I125d3e66d4bb4efbfbfef3e19f8acebd7ce9e01b Bug: 999242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775103Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#691765}
-
Max Moroz authored
Some buildbots are executing `ninja all` and fuzz targets should not be attempted to be built there unless certain GN flags are enabled. Bug: 999096 Change-Id: I11addbe7ab00a5ef8c57559bd84a1ec4b287f212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775756 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#691764}
-
Jordan Demeulenaere authored
This CL fixes a bug introduced in http://crrev/c/1710898: when showing a bottom sheet content that has its own toolbar, the default toolbar visibility was set to gone. After that CL, the default toolbar visibility is not changed anymore. This causes a visual bug in the peek state when the content toolbar height is smaller than 56dp. Before: https://screenshot.googleplex.com/2kHm6NpPZRx.png After: https://screenshot.googleplex.com/AKx4yVYssyz.png Change-Id: I1b35b17fe7c5eb8d257f0ceab4a565f3b4182724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774451 Auto-Submit: Jordan Demeulenaere <jdemeulenaere@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#691763}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b1f411ac053d..3783375c4d41 git log b1f411ac053d..3783375c4d41 --date=short --no-merges --format='%ad %ae %s' 2019-08-29 herb@google.com Only send the RemoteStrikes that have pending glyphs. Created with: gclient setdep -r src/third_party/skia@3783375c4d41 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: None Change-Id: I8a62b56d3ecc2e26ca4f57eee9887804f9519340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776387Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8dd0eb227a3f..793b6c3d0b6b git log 8dd0eb227a3f..793b6c3d0b6b --date=short --no-merges --format='%ad %ae %s' 2019-08-29 capn@google.com Disable Vulkan projects in Visual Studio solution build Created with: gclient setdep -r src/third_party/swiftshader@793b6c3d0b6b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/139189696 Change-Id: Ifef23440066867918f6d5ebf17fa3ed3e74f5965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776386Reviewed-by:
-
James Cook authored
When the user manually selects a timezone we keep showing the autodetect method menu, but disable it. This makes the UI shift around less than the old approach, which was to hide the menu. If the user chooses a custom timezone the menu is disabled and it shows the default (IP address) label. This means the label may switch from the WiFi option to the IP address option if the user toggles back and forth between the "Set automatically" and "Choose from list" radio buttoms. Our PM Jesse is OK with this. If policy disables automatic timezones the menu is disabled and the label is 'Automatic time zone detection is disabled'. Before: - automatic: https://screenshot.googleplex.com/TsyNYwjg0HS - manual: https://screenshot.googleplex.com/1eTPHgBqOwF - policy: https://screenshot.googleplex.com/9ZWzTHaawra After: - automatic doesn't change - manual: https://screenshot.googleplex.com/4bf2aG4FwJt - policy: https://screenshot.googleplex.com/KqPh3q7pwQT Bug: 997118 Test: updated browser_tests Change-Id: Ieb5f3d4df887082e981518bddd895ecd8bbf5fd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769234Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
-
Andrew Xu authored
Add focus traversal to ScrollableShelfView Bug: 973481 Change-Id: I3beeea53aff1ed32ccb588f2033ab67851590574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767484 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2fe742d3173c..4d747ae4be07 Created with: gclient setdep -r src-internal@4d747ae4be07 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: If6b9a255140e953d20df02b0dc18eaa208eda060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776385Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#691758}
-
Hector Carmona authored
No UI change, only behavior on which menu to show. Both menu and selection are pre-existing UI. Bug: 910412 Change-Id: I7335ef5b2e5675b6ff0de5bde14dc5144a4d7311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772442 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#691757}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/04fc7733eda6..8aaeffd8edef git log 04fc7733eda6..8aaeffd8edef --date=short --no-merges --format='%ad %ae %s' 2019-08-29 tcwang@google.com afdo: Fix orderfile-generate-toolchain builder. Created with: gclient setdep -r src/third_party/chromite@8aaeffd8edef If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I6496ccc53c70f422334e448e3719b50ab92df5aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774932Reviewed-by:
-
Kevin Marshall authored
This is a reland of 830d60ac. Fixes a test linker error by adding a export directive. Adds some missing #includes. TBR=nasko@chromium.org TBR=jam@chromium.org Original change's description: > [fuchsia] Add support for loading embedder content via fuchsia-dir://. > > Defines a new scheme for loading resources from named embedder > Directories. Resources from these directories can be loaded using > the URL: > > fuchsia-dir://<directory-name>/<path>/<to>/<file>.html. > > * Browser tests added for testing URLLoaderFactory & URLLoader logic. > * Integration tests added to test ContextProvider changes. > > Bug: 991298 > Change-Id: I5875594d9fe5cc7f9006ccdecda78cc3bdf667b3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764335 > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691363} Bug: 991298 Change-Id: I1a74d7d3936bcc5666e3c5d814079838cac7afac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775805 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#691755}
-
Ryan Hamilton authored
to force the OS to pick an unused port and hence avoid flakiness in QUIC EndToEndTests. Bug: 997325 Change-Id: I1c6eecac8e599863ab60077f1692d209fe055dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776603 Commit-Queue: Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Auto-Submit: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#691754}
-
Angel Alvarez authored
Bug: 977713 Change-Id: I54b01d443cf8f4335569e9f741a648bfc3c5cff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769720Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Angel Alvarez <angelii@google.com> Cr-Commit-Position: refs/heads/master@{#691753}
-
Jeffrey Kardatzke authored
This fixes a bug in the uploader where it would post a task with a callback that had a raw pointer, and if it was during shutdown then the referenced object could be destructed before the call on said pointer was invoked. The simple part of the change is using a WeakPtr in that location instead of a raw pointer, so the callback will be skipped. However, the way the code worked was that it would read the pre-existing feedback report from disk to a string, then it would pass that into the callback which asynchronously generated a new feedback report in a new disk location and then it would delete the old feedback report file. However, if that callback is suppressed (which it would be in the case the new WeakPtr becomes invalidated) then we would end up deleting that feedback report from disk without sending it. So this code also changes things to not recreate the report on disk but instead reuses that existing file for the feedback report. Bug: 994846 Test: components_unittests pass and manually verified report upload Change-Id: Ib64ce1abbfea23e94e45387fa5a296817bf19a30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766766 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#691752}
-
Matt Menke authored
https://chromium-review.googlesource.com/c/chromium/src/+/1758546 is the fix for the bug itself. Bug: 994537 Change-Id: I7850325a19fd41e8b08040a69201df9251a78690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758717 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Antonio Gomes authored
... where ever possible. Note that some instances of std::vector still remain, because they are from method signatures' that override //third_party/webrtc APIs, or call out to //media APIs. BUG=787254 R=guidou@chromium.org Change-Id: I358bf8b23109612e3e3f604029c4ad83b06c0297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775873Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#691750}
-
Josh Nohle authored
TimeTicks are better suited for measuring time durations, specifically for tracking the amount of time a task runs. See comments at the top of https://cs.chromium.org/chromium/src/base/time/time.h. Bug: 899080, 933656 Change-Id: I9892e1690b194b9c91ea091a895555a88a45173a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775209 Commit-Queue: Josh Nohle <nohle@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
-
Vasiliy Telezhnikov authored
This CL enables GL_APPLE_sync for Skia when we force it using ES2.0 on ES3.0 context. Bug: 987286 Change-Id: If66d625a548ea486dbb4f376d91a55990d6760e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774931Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#691748}
-
Avery Musbach authored
Change-Id: Icad584da8b83f653695c22c5417de67c4e0301b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772425Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#691747}
-
chrome://proximity-authJosh Nohle authored
We fix the closure compiler errors on the page. Bug: 993373 Change-Id: If2b884ddb55efa27fd2c2c1c764fe1c6dda80dcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752246 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Antonio Gomes authored
... torward its WTF counterparts. BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I207a37af8451dd9705c9834c9649e062de68a487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775866 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Henrique Nakashima authored
Change-Id: I18976200d45536fc91706a1beaad0c3b4dade11b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775440Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#691744}
-
Nico Weber authored
Bug: 961769 Change-Id: Iac5fa643cd60ca8308dd050b7a7f58677f3d824b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776224 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
-
Ken Rockot authored
This moves the Resource Coordinator Service off of Service Manager APIs in favor of direct Mojo interface usage. A public browser API is exposed to give content clients access to the service connection. Bug: 977637 Change-Id: I898228ad49e3be405e0bb746d00c23d057658680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769102 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#691742}
-
Eric Foo authored
This is CL is generated by a script. Data is pulled from review conducted in Q2 2019. See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: Ic56ae0f036156dc160eb72da75b1003585daaca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699958Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#691741}
-
David Black authored
Per UX request, we shouldn't show proactive suggestions during the same login session if we've already shown them to the user. Duplicates are defined as having the same content description. Note that this has been implemented as a FeatureParam to give us a lever to disable this behavior if needed. Bug: b:139199754 Change-Id: I39e78529159ffd697383b98b23b4986f0d3a10ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774968Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#691740}
-
Vasiliy Telezhnikov authored
This CL fixes potential inconsistency between backend format we used to create promise image and one in fallback image in case we'll need one. This causes internal checks in Skia to fail. Bug: 998876 Change-Id: I5d7e25472c392c42b5b9f766ca525e965d0f4a4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776206 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
-
Will Cassella authored
This CL performs some cleanup to the VRServiceImpl class. 1) Removed 'IsAnotherHostPresenting()' declaration, since that function was never actually defined anywhere. 2) It inlines 'SetInFocusedFrame', since there was only a single call to it, and it makes the code somewhat easier to follow. 3) Moved the check on 'initialization_complete_' inside of 'RequestSession' to the top of the function in order to be more consistent with other functions in this class. 4) Removed null checks for 'render_frame_host_', because it's not allowed to be null. Change-Id: Ice0433923b747a3fda3e5e0178af2260b8b14d07 Bug: 846392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764549 Commit-Queue: Will Cassella <cassew@google.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#691738}
-
Martin Kreichgauer authored
This removes a giant switch on FidoReturnCode that's better handled higher up the stack. Also resolve a stale TODO while we're at it. Bug: 876109 Change-Id: I84bd8aa0a0c73e0a59dad7a673f041ded6019e4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764760Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Cr-Commit-Position: refs/heads/master@{#691737}
-
Nicolás Peña Moreno authored
This CL adds a test for poster image of video. It also adds a helper script with a checkImage() helper which is used in the tests where LCP entry with image is expected. The last parameter is an options array which is used to specify different expected behaviors. Bug: 994414 Change-Id: If0d085aa4569d2ce2d116734819c18028700ad8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764416Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#691736}
-
Etienne Bergeron authored
Add arguments from ScopedThreadMayLoadLibraryOnBackgroundThread to the tracing whitelist. ScopedThreadMayLoadLibraryOnBackgroundThread:: ScopedThreadMayLoadLibraryOnBackgroundThread(const Location& from_here) { TRACE_EVENT_BEGIN2("base", "ScopedThreadMayLoadLibraryOnBackgroundThread", "file_name", from_here.file_name(), "function_name", from_here.function_name()); [...] } R=oysteine@chromium.org Bug: 973868 Change-Id: If6bfa7c224a4c69c9d004526c773ad0d69534ea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773702Reviewed-by:oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#691735}
-
Peter Boström authored
Makes sure BrowserActionsContainer isn't being used anymore. Note that there are layout problems and that the entire container doesn't render. The change is under a flag though so submitting it won't break users but debugging the layout problems can be done separately. Bug: chromium:995452, chromium:985834 Change-Id: I4c3c71f7afa7705bcc8da96631dccf3973c985b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740687 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#691734}
-
chrome://local-staterbpotter authored
This is the first WebUI page leveraging native Javascript modules, used as a proof of concept for other WebUI pages to follow. Type-checking should also work ninja -C out/<out>/ chrome/browser/resources/local_state:closure_compile Bug: 915053 Change-Id: I274f02c5f95e395131318ece0172750c9d815139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1414153 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#691733}
-
Erik Chen authored
Bug: 995981 Change-Id: I1737d9866fb616666e6984825e4a389c169a2a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775057 Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
-
vmpstr authored
This patch adds the CSS content-size property along with the parsing code. This does not add any behavior changes based on the existence of these properties. R=chrishtr@chromium.org, futhark@chromium.org Bug: 991096 Change-Id: I853caab577176abf8a566f2694091800c68b6184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772285 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#691731}
-
Monica Basta authored
Set the ids for the listed accounts retrieved from |prefs::kGaiaCookieLastListAccountsData| on startup as they are not set in |gaia::ParseListAccountsData| and are empty. Bug: 990286 Change-Id: I57d28ce8eff3f209c9b4fc82f0bf22e78545a7bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760950 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#691730}
-
Erik Chen authored
The redirect through MainFrameWidget was incorrect -- size is a WebViewImpl property and should be directly set. Bug: 995981 Change-Id: Ic57d7f890fefc4220de02d06d5b883ab9bb64398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774017Reviewed-by:
-
