- 08 Aug, 2019 40 commits
-
-
Raphael Kubo da Costa authored
kRotationDOMMatrix has not been used since commit 7e8c0421 ("[sensors] Fix orientation sensor layout test"). Change-Id: I2c85083df36e778acc0512bb8212a18f564334d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742132 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#685256}
-
Antonio Gomes authored
This is a follow up of [1], where these files were Onion soup'ed. [1] crrev.com/c/1731644 BUG=923394 R=guidou@chromium.org Change-Id: Ia0138ca8e0b3ed26c5614fd0d2ca2367bc8be266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744047 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#685255}
-
Scott Little authored
This reverts commit 0d6bba53. Reason for revert: Broke webkit_layout_tests on WebKit Linux Leak bot: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/2935 Original change's description: > Fix sending scrollend on main thread snap > > This CL sends scrollend event if GSE is being > handled on the main thread after the snap (if > the snap has started after GSE). It also takes > care of sending scrollend event for snap after > fling. > > Bug: 907601 > Change-Id: I21aba5d098b25ddc765d78a7792ec8a2fb7987cb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743253 > Reviewed-by: David Bokan <bokan@chromium.org> > Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#685217} TBR=bokan@chromium.org,nzolghadr@chromium.org Change-Id: Ib7901d4284565f8cd636e1e4064163750bf08d4e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 907601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744517Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#685254}
-
Matthew Jones authored
This reverts commit a5cf7b8f. Reason for revert: Breaking Android WebView L bot/tests: https://ci.chromium.org/p/chromium/builders/ci/Android%20WebView%20L%20%28dbg%29/8779#overview-tab java.lang.AssertionError: Android WebView is missing the following declared Blink interfaces: interface OffscreenCanvasRenderingContext2D interface OffscreenCanvas : EventTarget interface HTMLCanvasElement : HTMLElement.method transferControlToOffscreen . Interfaces which are intentionally not exposed in WebView need to be added to not-webview-exposed.txt Original change's description: > Disable viz-dependent features on WebView > > This adds a flag to disable: > - window.OffscreenCanvas > - Context2DCreation.desynchronize. > - HTMLCanvasElement.transferControlToOffscreen > > Bug: 940953 > Change-Id: If774e41adbaa6bef94a058f783225b27e5d0669a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736804 > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Commit-Queue: Fernando Serboncini <fserb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#685170} TBR=boliu@chromium.org,chrishtr@chromium.org,alexmos@chromium.org,fserb@chromium.org,wfh@chromium.org Change-Id: Ie8105469766f1182c9f6d44c263bc180e5067c2e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 940953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744516Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#685253}
-
Clark DuVall authored
This path is no longer used now that NavigationLoaderOnUI is default. Bug: 979264 Change-Id: Iacfd172d4f1eaa742f642b712279841995db4cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744285 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#685252}
-
Eric Willigers authored
WPT to verify the width and height properties do not inherit. https://drafts.csswg.org/css-sizing-3/#propdef-width Change-Id: Ib35db7d4d5b55a5bc1b56db38eff49ec0fb4c427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741785Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#685251}
-
Danyao Wang authored
This change was announced to developers in M76. This patch will ship it in M78. Spec: https://w3c.github.io/payment-request/#shipping-address-changed-algorithm Intent to ship and implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/69dw-4Myc_A Chrome Status entry: https://chromestatus.com/features/5653566570102784 Bug: 821771 Change-Id: Idedf89cc868e7b98ff00ef649d898458c3edbe49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741296Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#685250}
-
James Cook authored
Before this change, base/debug/debugger.h was transitively included by 21,000 .cc files in the chrome build target. After this change it is included 24 times. Notes at go/chrome-transitive-includes TBR=sky@chromium.org Bug: none Change-Id: I1bcfa6e5c882cdd33b04d241b3038ef37ccc5250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742728Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#685249}
-
Avery Musbach authored
1. StartTabletActiveRightSnapPreviousLeftSnap is supposed to test with the right snapped window active (according to both the name and the comment), but actually tests with the left snapped window active. The present CL makes it test what it is supposed to test. 2. Among the tests with an active window and a previous window, some make it totally clear by activating both windows one after the other, while others just activate one window and assume that the other one will be previous. The present CL works out this inconsistency (at least for the tests that are the focus of my attention at the moment). 3. The comment on StartTabletActiveLeftSnapPreviousLeftSnap has some text left over from before [1], and currently does not even make sense. The present CL removes the offending text. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1535172 Change-Id: I086612a9cc180dd5092cd3c8794ccc29ee8b5a49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738633Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#685248}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome BUG=762641 TBR=wutao@google.com Change-Id: Ia862df593cfa4da52c102af7ce43e5496fb2f7ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744006Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#685247}
-
rbpotter authored
- Add a prefix replacement for chrome://resources, since this is needed across various Web UI pages - Always add Polymer 3 arguments to closure_flags, even if they are defined by the invoker. This allows Polymer 3 pages to set additional prefixes without having to also re-add the polymer 3 closure arguments. Bug: 965770 Change-Id: Id377a4c454862794ef4330e148615d987bc19030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742445Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#685246}
-
Nick Diego Yamane authored
The main user of GLib MessagePump implementation is Aura/X11, while Ozone-based ports use mainly libevent version, which exposes WatchFileDescriptor API that is used by higher level components through MessageLoop[Current]For{UI,IO} interfaces. Currently, there's no such API in MessagePumpGlib. The motivation here is to make MessageLoopCurrent API usage transparent, regardless which message pump is used in UI thread. This benefits X11 migration to Ozone on Linux desktop, which (just like Aura/X11) must integrate with Gtk, so GLib-based loop in browser's main thread is a natural path. So, this CL implements the aforementioned API in GLib MessageLoop following the same design, assumptions and overall structure as its original libevent-based version. As a follow-up, https://crrev.com/c/1730972 refactors code using MessagePumpLibevent::{FdWatchController,FdWatcher} directly, replacing them by MessageLoopCurrent*ForUI counterparts as well as refactoring X11EventSourceLibevent (which Implementation has been used as reference for this CL) in the same direction, so in the end it has no libevent specific code and the build-time glib/libevent switch (use_glib gn var) is possible. Bug: 988094, 789065 Test: base_unittests (MessagePumpGLibFdWatchTest.*) Change-Id: I843ab924d18c08b6384e0716bc36c4f5f8482fa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731031 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#685245}
-
Dominic Battre authored
This CL introduces the logging for form and field signature hashes as they exist in UKMs to simplify detecting a specific form and field. R=kolos@chromium.org Bug: 928595 Change-Id: I5a5f3a9311896e8d9ec9b46d3862e0182dbb5aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733546Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Auto-Submit: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#685244}
-
Anton Bikineev authored
Bug: 991989 Change-Id: Ib1e4102664a9be9e110199e386c31aaae7271702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743732Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#685243}
-
Nate Fischer authored
Follow-up to https://crrev.com/c/1733793. We can remove the #include statements as well. Bug: 990490 Test: N/A Change-Id: I4703be8307d2bb744179eec8a0e110ba5e292fd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743061 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#685242}
-
Scott Little authored
This reverts commit 3ce9f4d8. Reason for revert: Broke browser_tests on win-asan bot. https://ci.chromium.org/p/chromium/builders/ci/win-asan/6832 Original change's description: > Make ResourcePrefetchPredictor use correct NetworkIsolationKeys. > > ResourcePrefetchPredictor was always using the origin of the initial > page being navigated to in constructing the NetworkIsolationKey. > With this CL, it uses the origin it expects the page to redirect to > instead. > > Bug: 987735 > Change-Id: Ic66c33bb5f99a9a00485ffe46c70e0947e0e430b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730782 > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Egor Pasko <pasko@chromium.org> > Commit-Queue: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#685173} TBR=pasko@chromium.org,mmenke@chromium.org,tbansal@chromium.org Change-Id: I7af5589722eafc8a0157c639acb357e8d28ae0bf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 987735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744512Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#685241}
-
Ioana Pandele authored
Bug: 986322 Change-Id: I282d1f1fd87ee03394857a21c612ba8d1be987b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736361Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#685240}
-
Prashant Malani authored
This reverts commit c3311e2b. Reason for revert: Chromium OS can continue to use the std::deque version, since it checks out this directory at a specific commit. Chromium can revert to using the circular_deque variant. This means that there will be a transitional discrepancy between MidiMessageQueue implementations in Chromium and Chromium OS, but those should be resolved once libchrome in Chromium OS gets uprev-ed. BUG=chromium:787643 TEST=None Original change's description: > midi: Use std::deque for MidiMessageQueue > > For the purposes of this class, the semantics of circular_deque and > std::deque are the same. Switching to std::deque will make this class > easier to re-use outside of Chrome, by reducing its dependency on > src/base/containers. > > BUG=chromium:701005 > TEST=MIDI works on Chrome. > > Change-Id: Iae83c69ef85682fbde75e6078cd5eb262b9f4082 > Reviewed-on: https://chromium-review.googlesource.com/784010 > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#518599} TBR=toyoshim@chromium.org,pmalani@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:701005 Change-Id: Id061ff49297b1b40b3e0417ad3022e744a7c2fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743035Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Prashant Malani <pmalani@chromium.org> Cr-Commit-Position: refs/heads/master@{#685239}
-
Kyle Milka authored
This method was only used for reseting the background. Bug: None. Change-Id: I64b35e1832cf739324230d1b4e5460a18d83d0bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719831 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#685238}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I3fc53be382f582d7eb482058fb24a6b5b2afe485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744279Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685237}
-
Daniel Clark authored
An <input type='url'> should have LocalizedControlType of "url" per https://w3c.github.io/html-aam/#el-input-url Currently its LocalizedControlType is "edit". This change updates it to the correct value by adding an entry to BrowserAccessibility::GetLocalizedStringForRoleDescription(). Bug: 990386 Change-Id: I92cee38c5fb0b9c81229cb6070784271187f4154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733202Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#685236}
-
Lily Chen authored
Callers of this method seem to only care whether the effective SameSite is None, so just give them that. This is for prophylaxis of subtle bugs that may arise from GetEffectiveSameSite now possibly returning different values if called at different times. Bug: None Change-Id: If2c9cd38f2be41d039b144e1af6a043f799ab0da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743131Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#685235}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/efffd0a5fa22..940c2b500589 git log efffd0a5fa22..940c2b500589 --date=short --no-merges --format='%ad %ae %s' 2019-08-08 gustaf@webrtc.org AEC3: Reduce level of log messages 2019-08-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5744654b..498f5876 (685023:685149) 2019-08-08 tommi@webrtc.org Remove MediaTransport from Call. 2019-08-08 asapersson@webrtc.org Update test::CreateVideoStreams to use configured scale_resolution_down_by if set. 2019-08-08 oprypin@webrtc.org Delete shim of PRId64 et al. on Windows 2019-08-08 nisse@webrtc.org Change return type of of ReceiveStatistics::Create to unique_ptr. 2019-08-08 sprang@webrtc.org Remove unused fallbacks in PacedSender 2019-08-08 peah@webrtc.org Removing unused fallback variant for the reverb computation 2019-08-08 tommi@webrtc.org Call Call::GetStats() from the correct thread in ProbingEndToEndTest. 2019-08-08 tommi@webrtc.org Call Call::GetStats() from the correct thread in VideoSendStreamTest. Created with: gclient setdep -r src/third_party/webrtc@940c2b500589 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:none Change-Id: I19e1508a1421f78de872effd98f1a13c8456331e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744275Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685234}
-
Guido Urdaneta authored
This is to be followed by a move of this file to Blink. Bug: 704136 Change-Id: Ib75c46e895b585cc6da84d67c5d9388551df0d8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744426Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#685233}
-
Shakti Sahu authored
This crash could possibly happen since we are clearing out the downloads in OnDownloadRemoved rather than OnDownloadDestroyed. The destroyed is a super set and is safer to use. Bug:991621 Change-Id: Id90e8b259b36a3886ff16cd321363e25c81a6c06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742530Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#685232}
-
Daniel Rubery authored
This class will handle the interactions with FCM, routing messages to the appropriate callback, and managing the lifetime of the InstanceID token. At the moment, the InstanceID token is created and never deleted, but in the future we may want to manage the lifetime of the token. Bug: 980784 Change-Id: I605affb03cd2e01eb258b15ebdc147b15a022a3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731542 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#685231}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d88a2079b485..fa26b6523911 Created with: gclient setdep -r src-internal@fa26b6523911 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I272225f8fb4e9ff13316a5376c3e432384dc02a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744273Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685230}
-
Philip Rogers authored
This reverts commit 88f1169d. Reason for revert: Was not the cause of a flaky test failure, see: https://crbug.com/990692#c7. Original change's description: > Revert "Paint non-fast scrollable regions for resize handles" > > This reverts commit 0c4a415f. > > Reason for revert: reverting to see if this is causing consistent failures on Linux MSan Tests, browser_tests, DevToolsSanityTest.TestDeviceEmulation (timeout) > > Original change's description: > > Paint non-fast scrollable regions for resize handles > > > > Non-fast scrollable regions are regions on a cc::Layer where the > > compositor should not handle scroll events. These are primarily for non- > > composited scrollers but are also used for resize handles and plugins. > > This patch paints non-fast scrollable regions for resize handles. > > > > The interesting code change is in ScrollableAreaPainter::PaintResizer > > where we now emit a ScrollHitTestDisplayItem for resizers. This fixes > > a class of bugs such as non-fast regions being on the wrong cc::Layer > > (https://crbug.com/968691) and having the wrong offset > > (https://crbug.com/989038). > > > > Design doc: > > https://docs.google.com/document/d/1IyYJ6bVF7KZq96b_s5NrAzGtVoBXn_LQnya9y4yT3iw/view#heading=h.rrlzkp4v3huj > > > > Bug: 864567, 968691, 989038 > > Change-Id: I8193077279617418433306912d712c31d99149f3 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730521 > > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > > Commit-Queue: Philip Rogers <pdr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#683670} > > TBR=pdr@chromium.org,chrishtr@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 864567, 968691, 989038, 990692 > Change-Id: I1986b58522d7658109155e811419a6d3ae1d2dbd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736702 > Reviewed-by: Chris Sharp <csharp@chromium.org> > Commit-Queue: Chris Sharp <csharp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683991} TBR=pdr@chromium.org,csharp@chromium.org,chrishtr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 864567, 968691, 989038, 990692 Change-Id: I40cfb1cb50e2487d6f0dac74fd20292dcfb8a786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744277Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#685229}
-
Sasha McIntosh authored
Bug: 988538 Change-Id: I2d15cd3634332d39538f7f9d084db62bc9db50a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731758Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Cr-Commit-Position: refs/heads/master@{#685228}
-
Andrew Luo authored
Change-Id: I932940a233e7e92c6474d4d3d85c69e92eae8eb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739158Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#685227}
-
Ben Pastene authored
This should make the builders more resilient to LKGM updates when no SDK is available at the version for one of the multiple boards we use. Bug: 921048 Change-Id: I6084e7238c4b57d182ea945417f93a7e6ca45106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739112Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#685226}
-
Nate Fischer authored
No change to logic. This removes obsolete references to kNetworkService now that this feature is enabled by default. This cleans up the corresponding include macros as well. Bug: 989104 Test: run_android_webview_unittests (tests still pass) Change-Id: Icf4f2d5821c90f95fc1cd7f3619355f8ff8c4ba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737821 Commit-Queue: Richard Coles <torne@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#685225}
-
Kyle Milka authored
Add logging for daily refresh toggle/enabled to the RP. Bug: 984752 Change-Id: I4c401a92b9ff41f769d1f95b4cae6deec23dfae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729065 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#685224}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a062e707..0fe515a8 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8d455d2da7ea252114a3ea2d2f77b5aab8945c66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744049Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685223}
-
Ovidio Henriquez authored
This change adds a menu for the Native File System write permission in chrome://settings/content. This permission controls whether sites are allowed to ask the user for permission to save to the original file that the user previously selected using the Native File System API. Bug: 982904 Change-Id: I97bdedaed31cfff6c54b6c2a89efdb374f0b2951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696390 Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#685222}
-
Scott Little authored
This CL turns on by default support for sites to lazily load <img> and <iframe> elements by specifying "loading=lazy". This CL also changes automatic lazy loading to by default get restricted to lite mode users only, to more closely match what will be launched, and updates the default distance-from-viewport loading threshold for "Unknown" effective connection types to match the "4G" values, since "4G" is the most common effective connection type. Bug: 990967 Change-Id: I5ea3a5f03acc38b8d3475a847c14075e78cc1d2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740307Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#685221}
-
Chris Mumford authored
Bug: None Change-Id: Iad4bf594dbc90c9e246d43fe9729e4b56fed9679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740128Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#685220}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/07dff948a085..b307d657e8b7 git log 07dff948a085..b307d657e8b7 --date=short --no-merges --format='%ad %ae %s' 2019-08-08 treehugger-gerrit@google.com Merge "Use noice-json-rpc for the extension to communicate with devtools" Created with: gclient setdep -r src/third_party/perfetto@b307d657e8b7 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I3172b428cecdb8b3029bfe59045dafa792bf12a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744276Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#685219}
-
Eric Willigers authored
The CSS Inline Layout spec has been updated to show the initial value of dominant-baseline as 'auto', matching SVG 1.1 and browsers. https://drafts.csswg.org/css-inline/#dominant-baseline-property https://github.com/w3c/csswg-drafts/issues/4115 Change-Id: Ib2dbdf91a9535c4d149aa773b61302c36c360305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741445 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#685218}
-
Navid Zolghadr authored
This CL sends scrollend event if GSE is being handled on the main thread after the snap (if the snap has started after GSE). It also takes care of sending scrollend event for snap after fling. Bug: 907601 Change-Id: I21aba5d098b25ddc765d78a7792ec8a2fb7987cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743253Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#685217}
-