- 15 Oct, 2019 40 commits
-
-
Morten Stenshorne authored
Collapse block margins between sibling spanners and add inline margins, including auto margins. We now position spanners correctly. Bug: 829028 Change-Id: I07b5c1af92852d385cf558db6c20de61e88d87d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860419 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#706114}
-
Manu Cornet authored
* Rename the "NotifyXYZ" methods into "OnXYZ" which is more idiomatic for callbacks, and makes things more consistent across the app list classes (instead of having both, depending on the class). * Change the notion of "target visibility changed" to "visibility will change". * Remove "AppList" from within the method names when "AppList" is already part of the class name (i.e. except for observers outside of app_list). This is purely a name change and has no user-visible effects. Change-Id: I37dfe742d50e516bd70d78b037b867486230a8eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861018Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#706113}
-
Hector Carmona authored
Bug: 876601 Change-Id: I49c8f9730adf76a6612cb108785145465c3b640f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861112 Auto-Submit: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706112}
-
Robert Liao authored
There was only one caller in system_fonts_win.cc and it is better served with a direct call to SystemParametersInfo. BUG= Change-Id: Icd3f4e6e27d50d8569e602cb0eeace2c6dd530a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861109 Auto-Submit: Robert Liao <robliao@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#706111}
-
Hiroshige Hayashizaki authored
Because kEvaluateScriptMovedBetweenElementDocuments UMA has been 0 for a week on canary, it seems also safe to stop executing such scripts. We still keep the use counter to confirm that such cases are really rare on stable channel. Bug: 721914 Change-Id: I2b4963321f6e81284b9baac22ee5d5f9e3df7484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854643Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#706110}
-
Daniel McArdle authored
Now we only use valid UTF8 strings. Also, the session_id string must begin with "{", end with "}", and be nonempty, according to DCHECKs in MakeProtocolRequest. Bug: 1014625 Change-Id: If30c9b21f63c7cab7a01f456ec0593971ef1bc37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863669Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#706109}
-
Maks Orlovich authored
They will need to be marked explicitly and secure, so adjust some tests to be over SSL and mark those cookies appropriately Bug: 1006816 Change-Id: I6da53ea64a7c03530335913fadb9099992e8ca33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863389Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#706108}
-
Sergey Poromov authored
SCHEMA_ALLOW_INVALID strategy is used only for ManagedBookmarks policy and is considered for deprecation. Adding UMA metrics to check how ofter this strategy is useful in reality Bug: 969706 Change-Id: I0dee14588d48ce30e83cbd14cacc0375e3fa1a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841031Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Auto-Submit: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#706107}
-
Clark DuVall authored
Due to some recent changes in how the fragment works, the browser tests were crashing on Android. Change-Id: I5302c63f1f02eccdac3d5e95fe711a9d24048cb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863592Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#706106}
-
John Lee authored
- Mostly only tests CSS properties that have an impact on visibility, such as opacity, width, and display, or can be tested using CSS vars - Fixes an attribute that should have been private Bug: 989131 Change-Id: Icdf6e830d5a95cf8feeca63cd0b755ecc1ad64d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857023 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#706105}
-
Elly Fong-Jones authored
This change removes overrides from: * DesktopMediaPickerDialogView, which used static strings * DownloadDangerPromptViews, which used static strings conditional on a constructor parameter * HungRendererDialogView, which computes its strings but never updates them after creation * PermissionsBubbleDialogDelegateView, which used static strings conditional on GetDialogButtons(), which itself returned a constant * PasswordReuseModalWarningDialog, which used strings computed from a member that never changes after construction * TabModalConfirmDialogViews, which gets its strings from a delegate but never updates them * UninstallView, which used static strings This change also removes a couple of redundant overrides of GetDialogButtons that replicated the default, and const-ifies a couple of members where the const-ness helps reason about code correctness. Bug: 1011446 Change-Id: I6f89e975895c16a492cc0becad98f43a4f96e6c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862119 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#706104}
-
Martin Kreichgauer authored
When enrolling a fingerprint template on a security key through the settings UI, the device will generally choose some default value for template's human-readable name label. This change adds an extra step to let the user optionally modify the label after enrolling the template completed. Bug: 974046 Change-Id: If85f3db63cbb9c10b7870fcd75fb79db6b6127b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848477Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#706103}
-
Collin Baker authored
This is the first C++-side browser test for the thumbstrip. Bug: 997887 Change-Id: Ic155adc5c2d519cc383438326c7ffb6fe21caf1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861110 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#706102}
-
Hesen Zhang authored
- Create client side code. - Add client type. Bug: 1013685 Change-Id: Ie915b1e697b3a7e40a42079a629301918dfd5966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856884Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Auto-Submit: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#706101}
-
Tommy Li authored
This CL is a cleanup to pave the way for more work to polish the on-focus suggestions UI. Bug: 1013287, 996516, 963173 Change-Id: Iec5b40451b00baf440e61a7881c8168a29eedde0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862715 Auto-Submit: Tommy Li <tommycli@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#706100}
-
Wenbin Zhang authored
All builds on android-nexus5x-perf are generating "infra failure" due to the fact that six devices are missing from Swarming. We're reducing the expected shard size for this specific builder in this case, as discussed in: https://bugs.chromium.org/p/chromium/issues/detail?id=1014120#c17 Bug: chromium:1014120 Change-Id: I87bf6d66523d0299d39a9d38de69209a2c82cf5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862995 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#706099}
-
Manu Cornet authored
(Weidong left the team a while ago.) Change-Id: Ifc9f1532f188d832e77b0b81a0292c2b435d3691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859912Reviewed-by:
Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#706098}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/b8d86733e9d9..412547ad4b75 $ git log b8d86733e..412547ad4 --date=short --no-merges --format='%ad %ae %s' 2019-10-09 angiebird Refactor calc_frame_boost() 2019-10-09 angiebird Add first_pass_info in TWO_PASS 2019-10-09 angiebird Refactor get_prediction_decay_rate() 2019-10-09 angiebird Replace cpi by frame_info in get_sr_decay_rate() 2019-10-09 angiebird Change the interface of calc_frame_boost 2019-10-09 angiebird Use frame_info in calculate_active_area 2019-10-09 angiebird Add FRAME_INFO into VP9_COMP 2019-10-08 angiebird Add detect_flash_from_frame_stats() 2019-10-04 jianj vp9: fix non bitexact when reuse_inter_pred is 0. 2019-10-03 hienho vp9/common/vp9_reconinter: fix int sanitizer warnings 2019-10-01 hienho vpx_dsp/quantize: fix int sanitizer warnings 2019-10-01 hienho vp9/decoder/vp9_detokenize: fix int sanitizer warnings 2019-09-28 jzern namespace ARCH_* defines 2019-09-27 jianj Fix python3 format issue 2019-09-20 marpan vp9-rtc: Fix to speed 4 for real-time mode 2019-09-19 angiebird Remove USE_PQSORT and CHANGE_MV_SEARCH_ORDER Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: Idb64446d8484a2ebacc8a295b1cb3d91219a5bb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857584Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#706097}
-
Dave Tapuska authored
If a Webview app delays setting the allowUniversalAccessFromFileURLs it is possible that further accesses will fail because they are different agent clusters. Grant corss agent cluster access. BUG=1006684 Change-Id: Ic19b5ae26ffc03747f5d352f824a00e2deda776a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857301Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#706096}
-
Krishna Govind authored
This reverts commit 7294a953. Reason for revert: crashes bug 1013972 Original change's description: > Rolling R8 1.6.28 -> 1.7.11 > > Change-Id: I4a431f966ab297e7c81b7abe8e29ed302b984586 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849181 > Commit-Queue: Sam Maier <smaier@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705353} TBR=agrieve@chromium.org,smaier@chromium.org Binary-Size: revert R8 # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I9a0cc7ad69dec3a20308b208aa7ec36e6e6927dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860126 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#706095}
-
Koji Ishii authored
This patch fixes hit-testing image list markers. The previous fix for hit-testing list markers (r682470 crrev.com/c/1726571) didn't cover image list markers, and unfortunately the test did not cover the case. Bug: 1002417 Change-Id: Ieefcfa91240570a3d59265cf7e75c802396da6d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862873Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#706094}
-
dalyk authored
This change will allow URLRequests to bypass DoH during hostname resolution. Change-Id: Ic5a5346d57bf8fc639a82ff8b284f4e11893745d Bug: 1012268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842562 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#706093}
-
Tommy Li authored
The API currently has an unused pointer argument that's used as a bool. It just makes for a confusing read, and I'm trying to build on top of it to fix some polish issues for on-focus suggestions (ZeroSuggest). This CL turns that pointer-as-boolean argument into an explicit bool argument that's properly labeled. No behavior changes. Bug: 996516, 963173 Change-Id: I02767d26849dae035feeb54173ebee2fbc66ea03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862256 Auto-Submit: Tommy Li <tommycli@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#706092}
-
Fredrik Söderquist authored
The font code (FontMetrics::AscentDescentWithHacks specifically) will (may) mangle (round) the ascent and descent, meaning that for small font-sizes all precision is lost. Using our (potentially) "rescaled" Font for computing the baseline for text gives us a chance to recover some of the precision lost in the rounding process. Bug: 1013859 Change-Id: Ieaadaf558315b8a082331ac76deeb52bcf3b11c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859961Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#706091}
-
Robert Liao authored
BUG=1014283 Change-Id: I9d553dceab196d7a1c9d254ad9e5d18da69cd13c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860044 Commit-Queue: Min Qin <qinmin@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706090}
-
Alfonso Garza authored
Crash was caused as the bridge's dealloc was calling OnDimissed on the controller, which is meant to notify that the user explicitly dimissed the dialog, instead of OnConfirmNameDialogCLosed. This in turn caused the controller to retain the bridge even thought it had already been deleted. Change-Id: If47970e04aacf4ce1d628b5663f60835a7277378 Bug: 1013292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860981Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Alfonso Garza <alfonsogarza@google.com> Auto-Submit: Alfonso Garza <alfonsogarza@google.com> Cr-Commit-Position: refs/heads/master@{#706089}
-
Robbie McElrath authored
This removes the stub implementation of WillCreateURLLoaderFactory in unit_tests, which was needed when interceptors ran on the IO thread. Bug: 966633 Change-Id: I2305606c0f178e98661ca70eb1696ce5200ab445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860885Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#706088}
-
Jonah Ryan-Davis authored
Because of a finch trial of DefaultPassthroughCommandDecoder, a few bots which were relying on the default to test the validating command decoder ended up switching to passthrough. This CL reconfigures to be more explicit TBR=kbr@chromium.org Bug: 1014368 Bug: 1014370 Change-Id: I5ca6c380755d529ce506e86ececbf070f472bd33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863152 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#706087}
-
Clark DuVall authored
This fixes resources loading, and allows WebLayer to work with the standalone WebView APK, which previously would crash with a Resources$NotFoundException exception. Adds a run_weblayer_shell_webview build target for testing with standalone WebView. Change-Id: If1063efdfbf462ccf36bc54f796d3b934a456274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854204Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#706086}
-
ckitagawa authored
This CL implements a basic hit testing system for finding links associated with rects. An instance of the Hit Tester will exist for each frame to address stacking. This may return multiple links per query. In such cases, it is up to the caller to decide which link if any to resolve. Bug: 1012891 Change-Id: I772ebecae7a7403228e6c50cdc499c1ed7690fcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849209 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#706085}
-
Mikel Astiz authored
This removes complexity from the bridge to a struct with much simpler semantics, and allows future patches to compute specifics from NigoriState instances other than the authoritative copy owned by the bridge. Bug: 922900 Change-Id: I0dd60f316145700502e22a1dbc1460b3e1bcf703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862457 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#706084}
-
David Benjamin authored
In https://chromium-review.googlesource.com/c/chromium/src/+/1539153, I cleaned up some dead symbols but, in doing so, I left a stray "race:base::trace_event::" in the file with no trailing newline. That line and the suppression following it don't actually do anything useful as a result and apparently TSan bots have been fine, so remove them. Bug: 257396 Change-Id: Ic995eff58651c011edee0dd0586d9e598f155fe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681449 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#706083}
-
Istiaque Ahmed authored
If a worker stops right after it sends an extension event ack, decrementing ref count (FinishExternalRequest) can fail in the browser process. This happens if the browser process has already dropped knowledge about the worker. Ignore FinishExternalRequest's result in this case, after examining the worker's status in ProcessManager. This reduces flaky failures of ServiceWorkerTest.Update(Un)PackedExtension tests. Bug: 999027 Change-Id: Iad0287067eff0feab7cf64ff21768c204009969c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832491 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#706082}
-
Chris Harrelson authored
This reduces the snapping-related code paths in the referenced bug by about 4x. Bug: 504567 Change-Id: I4a48eef9935dbb9bfb75d7ab2a0b921f3f5b2c8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860403 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#706081}
-
Caleb Rouleau authored
This change https://chromium-review.googlesource.com/c/catapult/+/1839176 makes it so that expectations config is passed to story_filter.py using the project config (sometimes referred to as the "environment"). This change lays the groundwork for that future change. Until that change is committed, this is a no-op change. This change first requires this catapult-side change https://chromium-review.googlesource.com/c/catapult/+/1854882 to make sure that we don't pass an invalid argument to GetRunOptions(). Bug: 985103 Change-Id: Idd53aaf7f84e792b0d7a7d0db6b45ce0562fb5f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854794 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#706080}
-
Garrett Beaty authored
Setting default RBE_PROD backend in some of the builder functions means that any new builders added would use the RBE_PROD backend which might overwhelm the backend if it is triggered often. Instead, require all builders to be explicitly opted in to RBE_PROD backend. The functions for the goma FYI builders were left as-is since they incorporate the information about the backend in their names and its is reasonable that the goma team would be specifically concerned with the backend being set correctly to not accidentally add something using the wrong backend. Change-Id: Ia1ec7ec8d35232f02d503ecc4cec196f94a7f134 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862259Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#706079}
-
Olga Gerchikov authored
This CL changes how local time of composited worklet animations is updated on main thread: instead of polling local time on main thread, the local time is posted via animation events by the composited thread to the main thread. Design document: https://docs.google.com/document/d/1vUxaKBLDHQv9ACJUQJH4RXjuQTlWIsSiAFYkMrjccyc/edit?usp=sharing Changes made: - Expanded AnimationEvent to support worklet animation time update event type. - Reused existing mechanism of posting animation events to the main thread to support new event type. - Removed "peek" logic. - Enabled tests that previously failed. Bug: 943787 Change-Id: I2d285506739ea623e292927d21e54910fb7e24bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826872Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com> Cr-Commit-Position: refs/heads/master@{#706078}
-
George Zhang authored
Currently, nothing in the codebase exists to generate java heap dumps. By adding this, we write heap dumps to file that can be passed to c++ which can be later uploaded and analyzed. Bug: 1012072 Change-Id: I9381b998d3fc98d2efa7f226e3c0b0b25dd4f3ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839011 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#706077}
-
Livvie Lin authored
Bug: 1007497 Change-Id: I4498d39cabf4736a697294ad027082a53894a623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857166Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706076}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/260e87e6956a..4ccba5fc7b22 git log 260e87e6956a..4ccba5fc7b22 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 vapier@chromium.org partial_mock: AddCmdResult: switch to stdout/stderr arg names 2019-10-15 saklein@chromium.org portage_util: Add version validation to chromeos_version.sh call. Created with: gclient setdep -r src/third_party/chromite@4ccba5fc7b22 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I1cc7c13e645d5d594ad71afa2e00b68b027b6feb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862243Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706075}
-