- 24 Jan, 2020 1 commit
-
-
Xiaohui Chen authored
* Add a couple shelf layout tests to make sure when Assistant is invoked in tablet mode with/without apps, the hotseat state won't change. Bug: None Test: unit tests Change-Id: I7103fe9489f780cd441942801aa4d03b71825dbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013752 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#734728}
-
- 23 Jan, 2020 39 commits
-
-
Gabriel Charette authored
It should already have been but let's enforce this in preparation for it becoming a run-time check in [1] as a step towards API-as-a-destination rather than destination-as-a-trait in task APIs v3. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2014055 Bug: 1026641 Change-Id: Icf78830b7c0961324f650ea922ccb8a97e3a2910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015181 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#734727}
-
Dan Harrington authored
Note: this is a slightly modified reland of https://chromium-review.googlesource.com/c/chromium/src/+/1956275. The only difference is adding SuppressWarnings for Validators.java, which was prompted due a change in errorprone. - Restructure to match chrome/browser/java/res - Replace strings with references to existing .grd strings - I kept Piet resources separate, since piet may eventually be moved into a different library. - Move feed/library sources into chrome_java Strings changed: snackbar_fetch_no_new_suggestions -> ntp_suggestions_fetch_no_new_suggestions snackbar_fetch_failed -> ntp_suggestions_fetch_failed snackbar_default_action -> undo It looks like chromium's strings are translated to more languages, so this might provide better localization. Some of these strings are translated differently between feed and zine. TBR=dtrainor@chromium.org,wnwen@chromium.org,twellington@chromium.org,carlosk@chromium.org Change-Id: I2a14b0c4b4b60c7ab5b45ead0ec75b09233f4d99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017243Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#734726}
-
Hesen Zhang authored
- Move update notification service into one module. - Wrap up bridge as a class. - Inject bridge and config as components into serviceImpl. - TODO: Add test targets. - TODO: Fix some broken due to ownership change. Bug: 1013685 Change-Id: I1371176eb5249a048c9cc564a9056bfa747e64fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994177Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#734725}
-
Ted Meyer authored
MediaLogRecord::Type contains multiple unrelated values, including log levels, play/paused events, and a selection of video properties. This CL breaks them out into categories and adds another enum for each category with all the related fields there. It also adds a new method to MediaLog for each entry in MediaLogRecord::Type. There are now: SetProperty<MediaLogProperty>(...); AddEvent<MediaLogEvent>(...); NotifyError(...); AddMessage(MediaLogMessageLevel, std::string); which create and add records. Bug: 794255 Change-Id: I3f1f93d595d66d178b3b309f5696085015f4acc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006249 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#734724}
-
Scott Violet authored
This patch does two things: . Replaces TestLauncher::AdjustChildProcessCommandLine with GetUserDataDirectoryCommandLineSwitch and moves logic of ensuring present to content. . Makes sure the CommandLine has GetUserDataDirectoryCommandLineSwitch() with a temp directory. This is necessary for the --single-process* case, which before this patch did not create a temporary directory. BUG=none TEST=none Change-Id: I9ff14f0a3ad013761b42b144727a41369b05e4a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018102Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#734723}
-
Dale Curtis authored
May be fixed, so lets find out. TBR=kbr Bug: 1027518 Change-Id: Id9aca0c1d60f0daf7b270a739f9a01628d9bcbcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017883Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#734722}
-
Ahmed Mehfooz authored
The parameter causes UI elements without their own layers to be not visible on these bubbles. Change-Id: Ie6a13cb30151fe827623bc888d67f517cb2f0477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017910Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#734721}
-
Zhiheng Li authored
See: //chromium/src/chromecast/browser/cast_content_window.h Bug: b/147646410 Test: none Change-Id: Iaee645a6b88330a4416cc87112aafb4a7bf2fe9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015571Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Zhiheng(Vincent) Li <vincentli@google.com> Auto-Submit: Zhiheng(Vincent) Li <vincentli@google.com> Cr-Commit-Position: refs/heads/master@{#734720}
-
Maksym Onufriienko authored
Example of full_results.json "HistoryUITestCase/testSwipeDownDismissWhileSearching": {"expected": "PASS", "is_flaky": true, "actual": "FAIL PASS"} https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=b152f5f5e3202ee123f81c8b7d912a850cc1ec48&as=full_results.json Bug: 1032141 Change-Id: I24e7401d5f3a4e3a196dfbadcbd9953bfab39484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013759 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#734719}
-
James Cook authored
The C++ OSSyncHandler is only instantiated when the SplitSettingsSync flag is set. However, the new os-sync-controls HTML/JS can be instantiated by a search event when the flag is not set. This leads to a DCHECK for an unhandled message. Only instantiate the HTML if the flag is set. Do the same for the old UI. Fixed: 1044369 Change-Id: If09060e9916405afc524e669f235166cedf8c4eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017986Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#734718}
-
Nate Fischer authored
No change to logic, only docs. This clarifies WebView's flag support. Namely, it explains that we don't "support" all flags, but that we support toggling them (and the behavior itself may or may not be stable). This also links to the layer diagram. This clarifies some of the language around "features," defining "base::Feature" and updating some references to use either "base::Feature" or "Feature" rather than "feature" (which could be mistaken for a general enhancement to the product). Bug: 918221 Test: tools/md_browser/md_browser.py Test: Upload to gerrit > open file > click "gitiles" Change-Id: I570eeed005b8671a003028e0c45b8ac03d37fc71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018151 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#734717}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e386b83c7d0a..a14e17a13c81 git log e386b83c7d0a..a14e17a13c81 --date=short --first-parent --format='%ad %ae %s' 2020-01-23 tsepez@chromium.org Introduce new CXFA_FFWidget::As*() methods. 2020-01-23 thestig@chromium.org Rename |CPDF_TextPage::m_CharIndex| to |m_CharIndices|. 2020-01-23 thestig@chromium.org Simplify operations involving |CPDF_TextPage::m_CharIndex|. Created with: gclient setdep -r src/third_party/pdfium@a14e17a13c81 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I4222d30ba857880f98dc37e82279d062689ea7d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018029Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734716}
-
Nina Satragno authored
Add the "webauthn:virtualAuthenticators" capability. This capability is supported (i.e. returns true) only on desktop. See https://w3c.github.io/webauthn/#sctn-automation-webdriver-capability Bug: chromedriver:3321 Change-Id: Id05b641325e825beca65987b7b66f651325a16a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017183 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#734715}
-
Miyoung Shin authored
This CL converts ApplicationMediaCapabilities mojom interface client in chromecast to use BrowserInterfaceBroker. Bug: 936482 Change-Id: I711d4312316d96195f980ac0cc7b3dc1ea786b4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957622Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#734714}
-
Theodore Dubois authored
The order of priority is: allow > allowAllRequests > block > upgradeScheme > redirect. This is implemented by including the action in the lower 8 bits of the priority that is persisted in the flatbuffer ruleset. To make room for this, the peristed priority is expanded from uint to uint64. Bug: 1026733 Change-Id: I3207175bd3a92a2bd945ca428f493d1af3252739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952284 Commit-Queue: Theodore Dubois <tbodt@google.com> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#734713}
-
Matthew Mourgos authored
Bug: 1042474 Change-Id: I6b2f2fa280b6739819fc7e8f4fb266f1e7bb9453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003616 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#734712}
-
Albert Chaulk authored
Sometimes the surface appears to resize to 0x0 when being destroyed. If this happens and the surface id is invalid at the point where the surface aggregator replaces the invalid surface with a solid color quad and that triggers a DCHECK So just don't emit 0x0 quads at all Bug: b/147673681 Test: None Change-Id: Icc89bff8c9b6d21560390285721637bf8cf608f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013801 Commit-Queue: Albert Chaulk <achaulk@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#734711}
-
Manas Verma authored
This reverts commit eeb29c79. Reason for revert: This fix was tested again and was working as intended, and was deemed more maintainable than the alternative solution. Original change's description: > Revert "[Autofill Auth] Adding capability to disable WebAuthn UI from Autofill" > > This reverts commit 69671ce5. > > Reason for revert: Tested in Canary, and the flow stops immediately after authentication. Will try to debug this, and possibly just go ahead with the long term solution right away. > > Original change's description: > > [Autofill Auth] Adding capability to disable WebAuthn UI from Autofill > > > > Providing an option to disable WebAuthn UI from InternalAuthenticatorImpl. > > > > By disabling WebAuthn UI, modal dialogs will stop conflicting between the two > > components and this will give Autofill full control over the user experience. > > > > Bug: 949269 > > Change-Id: Ibf88cdb0f014c022371546df54d10e2c9eb7bc24 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948916 > > Commit-Queue: Manas Verma <manasverma@google.com> > > Reviewed-by: Martin Kreichgauer <martinkr@google.com> > > Reviewed-by: Jared Saul <jsaul@google.com> > > Reviewed-by: sebsg <sebsg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#722230} > > TBR=sebsg@chromium.org,jsaul@google.com,martinkr@google.com,manasverma@google.com > > Change-Id: Iab4507114f3e19e59acddd49ea89244ee7390048 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 949269 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955910 > Reviewed-by: Manas Verma <manasverma@google.com> > Commit-Queue: Manas Verma <manasverma@google.com> > Cr-Commit-Position: refs/heads/master@{#722571} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 949269 Change-Id: Ib4ca1fc4eb1d0032864385d8c66c926c6e6d1a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017647Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Manas Verma <manasverma@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#734710}
-
Cliff Smolinsky authored
Newly added static lib dependencies prevent the unittests from loading on non-desktop Windows skus such as Hololens. The delayloads allow this to succeed. Bug: 1045092 Change-Id: Icc9d24ff0a3b4e31895574f6ecac2b5b761aa185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016664Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#734709}
-
Tim Song authored
All events are being sent to the ARC notification window, so we need a special case to forward click and tap events to the message center widget when the ARC notification is slid out. BUG=965603 Change-Id: I7a0c4653c2bb0eef5dbf1c8708f33fa96ee4567e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016282Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#734708}
-
Kevin McNee authored
RenderWidgetHostViewGuest has been removed, so there is no longer a need to check whether a RWHVAura is related to a guest. We also add a DCHECK to ensure the view is not a child frame which would make this a bad cast. Bug: 533069 Change-Id: Ie71f246d3a524865a1217dd4e1521a5c5c60c295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017182Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#734707}
-
John Lee authored
Change-Id: If7dcc1d250162ac5bd315d163b4f49fc0aa16b61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016352Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#734706}
-
Ayu Ishii authored
This change removes the old "CookieStore" flag and adds 2 new flags "CookieStoreDocument" and "CookieStoreWorker". The APIs are divided as follows. CookieStoreDocument: -'CookieStore': ['get', 'getAll', 'set', 'delete', 'onchange'] -'CookieChangeEvent': ['changed', 'deleted'] CookieStoreWorker: -'ServiceWorkerRegistration': ['cookies'] -'CookieStoreManager': ['getSubscriptions', 'subscribe', 'unsubscribe'] Change-Id: I8dd3fd8419576a70aae3cf5012d96fb7f8afb2ce Bug: 1044245 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008588Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#734705}
-
Tommy Steimel authored
This CL ensures that KaleidoscopeWebUIControllerFactory is enabled before attempting to register it. Bug: 1044216 Change-Id: I0ed2b42c7bc1264b89a075d06c023463f932a385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012834Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#734704}
-
Regan Hsu authored
Move strings that belong to OS Settings Personalization section out of Appearance string section of browser settings string provider, and into OS settings string provider. Bug: 967888 Change-Id: Ib96b0635e304a136ebe137916903b6d9ef5bd87f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013497Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#734703}
-
Tim Song authored
Opening the inline settings now triggers another surface created event, which is not currently expected by the ArcAccessibilityHelperBridge. If the corresponding tree already exists, then we should just return early. TEST=manually verified BUG=1042554 Change-Id: Ic689184f54c4a737ddd35d7ed05e42b09d3c21bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003197Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#734702}
-
Jamie Walch authored
This CL updates implementors of MouseCursorMonitor and MouseCursorMonitor::Callback in line with https://webrtc-review.googlesource.com/c/src/+/166560 Bug: 1043325 Change-Id: I24f7d574d4993f73c2a9413600d2d6563159cda3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013754Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#734701}
-
Johannes Henkel authored
New Rev: 201330a4e7a527dfc6d73bbb3c297562edcf28f8 Change-Id: I8d47c1944a43d1ea96cd572a1ff41ea378ba255b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017676 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#734700}
-
Avery Musbach authored
The present CL follows up after [1] which implements functionality where you can drag an overview window from one display and drop into overview on another display. The problem is that after you do so with a browser window and then end overview, the caption buttons (Minimize, Maximize, and Close) on that browser window may not work. I observe the problem on a test device (nautilus) but not in the emulator. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2008237 Bug: 961170 Change-Id: I15f6bcec8116cbe853737682735865a77827d196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013866 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#734699}
-
Aaron Colwell authored
ChildProcessSecurityPolicyTest.HandleExtendsSecurityStateLifetime was failing because it was triggering citadel enforcements. This change makes sure the process_id is properly locked so that the test doesn't fail the citadel check. Change-Id: I7a94892e090e88fc5915ee7e61e898146cb8716d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017991 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#734698}
-
Wenyu Fu authored
Extract part of the common utility function in Homepage related test to HomepageTestRule. Bug: 1036470 Change-Id: I19b6feb55deff54b94c025ab6319eeeeb7e48650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013740 Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#734697}
-
chrome://certificate-managerDemetrios Papadopoulos authored
The migration of the <certificate-manager> component itself has been done in previous CLs. Here chrome://certificate-manager is simply modified to display the Polymer 3 version of <certificate-manager> Bug: 965770 Test: Navigate to chrome://certificate-manager. There should be no HTML Imports related warnings in DevTools. Change-Id: I68f8aac10c9cf3aa94853670b0201beb87e4aebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013860Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#734696}
-
Yuly Novikov authored
Mac trybots were switched in crrev.com/c/1918372, this completes the migration, switching Android, Linux and Windows manual GPU trybots. Also removes gpu-fyi-try-win-xr-builder-64, since it doesn't have a corresponding pool, and looks like it can't be used for the intended purpose of pinpoint jobs. Bug: 1020753, 977735 Change-Id: I7800d10c137010c08bb4ff10cd966dc62df9a161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015548 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#734695}
-
Archana Simha authored
BUG=1044730 Change-Id: I9b664dfea146371672d1e6488f34fdbd0a4fcb0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013495 Commit-Queue: Archana Simha <archanasimha@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#734694}
-
Maks Orlovich authored
Bug: 1045122 Change-Id: I54beac2185515cf91b6225f9ce1588f2d2ae65e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015430 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#734693}
-
Sarthak Shah authored
Currently, if experimental fling animation feature is turned on, FlingControllerTest fails with an exception as ScreenWin::GetPixelsPerInch() returns zero. As there is no display instantiated while running FlingController unittest, GetScreenWinDisplayNearestDIPPoint returns default ScreenWin object which has zero value for pixels per inch. This CL fixes the issue by return default value if the value of pixels per inch from ScreenWinDisplay is zero. Change-Id: I9cd7aa2ccfd62fa1896981f09a2dd4a336e49469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974620Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#734692}
-
Evan Stade authored
New methods are added to Tab: - beginFindInPage - activateNextFindInPageMatch - endFindInPage And a new FindInPageCallback interface is introduced with one method: - onFindResult Also add very basic FIP controls to shell to partially exercise the new API. Notes: 1. The embedder provides the main find in page UI (the text input). 2. The embedder is responsible for ending the find session as appropriate (i.e. when the main find in page UI is dismissed), which cleans up the in-page UI, consisting of a results sidebar and text highlighting. Commonly this would happen if the user cancels the find session or if a navigation occurs. 3. When the active tab loses focus, the find session is ended and the result bar is removed. 4. It is generally expected that the embedder-provided find in page UI will be hosted in the top view. TODO: 1. The top controls should be forced visible when the new web contents overlay view holds children. That will definitely be desired for tab modal dialogs, and is probably desired for find in page as well (at least judging by what Clank does). 2. Write tests. Bug: 1038415 Change-Id: I6183172dc3944157aae2db5ebb0aed983a34bffc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004072Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#734691}
-
Tim Van Patten authored
The test conformance/textures/misc/texture-upload-size.html is flaky on Android with the OpenGL ES backend: https://ci.chromium.org/p/chromium/builders/try/android_angle_rel_ng/10962 https://ci.chromium.org/p/chromium/builders/try/android_angle_rel_ng/10935 https://ci.chromium.org/p/chromium/builders/try/android_angle_rel_ng/10931 https://ci.chromium.org/p/chromium/builders/try/android_angle_rel_ng/10871 This CL will suppress the test while the issue is investigated. Bug: 1044847 Tbr: ynovikov@chromium.org Change-Id: I068b75df073d2e1c39a0027d5642cccea8e0f1fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017644 Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Auto-Submit: Tim Van Patten <timvp@google.com> Cr-Commit-Position: refs/heads/master@{#734690}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/a5a6e4f5bbda..d87e67684558 git log a5a6e4f5bbda..d87e67684558 --date=short --first-parent --format='%ad %ae %s' 2020-01-23 cwallez@chromium.org Add the webgpu.h swapchain creation path Created with: gclient setdep -r src/third_party/dawn@d87e67684558 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Id9ebeeab4ccc90df0fd625c21915ab9389cd814e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017679Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734689}
-