GitLab

Revert of MediaRecorder: use VideoTrackRecorder::GetPreferredCodecId() when available (patchset #5 id:250001 of https://codereview.chromium.org/2624053002/ )

Reason for revert:
Suspected CL-to-blame for webkit tests failing on Mac Retina:
fast/mediacapturefromelement/HTMLMediaElementCapture-capture.html
fast/mediacapturefromelement/CanvasCaptureMediaStream-framerate-0.html

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28retina%29/builds/10965

Original issue's description:
> MediaRecorder: use VideoTrackRecorder::GetPreferredCodecId() when available
>
> This CL adds a static method to VTR to query which
> one, if any, is the preferred video codec.
>
> A new singleton Lazy Leaky class CodecEnumerator is
> added to encapsulate poking the VEA to see which
> codecs are supported, and to further query
> a) the preferred codec id
> b) if a given codec is supported
> and wraps the previous CodecIdToVEAProfile()
> functionality.
>
> BUG=679946
>
> Review-Url: https://codereview.chromium.org/2624053002
> Cr-Commit-Position: refs/heads/master@{#443165}
> Committed: https://chromium.googlesource.com/chromium/src/+/904b7a6f6dffa9cee5ac930c37dd591c330d14c6

TBR=emircan@chromium.org,chfremer@chromium.org,mcasas@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=679946

Review-Url: https://codereview.chromium.org/2622273006
Cr-Commit-Position: refs/heads/master@{#443251}

Based on post-review comments on:
https://codereview.chromium.org/2558913003/

BUG=none
TBR=mattm@chromium.org,donnd@chromium.org,afakhry@chromium.org,noyau@chromium.org

Review-Url: https://codereview.chromium.org/2627033003
Cr-Commit-Position: refs/heads/master@{#443250}

This implements the crash handler companion to the launcher in https://codereview.chromium.org/2596463002/. The handler parses the command line as created by the launcher. After this, it can write a minidump with MinidumpWriteDump, then augment it with Crashpad metadata and massage such that Crashpad can parse it.
After this, the dump is dropped into the Crashpad database for eventual upload.

BUG=678959

Review-Url: https://codereview.chromium.org/2611393002
Cr-Commit-Position: refs/heads/master@{#443249}

BUG=630728
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2618933002
Cr-Commit-Position: refs/heads/master@{#443248}

Use webState:didStartProvisionalNavigationForURL: instead.

BUG=674991

Review-Url: https://codereview.chromium.org/2626733003
Cr-Commit-Position: refs/heads/master@{#443247}

This work is to support more generic rendering for mobile platforms.
The thinking behind using a stack of 'drawable' objects is we could
add future features like fps stats or more animations, and also add
debug screens to apps in development for gesture feedback and connection
health.

R=yuweih@chromium.org
BUG=671692

Review-Url: https://codereview.chromium.org/2591363002
Cr-Commit-Position: refs/heads/master@{#443246}

Change the exclusive end time bound in WebHistoryService to be inclusive,
as required by the history.google.com API.

BUG=674165

Review-Url: https://codereview.chromium.org/2621143004
Cr-Commit-Position: refs/heads/master@{#443245}

Part of removing dependency of Windows browser DLL on v8.

R=jochen@chromium.org
BUG=581766

Review-Url: https://codereview.chromium.org/2627713007
Cr-Commit-Position: refs/heads/master@{#443244}

The model was already being reloaded but not the the collection view,
this could cause crashes as the collection view and its model were not
in sync anymore. The collection view is now reloaded as well.

BUG=680098

Review-Url: https://codereview.chromium.org/2622103005
Cr-Commit-Position: refs/heads/master@{#443243}

https://skia.googlesource.com/skia.git/+log/621ea115e0b1..0c2997b6d85e

$ git log 621ea115e..0c2997b6d --date=short --no-merges --format='%ad %ae %s'
2017-01-11 brianosman Remove second version of SkImageInfo2GrPixelConfig
2017-01-11 brianosman Remove kIndex_8_GrPixelConfig
2017-01-12 borenet Move recipe expectations into example.py recipes inside of modules
2017-01-12 borenet Move most recipes into modules

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=kjlubick@google.com

Review-Url: https://codereview.chromium.org/2630543002
Cr-Commit-Position: refs/heads/master@{#443242}

BUG=677012

Review-Url: https://codereview.chromium.org/2617583006
Cr-Commit-Position: refs/heads/master@{#443241}

Semi-autogenerated ARCMigrate commit.
Notable issues:
 * Since one of the weak_nsobjects is exposed in a header and I change it to a __weak instead, converted two unit tests to ARC alongside this.
 * Fixed some assignments of newly created views to weak properties by introducing an intermediate local variable to retain the view until it's added as subview.

BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2624963003
Cr-Commit-Position: refs/heads/master@{#443240}

WmWindowMus and WmWindowAura only differ in a couple of ways that are
better isolated in WmWindowAura rather than two separate classes.

Next I'm going to rename WmWindowAura to WmWindow.

BUG=671246
TEST=none
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2625873007
Cr-Commit-Position: refs/heads/master@{#443239}

Changelog:
  [78fa5bc24d] SyzyAsan - Improve the performance of the heap corruption detector.

BUG=675697

Review-Url: https://codereview.chromium.org/2626853004
Cr-Commit-Position: refs/heads/master@{#443238}

Ensure that dismissing a category cannot increase its clicks and use
the previous category clicks, not the next one.

Due to PassingMargin, it is possible that lower categories have more
clicks. Before this CL, this could lead to dismissed category clicks
increase, which was not intended. Now we take mininum of new and old
clicks.
In addition to this before this CL, click count was reduced based on
the next category in the list, after this CL, on the previous one.

BUG=678586

Review-Url: https://codereview.chromium.org/2616813003
Cr-Commit-Position: refs/heads/master@{#443237}

The RecyclerView library has a mechanism to perform partial refresh
of views from the adapter via partial binds[1]. Added support for it
in the NewTabPageAdapter and related classes, and rewrote the refresh
of the offline badge using that.

This patch also fixes an issue where the badge was not removed when an
offline page was deleted

Preview: https://goo.gl/photos/MKD2WXTiNqbQ17xD8

BUG=616090

Review-Url: https://codereview.chromium.org/2622793003
Cr-Commit-Position: refs/heads/master@{#443236}

https://pdfium.googlesource.com/pdfium.git/+log/e8b0281d1342..ffdfbb9ec274

$ git log e8b0281d1..ffdfbb9ec --date=short --no-merges --format='%ad %ae %s'
2017-01-12 tsepez Remove unused CJS_Object::ExitInstance() method

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2627783005
Cr-Commit-Position: refs/heads/master@{#443235}

To pick up our upstreamed optimization for suggestions, and fuzzing bug fixes.

The license requirements were approved, by having README.chromium
specify which license it was using.

BUG=673424

Review-Url: https://codereview.chromium.org/2587363003
Cr-Commit-Position: refs/heads/master@{#443234}

In https://codereview.chromium.org/2554413002/, BrowsingDataRemover was
split into content-related and embedder-specific datatypes
(BrowsingDataRemover[Impl] and [Chrome]BrowsingDataRemoverDelegate,
respectively).

The split was done according to where the relevant data storage backends
resided. This CL intends to make the split more precise by looking at it
more semantically.

1. While SSLHostStateDelegate lives in content/, it's state is deleted
   as a part of the HISTORY datatype, which is not a content/ concept.
   Therefore, this was moved to ChromeBrowsingDataRemoverDelegate.

2. The DCHECK verifying that all UI entrypoints to history deletion
   were disabled if !|may_delete_history| was also moved to
   ChromeBrowsingDataRemoverDelegate, as UI is also not a content/
   concept.

3. The deletion of auth cache is done in BrowsingDataRemoverDelegate
   for both the COOKIES and PASSWORDS datatypes. However, PASSWORDS
   are not a content/ concept. Therefore, BrowsingDataRemoverImpl now
   deletes the auth cache for COOKIES, and
   ChromeBrowsingDataRemoverDelegate for PASSWORDS. This is currently
   done by the duplication of the code, as some duplication is
   necessary anyway, and only about ~10 lines of code are duplicated
   unnecessarily; this seems to be too few to justify creating a new
   file in content/public to be shared between content/ and chrome/.

   TODO: This is the second duplication between the two classes. If
   this keeps happenning, consider putting the shared functionality
   to content/public anyway.

BUG=668114

Review-Url: https://codereview.chromium.org/2617403005
Cr-Commit-Position: refs/heads/master@{#443233}

The following traits are used:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: SKIP_ON_SHUTDOWN (default)
  Tasks posted with this mode that have not started executing at
  shutdown will never run. However, any task that has already begun
  executing when shutdown is invoked will be allowed to continue and
  will block shutdown until completion.

  Note: Previously, the task was posted to the blocking pool with
  BLOCK_SHUTDOWN (default in SequencedWorkerPool).

May Block:
  Tasks posted with MayBlock() may block. This includes but is not
  limited to tasks that wait on synchronous file I/O operations:
  read or write a file from disk, interact with a pipe or a socket,
  rename or delete a file, enumerate files in a directory, etc. This
  trait isn't required for the mere use of locks.

BUG=667892

Review-Url: https://codereview.chromium.org/2625193002
Cr-Commit-Position: refs/heads/master@{#443232}

The following traits are used:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: SKIP_ON_SHUTDOWN (default)
  Tasks posted with this mode that have not started executing at
  shutdown will never run. However, any task that has already begun
  executing when shutdown is invoked will be allowed to continue and
  will block shutdown until completion.

  Note: Previously, the task was posted to the blocking pool with
  BLOCK_SHUTDOWN (default in SequencedWorkerPool).

May Block:
  Tasks posted with MayBlock() may block. This includes but is not
  limited to tasks that wait on synchronous file I/O operations:
  read or write a file from disk, interact with a pipe or a socket,
  rename or delete a file, enumerate files in a directory, etc. This
  trait isn't required for the mere use of locks.

BUG=667892

Review-Url: https://codereview.chromium.org/2623313002
Cr-Commit-Position: refs/heads/master@{#443231}

SigninInteractionController uses an AlertCoordinator to display
potential sign-in errors, which requires the view controler to use to
present the alert dialog.
To ensure SigninInteractionController can always display correctly
errors, the AlertCoordinator must be given the top most visible view
controller (some errors are displayed before the sign-in screen is
shown, and some are displayed on top of the sign-in screen).

BUG=679809

Review-Url: https://codereview.chromium.org/2626003004
Cr-Commit-Position: refs/heads/master@{#443230}

Added benchmarks: v8.todomvc-turbo, v8.infinite_scroll-turbo_tbmv2, v8.browsing_mobile_turbo, v8.browsing_desktop_turbo

R=mvstanton@chromium.org,hpayer@chromium.org
BUG=v8:5827
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2623113003
Cr-Commit-Position: refs/heads/master@{#443229}

When add main thread scrolling reason kHandlingScrolFromMainThread, there is no need to update the subframes as they are not scrollable when the reason is set to main frame.
BUG=675677

Review-Url: https://codereview.chromium.org/2620453003
Cr-Commit-Position: refs/heads/master@{#443228}

Previously, we disabled the hackernews telemetry test as we tried to set the
default value of touch-events flag to enabled. Now we've changed the strategy
and reset the default value to auto. And recently, we also passed the test with
the flag set to be enabled. So the hackernews telemetry test no longer needs to
be disabled.

BUG=665007

Review-Url: https://codereview.chromium.org/2627163003
Cr-Commit-Position: refs/heads/master@{#443227}

BUG=602666

Review-Url: https://codereview.chromium.org/2621453002
Cr-Commit-Position: refs/heads/master@{#443226}

https://skia.googlesource.com/skia.git/+log/e7a364d43584..621ea115e0b1

$ git log e7a364d43..621ea115e --date=short --no-merges --format='%ad %ae %s'
2017-01-12 mtklein only copy NDK binaries when using NDK in our standalone builds

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=kjlubick@google.com

Review-Url: https://codereview.chromium.org/2631483003
Cr-Commit-Position: refs/heads/master@{#443225}

Before this CL, URLFetcher could only be instantiated from a
single-threaded task. The response was dispatched on the origin thread.

With this CL, URLFetcher can also be instantiated from a sequenced
task. The response is dispatched on the origin sequence.

Since SequencedTaskRunnerHandle behaves the same way as
ThreadTaskRunnerHandle when used from a single-threaded task, this
CL does not affect the behavior of existing URLFetcher call sites
(they are necessarily in single-threaded tasks because
base::ThreadTaskRunnerHandle::Get() crashes when called from
a non-single-threaded task).

BUG=675631

Review-Url: https://codereview.chromium.org/2599873002
Cr-Commit-Position: refs/heads/master@{#443224}

This will avoid the system from inappropriately coalescing them with
other kinds of notifications shown by Chrome.

BUG=674927

Review-Url: https://codereview.chromium.org/2627963003
Cr-Commit-Position: refs/heads/master@{#443223}

Some internal tests require special entitlements (e.g. for keychain
access). This was inadvertently dropped during the upstreaming.

BUG=679042

Review-Url: https://codereview.chromium.org/2632473002
Cr-Commit-Position: refs/heads/master@{#443222}

BUG=676382
TEST=none

Review-Url: https://codereview.chromium.org/2625123003
Cr-Commit-Position: refs/heads/master@{#443221}

BUG=678850
TEST=conformance/more/functions/vertexAttribPointerBadArgs.html,
     conformance/attribs/gl-vertexattribpointer.html,
     conformance2/attribs/gl-vertexattribipointer.html.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2610393003
Cr-Commit-Position: refs/heads/master@{#443220}

Now, TestingPlatformSupport registers itself as the current Platform
instance, but it is inside the constructor.

On the other hand, a child class TestingPlatformSupportWithMockScheduler
expects the parent class reigsters it for children.

But, to register a Platform instance, virtual methods should be ready
to call. Rephrasing it, we can not register a Platform instance
correctly inside a super-class's constructor.

This patch provides ScopedTestingPlatformSupport class template that
manages TestingPlatformSupport instance and Platform instance
installation.

Without this patch, Platform::current()->mainThread() returns a
wrong WebThread, and it makes new tests that I will add fail.

BUG=n/a
TEST=platform_blink_unittests, webkit_unit_tests

Review-Url: https://codereview.chromium.org/2588403002
Cr-Commit-Position: refs/heads/master@{#443219}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6377613b1a29..0e201cdd06ed

$ git log 6377613b1..0e201cdd0 --date=short --no-merges --format='%ad %ae %s'
2017-01-12 hjd Hopefully this will make it easier for people coming to the memory infra UI for the first time to understand what is happening.

BUG=663353

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2622363004
Cr-Commit-Position: refs/heads/master@{#443218}

The following traits are used:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: SKIP_ON_SHUTDOWN (default)
  Tasks posted with this mode that have not started executing at
  shutdown will never run. However, any task that has already begun
  executing when shutdown is invoked will be allowed to continue and
  will block shutdown until completion.

  Note: Previously, the task was posted to the blocking pool with
  BLOCK_SHUTDOWN (default in SequencedWorkerPool).

May Block:
  Tasks posted with MayBlock() may block. This includes but is not
  limited to tasks that wait on synchronous file I/O operations:
  read or write a file from disk, interact with a pipe or a socket,
  rename or delete a file, enumerate files in a directory, etc. This
  trait isn't required for the mere use of locks.

BUG=667892

Review-Url: https://codereview.chromium.org/2628673003
Cr-Commit-Position: refs/heads/master@{#443217}

The lifetime of ExecutionContext and DOMWindow is a bit different.
In common case, they get detached at the same timing but in a case where
a frame navigates from an initial empty document to another same-origin document,
the ExecutionContext gets detached but the DOMWindow is reused.
Due to the (subtle) difference, we need DOMWindowClient in addition to ContextClient.

ContextClient is a client for objects that want to observe ExecutionContext.
DOMWindowClient is a client for objects that want to observe DOMWindow.

This CL uses DOMWindowClient for Navigator.

BUG=610176

Review-Url: https://codereview.chromium.org/2629493004
Cr-Commit-Position: refs/heads/master@{#443216}

BUG=679369

Review-Url: https://codereview.chromium.org/2619963004
Cr-Commit-Position: refs/heads/master@{#443215}

As a quick fix, I'll revert the change of file_manager_private.js in
https://codereview.chromium.org/2580303002/.

BUG=none
TBR=nya@chromium.org
TEST=run third_party/closure_compiler/run_compiler

Review-Url: https://codereview.chromium.org/2625233004
Cr-Commit-Position: refs/heads/master@{#443214}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/d71b47153f16..6377613b1a29

$ git log d71b47153..6377613b1 --date=short --no-merges --format='%ad %ae %s'
2017-01-12 hjd [tracing] Use ES6 object literal notation when exporting symbols

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2631513003
Cr-Commit-Position: refs/heads/master@{#443213}

Instead, I modified V8 to just cope with this behavior

BUG=chromium:679345
R=haraken@chromium.org

Review-Url: https://codereview.chromium.org/2625643002
Cr-Commit-Position: refs/heads/master@{#443212}