- 06 Oct, 2020 40 commits
-
-
Thomas Lukaszewicz authored
This is a reland of 635cbc1a Change: Added missing variable initialization. Original change's description: > Views: Add BoxLayoutView > > This CL adds class member getters and setters to the BoxLayout class > where needed for the BoxLayoutView properties. Adds a TODO to ensure > layout is invalidated when these members are set. > > Bug: None > Change-Id: I13d73c75ca93f9de391b46c7241682ee7ced9a89 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434561 > Reviewed-by: Wei Li <weili@chromium.org> > Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813351} Bug: None Change-Id: I850dfcc06c75bd49073e6aa0d0cc51471d5ebbb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451554Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#814309}
-
Lu Huang authored
design doc: https://docs.google.com/document/d/19dGklalQTRtRrG3PKrVbDRmYPLHGLnsGEwUaed7sAFQ/edit?usp=sharing design overview cl: https://chromium-review.googlesource.com/c/chromium/src/+/2393252 Chrome status: https://www.chromestatus.com/feature/5739732661174272 Bug: 1072058 Change-Id: I6ef280af95514e0ac1abfacdcf6b113ee7b7af57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444439 Commit-Queue: Lu Huang <luhua@microsoft.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#814308}
-
Sean Kau authored
ChromeOS printing team has enough data. It's pretty much always 1. Bug: 1089320 Change-Id: I9683a47aed3f183d401ffe56ec21a7bb965abbcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447229 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#814307}
-
Kyle Shimabukuro authored
Adds the ability to clear all notifications. The chrome precondition state reset in Tast does not clear notifications which is causing issues with the test ui.QuickSettingsMicGainSlider. We can call the function added here during the state reset to clean up notifications that other tests may have left behind. BUG=chromium:1131698 TEST=Manually created some notifications by taking screenshots and downloading files, and manually called the api to clear the notifications. Change-Id: I7e0995a0d99ebcf54ba7a59d986de19e848daeb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442648 Commit-Queue: Kyle Shimabukuro <kyleshima@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#814306}
-
Yuke Liao authored
ui/ozone/ozone.gni was moved to build/config/ozone.gni, however, it turns out that ozone.gni depends on ozone_extra.gni, so this CL moves ui/ozone/ozone_extra.gni to build/config/ozone_extra.gni in order to keep build/config self-contained. Bug: 1129223 Change-Id: I0b67cbd41d7b402dfd595204a3a599053c83ba77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451872 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#814305}
-
Sebastien Lalancette authored
Moving some of the logic that used to live in utils into a new handler class. This class will be used to receive asynchronous JavaScript responses in a subsequent CL, hence the requirement to use an instance rather than utility functions. Bug: 1099268 Change-Id: I6752d1532bc5e64d40f327b7506e298d136e78a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446816 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#814304}
-
Maksim Sisov authored
In case of Ozone, we support more types. Bug: 1134495 Change-Id: I9712931545c8b70a1a0357d5b119b8c9a7c08c4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443650Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#814303}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metatada from OWNERS files for //styleguide. Bug: 1113033 Change-Id: Ia223073dc571c11b1bc55eeaba7e8a9d738de16d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451392Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Mugdha Lakhani authored
Add a BackgroundSync delegate to let components embedder customize the logic in components/background_sync. Use this delegate to customize UKM logging logic, and remove the dependency on UkmBackgroundService from BackgroundSyncControllerImpl, which will eventually be moved to components. background_sync_metrics* will be moved to components/ in a follow-up CL. Bug: 1087486 Change-Id: Ia6221f9db842ba8a2da90a1ef3fe721bc113b858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443089Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#814301}
-
Moe Ahmadi authored
- zero-prefix suggestions on the NTP (Omnibox and Realbox) have been launched in M84 and enabled by default in M86 (crrev.com/c/2175138) - zero-prefix suggestions on SERP are no longer pursued. Fixed: 1134782 Change-Id: Ie9a074dc1306371173d34f8200b55686df153751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446461 Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#814300}
-
George Steel authored
This is to prepare for using DependsOnBoxSize for invalidation of compositor animations, allowing width and height changes to be propagated separately. This is to enable acceleration of percent- containing transform. See design doc https://docs.google.com/document/d/1zgr5CHRMpvlqodn1e0eM9J3MjL2eEMfAHrHsZUK7gMM/ Bug: 389359 Change-Id: I2bf30bdd51b048bc6f1d330e4159c72c36a5f5ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422088Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#814299}
-
Xinghui Lu authored
Bug: 1130728 Change-Id: I9549b464abedb6e06b706a2923ccf613a99f02ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434884Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#814298}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //sql. Bug: 1113033 Change-Id: I7fa2ca83ea5d961bea8d257c4919b035f9e6fe6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451394 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#814297}
-
mark a. foltz authored
This adds an OWNERS file for this folder for consistency with other Android code that supports Cast features. Change-Id: I7da7aac04b56c493cf78be47afdfc2e47604682e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441528Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#814296}
-
Aaron Leventhal authored
When adding children, make sure we only add aria-owned children to the owning nodes. This avoids a common crash in chrome://bookmarks that has a confusing crash stack. In order to do this, when ComputeAccessibilityIsIgnored() is called, the relation cache must already be updated with the knowledge that the object is owned. Do not ever allow owned objects to ever have a "not included in tree" parent. Therefore, they can never be added as second line children via the recursion in InsertChild(). Also re-remove WalkAllDescendants(), which was it was recently re-added as a band-aid for the chrome://bookmarks crashes. Without this change, removing WalkAllDescendants() causes assertions in AXTreeSerializer, when aria-owns points to an unincluded node, that the same object is being added twice. Finally, add better logging and DCHECKs that will help diagnose issues more quickly. TBR=dmazzoni@chromium.org Bug: 1100968, 1131848 Change-Id: I79d785bc725989a53274a14f6bded5dbdaa7e21d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451507Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#814295}
-
Nohemi Fernandez authored
The current approach does not allow a developer to change the icon image when another image has already been set. Bug: 1125631 Change-Id: I2665b3ffdd66f666b9fe86821ba4fa04d6708ed0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445417 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
-
John Lee authored
This CL adds a new component <cr-menu-selector> that takes in a set of elements that have a role of 'menuitem' and manages focus between the items as the user uses arrow, Home, and End keys. The first menuitem is the only menuitem that is focusable using the Tab key, allowing users to easily skip over the menu to the main content area of a page. This follows the accessibility guidelines set for navigation drawers. This element will also be used on the History page's menu. Bug: 1110405 Change-Id: I1d644959412d5c19f324d75336bd0e9a08ce7ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436706Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#814293}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: I64955cac925925260dd5876ce7a46fda82ba24e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445472 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#814292}
-
Ionel Popescu authored
This CL enables the eye dropper feature on Windows and Mac. Bug: 992297 Change-Id: I3ebe0e8526fda49f7956af4e3fe8fd2ea5cdb73d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412598Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#814291}
-
Tibor Goldschwendt authored
This is necessary to trigger the shopping tasks experiment. Bug: 1135401 Change-Id: I030f073dd9c4b69bed037fa8f7923d8860249b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451575 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#814290}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 52 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2021-01-04. TBR=chromium-metrics-reviews@google.com Change-Id: Ic4ef9858937be7af003a770a63b0c61a3b7618f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451402Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#814289}
-
Tommy Nyquist authored
These histograms are shared by multiple in-product help features, and as such need to be extended. Their names are completed by the IPHFeatures suffix. In addition, the histograms tracked for the two database types (events and availability) are also extended. Bug: 1134477 Change-Id: Ia7c097f7d5e50d08e428e998f72f701bd5c54143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450843Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#814288}
-
Rayan Kanso authored
This is guarded behind a feature flag. Ideally, we should be able to check whether a launch URL works offline before registering the content index entry. Bug: 1122646 Change-Id: I204828691590670f3625eb02b53c1bb6dbbc574a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379836 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#814287}
-
Adrienne Walker authored
It is unclear what the rate of blob files missing are as a part of this bug, and so add some metrics to try to get a handle on the scope of the problem. FilesystemProxyFileStreamReader is currently only used for IndexedDBDataItemReader, but this creates a separate entry point and metrics boolean in case this class gets reused for something other than IndexedDB. Bug: 1131151 Change-Id: I4d0610413534fb40edb95e321b6d58e92fdf23ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446889Reviewed-by:
-
Nohemi Fernandez authored
- Adds the entrypoint to Settings from NTP profile image. - Updates the Settings screen to separate Sync from Google Services. - Adds the new G icon for Google Services. https://drive.google.com/file/d/1EdCu2VT7I8DBERCr-SZlXXBlZh9OVaNS/view?usp=sharing Bug: 1125631 Change-Id: I6354c7e93d116b0ed69f54100988e38a8bff7529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442794 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#814285}
-
Joon Ahn authored
https://screenshot.googleplex.com/AYbxBNBccTZfMbZ Bug: 1125150 Change-Id: I123b7f0c29dc3c6004e0e7a299c5102b20a9b0fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450895Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#814284}
-
Richard Knoll authored
Other types of notifications shown by Chrome are typically features explicitly triggered by the user and should still be shown even if the user is currently recording the whole screen. Bug: 1131375 Change-Id: I06bc335f8b556fb9105d99314ec1070a653e7810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437397 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#814283}
-
David Roger authored
Screenshot: https://screenshot.googleplex.com/9ni7vN3NVGAAcGf.png Bug: 1130945 Change-Id: I9aeafecd92ca17ed492aa00d6e86b0f4fced9716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445483 Auto-Submit: David Roger <droger@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#814282}
-
Peter Kotwicz authored
This CL: - Forces on check that resource_overlay is specified if target overrides resources for non-test targets. Disables check by default for tests. The check is not on by default for tests because tests like clank_junit_tests include resources with the same name but from different dynamic feature modules - Adds enforce_resource_overlays_in_tests flag to enable tests to enable check. BUG=1093825 Change-Id: Id0ac645b6f338b1f2c3a6ce75b6be35f9de6e29c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391606 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#814281}
-
Mason Freed authored
With [1], all three Web Component v0 APIs have been disabled for any external use through the WebIDL. This CL DCHECKs on two of the three, to make sure no internal code is using these APIs. There are still dependencies on HTML Imports (see crbug.com/1111843), so that API will be left functional for now. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2195005 Bug: 937746, 1111843 Change-Id: Iba416e804828f8a0961dd4dbfbffc1159573c5e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451299Reviewed-by:
Yu Han <yuzhehan@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#814280}
-
Ben Pastene authored
This moves that particular test to the main chromium.tests pool while also configuring it to use a named cache on the test bot. This cache won't be used to store any files, but will simply let us target (via swarming dimensions) bots that already have this cache (i.e. bots that have already ran a CrOS VM url_unittests). This is done by also adding an additional task slice to the test that will wait 60s for a bot with that cache already present. If one isn't available in time, it will run on any bot. In the latter case, that bot will then have our magic cache created on it, allowing it to run future CrOS VM url_unittests. Bug: 1132206 Change-Id: If8630a84bb9892065deb8e3639e3d0780e2ffc83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438776Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#814279}
-
Jeff Yoon authored
The machines have successfully upgraded to Mac 10.15, so we're setting the OS dimension accordingly. Bug: 1135264 Change-Id: Ie1bcf9e434e75510a673f93ac430474c5fbcf7a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450896 Auto-Submit: Jeff Yoon <jeffyoon@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
-
Tim Volodine authored
The test is flaky on some android bots, in particular on Lollipop Phone Tester and Marshmallow Tablet Tester. BUG=1135601 TBR=altimin@chromium.org,hbolaria@chromium.org Change-Id: I72916ef172ecc76d6a2b92e3482314e52751c91b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453390Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#814277}
-
Dan Harrington authored
For context, enable_feed_v1=false removes the v1 version of the NTP feed from the build. This CL fixes various problems with that configuration: * fixed some tests * fixed some unused resource errors * some tests were more difficult to fix, i've made some assertions conditional. Instant start isn't yet implemented for v2, so it's likely these require more than test updates. Bug: 1129187 Change-Id: If1cfbdd9e596c61c082565279a545326f1dba244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441958Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#814276}
-
Alex Rudenko authored
This CL makes a few improvements in handling the case when the overlay agent gets disabled: - Moves the agent status check to the top of the SetInspectTool. - Adds a check for the agent status in the input event handler so that events are not handled when the agent is disabled. - SetInspectTool returns an error response if the agent is disabled that gets propagated to the client where applicable. This CL is a follow up for the previous fixes in this area [1][2]. [1]: https://crrev.com/c/2387560 [2]: https://crrev.com/c/2235553 Change-Id: Iee68ca735c8990ab15832b0f35c086cceeb98510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397735Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#814275}
-
Elly Fong-Jones authored
This change adds two new methods to WidgetDelegate, both of which allow setting the WidgetDelegate's contents view, thus removing the need to override GetContentsView(). The two new methods are: * SetContentsView(unique_ptr<View>), which takes ownership of the given View * SetContentsView(View*), which doesn't Each method can only be used with the appropriate ownership protocol, so SetContentsView(unique_ptr<View>) will DCHECK if the provided view is owned_by_client(), and vice versa for SetContentsView(View*). This effectively forces clients into one of these two ownership protocols and away from the "sometimes owning" pointer semantics of overriding GetContentsView(). This is part 2 of the following plan: 1) Introduce WidgetDelegate::TransferOwnershipOfContentsView() and migrate to it in places that are trying to take ownership 2) Introduce WidgetDelegate::SetContentsView(), which will either: a. Store the provided view in a unique_ptr, if it is not owned by client, or b. Store the provided view in a raw pointer, if it is owned by client 3) Replace all existing overrides of GetContentsView() with uses of SetContentsView() 4) Require that !owned_by_client() in SetContentsView(), which will likely require intense surgery of client classes 5) Have SetContentsView() take and TransferOwnershipOfContentsView() return a unique_ptr<View> rather than a View* as laid out in 1206dbae. Bug: 1075649 Change-Id: Ifa35af1d87ad958a7d544ed74d6b1f980e416463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449919 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#814274}
-
Makoto Shimazu authored
This reverts commit 8a93811e. Reason for revert: https://crbug.com/1134552 Original change's description: > ServiceWorker: Start the timer immediately after queuing an event > > This CL makes the timer start immediately after an event is enqueued, > and erases the event from the queue when it has not started to run yet > and the timeout happens. Also, this CL updates kUpdateInterval because > the minimum possible timeout is 10 seconds for offline events. > > Bug: 965802 > Change-Id: Ib84c6f3164aa00d525d2f936385a152fdad1fa49 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423698 > Commit-Queue: Asami Doi <asamidoi@chromium.org> > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812028} TBR=falken@chromium.org,shimazu@chromium.org,asamidoi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 965802, 1134552 Change-Id: I61e03383b7147d40ebfa0413a7fe6345202e015d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452092Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b0ecf543..090d2b61 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic6cb2add1af26661a98f6300a5196ccc95cbce62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452555Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814272}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1601942192-fa539b08a521491a2633981acf18458f1a2ef415.profdata to chrome-win32-master-1601974327-16d759bfb740e331cae500f5af505af81f39b1ea.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2f5e7ab40ef6b80c11a0ad31e7087cee0ce604c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452227Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814271}
-
Frank Liberato authored
This reverts commit d92b6c97. Reason for revert: new test fails on the bots Bug: 1135654 Original change's description: > [CORS-RFC1918] Add UseCounter integration tests. > > These tests are defined in chrome/, as opposed to content/, because the > UseCounter integration with UMA histograms relies on chrome/ code. > > Bug: chromium:1124358 > Change-Id: I9faa667e2ced9e92f0c8bd10652ccc2f225c3b13 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442013 > Commit-Queue: Titouan Rigoudy <titouan@chromium.org> > Auto-Submit: Titouan Rigoudy <titouan@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814235} TBR=droger@chromium.org,arthursonzogni@chromium.org,titouan@chromium.org Change-Id: Id40979616b58d0390a070ad5953fd4400954e8ce No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1124358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453571Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#814270}
-
