- 01 Aug, 2017 40 commits
-
-
Tommy C. Li authored
It's been enabled by default for a long time. We're just removing the feature flag now. Bug: 749174 Change-Id: I6cad01d596855c4320e219597789347c63a5b9a6 Reviewed-on: https://chromium-review.googlesource.com/587428Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#491156}
-
Cooper Knaak authored
Add ARC guard to bubble_util.mm so it can only be compiled with Automatic Reference Counting enabled. Although it currently only contains C++ symbols, it is convention to include the ARC guard on all new files. If in the future Objective-C symbols were added to the file, not having the ARC guard could cause memory leaks. R=edchin@chromium.org, gchatz@chromium.org Bug: none Change-Id: I0b72bd93a904f04034ca85f9f21b969f9a358e07 Reviewed-on: https://chromium-review.googlesource.com/596587 Commit-Queue: Cooper Knaak <cooperknaak@google.com> Reviewed-by:
Ed Chin <edchin@chromium.org> Reviewed-by:
Gregory Chatzinoff <gchatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#491155}
-
Yuwei Huang authored
Previously when the user taps "Hide Keyboard" from the session menu, the keyboard will immediately show then hide itself. This CL prevents the keyboard from showing between (alert is shown, action is executed) and manually shows it again only when necessary. This CL also includes some refactoring to reduce redundant common code. Bug: 750956 Change-Id: I545e1880352e279ebf324676f7680600761b78f3 Reviewed-on: https://chromium-review.googlesource.com/595016Reviewed-by:
Scott Nichols <nicholss@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#491154}
-
Weiliang Chen authored
Add a function to replace existing quad with a solid color draw quad to reduce duplicate code in overlay. R=danakj@chromium.org Bug: 739429 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6ea4df426dde50122b73923d970ea3e6429dd8aa Reviewed-on: https://chromium-review.googlesource.com/596647 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
John Bauman <jbauman@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#491153}
-
Gauri Manikpure authored
Bug: chromedriver:1878 Change-Id: I1ae14a5e3700e442ca1507db5c2f51e9e1005044 Reviewed-on: https://chromium-review.googlesource.com/596531Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Gauri Manikpure <gmanikpure@chromium.org> Cr-Commit-Position: refs/heads/master@{#491152}
-
Matt Menke authored
In particular, add suppressions for some new bluetooth/characteristic/ tests, an inspector-protocol test that's seen recent work, and a scrollbar test that's falking for unknown reasons. TBR=rdsmith@chromium.org NOTRY=true Bug: 729849 Change-Id: Ib26bad25b705c9e05c57f588362bcbc9233f5ae5 Reviewed-on: https://chromium-review.googlesource.com/596795 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#491151}
-
Tommy C. Li authored
This CL prevents the match part of the URL from being elided by the experimental URL formatting flags. Bug: 732582 Change-Id: Ic08a8cad845f4d4581d8f6310e59423191d4bd28 Reviewed-on: https://chromium-review.googlesource.com/594722 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#491150}
-
Aleksandr Derbenev authored
Make clang build use msvs_use_absolute_paths gn argument to get same behavior in msvc & clang builds. https://chromium-review.googlesource.com/c/558871/#message-7a8946793945959784b225c192588fa4bb5f26b1 Follow-up: https://chromium-review.googlesource.com/c/558871/ Bug: Change-Id: I9c35d83b0f163356aac0fd2c94f4c56c02a794a5 Reviewed-on: https://chromium-review.googlesource.com/585467Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#491149}
-
Tom Anderson authored
This CL reverts the changes in sysroot-creator.sh and rolls the sysroots forward to reflect the change. BUG=749077 R=thestig@chromium.org Change-Id: Ia9ba4427666dbf9268138f7ec7a2f77df70a172f Reviewed-on: https://chromium-review.googlesource.com/596419 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#491148}
-
Anantanarayanan Iyengar authored
This is to ensure that we can provide functionality to update the AppCache using the URLLoader. The plan is to implement the URLLoaderClient part of the update job in a subsequent patch. This patch has the following changes: 1. We have a new class AppCacheUpdateRequestBase which provides the interface which is implemented by the URLRequest and URLLoaderClient subclasses. This interface is used by the URLFetcher and the AppCacheUpdateJob. 2. Subclasses AppCacheUpdateURLRequest and AppCacheUpdateURLLoaderRequest. These implement the URLRequest and URLLoaderClient portion of the update functionality. The URLRequest one is fully functional at this point. 3. I have left most of the reading and updating logic unchanged in URLFetcher unchanged. Will revisit this when I start working on the URLLoaderClient functionality. 4. The AppCacheUpdateURLRequest subclass maintains a pointer to the URLFetcher base and invokes its methods when it receives a response/redirect notification/data, etc. BUG=715632 Change-Id: I16497e41aa5dbfab0c06c1ab0fc114945dd279e8 Reviewed-on: https://chromium-review.googlesource.com/592809Reviewed-by:
Michael Nordman <michaeln@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ananta Iyengar <ananta@chromium.org> Cr-Commit-Position: refs/heads/master@{#491147}
-
Aaron Leventhal authored
Bug: 748318 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ieec84f84713dafde7e6186367032a09eb18af3f6 Reviewed-on: https://chromium-review.googlesource.com/584169 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#491146}
-
Tom Anderson authored
R=dpranke@chromium.org CC=thakis@chromium.org Change-Id: I6ed223a1fe08fa95837156ae9f4800acf7396524 Reviewed-on: https://chromium-review.googlesource.com/592512Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#491145}
-
Danyao Wang authored
Transient URL rewriters do not make sense for lazily synced navigation items. Refactoring them out of CreateNavigationItemWithRewriters allows GetItemAtIndex() to maintain its const contract. There is no behavior change for LegacyNavigationManager or CRWSessionController. The new behavior only affects WKBasedNavigationManager. Bug: 734150 Change-Id: Id39ef8151b268f44b2179977da5cc8ace10fafbe Reviewed-on: https://chromium-review.googlesource.com/590150 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#491144}
-
Dave Schuyler authored
This CL removes the i18n-content on the <title> (afaik it was not being set so I removed it rather than converting to $i18n{title}). Also removes strings.js and i18n_template.js which should be unneeded at this point. Bug: 677338 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iab29f07c23d200ed824f4207199853d982eefff2 Reviewed-on: https://chromium-review.googlesource.com/585769Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#491143}
-
Dale Curtis authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/a53b8db56039..bcaa25858745 $ git log a53b8db56..bcaa25858 --date=short --no-merges --format='%ad %ae %s' 2017-07-31 dalecurtis [mov] Bail when invalid sample data is present. Created with: roll-dep src/third_party/ffmpeg Bug: 750009 Test: asan test case now passes Tbr: wolenetz Change-Id: I565568cdabf61533b5a0527ab73e9d2c8ba3fdc2 Reviewed-on: https://chromium-review.googlesource.com/595167Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#491142}
-
Eric Roman authored
Netscape Server Gated Crypto (2.16.840.1.113730.4.1) is a deprecated mechanism that is still in use by some unexpired (intermediate) certificates. It is not part of the RFC 5280 profile for internet PKI. This change adds a warning for the chain(s) in the certificate that are relying on nsSGC in place of server auth. Bug: 733403 Change-Id: I2994f7f5e2981eecf24bb9839e266d4292cad7f8 Reviewed-on: https://chromium-review.googlesource.com/593207Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#491141}
-
Marijn Kruisselbrink authored
Pass a mojo BlobPtr in addition to the uuid in all the IPCs/mojo calls for the cache and fetch APIs to make sure the blobs stay alive long enough. Since the cache and fetch APIs largely pass around their parameters in a copyable struct (mostly passed by const reference) this also required introduction of a storage::BlobHandle type, a ref-counted wrapper around a BlobPtr. The BlobPtr passed along in IPCs/mojo messages isn't actually used for anything other than lifetime management at this point. The browser side code still uses the UUID to actually look up the blob and get its data. Also add service worker and fetch tests to the mojo blobs virtual test suite to make sure this all works correctly. Bug: 740744 Change-Id: I6bfcda977cd605099bd6c04d9f079ce7783b43f4 Reviewed-on: https://chromium-review.googlesource.com/567549Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#491140}
-
Joy Yu authored
Add a new member variable LayoutTableCell::is_spanning_collapsed_row_ so that there is no need to access LayoutTableSection::RowHasVisibilityCollapse in LayoutTableCell. This avoids using the memory that has already been freed. Bug: 750016 Change-Id: I1838a775f3b45315b2dee3e15942af0dff0c5955 Reviewed-on: https://chromium-review.googlesource.com/594935Reviewed-by:
Morten Stenshorne <mstensho@opera.com> Commit-Queue: Joy Yu <joysyu@google.com> Cr-Commit-Position: refs/heads/master@{#491139}
-
Yuly Novikov authored
conformance/extensions/oes-texture-float-with-video.html conformance/textures/image_bitmap_from_video/* conformance/textures/video/* On Win10 NVIDIA Quadro P400 D3D9 BUG=750896 TBR=kbr@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I56d7e5e5b052d351fe30b0d775da9bf431be8d23 Reviewed-on: https://chromium-review.googlesource.com/595158 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#491138}
-
rdevlin.cronin authored
Migrate the ActivityLog and related classes away from posting tasks to and checking that they are currently on the content::BrowserThread::DB thread, and replace this with a singleton SequencedTaskRunner to be used in the activity log. BUG=689520 Review-Url: https://codereview.chromium.org/2980503002 Cr-Commit-Position: refs/heads/master@{#491137}
-
Matt Menke authored
There are also some suppressions for tests with the same test fixture. TBR=rdsmith@chromium.org NOTRY=true Bug: none Change-Id: I8b15460c0725525b1d6510c6f00852a3afb59f6f Reviewed-on: https://chromium-review.googlesource.com/596798Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#491136}
-
Raymond Toy authored
Keep nodes alive when there are no input connections so that the node has time to flush out any internal memory. When the output of the node is going to be disabled (because there are no inputs), place the node on a list, without disabling the output. The list is processed every rendering quantum to see if the tail time of node has passed. If the tail time has not passed, nothing is done; otherwise, the output is disabled, and the node is removed from the list. This allows the node to be collected, if possible. Bug:357843 Test:AudioNode/tail-processing.html,DynamicsCompressor/dynamicscompressor-clear-internal-state.html, internals/cycle-connection-gc.html Change-Id: Iab28ec749ee532cbb2ee9631501a6dac0ceb0afb Reviewed-on: https://chromium-review.googlesource.com/583587Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#491135}
-
Helen Yang authored
Previously, unit tests for bubble_util overrode the ICU default locale in order to test methods in LTR/RTL. This caused CardStackLayoutManagerTest to fail on bots. This CL fixes the issue by removing default locale overrides from bubble_util unit tests, and instead adds an |isRTL| parameter to the relevant util method to make it more testable. Bug: 750865 Change-Id: Ia53f92c8a08636c8c56519306b9347e8b425a37f Reviewed-on: https://chromium-review.googlesource.com/596673 Commit-Queue: Helen Yang <helenlyang@google.com> Reviewed-by:
Rohit Rao (ping after 24h) <rohitrao@chromium.org> Reviewed-by:
Gregory Chatzinoff <gchatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#491134}
-
Adithya Srinivasan authored
The OmniboxViewTests are currently flaky, see the associated issue for more details. TBR=jdonelly@chromium.org Bug: 751031 Change-Id: I051f5ad400b4ab729c45e7b2c77365d1dba45356 Reviewed-on: https://chromium-review.googlesource.com/596927Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#491133}
-
Bret Sepulveda authored
Restores the OnFocus > SetChecked line in RadioButton removed in https://chromium-review.googlesource.com/c/547075, which is required to let the user move the radio selection with the arrow keys. Bug: 749014 Change-Id: I861f64b3abbcaac2ec762c7014e5b5e6bee8965b Reviewed-on: https://chromium-review.googlesource.com/595231Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#491132}
-
Lucas Furukawa Gadani authored
Receiving events before attachment can cause races, as the guest may not have a RenderFrameProxy. Bug: 747125 Change-Id: I01a20215a7ee04f657ff8e65f70d562c87a33887 Reviewed-on: https://chromium-review.googlesource.com/591931Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491131}
-
Danyao Wang authored
This is a reland of 2c0e1ed7 Renamed CRWNavigationItemHolder's |-setNavigationItem| to |-replaceNavigationItem| to fix xcode_clang error. Original change's description: > [Nav Experiment] Associate NavigationItem with WKBackForwardList. > > Added WKBasedNavigationManagerTest for implementation-specific test > cases. The majority of WKBasedNavigationManagerImpl can be tested > using NavigationManagerTest. This will be enabled in a subsequent CL. > > Bug: 734150 > Change-Id: Ief59f397a72fd5bb1404e94a58486fa3daa87780 > Reviewed-on: https://chromium-review.googlesource.com/580628 > Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Danyao Wang <danyao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#490117} Bug: 734150 Change-Id: I277c048478a9a0fa9aea2962d10b56059d84fc5b Reviewed-on: https://chromium-review.googlesource.com/592273 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#491130}
-
Wenzhao Zang authored
The texts of the first step (launcher) of Welcome App should be customized based on if voice interaction (Assistant) is enabled. Bug: 750941 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2d53c2e5c8e6e0d579f1564c7793d27fde96d172 Reviewed-on: https://chromium-review.googlesource.com/595111 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#491129}
-
David Reveman authored
Update origami monkey animation with version that seamlessly loop. BUG=750461,721647 TBR=stevenjb@chromium.org Change-Id: I071aa14517eb11708cc6f6e17084ee57dec61ff9 Reviewed-on: https://chromium-review.googlesource.com/596773Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#491128}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/7516c2775c30..249ee1f985b4 $ git log 7516c2775..249ee1f98 --date=short --no-merges --format='%ad %ae %s' 2017-08-01 mtklein clamp to 0 in repeat and mirror image tilers 2017-08-01 brianosman Guard against D3D NaN/Infinity literals bug 2017-08-01 ethannicholas support for 'half' types in sksl, plus general numeric type improvements 2017-08-01 bungeman Assert text passed to canvas is initialized. 2017-08-01 mtklein Add Perf-Win2k8-Clang bots. 2017-08-01 liyuqian Revert "Revert "Revert "Add support for semaphores to be inserted on GrContext flush""" 2017-08-01 bsalomon Allow RegionOp to be used for stenciling 2017-08-01 brianosman Remove unused code for index 8 2017-08-01 robertphillips Roll ANGLE 2017-08-01 egdaniel Revert "Revert "Add support for semaphores to be inserted on GrContext flush"" Created with: roll-dep src/third_party/skia BUG=749260,750070,750071,750072 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: I7026762d2d4d4c8423e909c82f6f0216f5aaebb1 Reviewed-on: https://chromium-review.googlesource.com/596829Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#491127}
-
Jamie Walch authored
This reverts commit 26c8b12c. Reason for revert: Compile Failure on official.desktop.continuous TRUNK Builder - Linux 64 Original change's description: > Implement wait-for-logs functionality in user_session binary > > This ports the wait_for_logs method from the Python script, and forwards > the pipe write fd to the Python script. > > Change-Id: Ief54da136894cd13e0761b9755aa3c7d51fe17f8 > Reviewed-on: https://chromium-review.googlesource.com/594807 > Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org> > Reviewed-by: Jamie Walch <jamiewalch@chromium.org> > Commit-Queue: Erik Jensen <rkjnsn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491058} TBR=jamiewalch@chromium.org,lambroslambrou@chromium.org,rkjnsn@chromium.org Change-Id: I2f9a0a404554ffc08402b573ae3e59bfc9f36f9b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/597027Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#491126}
-
Derek Cheng authored
When the NewPresentationCallbackWrapper is being destroyed, the mojo callback is invoked to satisfy Mojo. This patch fixes the PresentationError that it is invoked with to correctly reflect the fact that the frame is being navigated or destroyed. Note that this behavior is most likely invisible to the page anyway since the page is going away when the callback is invoked. Change-Id: If9428420727d5809f985fff8169fc9d8ed075703 Bug: Reviewed-on: https://chromium-review.googlesource.com/595348Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#491125}
-
Ian Clelland authored
The serialized frame is now represented as a WebVector<char>. BUG=568803 Change-Id: I2e7dd9166a27cd29d1f6e5887d21e1cc439345f5 Reviewed-on: https://chromium-review.googlesource.com/579869Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#491124}
-
Scott Haseley authored
The current SwapMetricsObserver implementation combines how and how often swap metrics are updated with the client side consumption of the metrics. This CL splits the computation and frequency of swap metrics with clients wishing to use the metrics, allowing a single implementation of platform-specific computation while enabling multiple independent observers. Additionally, the API is moved to content/public/browser so it can be used by clients outside of content/browser. Much of SwapMetricsObserver has been moved to SwapMetricsDriver, which drives the collection of the metrics. The SwapMetricsDriver notifies an associated SwapMetricsDriver::Delegate about metrics updates. There is one 1-1 relationship between drivers and delegates; each driver has one delegate scoped at its lifetime. The driver controls the frequency at which metrics are updated, and we assume different clients will sample at different frequencies or over different intervals, which requires multiple driver instances. The existing periodic experimental UMAs have been moved to SwapMetricsObserverUma. Bug:chromium:740625 Change-Id: I66d8cdf3c06ebadba31044ff203fdd803094157f Reviewed-on: https://chromium-review.googlesource.com/565346 Commit-Queue: Scott Haseley <shaseley@google.com> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#491123}
-
Etienne Pierre-Doray authored
Bug: 751215 Change-Id: I5c7e2978528b690fa41f2ca8483b3a98ff264609 Reviewed-on: https://chromium-review.googlesource.com/596907Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#491122}
-
Trent Apted authored
This reverts commit 27e05838. Reason for revert: Makes the test flaky on other macOS versions Original change's description: > Fix WidgetTest.ChildStackedRelativeToParent on 10.13 > > Since 10.13, a trip to the runloop seems to be been necessary to ensure > [NSApp orderedWindows] updates inside WidgetTest::IsWindowStackedAbove(). > Since tests using this are only concerned with relative ordering of > windows in the same process, flushing the run queue here shouldn't cause > flakiness. > > Bug: 749905 > Change-Id: I2fdd42994f759613d91458bf4c2d15cb20cf3c65 > Reviewed-on: https://chromium-review.googlesource.com/590332 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: Trent Apted <tapted@chromium.org> > Cr-Commit-Position: refs/heads/master@{#490911} TBR=tapted@chromium.org,rsesek@chromium.org Change-Id: I65b91a0185047ea45bfdf91d5aec4d25a722347a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 749905 Reviewed-on: https://chromium-review.googlesource.com/596987Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#491121}
-
Nico Weber authored
We most care about having release MSVC builds working, so make that the configuration we test on the main waterfall. Bug: 751198 Change-Id: I3d939b50351bd3112a9b079a87087e2a729394f8 Reviewed-on: https://chromium-review.googlesource.com/596747Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#491120}
-
Geoff Lang authored
https://chromium.googlesource.com/angle/angle.git/+log/40ac783..5788d24 BUG=chromium:750685 TBR=jmadill@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I9c2a7b8795d7dbe7e7a7c08597f03af846227530 Reviewed-on: https://chromium-review.googlesource.com/596727Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#491119}
-
David Benjamin authored
Until we do https://crbug.com/458365 and remove the global session cache, consumers making SSLClientSockets with the default empty shard should not enable session caching, as they'll interact with other sockets which do that. Bug: 458365 Change-Id: Ib8bb5cc6fb51240c4e9a89184ab51775e9653168 Reviewed-on: https://chromium-review.googlesource.com/595155 Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#491118}
-
John Bauman authored
If the video processor input is YUV but marked as being in SRGB colorspace, then NVIDIA treats it more like BT.601 and Intel treats it more like BT.709. This test only cares that there's no crash, so it should ignore the precise output color in this case. Bug: 750784 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I36ce482bfe5cbe79338b485ce5b573e1b170999e Reviewed-on: https://chromium-review.googlesource.com/595131Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: John Bauman <jbauman@chromium.org> Cr-Commit-Position: refs/heads/master@{#491117}
-