- 20 Jan, 2020 40 commits
-
-
Albert Chaulk authored
GRPC appears to barf if Finish() is called on a stream that is still active on the read side. The intent was to allow shutting down by cast_shell at any time, however we have to wait until both read and write are inactive Call OnError() at any time from any thread, sets errored_ The flows now are If this happens between a read completion and the start of the next read - If send_pending_ is false, ReadComplete calls Finish - Else, read_pending_ becomes false - Later, WriteComplete will call Finish If the read has started and a write is pending - If the write finishes first, sets send_pending_ false -- Then, the read completion will call Finish - If the read finishes first, sets read_pending_ false -- Then, the write completion will call Finish A consequence of this is that we can now only shut down most of the time after the next message from the client is received Bug: b/146500172 Test: with patch 1985810 Change-Id: I51df0503b412f86e888143eecae76b6610762552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008367 Commit-Queue: Albert Chaulk <achaulk@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#733445}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/900f1f215dee..bb76282b5443 Created with: gclient setdep -r src-internal@bb76282b5443 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:989667 Tbr: jbudorick@google.com Change-Id: Id66a72545bf5b1bf81e5090f1512532736c81a25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011211Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733444}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fa9410e8e8a6..cbab43ca0aa3 git log fa9410e8e8a6..cbab43ca0aa3 --date=short --first-parent --format='%ad %ae %s' 2020-01-20 tvanderlippe@chromium.org Typecheck Trie.js with TypeScript Created with: gclient setdep -r src/third_party/devtools-frontend/src@cbab43ca0aa3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I918401305b15c2805c448f43577b693c9b65818a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011210Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733443}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c5af6931c0ed..e5aad3baed2b git log c5af6931c0ed..e5aad3baed2b --date=short --first-parent --format='%ad %ae %s' 2020-01-20 lalitm@google.com bazel: add indirection layer for public visibility 2020-01-20 lalitm@google.com Merge "perfetto: don't enable perfetto before running tests" 2020-01-20 lalitm@google.com Merge "trace_processor: make slice stack ids safe for JS" 2020-01-20 lalitm@google.com Merge "trace_processor: add flamegraph virtual table" Created with: gclient setdep -r src/third_party/perfetto@e5aad3baed2b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I19c839771a8b37a8d84fa56bc98c1a05e08aea76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011145Reviewed-by:
-
Denis Kuznetsov authored
By polymer specification all styling should be done inside <template> element. Preprocessor embeds <link rel="stylesheet"> into resulting HTML. Bug: 955194 Change-Id: I91cbadf0b73cc771619a9041e2f7c662199f3740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010773 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#733441}
-
Kevin Schoedel authored
Bug: b/147496970 Change-Id: Iea93191737ff06d4d4844b16a7ab38ecb0d50a10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011163Reviewed-by:
-
Aaron Krajeski authored
Because we don't return the skia canvas when the context is lost we can invalidate the save stack if we save on our end. This is testable (https://bugs.chromium.org/p/chromium/issues/detail?id=1035224) but only with the --enable-experimental-web-platform-features flag. Bug: 1035224 Change-Id: I0048dc5c9e26908b5568173aa6431adc11a013b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002929 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#733439}
-
Nazerke authored
This CL updates AppLauncherCoordinator to use the browser-based initializers, and updates unit tests. Also this CL converts AppLauncherCoordinator to ChromeCoordinator subclass. Bug: 906541, 1029346 Change-Id: I327200dd6d7dfbfb9fa032e719996aa319233723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010863Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#733438}
-
Anqing Zhao authored
According to the suggestion from jennschen@ during ChromeOS-UXImpl review: we don't say 'Android applications' anywhere in the settings UI but instead use Play Store terminology and iconography. Therefore, the corresponding description and icon need be changed. Bug: 1010213 Change-Id: I96f2e6c73c295c53dd68a624d281e0e14c7edf16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010945Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Anqing Zhao <anqing@google.com> Cr-Commit-Position: refs/heads/master@{#733437}
-
Maksim Ivanov authored
This is a pure cleanup CL. It replaces the use of "position: absolution" in the smart card SAML PIN dialog (a.k.a. the security_token_pin dialog) with the normal positioning. This makes the implementation less fragile against future changes, as it doesn't rely on the absolute coordinates of the PIN input field and its sizes anymore. Bug: 1024251 Test: take screenshot of the SAML smart card PIN dialog before and after the change, check they're equal Change-Id: Ibce4d99d07016ef9437782ba528c7e3c2744b799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007647Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5546abd6b001..c533f76b91f8 git log 5546abd6b001..c533f76b91f8 --date=short --first-parent --format='%ad %ae %s' 2020-01-20 phoglund@google.com Fix dev_server (method disappeared after recent refactoring). Created with: gclient setdep -r src/third_party/catapult@c533f76b91f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029452 Tbr: sadrul@google.com Change-Id: I572b2fb36108b211152f423d7e168edd6100a30a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011141Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e54bb9023e14..900f1f215dee Created with: gclient setdep -r src-internal@900f1f215dee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I9dcf2b09d42b5a6cf056748bd7f77903b874eac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011128Reviewed-by:
-
Henrique Nakashima authored
Use SharedPreferencesManager consistently instead of SharedPreferences directly. Move the usages to methods in SigninPreferencesManager. Bug: 1022108, 1034960 Change-Id: I24b5d9f20d847e7c3c8573b0cd7e712e114e3d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988603 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#733433}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/85de0bc72ef7..fa9410e8e8a6 git log 85de0bc72ef7..fa9410e8e8a6 --date=short --first-parent --format='%ad %ae %s' 2020-01-20 aerotwist@chromium.org Updates Chromium builds Created with: gclient setdep -r src/third_party/devtools-frontend/src@fa9410e8e8a6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1043142 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id92393c4f6cbc78217e772660cb3378b25e3a426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011140Reviewed-by:
-
Oleg Davydov authored
This commit does the following changes in order to better collect data about content verification, detection of extension corruptions and reinstalling corrupted policy-based extensions: * Extensions.ContentVerification.ComputeHashesOnInstallResult. A new histogram which collects success rate of computing hashes (required for content verification) during installation. Not collected when hashes were not computed. * Extensions.ContentVerification.ComputeHashesOnInstallTime. A new histogram which collects time spent on computing hashes, if it was successful. * Extensions.CorruptPolicyExtensionDetected3. An upgrade of previous version of this histogram, now it collects not only number of extensions scheduled for reinstall, but also a brief information about decision: was it extension from Chrome Web Store or not, or was it just an extension without hashes, so we need to reinstall it to compute ones. Note that corruption detection for off-store extensions is not enabled yet. So these histograms are mostly unused by now, but will be in the future. Bug: 958794 Change-Id: Idc38de1300204cafe00210507519ebaf20c2057e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998401 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#733431}
-
Jonathan Backer authored
Change-Id: Ia4c19af1a17a3938fba396253e989aefc6495789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976554 Commit-Queue: Jonathan Backer <backer@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Auto-Submit: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#733430}
-
Dave Tapuska authored
The gfx types can be used natively inside blink so we don't need to typemap them. This will allow us to progressively remove the platform types. BUG=640049 Change-Id: I028e4f4c6cd806661bbc74078e0a0d0c91609a8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007279Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#733429}
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=msarda@chromium.org Bug: 1042208 Change-Id: I0b00fde7e51ad9084d8bf00e1113137260971556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007587 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#733428}
-
Stepan Khapugin authored
Reparents signinInteractionCooordinator and cleans up guts interfaces. Note the new method in SceneControllerGuts that allows MC to cleanup a SC before shutdown. I think this is fine at least temporarily, but we need to iron out how this happens in iOS 12 compat in the future. Bug: none Change-Id: Ie214b60b830548f1aaec56207298cdf6ba6ddd3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007051 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
Nina Satragno authored
Test is flaky, e.g.: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/1958 TBR=csharrison@chromium.org Bug: 1043619 Change-Id: I1a3356592a50c3cb3018bd0a490547188f0c1137 No-try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011164Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#733426}
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=msarda@chromium.org Bug: 1042208 Change-Id: I5e7941be37469d17ae0610fb475ae10533cd79f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010788 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Ewann authored
- Replaces UIDocumentInteractionController by UIActivityViewController to allow custom actions. - Adds @OpenDownloadsFolderActivity. - Adds eg2 tests. Bug: 1013572 Change-Id: I29b74036151b5206ee99f2deb311046d1aaf6eb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884550 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#733424}
-
Rob Buis authored
This commit adds new constraints to NGConstraintSpace to indicate the "target" inline/block size to which the unique operator in the sub tree should try to stretch. See https://mathml-refresh.github.io/mathml-core/#dfn-inline-stretch-size-constraint Bug: 6606 Change-Id: Ia7b8d9c1b153d6e55ce5fa5f6a716fa26f0e9a2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911741 Commit-Queue: Rob Buis <rbuis@igalia.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#733423}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b6cc6e6bb8d3..c5af6931c0ed git log b6cc6e6bb8d3..c5af6931c0ed --date=short --first-parent --format='%ad %ae %s' 2020-01-20 lalitm@google.com Merge "trace_processor: don't create a sorted cache table for sorted cols" Created with: gclient setdep -r src/third_party/perfetto@c5af6931c0ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: If820deea15c584245f354b4a216d99adcb896ba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010271Reviewed-by:
-
Patrick Monette authored
After a bad git rebase, I mistakenly reverted part of a previously landed CL in a subsequent one. This is the CL that was partially reverted: https://chromium-review.googlesource.com/c/chromium/src/+/1990211 This is the CL that did the partial revert: https://chromium-review.googlesource.com/c/chromium/src/+/1988831 Also, I had to fix a test that was added since then. Bug: 1040794 Change-Id: Icb662bd0bee94917ba2bc59b20e63289ca9d3247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008148Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#733421}
-
Nina Satragno authored
This reverts commit ed985006. Reason for revert: I suspect this is the cause of several flaky tests on mac, see crbug.com/1043665 Original change's description: > [SyncSetup]: Change Sync everything to a radio behaviour. > > As part of friendly settings, this CL implements changing |sync > everything| from check box to radio button. The motivation behind this > work is to clarify to users the difference between |Sync everything| > checked and |Sync everything| unchecked but all single data types > checked. > > Bug: 1043122 > Change-Id: I579b8173a7b32f1416a3b1eda999196d177a2b5c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007730 > Commit-Queue: Monica Basta <msalama@chromium.org> > Reviewed-by: Dan Beam <dbeam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#733286} TBR=dbeam@chromium.org,msalama@chromium.org Change-Id: Ibe071bf447abb103d3ae801069cf1f27a9123c67 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1043122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011168Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/24def43af03b..e54bb9023e14 Created with: gclient setdep -r src-internal@e54bb9023e14 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I4265c25e445e835547d0d7f138235877c53feb28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010270Reviewed-by:
-
Sebastien Marchand authored
Bug: 1030399 Change-Id: I98304a72ef053569988d82efacfb564f25d4717c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007981 Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#733418}
-
Tanmoy Mollik authored
SyncManualStartAndroid has been rolled out. This cl removes the flag and code no longer needed. Bug: 1038725 Change-Id: I645fcf0c2c2ca1d2702ce9755870b28f27e02bae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989526Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium c738d46c. With Chromium commits locally applied on WPT: 0f8fd66b "[WPT/common/security-features] Support sub projects and split referrer-policy 4K tests" b4420ced "Revert "Update timeout and split slow COOP WPTs"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I88d141245a54c2c47c242ad26b85943f2665e2a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010924Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733416}
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=msarda@chromium.org Bug: 1042208 Change-Id: I0f478927d6a539c273c124437d83851e69a138b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010820 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b56d35e2..ebf1fafe Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I351ed0ca2587576c3ce9597b4eafe3fb2bdcdca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010925Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733414}
-
Piotr Bialecki authored
This is a reland of 3e21b750 Additional fix needed for a reland: This change prevents the inclusion of ARCore-related entries to the manifest when enable_arcore is false (for example for x86 builds). Changes: - include_arcore_manifest should be equal to enable_arcore on targets that have ARCore support (monochrome, trichrome, but *not* chrome_modern, chrome) - trichrome.gni entry should not be needed since the variables for both monochrome and trichrome are set in monochrome_public_apk_or_module_tmpl Validated with chrome APK, chrome_modern bundle, monochrome bundle and trichrome_chrome bundle, both for arm and x86. This change *must* land at the same time as https://crrev.com/i/2428538, otherwise the push to Play Store will fail. Original change's description: > Reland "Move away from using DFM to distribute AR-related code" > > This is a reland of cd842897 > > Original CL caused Chrome Canary to be rejected from Play Store. > Play Store validates whether ARCore SDK's manifest entries are present > only for applications that contain entry about ARCore being either > required or optional. > > Additional changes needed for reland: > - ArCoreShimImpl.java should not be included in java_sources - it will > be brought in by ar_java target on supported configurations since > it depends on ARCore SDK which is included only for specific targets > - relaxed the change in arcore_consent_prompt.cc - the original change > would cause builds that are not supporting ARCore (by design) to > crash > > Original change's description: > > Move away from using DFM to distribute AR-related code > > > > This change will make Chrome for Android stop using DFM to ship the > > ARCore SDK. This is done to enable us to provide AR experiences for > > apps using WebView. The changes are introduced in a way to enable us to > > switch back to using AR DFM if need be. > > > > Changes summary: > > - chrome_java target (defined in chrome/android/BUILD.gn) now also > > compiles ArCoreShimImpl.java (see java_sources.gni) - this means that > > java parts from ARCore SDK have to be added to its deps > > - libarcore_sdk_c.so needs to be listed in loadable modules - this is > > done in monochrome_public_common_apk_or_module_tmpl (only if target > > is a base module when ARCore is enabled) > > - AndroidManifest.xml no longer needs to contain the min_apk_version > > and InstallActivity entries explicitly - they will be brought in > > auto-magically by the build system and were needed only because > > manifest merging did not work for DFMs > > - ArCoreInstallUtils (java) should never report that we can request > > installation of AR DFM > > - ArCoreConsentPrompt (native) should never think it needs to request > > installation of AR DFM > > - Added a DCHECK and graceful handling of null jstring for java_path > > (path to ARCore SDK .so) - it can be null if loadable_modules do not > > contain correct entry - with the DCHECK, debug builds will still > > crash but the release builds should just report that the WebXR > > specified session configuration (session mode == "immersive-ar") is > > not supported > > > > Binary-Size: Tracked in crbug/1040289 > > Bug: 1031623, 1040289 > > Change-Id: Ia2f305d1685f1c7207cc187d253f59a6331c36fc > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988834 > > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > > Reviewed-by: Alexander Cooper <alcooper@chromium.org> > > Auto-Submit: Piotr Bialecki <bialpio@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#729818} > > Binary-Size: Tracked in crbug/1040289 > Bug: 1031623, 1040289 > Change-Id: I87eac0bc3748973e22190c6dba1187e822f83082 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995769 > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Alexander Cooper <alcooper@chromium.org> > Commit-Queue: Piotr Bialecki <bialpio@chromium.org> > Cr-Commit-Position: refs/heads/master@{#731011} Binary-Size: Tracked in crbug/1040289 Bug: 1031623, 1040289 Change-Id: I90d7f6554026bf41c248a8d06f38963534efee28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003765Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#733413}
-
David Munro authored
Autogenerate Polymer 3 version of cr_slider and tests. Bug: chromium:858815 Test: browser tests Change-Id: Ied01457e7b404400c277149539c9bbb6d630ad10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004184 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Auto-Submit: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#733412}
-
Sadrul Habib Chowdhury authored
tdanderson@ and bruthig@ no longer work on chromium. So remove them from owners for various metrics. BUG=none Change-Id: Id766f74f7c8db452261f4ae9b321a92f9a98d93f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972243 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#733411}
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=droger@chromium.org Bug: 1042208 Change-Id: I2bd103df8e48cd777203961ebad5019f92b6d978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010765 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#733410}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9fbe9ae1c109..61380c09e241 git log 9fbe9ae1c109..61380c09e241 --date=short --first-parent --format='%ad %ae %s' 2020-01-20 srte@webrtc.org Cleanup of rtc::Thread. 2020-01-20 danilchap@webrtc.org in RtpPacket packet pass rtp header extension value by const& 2020-01-20 danilchap@webrtc.org Remove unit_base functions FromStaticX 2020-01-20 hbos@webrtc.org [Overuse] MaybeUpdateTargetFrameRate() & ResetVideoSourceRestrictions() 2020-01-20 ivoc@webrtc.org Reland "Enable using a custom NetEqFactory in simulations" Created with: gclient setdep -r src/third_party/webrtc@61380c09e241 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Id0c285c841cf152aba530dd5e89ab5acc46b61c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008267Reviewed-by:
-
Nicolás Peña Moreno authored
This CL adds the equivalent to element-timing/multiple-redirects for LargestContentfulPaint. Since we use get-host-info instead of the .sub commands, the .sub in the name is unneeded. This CL also updates the expectations for disabled-OOR-CORS: the recent TAO tests will fail without this flag enabled. Bug: 1003943, 1042580 Change-Id: Ibc0b79d4c548fdbe9dc3eab6bd810f5a92425b35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010176Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#733408}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5d3c6c53932a..b6cc6e6bb8d3 git log 5d3c6c53932a..b6cc6e6bb8d3 --date=short --first-parent --format='%ad %ae %s' 2020-01-20 buss@google.com Fix compilation on Windows/VSC. Created with: gclient setdep -r src/third_party/perfetto@b6cc6e6bb8d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I02906d529a2e57da2cd6f6865e0b3ad8461803f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008266Reviewed-by:
-
Gauthier Ambard authored
Bug: none Change-Id: I17614a11b718a226bf00591596f378a4a3d44575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007638 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#733406}
-
