- 15 Apr, 2020 40 commits
-
-
Clark DuVall authored
This is used by ContentSettingsAgentImpl to query for storage permissions in the browser process. Bug: 1065537 Change-Id: Idd8176bf801c6636559304c6d23ce6c6b1237405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145257 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#759436}
-
Kevin Babbitt authored
The Microsoft Edge team has reports of a null dereference crash showing up in automated usage testing. The symptom is that, while responding to a UIA Navigate call, we check to see whether the navigated-from element is the child of a fragment root. We come across an entry in the fragment root map from the element's HWND to a null fragment root pointer, dereference that null pointer, and crash. It's not expected that we'll ever have such an entry - the map is supposed to map HWNDs to non-null fragment roots. From the crash data we have, the exact sequence of calls leading up to this scenario is unclear, but I was able to reproduce one way it can occur and captured it in a unit test. The fix for the issue is, when looking up an entry in the map, use unordered_map::find() rather than operator[], the latter of which will create an entry if one doesn't exist. Bug: 1071185 Change-Id: I5f04188e849ffc0969762d870b80603d4b7e15b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148850Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#759435}
-
Alex Danilo authored
Text display with selection mode active should be blue and 14px size. Moves the non files-ng 'color' property to only apply when needed. Adds a files-ng selector for the check-select class to set the 'color' and 'font-size' properties. Bug: 1068079 Change-Id: Id0d332e6bca42c5176ce8424d4faa9ca066e0fbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150314Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#759434}
-
Hailey Wang authored
Add a more throughout browsertest in addition to the basic browsertest. Bug: 1059341 Change-Id: I0c1b5facf5d77914777462f69083070c01a2ad03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149634 Commit-Queue: Hailey Wang <haileywang@google.com> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#759433}
-
Adrienne Walker authored
The two important changes here are: (1) Call DeleteBlobsInObjectStore before RemoveRange If RemoveRange is called first, then DeleteBlobsInObjectStore cannot find all of the blobs to add to the external change map, and thus CollectBlobFilesToRemove will have nothing to remove. (2) Exclude the BlobEntryKey index from RemoveRange If this is removed in ClearObjectStore, then CollectBlobFilesToRemove will not be able to find the blobs (and their numbers) when decoding the external objects. These entries will be individually removed in CollectBlobFilesToRemove. Bug: 488851 Change-Id: I8dc9cd0208054d482006718ab42c439cf5f79382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148847 Commit-Queue: enne <enne@chromium.org> Auto-Submit: enne <enne@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#759432}
-
Oriol Brufau authored
When finding the intrinsic sizes of a grid container, track sizing functions that contain percentages would be indefinite, and thus should be treated as 'auto'. This is done in GridTrackSizingAlgorithm::CalculateGridTrackSize, but there was an early return if the grid container had size containment. Then, instead of being treated as 'auto', the track sizing function used to just resolve the percentage against 0. Additionally, a track sizing function of '1fr' is supposed to be treated as 'minmax(auto, 1fr)', since only max track sizing functions can be flexible. This fixup was also skipped, though this didn't affect the final result. This patch fixes these problems by removing the early return and adding some asserts. BUG=1069310 TEST=external/wpt/css/css-contain/contain-size-grid-003.html TEST=external/wpt/css/css-contain/contain-size-grid-004.html Change-Id: I1b8d8645a3fdf6c697c503184b35cc8cd12925a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144019 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#759431}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4a5bce96e8c2..8ec11b831293 git log 4a5bce96e8c2..8ec11b831293 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 danilchap@webrtc.org Do not register generic frame descriptor v1 in integration tests 2020-04-15 tommi@webrtc.org Reland of the test portion of: Created with: gclient setdep -r src/third_party/webrtc@8ec11b831293 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie67d2bb353b5a7a75cc988e54603acd9c5969389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151078Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759430}
-
bttk authored
Also removes histogram "WrenchMenu.OpeningAnimationFrameTimes" WrenchMenu.OpeningAnimationFrameTimes uses the default "times" histogram, which has 48 exponential buckets for samples in range [1ms; 10_000ms) If we were to use this metric to analyze animation jank, this metric doesn't provide much useful signal about how much longer a frame took compared to the goal (17 ms @60fps, 34ms @30fps). Instead of looking at the delay, we get: * 12 buckets with samples [0ms; 17ms) * a [17ms; 20ms) bucket with ok frame times and sort-of ok late frames * a [29ms; 34ms) bucket with late 60fps frame times and ok 30fps times * a [34ms; 40ms) bucket with both ok frame times and 15% late times * 28 buckets for significant jank [96ms; inf) It would be more useful to measure something like: * "mean time between lost frames", or * "mean time between 100ms jank" Bug: 1069507 Change-Id: Ie59cb20d2e9bda5ffa2673790a8e52dbca734e15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144394Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#759429}
-
Jeffrey Cohen authored
Bug: 1036023 Change-Id: Ic76a51834f2fd1635e768a6974b95db5a6cbda07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151466 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
yilkal authored
This Cl ensures that time limit is reset at the specified time in PATL policy. When the computer wakes up it decides to reset time limit based on the last reset time. If reset time boundary has been crossed because either time has moved forward or backward, chromeos resets the time and saves the current time as the last reset time which will result in wrong reset times in the future. The following is an example scenario where the reset time is 6 am. 1. User opens computer at 1 pm on day 1. There was no reset time before so the computer saves 1 pm day 1 as the last reset time. 2. Computer schedules the next reset time to be on 6 am on day 2. 3. After a few hours of activity, the computer is closed before reaching the correctly scheduled limit. 4. User opens computer at 9 am on day 2. User observes ERROR: -> EXPECTED: time limits are reset because the reset time has been crossed. -> ACTUAL: time limits are not reset until after 1 pm on day 2. This cl corrects the issue seen in step 4. Bug: 1069932 Change-Id: I9cd4ad4c887e2067292612cf1d32c9dd43bafa6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149289 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#759427}
-
Aaron Colwell authored
This change simply cleans up the process that is created in SetUp(). Despite what the comment in SetUp() said, these process objects were not actually being cleaned up during BrowserContext shutdown. As a result these process objects stay alive between tests in a process global map managed by GetAllHosts() in render_process_host_imp.cc. While this doesn't cause any specific problems in the current tests, there is potential for flakiness because state is being maintained across test cases. It also exposes pointers to destroyed BrowserContexts via GetAllHosts() and can enable unexpected matches to old process objects if a previous BrowserContext pointer gets reused in a subsequent test. Explicitly cleaning up the process during TearDown() avoids these issues. Change-Id: Idf879b9f48bc31cfcda20c89925ea2d5f8ff1714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151337Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Aaron Colwell <acolwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#759426}
-
Vladimir Levin authored
This patch does two things: 1. It ensures that when we have percent descendants that cross a display-lock boundary, they are allowed to remain dirty (since the display lock would block the traversal) 2. Ensures that if we force unlock a lock, bookkeeping is properly updated. 3. Adds a missing compositing dirty bit propagation to the DisplayLockContext::Unlock function R=cbiesinger@chromium.org, ikilpatrick@chromium.org Fixed: 1070017 Change-Id: I11e896c59421ad99c7a0a274902053a8787a7aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148823 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#759425}
-
Andrew Grieve authored
Broke when fixing script in stand-alone mode: 96f62d4a Tested that this time it works in both stand-alone mode and for trichrome. Bug: 1069248 Change-Id: I2b3949efa4e6620f40578385247384bf66abe480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147013Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#759424}
-
Alexander Cooper authored
Makes a couple of small cleanup changes that came up as a result of either presubmit warnings or DEPS issues when moving metrics code to content: * Swap two "NULL"s for "nullptr"s * Replace ukm::GetSourceIdForWebContentsDocument with WebContents::GetLastCommittedSourceId Bug: 1031622 Change-Id: Ic41ffa44abe9774b954c78bb6d710720b5632a9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151326 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#759423}
-
rbpotter authored
This allows the manage button to work correctly in Incognito mode. Bug: 929640 Change-Id: Ia0295b1fc6576071a9e5a41fb0723fc121e36eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150692Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#759422}
-
Avi Drissman authored
optipng sometimes finds that using indexed color yields a smaller PNG file. Allow that. Also add a comment to the sRGB code explaining why that value was chosen. Bug: 846451 Change-Id: Ia8d6ef7dba59e4a0a0cbbf4d3122f63c501cfabf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148030 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#759421}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0f1f87d7bd4b..8ac25c44cbe8 git log 0f1f87d7bd4b..8ac25c44cbe8 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 tdenniston@google.com [svg] Improve color value parsing 2020-04-15 brianosman@google.com Cache inverse matrices in SkMarkerStack 2020-04-15 senorblanco@chromium.org Refactor GL and Metal FinishCallback into a helper object. Created with: gclient setdep -r src/third_party/skia@8ac25c44cbe8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: I59f15f6dceaf0742992a4ffdf05e71138e7bda43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151076Reviewed-by:
-
Kurt Horimoto authored
Bug: none Change-Id: Icc5945a0defa2e488275fa2e396c8e6c616b4a14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145956 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#759419}
-
Ian Kilpatrick authored
"text-align: -webkit-center" is a non-standard css property/value pair which has undefined behaviour. This was being used for centering the video controls within the video player when in the "immersive-mode". https://chromium-review.googlesource.com/c/chromium/src/+/1977196 ...changed how the blink's layout codebase handles margins, removing a bug for when "-webkit-center" is set on a child. This patch changes the immersive-mode stylesheet to use: "align-items: center" for centering the controls in their container. It was also necessary to specify the width of the "timeline" to ensure it filled the available space. This also re-enables the disabled test. Bug: 1041904 Change-Id: I6ca530a14185fa0bba8900824cef3b369728e90c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144777Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#759418}
-
Lan Wei authored
After we finish the scroll unification, the scrolls happens mainly on the compositor thread, and the scroll code in the main thread will be removed. eventSender sends the scroll events to main thread, so it would not work after the scroll unification. We should replace eventSender.mouseScrollBy with gpuBenchmarking.smoothScrollBy in all the layout tests, this is part 1. Bug: 1047176 Change-Id: If746d2b7a4b0a031829105115d9c27d46a27cfa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119532 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#759417}
-
Brian Sheedy authored
Adds the necessary mixins to all uses of chrome_public_test_apk so that RenderTests can use the Skia Gold code path if desired. This should have no effect on any existing tests, it simply makes it so that the test runner doesn't blow up if a test tries to use Skia Gold. It currently does so due to necessary args such as --git-revision not being passed, which is fixed by the mixins. Bug: 1057851 Change-Id: Ib924e3df927b770e4b5d9abceae4906a6e358447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151050 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#759416}
-
Willie Koomson authored
This change modifies ArcVmClientAdapter so that arcvm-boot-notification-server upstart job is started during StartMiniArc(). In UpgradeArc(), ArcVmClientAdapter sends upgrade props to the server over the Unix socket. make sure AVCA is able to successfully start and connect to the server. Bug: b:144542975 Test: Build and deploy_chrome. "restart ui", then look at logs to Change-Id: I914770d4639eefd6cf3baa444d0288f0ae8a6dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067613 Commit-Queue: Willie Koomson <wvk@google.com> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#759415}
-
dpapad authored
GetRawDataResource assumes that underlying files are not compressed, whereas LoadDataResourceString automatically decompresses if necessary. This is one of many CLs, in preparation of compressing all HTML, JS, CSS, SVG files by default (meaning without requiring compress="gzip" to be specified). Bug: 1068407 Change-Id: I59e9f8654e85a780d6152b4e2f9e36e34dc84da4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145854Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#759414}
-
sczs authored
I've been trying to figure out why this is happening, my theory is that this is somehow related to swipe down to dismiss (the crash is iOS13 only) and dismissWithURL being called twice (the second time _rootNode might've been niled). Though I'm not sure why this didn't happen on M80 where this behavior existed. So I'm not sure what could've changed that caused this crash. This is a speculative fix, but modifying the code and setting _rootNode to nullptr reproduces the crash stack exactly. Even if we'd know the root cause, I'm not sure we'd want to cherrypick something more complex than this to M81. Bug: 1061882 Change-Id: Ic47449388e57e17c8acc34e104cc297dc8c2638d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147955 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#759413}
-
Peng Huang authored
Skia uses multiple texture units, so we need to reset all sampler units. This is a temporary workaround. We will create GrContext for ES 3.0 soon, after SkiaRenderer + GL is shipped. Bug: 1057271 Change-Id: I38fe243f86e91868226780960ddc997401ea3a1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150816 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#759412}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d5ba916d3c9c..49ad8eaae192 git log d5ba916d3c9c..49ad8eaae192 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 rafael.cintron@microsoft.com Enable allowClearForRobustResourceInit for Intel drivers 2020-04-15 ancheng.qiao@arm.com Add gles1 primtest tests 2020-04-15 timvp@google.com Add 'java_api_finder' to Android.bp Created with: gclient setdep -r src/third_party/angle@49ad8eaae192 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I179525100bbad15bc75e81a393ab7da285e95160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151066Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6732305714ca..bd0ce7c933dc Created with: gclient setdep -r src-internal@bd0ce7c933dc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ricea@google.com,nektar@google.com,guidou@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1070424 Tbr: ricea@google.com,nektar@google.com,guidou@google.com Change-Id: I675f14546bd022bd1370a7f95ff125a787466308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151073Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759410}
-
Jon Mann authored
Previously, the timestamp was only tracking if a network had been connected to on the local device. This prevented us from syncing user updates that were performed before connecting which would be confusing for users. Bug: 966270 Change-Id: I90da43383813c4c1e503b22813a84d1ff4ecf7b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149693Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#759409}
-
Charlie Hu authored
Because feature_policy_helper now contains document_policy related helper functions as well, rename the file to a more general name: policy_helper. Change-Id: I8a6c7d2343ff8ff780e64bef52c8b41d38414022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144040 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#759408}
-
Dale Curtis authored
This reverts commit d888e096. Reason for revert: Issue may be fixed now, lets see! Original change's description: > Disable audio output for media browser_tests on Linux > > Due to problems on some bots failing to start PulseAudio and causing > Chrome startup to hang, disabling audio output for media browser tests > on Linux to avoid the hang. > > Bug: 986021,1023029,1026849,1035472,1049467 > Test: modified browser_tests pass locally > Change-Id: I29a996ee627bc4a5b93e5b8d6227dd7801998d11 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056760 > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Commit-Queue: John Rummell <jrummell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741613} TBR=dalecurtis@chromium.org,jrummell@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 986021, 1023029, 1026849, 1035472, 1049467, 1054560 Change-Id: Iffb9f8299c86d9a1eccb59f3db0e5f16d09b207a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151049Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#759407}
-
Matt Menke authored
We want to get rid of the single argument AddHeader() method as the two argument AddHeader() and SetHeader() methods are safer and more flexible. Bug: 1068194 Change-Id: Id950858f00c584a99af69faab6f70ed4c984db9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150009 Auto-Submit: Matt Menke <mmenke@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#759406}
-
Sigurdur Asgeirsson authored
The serialization ID is slated for removal, and local ID assignment is sufficient for this metrics provider. Bug: 1071090 Change-Id: I73165ae30636a834fc9d1294d3dbf40ed308d48b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150234Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#759405}
-
Erik Staab authored
Bug: 1058963 Change-Id: If7d10216e236282357f88e3cc49a5a2c5b3200a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150395Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#759404}
-
Carlos Knippschild authored
- Rename PERMISSION_DENIED to STORAGE_PERMISSION_DENIED for clarity. - Favor using OfflinePageModel::CanSaveURL when deciding about saving an OP. - Properly reporting metrics for pages that failed being published (new call to OfflinePageModelTaskified::InformSavePageDone). - Removed OfflinePages.SavePageCount which was recording unsuccessful saves too. The same information can be obtained from OfflinePages.SavePageResult. - Adds a new error type to OfflinePages.SavePageResult: incorrect URL. - Consolidates OfflinePages.PublishPageResult as a special case into OfflinePages.SavePageResult. - Renames OfflinePages.SavePageResult to *2 due to the reporting changes described above. - A few more minor changes. This is not a full review of all metrics reporting but covers some bugs I found. There might be more issues to be addressed. Change-Id: I941effe555050b841c90735f6ff66f1641b7255b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138775 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#759403}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9ac89e3e1842..b9ebe017027a git log 9ac89e3e1842..b9ebe017027a --date=short --first-parent --format='%ad %ae %s' 2020-04-15 ilkos@google.com Merge "Incorporate oom victims in the lmk metric" Created with: gclient setdep -r src/third_party/perfetto@b9ebe017027a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I3ec84fd84b44e4ace1f4f01e41a0abd0d92216e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151072Reviewed-by:
-
Clark DuVall authored
This implements basic client hints functionality. Still TODO after this patch to make sure ContentSettingsAgentImpl is working as expected: - Sync content settings to renderer - Add ContentSettingsManager implementation for WebLayer Bug: 1065537 Change-Id: I3a281c2a6a472ba9e1d79ff860d5bb94367cf888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145156 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
-
David Van Cleve authored
There's some global state that the key commitment fuzzer needs initialized, or else it (evidently) crashes. So far, this seems to include ICU and the command line. This change adds a dependency on //net:net_fuzzer_test_support in order to initialize net-relevant global state, including those two. R=svaldez Fixed: 1071130, 1071084, 1071157 Change-Id: If92e8a9e3a7905e0966950cc45576fd9549adca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151105Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#759400}
-
David Black authored
This CL: - Creates public interface for AssistantController - Renames existing AssistantController to AssistantControllerImpl - Updates references This new interface (which exposes a singleton accessor) will be used moving forward to get a handle to the AssistantController from outside of Ash. The most pressing need for this is the new Assistant search provider. Note that this CL doesn't yet add public APIs onto the interface, as I attempted to only make the smallest possible change in this CL. Follow up CLs will migrate public APIs onto the interface as well as remove the existing accessor to AssistantController that is currently exposed through Shell so that we can enforce consistent access to AssistantController through this new public API moving forward. Bug: b:146074655 Change-Id: Id9f414f66fbfc60c90eb5d0c8a9b86681c641da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148098 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#759399}
-
Clark DuVall authored
PathClassLoader may call stat on the library paths, which causes a strict mode violation. We may want to try to move this to a background thread eventually. Bug: 1071119 Change-Id: I51df3ee7bcd3a4bb94d4c0a56a21d97dc9406548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150886Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c6ff53c7..b774f178 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia9aaf0c2c019480b2416035899a64dd1bcd05e5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151205Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759397}
-
