- 10 Nov, 2018 40 commits
-
-
file:///*.svgzChris Mumford authored
A speculative fix for a 7%-19.2% regression of memory use. This change releases the ZLib buffers used for Gzip inflation - releasing the memory as soon as it is no longer needed instead of waiting for the URLResponseBodyConsumer instance to be deleted. This change also fixes an incorrect reset of |zlib_wrapper_|, which was calling release() instead of reset(), when zlib would fail to initialize. This was likely a latent bug and not the cause of the regression. Bug: 901891 Change-Id: I52687f5614b7a76c52f4b9d5317deb33a299e4cb Reviewed-on: https://chromium-review.googlesource.com/c/1317922Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#607124}
-
Chris Mumford authored
Combined the four configuration parameters to RendererConfiguration::SetConfiguration() into a structure to simplify current implementation and future expansion. Bug: 897986 Change-Id: Id931218928c6c3c6bf2e4f52da7605c40dbbfbb7 Reviewed-on: https://chromium-review.googlesource.com/c/1318434Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#607123}
-
Guido Urdaneta authored
This CL introduces two utility functions: 1. RescaleSetFromConstraint: transforms a resizeMode constraint into a set of boolean values for easier processing. The boolean values represent if rescaling is supported or not. 2. IdealRescaleFromConstraint: transforms the ideal value in a resizeMode constraint into an optional bool, which represents preference for rescaling (true), preference for not rescaling (false), or no preference (nullopt). These utilities simplify processing of the resizeMode constraint in getUserMedia() and applyConstraints() for both device and content capture. This support is added in follow-up CLs in this series. Bug: 854980 Change-Id: I0a76fbc2842c5bb0aff8f231d36a404f25ae665d Reviewed-on: https://chromium-review.googlesource.com/c/1310175 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#607122}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4b0662f8875f..bf02135b32e9 Created with: gclient setdep -r src-internal@bf02135b32e9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I3cfd099595656776d06a6ea0d65388947430e8f5 Reviewed-on: https://chromium-review.googlesource.com/c/1330774Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607121}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/17754d54ed77..4b0662f8875f Created with: gclient setdep -r src-internal@4b0662f8875f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I3dc27de3cc84977c20be569bed8367c2d1b5a69e Reviewed-on: https://chromium-review.googlesource.com/c/1330773Reviewed-by:
-
Mario Sanchez Prada authored
As part of the servicification project and the migration to the Identity service, we have removed dependencies on //components/signin/core/browser from many places, but some stale includes and dependencies remained. This patch attempts to clean that up so that we have a better and cleaner surface to work upon when doing the servicification. Bug: 903846 Change-Id: I1f28f1c08047c279dcad60cff4e66945d4e68852 Reviewed-on: https://chromium-review.googlesource.com/c/1329923Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#607119}
-
Lei Zhang authored
PrepareFrameAndViewForPrint::CopySelection() generates HTML + CSS to support printing only the selection. By making it do the generation in print mode, the generated output will have print media CSS applied. BUG=889226 Change-Id: Ia57d4c0429b93d72cb412545eda7579b53570e6c Reviewed-on: https://chromium-review.googlesource.com/c/1308604Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#607118}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5d5091665700..f2c3502f7788 git log 5d5091665700..f2c3502f7788 --date=short --no-merges --format='%ad %ae %s' 2018-11-10 nednguyen@google.com [browser_test_runner] Ensure that skipped tests have skipped expectation if typ expectation file is not used 2018-11-09 benjhayden@chromium.org Add BatchIterator for v2spa 2018-11-09 benjhayden@chromium.org Merge test suite descriptors in v2spa 2018-11-09 benjhayden@chromium.org Add RecommendedOptions to v2spa 2018-11-09 benjhayden@chromium.org Support uploading to dev_appserver.py 2018-11-09 benjhayden@chromium.org Generalize complex test cases in Descriptor. 2018-11-09 benjhayden@chromium.org Expose annotations via /api/timeseries2 2018-11-09 benjhayden@chromium.org Add tag-filter for v2spa 2018-11-08 dpranke@chromium.org Integrate test expectation-parsing code into TYP. Created with: gclient setdep -r src/third_party/catapult@f2c3502f7788 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:904019,chromium:898552,chromium:900218,chromium:835690 TBR=sullivan@chromium.org Change-Id: Ic8d2d5b5c618bef91ecd2c6051a9e85ab340dab9 Reviewed-on: https://chromium-review.googlesource.com/c/1330771Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607117}
-
Hirokazu Honda authored
BUG=chromium:895230 TEST=CtsMediaTestCases Change-Id: If928fa30cf6800809242b467c472b4549926f3d0 Reviewed-on: https://chromium-review.googlesource.com/c/1325584Reviewed-by:
Pawel Osciak <posciak@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#607116}
-
Zhiqiang Zhang authored
This CL adds unit tests to CastSessionController. Also the updateNamespaces() method is fixed to accept null ApplicationMetadata or namespaces. Change-Id: I3b435b22423a036c80d8237ec4a3f56983c9c0c4 Reviewed-on: https://chromium-review.googlesource.com/c/1328563 Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#607115}
-
Roger McFarlane authored
TBR: sebsg@chromium.org Bug: 850606 Change-Id: I839c3125ced2779ba6b780bde754609d49a6d89e Reviewed-on: https://chromium-review.googlesource.com/c/1330902Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#607114}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e4a0ea21df88..17754d54ed77 Created with: gclient setdep -r src-internal@17754d54ed77 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib57dc6d55b55f81edb4adae8eb0acc849900fbfa Reviewed-on: https://chromium-review.googlesource.com/c/1330933Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/95af4726bf91..c7a34cae21d2 git log 95af4726bf91..c7a34cae21d2 --date=short --no-merges --format='%ad %ae %s' 2018-11-10 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2018-11-10 caryclark@skia.org fix bookmaker 2018-11-10 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@c7a34cae21d2 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I10a624e05f4f17e46ade173e6a35513faa963311 Reviewed-on: https://chromium-review.googlesource.com/c/1330772Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ed0182c12062..e4a0ea21df88 Created with: gclient setdep -r src-internal@e4a0ea21df88 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If34d901e03aaefdad6e7fa218d7dea977a619f18 Reviewed-on: https://chromium-review.googlesource.com/c/1330932Reviewed-by:
-
Ned Nguyen authored
TBR=kbr@chromium.org, rmhasan@google.com Bug: chromium:904019 Change-Id: I6f6bf317dc25ee9d3bcf3c1c2163a3b5afff3086 Reviewed-on: https://chromium-review.googlesource.com/c/1330990Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#607110}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/303a38c86077..95af4726bf91 git log 303a38c86077..95af4726bf91 --date=short --no-merges --format='%ad %ae %s' 2018-11-09 stani@google.com Revert "Improve degenerate 2pt conical gradient cases" 2018-11-09 mtklein@google.com oops, forgot tests only run in Android roll Created with: gclient setdep -r src/third_party/skia@95af4726bf91 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I6ceea3a4062bc472550721cb6a204878ccf13b57 Reviewed-on: https://chromium-review.googlesource.com/c/1330929Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/768c3afe1da0..ddbeac1c06a9 git log 768c3afe1da0..ddbeac1c06a9 --date=short --no-merges --format='%ad %ae %s' 2018-11-10 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@ddbeac1c06a9 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: If8b371d48efd2b62200f8123efe8d195b7b0b7ce Reviewed-on: https://chromium-review.googlesource.com/c/1330770Reviewed-by:
-
Ted Choc authored
BUG=898522 Change-Id: I3a52ec99bde43584203de8bce30b448d50411061 Reviewed-on: https://chromium-review.googlesource.com/c/1318571Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#607107}
-
Emil A Eklund authored
Fix a bug in CaseMappingHarfBuzzBufferFiller where 8-bit strings weren't up-converted to 16-bit in cases were the original and case mapped string differed in length which hit a CHECK in the String::Characters16 method. Bug: 899876, 899868 No-Try: true Change-Id: I5de8fbaabbc08932904846ffa4674129263f50aa Reviewed-on: https://chromium-review.googlesource.com/c/1330723 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#607106}
-
Maggie Chen authored
When it's a protected video, it must use overlay swap chain so the video content can be protected by Windows OS and hardware. There is no protection with GL composition. DC layer overlay processor should decide which code path to go. Remove REQUIRE_OVERLAY from the media frame metadata since it is not the information the media gather from the front end. It's really a decision inside the overlay processor. Bug: 843814 Change-Id: I5862a400a12870070be45f0d5d713d3b1ab64170 Reviewed-on: https://chromium-review.googlesource.com/c/1329883 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#607105}
-
Zhiqiang Zhang authored
This CL adds unit tests for BaseSessionController. Also, when ending session, call SessionManager.endCurrentSession() instead of selecting the default route. Also the app ID is set to null. Bug: 711860 Change-Id: I002d69c16b72fd68d5ff9076624c74e63f0b0003 Reviewed-on: https://chromium-review.googlesource.com/c/1317337Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fbac34ca6a56..ed0182c12062 Created with: gclient setdep -r src-internal@ed0182c12062 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If9585f6aeec07d96aaf19bbdba904f8dd1c6706b Reviewed-on: https://chromium-review.googlesource.com/c/1330769Reviewed-by:
-
rajendrant authored
Client LoFi infobar will be shown when lofi response is received, and android omnibox UI will be shown at navigation commit. This CL changes the behavior to show the infobar UI as well at navigation commit, when NetworkService is enabled, since the response headers of subresources would not be received in the browser process. Bug: 893728 Change-Id: I66122590e80974449528635892b1c720efe04450 Reviewed-on: https://chromium-review.googlesource.com/c/1327556 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#607102}
-
Roger McFarlane authored
This is a two part change. (1) Explicitly add the form/field id and name attributes to the data passed across the renderer/browser boundary. The pre-existing name and id properties of each form/field were computed values that attempted to capture whichever of the id/name was available. These values need to be passed from the renderer/JS to the browser so they can be included in the randomized form metadata sent with uploads. This part of the change is mostly mechanical, but involves updating a significant number of unittests. (2) Integrate the RandomizedEncoder to enable Rich Metadata Uploads. This augments the vote information sent from the client with additional form and field metadata that has been randomized (differential privacy via randomized responses), preventing any given upload from revealing the metadata observed by the client, but reconstructible in aggregate if sufficient clients send the same underlying metadata. Bug: 896719 Change-Id: Id866bd358eccbebdf952063bf5f6dcb9b59ad194 Reviewed-on: https://chromium-review.googlesource.com/c/1279202Reviewed-by:Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#607101}
-
Nick Harper authored
Change-Id: Ic0fe9dd8a8a4f7fd785ba5bcf94ebd94d093217e Reviewed-on: https://chromium-review.googlesource.com/c/1328707Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#607100}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromiue.org Change-Id: Ibe4bc0cf846384b5093ce5c8fbba9339156078ef Reviewed-on: https://chromium-review.googlesource.com/c/1330796Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#607099}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/af0ede1e73a7..768c3afe1da0 git log af0ede1e73a7..768c3afe1da0 --date=short --no-merges --format='%ad %ae %s' 2018-11-10 iannucci@chromium.org [led] Roll to pick up new kitchen CLI flags and set CallUpdateBuild=false. Created with: gclient setdep -r src/third_party/depot_tools@768c3afe1da0 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I1e06de8d552da3bea9e1d621679986a4b7f52c2d Reviewed-on: https://chromium-review.googlesource.com/c/1330928Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/83560374fb95..fbac34ca6a56 Created with: gclient setdep -r src-internal@fbac34ca6a56 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I23d5bc89c435a6088eda6c8a99a23e843c98f6cc Reviewed-on: https://chromium-review.googlesource.com/c/1330930Reviewed-by:
-
Kenneth Russell authored
This code path was using the wrong blend mode when drawing the WebGL content to the intermediate cc::PaintImage which is then drawn to the 2D context. Added a pixel test for this which fails before the fix, and passes afterward. A WebGL conformance test has also been written which will be rolled in later, but it would not catch the bug unless the tests were run with SwiftShader - which they aren't currently on Chromium's waterfall. Bug: 894021 Change-Id: I77a0d4877641c545159bc43b11483b80ffc74c72 Reviewed-on: https://chromium-review.googlesource.com/c/1330890 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#607096}
-
John Budorick authored
This reverts commit e0c7bc0e. Reason for revert: crbug.com/903425 Original change's description: > Build internal android targets in telemetry_chrome_test. > > Requires crrev.com/i/709113 > > Bug: 817842 > Change-Id: If7556e8aa41631e12def309927656b4bcbcac330 > Reviewed-on: https://chromium-review.googlesource.com/c/1315992 > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > Reviewed-by: Ned Nguyen <nednguyen@google.com> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606139} TBR=perezju@chromium.org,nednguyen@google.com,jbudorick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 817842 Change-Id: I36d79be86060440535dd136e58427812d02db98d Reviewed-on: https://chromium-review.googlesource.com/c/1330843Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#607095}
-
Xianzhu Wang authored
The bug was exposed by removal of cache generation mechanism of paint controller. Before that, objects painted onto different paint controllers were always implicitly invalidated in one of the paint controllers due to cache generation mismatch. The bug exposed because we don't invalidate resizer in the main graphics layer on container resize if the resizer is composited. We should not paint composited resizer on the main graphics layer. Bug: 902697 Change-Id: Ia6eefe687d79a4a787528c3ccb391c57f649a911 Reviewed-on: https://chromium-review.googlesource.com/c/1329803 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#607094}
-
Ben Pastene authored
Bug: 903078 Change-Id: I30666c534644b6ccf4909456b50a47d510abff4a Reviewed-on: https://chromium-review.googlesource.com/c/1327147Reviewed-by:
Reid Kleckner <rnk@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#607093}
-
Jordy Greenblatt authored
I manually confirmed that it now shows the network state 'Connecting' and starts connecting when the cr-network-list-item corresponding to a tethering host is clicked. Bug: 903622 Change-Id: Ib7efe3001cd4283065f85327f8a6f56916d825f1 Reviewed-on: https://chromium-review.googlesource.com/c/1328144Reviewed-by:
Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#607092}
-
Chromium WPT Sync authored
Using wpt-import in Chromium deef63c0. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." 9ff65400 "Add redirected cases to CSP/import tests in wpt/worklets" 687313c5 "Add action_sequence in testdriver" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Idcffdcc64ea93b9f1a6528de29909667aaa7432d Reviewed-on: https://chromium-review.googlesource.com/c/1330831 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607091}
-
Andrew Comminos authored
When we have a single-line definite height row flexbox with a column flexbox as its child, we always relayout all children of the column flexbox during LayoutLineItems with a zero-sized height being set. This patch leverages the definite height of the row flexbox in order to avoid a relayout of the column flexbox children. Bug: 703512 Change-Id: I1f67efff3ebc67cdcce57dce2d2567e2abe13625 Reviewed-on: https://chromium-review.googlesource.com/c/1306404Reviewed-by:
-
David Black authored
Previously AnswerCardContentsRegistry was used by AppList and Assistant to embed WebContents in Ash, although this would not work in Mash. Assistant used AnswerCardContentsRegistry in conjunction with WebContentsManager to embed Assistant cards. Now, we have migrated to Content Service which renders these classes no longer needed. AppList was transitioned in: https://chromium-review.googlesource.com/c/chromium/src/+/1269622 Assistant was transitioned in: https://chromium-review.googlesource.com/c/chromium/src/+/1313745 https://chromium-review.googlesource.com/c/chromium/src/+/1321861 Bug: b:78078693 Change-Id: I5b855b6ff24722524b600eb1032960210c0233f7 Reviewed-on: https://chromium-review.googlesource.com/c/1325430 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#607089}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7adddc2268b1..f768692bdef0 git log 7adddc2268b1..f768692bdef0 --date=short --no-merges --format='%ad %ae %s' 2018-11-10 tsepez@chromium.org Enable more field property tests. 2018-11-09 thestig@chromium.org Fix JS event.value behavior. 2018-11-09 tsepez@chromium.org List annots in page annotation dict for JS field tests 2018-11-09 thestig@chromium.org Add CPDF_DocRenderDataTest. 2018-11-09 tsepez@chromium.org Add better tests for AFSimple_Calculate(). Created with: gclient setdep -r src/third_party/pdfium@f768692bdef0 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Idb3b239df8b74ad143fda91a02f9e838b099b3d9 Reviewed-on: https://chromium-review.googlesource.com/c/1330118Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8ecbd57f8e89..83560374fb95 Created with: gclient setdep -r src-internal@83560374fb95 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie9c10c2e2e81e1069c0d52240d329004e3ebeef5 Reviewed-on: https://chromium-review.googlesource.com/c/1330120Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2bb343c5e822..303a38c86077 git log 2bb343c5e822..303a38c86077 --date=short --no-merges --format='%ad %ae %s' 2018-11-09 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-09 reed@google.com Revert "rm legacy flags for hinting enum" 2018-11-09 jvanverth@google.com Verify YUVA channel information and add premultiplied alpha 2018-11-09 caryclark@skia.org fix bookmaker 2018-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 5d2dfa46c05c..50bf0429394d (1 commits) 2018-11-09 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@303a38c86077 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I1b7fa5d77e8098d419ced8d604972d53fbd93a12 Reviewed-on: https://chromium-review.googlesource.com/c/1330111Reviewed-by:
-
Ben Pastene authored
Will go on chromium.android.fyi, and be a copy of the O WebView bot w/ the NetworkService feature. Going to try swarming it since the L WebView bot appears to be working on swarming. I can always undo that if it doesn't work. Bug: 880623 Change-Id: Ic57bce51c3c70325a2b4038976bb85552723fd0e Reviewed-on: https://chromium-review.googlesource.com/c/1327414Reviewed-by:
-
