GitLab

Due to a bug, the Clang-plugin style checker failed to warn about
inline constructors, destructors, non-empty virtual methods, etc.
for nested classes.

The plugin has been fixed, and this patch is part of a clean-up of all
the code that now causes the plugin to issue errors.

BUG=139346


Review URL: https://chromiumcodereview.appspot.com/10855076

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150913 0039d316-1c4b-4281-b951-d872f2087c98

Due to a bug, the Clang-plugin style checker failed to warn about
inline constructors, destructors, non-empty virtual methods, etc.
for nested classes.

The plugin has been fixed, and this patch is part of a clean-up of all
the code that now causes the plugin to issue errors.

BUG=139346


Review URL: https://chromiumcodereview.appspot.com/10829258

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150912 0039d316-1c4b-4281-b951-d872f2087c98

The cause of the error was work_area in screen coordinates was passed to CalculateAttachedSizes while bounds is in |window()->parent()|'s coordinates.

BUG=139231
TEST=Set the 2nd display on left, open two windows and use multi window resizer on debug build, and check crash does not occur.

Review URL: https://chromiumcodereview.appspot.com/10836157

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150911 0039d316-1c4b-4281-b951-d872f2087c98

Previously, I thought width was used in layout in render_text_linux.cc,
but it turns out that the width that's passed in to SetupPangoLayout()
gets cleared right after. So the width of the display rect does not
actually affect layout and thus does not need to cause the layout to
be reset.

BUG=137064
TEST=No behavior change.

Review URL: https://chromiumcodereview.appspot.com/10829261

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150908 0039d316-1c4b-4281-b951-d872f2087c98

The original name was a misnomer. Looking at the code, the function
moves an entry from the root directory to another directory.

Along the way, remove if (!callback.is_null()) and PostTask() from
this and related functions.

BUG=126634, 139446
TEST=copying and moving of files on Drive work as before

Review URL: https://chromiumcodereview.appspot.com/10828238

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150907 0039d316-1c4b-4281-b951-d872f2087c98

As titled, switches everything over to using the AudioBus
class instead of const std::vector<float*>.  Allows removal
of lots of crufty allocations and memsets.

BUG=114700
TEST=unit tests, layout tests, try bots.  Nothing should change.


Review URL: https://chromiumcodereview.appspot.com/10823175

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150906 0039d316-1c4b-4281-b951-d872f2087c98

This applies the mmap workaround to all "Chrome" builds, since we're
also seeing the error on Chrome continuous branch builders, which aren't
marked as "Official" builds.

Review URL: https://chromiumcodereview.appspot.com/10823264

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150905 0039d316-1c4b-4281-b951-d872f2087c98

This tool checks all third-party code used on Android, for the purposes of the Android WebView build.

BUG=138921

Review URL: https://chromiumcodereview.appspot.com/10816041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150904 0039d316-1c4b-4281-b951-d872f2087c98

The code paths have been different for quite some time without any new suppressions filed. In addition to that, I've landed a few patches that improve the thread safety of code in question!

BUG=46642,107181
TBR=timurrrr

Review URL: https://chromiumcodereview.appspot.com/10830250

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150903 0039d316-1c4b-4281-b951-d872f2087c98

Most of our existing disk cache histograms focus on the speed of operations on the cache itself. This CL adds a bunch that break down http transactions by type, and track both time spent reading (either from disk cache or network), and time spent waiting for the disk cache to allow us to send the network request.

Note that these patches are based on http://codereview.chromium.org/10797042/ , which must land first.

R=rvargas@chromium.org, tburkhard@chromium.org
BUG=None

Review URL: https://chromiumcodereview.appspot.com/10808047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150902 0039d316-1c4b-4281-b951-d872f2087c98

- Update third_party/mach_override from https://github.com/rentzsch/mach_star/mach_override to include the fix for building Chromium on 64 bits.

BUG=138535

Review URL: https://chromiumcodereview.appspot.com/10834127

TBR=mmaerean@adobe.com
Review URL: https://chromiumcodereview.appspot.com/10830249

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150901 0039d316-1c4b-4281-b951-d872f2087c98

Unfortunately until bug 110228 is fixed I have to keep IsInitializedForTesting() around but atleast it enforces that state_ is accessed on the same thread instead of locking.

Review URL: https://chromiumcodereview.appspot.com/10823261

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150899 0039d316-1c4b-4281-b951-d872f2087c98

This CL: 
- eliminates unnecessary dispatches
- correctly handles devices that are discovered before interest is
registered

TEST=ran api test
BUG=133179


Review URL: https://chromiumcodereview.appspot.com/10815072

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150898 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/10831244

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150897 0039d316-1c4b-4281-b951-d872f2087c98

The public functions TransferFileFromRemoteToLocal() and
TransferFileFromLocalToRemote() are called from file_browser_private_api.cc
with callbacks, hence it's safe to make the callback parameter mandatory.

BUG=126634, 139446
TEST=out/Release/unit_tests --gtest_filter=GData*

Review URL: https://chromiumcodereview.appspot.com/10824240

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150896 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/125937
TEST=existing
TBR=jochen@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10825254

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150895 0039d316-1c4b-4281-b951-d872f2087c98

sourceSetTimestampOffset() was removed in r150129 because it looked like it wasn't being used.  It just hadn't been hooked up to WebKit yet.  This patch will add it back.

BUG=141659

Review URL: https://chromiumcodereview.appspot.com/10823260

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150894 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10825189

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150893 0039d316-1c4b-4281-b951-d872f2087c98

due to fame navigation flakiness.

TBR=jochen@chromium.org 
BUG=141497
Review URL: https://chromiumcodereview.appspot.com/10827258

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150892 0039d316-1c4b-4281-b951-d872f2087c98

Due to a bug, the Clang-plugin style checker failed to warn about
inline constructors, destructors, non-empty virtual methods, etc.
for nested classes.

The plugin has been fixed, and this patch is part of a clean-up of all
the code that now causes the plugin to issue errors.

BUG=139346


Review URL: https://chromiumcodereview.appspot.com/10825275

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150891 0039d316-1c4b-4281-b951-d872f2087c98

DownloadItem::Observer::OnDownloadDestroyed() replaces DownloadItem::REMOVING
Changes from original CL only in downloads_api.*

Reviewers:
Ben Goodger: chrome/browser/ui/views/download/download_item_view.*, chrome/browser/plugin_installer.*, chrome/browser/automation/automation_provider.cc
rdsmith, asanka: all
Nico (thakis): chrome/browser/ui/cocoa/download/download_item_mac.*
Achuith: chrome/browser/chromeos/gdata/gdata_download_observer.*
Evan (estade): chrome/browser/ui/gtk/download/download_item_gtk.*, chrome/browser/ui/webui/downloads_dom_handler.*
Scott (sky): chrome/browser/history/history_unittest.cc
Aaron (aa): chrome/browser/extensions/webstore_installer.*

Add DownloadItem::Observer::OnDownloadRemoved() to signal when a download is being removed from history.
Make chrome.downloads.onErased trigger from DownloadItem::Observer::OnDownloadRemoved() so that extensions don't think that all downloads are being erased just because the browser is closing.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149794
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=150086
http://crbug.com/140687

Review URL: https://chromiumcodereview.appspot.com/10704026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150890 0039d316-1c4b-4281-b951-d872f2087c98

Resubmit of r145925

BUG=136828
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10702038


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150889 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150888 0039d316-1c4b-4281-b951-d872f2087c98

TBR=yutak@chromium.org

BUG=

Review URL: https://chromiumcodereview.appspot.com/10823236

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150887 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10827248

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150886 0039d316-1c4b-4281-b951-d872f2087c98

Original CL http://codereview.chromium.org/10827154/ was failed on linux_chromeos. This CL fixed the test.

Preload default wallpaper.


BUG=139929
TBR=nkostylev, sky

Review URL: https://chromiumcodereview.appspot.com/10827247

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150885 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=the new test passed on try

Review URL: https://chromiumcodereview.appspot.com/10855068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150884 0039d316-1c4b-4281-b951-d872f2087c98

Chromium already behaves like this in the IPC plumbing for IDB,
but the code can be simplified by pushing this into the WebKit
implementation itself.

Full landing sequence is:

(1) WebKit prep: Add new API stubs http://webkit.org/b/92414 
(2) Chromium changes: dispatch to old and new API https://chromiumcodereview.appspot.com/10830028 (this patch)
(3) WebKit changes: use the new API http://webkit.org/b/92278
(4) Chromium cleanup: delete old API usage
(5) WebKit changes: delete old API


Review URL: https://chromiumcodereview.appspot.com/10830028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150883 0039d316-1c4b-4281-b951-d872f2087c98

Currently we have the debugd logs prefixed with debugd and then duplicated in another key called debugd; this will be fixed with http://code.google.com/p/chromium/issues/detail?id=138582 but for M22, we want to fix the UI to display the logs more appropriately.

Reviews requested,
ellyjones@ - main review.
xiyuan@ - OWNER's review.

R=ellyjones@chromium.org,xiyuan@chromium.org
BUG=140489
TEST=debugd- prefixed keys are gone; so is the debugd key which contained all the logs again.


Review URL: https://chromiumcodereview.appspot.com/10825260

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150882 0039d316-1c4b-4281-b951-d872f2087c98

Add in support for timing chrome's startup and session restore times.

BUG=130212
TEST=Included


Review URL: https://chromiumcodereview.appspot.com/10834015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150881 0039d316-1c4b-4281-b951-d872f2087c98

BUG=137676
TBR=tony, sky

Review URL: https://chromiumcodereview.appspot.com/10837158

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150878 0039d316-1c4b-4281-b951-d872f2087c98

Due to a bug, the Clang-plugin style checker failed to warn about
inline constructors, destructors, non-empty virtual methods, etc.
for nested classes.

The plugin has been fixed, and this patch is part of a clean-up of all
the code that now causes the plugin to issue errors.

BUG=139346


Review URL: https://chromiumcodereview.appspot.com/10831234

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150877 0039d316-1c4b-4281-b951-d872f2087c98

R=ben@chromium.org,groby@chromium.org
BUG=109425,128964


Review URL: https://chromiumcodereview.appspot.com/10830102

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150876 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141134

Review URL: https://chromiumcodereview.appspot.com/10830138

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150875 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=yefim

Review URL: https://chromiumcodereview.appspot.com/10836183

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150874 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140306
Tested: Added new browser tests!

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150654

Review URL: https://chromiumcodereview.appspot.com/10830072

TBR=fsamuel@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10827257

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150873 0039d316-1c4b-4281-b951-d872f2087c98

The number of calles of FindEntryByPathSync() is reduced from 15 to 13.

BUG=137694, 126634, 139446
TEST=Moving a file to another directory and renaming in the same directory work as before from file manager

Review URL: https://chromiumcodereview.appspot.com/10854072

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150871 0039d316-1c4b-4281-b951-d872f2087c98

The hit-region for windows need to be larger for touch events to allow
resizing windows easily, while continuing to use a smaller hit-region
for mouse-events.

BUG=135187

Review URL: https://chromiumcodereview.appspot.com/10854060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150870 0039d316-1c4b-4281-b951-d872f2087c98

and need to share existing code with other developers.

BUG=125307


Review URL: https://chromiumcodereview.appspot.com/10533086

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150869 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150867 0039d316-1c4b-4281-b951-d872f2087c98