- 19 Jan, 2018 40 commits
-
-
Xida Chen authored
In quite a few functions in the CSSPaintImageGeneratorImpl class, we check whether the document paint definition of a particular name exists or not, but we never do null check on that definition. This could lead to crash if the document paint definition is a null ptr. This CL fixes the problem by doing null check. It also changes one layout test to execise this code path. The change to the layout test also fixes the problem that this layout test passes in the browser that doesn't support paint worklet. Bug: 802970, 768683 Change-Id: Ia952ad977b63af643410b0973cc8034fac504f9f Reviewed-on: https://chromium-review.googlesource.com/869891 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#530441}
-
Tatsuhisa Yamaguchi authored
We decided to postpone release of this feature to M66. The flag was originally added by Issue 844497. Bug: 783200 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I67189658f2b4c680a902eaba9550aad986d6f06a Reviewed-on: https://chromium-review.googlesource.com/874979Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#530440}
-
Patti authored
Chosen object views (currently, only USB devices) shown in the Page Info bubble only show the name of the USB device granted to them and don't give any context of what they might be. Add a label in secondary text underneath the chosen object name to make it clear to the user that this is a USB device. Bug: 773156, 773146 Change-Id: I95af87ed0fe86ff14fd539f44204f9158cc0ff9a Reviewed-on: https://chromium-review.googlesource.com/771060 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Lucas Garron <lgarron@chromium.org> Cr-Commit-Position: refs/heads/master@{#530439}
-
rhalavati@chromium.org authored
Network traffic annotations should be passed from the request sources to the final sockets. This CL does the annotation tunneling from SocketDispatcherHost to the actual sockets in P2PSocketHostTcpBase. In a next CL, we will pass the annotation from the call sources (like WebRTC) to SocketDispatcherHost. Bug: 656607 Change-Id: I83cd604197dec71e77df429dfd0aed5bb3edc96a Reviewed-on: https://chromium-review.googlesource.com/859499Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#530438}
-
Wei-Yin Chen (陳威尹) authored
Sole integration needs to know whether it's enabled or not before native is loaded, so it's cached in shared preference, and requires restarting twice after the flag is modified. Bug: 778805 Change-Id: I5885b2fb44990d6bb0cdcbba4cc382772c5732be Reviewed-on: https://chromium-review.googlesource.com/875322 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#530437}
-
Lei Zhang authored
- Make them all consistent. - Remove IsAskPrintSettingsEnabled() method since all impls as the same. Change-Id: Ief39548a5ab9fd7ea92638f41612282c82373df1 Reviewed-on: https://chromium-review.googlesource.com/875264Reviewed-by:
Jianzhou Feng <jzfeng@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#530436}
-
Shanmuga Pandi M authored
Intent to implement and ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Qc-bOSyU0FQ Bug: 534245 Change-Id: Ib97235c26b4b3ccd681e708e232a782d5612745c Reviewed-on: https://chromium-review.googlesource.com/861601Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#530435}
-
Eddy Mead authored
Bug: 803453, 803520 Change-Id: I3870ea56cd8349704621f3a72b64b69a24624680 Reviewed-on: https://chromium-review.googlesource.com/874981Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#530434}
-
John Abd-El-Malek authored
Remove usage of content/common from content/network in preparation of moving that code to services/network. Bug: 753658 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ifcde5a90551d5abec39ff96fccf665aae3183391 Reviewed-on: https://chromium-review.googlesource.com/875298 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#530433}
-
Yoichi Osato authored
# COMPONENT: UI>Browser TBR: tapted@chromium.org Bug: 803743 Change-Id: Iabe7e265797ba0c37666016479687d51ef967a17 Reviewed-on: https://chromium-review.googlesource.com/875512Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#530432}
-
Sidney San Martín authored
Work around a High Sierra bug that makes a window in an inactive space activate if it shows its status bubble. Starting in 10.13, adding a child window to a window in an inactive space brings it to the front if the user is interacting with its application in the active space. I can't find a nice workaround, and hidden windows showing a status bubble have triggered similar issues in the past, so this workaround waits to add the status bubble to a window until it's visible. Bug: 798792, 783521 Change-Id: I35cd7df87d74b6e1237cd91fc91acf455c443f82 Reviewed-on: https://chromium-review.googlesource.com/849559 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#530431}
-
Peter Collingbourne authored
Found by compiling with libc++ on Windows. Bug: 801780 Change-Id: I948e6d5baaf7008892a576bcc27943d96b911e62 Reviewed-on: https://chromium-review.googlesource.com/875372Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#530430}
-
JunHo Seo authored
This CL contains a major refactoring. 1. Ignore non-navigable iframes. Previously, spatnav only dug into the first iframe it found. Now, in case that is an iframe without focusables, we ignore it and go look for the next candidate. Note that additional time and space can be increased in the worst case (the next closest element is always an iframe that cannot consume input). Example: <a href='#'>focused element</a> <iframe></iframe> .. many iframes <iframe></iframe> <a href='#'>target element</a> 2. Remove recursion. Now we use a HeapVector and regard it as stack for managing search order instead the call stack. Also we cleaned up some dead code related with is_offscreen_after_ scrolling condition statements. The condition never hit because is_offscreen_after_scrolling==false is one of condition for being candidate. 3. Don't revisit subtrees we've already searched. When the search scope is expanded from "current container" C to C's parent container, AdvanceFocusDirectionallyInContainer() searched C's tree again. Now we skip already searched subtrees. Bug: 770147, 784320 Change-Id: Idcce4e9125ec05d35481ecdc17b1336a85bc968a Reviewed-on: https://chromium-review.googlesource.com/781326 Commit-Queue: JunHo Seo <junho0924.seo@lge.com> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Hugo Holgersson <hugoh@vewd.com> Cr-Commit-Position: refs/heads/master@{#530429}
-
Yoshifumi Inoue authored
This patch makes |LayoutInline::GenerateLineBoxRects()| to LayoutNG by utilizing |NGInlineFragmentTraversal::SelfFragmentsOf()| which encapsulates handling of culled inline boxes. After this patch, following member functions of LayoutInline is adapted to LayoutNG: - AbsoluteRects - AbsoluteQuadsForSelf - AddOutlineRects - ComputeSelfHitTestRects Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Bug: 591099 Change-Id: I05dd8772928932a1b102506ebac9c1df965c545a Reviewed-on: https://chromium-review.googlesource.com/866602 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#530428}
-
Tetsui Ohkubo authored
As fullscreen app_list is already launched and the flag is removed, IsFullscreenAppListEnabled() always returns true. This CL removes the flag checking code under ui/app_list/views. TEST=app_list_unittests BUG=775279 Change-Id: Iab6d593f2ce620038183a78c9faa9bd8b4785c24 Reviewed-on: https://chromium-review.googlesource.com/867138 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#530427}
-
Yoichi Osato authored
TBR: hbos@chromium.org Bug: 803597 Change-Id: I9230416edbd8fc86f4fa47a4d172b17fefb6e540 Reviewed-on: https://chromium-review.googlesource.com/874988Reviewed-by:
-
Yoichi Osato authored
This patch disables the browsertest on Win,Mac and Linux. TBR: dougarnett@chromium.org Bug: 803626 Change-Id: I9d145603d154cc7316bcb5ddf536417f146df568 Reviewed-on: https://chromium-review.googlesource.com/874986Reviewed-by:
-
Gyuyoung Kim authored
This is a reland of I66825c20395ea6fd6b26e32fc8f6508fd85aeef7. Original CL caused a memory leak for the layout test. This CL fixes it speculatively. Bug: 790860 Change-Id: I0daac689085625b4954bac34991e28addea6f8e1 Reviewed-on: https://chromium-review.googlesource.com/874977Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Cr-Commit-Position: refs/heads/master@{#530424}
-
Maajid authored
Bug: 741274 Change-Id: Ib6a62720c7f3e89a7d480a63c4bc4a470d75aed9 Reviewed-on: https://chromium-review.googlesource.com/861368 Commit-Queue: Maajid <maajid@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#530423}
-
Istiaque Ahmed authored
There are two hash files that are involved for content verification: verified_contents.json and computed_hashes.json. The new class aims to pull all operations related to these files into ContentHash to improve content verification code and also facilitates further improvements to the code. This CL moves both hash files' reading code into ContentHash class avoiding the need to read verified_contents.json from multiple places. This CL also moves computed_hashes.json file generation/writing to ContentHash. The Cancel() behavior of ContentHashFetcherJob is retained in this CL, and is moved primarily to ContentHash. ContentHash uses CancellationStatus interface to consult ContentHashFetcherJob about cross thread cancellation of ContentHashFetcherJob. Update ContentHashReader and ContentHashFetcher accordingly to use ContentHash to deal with the hashes. Fetching verified_contents.json from network is still kept in ContentHashFetcher to keep the change simpler. Behavior changes: We used to write computed_hashes.json after computing hashes but didn't read that file at that step, this CL reads them back to ContentHash::Reader right after writing it. This avoids special cases and makes ContentHash always have both hashes ready. Other than that, expect no behavior change in this CL. Bug: 796395 Change-Id: I00e03cf208982e1cbd8be7951e06da97173a3ffc Reviewed-on: https://chromium-review.googlesource.com/831341 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#530422}
-
chrome-release-bot authored
TBR=govind@chromium.org Change-Id: Ie46fec9026e797b25f4f1d0784f71df561f36e15 Reviewed-on: https://chromium-review.googlesource.com/874851Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#530421}
-
dpapad authored
Before this CL 1) for each user interaction there were 2 JS->C++ messages, instead of just 1. 2) the C++ call was made only after the drawer animation finished, which created a race condition between the inDevMode boolean and the toggle's state. Now it happens as soon as the user clicks. 3) The height of the cards was snapping after the toolbar animation finished. No longer the case. The height of the cards animates at the same time with the toolbar. This simplifies the logic a bit, and unblocks porting the PolicyTest.DeveloperToolsDisabledExtensionsDevMode to the new UI. Bug: 803326 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4f2995bc322f619fbc8fad812dd03344e895391c Reviewed-on: https://chromium-review.googlesource.com/874775 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#530420}
-
Jinsuk Kim authored
This fix a potential bug that can happen, based on the crash report https://crbug.com/803244. It was not taken into account when landing https://crrev.com/c/867177. Bug: 803244 Change-Id: I99c4d927cc69567efae619622ce8baf434cc332b Reviewed-on: https://chromium-review.googlesource.com/874976 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
-
Yaron Friedman authored
As a follow-on to https://chromium-review.googlesource.com/776162 since we need a copy of the runtime library for fallback behaviour in the ShellApk, we should just expand this once and check it in. This avoids the problem where any change to the aidl for the runtime library requires the shell apk to also be updated. Bug: 700228 Change-Id: Ib2a2db8980f27813a552a8d8a9783cadbdb1be39 Reviewed-on: https://chromium-review.googlesource.com/797292 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#530418}
-
Miguel Casas-Sanchez authored
This CL extends gl_image_io_surface_unittest.cc to try a few more formats and addresses the strange situation of RGBA_8888 being handled as an BGRA by writing a significant comment. Also: better logging and comments in gl_image_io_surface.mm and gl_image_test_support.cc. Bug: 803473 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I630a4bee5cd1003d4b10da8dece4dadcced63bed Reviewed-on: https://chromium-review.googlesource.com/874898 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#530417}
-
Javier Fernandez authored
There were several discussions to avoid ambiguities with the complex values, specially when it comes to define the place-xxx shorthands. One of the sources of problems is the 'overflow-position' keyword. The CSS WG has decided to change the syntax of all the CSS Box Alignment properties so that the 'overflow-position' keyword always precede the 'self-position' or the 'content-position' keywords. https://github.com/w3c/csswg-drafts/issues/1446#event-1125715434 In order to apply this change to the Content Distribution properties' (align-content and justify-content) syntax I had to completely re-implement their parsing function. Thanks to this I addressed also the issue with the content-distribution fallback, which cannot be specified explicitly now. https://github.com/w3c/csswg-drafts/issues/1002#ref-commit-c38cac4 Bug: 802098, 802247 Change-Id: I57315a475940c00d0c0dafbb4f1b32a2c6c1ff68 Reviewed-on: https://chromium-review.googlesource.com/868531 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
meade_UTC10 <meade@chromium.org> Reviewed-by:
Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#530416}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0e7a30e1. With Chromium commits locally applied on WPT: e8a79119 "Fixed wpt csp reporting tests and moved over chrome internal ones" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/10313 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kpaulhamus@chromium.org: external/wpt/webauthn TBR=kereliuk No-Export: true Change-Id: I29fa2d57b9501f8bbe77eb13a18dd8c7864db988 Reviewed-on: https://chromium-review.googlesource.com/875350 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#530415}
-
Peter Kasting authored
The Harmony spec removes periods when a control has only one phrase or sentence. This applies even when there is a trailing button, e.g. "Do something [OK]". BUG=686285 TEST=none Change-Id: I9de4da4cdf94c1e19d86e2c18877e51dc1344e0e Reviewed-on: https://chromium-review.googlesource.com/875171 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#530414}
-
Alan Cutter authored
Change-Id: I8616c8b57f7cd04475bd720760d5f71a1ba3b849 Reviewed-on: https://chromium-review.googlesource.com/874973Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
-
Bill Budge authored
This reverts commit 348c758d. Reason for revert: <INSERT REASONING HERE> Original change's description: > Reland [partition_alloc] Allow 2 GiB direct mapped allocations. > > - Raises the limit of direct mapped allocations. WASM needs > to be able to allocate 2GiB regions. > > Bug: chromium:801604 > Change-Id: I77e905ff4ae6f5ca66de9daf30f19bb6f7b54089 > Reviewed-on: https://chromium-review.googlesource.com/875301 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Bill Budge <bbudge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#530380} TBR=bbudge@chromium.org,haraken@chromium.org Change-Id: I4462f890182dcb523f15cb8289ca416b5d266578 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:801604 Reviewed-on: https://chromium-review.googlesource.com/875169Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#530412}
-
Evan Stade authored
Use NotificationDisplayService instead of MessageCenter in tests. Bug: 783018 Change-Id: I2bc849e90f5f899144d015c83755f8eade62e185 Reviewed-on: https://chromium-review.googlesource.com/867291 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#530411}
-
Devlin Cronin authored
ExtensionScopedPrefs is an object that provides a more limited set of methods than ExtensionPrefs. However, it is only used in a small handful of places, only has a single implementation (ExtensionPrefs), and has no way of retrieving itself as a KeyedService (ExtensionPrefs::Get returns an ExtensionPrefs*), which means that it also doesn't reduce any set of required dependencies. Remove the class, and make the few callers that knew about it use ExtensionPrefs. TBR=benwells@chromium.org (c/b/ui/app_list) Bug: None Change-Id: Ifcfc8e657a698e16bb44e898913246ee452e0894 Reviewed-on: https://chromium-review.googlesource.com/857839 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#530410}
-
Xu Xing authored
TODO(crbug.com/803286): npot texture always return false on ubuntu desktop. The npot texture check is probably failing on desktop GL. BUG=802924, 803286 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I8f2dc179f065f1fa59650184c59d6184e293fbfd Reviewed-on: https://chromium-review.googlesource.com/869952Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Xing Xu <xing.xu@intel.com> Cr-Commit-Position: refs/heads/master@{#530409}
-
Devlin Cronin authored
Extension APIs and API objects can potentially be accessed after the context is invalidated (e.g., if a parent frame stores a reference to a child frame's API object, then removes the child frame, then tries to use the API object). We don't support this because we require a valid ScriptContext. Expand the checks we have in place for this to include all the custom API types (StorageArea was previously handled, but expand to ContentSetting, ChromeSetting, and EasyUnlockPrivate), and add a common method to check context validity and throw an error if the context is invalid. Update the checks in APIBinding when we are accessing an API method or retrieving an event as well. Add tests for all of these instances - custom chrome API objects, API methods, and API events. Bug: 653596 Change-Id: Ifca7694fbd6c78260a015231f19fc241e5a39b8a Reviewed-on: https://chromium-review.googlesource.com/869375Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
-
Marijn Kruisselbrink authored
These callbacks are only called once, so should really be OnceCallback rather than Callback. Bug: none Change-Id: Ia8b15a328db8f7949402bd7b6a737a578fba01dd Reviewed-on: https://chromium-review.googlesource.com/874953 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#530407}
-
agrieve authored
This reverts commit e23729f3. Reason for revert: Probably causing other crashing (see bug) Original change's description: > Fix crash when switching back from Samsung DeX to Phone mode. > > Regressed in d875cacb > > Bug: 780593 > Change-Id: Ifee7a93ada73f5b757a35ece75b0bef61ea767c2 > Reviewed-on: https://chromium-review.googlesource.com/820531 > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Ted Choc (back but slow, ping me) <tedchoc@chromium.org> > Commit-Queue: agrieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#527117} TBR=tedchoc@chromium.org,twellington@chromium.org,agrieve@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 780593, 794551 Change-Id: Ia91f278b1dff52af4f4fc1bbd33743168dfb5e4a Reviewed-on: https://chromium-review.googlesource.com/874803Reviewed-by:
-
Fabio Tirelo authored
"Try Again" can be context-dependent in some languages, so this is to help translators, so it's important to indicate that it should have the same translation as in the button. Change-Id: I6a80d5b1dd444dba9bd05f052059e5f3caf76a00 Reviewed-on: https://chromium-review.googlesource.com/875112Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#530405}
-
David Valleau authored
https://chromium-review.googlesource.com/c/chromium/src/+/861956 Fixing link error caused by the free ParseUri function in printer_configuration.h not being exported properly. This reverts commit 68d7f4c6. Bug: 769893 Change-Id: I02a482272bf97e7166c221448dd2444bece00d03 Reviewed-on: https://chromium-review.googlesource.com/872265 Commit-Queue: David Valleau <valleau@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#530404}
-
Peter Kasting authored
BUG=none TEST=none Change-Id: I0b106db267d30d0ab083b107258f0964165917d2 Reviewed-on: https://chromium-review.googlesource.com/855823 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Buck Krasic <ckrasic@chromium.org> Cr-Commit-Position: refs/heads/master@{#530403}
-
Miguel Casas authored
This CL adds a FeatureInfo::FeatureFlags.chromium_image_xr30 to indicate that XR30 (aka BGRX_2101010) is supported, and propagates it to the context's gpu::Capabilities.chromium_image_ar30, and teaches a few other context-related classes about this format. Bug: 797347,776093 Test: unit tests and crrev.com/c/862326. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8794aa2a45eb47f4809eeee18a1fc3a3bfcce5ed Reviewed-on: https://chromium-review.googlesource.com/868172 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
-
