- 24 Oct, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b8943e033650..151f5fbf383d git log b8943e033650..151f5fbf383d --date=short --no-merges --format='%ad %ae %s' 2019-10-24 vapier@chromium.org cros_install_debug_syms: switch to outcap 2019-10-24 vapier@chromium.org run_tests: invert python3 support logic Created with: gclient setdep -r src/third_party/chromite@151f5fbf383d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I7555a4dd5bb57a760ded98314955849133fca6d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879508Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709126}
-
Owen Min authored
Default search provider maybe null when it's disabled by policy. Make sure the touch bar search button can handle this case with an empty button. User is still able to press the button to enter URL. Screenshot: https://drive.google.com/file/d/1Sw8xd2bl4MGfF2p2qrT7PKF4bQ2jczRC/view?usp=sharing Bug: 1011260 Change-Id: Iba221a4d65baff7cc5485de43f4b145481c2d1f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841837 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#709125}
-
Stephen McGruer authored
TBR=estade@chromium.org Bug: 1017819 Change-Id: I8d5f2acbe8c30c5998e8c5a4ebd83c95a555a8a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879692Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#709124}
-
Xing Liu authored
The option "Always open with system viewer" should be following the option "Open with system viewer". Bug: 574090 Change-Id: I3c75924ef9878b4ea3aa299af14a6c03330141b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879429Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#709123}
-
David Dorwin authored
Change-Id: I730f54915f7a4f219d6b970ff4651fa20eb07b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866928 Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#709122}
-
Tao Bai authored
MetricsWebViewContentObserver assumed WillStartNavigationRequest() and DidFinishNavigation() is sequencially called for main frame, it isn't true, since both callbacks are post task, calling sequence isn't guaranteed. Bug: 1010034 Bug: 937528 Change-Id: Ia7fc892a599f789aa56b613409815f45d36e4223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865268Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#709121}
-
Min Qin authored
DragDownloadFile is used on UI thread, no need to use scoped_refptr. This CL also cleans up the unused DataObjectImpl::Observer class BUG=1008188 Change-Id: I9ba7596c69450df23e3dbe7b5bf7e56fb80ecc3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825890Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#709120}
-
Henry Jian authored
For browser installed WebAPKs, v109 has adaptive icon support Bug: 977173 Change-Id: Ic3b5e1b118dbe5ddb05fdaa662ae1ed9e81c6340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879547Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Henry Jian <hzjian@google.com> Cr-Commit-Position: refs/heads/master@{#709119}
-
Friedrich Horschig authored
Before this CL, the touch to fill sheet was intially shown in a very high PEEK state (which provides pixel-exact height control). The PEEK state had the side effect that the scrim view wasn't brought up reliably (see linked bug). Therefore, it is skipped now and instead, the half state is invoked right away. To the user, this looks and behaves exaclty the same but triggers the scrim view more reliably. Additionally, there is a small fail-safe that would have fixed the issue on its own (just not as clean). The fail-safe ensures the sheet is dismissed as soon as there the BottomSheet enters the HIDDEN state, even if the observer wasn't notified that is was closed beforehand. Minifix: the bottom sheet vertical size seems to align with Chrome now, so set the margin of the "Manage Passwords" button back to 8dp. Bug: 1017727 Change-Id: I66ddef169a96d43a059bd7f065195c03783d595f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879447Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#709118}
-
Gyuyoung Kim authored
This CL replace mojo::Binding with mojo::Receiver in |binding_|. Then, renames |binding_| with |receiver_|. Bug: 955171 Change-Id: I24a49f57e58397c74beed9105ac8eb0347e5f3a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875349Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#709117}
-
Christopher Cameron authored
The funciton UpdateAppProfileMenu should only be hit when in multi-profile mode. TBR=dominickn Bug: 1017755 Change-Id: Ib35aeb8ed4da2ff2af669c01d4996e4c278adfff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879687Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#709116}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4ab4e641f151..4a4400d9e9fa git log 4ab4e641f151..4a4400d9e9fa --date=short --no-merges --format='%ad %ae %s' 2019-10-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-24 herb@google.com Fix fuzzer bug in SkDescriptor::isValid 2019-10-24 fmalita@chromium.org Slightly faster hsl_to_rgb stage 2019-10-24 robertphillips@google.com Revert "Allow direct readback for formats in non-ES OpenGL" 2019-10-24 csmartdalton@google.com Don't keep "outResultsFile" open in nanobench 2019-10-24 mtklein@google.com restore _DXDY image shader on ARM 2019-10-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-24 bsalomon@google.com Allow direct readback for formats in non-ES OpenGL Created with: gclient setdep -r src/third_party/skia@4a4400d9e9fa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: chromium:b/143074513 Change-Id: Iebc12a2367684d181b48c642cd64595de72bb997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879310Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3671a6a21726..1906f405ba0f git log 3671a6a21726..1906f405ba0f --date=short --no-merges --format='%ad %ae %s' 2019-10-24 bpastene@chromium.org gclient: When deleting untracked files, gracefully handle symlinks that point to dirs. Created with: gclient setdep -r src/third_party/depot_tools@1906f405ba0f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:991276 Change-Id: I30e26ef2a8121cbe837bec64f4b9369e423b2651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879309Reviewed-by:
-
Philip Rogers authored
The inspector has a feature for "Scrolling performance issues" under the bottom console's "Rendering" tab which shows reasons for non-fast scrolling. This feature did not include main-thread scrolling reasons such as background-attachment: fixed. This patch adds main-thread scrolling reasons to the scrolling performance issues visualization. Bug: 1015918 Change-Id: I46039b4fc8ba3400cab1c2633da31e427865ce3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868660Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#709113}
-
Evan Stade authored
Re-write the math in GetSizeForLabelWidth and GetWidthBetween (nee WidthMultiplier) so that the tween is correctly calculated for the in-out animation. Bug: 1005837 Change-Id: I729b6bb43265fdb7cb0aab52e6ae10e3c41a0702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863351 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#709112}
-
Ana Salazar authored
This change delegates the gesture events happening in the navigation widget to the shelf Fixed: 1016931 Change-Id: I4c91612ff5d4283a2f4b2d21a6c890dd33f34532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877140 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#709111}
-
meacer authored
This CL removes clickjacking.launch_url which was added back in 2009. I suspect nobody is actively looking at it, so it seems safe to delete. Change-Id: I088c115e2811c18a993385d86ca44a58ed449da5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873110Reviewed-by:
-
Anastasiia Nikolaienko authored
Change black background to semi-opaque (60% #202124) for 'Add Account' dialog. This is a short term fix until crbug/1016828 is resolved. Bug: 997479, 1016828 Change-Id: I4741e2847f25b30a5ca3ee295569ea0c1c81cf4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847274 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Mitsuru Oshima (slow) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#709109}
-
Miriam Zimmerman authored
The "Details" text in the system & app information dialog was too low-contrast. BUG=chromium:1005543 TEST=Took screenshots in linked bug and checked contrast ratios. Change-Id: Ic0862a00c7ddb3dbbb4e46be8468e2e70a318afc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877648Reviewed-by:
J Kardatzke <jkardatzke@chromium.org> Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org> Cr-Commit-Position: refs/heads/master@{#709108}
-
Hans Wennborg authored
And make sure that the 'n' prefix gets used properly. TBR=thakis Bug: 1017736 Change-Id: I9d65fd468ec4d58ab7ddf3ce35160e13f518514e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879227Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#709107}
-
Taylor Woll authored
Add a reference to the libclang package to the list of packages which should be uploaded from the staging bucket to the production bucket when the clang toolchain is rolled. See this commit for details on the new libclang package: http://crrev.com/c/1874450 Change-Id: I2f0264e95a5fad4dc370647d60f894c30d26fd89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877605Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Taylor Woll <Taylor.Woll@microsoft.com> Cr-Commit-Position: refs/heads/master@{#709106}
-
Mikel Astiz authored
IsExitConditionSatisfied() now allows callers to provide details about why the condition wasn't satisfied. This is expected to be helpful to debug flake occurrences in the future, since it's often the case that the flake cannot be reproduced locally. Coupling the evaluation of the satisfaction predicate together with outputting a human-friendly explanation is a lot more natural than having a separate GetDebugMessage(), and aligned with common practice in testing frameworks (e.g. gMock). This patch updates all subclasses semi-mechanically with minor behavioral changes. Bug: 1017645 Change-Id: Ic3eb3d071758d71cae669ca50f022b0d3b141dad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878072 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#709105}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/56d4da0510a5..3a8b8908605b git log 56d4da0510a5..3a8b8908605b --date=short --no-merges --format='%ad %ae %s' 2019-10-24 geofflang@chromium.org GL: Follow-up primitive restart emulation fixes. Created with: gclient setdep -r src/third_party/angle@3a8b8908605b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: chromium:1017337 Change-Id: Icb669833691e6be9a505241540e525ad9654777a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879167Reviewed-by:
-
Tao Wu authored
This reverts commit 78abc7fa. Reason for revert: Break the build: ../../chromeos/services/assistant/platform/audio_stream_handler.cc:31:43: error: no viable conversion from 'typename remove_reference<InterfacePtr<AssistantAudioDecoderClient> &>::type' (aka 'mojo::InterfacePtr<chromeos::assistant::mojom::AssistantAudioDecoderClient>') to 'mojo::PendingRemote<AssistantAudioDecoderClient>' mojo::MakeRequest(&audio_decoder_), std::move(client), Original change's description: > Migrate AssistantAudioDecoderFactory to new Mojo types > > This CL applies the new Mojo types to CreateAssistantAudioDecoder > in AssistantAudioDecoderFactory interface. > > - Convert FooRequest to mojo::PendingReceiver. > - Convert FooPtr to mojo::PendingRemote or mojo::Remote. > > Bug: 955171 > Change-Id: I2de4cb0561c69201335817ec6a873258a30d9a00 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871503 > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > Reviewed-by: Tao Wu <wutao@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709059} TBR=sammc@chromium.org,wutao@chromium.org,gyuyoung@igalia.com,oksamyt@chromium.org Change-Id: I3890551d694ab28db3ba476e0771c99993c3b270 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 955171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879690Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#709103}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/87002bea1174..21b8d3ff0a35 Created with: gclient setdep -r src-internal@21b8d3ff0a35 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I7415a8f83b5b92fd9de07d37b38587c7fbdad943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878873Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709102}
-
Etienne Bergeron authored
This CL is replacing the previous cache by an MRUCache. The previous cache was an 'std::map' and was unbounded. It was not an issue since typically the amount of typeface loaded is low on the browser side. Unfortunately, that was not the case when expensive fallback fonts were used and lot of fonts were installed on the user computer. The GlyphCache is still an std::map, but it is bounded to the max amount of glyphs that a font can have (e.g. 16-bits). Bug: 890298 Change-Id: I1148ea7ebfc285dfcc05e8da454db830e809ebb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874246 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#709101}
-
Garrett Beaty authored
If no explicit pool dimension is set, buildbucket implicitly requests a pool with the bucket's long name. Bug: 922150 Change-Id: I6edbce54bc2c32f2d4a9c44e16008dc8d8c47ecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877657Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#709100}
-
Garrett Beaty authored
This is a reland of f26b6b6d generate_buildbot_json.py has been updated to look for luci-milo-dev.cfg in the generated subdirectory. Original change's description: > Migrate luci-milo-dev.cfg to starlark. > > Bug: 1011908 > Change-Id: Ic7f4fc26d75811f04c9f988866bb479a40e0d0c3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869713 > Auto-Submit: Garrett Beaty <gbeaty@chromium.org> > Reviewed-by: Aaron Gable <agable@chromium.org> > Commit-Queue: Garrett Beaty <gbeaty@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708714} Bug: 1011908 Change-Id: Idef08a086a4d764967a9a2e9b20a5dc5903d9111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877138 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
-
Aaron Colwell authored
Refactors the code so that default SiteInstances won't be used anywhere when the kProcessSharingWithDefaultSiteInstances feature is not enabled. The old code would still allow default SiteInstances in some scenarios even if the feature was off. This is surprising and more an artifact of how the feature was incrementally developed instead of intended behavior. Bug: 1015882 Change-Id: I5c46487428d33d77f5706e0f7f3b7795251a1212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877909 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#709098}
-
Boris Sazonov authored
Bug: None Change-Id: I7461f3415cc71741ce9f15e20ee35c1f500df627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878689 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#709097}
-
Peter E Conn authored
In this first step we split TrustedWebActivityVerifier up into: - TrustedWebActivityVerifier, which contains the logic for checking whether the current url is verified at the appropriate times (eg page load, tab switching) and notifying the outside world. - TwaVerifiedDelegate, which contains the logic specific to TWAs, primarily gathering the origins the client app claims it is verified for and running Digital Asset Link verification. - TwaRegistrar, which essentially contains the logic from TrustedWebActivtyVerifier#registerClientAppForOrigin The next steps are: - Rename TrustedWebActivityVerifier to just Verifier (I didn't do this in this CL to make the code review easier). - Make Verifier agnostic to whether we verify for origins or scopes. - Moving the TwaRegistrar dependency from Verifier to the TWACoordinator. - Removing the knowledge about the client package name from the Verifier - the Verifier shouldn't be the source of truth for this. Bug: 1017114 Change-Id: If6e508ed99130e0fbbc0c5fd148f65f1a0cae66d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875750Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
-
Livvie Lin authored
Security UX is experimenting with using a grey triangle warning for non-secure site connections (crbug.com/997972). When this icon is shown, DevTools Security panel's security overview should match the state shown in the omnibox. This cl sets up this change by adding an insecure-broken state, so that the following states can be distinguished: - neutral (info icon) - insecure HTTP - insecure broken HTTPS This change will also make the security state naming more intuitive, since insecure HTTP can be marked as 'insecure' rather than 'neutral' as part of a follow-up cl. Temporarily disables a web test since fixing it requires a frontend change, which is in a separate repo. This will be re-enabled in a follow-up. Bug: 1008218 Change-Id: I628f2fe1168dfeead7874e36b210bcc0396b6e8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874787 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#709095}
-
Carlos Caballero authored
MessageLoop is going away soon. This CL was uploaded by git cl split. R=rockot@google.com Bug: 891670 Change-Id: Ifb004a1f5fa5f9801e6b08010e95448cf7feb083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878074 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
-
Ethan Jimenez authored
1. Updating functionality of `ITextRangeProvider::MoveEndpointByUnit` to reflect UIA-specific behavior expected by ATs when moving by line and crossing the start of an inline block boundary, which should be effectively treated as a line break. This is mostly implemented in `AXPlatformNodeTextRangeProviderWin`, but a new method `AtStartOfInlineBlock` is introduced in `AXPosition` to expose inline block boundaries similar to how paragraph boundaries are computed by using an `AbortMovePredicate`. 2. Adding browser tests to cover new expectations mentioned above. Bug: 928948 Change-Id: Ie243a96885edaf3037c75f375ae4fce20fa29e30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858518 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#709093}
-
chrome://webrtc-internalsChristopher Grant authored
Follow the lead of other DevUI pages, and move WebRTC internals resources (those used in chrome://webrtc-internals) into the DFM. This removes ~25 KB from the main .pak file on Android. Bug: 927131 Change-Id: Ia243ec46e728a711cc7c3bb8df10cb661300d1a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869014Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#709092}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fc78aaceea0a..a9229043e357 git log fc78aaceea0a..a9229043e357 --date=short --no-merges --format='%ad %ae %s' 2019-10-24 sprang@webrtc.org Calls OnPacketsAcknowledged on RtpRtcp instead of RTPSender directly. 2019-10-24 ssilkin@webrtc.org Revert "Reset end-of-frame flag in non-VCL packet." Created with: gclient setdep -r src/third_party/webrtc@a9229043e357 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:999807 Change-Id: I4eec0cdb586117711fcdbaf9ec08581e9619d783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878867Reviewed-by:
-
Alan Cutter authored
This CL updates WebAppControllerBrowserTest test names to look like WebAppFileHandlingBrowserTest.PWAsCanReceiveFileLaunchParams/HostedAppController WebAppFileHandlingBrowserTest.PWAsCanReceiveFileLaunchParams/UnifiedControllerWithBookmarkApp WebAppFileHandlingBrowserTest.PWAsCanReceiveFileLaunchParams/UnifiedControllerWithWebApp instead of WebAppFileHandlingBrowserTest.PWAsCanReceiveFileLaunchParams/0 WebAppFileHandlingBrowserTest.PWAsCanReceiveFileLaunchParams/1 WebAppFileHandlingBrowserTest.PWAsCanReceiveFileLaunchParams/2 Bug: 876576 Change-Id: I0a5cb9f4b51f977304312f07848e34c079e571ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877504 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#709090}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/177c5c4fe392..b8943e033650 git log 177c5c4fe392..b8943e033650 --date=short --no-merges --format='%ad %ae %s' 2019-10-24 hidehiko@chromium.org chromite: Enable TastVMTests on betty-pi-arc-paladin. Created with: gclient setdep -r src/third_party/chromite@b8943e033650 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ibf0440f8ca4bdb0ded1ada4b1c210c311295beb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879027Reviewed-by:
-
Boris Sazonov authored
Disables TabPersistentStoreTest#testUndoCloseAllTabsWritesTabListFile on API levels greater than 25 (Android N), as it is flaky there. TBR=twellington@chromium.org Bug: 1017732 Change-Id: Iebbb912d8401eba4497edc7d9e6a1ac70d73ffa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878750Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#709088}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/38c2b4512e74..d4a217b1f81e git log 38c2b4512e74..d4a217b1f81e --date=short --no-merges --format='%ad %ae %s' 2019-10-24 eseckler@google.com Merge "processor: Support arg/metadata/label filters in ExportJson()" 2019-10-24 fmayer@google.com Merge "Print usage to stderr." 2019-10-24 fmayer@google.com Merge "Fix invalid exit code for `trace_to_text symbolize.`" 2019-10-24 lalitm@google.com trace_processor: add range mode to RowMap Created with: gclient setdep -r src/third_party/perfetto@d4a217b1f81e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:135177627 Change-Id: Ia41bf055a14ea35aa64ca7d8d10f1929c187c0d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878871Reviewed-by:
-
