- 07 Oct, 2020 40 commits
-
-
David Roger authored
Bug: 1115247 Change-Id: I021ed4188b4aca948b54df2af0117c6a5ce9f398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445490 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#814620}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Id8840c4ad14f1532c59a4d12be4a55ff09cc7873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455302Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814619}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f15133788010..fc8264854c53 2020-10-06 afdx@google.com spirv-fuzz: Replace dead-block terminators with OpKill etc. (#3882) 2020-10-06 vasniktel@gmail.com spirv-fuzz: TransformationPropagateInstructionDown (#3692) 2020-10-06 afdx@google.com spirv-fuzz: Transformation to add wrappers for OpKill and similar (#3881) 2020-10-06 afdx@google.com spirv-fuzz: Use overflow ids when duplicating regions (#3878) 2020-10-06 vasniktel@gmail.com spirv-fuzz: Fix rvalue references (#3883) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,timvp@google.com Change-Id: Ib4ad31f2422336dd942227d2a437492930b65310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455298Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8f6d8b45..86a4dade Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idc0ec5211d6ea18e0c2403f2c25b43d75d0e9af6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454279Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814617}
-
David Roger authored
Bug: 1130945 Change-Id: Ia1f0c9b8f20ae472dbc4a06711d3d2a4fe574e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446055 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
-
Vasilii Sukhanov authored
This reverts commit fbdd1097. Reason for revert: Fails consistently on Mac10.13 Tests (dbg) https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/20278 Original change's description: > Re-add EyeDropperBrowserTests on FYI bot > > Can't repro the flaky test locally. Re-adding to FYI bot for further > debugging and remain disabled for CI/CQ bot. > > Bug: 1131319 > Change-Id: Id0efb7067480d668dd7caad1cbb6763cb0a1ae84 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446025 > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Commit-Queue: Sven Zheng <svenzheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814349} TBR=ellyjones@chromium.org,martiniss@chromium.org,svenzheng@chromium.org Change-Id: I6d90db5e79679597dc7cadd42adb7491df196891 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1131319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455606Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#814615}
-
Rohit Agarwal authored
EnableAmbientAuthenticationInIncognito and EnableAmbientAuthenticationInGuestSession feature flags are removed as a follow-up cleanup, since ambient authentication is now disabled for private modes for many milestones. Ambient authentication for private modes is now only manageable using Enterprise policies. Bug: 458508 Change-Id: I98263fa763c18132bc977865a29604a58f4e478f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452669 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#814614}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/439af79f26e2..57c37ad0e4c8 2020-10-07 csmartdalton@google.com Add a 2d cross product intrinsic to sksl If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jvanverth@google.com Change-Id: I073a8e92e9ee3e4402c2a26eff66e6045d3a5802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455301Reviewed-by:
-
Fredrik Söderqvist authored
This is now always equal to the stroke bounding box (or object bounding box if stroke does not apply or otherwise have no influence), so it can be removed and VisualRectInLocalSVGCoordinates() forwarded to StrokeBoundingBox(). Ditto for |LayoutSVGRoot::visual_rect_in_local_svg_coordinates_|. Bug: 1028061 Change-Id: Idebfb8fb5ca4fd3c954c99068163e3947e042b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450321 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#814612}
-
Alice Wang authored
This CL adds tests to check uma recording when account picker is suppressed when no accounts are on device and when sign-in is not allowed. Bug: 1134874 Change-Id: I88817b536d9dcb02b34fcee3a294801a3706ae5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448797 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#814611}
-
Austin Tankiang authored
Bug: 1135930 Change-Id: Ia981112e2525fb2b2c883197a1a10f675c9d6142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454435Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#814610}
-
Fabio Tirelo authored
Bug: 1135570 Change-Id: I508f9fb7f5a3c6a9decd37666934cfc25ea59481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453902 Auto-Submit: Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#814609}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: I0302d272b769933d9deceb25883d00cc4e4c2e78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445614 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#814608}
-
David Roger authored
Notes: * on the mock, there is a color row missing. I've confirmed that it should be added (this is done in this CL). * The input is not plumbed (does not update the profile name) * the pink color is hardcoded * the brush icon for the custom color is larger than the mocks Screenshot: https://screenshot.googleplex.com/AStdxggC7tftUN2.png Mock: https://screenshot.googleplex.com/4Ntu44ka2iBMJxm.png Bug: 1130945 Change-Id: I736119eae9714f6662955c41f30e13624710dd52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450010 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f3f59fd5e5fa..e1f2ce586075 2020-10-07 alexrudenko@chromium.org Migrate ScreencastApp.js to TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I79e1df15fd76511ff0d2a5011fe657d115780fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454277Reviewed-by:
-
Boris Sazonov authored
Replaces existing calls to PrimaryAccountManager::HasUnconsentedPrimaryAccount with HasPrimaryAccount(ConsentLevel::kNotRequired) and removes the method. Bug: 2440621 Change-Id: Icacc73e23d7165e523d463d03967f9c5f71c9247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450019 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
-
Koji Ishii authored
r813630 crrev.com/c/2448269 added the early return for hit- testing in NG. It turned out that the logic in |LayoutNGBlockFlowMixIn| was copied from |LayoutBox| in 2017 (r508056 crrev.com/c/710498) but the logic in |LayoutBox| has evolved since then. The new logic was then improved further and extracted to |LayoutBox::MayIntersect| in r814225 crrev.com/c/2448709. This patch changes LayoutNG to use the code instead. Note, we may need to add more early return checks to |NGBoxFragmentPainter|, e.g., |HitTestBlockChildren| and/or |HitTestChildBoxFragment|, but the early return itself has some costs. I will investigate the hit-testing in FragmentTraversal codepath and how much adding early return can improve in future patches. Bug: 1134574 Change-Id: Ibe95bfd5fdaafe1d3e6cd964f479eda98d48306a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452011Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#814604}
-
chrome://accessibilitydpapad authored
Also adding some minimal JS type checking. Bug: None Change-Id: I17a74b88666b5d8e17ab5ce65f0271392bb0ee00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444485 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#814603}
-
Jiewei Qian authored
LaunchSystemWebApp used whatever profile is provided in the parameter to create SWA windows and launching SWAs, even if the profile may not suitable to host a SWA window. This CL adds logic to determine the appropriate profile if the provided one is unsuitable. This serves as a mid-term solution for launching SWAs, and acts as a safety net to prevent chrome crashing if unsuitable profiles are provided. Specifically, it catches these two types of profiles: - Guest session "original" profile: launch into guest session's primary off the record profile (which is used for guest session browsing and SWAs). - Normal session incognito profile: launch into the original profile, because we don't support incognito SWAs. Fixed: 1109594 Change-Id: Ibe4a3b1bf7c811ef1ee02fd967307ad9bf070ee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423760 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#814602}
-
Milica Selakovic authored
|GetForWebContents| should only retrieve RuntimeManager for given web contents and |GetOrCreateForWebContents| should create instance if one does not exist. Bug: 1133783 Change-Id: Ib26162b69d1b3359fc571e139ba3724ec951aa12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453389Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Milica Selakovic <selakovic@google.com> Cr-Commit-Position: refs/heads/master@{#814601}
-
Francois Beaufort authored
This CL tracks the number of times a video capture device is accessed simultaneously to understand if Chrome should add some restrictions around simultaneous camera access. Test: Go to chrome://histrograms/Media.VideoCapture.NumberOfClients and access camera device from several tabs. Change-Id: I1a4bb4020ff13bd1ddc54a59094379115e2f65e5 Bug: 1134077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440514 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
Adam Langley authored
The JNI wrapper code already caches the class objects. Use them in DCHECKs rather than doing a lookup every time. Also means that typoing the class name is now a compile-time failure. BUG=1002262 Change-Id: Ifc86bdc859d6529d0aeaa54f99c63ad199a8b8a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453919 Auto-Submit: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#814599}
-
Mugdha Lakhani authored
Pre-work for this has been done in: https://chromium-review.googlesource.com/c/chromium/src/+/2443089 This moves BackgroundSyncMetrics to components and updates references. Bug: 1087486 Change-Id: I175de6d5ff224ba2e9f590234b98bd4a2de952e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445874 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#814598}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1602028663-b1557222162a5cc9fe20bab7e0f808c4540fc966.profdata to chrome-linux-master-1602050190-1e5b85dfdba4ddd2f1758e82cab3cd509e5e62c9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ifbeddc3147fe17a41ce644119f8157b33431dbd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455294Reviewed-by:
-
Roberto Moura authored
Call |contentWillAppearAnimated| on the tab grid view controller before dispatch_async. Bug: 1134718, 1134062 Change-Id: Id8c61f596bdf69371f9b126e671d621eac54dbd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449349Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Roberto Moura <mouraroberto@google.com> Auto-Submit: Roberto Moura <mouraroberto@google.com> Cr-Commit-Position: refs/heads/master@{#814596}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 87-4265.0-1601892862-benchmark-87.0.4280.9-r1 to 87-4265.0-1601892862-benchmark-87.0.4280.10-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I6bef48fcf74d4f1e8d3407f1dca8b2fce92a74df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453636Reviewed-by:
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: Ie67a6515da3e08441081fe6c0d1aedcf090366d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445477 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#814594}
-
Vasilii Sukhanov authored
This reverts commit 4cabff3a. Reason for revert: broke virtual/text-antialias/international/complex-character-based-fallback.html on Mac10.14 https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/9098 Original change's description: > cc: Make UI resources use raster color space > > UI resources are rastered in sRGB, if the screen > has a different color space, a color conversion step > will be added to the fragment shader. > > This CL creates UI resources directly in the color space > used by the final compositing step, so that > the conversion can be skipped. > > Bug: 1129243 > Change-Id: Ia9659cbb993ebb16097079daf6c7e67aecf0525f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441932 > Commit-Queue: Daniele Castagna <dcastagna@chromium.org> > Reviewed-by: ccameron <ccameron@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814330} TBR=ccameron@chromium.org,dcastagna@chromium.org Change-Id: I7700b6b5bd8b706e17429a9bc4fb2b779aed3d94 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1129243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455348Reviewed-by:
-
Morten Stenshorne authored
This is a reland of 430b7621 Original change's description: > [LayoutNG] Don't truncate margins after spanners. > > A column spanner forcefully breaks a column, so any leading margins on > content right after the spanner shouldn't be discarded. > > Bug: 829028 > Change-Id: I767466677d72be2760306ddd531e847f52cfa8ca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445482 > Reviewed-by: Alison Maher <almaher@microsoft.com> > Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> > Commit-Queue: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813892} Bug: 829028 Change-Id: I83b1242b9a2e47b7205fc35e31b806e370141e8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454050Reviewed-by:
Alison Maher <almaher@microsoft.com> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#814592}
-
Fredrik Söderqvist authored
This moves the code from said method into a new helper class named SVGResourceInvalidator, streamlining it and splitting invalidation into 'effects' and 'paints'. At the callsites, make the invalidation calls conditional on the reference box (bounds) changing rather than layout dirty flags. We can do this because we no longer have an implicit dependency between effect bounds and the visual rect of the LayoutObject. Also use this helper in RemoveFromCacheAndInvalidateDependencies() since it matches the pattern used there (but add a comment about it possibly being unnecessary). Bug: 1028061, 1028063 Change-Id: Ic46481d925c6ac73e9eae4f8a9afc2ddd31c093c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449995Reviewed-by:
-
Noel Gordon authored
Add minor white space for better readability. GetDetails() returns the EXIF photographic details of the RAW image. piex-loader.js cleans this data later (remove trailing string null bytes and trim left and right, reformat floating point and integer numbers) for eventual presentation to users (in the FilesApp Quick View metadata info box for example). The color space names used are presentation names (sRGB, AdobeRGB1998) not values. The piex color space values are 'sRgb' and 'adobeRgb', and this note to point out the difference. Test: piex/tests.sh PASS Tbr: adanillo No-try: true Bug: 1132695 Change-Id: Ic80765334c0a78a18bd0cbdd2c114cbb16658cee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454354Reviewed-by:
-
arthursonzogni authored
Make sure MHTML document works correctly regarding sandbox flags. Bug: 1041376 Change-Id: I6bc12e7ab5861f51f39af44005f715c603c78e3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450152 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#814589}
-
Vasilii Sukhanov authored
This reverts commit b0ea6fb9. Reason for revert: reliably broke GcpSetupTest tests on Win https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64%20%28dbg%29/17611 Original change's description: > Read allowed domains from omaha policy. > > When cloud policies is enabled, GCPW will try to read the list of allowed domains from Omaha policy if they have been fetched already. If not it will fall back to the registry entry as before. > > Bug: 1134817 > Change-Id: Ia68a799af2216898e10e0c25ac94fbb2421e5afa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446546 > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Reviewed-by: S. Ganesh <ganesh@chromium.org> > Reviewed-by: Rakesh Soma <rakeshsoma@google.com> > Reviewed-by: Yusuf Sengul <yusufsn@google.com> > Commit-Queue: Robin Lewis <wrlewis@google.com> > Cr-Commit-Position: refs/heads/master@{#814393} TBR=pastarmovj@chromium.org,ganesh@chromium.org,yusufsn@google.com,rakeshsoma@google.com,wrlewis@google.com Change-Id: Ie9d1f9fb2aafe9c378f559736af2da6377e53869 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1134817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453393Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1602028663-1c726c728b4525c73e7ec5c77c97e6198df9f35c.profdata to chrome-mac-master-1602050190-974fbc4c4bfed178912ed1051cd970c3d7aa5e65.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I335851a461c021fb0a6959345c85bfc90edc091e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455295Reviewed-by:
-
Jinsuk Kim authored
This CL reduces the width of the area used for triggering gesture navigation. The reported conflicts with other UI can be alleviated. Bug: 1128629 Change-Id: I726453adc3dfd1848332ee668d11662c44afdb55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448070 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#814586}
-
Kuo Jen Wei authored
The preview video element is not interactable with chromevox. This CL prevent chromevox navigate to preview by creating preview video from template with aria-hide=true. Bug: 1135052 Test: Manually with chromevox Test: tast run <DUT> "camera.CCAUI*" Change-Id: I1dfc87b564dd1db119c10643b587fa254470493a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454913 Auto-Submit: Inker Kuo <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#814585}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 87-4265.0-1601895675-benchmark-87.0.4280.9-r1 to 87-4265.0-1601895675-benchmark-87.0.4280.10-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I961414c16f3eff834482ef68f56ccb9d371c01b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455297Reviewed-by:
-
Alice Wang authored
This CL adds a metric SuppressedSigninNotAllowed to Signin.AccountConsistencyPromoAction when web sign-in bottom sheet is not shown due to sign-in not allowed. Change-Id: Ic2f3334a28c1a46da955ed4bd1069f3d76651e00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450090Reviewed-by:
-
arthursonzogni authored
The patch [1] might introduce the kInitialDocument state to the RenderFrameHost. During code review, I was surprised not seeing the transition: kInitialDocument -> kRunningUnloadHandler. In theory, executing an unload handler from the initial empty document can happen. This patch adds a test showing it is possible. This turns out not to be crashing against [1]. The reason: the initial "fake" navigation for empty document IPC is received in between the creation and the deletion of the frame. This makes the RFH state to transition to kActive, just in time before the deletion. Even if this patch didn't prove its point, it it still a good addition. This might become more useful after the removal of the "fake" initial navigation (see [2]). R:acolwell@chromium.org CC:alexmos@chromium.org, rakina@chromium.org, sreeja@chromium.org [1]: https://chromium-review.googlesource.com/c/chromium/src/+/2430976/5 [2]: https://docs.google.com/document/d/1UjdxiDJ3sgVDbp0CZpsSntdwAYNMSfc2qajX4nzXfLY Bug: 1113357 Change-Id: Iaf146c77b767b3af37401dab968fb536efba5293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449474 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#814582}
-
Ben Reich authored
Change all const std::string into const std::string& to avoid copying strings on every function invocation. Test: browser_tests --gtest_filter="*FilesApp*" --devtools-code-coverage Bug: 1113941 Change-Id: Id3e5a767b575417cf122c85de961e752981ddb16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453343 Auto-Submit: Ben Reich <benreich@chromium.org> Reviewed-by:
-
