GitLab

Keyboard should be recreated with Shell::CreateKeyboard per user sign
in/out so to associate the new user to keyboard extensions. If the
keyboard extensions were associated with the previous user, it in turn
associated with an inactive IME and thus chrome.input.ime.sendKeyEvents
does nothing.

Currently the keyboard is recreated in Shell::OnSessionStateChanged when
the session state becomes ACTIVE. However, on the supervised user
creation window, the session state is not ACTIVE, but
LOGGED_IN_NOT_ACTIVE, which represents the state where the user
has signed in but the login UI is not hidden yet.
That's why virtual keyboard was not working there.

This CL fixes the issue by recreating the keyboard on LOGGED_IN_NOT_ACTIVE
too.

BUG=712873
TEST=Added unit test. Manually tested VK works:
- on supervised user creation window
- after multiprofile switch

Review-Url: https://codereview.chromium.org/2852403002
Cr-Commit-Position: refs/heads/master@{#480878}

BUG=644766

Review-Url: https://codereview.chromium.org/2946673003
Cr-Commit-Position: refs/heads/master@{#480877}

BUG=722527

Review-Url: https://codereview.chromium.org/2952603002
Cr-Commit-Position: refs/heads/master@{#480876}

Before this patch, calling PaymentRequest with a card type (credit,
debit, prepaid) filter outputs a DevTools console warning "Unable to
differentiate card types" and does not perform any filtering in user
interface. This prevented merchants that accept debit cards only, for
example, from using PaymentRequest API.

This patch adds a "type" field to "masked_credit_cards" autofill table.
This field is populated from sync, because the card type is known only
for server cards.

PaymentRequest UI now filters out cards that don't match the merchant's
requested card type explicitly. For example, suppose merchant requests
debit cards, then the UI will filter out credit and prepaid cards. The
user can still use unknown card types, but the user has to explicitly
select a card of unknown type in UI, because Chrome does not pre-select
it.

The PaymentRequest UI on Android and desktop has two changes when
merchant website requests a subset of [credit, debit, prepaid] card
types:
1) The payment methods section shows which card types are accepted. For
   example: "Debit cards are accepted." This helps the user to make the
   right choice when Chrome has not been able to determine card type.
2) The "Accepted cards" label for the card issuer network icons in the
   editor dialogs is customized based on the accepted card types. For
   example, "Accepted debit cards."
Throughout Chrome UI, the term "credit card" has been changed to "card."

Bonus: PaymentRequest UI on desktop now shows "Select shipping address
to see available shipping options" in the shipping address view for
merchants that require to see the shipping address first before
calculating the shipping prices.

This patch does not modify iOS behavior.

Bug: 602665
Change-Id: I5bce1e4d029e4dc8f8ebc9720dbb184ccac43090
Reviewed-on: https://chromium-review.googlesource.com/509808
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480875}

One was accidentally added in
https://codereview.chromium.org/2939733002/. Previously, it had no
cache.

BUG=734619

Review-Url: https://codereview.chromium.org/2945083002
Cr-Commit-Position: refs/heads/master@{#480874}

Currently gfx::Canvas does not accept float scale values, despite
cc::PaintCanvas providing the API to allow non integral scale values.

BUG=734684
COMPONENT=Gfx canvas

Review-Url: https://codereview.chromium.org/2943373002
Cr-Commit-Position: refs/heads/master@{#480873}

Graphics layers were not getting unregistered so the layer id of
the CanvasSurfaceLayerBridge's web_layer_ was getting leaked.

BUG=735029

Change-Id: If8ab2badba2fc25243834939e9c95d3c9582c3c0
Reviewed-on: https://chromium-review.googlesource.com/541496Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480872}

Revert of Reland: Move the files related to Android <-> Web credentials to a separate folder. (patchset #2 id:20001 of https://codereview.chromium.org/2949793002/ )

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 480867 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2ZmNjY1NmFiM2ExYzVmY2I2ZWQ3OGZhZTU1YjViYjk3ZjY3MmY3NWMM

Original issue's description:
> Reland: Move the files related to Android <-> Web credentials to a separate folder.
>
> Reland https://codereview.chromium.org/2949573002/
>
> BUG=630555
> TBR=engedy@chromium.org
>
> Review-Url: https://codereview.chromium.org/2949793002
> Cr-Commit-Position: refs/heads/master@{#480867}
> Committed: https://chromium.googlesource.com/chromium/src/+/ff6656ab3a1c5fcb6ed78fae55b5bb97f672f75c

TBR=vabr@chromium.org,vasilii@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=630555

Review-Url: https://codereview.chromium.org/2953443002
Cr-Commit-Position: refs/heads/master@{#480871}

TBR=jbudorick@chromium.org

Bug: 670879
Change-Id: I1cc29e26fc1effb2522e152debf0e95451742f2b
Reviewed-on: https://chromium-review.googlesource.com/540662Reviewed-by: Benjamin Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Benjamin Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480870}

TBR=charliea@chromium.org

Bug: 713222
Change-Id: I5bc5721105f1bc23fa9ac1ec39a6e9faa37c73a0
Reviewed-on: https://chromium-review.googlesource.com/540820Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: rnephew <rnephew@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480869}

This was functionally equivalent to SymmetricKey::key(), and also
returned a always true status code. Switching to key() allowed for
the simplification of downstream functions.

R=alemate@chromium.org, alokp@chromium.org, davidben@chromium.org, rogerta@chromium.org, stanisc@chromium.org

Review-Url: https://codereview.chromium.org/2934893003 .
Cr-Commit-Position: refs/heads/master@{#480868}

Reland https://codereview.chromium.org/2949573002/

BUG=630555
TBR=engedy@chromium.org

Review-Url: https://codereview.chromium.org/2949793002
Cr-Commit-Position: refs/heads/master@{#480867}

GC-supporting WebThreads get to have global thread-specific memory
cleared.

A proper support would involve making MemoryCoordinatorClient thread
friendly as base's. But this is more than enough for current thread
memory cleaning.

Bug: 730692
Change-Id: I07685c2ef66325b82a02b76536166cfbada8911a
Reviewed-on: https://chromium-review.googlesource.com/533796
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#480866}

computed font size is font size after zoom
adjusted font size is bounded by min/max font sizes

Those don't make sense in canvas-land

Bug: 730661
Change-Id: I1d840b784f18ade1952fba2f9548922afc974b6f
Reviewed-on: https://chromium-review.googlesource.com/535275Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480865}

This test generates logs that are too large to be proccessed by the recipe
engine without out-of-memory crashes.

TBR=kbr@chromium.org
NOTRY=true

BUG=713196

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I0f3ea6d83352f8799390108d70067c3676977cf1
Reviewed-on: https://chromium-review.googlesource.com/541616
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480864}

Enables some VR tests that were previously restricted to only run with
Daydream View paired to also run with Cardboard paired. Not all VR browser
tests were switched over due to some requiring Daydream View-only features
(controller input, NFC scanning) as well as crbug.com/734792

Bug: 734757
Change-Id: I64b2988ff3a24f7d5f31194d77d6290086de50be
Reviewed-on: https://chromium-review.googlesource.com/540456Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480863}

This relands https://codereview.chromium.org/2573773002/, which was
reverted in https://codereview.chromium.org/2654083006/.

Relevant spec changes since December 2016:
 * https://github.com/whatwg/fullscreen/pull/68
 * https://github.com/whatwg/fullscreen/pull/72
 * https://github.com/whatwg/fullscreen/pull/85
 * https://github.com/whatwg/fullscreen/pull/87
 * https://github.com/whatwg/fullscreen/pull/90
 * https://github.com/whatwg/fullscreen/pull/92

Updated tests for https://github.com/whatwg/fullscreen/pull/92:

 * document-exit-fullscreen-nested-manual.html asserts that fullscreenElement
   changes are not synchronous.

 * document-exit-fullscreen-timing-manual.html and
   element-request-fullscreen-timing-manual.html assert that fullscreenElement
   changes before the resize event. (They still fail in content_shell because
   there is no resize, but pass in chromium if run manually.)

 * element-request-fullscreen-and-exit-iframe-manual.html asserts that the order
   of "run the fullscreen steps" (firing events) is now frame tree order.

Bug: 402376
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I9c01b237ecfd7d74b28e3dbafcacdefe43416cdf
Reviewed-on: https://chromium-review.googlesource.com/521162
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: John Mellor <johnme@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480862}

Also:
  - removes no longer needed field trial on some lite page
integration tests
  - adds server response checks on new force lofi flag test
  - annotates the tests than need M-61 or greater.

BUG=701802

Review-Url: https://codereview.chromium.org/2941103002
Cr-Commit-Position: refs/heads/master@{#480861}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a8a39548..2cb002aa

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2950833002
Cr-Commit-Position: refs/heads/master@{#480860}

Bug: 721066, 731751
Change-Id: Ie59104f9d856a9226e53af34b125cdf2d266953e
Reviewed-on: https://chromium-review.googlesource.com/541403Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480859}

Bootstrapping: Send meaningful error code/message from Slave to Master using the following convention:
[1*, "network error"]
[2*, "authentication error"], e.g., [21, "Service unavailable"], ...
[3*, "enrollment error"], e.g., [31, "DMserver registration error"], [32, "Policy validation error"], ...
[4*, "other error"]

BUG=695235
TEST=Manually

Review-Url: https://codereview.chromium.org/2890383003
Cr-Commit-Position: refs/heads/master@{#480858}

Same as issue 535575 -- adds many missing blink test results, but removes flaky AccessibilitySource test results.
No code changes here other than adding some more default properties. Mostly adding test results files.

Unable to test for blink versions of the following properties:
- Selection: caret_offset, n_selections, selection_start/end
- HTML attributes: text_input_type, class, id, src, grabbed, drop_effect

Originally reviewed by dmazzoni and reverted because of failures on some test boxes for AccessibilitySource test.

Bug: None
Change-Id: I4826129a65fc2152ad2ecf938540a5392ebce07e
Reviewed-on: https://chromium-review.googlesource.com/541475Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480857}

BUG=735003
TBR=rmcilroy

Review-Url: https://codereview.chromium.org/2948793002
Cr-Commit-Position: refs/heads/master@{#480856}

This CL adds an internals page that will be used to build and debug
the desktop identity consistency feature. The current implementation
just does the piping and presents a simple page that has an Enable
Sync button that does not have any action attached to it.

This initial goal is to be able to make progress on the feature before
the mocks are final and approved by UI review.

BUG=733226
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2943093002
Cr-Commit-Position: refs/heads/master@{#480855}

BUG=724549

Review-Url: https://codereview.chromium.org/2936233004
Cr-Commit-Position: refs/heads/master@{#480854}

This CL improves the metrics landed in
https://codereview.chromium.org/2930353005/. It ensures timing metrics
are not recorded for same-document navigations. It also ensures that the
cache flag metric is not captured twice when PlzNavigate is enabled.

BUG=705559
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2944033002
Cr-Commit-Position: refs/heads/master@{#480853}

BUG=None

Review-Url: https://codereview.chromium.org/2947883002
Cr-Commit-Position: refs/heads/master@{#480852}

Previously the profile shortcut manager was only disabled if the user
data directory was overridden via the --user-data-dir command line flag.
Some (unit) tests use ScopedPathOverride however, which bypasses the
command line flag.

We now compare the value of the USER_DATA_DIR path to the
programmatically-defined default value instead.

Bug: 733861
Change-Id: I85854ba0821a0e41d28abfd8d5ec2f0873941aab
Reviewed-on: https://chromium-review.googlesource.com/539342Reviewed-by: Sorin Jianu <sorin@chromium.org>
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480851}

https://pdfium.googlesource.com/pdfium.git/+log/3962d80bde19..d5a13afe9265

$ git log 3962d80bd..d5a13afe9 --date=short --no-merges --format='%ad %ae %s'
2017-06-19 npm Fix signedness of height in BMP decoder

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Ifdd62777da76a78b871977ecdb370c0b95754823
Reviewed-on: https://chromium-review.googlesource.com/541535
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480850}

To implement the FeatureEngagementTracker for a New Tab feature,
code was added to include a kIPHNewTabFeature. This feature will
only be included in Windows.

Bug: 734176
Change-Id: I85764c5dd6373c0bfcda0bb4fe0fad1af5b1f02d
Reviewed-on: https://chromium-review.googlesource.com/538815
Commit-Queue: Catherine Chung <catherinechung@google.com>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480849}

In the future, each cc::Surface will have a SurfaceDependencyDeadline in
order to enable scoping of deadlines.

For example, a renderer resizing an OOPIF should not have any impact on
another Chrome window resizing: the OOPIF in window A should not impact
the resize deadline of window B and its renderer.

This CL takes us in that direction by decoupling SurfaceDependencyDeadline
from SurfaceDependencyTracker.

Bug: 689719
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I639c67ed9b7756533d356ac52efd97e3b97abcaf
Reviewed-on: https://chromium-review.googlesource.com/540016Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480848}

Also refactors getting/setting window bounds for WebContents so that
bounds changes are applied to the top level platform window.

Bug: 726286, 726288
Change-Id: I05300b19ea79bb1c1821644a438d885dbcaac26d
Reviewed-on: https://chromium-review.googlesource.com/527038
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480847}

BUG=none
TEST=None

Change-Id: I9d992e89eb517dfe3efc041b28c448017f3f0975
Reviewed-on: https://chromium-review.googlesource.com/538907Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Ben Henry <benhenry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480846}

There is just one instance of this crash and the report does not tell much about
whether its an invalid memory access. I am speculating that may be we need to check
if cache_ weak pointer is still valid before invoking a function on it in
DoFinishHeaders. Will keep a watch if there are more such crashes reported with more information.

BUG=734357

Review-Url: https://codereview.chromium.org/2946633002
Cr-Commit-Position: refs/heads/master@{#480845}

BUG=731038
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2944213002
Cr-Commit-Position: refs/heads/master@{#480844}

TBR=clamy@chromium.org

BUG=NONE

Review-Url: https://codereview.chromium.org/2947873002
Cr-Commit-Position: refs/heads/master@{#480843}

d3e4f09742d6 linux: Collect fxsave instead of fsave in ThreadInfo
8c802aace407 Add ReinterpretBytes which does a checked, variable size
             bit cast
c4f6ca3c6ac5 mac: Provide a larger thread state buffer for AVX-512 on
             10.13

Bug: 733387, crashpad:30, crashpad:185, crashpad:190
Change-Id: Ib4c1ab4c64c7e8697daca7695b81caa426e25b48
Reviewed-on: https://chromium-review.googlesource.com/541517Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480842}

BUG=647279

Review-Url: https://codereview.chromium.org/2950473003
Cr-Commit-Position: refs/heads/master@{#480841}

Automatically generated ARCMigrate commit
Notable issues:
* Taking over CL 2894003002
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2915043003
Cr-Commit-Position: refs/heads/master@{#480840}

https://skia.googlesource.com/skia.git/+log/fcc4a071d9df..369f7eaeb06f

$ git log fcc4a071d..369f7eaeb --date=short --no-merges --format='%ad %ae %s'
2017-06-20 halcanary Revert "remove unused api on xfermodeimagefilter"

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=halcanary@chromium.org

Change-Id: I929c1c3049ca656a9d898ec4f0c7cfa6e0de2ee7
Reviewed-on: https://chromium-review.googlesource.com/541495Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480839}