- 06 Sep, 2018 26 commits
-
-
Yuki Yamada authored
This CL removes unused includes regarding to blink::V8AbstractEventHandler and blink::V8EventListenerOrEventHandler. Bug: 872138 Change-Id: I0fec7187851165e36f1bef0508cecced1f1202b7 Reviewed-on: https://chromium-review.googlesource.com/1206751Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Yamada <yukiy@google.com> Cr-Commit-Position: refs/heads/master@{#589093}
-
Yuki Yamada authored
This CL renames V8 private property names regarding to V8EventListenerOrEventHandler. This property is used in not only blink::V8EventListenerOrEventHandler but also other classes (blink::V8EventListenerImpl, blink::V8LazyEventListener, blink::V8EventListenerHelper). These classes that is related to event listener is under redesigning as described crbug.com/872138 and it is confusing to use "V8EventListenerOrEventHandler" for the InterfaceName of private properties. Bug: 872138 Change-Id: I2509f60e7b527260b5f51a1e69305a53c3836302 Reviewed-on: https://chromium-review.googlesource.com/1206752Reviewed-by:
-
Kouhei Ueno authored
This CL adds a UseCounter that counts documents transferred as inner response of a signed exchange. In order to make this info available to Blink, this CL plumbs the |is_signed_exchange_inner_response| flag from content/browser to blink. - network::ResourceResponseInfo - blink::WebURLResponse - blink::ResourceResponse Bug: 863305 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I73e5e8e65c422c0882028d45a4443eb7d0d13d2a Reviewed-on: https://chromium-review.googlesource.com/1205920 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#589091}
-
Sadrul Habib Chowdhury authored
The BeginFrameAck needs to carry the trace-id from the BeginFrameArgs. So update the code to use the ctor for BeginFrameAcks that copies over all the necessary info from the associated BeginFrameArgs. BUG=none Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6b864e94cd1b7c6819f2fb1aeb35eef73bd5d253 Reviewed-on: https://chromium-review.googlesource.com/1196845Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#589090}
-
Mohammad Refaat authored
Add AppBarNavigationController.h/m files and ColorThemer sub directory Also added strings needed for AppBarViewController Bug: 880938 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I0b93329a2eca0b06b3ae803953b03912d105da57 Reviewed-on: https://chromium-review.googlesource.com/1208440Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#589089}
-
Marijn Kruisselbrink authored
The previous fix still passed nullptr as instance, so wasn't actually installing anything on the instance. This CL fixes that. Also adds SecureContext to the chooseFileSystemEntries method that wanted this to work. Bug: 878566, 878539 Change-Id: I7d7e6a5f62561ca5696b3066b3b7807ed61ff41c Reviewed-on: https://chromium-review.googlesource.com/1208812Reviewed-by:
-
Zhuoyu Qian authored
Rename blink/common/message_port/, blink/public/common/message_port/ and blink/public/mojom/message_port/ to messaging/. Bug: 868501 Change-Id: I2e657863803bb0a2c80baff970618075397c18b3 Reviewed-on: https://chromium-review.googlesource.com/1203753 Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#589087}
-
Matt Giuca authored
This is a reland of cac69564 (r587490, reverted in r588581). The reland fixes a browser test crash on Mac Cocoa (because it's running Views-only code) (https://crbug.com/880363). Added a ScopedMacViewsBrowserMode to force the test to run in Views mode. Original change's description: The title text color and side/bottom frame color now match the GTK theme, rather than the app's theme color (which clashed with the title bar background color, that would use the native color scheme regardless of the app theme color). Adds a browser test for GetFrameColor. Bug: 878636, 880363 Change-Id: I21003e78b4232cc6b8583267b08e2b37a823cfed Reviewed-on: https://chromium-review.googlesource.com/1205972Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#589086}
-
Sungguk Lim authored
Relevant code is moved to extensions/renderer/extension_bindings_system.cc. So use the new location in comment. Bug: None Change-Id: I1de550ca370de9981a80479452d2ee0e3113dbf7 Reviewed-on: https://chromium-review.googlesource.com/1206730 Commit-Queue: Sungguk Lim <limasdf@gmail.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#589085}
-
Ryan Cui authored
Pull in entries from the Mash filter file, for tests that are also failing in Mash. Also broadens filter coverage for some test classes using wildcards, to reduce the chance of a failure from a flakiness or new tests being added. Bug: 880584 Change-Id: Ic9d782e24fbd9c136c09b480fce5123190a53b43 Reviewed-on: https://chromium-review.googlesource.com/1208451 Commit-Queue: Ryan Cui <rcui@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#589084}
-
Tatiana Buldina authored
Change-Id: I21cad29f968ad4a01ee1edf5e16867658eecc9bb Reviewed-on: https://chromium-review.googlesource.com/1208723Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#589083}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fccfd62a. With Chromium commits locally applied on WPT: f22f8191 "Throw errors for invalid rolloffFactor and coneOuterGain" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24141 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mkwst@chromium.org: external/wpt/cookies NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: Ib811e6d522d36032724a7e6f1bcca120b19f7b75 Reviewed-on: https://chromium-review.googlesource.com/1208912 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#589082}
-
Devlin Cronin authored
Add a method to ExtensionPrefsObserver to monitor for runtime permission changes, and listen for these changes in the chrome://extensions page. This solves an issue where adding a new runtime host permission wouldn't be reflected immediately in the chrome://extensions page if it wasn't a permission directly requested by the extension, because there wouldn't be an active permissions change. Also reorder setting the "withhold permissions" pref to happen before adding the withheld permissions so that when the observers are notified, the bit is properly set. Bug: 878939 Change-Id: I98c70ecd951a6ebb3d3372fec797f3657215a2b1 Reviewed-on: https://chromium-review.googlesource.com/1196107 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#589081}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/01f0c698fb89..0f5a0b440989 git log 01f0c698fb89..0f5a0b440989 --date=short --no-merges --format='%ad %ae %s' 2018-09-05 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@0f5a0b440989 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I5dc37284401db2b6e1d91640832dd5d3361bfe00 Reviewed-on: https://chromium-review.googlesource.com/1208313Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589080}
-
David Black authored
DCHECK failure occured at this line: https://cs.chromium.org/chromium/src/ui/aura/window.cc?type=cs&l=244 Because we are only at 0% opacity right before we animate in or right before our window is removed, I think it should be safe to just avoid the DCHECK by using an approximate value instead of 0% opacity. Bug: b:113298385 Change-Id: I5dcc2b93a45a515e3a0d9278fc835e919cf01cd6 Reviewed-on: https://chromium-review.googlesource.com/1208823Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#589079}
-
Yoichi Osato authored
This patch adds some tests to confirm selection rect including block end linebreaks. Bug: 789870 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ia0b30c333944c86d27bf6568e550645d60f5e319 Reviewed-on: https://chromium-review.googlesource.com/1205752Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#589078}
-
Bailey Berro authored
- Previously SmbService and SmbFileSystem initialized their temp_file_manager_ members via a Task which was run on a non-UI thread. Changes to the class state should only happen on the UI thread to avoid race conditions. Bug: 879911 Change-Id: If79b0cd1162d2080c9ec1d44b0beb62cc53e8278 Reviewed-on: https://chromium-review.googlesource.com/1208193Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#589077}
-
Ned Nguyen authored
NOTRY=true TBR=kouhei@chromium.org, ksakamoto@chromium.org Bug: 876636, 879833 Change-Id: I6d2963cbc6ca33da5e62e68a17d19330786f864a Reviewed-on: https://chromium-review.googlesource.com/1208960Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#589076}
-
Pedro Amaral authored
If we are in regular browsing mode and the tab switcher is tapped twice quickly then the fade start animations will be triggered in an unexpected order. This is the normal ordering: 1. Empty slot fade animation start 2. Empty slot fade animation end (button disabled) 3. Home-button fade animation start (button enabled) 4. Home-button fade animation end Which means the button is enabled after all the animations complete. This is the problematic ordering: 1. Empty slot fade animation start 2. Home-button fade animation start (button enabled) 3. Empty slot fade animation end (button disabled) 4. Home-button fade animation end Which means the button is ends up disabled. This CL makes the animation end either enable or disable the button so this would happen: 1. Empty slot fade animation start 2. Home-button fade animation start (button enabled) 3. Empty slot fade animation end (button disabled) 4. Home-button fade animation end (button enabled) Which makes the button end up enabled. This does lead to a flicker from a grayed to normal when the tab switcher button is tapped quickly but I think it's fine since double tapping the tab switcher is a rare event. Bug: 879986 Change-Id: I0dc85e2f161a6e9e35f0a7e490e4f5cd71b5a9ba Reviewed-on: https://chromium-review.googlesource.com/1208443Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#589075}
-
Ian Kilpatrick authored
This function allows LayoutNG to correctly query the percentage resolution block_size in quirks mode. (see test case for an example of where this happened). We call this as we are crossing a legacy->LayoutNG boundary while creating the constraint space from a LayoutObject. The function will also be used in the CSS Layout API to provide the correct percentage resolution size. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I295145996f2460de1b25f85ff3784df6d6edbd30 Reviewed-on: https://chromium-review.googlesource.com/1194072 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#589074}
-
sczs authored
This CL changes BookmarksTableVC so it uses dynamic row height. It also updates some EG tests that started to fail once this change was made. I suspect this has to do with internal TableView management of cells when using dynamic height. The BottomCell test cell was moved to the penultimate position since we now snap at the top of the top cells instead of using the offset value of the TableView. This meant that the top cell was completely visible when re-creating the cache and the "Bottom Cell" was partially hidden. Bug: 869671 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I3f02b580332161b3bd30b3df1cb7da0c782edabb Reviewed-on: https://chromium-review.googlesource.com/1205806Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#589073}
-
Raymes Khoury authored
This enables the Permission Delegation feature by default. Bug: 802945, 818004 Change-Id: I1631401b929aee66def51d44e71e1d95915fcd54 Reviewed-on: https://chromium-review.googlesource.com/1201644Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#589072}
-
David Staessens authored
Adapted the v4l2 video slice decoder to make use of the GLFenceEGL wrapper, rather than using EGLSync functionality directly. Benefits: * Better code reuse and less code duplication. * Makes it easier to mock out dependencies when unit testing. * Easier to swap to different implementation if required. TEST=ran VDA tests on kevin Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If68ec97a92fba610762e475c108d0e6531c94be7 Reviewed-on: https://chromium-review.googlesource.com/1172176 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#589071}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fb0b7fe4..1b63139d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5151fc9d6722d838f1820b0eb2eca0b28b1b6820 Reviewed-on: https://chromium-review.googlesource.com/1208147Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589070}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8a49a283b96c..f23b4ab8b889 git log 8a49a283b96c..f23b4ab8b889 --date=short --no-merges --format='%ad %ae %s' 2018-09-05 dgarrett@google.com workspace_stage: Add WorkspacePublishBuildspecStage. 2018-09-05 saklein@chromium.org portage_util: incorrect category regex 2018-09-05 saklein@chromium.org Cleanup portage_util error classes. 2018-09-05 chingcodes@google.com signing: Add Subkey to KeyPair and Keyset 2018-09-05 chingcodes@google.com signing: Add Signer Configuration via INI files Created with: gclient setdep -r src/third_party/chromite@f23b4ab8b889 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Iae27e9f7ef30190f6b30a771dc9b348a28ddfd18 Reviewed-on: https://chromium-review.googlesource.com/1208298Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589069}
-
kristipark authored
Bug: 879064 Change-Id: If965059e7e279c772b9f808cf65a3119e60e1fa1 Reviewed-on: https://chromium-review.googlesource.com/1205097 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#589068}
-
- 05 Sep, 2018 14 commits
-
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/62228c41ea17..b9bb9e3f6683 git log 62228c41ea17..b9bb9e3f6683 --date=short --no-merges --format='%ad %ae %s' 2018-09-05 buildbot@webrtc.org Roll chromium_revision 4d01f290..87a4e8f8 (588344:588971) 2018-09-05 julien.isorce@chromium.org ScreenCapturerMac: make sure the desktop frame is zero initiaziled 2018-09-05 braveyao@webrtc.org desktopCapture: add braveyao@webrtc.org as OWNER 2018-09-05 danilchap@webrtc.org Add RtcpTransceiver::Stop to allow non-blocking destruction 2018-09-05 sakal@webrtc.org Add support for platform software video decoder implementations. 2018-09-05 mbonadei@webrtc.org Introduce GN arg rtc_exclude_metrics_default. 2018-09-05 danilchap@webrtc.org in RtpPacketizer add support for first packet reduction length 2018-09-05 magjed@webrtc.org Reland "Reland "Update video_quality_analysis to align videos instead of using barcodes"" 2018-09-05 brandtr@webrtc.org Remove deprecated VideoEncoder.Settings constructor. 2018-09-05 sprang@webrtc.org Clean away WebRTC-Vp8DontDropKeyFrames switch Created with: gclient setdep -r src/third_party/webrtc@b9bb9e3f6683 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:867003 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If34680549d9e4ac36e11fc8a86f192c208d636ea Reviewed-on: https://chromium-review.googlesource.com/1208296Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589067}
-
Clemens Hammacher authored
After the flag flip in v8 (https://crrev.com/c/1118485), this CL also changes the default of the chromium flag to enabled. Chromium always passes either "--no-wasm-tier-up" or "--wasm-tier-up" to d8, so the flag flip in v8 did not have any effect on chromium. R=titzer@chromium.org, hablich@chromium.org Bug: chromium:880790, chromium:787421 Change-Id: I3d6b66a90ca41cb093b9bfd174ca3bfc3c35263a Reviewed-on: https://chromium-review.googlesource.com/1206351Reviewed-by:
Michael Hablich <hablich@chromium.org> Reviewed-by:
-
Miguel Casas authored
This reverts commit e865a56b. Reason for revert: Causing gn analyze problems e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-dbg/331 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win32-rel/2125 /b/swarming/w/ir/cache/builder/src/buildtools/linux64/gn gen //out/Debug --check -> returned 1 ERROR at //components/viz/service/main/viz_main_impl.cc:22:11: Can't include this header from here. #include "media/gpu/buildflags.h" ^--------------------- The target: //components/viz/service/main:main is including a file from the target: //media/gpu:buildflags It's usually best to depend directly on the destination target. In some cases, the destination target is considered a subcomponent of an intermediate target. In this case, the intermediate target should depend publicly on the destination to forward the ability to include headers. Dependency chain (there may also be others): //components/viz/service/main:main --> //components/viz/service:service --[private]--> //media/gpu/ipc/service:service --[private]--> //media/gpu:buildflags Original change's description: > Do not use components/arc/common in non CrOs builds > > I found that (at least win) bots are using components/arc/common > stuff (see e.g. [1]), when this are supposed to be limited to > CrOs. This CL corrects that by sandwiching the appropriate > BUILD entries between if(is_chromeos). > > [1] https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8936282730877054816/+/steps/compile/0/stdout > /BUILD.gn mojom(media) > > Bug: 732531 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel > Change-Id: Ic0e807b5b97d1aadd5736377188456634424647d > Reviewed-on: https://chromium-review.googlesource.com/1208410 > Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: kylechar <kylechar@chromium.org> > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589056} TBR=lhchavez@chromium.org,mcasas@chromium.org,rsesek@chromium.org,kylechar@chromium.org Change-Id: I2638bbedd77268b26ca0c3ca4fc94606d196b545 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 732531 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1208678Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#589065}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/29a4a684af25..0c3dc59fc1c6 git log 29a4a684af25..0c3dc59fc1c6 --date=short --no-merges --format='%ad %ae %s' 2018-09-05 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader fe5861bf5bb1..ad5c2952ca88 (5 commits) 2018-09-05 mtklein@google.com fix sw extended transfer functions 2018-09-05 mtklein@google.com fix typo 2018-09-05 mtklein@google.com add src/opts headers to .gni files 2018-09-05 bsalomon@google.com Don't use MEM_MOVE=true with SkTArrays of sk_sp 2018-09-05 jvanverth@google.com Rip out variable offsetting 2018-09-05 bsalomon@google.com Fix GrAAConvexTessellator to handle cases slightly concave bistectors. 2018-09-05 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-09-05 herb@google.com Centralize the predicate for a glyph being too large for the atlas 2018-09-05 bsalomon@google.com Fix missing triangle when miter point omitted in GrAAConvexTessellator. 2018-09-05 brianosman@google.com Remove SK_USE_LEGACY_PRIMARIES_TO_XYZ 2018-09-05 skcms-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll skia/third_party/skcms 8a251fa55434..da4870efd7b7 (1 commits) 2018-09-05 caryclark@google.com Revert "makeSurface defaults to raster" 2018-09-05 egdaniel@google.com On GrAHardwareBufferImageGenerator store the owned texture as a GrGpuResource instead of GrTexture. Created with: gclient setdep -r src/third_party/skia@0c3dc59fc1c6 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:875650,chromium:851637,chromium:b/112859199 TBR=jvanverth@chromium.org Change-Id: I21e2f158cebeb62dbc38dfafaf9daea314093269 Reviewed-on: https://chromium-review.googlesource.com/1208297Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589064}
-
Christian Biesinger authored
Addref takes 3.27% in one profile (floats_2_100.html); reduce some of that. R=eae@chromium.org, ikilpatrick@chromium.org Change-Id: Ie88ebd6907afc64e8a138d4279549ba1bd0b80c8 Reviewed-on: https://chromium-review.googlesource.com/1208930 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#589063}
-
Sky Malice authored
There's a difference between downloading a page and prefetching a page. While ContentMetadata is passed for Prefetch, this action results in a download. Offline Pages component does not support and does not want to support holding/using this metadata for downloads. Bug: 879824 Change-Id: I3fd21936355aa94f74066ceac20fe3df2ac4c587 Reviewed-on: https://chromium-review.googlesource.com/1208910Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#589062}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/79ec21c5d4cf..7359954301e1 git log 79ec21c5d4cf..7359954301e1 --date=short --no-merges --format='%ad %ae %s' 2018-09-05 jmadill@chromium.org Update update_canary_angle script. 2018-09-05 jmadill@chromium.org Update jsoncpp DEPS. Created with: gclient setdep -r src/third_party/angle@7359954301e1 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:None TBR=fjhenigman@chromium.org Change-Id: I855c73346d68391bc8911ee429af037f2ef0ada2 Reviewed-on: https://chromium-review.googlesource.com/1208295Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589061}
-
Jared Saul authored
This change adds |chrome_user_context| and |full_sync_enabled| values to Unmask, GetDetails, Upload, and MigrateCards requests, as long as either of the appropriate flags are enabled. Bug: 840703 Change-Id: Ieb3baf980b68add43a3111c0902a03b574b1adcf Reviewed-on: https://chromium-review.googlesource.com/1208434 Commit-Queue: Jared Saul <jsaul@google.com> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#589060}
-
Raymond Toy authored
Catch more cases where we should throw errors if a new setValueCurveAtTime overlaps an existing setValueCurveAtTime event. Add some additional tests for more coverage. Also, some of the existing tests were using incorrect expected error types so fix them. Remove test expectations file since we pass now. Bug: 879767 Test: the-audioparam-interface/audioparam-setValueCurve-exceptions.html Change-Id: I14a7a7c9ab36955b7e084ca9148495860b661111 Reviewed-on: https://chromium-review.googlesource.com/1205719 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#589059}
-
Kevin Marshall authored
This change reduces load on system resources by terminating the webrunner and its instance of the Context (aka browser process) when the last Component channel is disconnected. Change-Id: If667cfa7680e02519105d8303bd734235f6180f9 Reviewed-on: https://chromium-review.googlesource.com/1208715 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#589058}
-
Takumi Fujimoto authored
Call on the CastDialogController in CastDialogView::SinkPressed() only if the pointer to it is not null. Also hide the dialog when the controller gets invalidated. Bug: 876900 Change-Id: I248385f086e3d3bde68ea2603afa77fca76e7d9c Reviewed-on: https://chromium-review.googlesource.com/1200523 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#589057}
-
Miguel Casas authored
I found that (at least win) bots are using components/arc/common stuff (see e.g. [1]), when this are supposed to be limited to CrOs. This CL corrects that by sandwiching the appropriate BUILD entries between if(is_chromeos). [1] https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8936282730877054816/+/steps/compile/0/stdout /BUILD.gn mojom(media) Bug: 732531 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ic0e807b5b97d1aadd5736377188456634424647d Reviewed-on: https://chromium-review.googlesource.com/1208410Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#589056}
-
Shakti Sahu authored
This CL attempts to add the following : 1 - Removes dependency on SelectableListLayout. 2 - Moves toolbar creation, menu action, search and toolbar shadow logic out of DownloadManagerCoordinatorImpl to a ToolbarCoordinator which wraps around the toolbar. 3 - ToolbarCoordinator delegates the user actions to various delegates. 4 - Also fixes a bug in search menu icon visibility update which wasn't happening due to listening to incorrect observer methods on RecyclerView.Adapter Bug: 850601 Change-Id: Id1ba4bc435040c3d01644d4ccff34a7f2dd73e97 Reviewed-on: https://chromium-review.googlesource.com/1173481 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#589055}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/cc5f350ab9c8..ad370480282d git log cc5f350ab9c8..ad370480282d --date=short --no-merges --format='%ad %ae %s' 2018-09-05 npm@chromium.org Roll third_party/freetype/src/ 2c8e6279a..f8af8fba7 (34 commits) Created with: gclient setdep -r src/third_party/pdfium@ad370480282d The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ie222bef540fab684e76c2c194a1795a476cf7338 Reviewed-on: https://chromium-review.googlesource.com/1208312Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589054}
-
