- 21 Jul, 2020 40 commits
-
-
Will Harris authored
This CL adds a test that creates a callback from operating system code to a module that has CFG enabled where the callback is not listed as a valid indirect target. Note: this test does not require dispatch guards to be present in chromium code, just for them to be present in OS code and for the CFG load config to be generated correctly. BUG=584575 Change-Id: Id6f5f4061f7237c23f08c8fe1b7471ea200f0628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308854 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#790587}
-
Liviu Tinta authored
Add azimuthAngle/altitudeAngle to pointer_events.idl and pointer_events_init.idl. Remove tiltX/tiltY default values from pointer_events.idl Add transform functions from tiltX/tiltY to azimuth/altitude. Add web platform test. Change default values for tiltX/tiltY. See Pointer Events spec Pull Request here: https://github.com/w3c/pointerevents/pull/323 Bug: 1069500 Change-Id: Ie04dd991e0223a793a037c784631ddf3a14e70a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165457Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#790586}
-
Alan Cutter authored
This CL adds a simple nullptr check to the web app menu for when the browser window has no tabs selected. Screenshot of no minor text: https://bugs.chromium.org/p/chromium/issues/attachment?aid=457537&signed_aid=Kjcn9nX_y395O5ZsqKkjjw==&inline=1 Bug: 1103331 Change-Id: I79c2f02edebde35772f6cd7c34f8e8c610f56040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309769 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#790585}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/84d986f9a16a..55b591c650f4 2020-07-21 brgoddar@microsoft.com Revert "Copy sourcemaps over in is_debug mode" 2020-07-21 tmathmeyer@chromium.org Add a "Hide player" to right click menu on media player list 2020-07-21 tmathmeyer@chromium.org Keep event pane scrolled to bottom if it is already there 2020-07-21 jacktfranklin@chromium.org Copy sourcemaps over in is_debug mode If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1104375,chromium:1104376 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5eb409c554e76f81993360346dcf935fc446b31f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310751Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790584}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b4a89393df3c..5e102dafa79a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC katydek@google.com,tmartino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1071603 Tbr: katydek@google.com,tmartino@google.com Change-Id: I6631df2152b7955e168f43d0d764a582e8659df7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310951Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790583}
-
Adithya Srinivasan authored
Issue was pointed out in crbug.com/1096617. We currently return the frame's token as the portal token (and vice-versa) to the renderer through the CreatePortal callback. Change-Id: I66bfc503e1ff31462002212a4cfd093c7a83d0a0 Bug: 1096617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305832Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#790582}
-
Xinghui Lu authored
Add Consumer and Enterprise suffixes for all metrics in RealTimeUrlLookupServiceBase, so we will be able to compare the metrics against each other. Also add a metric SafeBrowsing.RT.CanCheckDatabase to record whether Safe Browsing database can be checked in Safe Browsing URL checker. Bug: 1085261 Change-Id: I1e282a1fb5e614b2a7d1452ed82d9d6a1eb801f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302920 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#790581}
-
Naomi Musgrave authored
Tracks details of an outgoing connection, similar to IncomingShareTargetInfo. Also addressed feedback in change Id7265fb16da494737b76531b08c8cbc21ddb7c67 for simpler map access. Bug: 1084644 Change-Id: I39e3306b8c5f09f54fd32d7147019bb7bf44ebe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310489 Commit-Queue: Naomi Musgrave <nmusgrave@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#790580}
-
Songtao Xia authored
CL that disabled the tests: https://chromium-review.googlesource.com/c/chromium/src/+/2288108 Bug: crbug.com/1103380 Change-Id: I65ae262f66956dd7ca41ce23fc363853996f0f2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292812Reviewed-by:
John Emau <John.Emau@microsoft.com> Commit-Queue: Songtao Xia <soxia@microsoft.com> Cr-Commit-Position: refs/heads/master@{#790579}
-
Jesse Schettler authored
Move this class to its own .cc/.h files so it can be used in unit tests for other ServiceDiscoveryDeviceLister::Delegates. Also, move MakeServiceDescription() out of FakeServiceDiscoveryDeviceLister since it is specific to printers. This allows other tests to create their own ServiceDescriptions and pass them into Announce(). Bug: None Change-Id: I01f6e65c75b3a38819c74fac18f8034a8b62cac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300833Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#790578}
-
Ayu Ishii authored
Convert - Command - CommandCallback - SessionCommand Bug: 1007643 Change-Id: Ib052ab353cdad961d454e0ce3f1ec0e50c7595a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311113Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#790577}
-
Lei Zhang authored
Move more code that depends on PPAPI out of the "internal" build target. Bug: 1103478 Change-Id: Ifa7b2ca0565a261ca0493d97dab9bf216d47f35f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308490 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#790576}
-
Lexi Stavrakos authored
This function will allow QuotaManager to identify the state of storage pressure when given information about disk capacity and usage. QuotaManager will ultimately use this signal to dispatch a storage pressure event to script. This change also moves the kStoragePressureEvent flag from content_features to quota_features so that it can be accessed from quota code, and content can never be included in storage. This flag will remain accessible from content. Design Doc: https://docs.google.com/document/d/1-ZzFe7ITnzW-G7uymhv_obPwfQjJwzA6wh10tfl5tCw/edit Bug: 1088004 Change-Id: I84387f0599dde3404ffbae9014bf389bd0039ba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252032 Commit-Queue: Lexi Stavrakos <astavrakos@google.com> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#790575}
-
Nate Fischer authored
No change to logic. This exposes CommandLine.hasSwitch() and CommandLine.appendSwitch(). These are used all over the code base, and I can't think of a good reason to mark them @VisibleForTesting. I know Android WebView definitely needs to use these APIs, since we have some Java-only processes which need to check and manipulate the commandline state, as well as some browser-process code which needs to check the CommandLine early in startup (before native initialization). Bug: 1107950 Test: autoninja -C out/Default system_webview_apk Change-Id: Id0293c7e59c3c437cfd4870732de86e342b182d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310833 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#790574}
-
Archana Simha authored
This CL implements the getter and setter methods for extension specific ExtensionPrefs with string, integer and boolean values. Design Doc: http://go/extprefrefactor Bug: 1069560 Change-Id: I238cde708b678deb18ac0b5d97641c0be8bfe14c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300326 Commit-Queue: Archana Simha <archanasimha@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#790573}
-
Gary Tong authored
Bug: 1106950 Change-Id: I51441507a75d0280898a6597b61eb7a4f57dc0af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310319Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Gary Tong <gatong@chromium.org> Cr-Commit-Position: refs/heads/master@{#790572}
-
Andrew Grieve authored
Bug: 1107950 Change-Id: I8a44ddf86ba16ab28ada77dd0daba4d18fdba38f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310973 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#790571}
-
K. Moon authored
Updates painting classes (PaintAggregator, PaintManager, PaintReadyRect) to use gfx:: geometry types, instead of pp:: geometry types. Also updated OutOfProcessInstance and related code that uses the painting classes. Beyond renaming from the pp:: to the equivalent gfx:: types, some special cases needed to be handled: 1. In some cases, a member function of a pp:: or gfx:: type mutated in place, while the corresponding member function did not. These cases required extra care to find an equivalent replacement. 2. pp::Point was replaced with gfx::Point or gfx::Vector2d, depending on usage. pp::Point does not distinguish between these two cases. In all the remaining cases, the pp:: and gfx:: types behave the same. Bug: 1099020, 1101101 Change-Id: Ia899e57a728b6a517d7739f10f59825ffe75dfdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305594 Commit-Queue: K. Moon <kmoon@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#790570}
-
Clark DuVall authored
All of these APKs are now defined unconditionally since http://crrev.com/c/2173947 and http://crrev.com/c/2281021. It no longer makes sense to guard these with public_android_sdk, and this seemed to be causing some flakiness where the bots sometimes could not find the correct APKs. Bug: 1105096 Change-Id: I3f73acc277ebf7b40e9f93385a3a097b768662a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310356Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#790569}
-
Evan Stade authored
This reverts commit eb04b682. Reason for revert: lint fix is in ps2 Original change's description: > Revert "Refactor DisplayCutoutController to prepare for componentization." > > This reverts commit eb6596e7. > > Reason for revert: Suspected to have broken compile on Android: > https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/13404? > > Original change's description: > > Refactor DisplayCutoutController to prepare for componentization. > > > > DisplayCutoutController is split into DisplayCutoutController > > (destined for //components) and DisplayCutoutTabHelper (which stays > > in //chrome). Relocation/reuse will occur in a follow up CL. > > > > TBR=dtrainor@chromium.org > > Bug: 1095714 > > > > Change-Id: Ie119069ae4756baf73acc23d655665fce1d4c035 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296888 > > Commit-Queue: Evan Stade <estade@chromium.org> > > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#790402} > > TBR=dtrainor@chromium.org,estade@chromium.org,beccahughes@chromium.org > > Change-Id: I9821d88e9e06163aae93800ae84ed21fb32ac180 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1095714 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310131 > Reviewed-by: Katie Dektar <katie@chromium.org> > Commit-Queue: Katie Dektar <katie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790440} TBR=dtrainor@chromium.org,estade@chromium.org,beccahughes@chromium.org,katie@chromium.org Bug: 1095714 Change-Id: I19ef0731684caf927be643983c5d7161dac9de19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310834Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#790568}
-
John Abd-El-Malek authored
It didn't really need it; it was using it as a hint to know when it can be deleted when the frame goes away. A simpler method is to delete itself when it has no more receivers, if it's used in that mode. In the other mode where it's strongly owned, ownership remains the same. Bug: 1072817 Change-Id: I9d7f86b38650093df1c7d53964c3e6123961a16f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306013 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#790567}
-
Tommy C. Li authored
When the section headers are hidden or shown by a user, currently, screen readers give no indication that anything has changed. This CL fixes that and adds two new explicit announcements: - "Related to recent searches" section shown - "Related to recent searches" section hidden They are announced when the user shows or hides a section. It also fixes a bug in OmniboxPopupContentsView that caused some weird reentrant-like behavior, where updating the popup bounds would cause it to call UpdatePopupAppearance again. This bug suppressed the announcements, so this is needed too. Bug: 1099790 Change-Id: I96d847bc304d91a37ac306e2d9a27438d68856e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291234Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#790566}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/df76b72e..f6d3a035 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie84f8af10961a3b389cec4cbc2cdd7151ff6af03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310155Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790565}
-
adamta authored
Detects when the phone's theme changes from light to dark theme (or vice versa) and updates the feed VC with the new theme. Bug: 1085419, 1107843, 1107847 Change-Id: Ibd8a8243adae3e5cafec405b6c6d310bf2d156a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303312 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#790564}
-
Joel Hockey authored
See crbug.com/1106284#c1 for screen shots. If a PWA is showing the download shelf when it navigates away and the theme changes, we must notify that the theme has changed in order to redraw the download shelf correctly. This is required for all PWAs, not just those with tab strips. Bug: 1106284 Change-Id: I43a18cb578ee9ef8870a7bc602b373b16c3c52a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306492 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#790563}
-
Josh Nohle authored
Support move semantics needed for expiration scheduler instances in fake scheduler factory. Also, only allow fake scheduler callback to be invoked if scheduler is running. Note: I switch to std::map because I couldn't get base::flat_map to cooperate with move semantics. Bug: b/154864199 Change-Id: Ieef6474e9b1c8733dcb741a34f0ce3981b25fe46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309799 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#790562}
-
Mila Green authored
Updater: Fix ASAN test failure. Reland "Updater: AppWake starts the server instead of doing an update check." This is a reland of 4d324410 Original change's description: > Updater: AppWake starts the server instead of doing an update check. > > Bug: 1105589 > > Change-Id: I6d7e8b0b7858a4f1a538684758644f134318c0a4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298045 > Commit-Queue: Mila Green <milagreen@chromium.org> > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Sorin Jianu <sorin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790139} Bug: 1105589 Change-Id: I7946629e862fbd9d3d42113de16f194be7a56df7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309225Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Mila Green <milagreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#790561}
-
James Long authored
Previously, the users of the graph visualization component would need to ping it whenever there was a data update. Now, the users should supply as props the properties of pageModel that the graph should be reactive to. Since the page is now fully reactive, the "update" buttons for the inbound/outbound components have been removed. The goal of this is to make it easier to add UI components that interface with the visualization component. Bug: 1106107 Change-Id: I0578ad655fc6d13d7cc9cb7e444920846e02438b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310194 Commit-Queue: James Long <yjlong@google.com> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#790560}
-
Sasha McIntosh authored
Extends expiry of Renderer4.GpuImageDecodeState.CachePeakUsagePercent UMA. This metric is used to evaluate the finch experiment DecodeJpegToYuv. This UMA can expire after experiment launch. Bug: 1097844 Change-Id: I13fe1fb918d7d0b87562f4e2ec0e34148fd22f51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308172Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#790559}
-
Sami Kyostila authored
This patch implements a producer backend for Perfetto's client library using the mojo-based PerfettoService. This makes it possible to use Perfetto's client library to emit trace events. Since the perfetto service only supports one producer for each process, we introduce a feature flag (EnablePerfettoClientApiProducer) to enable the client library producer instead of the TraceLog implementation. Note that since no producers are actually ported to the client library yet, no trace events currently are generated when using this flag. Bug: b/158460810, 839071 Change-Id: Ief61793cba9fe6d5fb8e2a9330f9c06cccd0942a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283307 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#790558}
-
Matt Menke authored
QuicClientPushPromiseIndex allows at most one push per URL, which resulted in leaking data across NetworkIsolationKeys. Since this is a quiche-provided interface, the simplest workaround is to just create one per QuicChromiumClientSession instead. Bug: 1105544 Change-Id: I2bc975f4710bdc07f2a24f0ec6785c96000c5deb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302831Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#790557}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: If232d1b872328d80e0e6d0a661d66093e584bfb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310393Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#790556}
-
Adlai Holler authored
Bug: skia:104662 Change-Id: I186d6376b5685a1071ae5d57a871383422984b8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310889 Auto-Submit: Adlai Holler <adlai@google.com> Reviewed-by:
Robert Phillips <robertphillips@google.com> Commit-Queue: Adlai Holler <adlai@google.com> Cr-Commit-Position: refs/heads/master@{#790555}
-
Tommy Li authored
Currently, we persist to a pref when a user manually hides a suggestion group. This works because all suggestion groups are default-shown. In the near future, we plan to have some suggestion groups be default-hidden. So now, we should persist if a user has manually shown a suggestion group as well. (See go/desktop-chrome-polaris-engdesign for details.) This CL obsoletes the "omnibox.hiddenGroupIds" list pref and instead creates a new "omnibox.suggestionGroupVisibility" dictionary pref, which has the group ID as the key, and stores two possible states: - HIDDEN (1) - SHOWN (2) If the user has never set the preference, we plan to eventually return a third value: - DEFAULT (0) In that case, the callsite will have to decide on the proper default visibility, which will be either a client-side flag or a server-provided hint per-group. One more thing: I've purposely not provided a migration path from the old pref to the new pref. I did this for simplicity sake. I've looked at the UMA, and there are only ~25 count usages of the collapse / expand feature each on Stable in the last 30 days. Across all Channels, there's ~550 each over the last 30 days. I think a significant fraction of that 550 is Chromium developers. In other words, I think simplicity trumps migrating the prefs of the scant few users who've set this pref so far. Bug: 1106096 Change-Id: I8f0bf559f897474c18b9bf90cc33cb8b040cb0fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303862 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#790554}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0bc68bd16484..a5d9c1a45c2b 2020-07-21 danilchap@webrtc.org In DependencyDescriptor rtp header extension drop partial chain support If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6987329a0f8f7bd7a9e62fbc5cf23b55cbb2695c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310320Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#790553}
-
Matt Jones authored
Bug: 1062099 Change-Id: If923b8cd540f6004bc13603d98c81a00c80f4d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307487 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#790552}
-
Ali Juma authored
Change-Id: Id23c088afaa250faf5ac7233deccb94424e9a456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310802Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#790551}
-
evliu authored
This CL adds an API key for the Speech On-Device API (SODA). Usage of the API key is outlined here: go/securing-soda-on-chrome. Bug: 1107615 Change-Id: Ic92418407e17a88426559251e77797bd0b34818b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309133Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#790550}
-
Mohsen Izadi authored
Based on the data gathered from running the experiment on canary/dev and beta, it seems that the disabling latency recovery for both main and impl threads is an overall performance win. So, we are going to re-enable the (now-expired) experiment on stable and move forward with its gradual rollout. Bug: 993895 Change-Id: I5c45c3cb469d14cf53193d0af6a560842ce02be2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309188Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#790549}
-
Nnamdi Theodore Johnson-Kanu authored
Bug: 1106937 Change-Id: Idd4931433c8421187510df98b200b93e51da508c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309757 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#790548}
-