GitLab

BUG=137140


Review URL: https://chromiumcodereview.appspot.com/10808094

TBR=sergeyu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10829040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148578 0039d316-1c4b-4281-b951-d872f2087c98

Currently, it is fired when the DownloadItem is created, not when it has its filename, not when it's persisted. Listeners should observe the item for those kinds of state changes.
Those Observers that care about the filename (any of the filenames) should check whether it's empty() before using it. The DownloadItem[Impl] will UpdateObservers when the filename changes.
OnDownloadCreated is not fired for SavePackage downloads. It will be fired when we are comfortable with the user interacting with them, which might not happen until after the SavePackage integration.
ExtensionDownloadsEventRouter filters out temporary downloads, which are downloads whose DownloadCreateInfo.save_info.file_path is not empty(). GData also calls SetIsTemporary after OnDownloadCreated is fired, but only for SavePackage downloads, so EDER is safe there.

Review URL: https://chromiumcodereview.appspot.com/10735089

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148576 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148575 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r9247: (robertm) Roll archived pexe rev to compensate for a test change in rev 9235.
r9248: (arbenson) Use AddBootstrap function where applicable
r9249: (kschimpf) Update llvm revision: http://codereview.chromium.org/10808110
r9250: (robertm) Move pnacl toolchain size test from build script bot script.
r9251: (mcgrathr) Get rid of __nacl_tp_alignment
r9252: (robertm) Prune used binutils ld.bfd from pnacl toolchain.
r9253: (mcgrathr) Fix TLS alignment calculation
r9254: (jvoung) Emit a warning when bitcode file contains a known bug for ARM
r9255: (jvoung) Remove debug listing code for pnacl/build.sh (related to
r9256: (bsy) Add a developer hint log message for when RLIMIT_AS is the culprint in startup failure.
r9257: (mseaborn) Remove the unused function NaClGetEbx()
r9258: (mseaborn) Remove the unused file nacl_syscall_weak.S
r9259: (mseaborn) Use the DEFINE_GLOBAL_HIDDEN_IDENTIFIER macro consistently in assembly code
r9260: (eaeltsin) Debug stub: provide meaningful backtrace when stopped in syscall
r9261: (mseaborn) Thread suspension: Create an internal API for getting and setting registers
r9262: (pasko) validator_ragel: move the irt test from Makefile to scons

BUG=none
TEST=nacl_integration

Review URL: https://chromiumcodereview.appspot.com/10824040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148574 0039d316-1c4b-4281-b951-d872f2087c98

Because there's an expectation that this flag will need to be reverted on a
branch, add both the enable and the disable flags so that only
web_contents_impl.cc will need to be touched to change the default value.
Both can be removed later, once this setting sticks.

BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10825027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148572 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136844

Review URL: https://chromiumcodereview.appspot.com/10823033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148571 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/10834023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148570 0039d316-1c4b-4281-b951-d872f2087c98

BUG=90448
Review URL: https://chromiumcodereview.appspot.com/10834034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148568 0039d316-1c4b-4281-b951-d872f2087c98

Adds a flag --enable-hidpi-pdf-plugin so HiDPI rendering in the PDF Viewer can
be controlled by this flag.

Add a pepper priv interface to query the flag.

BUG=114674
TEST=Manual

Review URL: https://chromiumcodereview.appspot.com/10802004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148567 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136240,137785
TEST=
Review URL: https://chromiumcodereview.appspot.com/10829025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148566 0039d316-1c4b-4281-b951-d872f2087c98

This tool is actually broken because the number of ciphersuites has
exceeded the packing structure that it uses. None the less, we might
need to update in the future and this will save me some bother in the
future.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148565 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10825020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148564 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122913
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10696182

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148563 0039d316-1c4b-4281-b951-d872f2087c98

BUG=136844
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10826027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148562 0039d316-1c4b-4281-b951-d872f2087c98

BUG=137676
TEST=compiles
TBR=OWNERS

Review URL: https://chromiumcodereview.appspot.com/10831025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148560 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148559 0039d316-1c4b-4281-b951-d872f2087c98

BUG=90448
Review URL: https://chromiumcodereview.appspot.com/10821037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148558 0039d316-1c4b-4281-b951-d872f2087c98

Roll Protobuf r415:r423.                                                                                                                                                                                                                                                         

1) Got an upstream diff 415:423 from svn
2) Applied
3) Updated protobuf.gyp

Changelog:

r423 Add support for NaCl in atomicops.
r422 Fix issue/333. skip any escaped characters in quotes.
r421 -lz in protobuf.pc belongs in Libs.private, not Libs 
r420 set _VARDADIC_MAX=10 preprocessor definition to make test pass in vc11.
r419 Allow configure to disable maintainer mode 
r418 Update atomicops to support new platforms where intptr_t = long.
r417 Fix a NULL/bool conversion.
r416 Fix issue 378

Review URL: https://chromiumcodereview.appspot.com/10793026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148557 0039d316-1c4b-4281-b951-d872f2087c98

Also fixed a little nit in the chrome.bookmarks.create() call, which would return the wrong error code when given an invalid URL.

BUG=18979,89762
TEST=ExtensionApiTest.Bookmarks in the browser_tests is green


Review URL: https://chromiumcodereview.appspot.com/10831012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148556 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10829023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148555 0039d316-1c4b-4281-b951-d872f2087c98

The app-list closes itself when a click happens outside the bounds of
the window. However, if the click happens on a menu that is hanging
outside the window-bounds, then the app-list should not close.

BUG=131282
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10831024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148554 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139136
TBR=sergeyu@chromium.org
TEST=

Review URL: https://chromiumcodereview.appspot.com/10827039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148553 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138611
TEST=Breadcrumbs and search breadcrumbs look fine in FileManager.

Review URL: https://chromiumcodereview.appspot.com/10824009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148552 0039d316-1c4b-4281-b951-d872f2087c98

BUG=137999
TEST=The search box grows smoothly when focused.

Review URL: https://chromiumcodereview.appspot.com/10834029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148551 0039d316-1c4b-4281-b951-d872f2087c98

No code change.

TBR=henrika


Review URL: https://chromiumcodereview.appspot.com/10834032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148549 0039d316-1c4b-4281-b951-d872f2087c98

Note that JSEP 00 is still supported and we are adding support for JSEP01.


TEST= Run content unit tests and  ./chrome/test/functional/webrtc_call.py

apprtc.appspot.com is also a nice page to try out. Start chrome with the enable-peer-connection flag.



Review URL: https://chromiumcodereview.appspot.com/10804004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148548 0039d316-1c4b-4281-b951-d872f2087c98

We short circuit emulated mouse events (they are emulated on a touch) so
that these events don't get passed to javascript. The short circuit logic
also short-circuited the mouse capture/release logic, which caused failure
when touch happened during a mouse-capture.  

This commit ensures that only the call to ForwardMouseEvent is short-
circuited for emulated events.

BUG=132068
TEST=


Review URL: https://chromiumcodereview.appspot.com/10802085

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148547 0039d316-1c4b-4281-b951-d872f2087c98

BUG=135328
TEST=auth status is shown in chrome:drive-internals properly

Review URL: https://chromiumcodereview.appspot.com/10808116

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148544 0039d316-1c4b-4281-b951-d872f2087c98

It works transparently when it is run through another method, like when
embedded in a .isolate command and additional commands are used.

R=cmp@chromium.org
NOTRY=true
BUG=
TEST=new unit test


Review URL: https://chromiumcodereview.appspot.com/10829014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148543 0039d316-1c4b-4281-b951-d872f2087c98

http://crrev.com/93034 missed an option.

BUG=114101
TEST=install system-level chrome (at HH:MM C:\some\path\mini_installer.exe --system-level --verbose-logging --multi-install --chrome), set brand="CHXX" in HKLM\SOFTWARE\Google\Update\ClientState\{8A69D345-D564-463c-AFF1-A69D9E530F96}, then update chrome (at HH:MM C:\some\newer\mini_installer.exe --system-level --verbose-logging --multi-install) and see that the toast appears.  Also make sure it still works for user-level installs.
TBR=cpu@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10832031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148542 0039d316-1c4b-4281-b951-d872f2087c98

This is based on a suggestion from derat@ at
http://codereview.chromium.org/10808108/

Reference:
http://code.google.com/apis/accounts/docs/OAuth2WebServer.html

BUG=none
TEST=out/Release/unit_tests --gtest_filter='GData*'

Review URL: https://chromiumcodereview.appspot.com/10827018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148540 0039d316-1c4b-4281-b951-d872f2087c98

Re-enabling the TryChromeDialogBrowserTest.ToastCrasher crash, as the underlying cause that made the test fail seems to be gone.

Also added a comment.

BUG=127396
TEST=None, enabling a test.
Review URL: https://chromiumcodereview.appspot.com/380001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148539 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138401
TEST=manual: open chrome://extensions, toggle Developer Mode, observe animation

Review URL: https://chromiumcodereview.appspot.com/10828008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148538 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=ran chromeos_unittests


Review URL: https://chromiumcodereview.appspot.com/10830004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148537 0039d316-1c4b-4281-b951-d872f2087c98

It broke sync_integration_tests:
TwoClientExtensionSettingsAndAppSettingsSyncTest.AppsStartWithSameSettings
TwoClientExtensionSettingsAndAppSettingsSyncTest.AppsStartWithDifferentSettings

TBR=dcheng@chromium.org

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/10823037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148536 0039d316-1c4b-4281-b951-d872f2087c98

BUG=126810
TEST=Copy/paste and drug&drop operations.
Review URL: https://chromiumcodereview.appspot.com/10692090

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148535 0039d316-1c4b-4281-b951-d872f2087c98

This fixes 'licenses.py scan' for the projects relevant to the Android WebView
build.

BUG=138921

Review URL: https://chromiumcodereview.appspot.com/10796121

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148534 0039d316-1c4b-4281-b951-d872f2087c98

First step towards moving AudioDevice and AudioInputDevice from content/ to media/audio.  This cl introduces new IPC interface files in media/audio that have the definitions of an IPC layer for AudioDevice and AudioInputDevice.
AudioMessageFilter, AudionInputMessageFilter and others have been updated to use definitions from these file but in order to keep the diffs simple, I haven't actually moved the files over to media/audio. That will be the next step (and then no code changes should be needed).

TEST=There should be no functional changes here.
  If there are problems, they should be caught by our existing unit
  tests or build errors.

Review URL: https://chromiumcodereview.appspot.com/10790121

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148533 0039d316-1c4b-4281-b951-d872f2087c98

This allows easily running a unit test target on multiple simulator configurations.

BUG=None
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10832030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148532 0039d316-1c4b-4281-b951-d872f2087c98

This CL moves the printing.* prefs to the profile where they arguably
should have resided in the first place. Unit tests are simplified by
this change as the prefs can now be checked without verifying that local
state exists. There is no user-visible change as the prefs are not
exposed via the UI.

BUG=137814
TEST=all unit_tests pass, all printing browser_tests pass


Review URL: https://chromiumcodereview.appspot.com/10808006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148531 0039d316-1c4b-4281-b951-d872f2087c98