- 07 Oct, 2019 40 commits
-
-
Peng Huang authored
In follow up CLs, this VulkanInfo will be sent from viz process to browser process and then displayed in about:gpu page. Bug: 887018 Change-Id: Idde45c731aed65092fc384e529e8b5028c93e545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845872Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#703517}
-
Eric Foo authored
Most files in this CL either use "Build" or "Test" components See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I1ab5e956e11553ad6ca548ac0bd4669daeb631ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808169Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#703516}
-
Philip Rogers authored
Optimizing email Change-Id: I8d3bc4c77a10022f29d68fbcdb91c6f88327009d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842952 Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#703515}
-
kylechar authored
Fix the last failing test and remove LayerTreeSettings enable_surface_synchronization entirely. Bug: 985009 Change-Id: I7369f926a4c1157d8c77ee19803400f34c485736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822845 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#703514}
-
Anastasia Helfinstein authored
Currently, Switch Access looks for the menu panel each time it needs it. Instead, we expect the node to be in the accessibility tree once its javascript has loaded. Bug: None Change-Id: Ic48a3110c1c9ce40ab6581bf78c782b3f2a9d17e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841503Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#703513}
-
Owen Min authored
Use --vmodule=dice_turn_sync_on_helper=2 to enable this log message. It's possible that user cloud policies which are fetched during sign-in process may block sign-in in the end. It's not easy to debug under this situation because these policies will be removed right after sign-in is terminated. And chrome://policy page will never show these policies. Print policy values into log helps developers to understand policy values change user cloud policies are merged. Bug: 991322 Change-Id: I9b2d4358ec32f86b7fc3e5f2e3d06c4511f62a2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835020Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#703512}
-
Evan Stade authored
NOTIFICATION_PROFILE_DESTROYED was only used for normal (on the record) profiles. But normal profiles aren't destroyed until browser shutdown, and are destroyed after SafeBrowsingService is destroyed, so there is no need to listen to this notification. NOTIFICATION_PROFILE_ADDED can be replaced with ProfileManagerObserver::OnProfileAdded. Also, delegate between the two constructors (prod and test), so code needn't be duplicated between them. Bug: 268984 Change-Id: Iab614421b7c51136ccae79a45d00f8ee709a73b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832883 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#703511}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/107c97c8377d..3306bbe476fd git log 107c97c8377d..3306bbe476fd --date=short --no-merges --format='%ad %ae %s' 2019-10-07 ehmaldonado@chromium.org depot_tools: Remove buildbucket.py 2019-10-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-07 raul@tambre.ee gclient_utils: buffer output as bytestrings in Annotated 2019-10-07 raphael.kubo.da.costa@intel.com download_from_google_storage: Decode string passed to re.search() 2019-10-07 raphael.kubo.da.costa@intel.com download_from_google_storage: Do not call decode() on a string twice Created with: gclient setdep -r src/third_party/depot_tools@3306bbe476fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:984182,chromium:984182,chromium:1007872,chromium:984182,chromium:1007872 Change-Id: I0c124ecc2fb9d1eda0e129fedee04c7195c4a2cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845574Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703510}
-
Xida Chen authored
Right now in FrameSequenceTracker::ReportMetrics, we compare the throughput of the main thread vs the compositor thread, and report the one with smaller throughput as the SlowerThread. There is an error in the logic of determining which one is the slower thread. In particular, currently we didn't consider the case where the compositor and the main thread having the same throughput. This CL fixes the error, and added a unit test. Bug: None Change-Id: Ib90b625665f508a8dab610a9ab07f90f6c4f1c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838354 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#703509}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7c06777ab088..a639f7a24477 git log 7c06777ab088..a639f7a24477 --date=short --no-merges --format='%ad %ae %s' 2019-10-07 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 10156469..5ac2340a (703248:703358) Created with: gclient setdep -r src/third_party/webrtc@a639f7a24477 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I5bd1ca42505b573376b283efca952525efb9047c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845705Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703508}
-
Anastasia Helfinstein authored
This is a pure refactor. Bug: None Change-Id: I6b527024ef2a3d79b6c86e8c66b7d9c4853afd68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841740Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#703507}
-
Bill Budge authored
This reverts commit d99ef40d. Reason for revert: Causes browser crashes https://bugs.chromium.org/p/chromium/issues/detail?id=1011879 TBR=kinuko@chromium.org Original change's description: > [code caching] Handle small data with a single read/write > > - Many small reads and writes are observed, especially with the JavaScript > code cache. Detect these and write all data into the entry's stream 0, > and clear stream 1. When reading, detect the entry size and for small > data, skip the stream 1 read and copy the data from the stream 0 read. > - Changes the stream 0 data (again) to a header with response time and > data size. The data size, while not strictly necessary right now, will > be needed if we implement de-duplication of identical entries stored by > multiple origins. We can add the code hash to this header, and the size > field will disambiguate between small entries and large de-duplicated > entries where we use the hash as a key to the data. > - This change should make small reads faster than before, as synchronous > completion of stream 0 reads is observed. Otherwise, there should be no > change in performance. > - Renames the buffers and completion callbacks to reflect small/large data > distinction. > > Bug: chromium:992991 > Change-Id: I6fb5337ef1e4148dd9f300f0a8c85acb401be62e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834562 > Commit-Queue: Bill Budge <bbudge@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Mythri Alle <mythria@chromium.org> > Reviewed-by: Maks Orlovich <morlovich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702667} TBR=bbudge@chromium.org,kinuko@chromium.org,mythria@chromium.org,morlovich@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:992991 Change-Id: Ieae20ed3ad7646ca09e088accd90fbd7cbda2bdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845576 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#703506}
-
Willie Koomson authored
This change adds a throttling service for Crostini, CrostiniThrottle. This class is a KeyedService that holds observers and throttles the VM on a change in observer state. Currently the class it is inactive since it holds no observers and is not instantiated anywhere. Bug: 997397 Test: Run CrostiniThrottleTest unit test Change-Id: I344075908abc6c86f311e2c25f5c7ebead25fa42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836086 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#703505}
-
Sebastien Marchand authored
The CL that uses this in freezing will follow. Bug: 999594 Change-Id: I8dd17798ce4f707e99d57d0e9aec6d9da91d5f88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846091 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#703504}
-
David Maunder authored
Bug: 1011413 Change-Id: Ief7b8e89b6834dc3c69358c137dfd6544073a630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841895 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#703503}
-
Ben Pastene authored
Bug: 1011937 Change-Id: I0e04b43f160f60a5750a241fa6113360932e557a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842674Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#703502}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6acfca3ad3e3..2682b5a02d16 git log 6acfca3ad3e3..2682b5a02d16 --date=short --no-merges --format='%ad %ae %s' 2019-10-07 jmadill@chromium.org Documentation maintenance. 2019-10-07 jmadill@chromium.org Roll angle-internal with new GLES 1.0 fixes. 2019-10-07 bsheedy@chromium.org Reland "Add export_targets.py to presubmit" Created with: gclient setdep -r src/third_party/angle@2682b5a02d16 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: chromium:1003151 Change-Id: Id27d80e406b89e10d16f78df9a971be67deb2d41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845702Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703501}
-
Haiyang Pan authored
Currently emulator fyi bots have test failing due to the missing avd-config files. This CL adds them to the BUILD.gn Bug: 922145 Change-Id: Ide614113094585999b0370d219f55bd319f123b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846037Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#703500}
-
Yulun Wu authored
Bug: 1007204 Change-Id: Ic6bea1eef809db4e995040d4bee82ea05aa57c7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838978Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#703499}
-
Yulun Wu authored
App_list: Update Search Result Page View's OnBoundsChanged to reset rect based on size instead of size and origin. Bug: 1010724 Change-Id: Ic6061f243942a5c1d835f0df002321ee46fba78a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841574 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#703498}
-
Peter Kasting authored
Originally, when the table was visible, the device chooser had three children: a scroll view containiner the table, and two invisible centered labels. In https://chromium-review.googlesource.com/c/chromium/src/+/1837079 I reworked this to center the labels using anonymous views with layout managers. This meant that the device chooser now contained three visible full-size children (which, in two cases, just contained an invisible centered child). As a result the last child (which was highest in Z order) became the event handler at all times, and while it would bubble events to its parent, there was no way for them to get over to the sibling scroll view. The solution is to toggle the visibility of these centering views, rather than toggling the visibility of their contained labels. This causes event targeting to select the scroll view again. Also does various additional cleanup I noticed while working on this. Bug: 1011536 Change-Id: I27c496ebf4899b94bd442a1eaeb5e6ddbca387a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843294 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#703497}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 280f7621. With Chromium commits locally applied on WPT: c19433ef "Reland "[ChromeDriver] Stop using --ignore-certificate-errors"" 23748e60 "Change text directive to text=" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: meade@chromium.org: external/wpt/web-animations msramek@chromium.org, mkwst@chromium.org: external/wpt/clear-site-data NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I73a8c68e42dc30667c7e68e4e2101358422edbae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845854Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703496}
-
Andrew Luo authored
Change-Id: Iafc4de13add480e4ef58c8d3a8b8b82473fa3594 Bug: 1011098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834574Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#703495}
-
Irina Yatsenko authored
This allows to avoid build breaks when new ids are added on v8's side. Bug: chromium:1010312 Change-Id: Ia375cc842137e4b58f801e0fcc63d2222b0cf482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841933Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Irina Yatsenko <irinayat@microsoft.com> Cr-Commit-Position: refs/heads/master@{#703494}
-
Yuwei Huang authored
Now only messages with allow_dont_show_again set to true will show the "Don't show again" check box. Bug: 1001291 Change-Id: I920a8bf6188a063a078d230b38c4543ae108bb25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846237Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#703493}
-
David Van Cleve authored
crrev.com/c/1808144 replaced the ancient --no-referrers command-line switch with a base::Feature. The change contained a bug and didn't add sufficient test coverage beyond what was already present---and there was no test coverage already present! This patch remedies both the bug and the lack of coverage: 1. The bug was a failure to sync the base::Feature to a profile-scoped pref; the previous patch only propagated the base::Feature to a system-scoped (local state) pref. This is fixed by having the pref's default value, set in prefs_tab_helper.cc, depend on the value of the Feature. 2. This patch adds additional referrer policy browsertest coverage to make sure that, when the NoReferrers feature is on, the browser sends no referrers. R=jochen Bug: 1004486 Change-Id: Idc98b6d912dd59b23eab6eeef128e7a6992758ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842040 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#703492}
-
Tibor Goldschwendt authored
The purpose of this CL is to provide ICU support for 30 extra languages (see crrev/c/1648623 for more details). crrev/c/1811973 adds a feature module that delivers an extra ICU data file containing support for the aforementioned extra languages. To make use of this extra data file, we check at browser process startup whether the extra ICU feature module is installed and if so init ICU with the extra data file inside the module. We retrieve the module install state from the ContentBrowserClient as feature modules are a chrome layer concept and the ICU initialization happens in the content layer. The extra ICU data file is applied _before_ the main ICU data file. Otherwise, the main ICU data file would override the extra languages. Requires crrev/c/1834464. Bug: 1006794 Change-Id: Ic7c14bf3437309b90cf2ce205ade14da937203c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818876 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#703491}
-
Lily Chen authored
This change hooks up the CookieMonster's CookieAccessDelegate to CanonicalCookie::IncludeForRequestURL and IsSetPermittedInContext, by passing them the CookieAccessSemantics for that particular cookie that is returned by the delegate. The access semantics is fed into CanonicalCookie::GetEffectiveSameSite, where it is taken into account when computing the effective SameSite mode of a cookie. For now, the default value of the parameter is CookieAccessSemantics:: UNKNOWN, so other callers do not yet pass the right access semantics to IncludeForRequestURL and IsSetPermittedInContext. They will be updated in subsequent changes. Bug: 978172 Change-Id: Icf0dc68738c3651c8e0fc648e597658485dc799c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845233 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#703490}
-
Andrew Grieve authored
Bug: 982762 Change-Id: I6bcd8ea8be2fef88e907248b4b56a6ac96ee5ac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837203 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#703489}
-
Sebastien Marchand authored
Bug: 980533 Change-Id: I6c351d4ca8ee49b369ac9e187994aa69d470424e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836451 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#703488}
-
Moe Ahmadi authored
Currently Omnibox would clear the temporary text if the first results is attempted to be selected using the arrow key. This prevents the first zero-prefix result from being selected as there is no default matches in that case. This CL fixes that by adding an extra condition to prevent selection when there's no editing. Bug: 996516 Change-Id: Idb3338fcc86233ce14f0de22dc4253691f5daf13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845913Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#703487}
-
Abigail Klein authored
controls on the page do. Bug: 842891 Change-Id: I1dbb8e2228fcc393bc70479d1467b343b46ec7ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838393Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#703486}
-
Allen Bauer authored
Bug: 1005568 Change-Id: Ia232b595a862525d89a6be135a839f3f30dffbad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841758 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Auto-Submit: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#703485}
-
Sylvain Defresne authored
base::Bind/base::Callback are deprecated in favor of either base::BindOnce/base::OnceCallback or base::BindRepeating/ base::RepeatingCallback (depending on whether the callback is invoked once or multiple time). Convert some uses of base::Bind/base::Callback (this is a multipart change) in components/prefs and services/prefs to the recommended methods/types. Bug: 1007719, 1007831 Change-Id: I7d18d35c3148ccacf4228cc5d44349b96cefb56e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844813 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#703484}
-
Henrique Ferreiro authored
Convert the implementation and all users of the snippets_internals::mojom::PageHandlerFactory, PageHandler and Page interfaces. Bug: 955171 Change-Id: Ifaefd53184ce0f547b5048df1ffe2e144cf5fa4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807223Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#703483}
-
Andrew Grieve authored
This is just a minor build rule simplification. Should not affect anything. Change-Id: If778e8c2ece6e223b492ed4f172ce138f3c4e357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845932 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#703482}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d16fbbb2686c..9ccec3700953 Created with: gclient setdep -r src-internal@9ccec3700953 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:140584925,chromium:None,chromium:None,chromium:1011526 Change-Id: I7f8ed074a01bb4872e37fca816ca300cea46d8ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845942Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703481}
-
Tarun Bansal authored
Enable fetching of hints from the URLs extracted from the search result page. The hints are fetched only on slow connections. Change-Id: I0c8d0324ff913297c9f2b2a5fdc300771c0c3798 Bug: 1004527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839240 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#703480}
-
Kevin Marshall authored
Configures the NetworkContext to permit CORS requests with headers "Purpose" or "X-Requested-With" headers. These headers are safe and used for resource preloading and CSRF blocking, respectively. Previously, the Chromium netstack would block resources from loading if either of these headers were set. Bug: 1011905 Change-Id: I994ad2adddca5d00226e603b37c87d57cca69e1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846013Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#703479}
-
Kristi Park authored
Remove line-height, which was causing the area outside the actual size of the menu option to be selectable. Before: https://drive.google.com/open?id=16vEe60P6VDgFI1SKzexUS3mrZroQll-I After: https://drive.google.com/open?id=1QE7I6ig2lnomxVNxDG3bS_KvabJSw6s1 Bug: 1011802 Change-Id: I1c762703bb6b59a099477d4706618bf307179d53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845697Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#703478}
-