- 19 Aug, 2019 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium 067cbde1. With Chromium commits locally applied on WPT: 25797c4b "Port some css-fonts-{3,4} interpolation tests to WPT" 067cbde1 "[webnfc] A follow-up for nfc-mock.js" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I3f13dcdc24081bbffca9043386a37b84a84de637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760417Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688272}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/4935770daa8e..9bf01811ac13 git log 4935770daa8e..9bf01811ac13 --date=short --no-merges --format='%ad %ae %s' 2019-08-19 tsepez@chromium.org Remove some more CPDFXFA_* type usage from fpdfsdk/cpdfsdk_* 2019-08-19 thestig@chromium.org Simplify CPDF_ToUnicodeMap::Lookup(). Created with: gclient setdep -r src/third_party/pdfium@9bf01811ac13 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: Ifc2ce8d6a5cd679fcf5a1e0ca286fc5da6d6f3e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761218Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688271}
-
Umesh Patil authored
Bug: b/139671272 Change-Id: I9044de4ba7d75788b10deb4c005a35c964f8f417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761236Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Umesh Patil <upatil@google.com> Cr-Commit-Position: refs/heads/master@{#688270}
-
Andrew Xu authored
Refactor the handling functions for gesture scrolling in ScrollableShelfView. This CL makes preparations for the incoming CL which handles the gesture fling event. Bug: 973481 Change-Id: Ia25daf84043e38c0c03f7dbf73b7beb204b5bcab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760545 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#688269}
-
Daksh Idnani authored
Update platform tags for gpu integration tests and webgl conformance integration tests to include tags for all GPUs. Bug: 985486, 984780, angleproject:3701 Change-Id: I17c3ad90e42e815b1aff26a1d202a0f63d6a2f81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761193Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#688268}
-
Yaron Friedman authored
While looking at some OWNERS files I'm in and trying to make sense of the clients, realized that these are unneeded Change-Id: Ifb8d3a4039c8d074aa03b0b34251dec0110ec376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761223Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#688267}
-
Dana Fried authored
Currently, it's possible for a tab hover card to be blank if it's displayed when a page is loading for the first time. This CL changes the behavior so that in that state, the title that is shown is "Loading..." (or localized equivalent) unless the page has crashed in which case a "Crashed." message appears. The URL that is displayed in this case is the visible URL, not the committed URL, so it's obvious to the user *which* page is loading. Bug: 981103 Change-Id: I082088ac42bf32c37a2dc3ed220c68ba5d5400da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760669 Commit-Queue: Dana Fried <dfried@chromium.org> Auto-Submit: Dana Fried <dfried@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#688266}
-
Peter Wen authored
Making ModuleInstallerImpl package-private ensures that callers use the ModuleInstaller interface instead of depending directly on the implementation. Also add stricter parameters and requirements for ModuleInstaller#initActivity to ensure that SplitCompat#install is called in the right order (Application first then Activities). Add /* package */ to classes only used within its package, remove some redundant public method modifiers in interfaces since all methods in interfaces are public by default. Bug: 981084 Change-Id: I4826b2d716fb04fea8b59ed2eff14eb72c843ec7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761048 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#688265}
-
John Budorick authored
This reverts commit 34844187. Reason for revert: bot is underprovisioned at current build rate. Original change's description: > Add directory-based CQ for the SKV bot > > The SkiaRenderer Vulkan Android bot was breaking frequently. We > want to add it to the CQ for likely-impactful directories. This > should help maintain the SKV bot. > > Bug: 979431 > Change-Id: Id332ab4de1b2deac7ad4c53ef8e92351d176b58a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753667 > Reviewed-by: Eric Karl <ericrk@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Chris Blume <cblume@chromium.org> > Cr-Commit-Position: refs/heads/master@{#687332} TBR=jonross@chromium.org,jbudorick@chromium.org,cblume@chromium.org,ericrk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 979431 Change-Id: I1c140d90fd4f4021ac914d12ea63d077d6ec3771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761309Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#688264}
-
Xiaocheng Hu authored
Bug: 825895 Change-Id: I98e3327a82352a90db9a74b1adc4b62ffd54c4ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758834Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#688263}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/73b9263523ee..df7093214c55 git log 73b9263523ee..df7093214c55 --date=short --no-merges --format='%ad %ae %s' 2019-08-19 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@df7093214c55 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: None Change-Id: Ifec5eeef7d880e2c1bdb23ed4b1921e784930426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761209Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/82c85d4f089f..d272ed1e68f8 git log 82c85d4f089f..d272ed1e68f8 --date=short --no-merges --format='%ad %ae %s' 2019-08-19 saklein@chromium.org Build API README: Better explained proto changes process. Created with: gclient setdep -r src/third_party/chromite@d272ed1e68f8 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: If78b82d39d975f039574ff90d3b7ce5b31f6cac8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761167Reviewed-by:
-
Frank Tang authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/9a5af81f5..2b2ee71 2b2ee71 Add android_small/icudatl_extra.dat. 4ae379e Allow 'icupkg' to build data package without dependency check. 4de2cfd Merge the uptream pull/682 to prepare for Android extra data package. Bug: chromium:969181 Change-Id: Ia4cca333a23cf1eda8c5ceb7da979a72ec7a1320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760863Reviewed-by:
Jungshik Shin <jshin@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#688260}
-
Robbie Gibson authored
Bug: 991539 Change-Id: Ibd47e2d2ef209fa86400136af8d135f82898c1c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760225 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#688259}
-
Jun Cai authored
This CL updates SMS readme file to include more related docs. Bug: 994327 Change-Id: Ie96496fb3f68f3e9a99c6346ac77d6b2ab1e0bb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759225Reviewed-by:
Ayu Ishii <ayui@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#688258}
-
Austin Eng authored
Bug: chromium:852089 Change-Id: Ic526b2ec5d2d58a11a5bdfb26b29fe16c8f1ceed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759684 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#688257}
-
Gabriel Charette authored
This is the iOS equivalent of https://chromium-review.googlesource.com/c/chromium/src/+/1747171 Required to facilitate the mass-rename of "thread_bundle" variables. R=rohitrao@chromium.org Bug: 992483 Change-Id: I244370aa92eb53933cfe4076209b84b58b658504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757366Reviewed-by:
-
Daniel Clark authored
Change ControlType of <article> from "Document" to "Group" per https://w3c.github.io/html-aam/#el-article Change LocalizedControlType of <figure> from "group" to "figure" per https://thepaciellogroup.github.io/AT-browser-tests/test-files/figure.html Bug: 994380 Change-Id: I36e59265650b1655b2811ccb3baac8b67e8552a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757145Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#688255}
-
Tanisha Mandre authored
Architecture: Superclass - scannerView Subclasses - qrScannerView Files just renamed and shifted to scanner directory: - camera_controller - qr_scanner_alerts - qr_transitioning_delegate - qr_scanner_presenting Bug: 990744 Change-Id: I3fddd13f05e1a2bdd5de239c32f86979399eb925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741974 Commit-Queue: Tanisha Mandre <tanishamandre@google.com> Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#688254}
-
Michael Thiessen authored
No functionality changes intended, this is just cleanup to make the current behavior clearer. We already only have a non-incognito tab model, so if something tried to use the incognito tab creator it would just create a non-incognito tab anyways (I think?), which seems bad. Change-Id: I3439b2e9d8352afb4ab09e50c67b30066aceef80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751925 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#688253}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8566dda51b42..eb3eb98eb6b8 git log 8566dda51b42..eb3eb98eb6b8 --date=short --no-merges --format='%ad %ae %s' 2019-08-19 robertphillips@google.com Add textureReleaseProc and releaseContext to SkImage factory functions 2019-08-19 fmalita@chromium.org [skottie] Shaper downscale-to-fit vertical alignment mode 2019-08-19 jlavrova@google.com Fixed temp dir for snapshots Created with: gclient setdep -r src/third_party/skia@eb3eb98eb6b8 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@google.com Bug: None Change-Id: Idd621d0202d18dd13c375325ca20ac5bf1e157be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761215Reviewed-by:
-
Sam Maier authored
We are rolling mainly to remove assertions, which was a bug in R8: https://issuetracker.google.com/issues/139307059 Bug: 992809 Change-Id: Id7879e3ae72be7428f5c64a80d88969e18fa27fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760462Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#688251}
-
Andrew Luo authored
Bug: 934168 Change-Id: I083a79024282c245eb53b26d0c7bbdc92be5a7be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759186Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#688250}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/27e17f7851e2..d5e9e0c38f85 git log 27e17f7851e2..d5e9e0c38f85 --date=short --no-merges --format='%ad %ae %s' 2019-08-19 misterg@google.com Merge pull request #2397 from kuzkry:custom-type-traits-is_reference 2019-08-19 misterg@google.com Merge pull request #2381 from Yannic:fix_bazel 2019-08-19 absl-team@google.com Googletest export 2019-08-19 absl-team@google.com Googletest export Created with: gclient setdep -r src/third_party/googletest/src@d5e9e0c38f85 The AutoRoll server is located here: https://autoroll.skia.org/r/googletest-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng;luci.chrome.try:win_chrome_official TBR=isamsonov@google.com,staphany@google.com Bug: None Change-Id: Ibe3c208d94d03005e9feace74608f5320cd49f03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760677Reviewed-by:
Staphany Park <staphany@google.com> Reviewed-by:
Staphany Park <staphany@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688249}
-
Xing Liu authored
This CL replaces std::deque with base::circular_deque. This can reduce the APK size by 160 bytes. Notice there are some side effects for base::circular_deque, like can't dereference iterator while modifying the containers. Also std::sort on base::circular_deque is taking +500 bytes increase in APK size, which makes this replacement less efficient. Bug: 972191 Change-Id: I25f4ae780b0f8be5a970ced561c461a68f1c93fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759228Reviewed-by:
Hesen Zhang <hesen@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#688248}
-
Peter Kasting authored
See comment 8 on the bug for the spec link. Bug: 883451 Change-Id: I218eb090519bb44d37afd75bf0fb7ad66c323949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756711 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#688247}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4dfd57b8be2c..7dcd6b790228 Created with: gclient setdep -r src-internal@7dcd6b790228 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: If17f84f12107386aa92b163f7acade35c7cf8ad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761210Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#688246}
-
Vasilii Sukhanov authored
Bug: 986298 Change-Id: If5c875f2b94bb41a8c81dc49603b801903a8e69d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760735 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#688245}
-
Rune Lillesveen authored
Type rule invalidation sets are not used on the global ruleset, only rulesets for specific stylesheets. Those RuleFeatureSets are disposed with the whole RuleSet and re-created every time which means this did not cause a bug. However, we should clear to be consistent and on the safe side. Change-Id: Icaade0122a34d3f0945f95093dcab6427e02509b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760733 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#688244}
-
Kyle Milka authored
Bug: 995079 Change-Id: I2366ab1cdc470dffc942fe91194a6ca947e69ea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761047 Commit-Queue: Kyle Milka <kmilka@chromium.org> Auto-Submit: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#688243}
-
Jimmy Gong authored
- It was redundant to disable a network protocol option when the dropdown was already disabled if there is no connectivity or is a USB printer. Bug: 947183 Test: End to End manual, browsertests Change-Id: Iff171ad14a2db8a2911357b3aa5225d6b5ded177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748004 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#688242}
-
Mason Freed authored
The spec [1] is clear that :enabled and :disabled should *not* match link elements. Prior to this CL, links would match :enabled in Chrome, but would never match :disabled. This is obviously contrary to the spec, and it also does not match other browsers' behavior: Firefox (68), Safari (12.1), Edge (18) and IE (11) all work according to the spec. Now, neither :enabled nor :disabled match links in Chrome. [1] https://html.spec.whatwg.org/multipage/semantics-other.html#selector-enabled Bug: 993387 Change-Id: I745a314fdac720243ebf37eed4fdcf57228cc3cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754509 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
-
Jazz Xu authored
Bug: 964380 Change-Id: Ifd8883adb8f93a27694046f8c13a5b89545097c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759229Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#688240}
-
Gyuyoung Kim authored
This CL applies the new Mojo types into WebShare classes. - ShareServicePtr is converted to mojo::Remote<>. - mojo::Binding is converted to mojo::Receiver<>. Bug: 955171 Change-Id: Ide5d49a710e57bfcb5d99e0b590381eaa6d8450a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757961 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
-
Kush Sinha authored
Please check the attached bug for context. Bug: 995248 Change-Id: I2e8e83fb4eb75417f106e1175e9238d645b69ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760217Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#688238}
-
David Benjamin authored
Specifying privacy_mode and load_flags separately risks the callers mixing the two up, which can corrupt the socket pool state. Indeed network_context_unittest.cc itself mixes them up. Along the way, fix the documentation which claims privacy_mode makes the connection untrackable, which is false. The only thing it does is pools it with different requests. This CL should be a no-op behavior-wise. Bug: 799935 Change-Id: Iaf770cd556d7dbfaa296abfac22c070ecc903c50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752628Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#688237}
-
Hesen Zhang authored
- Change a vector of icons to small_icon and large_icon explicitly. - Wrap Skbitmap to an Icon struct for future extension. Bug: 963290 Change-Id: I6bd9459dc05e169e281659b67747a55c464e45bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758708Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#688236}
-
Sergey Ulanov authored
Now all VMOs created by chromium code will have name set. This doesn't affect VMOs allocated using mmap(). Bug: 991805 Change-Id: I2a8e13bb58e1a3b9f27216c636584a92af8d2219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758842 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#688235}
-
Chris Harrelson authored
Bug: 977514 Change-Id: I3c141db1860169da3064a049796bbead93f4407b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760536Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#688234}
-
Peter Kasting authored
This also switches to using these tints to calculate the frame (and incognito toolbar button) colors, so the two cannot get out of sync in the future. Bug: 865130 Change-Id: I386be5409589b9a7b45abadef567b1e41f593c39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759292 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#688233}
-
