- 07 Jul, 2020 40 commits
-
-
Quang Minh Tuan Nguyen authored
Bug: 1007685 Change-Id: I740afce20423be40ed662db3189f6b937a0cb9dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283026 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#785911}
-
Oleh Lamzin authored
Add ConvertVector template since we will need to convert vectors of at least 9 different types. Bug: b:158658869 Change-Id: If53036358ddd334626451e0fc722cb044e78e161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273062 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Roland Bock <rbock@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Cr-Commit-Position: refs/heads/master@{#785910}
-
Jamie Walch authored
I've been trying to diagnose a failure to resize the Windows host desktop, and the lack of logging is making it hard to work out what the issue is. I think logging in this area would generally be useful, so this CL adds some; specifically: * The logic by which the DesktopResizerWin determines the mapping from resolution to DEVMODE now logs some key decision points. * The list of supported resolutions returned by the platform-specific DesktopResizer* class to the ResizingHostObserver is now logged. Change-Id: Ieaebe21f501b58dda43707890b1eb31f866e280a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282894Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#785909}
-
David Tseng authored
The |isAsync| identifier is overloaded at the moment: SomeTestClass.prototype.isAsync and Callbackhelper.prototype.wrap(opt_callback, opt_isAsync); The ofrmer is part of the test framework (testing.Test) and the latter isn't and is public only to accessibility js tests. It is actually possible to infer whether the callback in the second case is async (via Es6 async functions). Do so and remove the unneeded param. R=anastasi@google.com AX-Relnotes: n/a Change-Id: I4081a6a5db159af70967a1f53c907512c229b8b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285062 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#785908}
-
mhasank authored
From the feedback in http://go/chr/2268468 BUG=b:62613791 TEST=deploy to dut, disable playstore, re-enable playstore, successfully finish the authorization flow Change-Id: I973bee23e41be5ea3b56ba9773ec3190caacadf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283639Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Auto-Submit: Muhammad Hasan Khan <mhasank@chromium.org> Cr-Commit-Position: refs/heads/master@{#785907}
-
Sunny Sachanandani authored
DCLayerOverlayProcessor supports non-root with a disabled by default finch flag. This hasn't shipped in the last 3+ years and it's unlikely it would ever ship in the current form. Meanwhile, any refactoring of the overlay processor for implementing real performance optimizations like partial quad aggregation becomes a lot more complicated due to handling the corner case of non-root render passes. Also remove support for non axis-aligned transforms since those rely on non-root render pass support as well. Remove the misleading unit tests for non axis-aligned transforms since those only test video quads in root render pass which doesn't occur in practice since non axis-aligned video surfaces don't get merged to the root render pass. Bug: 1100690, 1077210 Change-Id: Idc012d29d9e4effd3b3e4194ad0cfcdf9083d71f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277321Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#785906}
-
Daniel Hosseinian authored
Bug: 226176 Change-Id: Ia36e7a0e0c3334c8b45dfe3b0036a84719dea12c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278223Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#785905}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 29 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2021-01-03. TBR=chromium-metrics-reviews@google.com Change-Id: Idf9e91051be8f801f5e5327ca897175a555ae882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285005Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#785904}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/dcd57068bed4..6fc53fdb8bb1 2020-07-07 etienneb@chromium.org Fix typos in comment If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1091259 Tbr: syoussefi@google.com Change-Id: I78363e3ba9fc03c3ea58e4f525a5e1ea6f5e55ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284952Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#785903}
-
Jerome Jiang authored
https://aomedia.googlesource.com/aom.git/+log/e1ebb418ebdc..0a7c8715d792 $ git log e1ebb418e..0a7c8715d --date=short --no-merges --format='%ad %ae %s' 2020-07-06 jianj Revert "Add NEON version of av1_get_nz_map_contexts function" 2020-07-06 yaowu Shorten test time of AVxFirstPassEncoderThreadTest 2020-07-06 yaowu Shorten test time for AVxEncoderThreadTestLarge 2020-06-12 bohanli Unify temporal filtering of ARF and KF. 2020-07-02 wtc Pass correct second argument to _mm256_avg_epu16() 2020-07-04 yaowu Shorten Decode Test Time 2020-07-03 deepa.kg Fix number of workers in tpl multi-threading 2020-07-03 sanampudi.venkatarao Modularize NONE and SPLIT partition search 2020-07-02 nithya.vs Fix luma skip rd computation in hbd encoding 2020-07-01 vishesh.garg Group tuning related config in AV1EncoderConfig (...) 2020-06-15 jingning Add 6-tap filter support to 2D interpolation AVX2 2020-06-15 jingning Redesign AVX2 2d interpolation filter 2020-06-14 jingning Support 6-tap AVX2 horizontal interpolation filter 2020-06-14 jingning Handle 6-tap interpolation filter 2020-06-15 chiyotsai Simplify code-flow in palette mode 2020-06-15 sarahparker Doxygen for process_compound_inter_mode 2020-06-15 sarahparker Doxygen for PruneInfoFromTpl 2020-06-16 jingning Clean up GF_GROUP data structure 2020-06-16 jingning Remove CHECK_PRECOMPUTED_REF_FRAME_MAP 2020-06-16 jingning Remove deprecated functions in gop_structure.c Created with: roll-dep src/third_party/libaom/source/libaom R=jzern@google.com Change-Id: Ia9f0e6262def027e592e9d5ab3c27de6d074ccef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284009Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#785902}
-
Dan Harrington authored
- provides prefetch suggestions to offline_pages - informs offline_pages when new suggestions are available Some potential follow-ups: - It might be beneficial to inject a delay before we inform offline pages about the new content, to reduce processing happening while loading the UI. - offline prefetch supports only one image url, but the new server protocol supports any number. Ideally we could fetch all images. Bug: 1044139 Change-Id: I2fc7f039c0dbc11ef54ae243ee5bf0b33f7d8674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270208 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#785901}
-
Juliet Levesque authored
Allows logging instances used for Nearby Share to show up on chrome://nearby-internals logging tab. Bug: 1093634 Change-Id: I67e4b128fcd2fed8564a7cec3ee2df22f0572833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265452Reviewed-by:
Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Juliet Levesque <julietlevesque@google.com> Cr-Commit-Position: refs/heads/master@{#785900}
-
Lorne Mitchell authored
The tests include; UninstallAppInstalledInPreviousSession AlwaysUpdate UpdateOnVersionChange UpdateOnLocaleChange InstallResultHistogram will come as part of another CL. Bug: 1082880,1088399 Change-Id: Id7a3dc51e2d22739955e225bc2616df4ea906ee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276217 Commit-Queue: Lorne Mitchell <lomitch@microsoft.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#785899}
-
Regan Hsu authored
Fixed: 1102357 Change-Id: I36f83e60d2061525f8bd4e16d3325ed5821eb8c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285066Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#785898}
-
Fyodor Gayokho authored
The only reason CustomThemeSupplier was inherited from RefCountedDeleteOnSequence is that BrowserThemePack should destructs on the blocking thread because it might has mmapped data which requires IO operations that would violate UI thread checks. In this change we call destruction of DataPack inside BrowserThemePack on the other thread and CustomThemeSupplier is not inherited from RefCountedDeleteOnSequence anymore. Bug: 1074297 Change-Id: I40f532b2c62453d1bb780f67eb2c888c0a448951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270459 Commit-Queue: Fyodor Gayokho <fgayokho@yandex-team.ru> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#785897}
-
Carlos Knippschild authored
This merge includes the following commits: commit 8fb7fd9a80f7512cb78178b83f017d82d04f9b14 Author: Feed Team <no-reply@google.com> AuthorDate: Tue Jun 30 11:24:37 2020 -0700 Commit: Copybara-Service <copybara-worker@google.com> CommitDate: Tue Jun 30 11:25:14 2020 -0700 Re-add action origin filed to feed_action. This field is meant to help analyze how many actions are coming from the client side action cache versus from the active session. This will also help debug how the clients are generating duplicate actions. PiperOrigin-RevId: 319061509 Change-Id: I31da37eed03b1e8b6036b12bb4000fa7e0768455 commit ea5ee1a066f16148bbbe2a687d8316d563b40a57 Author: Travis Feuling <feuling@google.com> AuthorDate: Tue Jun 30 09:55:58 2020 -0700 Commit: Copybara-Service <copybara-worker@google.com> CommitDate: Tue Jun 30 09:56:32 2020 -0700 Export script changes. PiperOrigin-RevId: 319041793 Change-Id: I46c2620b393633fee751691b6d49953c9c55c03c Change-Id: Id516f309a883219c2918ee2a3b8e01efb4fc5ee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278608 Auto-Submit: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#785896}
-
David Bokan authored
Bug has been fixed for a while. Bug: 845097 Change-Id: I1edd1265d7e6c332d9e6d91bc32520939555aa17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284079 Commit-Queue: James MacLean <wjmaclean@chromium.org> Auto-Submit: David Bokan <bokan@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#785895}
-
David Bertoni authored
This test passed 3000 iterations on the bots without timing out. Bug: 238667 Change-Id: I257dbabaa668f48549adf661030917e6e0cf97e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264866Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#785894}
-
David Maunder authored
The test is flaky Bug: 1101760 Change-Id: I183c61503bb63c4ec90dd86f089723e4e5c42dd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284967Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#785893}
-
Hesen Zhang authored
- In the header file, change TileServiceScheduler to a pure interface, and create TileServiceSchedulerImpl class to inherit from LogSource and TileServiceScheduler both. - Implemented LogSource in Scheduler - as TileServiceImpl will actually owns the Logger. - Create Delegate in scheduler and GetTileGroup through TileManager, in order to expose to LogSource. - Added two more scheduler event APIs OnFetchStarted and OnGroupDataSaved in order to update the internal status. - (TODO) convert TileGroup to base::Value with pretty format. - Follow up CL: https://chromium-review.googlesource.com/c/chromium/src/+/2264934 Bug: 1066556 Change-Id: Ifa8099499f17e0cddf745dffc7384b3e3595fa2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277073 Auto-Submit: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#785892}
-
Wenbin Zhang authored
This CL puts tester android-go-perf in lightweight mode with '--skip-perf'. In this case the tester will no longer upload the perf data. Bug: chromium:1045256 Change-Id: Ib5e09994a03d6e46e6e5439ed283e3a2275715bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271774Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#785891}
-
Tom Anderson authored
When reading unions, the raw bytes are memcpy()ed into the destination. This works for XCB where structures are usually laid out as they would appear on the wire. However, XProto makes some changes (padding bytes are hidden, length fields are hidden when possible, etc), so this approach will not work. This CL changes RandR NotifyEvent to use a switch instead of a union. Since we have the switch variable available, there's no reason not to. Furthermore, there are only 5 uses of union in all of xcbproto: the one removed here, one in xproto (which I've checked is safe), and 3 in Xkb. All of them have switch variables, so we can change all of them over and get rid of unions altogether, which I'll investigate in followups. This fixes a buffer overflow when resizing a VM while Chrome is running, but also exposes a second issue: we're calling XRRUpdateConfiguration() without having initialized Xlib's Xrandr, so the Xlib event is nullptr causing a crash. I'll investigate a fix for that in a followup. R=nickdiego Bug: 1102059 Change-Id: Ieac8807257eab6a90a9eab26b192f7444ddfa0c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283940 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#785890}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 138 histograms that show frequent access in the past 90 days. These are the 90% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2021-01-03. TBR=chromium-metrics-reviews@google.com Change-Id: I59f8a8a48fbfe88c340443590f0cb5a317352c0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285006Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#785889}
-
Rakib M. Hasan authored
Update test expectations for Android. Bug: None Change-Id: I4617c9b4f1a2691f5c3d8bcb519d8698d4079b6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277879 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#785888}
-
Antonio Gomes authored
... instead of WebMediaStreamSource. BUG=704136 R=guidou@chromium.org Change-Id: I19a2e7ad7109db1404f9f563e8b01548432388da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283572 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#785887}
-
Dirk Pranke authored
This reverts commit 74002934 and re-lands bb015801 (#785246) with a fix to prevent the breakage I missed last time that affected the ANGLE CQ. Original CL's description: > Remove //chrome/test wrapper targets for angle. > > //chrome/test defined two targets (angle_perftests and > standalone_angle_unittests) that were simply wrappers around the > corresponding targets in ANGLE that added some data dependencies. > > By moving those data dependencies into ANGLE, we no longer need > the Chrome-side targets, and removing them unblocks the > wrapper script work I'm doing in bug 816629. TBR=jmadill@chromium.org Bug: 816629, angleproject:3162 Change-Id: I2a56802a4301892f4b4a9f84ba0882a64e23e0cd Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86;luci.chromium.try:linux-angle-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283378Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#785886}
-
Mason Freed authored
Prior to this change, font-size:0 was ignored for <select> options and option groups. Fixed: 1102414 Change-Id: I93389cbe5258095896f6846077c9df2c18410947 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283051 Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Yu Han <yuzhehan@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#785885}
-
John Abd-El-Malek authored
Bug: 1088488 Change-Id: I3ed287c91bf94384844008dfae943f8e902d80b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283931Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#785884}
-
Thomas Lukaszewicz authored
Bug: None Change-Id: I4b9c55779915bf5e4101d5c9e67011824ae3b310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252846 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#785883}
-
Noah Rose Ledesma authored
UI is enabled with #global-media-controls-seamless-transfer flag Bug: 1096242 Change-Id: I8134a437dbda07d32291ae91fb9707fe0df39418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270880Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Cr-Commit-Position: refs/heads/master@{#785882}
-
Chris Davis authored
This change is to verify that there is no difference in reported metrics for checking if the app is pinned to the taskbar with or without the additional check that the shortcut exposes the unpin from taskbar shell verb. Once this is verified a subsequent change will go in to remove the shell verb check. Bug: 1094395 Change-Id: Ibe70e7b2b54ae5bd9f4cdcccb20af7cb93e9f2da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277105 Commit-Queue: Chris Davis <chrdavis@microsoft.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#785881}
-
Monica Basta authored
This CL ensures the profile picker main view is updated if any of the profiles's state changes. Bug: 1063856 Change-Id: Ic93292b9f094b7202ceb1a25831310b25c77c997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279894 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#785880}
-
Justin DeWitt authored
Bug: 1099903 Change-Id: I8e6261064f4dc2bafd7484480d5b324b22edda49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271058Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#785879}
-
Tibor Goldschwendt authored
Change-Id: I7e4a3d562a3cbda06950c455554a1da33b6f7e66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284092 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#785878}
-
Dana Fried authored
UAF could occur in the following situation: - Layout manager is set on View. - View has child views added. - View is destructed. - After at least one of the child views is deleted, during a callback, a layout-related method such as CalculatePreferredSize() is called. - Layout manager queries host view's children's properties. - Child view is already destroyed, so pointer is invalid (but not null) resulting in UAF. I have seen a crash randomly in debug mode which seems like it is probably tied to this potential UAF at least once, which is why I'm submitting this change. Bug: 1102731 Change-Id: I7436ea9da0d1106178e9d43ed08e6e82f41a283e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284448Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#785877}
-
Adam Ettenberger authored
In the following CL ax::mojom::IntAttribute::kTextAlign was added and exposed for IA2 text-align : https://chromium-review.googlesource.com/c/chromium/src/+/2264456 This CL exposes the new attribute for UIA via ITextRangeProvider:: GetAttributeValue, UIA_HorizontalTextAlignmentAttributeId. Bug: 1090995 Change-Id: I7a1d0f86e20c49cad7d8ef867d7f01905ac08803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283770Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com> Cr-Commit-Position: refs/heads/master@{#785876}
-
Xiaohan Wang authored
MediaFoundationCdmFactory is a media::CdmFactory implementation that can create MediaFoundationCdm to be used on Windows platform. NOPRESUBMIT=true Bug: 999747 Change-Id: I197bc876bab5006d915d8bc0c0ae43641200746d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278589 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#785875}
-
Esmael El-Moslimany authored
Bug: 1100301 Change-Id: I6e21dee0a10b359f5b8d3571146f36b62892887f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284163 Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#785874}
-
Lucas Gadani authored
This CL fixes a crash when a RenderWidgetHostView is already destroyed by the time the query IPC is processed. Bug: 1101001 Change-Id: I046abacf6334fcfd56e3ea2bca07fdb24b5fff4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283824 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#785873}
-
Alexander Dunaev authored
The drag and drop client is supposed to set event flags according to the current state of modifier keys (i.e., Ctrl, Shift, and Alt). It was not implemented in Ozone, but migration of Linux/X11 to Ozone requires that. This CL adds the methods that allow the DDDClientOzone to get these flags from the platform. The issue has been found by a test that broke at the attempt to use DesktopDragDropClientOzone in place of DesktopDragDropClientAuraX11. Bug: 990756 Change-Id: I2657383011a1bf9d716bb5bfa90dbcf010bba48f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279975 Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Auto-Submit: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#785872}
-