- 18 Feb, 2016 40 commits
-
-
chromeos-commit-bot authored
Cr-Commit-Position: refs/heads/master@{#376118}
-
ben authored
TBR=sky@chromium.org BUG= Review URL: https://codereview.chromium.org/1705323003 Cr-Commit-Position: refs/heads/master@{#376117}
-
rune authored
:host and :host-context must always be in the rightmost compound with no other simple selectors except a succeding pseudo element in order to match as the host element is feature-less in that context. It's however not an invalid selector according to the CSS Scoping spec, so we shouldn't drop it at parse time. We could potentially skip adding other selectors to rulesets as well including selectors like: :hover:not(:hover), div:not(div), ::content and ::slotted not in shadow trees, etc. R=kochi@chromium.org,ericwilligers@chromium.org BUG=489481 Review URL: https://codereview.chromium.org/1703893002 Cr-Commit-Position: refs/heads/master@{#376116}
-
alancutter authored
This patch adds support for composite modes on clip CSS animations via element.animate(). This also changes clip to be more strict about when it permits smooth interpolation between values. Previously "rect(100px, auto, auto, auto)" would smoothly interpolate with "rect(200px, 100px, auto, auto)". Now these values will 50% flip as their distribution of auto keywords do not line up. This behaviour matches Firefox. BUG=437696 Review URL: https://codereview.chromium.org/1640643002 Cr-Commit-Position: refs/heads/master@{#376115}
-
leviw authored
The PluginView method layoutIfNeeded causes WebView plugins to update their entire lifecycle, but we only call that if their layout is dirtied. In the presence of some style changes, they can need invalidation or compositing updates without layout, and our recursive lifecycle update missed WebView plugins as it only recurses through the Frame tree. This change always updates child plugins when FrameView::updateStyleAndLayoutIfNeededRecursive is called. BUG=545039 Review URL: https://codereview.chromium.org/1708923002 Cr-Commit-Position: refs/heads/master@{#376114}
-
nhiroki authored
Before this CL, ServiceWorkerResponseReader and ServiceWorkerResponseWriter were asynchronously created in ServiceWorkerCacheWriter. Unfortunately, the cache writer did not check the validity of ServiceWorkerContextCore before attempting to create the accessors, so it caused crashes when the context was already gone due to storage failure etc. This CL stops asynchronously creating those response accessors, and creates them when ServiceWorkerCacheWriter is constructed so that the cache writer no longer has to concern about the validity of the context. If the context is gone after the accessors are created, diskcache acceess simply fails[1]. [1] https://codereview.chromium.org/1693303002/ BUG=584606 Review URL: https://codereview.chromium.org/1704293002 Cr-Commit-Position: refs/heads/master@{#376113}
-
abhishekbh authored
This change makes the host start scanning for WiFi APs when a startScan request is sent from the instance. BUG=584886 BUG=b/26495967 Review URL: https://codereview.chromium.org/1680483002 Cr-Commit-Position: refs/heads/master@{#376112}
-
dbeam authored
R=michaelpg@chromium.org BUG=none TEST=more email Review URL: https://codereview.chromium.org/1707013003 Cr-Commit-Position: refs/heads/master@{#376111}
-
scottmg authored
R=sky@chromium.org BUG=558054 Review URL: https://codereview.chromium.org/1697243002 Cr-Commit-Position: refs/heads/master@{#376110}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ee6c0303c252..842a4f2e34ee $ git log ee6c0303c..842a4f2e3 --date=short --no-merges --format='%ad %ae %s' CQ_INCLUDE_TRYBOTS= TBR=catapult-sheriff@chromium.org Review URL: https://codereview.chromium.org/1706963004 Cr-Commit-Position: refs/heads/master@{#376109}
-
yawano authored
BUG=585066 TEST=manually tested as described in the issue. Review URL: https://codereview.chromium.org/1706813004 Cr-Commit-Position: refs/heads/master@{#376108}
-
reveman authored
BUG= TBR=piman@chromium.org Review URL: https://codereview.chromium.org/1705423002 Cr-Commit-Position: refs/heads/master@{#376107}
-
rune authored
Like for siblingRules in [1], we don't need to add rules to uncommonAttributeRules if the attribute selectors are left of ::content, ::slotted, :host, or :host-context as two elements only may share style if they match the same elements left of the two former, and anything left of the two latter may never match. [1] https://codereview.chromium.org/1695393002/ R=kochi@chromium.org Review URL: https://codereview.chromium.org/1706793002 Cr-Commit-Position: refs/heads/master@{#376106}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/e2412d5738e4..c5eddd7d8d67 $ git log e2412d573..c5eddd7d8 --date=short --no-merges --format='%ad %ae %s' 2016-02-17 herb Add bilerp filtering. 2016-02-17 reed some modes need clamping due to numerical imprecision CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=tomhudson@google.com Review URL: https://codereview.chromium.org/1712443002 Cr-Commit-Position: refs/heads/master@{#376105}
-
scottmg authored
R=sky@chromium.org BUG=558054 Review URL: https://codereview.chromium.org/1700873002 Cr-Commit-Position: refs/heads/master@{#376104}
-
yuzus authored
In order to make clear that computation is performed, Event.deepPath has been changed to a method Event.deepPath(), that returns sequence<EventTarget>. See the discussion here: https://github.com/w3c/webcomponents/issues/361 Described in the spec here : http://w3c.github.io/webcomponents/spec/shadow/#widl-Event-deepPath-sequence-EventTarget See the spec change here: https://github.com/w3c/webcomponents/commit/ed93413f9a37a6bfbd774cb2e09e14a76c87d56c BUG=531990 Committed: https://crrev.com/b9279be7d61887c171d5c1cefa114292c84b9957 Cr-Commit-Position: refs/heads/master@{#372596} Review URL: https://codereview.chromium.org/1637813002 Cr-Commit-Position: refs/heads/master@{#376103}
-
samli authored
Keyframe rules injected via CSSOM have no associated source range. BUG=586085 Review URL: https://codereview.chromium.org/1697973002 Cr-Commit-Position: refs/heads/master@{#376102}
-
patricialor authored
MacViews: Fix views_unittests MenuButtonTest.{ActivateDropDownOnMouseClick,DraggableMenuButtonActivatesOnRelease} Tests added in r301015, regressed in r363547. They fail on Mac because a non-simulated cursor position is detected during button creation, where button states are initialized, thus not detecting a hover state. the ui::test::EventGenerator is used to simulate cursor position, but isn't created until after the button widget, which means an unexpected cursor position is detected between the time of widget creation and EventGenerator creation. Additionally, using the set_current_location() method does not trigger mouse events, which means the button's hover state is never detected. Fix is to create the EventGenerator object before button creation so that when mouse events are triggered the hit tests will detect mouse hover states. BUG=579380 Review URL: https://codereview.chromium.org/1670473002 Cr-Commit-Position: refs/heads/master@{#376101}
-
dtseng authored
- kbexplorer script now is blacklisted for classic - we now can actually handle the ctrl key in js (stop speech). Do that. Nicely, this let's us get the ctrl key and speak it in the kbexplorer (it probably just stopped speech in the past, so spoke nothing) - keys now just go through the background page - all keys speak TEST=ChromeVox+o, k. Press some f-keys (back, forward, etc) are read. Press modifiers ctrl, alt, search, shift; verify they are read (queued). Press letters, numbers, shifted keys. BUG=none Review URL: https://codereview.chromium.org/1702913002 Cr-Commit-Position: refs/heads/master@{#376100}
-
halliwell authored
This reverts https://codereview.chromium.org/1477483003/ which was intended to fix a problem where media playback in browser tests triggers metrics events that DCHECK on invalid session ID. Previous attempt set a dummy session ID, but this could mask bugs if we ever failed to set session ID correctly. Instead, explicitly only set the dummy ID for running browser tests. BUG= Review URL: https://codereview.chromium.org/1510973007 Cr-Commit-Position: refs/heads/master@{#376099}
-
scottmg authored
This won't affect Stable based on https://code.google.com/p/chromium/codesearch#chromium/src/chrome/app/chrome_crash_reporter_client.cc&l=182 . R=mark@chromium.org,siggi@chromium.org BUG=587139, 586622 Review URL: https://codereview.chromium.org/1707203002 Cr-Commit-Position: refs/heads/master@{#376098}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/134ad3e5b097..e2412d5738e4 $ git log 134ad3e5b..e2412d573 --date=short --no-merges --format='%ad %ae %s' 2016-02-17 cblume Adding direct access to SkMipMap levels. 2016-02-17 mtklein try plain-old code for sk_memset16/32 now that NEON is compile-time 2016-02-17 msarett Speculative fix for Google3 iOS build 2016-02-17 msarett Return the proper error code in SkBmpRLECodec 2016-02-17 jvanverth Add GrGpu support for Vulkan command buffer flush GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1705133002 2016-02-17 robertphillips Mark existing image filter entry points that will be going away with Deprecated GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1709753002 2016-02-17 mtklein Don't you just feel bad every time you type 'delete'? 2016-02-17 brianosman Further reduction of GPU workload in shapes benchmarks. Hopefully this squelches the random crashes on Mali 400. 2016-02-17 bungeman Move SkTArray to include/private. 2016-02-17 msarett Delete KTX tests to fix Android build 2016-02-17 halcanary bin/sync-and-gyp: better error checking 2016-02-17 iroth Enable GL interfaces for iOS build 2016-02-17 caryclark add last move to serialized path CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=tomhudson@google.com Review URL: https://codereview.chromium.org/1708063002 Cr-Commit-Position: refs/heads/master@{#376097}
-
shans authored
to the property name. Prior to this patch, multiple calls to inline style setProperty with the same custom property name cause multiple entries to be created in the StylePropertySet. This causes inline style getPropertyValue calls to return the wrong value. Review URL: https://codereview.chromium.org/1697233003 Cr-Commit-Position: refs/heads/master@{#376096}
-
azurewei authored
Implement chrome.input.ime.setComposition and chrome.input.ime.commitText APIs on Linux and Windows platform. This cl makes ui::InputMethodBase inherits from ui::IMEInputContextHandlerInterface, thus we can implement functions CommitText() and UpdateCompositionText() once for Linux and Windows. Make InputImeKeyEventHandledFunction::Run() calls the new added InputMethodBase::KeyEventHandler() in to set |handling_key_event_|, which indicates whether the IME extension is handling key event. And when |handling_key_event_| == true, we should not setComposition and commitText until it's done to run the callback. Add helper function UpdateCommitText() and CommitTextToInputContext() in InputMethodEngineBase, which will be override in chromeos::InputMehtodEngine and input_method::InputMethodEngine to implement the API on different platforms. BUG=517773 TEST=None Review URL: https://codereview.chromium.org/1657593007 Cr-Commit-Position: refs/heads/master@{#376095}
-
michaelpg authored
BUG=388460 Review URL: https://codereview.chromium.org/1710673002 Cr-Commit-Position: refs/heads/master@{#376094}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/24a43392..7cf41d49 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1708733003 Cr-Commit-Position: refs/heads/master@{#376093}
-
dpranke authored
This will hopefully prevent some wasted time until the underlying problem is fixed. R=kbr@chromium.org, skobes@chromium.org BUG=539509 Review URL: https://codereview.chromium.org/1708973002 Cr-Commit-Position: refs/heads/master@{#376092}
-
scottmg authored
badfacccee01 win: Add support for capturing unloaded modules R=mark@chromium.org BUG=587141, crashpad:89 Review URL: https://codereview.chromium.org/1704203004 Cr-Commit-Position: refs/heads/master@{#376091}
-
hayato authored
This is a proof of concept to support *slotchange* events at the end of a microtask. The spec discussion is here: https://github.com/w3c/webcomponents/issues/288 Because slot elements are guarded by ShadowDOMV1 flag, this new events will be seen only when the flag is enabled. BUG=531990 Review URL: https://codereview.chromium.org/1695163003 Cr-Commit-Position: refs/heads/master@{#376090}
-
amistry authored
If the wait set is being woken on one thread and have an awakable added on another (i.e. during MojoWait on the wait set), it is possible for the awakable to be added after checking the signals state, but before adding to the awakables list. In this case, the added awakable won't get woken up. The fix is to ensure that checking the signals state and adding to the awakables list is an atomic operation. Review URL: https://codereview.chromium.org/1708953002 Cr-Commit-Position: refs/heads/master@{#376089}
-
kcarattini authored
BUG=543161,561867 Review URL: https://codereview.chromium.org/1700943003 Cr-Commit-Position: refs/heads/master@{#376088}
-
chrome-tpm authored
Cr-Commit-Position: refs/heads/master@{#376087}
-
estade authored
BUG=none Review URL: https://codereview.chromium.org/1711493004 Cr-Commit-Position: refs/heads/master@{#376086}
-
loyso authored
BUG=577016 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1698213002 Cr-Commit-Position: refs/heads/master@{#376085}
-
kozyatinskiy authored
Method document::updateLayoutTree creates ScriptForbiddenScope. An HTML plugin can be reattached while updating layout tree. Pepper plugin can be destroyed while reattaching and executes some scripts. This execution produces crash on ScriptForbidden assert. BUG=550427 R=pfeldman@chromium.org,dcheng@chromium.org,dgozman@chromium.org Review URL: https://codereview.chromium.org/1693003002 Cr-Commit-Position: refs/heads/master@{#376084}
-
suzyh authored
The KeyframeEffectOptions interface definition used DOMStrings instead of enums for the "fill" and "direction" members, which differs from the spec: http://w3c.github.io/web-animations/#the-animationeffecttimingproperties-dictionary This patch converts them to the specified enums. BUG= Review URL: https://codereview.chromium.org/1711543002 Cr-Commit-Position: refs/heads/master@{#376083}
-
nolan.robin.cao authored
Add a layout test case for Cache.matchAll() without parameters. BUG=578708 Review URL: https://codereview.chromium.org/1706863002 Cr-Commit-Position: refs/heads/master@{#376082}
-
wuchengli authored
Now that all platforms support V4L2_EVENT_SRC_CH_RESOLUTION, we can always check V4L2_EVENT_SRC_CH_RESOLUTION bit on resolution change. BUG=chrome-os-partner:44431 TEST=Play resolution change video on nyan-big. Review URL: https://codereview.chromium.org/1696303003 Cr-Commit-Position: refs/heads/master@{#376081}
-
sbc authored
Reland of [NaCl SDK] Add initial support for building the SDK with gn (patchset #1 id:1 of https://codereview.chromium.org/1693213002/ ) Reason for revert: clang/win compile failures was fixed: https://codereview.chromium.org/1706613002 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_clang_x64_dbg Original issue's description: > Revert of [NaCl SDK] Add initial support for building the SDK with gn (patchset #6 id:100001 of https://codereview.chromium.org/1693053002/ ) > > Reason for revert: > Doesn't build with clang/win and looks nontrivial to fix: > > https://build.chromium.org/p/chromium.fyi/builders/CrWinClang64%28dbg%29/builds/3655/steps/compile/logs/stdio > > FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes /FC @obj/native_client/src/trusted/validator/driver/ncval_new/ncval.obj.rsp /c ../../native_client/src/trusted/validator/driver/ncval.cc /Foobj/native_client/src/trusted/validator/driver/ncval_new/ncval.obj /Fdobj/native_client/src/trusted/validator/driver/ncval_new_cc.pdb > ../../native_client/src/trusted/validator/driver/ncval.cc(359,36) : error: ISO C++11 does not allow conversion from string literal to 'char *' [-Werror,-Wwritable-strings] > while ((opt = getopt(argc, argv, "vd")) != -1) { > ^ > > (and i'm guessing several more) > > Original issue's description: > > [NaCl SDK] Add initial support for building the SDK with gn > > > > build_sdk.py still uses gyp. I have a followup CL to > > convert that to gn. > > > > BUG=585999 > > TBR=binji@chromium.org,dpranke@chromium.org,bradnelson@chromium.org,sbc@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=585999 > > Committed: https://crrev.com/b78379a22336ce66dac20778db7964e40faa9180 > Cr-Commit-Position: refs/heads/master@{#375349} TBR=binji@chromium.org,dpranke@chromium.org,bradnelson@chromium.org,thakis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=585999 Review URL: https://codereview.chromium.org/1705923002 Cr-Commit-Position: refs/heads/master@{#376080}
-
joedow authored
This change fixes a DCHECK on linux when the host is run without specifying a socket name. Typically the host has a name passed in as an argument however it is not required and may be skipped for a number of reasons. The fix here is to skip the creation of the GnubbyExtension if a socket name is not passed in. The net effect of this is that if a CRD client passes a gnubby-auth extension message, the ClientSession will look for a registered extension to handle the message (which won't exist) and the message will be ignored. BUG=587622 Review URL: https://codereview.chromium.org/1710653002 Cr-Commit-Position: refs/heads/master@{#376079}
-