GitLab

CertVerifier today guarantees that if the associated
CertVerifier::Request is deleted, the caller-supplied
callback will not be invoked. However, it does not provide
any guarantees as to when the callback itself will be
freed.

This strengthens the guarantee, such that when a ::Request
is deleted, it will also Reset() the callback. Similarly,
it provides a strong guarantee that if the CertVerifier is
deleted, the associated Callbacks will be Reset. Put
differently, if either (CertVerifier is deleted ||
Request is deleted), then the Callback will be Reset. This
makes it easier for callers to be confident of an
"eventually consistent" approach.

Prior to this change, when the Callback was destroyed was
a bit indeterminate. In some cases, when the underlying
CertVerifier went away, the Callback would be destroyed. In
other cases, it was not until the ::Request was deleted by
the caller. And in one, it was not until both the ::Request
was deleted and the underlying CertVerifier had been
deleted/the asynchronous job completed before the callback
would be destroyed.

Bug: none
Change-Id: I527fa9f3700016269d4236bae03c13510ab69b7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862116Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Matt Mueller <mattm@chromium.org>
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707472}

Jelly Bean support has been deprecated. Removing conditions that are no
longer necessary to check.

Bug: 923477
Change-Id: Ic8fca66acd3199f990e89fb0375d5ce823348e42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865687Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707471}

LoginScreenAccessibilityPolicyBrowsertest.DeviceLoginScreenFullScreenMagnifier
is flaky from 10/18 on ChromeOS.
https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVycAsSBUZsYWtlImVjaHJvbWl1bUBicm93c2VyX3Rlc3RzQExvZ2luU2NyZWVuQWNjZXNzaWJpbGl0eVBvbGljeUJyb3dzZXJ0ZXN0LkRldmljZUxvZ2luU2NyZWVuRnVsbFNjcmVlbk1hZ25pZmllcgw

TBR=amraboelkher@google.com

Bug: 1015763
Change-Id: I73451c082190a275a75e78ca5d6134a0c369d530
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869669Reviewed-by: Lan Wei <lanwei@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707470}

- Avoid looking up GCInfo and one word in memory when pushing an object
  that was discovered through the write barrier.
- Use already existing branch for regular and large objects to compute
  size, assuming that the object will be marked.

Output on Z840 (down from ~17x):
[ RUN      ] WriteBarrierPerfTest.MemberWritePerformance
*RESULT WriteBarrierPerfTest writes during GC: = 36403.349108117945 writes/ms
*RESULT WriteBarrierPerfTest writes outside GC: = 476190.4761904762 writes/ms
*RESULT WriteBarrierPerfTest relative speed difference: = 13.08095238095238 times
[       OK ] WriteBarrierPerfTest.MemberWritePerformance (29 ms)

Bug: 1014414
Change-Id: I2c915edd1607bc839ea0478891971d23496b2678
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865344Reviewed-by: Omer Katz <omerkatz@chromium.org>
Reviewed-by: Anton Bikineev <bikineev@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707469}

In order to ensure homogeneous fleets, we need to have more specific
dimension values when looking for bots. This set of CLs updated some
existing dimensions, and added the synthetic_product_name values for
dimensions if appropriate.

This CL updated the dimensions for Win 7 Nvidia GPU Perf:
 - Added synthetic product name 'PowerEdge R220 [01] (Dell Inc.)';
 - Updated GPU from '10de:1cb3' to '10de:1cb3-23.21.13.8792'

Please check the link below for the available bots based on the
old/new dimensions:
https://chrome-swarming.appspot.com/botlist?c=id&c=task&c=gpu&c=os&c=pool&c=status&c=synthetic_product_name&d=desc&f=gpu%3A10de%3A1cb3&f=os%3AWindows-2008ServerR2-SP1&f=cpu%3Ax86-64&f=pool%3Achrome.tests.perf&s=synthetic_product_name

Bug: chromium:996830
Change-Id: Ida39ce6e53509fc18540ef9eefd77ce15e7e0210
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866560Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Wenbin Zhang <wenbinzhang@google.com>
Cr-Commit-Position: refs/heads/master@{#707468}

Bug: 82078
Change-Id: Ic24ef9bcc5545ae06468a3c5a5912292ccb10988
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867814
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707467}

There are multiple places where change tracking is cleared:
1. Main thread tree change tracking is cleared in LayerTreeHost::FinishCommitOnImplThread.
2. Pending tree change tracking is cleared in LayerTreeHostImpl::ActivateSyncTree.
3. Active tree change tracking is cleared after drawing in LayerTreeHostImpl::DrawLayers.

If drawing was skipped in #3, we would not clear change tracking, but it
is possible to have changes that do not cause visible damage. This patch
ensures we always clear change tracking after drawing. This is slightly
over-invalidating because the typical flow (pending->active) will
overwrite the active tree change tracking.

This change fixes LayerTreeHostTestSurfaceDamage which had a bug where
the 4th step of the testcase would only run flakily due to an EndTest in
the 3rd step. Fixing the test bug exposed the real bug of change
tracking not being reset.

Bug: 1014263
Change-Id: Ib9ec4dbc78e4806ccf1bd0f1d237d33831f29acf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868836Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707466}

LowerJavaScriptPriorityWhenForceDeferred feature is currently enabled
by default. This CL changes it to disabled by default.
This change enables us to experiment with this feature
(whether it actually helps in the performance or not).

Change-Id: I39ec2b4f55550eee870be4d4d26283b92c960952
Bug: 978490
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824419Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Auto-Submit: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707465}

Bug: 987646
Change-Id: I480e772f03e2cefe7e66a931bfabc96305cb50e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866924
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707464}

* If gRPC initialize failed we don't have a connection to begin with so
can't call Read().
* Shutdown the CompletionQueue otherwise the thread won't exit.

Bug: b/142400443
Test: internal unittests
Change-Id: Ifc2a13e36bbdc640908ca1069afed855fc8cd790
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867313
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Auto-Submit: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707463}

Update the annotation tags of traffic that's throttled
when user has an active WebRTC call.

The new tags are the ones for which we have the right approvals.

Bug: 1005841
Change-Id: Ic370992a529158863990cae20a29cf0101026bef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868009Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Auto-Submit: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707462}

I accidentally missed a case (or merge conflicted or something) in which
we should be ignoring focusout when the user deletes the focused item.

This specific case reproduces with these steps:
0) Search for "what are carbs" (and execute search)
1) Type "what" into realbox on NTP afterward
2) Move focus to "what are carbs" result
3) Press Shift+Delete

I've added an assert() to ensure this doesn't happen again, and added a
test. I've also updated a test that was triggering the assert() because
it was differing from what the prod code actually does (there was a
comment admitting that).

Bug: 1002689
Change-Id: Ic534ba725931291c3c327a43ea52d65d27ae51a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868092
Auto-Submit: Dan Beam <dbeam@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707461}

Extracts parts of the regular grid layout function into a helper, which
is then used by the new grid layout function.

Test: manual
Bug: 1011973
Change-Id: I7bdf40227bbd1df467ea9d56bc84e58b01c12f33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867271
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707460}

Now that
https://chromium.googlesource.com/catapult/+/8df31ad1d9b887ec31d2ecca1305483501693b79
has landed, we can remove this code to augment expectations, since
now that is passed through from the project config.

Bug: 985103
Change-Id: Ib8e707bd70fb6cd5744527e20251b9d314010434
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867356Reviewed-by: Rakib Hasan <rmhasan@google.com>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707459}

The regression was caused by finished events being queued at the wrong
time in the document lifecycle. With this fix, the finished event is
deferred until the microtask is run rather than synchronously inside
the ApplyUpdates method.

Bug: 1015047
Change-Id: If2917b8aab27c5c98e58d78f4a43b4288b439e8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869389Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707458}

This reverts commit 3a9215b3.

Reason for revert:
virtual/split-http-cache-not-site-per-process/http/tests/devtools/isolated-code-cache/same-origin-test.js
virtual/split-http-cache-not-site-per-process/http/tests/devtools/isolated-code-cache/same-origin-module-test.js are flaky on WebKit Linux MSAN.
https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN

Original change's description:
> Adapt isolated-code-cache web tests to partitioned HTTP Cache
> 
> The not-site-per-process isolated-code-cache web tests currently assume
> that cross-origin resources are cached when code cache site isolation is
> not active. This causes them to fail when the HTTP Cache is partitioned
> by Network Isolation Key. We thus disable the partitioned HTTP Cache for
> those tests and add a new test for when site isolation is not active,
> but the HTTP Cache is still partitioned.
> 
> Bug: 1009628
> Change-Id: I0d5d438d9564d3f659b93484a5bcc8aa56d2cd26
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865421
> Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Alex Turner <alexmt@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#707360}

TBR=thakis@chromium.org,shivanisha@chromium.org,alexmt@chromium.org

Change-Id: I8ebebb654e02d4d3c5d0c7e946ea70710b0b5df7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1009628
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869477Reviewed-by: Lan Wei <lanwei@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707457}

Before this change, tooltips from a window might appear as you move your
mouse around a different window which covers it, but only after tooltips
in the back window have changed at least once. This is because, when
tooltips change, the method below sends a fake NSMouseEntered event that
allows tooltips to display no matter which window is on top. The
method's goal is to clear and re-show tooltips immediately when they
update, and with this change that only happens if the mouse is not over
a different window.

Bug: 883269
Change-Id: I37aace8cf86d5ac5a667d22f68be4da310e92fb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869291Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707456}

This adds a way to execute javascript in WebLayer. The script will be
executed in a weblayer isolate that will not be able to access any
scripts from the page.

Change-Id: Ia17bd8476b5d9247d5761f0af24cd4d61edaccb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867300
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707455}

Add UMA metrics related to positive match secret changes, to monitor
how fingerprint authentication works under the positive match secret
scheme, and whether migration to this scheme is successful.

The associated Chrome OS CLs are CL:1829293, CL:1737809, CL:1737816

BUG=chromium:927095
Signed-off-by: Yicheng Li <yichengli@chromium.org>
Change-Id: I006d2cebaaf054d6ae4bfe53fe62318eda5f4698
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864819Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707454}

https://webrtc.googlesource.com/src.git/+log/3f7e0ede1e71..1d6005296701

git log 3f7e0ede1e71..1d6005296701 --date=short --no-merges --format='%ad %ae %s'
2019-10-18 saza@webrtc.org Delete ApmPublicSubmodules, fix ApmPrivateSubmodules, ApmSubmoduleStates

Created with:
  gclient setdep -r src/third_party/webrtc@1d6005296701

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: None
Change-Id: I6fbc31e8bd6393db0211da84554a40b17743a522
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869432Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707453}

There should only be one mojom::GpuService message pipe so
GpuServiceImpl only needs one receiver instead of a set of them.

Bug: none
Change-Id: I76737d92dfcd4af84120709f4a25497ca34ab9e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869396Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707452}

This changes the display source extension to use network.mojom.IPAddress
for passing IP addresses over Mojo and network.mojom.IPEndPoint for
passing IP address and port number combinations over Mojo. That prevents
invalid IP addresses and port numbers from be accepted.

Bug: 242107,666823
Change-Id: Id3d4d98e389ff224d073983f61261bd643d29d9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675432
Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com>
Auto-Submit: Eero Häkkinen <eero.hakkinen@intel.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707451}

Currently uses default foreground color and transparent background color.

Uploaded screenshot in bug comment 25

Bug: 991037
Change-Id: Ic9a9899badaad7e06a94854f216ba4bfc26a238a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861047
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#707450}

If the domain does not match the condition for back-forward cache, the
back-forward cache is not used and then recording the outcome or other
things does not make sense. This CL skips to record anything in such
case.

Bug: 1004676
Change-Id: I7845598f7956bd3f02a099c9eb3053fa49d02fa1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869229
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707449}

This adds a check to determine if the Screen Capture permission has
already been granted and also triggers a 'fake' Screen Capture so
that the binary will be added to the list of apps that the user can
grant Screen Recording permission to.

Bug: 1012545
Change-Id: Ia3ad4709f0e594fd07660f62a683e6725f762805
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867447
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Auto-Submit: Gary Kacmarcik <garykac@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707448}

Creates a new BadgeType for the Save Credit Card Infobar and setups the
initial configuration for the SaveCard badge:

Adds support for kBadgeTypeSaveCard on BadgePopupMenuItem.
Creates a BadgeButton in the factory for the Save Credit Card Infobar.
Creates a Popup menu option for the Badge Popup Menu.
Creates an A11y constant for SaveCard Infobar.


Bug: 1014652
Change-Id: Ic8b88961dfc701783aa72e8c0f1009fb7c721d18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867273
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707447}

This CL left-justify artist and track title when artwork is not
available. We also don't hide the artwork view until waiting for 2.5
seconds after getting an empty artwork since the artwork could be
in the process of downloading and media session sent an empty artwork
first.


Bug: 1012418
Change-Id: Iac85af54b314cdda97b97567e6466b72464769ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846729
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707446}

Change-Id: Ib3d02f306a5965e122e61a572c3771a3905c4b13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867432Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707445}

Track the new pages created in the AppList root grid. This metric will
be recorded if a new page is added by drag and drop an app into a new
page, by moving the app with the keyboard or as a result of an app added
to the grid.

Bug: 954432
Change-Id: I8cccaef7ac7f0bd7ec20f161d0f2e5509d778081
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859580
Commit-Queue: Ana Salazar <anasalazar@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707444}

This CL is a followup to:
https://chromium-review.googlesource.com/c/chromium/src/+/1865616

It should prevent renderer-initiated or browser startup focus events
from triggering on-focus suggestions in the omnibox.

Bug: 1013287, 996516
Change-Id: I5bb000a6ce37a2adbd9dec9b1ef2f3a78da1ac42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867307Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707443}

The fuzzer for HandleMessage discovered a heap buffer overflow.  This
is not super serious because an evil kernel is outside of our threat
model.

It turns out that the NLMSG macros in netlink.h and RTA macros in
rtnetlink.h assume a signed integer type. Because we used size_t, the
*_NEXT macros were actually underflowing the size, causing the *_OK
macros to erroneously return true.

In excruciating detail: consider a loop using the RTA macros and
|size_t length| to represent the number of bytes remaining in the
buffer. RTA_OK(rta, length) checks whether rta->rta_len <= length.
Then, RTA_NEXT(rta,length) subtracts RTA_ALIGN(rta->rta_len) from
|length|. Supposing rta->rta_len == 9 and |length| == 10, RTA_NEXT
will actually subtract *12* from |length|. Yikes!

Bug: 1015070
Change-Id: I687bba0b814d7e76082e9f53b12a1f90fb59180d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865671
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707442}

This patch means disable save button when 'card expired' error message
is seen in chrome://settings/payments.

Bug: 917812
Change-Id: Icc5d2b85160faddd050b405146acfa62d718d33d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832181
Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: sebsg <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707441}

ChromeEarlGreyAppInterface returns NSError*
to indicate test failure, not BOOL.

Bug: 1015549
Change-Id: I4d8478910c6914e94f07ea1ba0fa28ac7378ea2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866956
Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707440}

While the Blink tests for the speech synthesis API that we wrote use
internals to mock the speech engine, the speech synthesis Web Platform Tests
do not, so they were exercising real platform speech APIs on some platforms.
Fix that by providing a testing implementation of TtsPlatform specifically
for web tests.

This change doesn't try to get any new WPTs to pass, it just hopefully
introduces some more stability and consistency.

Bug: 1003410
Change-Id: I45972c4717978a52427fce06bfe2e236b67cfab3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821741
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707439}

http/tests/devtools/a11y-axe-core/performance/landing-page-a11y-test.js
is failing on WebKit Linux MSAN.
https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN


TBR=juxiao@microsoft.com, yangguo@chromium.org

Bug: 1015859
Change-Id: I61ac9a670f1d403d334f2e27e0e995ad1644ec2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869033Reviewed-by: Lan Wei <lanwei@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707438}

Fix password change events for sign-in non-syncing passwords.
Previously, we were double counting password-change events where
if the user first signs into an account, a password change event
would trigger. This checks to see if a password hash already
exists for the username first before triggering.

Bug: 1015515
Change-Id: Ic8027f7c68fe1803a295a730812569dc0d4faf2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866911Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Bettina Dea <bdea@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Bettina Dea <bdea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707437}

This reverts commit 10cddf87.

Reason for revert: This original change is causing flaky failures locally on some device and might be causing flaky infra failures on CI bots. Will investigate locally and redo this change. See crbug/1013462 .

Original change's description:
> Change location of ensureAppLaunchedWithFeatures call for test case.
> 
> Moved ensureAppLaunchedWithFeatures from -setUp to overriding
> launchAppForTestMethod to eliminate unnecessary relaunches. CQ bot run
> results show significant improvement without the relaunches.
> 
> BUG: 1009017, 1010463
> 
> Change-Id: I650304daaa9e4271310e180635a8fb6ff865f717
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854786
> Reviewed-by: Gauthier Ambard <gambard@chromium.org>
> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#706521}

TBR=lindsayw@chromium.org,gambard@chromium.org,zhaoyangli@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I41e945fec5166c3d5cd487244775a40c4ec0ad4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868983Reviewed-by: Yun Liu <yliuyliu@google.com>
Commit-Queue: Yun Liu <yliuyliu@google.com>
Cr-Commit-Position: refs/heads/master@{#707436}

Bug: 1014122
Change-Id: I32dcb21d17d962c26ae02bd167330abc9fe39a16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863839
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707435}

https://android.googlesource.com/platform/external/perfetto.git/+log/2e43102c54d1..b78fa92a5114

git log 2e43102c54d1..b78fa92a5114 --date=short --no-merges --format='%ad %ae %s'
2019-10-18 lalitm@google.com trace_processor: fix starting on the correct bit for set bits iter
2019-10-18 lalitm@google.com Merge "trace_processor: use packet ts if power rail ts is empty"

Created with:
  gclient setdep -r src/third_party/perfetto@b78fa92a5114

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: chromium:135177627
Change-Id: I8ae77dab22fe869b36e5cf06554f875f84731315
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868978Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#707434}

Bug: 988753,988788,988800,988807
Change-Id: Ia07028ee94a734236463563070523e6f493be8d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845996Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Scott Haseley <shaseley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707433}