GitLab

Generate DIR_METADATA files and remove metadata from OWNERS
files for //ui/events.

R=nzolghadr@chromium.org, sadrul@chromium.org, wez@chromium.org

Bug: 1113033
Change-Id: I3efd4af2f9405bcddef0b0574553b55cf413cbe1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477662
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818026}

Generate DIR_METADATA files and remove metadata from OWNERS
files for //ui/gfx.

R=thakis@chromium.org

Bug: 1113033
Change-Id: I9e1aeded0e6703a8473bd83fa2c7d7e98ebe3121
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477445
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818025}

This CL adds the initial drag image that is displayed when dragging
items out of Holding Space UI. Follow up CLs will:

- Render screenshot items differently
- Render at most two items with an overflow badge if necessary

Note that this CL does not use ui::Layer's to accomplish the desired
drop shadow effect because a solution could not be identified to paint
a view hierarchy with its layer tree to an SkBitmap.

Demo: http://shortn/_mWLGXsTcTY
Note that the screen recorder did not capture the cursor moving with
the drag image but it actually does so on device.

Bug: 1139113
Change-Id: I569bf42b31beb19459f85a80bfc1c3f673a40b1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476728
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818024}

Before this CL bluetooth device peripherals subtext where not being
vocalized by chromeVox, this CL adds subtext to vocalized string.

Bug: 1132975
Change-Id: Idabfe6abaf90f186c96d1b56952c911c7ba5fc53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472585
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818023}

This reverts commit 7201dc96.

Reason for revert: Failing tests https://ci.chromium.org/p/chrome/builders/ci/android-arm-official-tests/1423

Original change's description:
> [Android] Add render test for sync promo in MainSettings
>
> This cl adds a render test to check that sync promo is shown when the
> user has signed in with without sync consent.
>
> Bug: 1105800
> Change-Id: I24bb2a78f84ebf39586fbe285bc7361ecba30cc1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467878
> Reviewed-by: Marc Treib <treib@chromium.org>
> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#817018}

TBR=treib@chromium.org,triploblastic@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1105800
Change-Id: I474d567a8583efe10b55068cace4ef08da257314
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481048Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818022}

Bug: 1109316
Change-Id: I65ff9feff3fff55a159eaf488c1a71cdbf29662a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480803Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818021}

This argument makes dependencies to classes in the same package be
ignored in the audit. This is especially useful when auditing a package
that will be entirely modularized.

Change-Id: I115c8bfc3bf123a5b0eedcc66d369aba620b72f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480626
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818020}

Added explicit values to enum entries and added a comment mentioning to
not change or re-use those values.

Also made histogram definition clearer.

Change-Id: Idada23970bd834575d314bcfac941f5a3b0e255c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480582
Auto-Submit: sebsg <sebsg@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818019}

to pass output_directory.

Bug: 1120190
Change-Id: Ibd449d4351200a4d4c50c1d9f281d611ae9ca133
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480625
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818018}

mac-arm64-rel-tests will be modified to serialize tests, which has the
potential to dramtically increase the execution time. The timeout is
being doubled to hopefully provide sufficient headroom for the time to
serially execute the tests.

Bug: 1139038
Change-Id: I904a7b9835b61cec053de28663df5ce5fe6a6315
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481068
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818017}

Bug: 1136195
Change-Id: Ib8062352a867f256207397e20f583da609beb2cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463589
Commit-Queue: Joon Ahn <joonbug@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818016}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/eaf54362..b0723ad5

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I956724f78243eccbf7efb8efa2f7c448da309be1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480663Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#818015}

Bug: 1138534
Change-Id: Iadcc84d914d8071c8c0a49226b456dd0c01c8c73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480805Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818014}

* History is an ExecutionContextClient, so it is primarily associated
  with a LocalDOMWindow/ExecutionContext. Get state off of
  LocalDOMWindow instead of LocalFrame or Document where possible,
  and stop using the ExecutionContextClient::GetFrame() helper.
* Add a GetHistoryItem() helper to make it cleaner to walk to the
  DocumentLoader to get to the HistoryItem.
* Remove a bunch of unnecessary null-checks.

Change-Id: I8f283586b3ecb164820481184c0fc3f84f8d5d26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477903
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Nate Chapin <japhet@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818013}

Now that the underlying bug has been fixed by crrev.com/817708, assume
that these tests run reliably on Android again.

Bug: 1095679
Tbr: backer@chromium.org
Tbr: khushalsagar@chromium.org
Change-Id: If5e6de3303027ccf9b7a8b1e49f503cbbab446d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478025Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818012}

It's already exported from content.dll. Trying to link it in twice
causes duplicate definition error when building with the latest Clang.

Bug: 1138934
Change-Id: I7440362ab7b8c3fe4debe0e3aba623c48e94a92d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480822
Commit-Queue: Hans Wennborg <hans@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818011}

This bot's Vulkan driver is unreliable.
See crbug.com/941685, crbug.com/915430

Bug: 1139366
Change-Id: I5cfab5c09efc7494c7c144a6f6dcb3d3d775aa0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480584
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Kramer Ge <fangzhoug@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818010}

Also changes the tests to actually click the buttons instead of just
running the button click handlers.

Bug: 772945
Change-Id: I34bd91b821398eeeb14d540411c1ae1cec86421b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476720
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Megan Jablonski <megjablon@chromium.org>
Reviewed-by: Megan Jablonski <megjablon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818009}

The script to push a new policy has moved to components, but we didn't
update the documentation.

Change-Id: I34bc6259c88db541056b098b587d7cfab9e0e8ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469460
Auto-Submit: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818008}

Previously, only breadcrumbs associated with BrowserStates were being
persisted across sessions. These events were stored inside the
BrowserState storage directory.

This CL moves the persisted events to files outside of the BrowserState
directories. Additionally, it listens for breadcrumbs from all
BreadcrumbManager instances. This allows all breadcrumbs to persist
across application cold starts.

Bug:1117667

Change-Id: Ief43577df397055b854f0beff3d55c92a3ed4289
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438579
Auto-Submit: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818007}

Generate DIR_METADATA files and remove metadata from OWNERS
files for //services.

R=jam@chromium.org

Bug: 1113033
Change-Id: Iecbb630beab2b961a7bc4292a3f5185325a1a132
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473338
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818006}

- Uses a temporary function to map an enum to it's name
- Test names will be localized in future CL

Bug: 1125150
Test: browser_tests --gtest_filter=DiagnosticsApp*
Change-Id: I0e2159fdb6b1115559af073b49818b45cab072e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462234
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818005}

This CL implement the capture label widget bounds change and opacity
fade in animation before 3-seconds countdown starts.

- If there is a label or label button showing when starting countdown,
(as in the case of fullscreen record or region record or window record
in tablet mode), we'll do bounds change animation.
- If there is no label when starting countdown (as in the case of window
record in clamshell mode), we'll do bounds shrink down + opacity fade in
animation.

Not covered in this CL:
- 3 seconds countdown animation. Will do it in a following CL.

Bug: 1126669
Change-Id: Iabb836aa79de9018d0259ae1a744a8bfd3bf3925
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476614Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818004}

Roll ChromeOS Orderfiles from 87-4277.0-1602498224-benchmark-87.0.4280.21-r1 to 88-4277.0-1602497703-benchmark-88.0.4288.0-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: I3f5a4b7649466cfe2790ed1c56a54721f1b584e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480929Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#818003}

This change begins adding test coverage (still quite incomplete) for
//ui/views/color_chooser.

Bug: None
Change-Id: I7ef91fe5b276e90f7e3bd13fcb153b66f90d72c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406390
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818002}

The PlatformVerification mojo object can become invalid during the
lifetime of the CdmFactory, so reset it on error and reconnect it.

BUG=b:153111783
TEST=ChromeOsCdmFactory works across page refreshes

Change-Id: If54667256bcabf8aa2624d6a89c32e4a46f4bcb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476727
Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com>
Cr-Commit-Position: refs/heads/master@{#818001}

This CL updates our approach to the state description
member variable of AccessibilityNodeInfo objects on Android.
Until now we have picked a single state description based
on the node. With this change we now concatenate all
potential state descriptions to make sure no information is
lost on mixed nodes (e.g. multiselectable listBox).

We added a few exceptions to concatenation, namely the case
of a multiselectable listbox will not announce the number of
items in the list when some are selected. This is to prevent
an utterance like:

"multiselectable, 2 of 4 selected. 4 items"

Instead in the case of a multiselectable listbox, it will be
read as either:

"multiselectable, none selected. 4 items"
or
"multiselectable, 2 of 4 selected."

Similarly, we make toggle buttons and partially checked
checkboxes mutually exclusive to prevent double speak.

As of now all other cases are simply concatenated.


AX-Relnotes: N/A
Change-Id: I5650230b141cae24dfd935be596fb14720b723ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476520Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Mark Schillaci <mschillaci@google.com>
Commit-Queue: Mark Schillaci <mschillaci@google.com>
Cr-Commit-Position: refs/heads/master@{#818000}

But hardcode it to false for public tryjobs.

This is a quick-fix to avoid sharing links where authenticate=1 is
dropped.

Note: There is no harm in authenticating unnecessarily (except for users
needing to go though the steps of signing in).

Bug: 1131568
Change-Id: I96dbd4133df7ca3315c72d88ffb5ad515c401ab2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477038Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817999}

BUG=None

Change-Id: I61815af5d9779b8379001421c46b8fe1f14d396b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461324
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817998}

Bug: 1132403
Change-Id: I690822d909ed5c86bcb1b9c6652bfc9dd61cf3e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479142
Commit-Queue: John Lee <johntlee@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817997}

The goal is to speed-up the compilation and linkinng on linux-lacros-rel
to as to offset the extra overhead of enabling 'also_build_ash_chrome'
gn arg.

Bug: 1129223
Change-Id: I7313fc22cc0115a33c8b4c0325655dae26a1c249
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477611Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817996}

This reverts commit 593dfd4d.

Reason for revert: Collided with history generate grd CL, CQ did
not re-run.

Original change's description:
> WebUI: Add support for resource_path_rewrites to generate_grd
>
> Support more general resource path rewrites by adding the option to
> pass such rewrites from the caller in the form:
> "original_file_path|resource_path_for_grd"
> Leverage this to rename rollup files, and remove the special-case logic
> that was used for this purpose originally.
>
> Bug: 1132403
> Change-Id: Icffa7d85497ab000044fed1ebcd9542cb5b869bc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476623
> Reviewed-by: dpapad <dpapad@chromium.org>
> Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#817961}

TBR=dpapad@chromium.org,rbpotter@chromium.org

Change-Id: Iabdc7d8cc3cb45704330e3ba9b79e3ac585446d5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1132403
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481063Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817995}

Before this CL, ScopedTestSystemNSSKeySlotMixin used ScopedTestNSSDB
which used a temp. directory to save the database data. This temp.
directory will be deleted after browser pre-tests (tests that start with
PRE_).

This CL changes ScopedTestSystemNSSKeySlotMixin such that it opens a
software slot in the user data directory which is not deleted after
browser pre-tests so to allow tests using system slot to simulate
browser restarts.

Bug: 1136437, 1127284, 1113115
Change-Id: Ie61a6a7f594b996236b709e2db765a240e7b8800
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460730Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Omar Morsi <omorsi@google.com>
Cr-Commit-Position: refs/heads/master@{#817994}

These no longer fail (were fixed at some point).

Bug: 1084472
Change-Id: I45dd6e907056825a0bb8788dad7d74fc6446dd2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445154Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com>
Auto-Submit: Maksim Sisov (GMT+3) <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#817993}

AuthTokenRequester is a helper class that attempts to obtain a
PinUvAuthToken from a FidoAuthenticator. It has a Delegate that collects
PINs, updates the UI and receives the result.

Follow-up CLs will integrate AuthTokenRequester into FidoRequestHandler
implementations and replace the token request logic there.

Change-Id: Ie189dab3a02fb1a118e128bb7589461ba5c5fad3
Bug: 1139111
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469404Reviewed-by: Nina Satragno <nsatragno@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#817992}

Roll Chrome Win32 PGO profile from chrome-win32-master-1602795589-2bd353ec3fee304a6bd3887aca77b7d3fb1210e3.profdata to chrome-win32-master-1602838722-3d3847c86317a9aa85069273b7be64c1533b4e7a.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: Idfac5d1a8893a7ecdba9333cff7b6f12ea9fcf4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478891Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#817991}

This reverts commit b2a6b60d.

Since this patch is introducing a bug, I need to revert this patch:
* sign-in
* open the settings
* open the account list
* open the add SSO account view
* cancel the SSO add account view
Result: the user can't do sign-out anymore.

Original change's description:
> [iOS] Dismiss views on top of Settings UI after authentication.
>
> Currently the sign out UI is dismissed conditionally when the
> authentication flow is complete. Remove the conditional since we expect
> the sign out UI every time authentication completes.
>
> Bug: 1125631
> Change-Id: Ide9805e5490377f9ec3cf5d3625622ab08e876a4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472005
> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
> Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#817863}

TBR=jlebel@chromium.org,fernandex@chromium.org

Change-Id: I40270d09662e2ccd5d24b8915d540cb5cd28ae49
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1125631
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480824Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817990}

settings subpage.

To do this, move the component updater observer logic to the captions
handler. Introduce a new ChromeOS-specific captions handler which will
observe the SODA download from the DLC service (to be implemented in a
follow-up).

AX-Relnotes: N/A (feature not launched yet)

Bug: 1055150, 1111002
Change-Id: I1f752836a1310f8eab44ae5fa31ca34060fb8147
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473446
Commit-Queue: Abigail Klein <abigailbklein@google.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817989}

This CL adds metric for the dismissal button in the web sign-in bottom
sheet.

Bug: 1139309
Change-Id: Idc381b3a79c77aa471b9b1a0b19bcc8fb731a4ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479426Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817988}

This is a preparation to add GradientMask[1] support.

[1] https://docs.google.com/document/d/1AXgfk66ROEr225roqAuPxrqWNsnDh91lHCQJ_cw8RrI/edit#

Bug: 1039003
Change-Id: Ib452c83e3408a1cbdcfb743e0a5ce819258f5ff3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459429Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817987}