- 03 Apr, 2020 40 commits
-
-
Javier Ernesto Flores Robles authored
Bug: 1045454 Change-Id: I44d39828843e817e82f20afe4abc1558b92a1e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134252 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#756198}
-
Javier Ernesto Flores Robles authored
Use ivars inside the property getters. Create lazy init for |reauthenticationModule|. Bug: 1045455 Change-Id: I9c7d77712e6bde22c9b079beec328ec015352691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134828 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Hitoshi Yoshida authored
Add enumerations newly added in IDL files but their generated files are not added in GN lists. Bug: 839389 Change-Id: I07916de1312f533d1d44cea78e3ec83749e30b5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134182 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#756196}
-
Benoit Lize authored
FontResource holds onto the encoded and decoded versions of the font. However the encoded version is never accessed after it has been decoded, and the decoded version is never discarded. This means that we are holding on the SharedBuffer without a need for it. Fonts are almost always compressed, with a ~3x compression ratio typical. From local benchmarking, encoded fonts are commonly ~500kiB on popular news websites. This CL discards the fonts after they've been decoded. Change-Id: Ic72009431084cdd1e30fcd69ba1ec59788c0cede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134291Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#756195}
-
Jacobo Aragunde Pérez authored
Per Mojo docs (//mojo/public/cpp/bindings/README.md#Enums), kMaxValue shares the value of the highest enumerator of the enum. In this case, it shares the value of kWindow, that means kWindow is not being dealt with in that switch statement. Bug: None Change-Id: I44a14426772b4b0e3e804e891cf2197a96650088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132159Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Cr-Commit-Position: refs/heads/master@{#756194}
-
Nicholas Verne authored
These tests cover the correct behavior on app launch. Bug: 1024693 Change-Id: I9808e7492e696f8fea89bf5c7eba49439c9fc5aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135091 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#756193}
-
Mathias Carlen authored
Before this patch, the backend url logic was in the android client and not directly available to the extension code. Since switching backends is useful during development and testing scenarios, this patch moves the command line switches to a shared file. The default URL can be in the service impl and does not need to be part of the client interface. The patch also cleans up the use of the api keys, which don't need to be handled in chrome, only the installation channel needs to be part of the Client interface. Bug: b/143736397 Change-Id: I30caeffc226e6936d43e0000d897f9bfbf53d9c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129549 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#756192}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Iaae3dbd46bc56a2e6b0c0f2d7ed2588dddcb014d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132080 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#756191}
-
Anastasiia Nikolaienko authored
Show kite icon in Account Manager for child users instead of info icon. Screenshot: http://screen/FNcYnvQJFwC Bug: 1054798 Change-Id: Ic8f99fe4dcffd2766f43dc96fe2c48bff03103fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132143 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#756190}
-
Yuki Shiino authored
V8 doesn't allow to specify v8::SideEffectType::kHasNoSideEffect even when there is no setter and the property is v8::ReadOnly. Fixes the flag. Bug: 839389 Change-Id: I579dffaa243f709e090747e29d513564b9c830f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134746Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#756189}
-
Miyoung Shin authored
This CL uses CheckedNumeric to avoid UBSAN issue of the integer overflow when calculating rect coordinates in ChromeClientImpl::ViewportToScreen. Fuzzer report: https://clusterfuzz.com/testcase-detail/4895093060861952 Bug: 1067114 Change-Id: Ibe0b4f353d06885024b915afedf22c125ee595d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134178Reviewed-by:
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Ib58dec4de1c128074264e0d530071bd3a7cd5179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132889Reviewed-by:
-
Nancy Wang authored
This reverts commit 527adae2. findit revert something badly, so I have to revert it. Reason for revert: <INSERT REASONING HERE> Original change's description: > Replace LaunchService's OpenApplication with AppService interface. > > LaunchService will be removed in the follow up CL:2116156 > > BUG=1061843 > > Change-Id: Ifdf73b4ce7bd1cc090a1e1f17c65cf3e36f242dc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132009 > Commit-Queue: Nancy Wang <nancylingwang@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756163} TBR=xiyuan@chromium.org,sky@chromium.org,dominickn@chromium.org,nancylingwang@chromium.org Change-Id: I4c03bd10ac96dfb74687715999bd5ec0d45bb749 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1061843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134033Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#756186}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c3968223894a..fca03eaabd52 Created with: gclient setdep -r src-internal@fca03eaabd52 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I6b30191177cdfce469b8f71c13a51cb7958561de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135450Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756185}
-
Findit authored
This reverts commit d07c4196. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 756170 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2QwN2M0MTk2Mjc0YWI5YzViNzgxOWNlYTM4MmNkYWFmZTk5ZTNkY2MM Sample Failed Build: https://ci.chromium.org/b/8884060269631959536 Sample Failed Step: compile Original change's description: > Remove launch service. > > BUG=1061843 > > Change-Id: I12efd2899403cb9cc5e9dafc04300a7156342ed9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116156 > Commit-Queue: Nancy Wang <nancylingwang@chromium.org> > Reviewed-by: Nancy Wang <nancylingwang@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Eric Willigers <ericwilligers@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756170} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=1061843 Change-Id: I413bad145ac3740f868bc94f43db3256666cfedb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135529 Cr-Commit-Position: refs/heads/master@{#756184}
-
Colin Blundell authored
This CL adds another test of WebLayer's external intent launching: When the user clicks a link to navigate to a page that then launches an intent without a user gesture (e.g., via onLoad()), the intent is launched. This case differs from that of the user navigating to said page directly via typing; once Weblayer incorporates //chrome's TabRedirectHandler the latter will be blocked by policy, but the former (the behavior being tested in this CL) is supported by Chrome and should be supported by WebLayer as well. Bug: 1031465 Change-Id: I58e1fc7bbde9fc6235606523f06797a7877bb108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132385 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#756183}
-
Eric Willigers authored
When a user-installed PWA was newly synced to a Chromebook, and the PWA was opened, we were defaulting to showing minimal-ui controls even if the manifest specified display: standalone. We now fetch the display mode from the manifest during sync. Bug: 1067504 Change-Id: I1189da9cdf05a1fc581ba19e90b67e020e83e1cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134089 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#756182}
-
Bartek Nowierski authored
Change-Id: I9a7af00fdce8e670590d71cfac1577d9961a4baf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134180 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Nancy Wang authored
This reverts commit c544f756. I have fixed it, don't revert! Reason for revert: <INSERT REASONING HERE> Change-Id: Iecfa4fe3ccf77242f103cd201fc69dffec7bb7c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133999Reviewed-by:
-
Bartek Nowierski authored
Change-Id: Ie37e7fdcd1e9c586fbc9276a5b9874cd98d46a0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126969 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
Kent Tamura authored
This CL has no behavior changes. Bug: 690036 Change-Id: I8ca4936b9b9fc841199b3762146bcd9233fc34c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134751 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#756178}
-
Alexandre Courbot authored
Getting the visible rectangle is a common operation that will be used by both the VDA decoder and the VD. Factorize it into a single method. BUG=b:149663704 TEST=vdatest passing on Hana. Change-Id: I1d254a7007bcd5919a8c9639b90c72c0f4adacd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131431 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#756177}
-
danielng authored
Adding a toggle to the plugin vm settings page to control whether the camera should be shared with plugin vm. Currently hidden behind a feature which is disabled by default. Bug: 1016193 Change-Id: I793c66ada1287fcaee21088f123281d3f8f76a52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131675Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/0b66fa3b62cb..b5757b95005b git log 0b66fa3b62cb..b5757b95005b --date=short --first-parent --format='%ad %ae %s' 2020-04-03 rharrison@google.com Remove extra semicolons (#2170) Created with: gclient setdep -r src/third_party/glslang/src@b5757b95005b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: I375435dc192da0684e39ab2438b207d703d9762e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135452Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756175}
-
Bartek Nowierski authored
This avoids passing an object by value (copy consturctor may not always exist). No more need for overshadowing IsDeletedValue hack for VectorBackedLinkedListNode. Change-Id: I5895a7e9b34f244e658bb319443b5c22451bd6ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134750Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
-
Maksim Sisov authored
Even though we set require_mojo to true in the PlatformProperties, in certain scenarios Ozone might be initialized without mojo, but in a single process mode (for example, unittests, ozone_demo). In this case, we should instantiate a direct connection between buffer managers without mojo. I could use base::TaskEnvironment, but it will require too much changes to how different tests are initialized. For example, binding an interface and sending a mojo call requires a a task runner handle (installed in WaylandBufferManagerGpu). And that fails with compositor_unittests - some tests create TaskEnvironment, and some don't. Initializing the TaskEnvironment in CompositorTestSuite won't help, because (as I said) some tests do that. This results in crashing when tls delegate is set. Bug: 1067156 Change-Id: If3236f9604c692b4ed6efc5dbaf9cc67ce36d62e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128111Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#756173}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/cb70daa3fa9a..47cd4085b978 git log cb70daa3fa9a..47cd4085b978 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3eea752c..ae03941a (756022:756130) Created with: gclient setdep -r src/third_party/webrtc@47cd4085b978 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If824b41a4171acffdbda91d2dc46e05ac2f9e5ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135447Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic78830db4c43ceed8a8c43500bf570d8aee9ff82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135449Reviewed-by:
-
nancy authored
BUG=1061843 Change-Id: I12efd2899403cb9cc5e9dafc04300a7156342ed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116156 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#756170}
-
Findit authored
This reverts commit 527adae2. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 756163 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzUyN2FkYWUyOGQ4Y2RhYWExY2E3OWI2OTE5ZWRiM2ZmMDQxZmFhODgM Sample Failed Build: https://ci.chromium.org/b/8884064963719290256 Sample Failed Step: compile Original change's description: > Replace LaunchService's OpenApplication with AppService interface. > > LaunchService will be removed in the follow up CL:2116156 > > BUG=1061843 > > Change-Id: Ifdf73b4ce7bd1cc090a1e1f17c65cf3e36f242dc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132009 > Commit-Queue: Nancy Wang <nancylingwang@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756163} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=1061843 Change-Id: Ic02e69cd59478d5d4547b02a73590d06f02da128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135526 Cr-Commit-Position: refs/heads/master@{#756169}
-
Julie Jeongeun Kim authored
This CL migrates this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose and renames it to flex-minimum-size-002.html. Bug: 1063749 Change-Id: Ia9479664c16a2ff8bb2c9ac70df5a4c0a275982d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133538 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#756168}
-
Tibor Goldschwendt authored
NewTabPageLogoTest.All is a suite of JS tests and was disabled because the "receiving resize message resizes doodle" test was flaky. This CL re-enables NewTabPageLogoTest.All and disables "receiving resize message resizes doodle" to at least keep coverage of the non-flaky JS tests. Bug: 1065812 Change-Id: Id17b039be73cbb81f4e4f370267b5c92a7402052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134403 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#756167}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/395a627b8ad8..2e6c0ac0b11d git log 395a627b8ad8..2e6c0ac0b11d --date=short --first-parent --format='%ad %ae %s' 2020-04-03 fancl@chromium.org Initial implementation of auto-triage Created with: gclient setdep -r src/third_party/catapult@2e6c0ac0b11d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1064955 Tbr: rmhasan@google.com Change-Id: I2df50401a70342c1177d64997d1a43872b68c583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134824Reviewed-by:
-
Maksim Sisov authored
This is a clean up of ui/gl, which goal is to get rid of USE_X11 guards and place the code to corresponding x11 source/header files so that ozone/x11, which is not guarded by USE_X11, can utilize the same classes. In this CL, I moved all X11 code to gl_surface_gl_x11, and also created a utility that each platform can implement to provide custom values for display attributes, alpha and buffer size. Also, I had to add a singleton with an optional interface that is set in ui/gl/init. The reason why I decided to do it like that is that we need X11 to set some x11 specific egl attributes. While it could have been not a problem to have just utility methods inside ui/gl for x11 and stub for others, it's a problem for ozone as we can't depend on ui/ozone from ui/gl. Thus, we have a singleton interface in ui/gl, which is then set in ui/gl/init right before display initialization. R=backer@chromium.org Bug: 1036285 Change-Id: I3117e65b8ba240ad16e87ec6c1489ccd6d71934f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116443Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
-
Ted Choc authored
If you were viewing partner bookmarks and left Chrome, and the process is killed while in the background (triggering a locale change forces this), then return to Chrome, the partner bookmarks will be editable. To solve this, change the partner bookmark reader pull the edit state value instead of relying on push from an external source. BUG=815276 Change-Id: I2fdc3f095be14c790a6a7eec79f79f79107acd67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129213 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#756164}
-
nancy authored
LaunchService will be removed in the follow up CL:2116156 BUG=1061843 Change-Id: Ifdf73b4ce7bd1cc090a1e1f17c65cf3e36f242dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132009 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
nancy authored
Replace launch service OpenApplication with AppService launch interface: LaunchAppWithUrl. Launch service will be removed. Move CreateAppIdLaunchParamsWithEventFlags from app_launch_params to launch_utils. Modify intent to add the port number to handle the URL including the port number, like https://app.com:35999/in_scope/index.html, to resolve the browser tests failure issue. BUG=1061843 Change-Id: Ib33063e90a4d0e813b19d339d3542632e546d671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130949 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#756162}
-
Ramin Halavati authored
For proper support of multiple off-the-record profiles for one regular profile, an OTRProfileID is added to profile class. This CL is based on the following design doc: https://docs.google.com/document/d/1xj21DPfwo1gZ8kagj6i1lSmKwG1dW-4KPt3yvVcsvOg This is the first step of implementation of this design doc, only adding OTRProfileID to C++ classes and adding/updating some tests. Bug: 1033903 Change-Id: Iaed207994c01372f3349ecce1333ee55fea44d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080253Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#756161}
-
Anders Hartvoll Ruud authored
The usage is so low that it doesn't even show on the stats page. Bug: 579788 Change-Id: Id4e8efaa5ea1b7df80fe1f07c8d35d1ab83b7f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130228 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#756160}
-
wutao authored
This is a reland of e77cef6b No changes, submit after the internal code submitted. TBR=xiaohuic@chromium.org,xiyuan@chromium.org Original change's description: > ambient: Add Get/Update Settings APIs > > This patch adds the Get/Update Settings APIs so that we can show and > update it in the Chrome OS Settings ambient mode page, which will be > implemented in a follow up cl. > > Bug: b/148483925 > Test: manual > Change-Id: Ia74d875813860a6abbfdc01479a67fed0c029fb8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125685 > Commit-Queue: Tao Wu <wutao@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#755531} Bug: b/148483925 Change-Id: I40f57d6e2cfe267a2ff27513e3702273e87d9434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135417Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#756159}
-
