- 02 Mar, 2020 40 commits
-
-
Peter Kvitek authored
This eliminates questionable practice of switching timeDomain while performance metrics collection is enabled by allowing us to remove Performance.setTimeDomain() method. timeDomain argument is optional and has default value of 'timeTicks' Bug: 1056306 Change-Id: I085bb5939d04eba65f3f6cf07f6a4d8f94fa32a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076427 Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#745988}
-
Dominik Röttsches authored
We continue to need those to monitor DirectWrite stability in the field (for font local matching, font fallback, browser side DWrite IPC host). Change owner for sandbox startup UMA. Fixed: 1053104, 1052966, 1052965, 1052964, 1052963, 1052962, 1052961, 1052960, 1052959, 1052958, 1052928, 1052927 Change-Id: I6f5782619a2236bf8f0f20c50280325fd820c19a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082375Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#745987}
-
Tanya Gupta authored
- Added toast to be displayed when the QRCode doesn't correspond to a URL. - Fixed issue where camera would read QRCode even when the screen was on share tab. Change-Id: Icc90903310bf4fb12c36e336cfe7d174bc7b4246 Fixed a few bugs Change-Id: Id75a9e785f33b15e596663b1f9e0de1a17a6cdec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079093 Commit-Queue: Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#745986}
-
Evan Stade authored
This allows the embedder to run the beforeunload handler, if any, before closing a tab. Bug: 1055540,1025256 Change-Id: I894256d0a05f11d58fa4234265beb03b34a019b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072922 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#745985}
-
Mario Sanchez Prada authored
Original: r745386 http://crrev.com/c/2041759 Revert: r745843 http://crrev.com/c/2082658 Fix "no-op build wasn't a no-op" error on bots using ninja's restat tool Make sure to "touch" the new file so that access, modify and change times are always newer than the source file's, otherwise Modify time will be kept as per the call to shutil.copystat(), causing unnecessary generations of the output file in in subsequent incremental due to ninja considering it dirty. Original change's description: New script to downgrade .mojom files from the new to the old mojo types Following the discussion in chromium-mojo and platform-architecture-dev, we're proposing to add this script to the chromium repository so that external repositories that still depend on the old mojo types (e.g. Android's and ChromeOS's libchrome repos) have a simple and maintained way to downgrade Chromium's .mojom files to the old syntax, while they can't support the new one. This CL includes a new mojom_types_downgrader.py script that can be integrates with those external builds requiring it, plus the necessary unit tests to guarantee that the downgraded files can still be parsed correctly by the bindings generator (i.e. mojom_bindings_generator.py). For extra context, see the relevant discussion in the chromium-mojo ML: https://groups.google.com/a/chromium.org/d/msg/chromium-mojo/BRK0Xeu7bgQ/z00hkpaGEQAJ Bug: 1035484, 1057525 Change-Id: Ib7dd91405e1b26a6ba6e8b0c40b97f9afca27df5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082513Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#745984}
-
Dominique Fauteux-Chapleau authored
Done through 2 refactors: - FileContents is now declared in the header to be used by tests. - GetSha256Blocking is now in the header as a static function. Bug: 1041890 Change-Id: I15e6ecf6938324271e2bf018db57d0071d7d0072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078973Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#745983}
-
Side Yilmaz authored
This CL update the profile passing to TrackerFactory from ToolbarManager. Currently, it is always regular profile, however it is not safe because of possible data leakage from incognito to regular profile. Therefore, this CL uses |isIncognito| boolean created from current tab model to get correct profile object(i.e., regular or off-the-record profile). Bug: 1041781 Change-Id: Ie9942d02a345cd6a755da1d8fd0b34089b22425b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075417Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#745982}
-
Koji Ishii authored
Following r741744 <crrev.com/c/2048707>, this patch fixes the block offset of a positioned object whose containing box is an inline box in split inlines. Bug: 982194 Change-Id: I3bcb9d8c6618b315abfddc0fe25284dd5a059a91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081718 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#745981}
-
Sylvain Defresne authored
Most of the include are obsolete. The remaining one can be removed as all the code is compiled with ARC thus there is no need to have a C++ smart pointer to call retain/release when the compiler can do it automatically. Also add missing guard checking that the file are correctly build with ARC (automatic reference counting) enabled. Bug: 1051997 Change-Id: Ia19d1e41aa16106ffebd87a0a3dd2815c741d8c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074297 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#745980}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. TBR=bradnelson@chromium.org Bug: 1026641 Change-Id: I0278c69144f7aee55a3abba0e405d141add05261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076358 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#745979}
-
Jaeyong Bae authored
This patch means replace selectable_list_layout_row_padding with default_list_row_padding. It is used for more generic value. This has been discussed in other patches[1]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2049424 Bug: none Change-Id: I4705c0e1208d094b4ce8704ed81dcffb6f32b7e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074998Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Cr-Commit-Position: refs/heads/master@{#745978}
-
Henrique Nakashima authored
Change-Id: I6f8fa5a4670f25ce7ca77fe8819671f989645f64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080433Reviewed-by:
Rohit Agarwal <roagarwal@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#745977}
-
Emil Segerås authored
When limit was introduced it was set to 3 seconds, but that's still a long wait, especially for repeated user actions that may result in long scroll distance, such as stepping between find-in-page matches. R=bokan@chromium.org Bug: 852549 Change-Id: If866c528c0358a6ae27f6c90f16e3a5e4bbb9302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044270 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#745976}
-
Stephen McGruer authored
This diff was generated by running: find . -type f -print0 | xargs -0 perl -pi -e "BEGIN { \$/ = undef; } s/assert_throws\(([ \n]*'[A-Za-z_]*') *(, *.)/assert_throws_dom(\1\2/gs" Then manually correcting some expectation files and fixing up whitespace. Bug: 1051932 Change-Id: I9105cb0363f3f39b7543d360ea3e3c7e06655527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079143 Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#745975}
-
Stephen McGruer authored
This diff was generated by running: find . -type f -print0 | xargs -0 perl -pi -e 'BEGIN { $/ = undef; } s/assert_throws\(([ \n]*)([A-Za-z]*Error) *\(\) *(, *.)/assert_throws_js(\1\2\3/gs' Then manually fixing up whitespace. Bug: 1051932 Change-Id: I65c91797b66c467ded3eb8c5ba4e8fdb3207921b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079831 Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#745974}
-
Daniel Cheng authored
It's simpler to just pass an initializer list. Change-Id: Ifed1b626f694f4987ebb6f30a2df24c147e8a48e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078910 Auto-Submit: Daniel Cheng <dcheng@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#745973}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b60935270c47..5f96597ad93d git log b60935270c47..5f96597ad93d --date=short --first-parent --format='%ad %ae %s' 2020-03-02 szuend@chromium.org [utilities] Use Map instead of Array for DOMNode attributes Created with: gclient setdep -r src/third_party/devtools-frontend/src@5f96597ad93d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1050549 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4cdd1b1d428ac108a6933fdb061d260ce045f920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083220Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745972}
-
Yusuke Sato authored
arc_vm_client_adapter_unittest.cc will soon start calling StartJob() twice in its ARC startup sequence, and this change will allow the test code to have more control over which job(s) fail to start. BUG=None TEST=components_unittests Change-Id: I34ca62a617e5450b98eeb7aea65d5d4b472b3602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078977 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#745971}
-
Kevin Ellis authored
CL 1715764 introduced a performance regression, where a replaced animation would not be composited for the initial frame. This was caused by a bug in calculation of the pending state, which in turn caused a replaced animation to be flagged as incompatible. The bug was fixed in CL 1728074. This patch introduced a test to ensure that the fix does not regress. Bug: 992408 Change-Id: Iab210ca9b525773ebb2c0a6f28d63f25c0b574e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080445Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#745970}
-
Monica Basta authored
This CL adds a histogram to record the displayed sWAA value in |chrome://settings/syncSetup| for sync users. We neglect the short period of time while sWAA is not fetched or is being fetched. In case of failure to fetch sWAA, we display nothing. In case of success, we either show on or off with an explanation of the reason for which sWAA is off. The histogram is recorded every time sWAA is calculated/refreshed. Bug: 1050070 Change-Id: I6ad75626edc590707c2594d86db4cb61a2069196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062421 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#745969}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/2998999dca23..6566156b03a0 git log 2998999dca23..6566156b03a0 --date=short --first-parent --format='%ad %ae %s' 2020-02-29 chrome-bot@chromium.org Update config settings by config-updater. 2020-02-29 vapier@chromium.org cros_bisect: convert to python3 only 2020-02-29 sanikak@chromium.org auto_updater: method to set clear_tpm_owner_request to 1 2020-02-29 chrome-bot@chromium.org Update config settings by config-updater. 2020-02-28 tbegin@google.com packages: prepend source or chroot paths for uprev_ebuild_from_pin 2020-02-28 vapier@chromium.org api/cbuildbot/service: drop --withevents 2020-02-28 mikenichols@chromium.org chromeos_config: Update missing Loon Rapid boards 2020-02-28 chrome-bot@chromium.org Update config settings by config-updater. 2020-02-28 cjmcdonald@chromium.org cbuildbot: Add 'no-publish-prebuilts-conf' flag 2020-02-28 mikenichols@chromium.org chromeos_config: Introduce a new loon builder tied to release tool Created with: gclient setdep -r src/third_party/chromite@6566156b03a0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I6d682be2662077640bc2f493a59dc09746463b85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083219Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745968}
-
Benoît Lizé authored
CrazyLinker is used for Chrome{,Public}.apk, but doesn't work on Android Q. In order to allow devs to use this APK on Q devices, fallback to the system linker. This doesn't affect shipped versions, as this APK doesn't ship on Android Q. Bug: 980304 Change-Id: Id311d8a317fe8eb15fb728d6f69754b342f8b306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080480Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#745967}
-
Yuki Shiino authored
Bug: 839389 Change-Id: Ic5342db153065aa1912a495da1efb150723a87aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082860Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#745966}
-
Nicolas Ouellet-Payeur authored
filter() results are not subscriptable in Python 3, so we need to use next() to retrieve the element instead. Bug: 1056747 Change-Id: I00546a0141aefe6ccd4e7ab35e833fc6e9d8a711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080202Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#745965}
-
Dominik Röttsches authored
Extend histogram lifespan since we still need to monitor Android font indexing performance before the feature switch can be removed in the future. Fixed: 1052926 Change-Id: I52794358d58e1a70c23c97f75d934ca5c9428875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083311 Commit-Queue: Dominik Röttsches <drott@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#745964}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/61f74d91f823..b03422a7370c git log 61f74d91f823..b03422a7370c --date=short --first-parent --format='%ad %ae %s' 2020-03-02 mirtad@webrtc.org Remove deprecated method onEncodingBitrate. 2020-03-02 danilchap@webrtc.org Increase accepted PSNR range for SimTimeEncoding test 2020-03-02 srte@webrtc.org Cleanup: Use common IP overhead definitions in test and prod code Created with: gclient setdep -r src/third_party/webrtc@b03422a7370c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I50838931cd0458da3fd569eee8fedea31e314009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083332Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#745963}
-
Gabriel Charette authored
This CL is a logical no-op. It manually covers the use cases the script (https://crbug.com/1026641#c22) didn't cover in https://chromium-review.googlesource.com/c/chromium/src/+/2026350. A few of the affected files were also migrated to content::GetUIThreadTaskRunner() whenever surrounding code consistency was at stake (but the bulk of that migration is staged to happen after this one so this wasn't a priority in this batch). Most files intentionally kept base/task/post_task.h as an include. It is still required because of a cyclical dependency during the migration preventing base/task/thread_pool.h from implicitly providing base/task/task_traits.h to its users (callers that explicitly store TaskTraits and include task_traits.h don't have this problem). The post_task.h include will be cleaned up in a later phase. This CL was uploaded by git cl split. TBR=fsamuel@chromium.org Bug: 1026641 Change-Id: Icd41d68bc3f719dbce3fc41bca489b3cb70d53a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079071Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#745962}
-
Side Yilmaz authored
incognito. This CL update the profile passing to TrackerFactory from PageInfoController. Currently, it is always regular profile, however it is not safe because of possible data leakage from incognito to regular profile. Therefore, this CL uses the profile (i.e., regular or off-the-record profile) received from webcontent in PageInfoController, then passes it to TrackerFactory. Bug: 1041781 Change-Id: Icbfa68762c0fede68de217621e054472fbdcfb61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080254Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#745961}
-
Finnur Thorarinsson authored
According to the documentation, this can occur if the underlying content provider returns null or crashes. Bug: 1056911, 656015 Change-Id: I8171b0aa0b4b44093ff95660e47fee2473619b20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083021 Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#745960}
-
Yuki Shiino authored
Implements V8DOMConfiguration::InstallConstants for context- dependent property installation. Bug: 839389 Change-Id: I3f67010e247ff4b1719cafec37b0865c9e05aa75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081729Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#745959}
-
Jose Lopes authored
Original: https://crrev.com/c/2056729 Revert: https://crrev.com/c/2078593 The original CL changes the media::IPCDataSource interface. This interface is also used in ChromeOS. However, the default tryjobs didn't catch this compilation failure (https://crbug.com/1056660). Affected builders: * chromeos-kevin-chrome * chromeos-betty-pi-arc-chrome * linux-chromeos-chrome * chromeos-eve-chrome * chromeos-betty-chrome * chromeos-arm-generic-cfi-thin-lto-chrome Original description: media: Migrate DataSource::ReadCB to once callback. This callback is used to signal completion of the read operation, therefore, it's a once callback: * https://cs.chromium.org/chromium/src/media/base/data_source.h?rcl=6e8610f8f31aa3bb8266660380a66c6c25b2e64a&l=27 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: Ideeef8a4c0c657deae9027a577fcbd9e05e69b8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078255Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Jose Lopes <jabolopes@google.com> Cr-Commit-Position: refs/heads/master@{#745958}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I9e702c484ca5169aed7a88111838df3a69cdd714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082749 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#745957}
-
Wez authored
Most of Chromium assumes the location of the Fuchsia SDK to be //third_party/fuchsia-sdk/sdk, so parameterizing the SDK location inside //build itself is not worthwhile. Replace use of |fuchsia_sdk| with hard-coded references to the SDK GN path, and remove the dependency on the SDK's config.gni. Bug: 1050703 Change-Id: I9e92e6feca74e761b820a9f54d2b934d71f4b532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072242 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#745956}
-
Rouslan Solomakhin authored
Patch #5: On desktop, pass currency to the CanMakePaymentEvent when minimal UI feature is enabled, so the updated WPTs can pass. Before this patch, the "currency" field of the CanMakePaymentEvent was never set. After this patch, the "currency" field of the CanMakePaymentEvent is set on desktop when the minimal UI feature is enabled, e.g., through chrome://flags/#enable-web-payments-minimal-ui flag, and the updated WPT passes on desktop when opened in a full browser. Bug: 1005076 Change-Id: Ib35ef8f808f57d7674a5712f12fbfe65918ce92a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078797Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#745955}
-
Fredrik Söderquist authored
Bug: 1056055 Change-Id: Id2f1c1af971c3b4e908562e9bec20b76779f0bd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080237Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#745954}
-
Shakti Sahu authored
Bug: 1057521 Change-Id: I6629503f4a105c1bc318f8b135065d82d1c2062c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082483Reviewed-by:
Hesen Zhang <hesen@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#745953}
-
Peter Kotwicz authored
This CL fixes crash due to bug in WebappDeferredStartupWithStorageHandler.java which incorrectly registers webapps with null key. TEST=WebappRegistryTest.testWebappNullId Change-Id: Iae1b8c85ccb6e12379f6719f1735a8b5b22ec161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082481Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#745952}
-
David Van Cleve authored
There's a bunch of boilerplate common to testing the three Trust Tokens operations of issuance, redemption, and signing, namely URLRequest creation (which involves constructing a TestURLRequestContext and a couple includes for RequestPriority and NETWORK_ANNOTATION_FOR_TESTS) and waiting for an asynchronous operation---TrustTokenRequestHelper::Begin---to conclude. This CL factors out the boilerplate into a fixture intended to be common to the three operations' tests. R=csharrison Bug: 1042962 Change-Id: Id513991f38a21c1cbb64924481f38f805fb88124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070824 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#745951}
-
Eric Seckler authored
Seems like creation fails occasionally on windows. Maybe related to sandbox issues? Adding a CHECK to see where the allocation happens. Bug: 1057614 Change-Id: Ic293907199cc3f48744cb0a4cb4d62f047c9fa1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083293 Commit-Queue: Eric Seckler <eseckler@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#745950}
-
Nico Weber authored
Bug: 1053958 Change-Id: Ia4f6c5022f68ec99bde8304a9cfc431f85326f33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082356 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#745949}
-