GitLab

BUG=None

Review-Url: https://codereview.chromium.org/2171703005
Cr-Commit-Position: refs/heads/master@{#407327}

BUG=630549
TBR=csharrison

Review-Url: https://codereview.chromium.org/2171303005
Cr-Commit-Position: refs/heads/master@{#407326}

BUG=597270
TEST=device test saw bug away

Review-Url: https://codereview.chromium.org/2167613003
Cr-Commit-Position: refs/heads/master@{#407325}

For malicious downloads, change the Dismiss button in DownloadItemView
to Discard button and cancel download when user clicks on it.

BUG=594596

Review-Url: https://codereview.chromium.org/2164723002
Cr-Commit-Position: refs/heads/master@{#407324}

BUG=627814

Review-Url: https://codereview.chromium.org/2174963002
Cr-Commit-Position: refs/heads/master@{#407323}

This should make it a little bit simpler for the somewhat common case
of a single column settings-box (20 / 60 existing two-line instances,
with more to come in internet settings).

BUG=589630
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2169193003
Cr-Commit-Position: refs/heads/master@{#407322}

Adding specific OWNERS file for Source/modules/imagecapture
(note that other potential Owners e.g. mlamouri@ are already
in Source/modules etc.)

Review-Url: https://codereview.chromium.org/2178703002
Cr-Commit-Position: refs/heads/master@{#407321}

BUG=630765

Review-Url: https://codereview.chromium.org/2169273005
Cr-Commit-Position: refs/heads/master@{#407320}

There was a bug in 23.2.1 where displayMetrics.orientation is wrong
after rotation, so we had a workaround. Now we don't need this
workaround anymore.

BUG=599048

Review-Url: https://codereview.chromium.org/2175943002
Cr-Commit-Position: refs/heads/master@{#407319}

Change log:
https://github.com/google/closure-compiler/compare/2f95290ea61dd4f1b5a3bf9d0fe3aa8e3244babf...c64418fd5518bb60aeb6a627d2bcc46a3d4be788
chrome_extensions.js: 754b5d249801020f5d71df9b7b576550f56972dc -> 462f6bc6508621ebeb7cf9a51fca7d069d2a7b85

R=dbeam@chromium.org
TBR=sergeyu

Review URL: https://codereview.chromium.org/2180623002 .

Cr-Commit-Position: refs/heads/master@{#407318}

Fix type in printing.gyp: printing/backend/cups_deleter{,s}.{h,cc}

Disable the cloud print connector like in GN in chrome.gyp

BUG=630791

TEST=Ran `GYP_CHROMIUM_NO_ACTION=0 gclient sync` and verified that chrome compiles

Review-Url: https://codereview.chromium.org/2170123003
Cr-Commit-Position: refs/heads/master@{#407317}

When a PageState update is received from the renderer process, it must
be for the current session history entry. This means that the sequence
numbers associated with the FrameNavigationEntry should match the ones
coming from the renderer process.
This CL is adding explicit check for this and a DumpWithoutCrashing to
help diagnose what cases can cause a mismatch.

BUG=628677

Review-Url: https://codereview.chromium.org/2172123004
Cr-Commit-Position: refs/heads/master@{#407316}

This is a follow-on CL to https://codereview.chromium.org/2130293003 which added the RaiseException call in memory_win.cc but missed memory.cc

BUG=614440

Review-Url: https://codereview.chromium.org/2173463002
Cr-Commit-Position: refs/heads/master@{#407315}

Revert of Fix the mobile emulator to use the correct device scale when disabled. (patchset #1 id:1 of https://codereview.chromium.org/2168313002/ )

Reason for revert:
Likely cause of webkit_tests unexpected_failures
inspector/screen-orientation-override.html

https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux/67873/layout-test-results/results.html

Failure appeared on many bots:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux/builds/67873
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/15157
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.10/builds/21002
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11/builds/7468
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10/builds/12746

and it seems related (change to devtools, failure in "inspector")

Original issue's description:
> Fix the mobile emulator to use the correct device scale when disabled.
>
> The mobile emulator was triggering a layout before it had reapplied the
> original viewport parameters when it was being disabled, which with
> use-zoom-for-dsf enabled was causing the wrong viewport size to be given
> to various components, like plugins and scrollbars.
>
> BUG=628501,628185
>
> Committed: https://crrev.com/d89c7a1578f9f16f6e1fa4375aab232b67fe0f9f
> Cr-Commit-Position: refs/heads/master@{#407294}

TBR=dgozman@chromium.org,alph@chromium.org,bsep@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=628501,628185

Review-Url: https://codereview.chromium.org/2174493004
Cr-Commit-Position: refs/heads/master@{#407314}

Remove DnsPrefetchingEnabled and DisableSpdy preferences.
DnsPrefetchingEnabled was not doing anything for about year now.  DisableSpdy
has not been doing anything since SPDY/3.1 support was removed recently.

Also remove class NetPrefObserver, which does not do anything besides
registering these two preferences.

This is a follow-up to https://crrev.com/2140733002.

BUG=624095, 526773, 334602

Review-Url: https://codereview.chromium.org/2172543003
Cr-Commit-Position: refs/heads/master@{#407313}

Since almost everything was converted to Create method, now
it can be moved to private section.

While doing this, CanonicalCookieTest::Constructor had to be
converted to Create method as well.

BUG=57061
TEST=net_unittests --gtest_filter=CanonicalCookieTest.Constructor
TEST=ios_net_unittests
R=mmenke@chromium.org

Review-Url: https://codereview.chromium.org/2159373002
Cr-Commit-Position: refs/heads/master@{#407312}

We know for sure the initial N release for N5X/N6P will have multisample
bugs. There is evidence as well that adreno 530 drivers in existing
devices like samsung s7 is affected as well. Expand the workaround to
cover these devices.

Planning on merging back to m52

BUG=612474
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2176703002
Cr-Commit-Position: refs/heads/master@{#407311}

Fallout from:
https://codereview.chromium.org/2177473004

TBR=aberent@chromium.org,pauljensen@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2175603004
Cr-Commit-Position: refs/heads/master@{#407310}

In GLES3.0 and WebGL2 spec, depth and stencil attachments should be the same image if both
attachmets are present, or the status of the framebuffer is GL_FRAMEBFUFER_UNSUPPORTED, but
in OpenGL 4.3 spec there is no such restriction.

This patch adds the validation in command_buffer and updates the related unittests to meet
this restriction.

BUG=629735

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2161383002
Cr-Commit-Position: refs/heads/master@{#407309}

This lifetime management for ClipboardImpl from service.cc to the window
server.

BUG=614037

Review-Url: https://codereview.chromium.org/2180593002
Cr-Commit-Position: refs/heads/master@{#407308}

Currently, the creation of any panner node causes the HRTF database to
be loaded.  However, the default panning model is "equalpower" (about
99.8%) so loading the database is a waste of time and memory.
(According to https://codereview.chromium.org/176683003/, it takes
30MB to hold the database.)

Thus, only load the HRTF database when the panning model is set to
HRTF.

Can't test this easily, but did verify with a debugger that the
database is only created when the panning model is set to HRTF and not
before.

BUG=592787
TEST=none

Review-Url: https://codereview.chromium.org/2171703003
Cr-Commit-Position: refs/heads/master@{#407307}

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/6e08f37..937acaa

BUG=
TEST=bots
TBR=kbr@chromium.org
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2173913003
Cr-Commit-Position: refs/heads/master@{#407306}

Document latency percentiles.

BUG=473337

Review-Url: https://codereview.chromium.org/2171833002
Cr-Commit-Position: refs/heads/master@{#407305}

Diff since last roll:
https://github.com/chromium/dom-distiller/compare/54d05ba208...6c16f14405

Picked up changes:
6c16f14 Warm up image cache for data URI used in tests
301ea1e Fix malformed test filter
9b606cb Remove files for drone.io
7e3b63e Fix schema.org article matching

BUG=619852

Review-Url: https://codereview.chromium.org/2173883004
Cr-Commit-Position: refs/heads/master@{#407304}

See the CL: https://codereview.chromium.org/2148723004

BUG=628459
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2175673003
Cr-Commit-Position: refs/heads/master@{#407303}

According to the C++ standard, the three arguments overload
of std::string::assign accepts an std::basic_string:
http://en.cppreference.com/w/cpp/string/basic_string/assign

Fixing the usage, where char* instead of std::string was passed.

This popped up after libc++ became more standard compliant,
and now it throws a compiler error.

BUG=630681

Review-Url: https://codereview.chromium.org/2177653004
Cr-Commit-Position: refs/heads/master@{#407302}

BUG=
TEST=webgl2_conformance
TBR=qiankun.miao@intel.com
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2177653005
Cr-Commit-Position: refs/heads/master@{#407301}

Whether the reference was local or not was disregarded, meaning that
any URL with a valid fragment part could potential result in a valid
clip - regardless of whether it was local or not. I.e foo.svg#bar would
reference an element with the id 'bar' in the local document.

Check if the URL reference resolver flagged the reference as being local,
and only pass a non-null fragment if it was.

BUG=629826

Review-Url: https://codereview.chromium.org/2174813003
Cr-Commit-Position: refs/heads/master@{#407300}

This implements the 'local url' handling per:

  https://drafts.csswg.org/css-values/#local-urls

which is also referenced from:

  https://svgwg.org/svg2-draft/linking.html#linkRefAttrs

Most of the logic is handled by a new helper class named
SVGURLReferenceResolver, which keeps state, resolves the URL
and extracts the fragment identifier as needed.

BUG=470608

Review-Url: https://codereview.chromium.org/2174833002
Cr-Commit-Position: refs/heads/master@{#407299}

This CL continues implementing ImageCapture:

- adds |iso|, |imageHeight| and |imageWidth| to PhotoCapabilities
 (each is a MediaSettingsRange).
- adds |imageHeight| and |imageWidth| to PhotoSettings.
- extends image_capture.mojom to support all the previous new
 fields
- wires Android's "old" and "new" Camera API to provide the
 capabilities and listen to the Settings (seems like the
 "old" does not reliably support ISO).
- extends the FakeVideoCaptureDeviceTest and the LayoutTests
 for these new features.

Note that setOptions() is not synchronous with takePhoto(),
so VideoCaptureDeviceAndroid holds on to the latest, if any,
requested capture resolution.

BUG=518807

Review-Url: https://codereview.chromium.org/2164473002
Cr-Commit-Position: refs/heads/master@{#407298}

https://chromium.googlesource.com/skia.git/+log/a1ce2163906e..0e72e9ee3b02

$ git log a1ce21639..0e72e9ee3 --date=short --no-merges --format='%ad %ae %s'
2016-07-22 egdaniel Remove asserts on scissor size in Vulkan
2016-07-22 mtklein Have SkRasterPipelineBlitter take over for 565 when it can.
2016-07-22 msarett Convert XYZ values from PNGs to D50
2016-07-22 herb In the current code, tiling and bilerp sampling are strongly tied together. They can be separated by taking advantage of observation that translating a sample point into filter points in the bilerp stage the filter points will be at most 0.5 outside the tile. This allows simplified repositioning for the various tiling modes; clamp and mirror use min and max while repeat has max -> 0 and 0-> max. This allows bilerp to simply treat the filter points that fall off the tile. This allows tiling and bilerp sampling to be totally separate.
2016-07-22 senorblanco Always init SkPathRef variables.

BUG=623195

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review-Url: https://codereview.chromium.org/2176873002
Cr-Commit-Position: refs/heads/master@{#407297}

BUG=603217
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2150763002
Cr-Commit-Position: refs/heads/master@{#407296}

Got reverted due to breaking MSVC build:
https://bugs.chromium.org/p/chromium/issues/detail?id=630335#c2
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/2630/steps/compile/logs/stdio

This CL:
- moves GTEST_FAIL() lines so that they fail at the end of the functions.
- adds static_cast<> to avoid x64 issues.

Original description ----------------------------------------------

H264 HW encode using MediaFoundation

This CL adds MediaFoundationVideoEncodeAccelerator which enables H264 encode support
using MediaFoundation on Windows 8.1+. Also, it includes a refactor of common
MediaFoundation classes under mf_helpers.*.

Note that, this is the first CL and H264 codec is still behind a flag.

Design Doc(with perf measurements): http://goo.gl/UCnwyA

BUG=590060
TEST= Tested AppRTC loopback with Chrome flag "--enable-webrtc-hw-h264-encoding" and
"--enable-mf-h264-encoding" on https://apprtc.appspot.com/?debug=loopback&vsc=h264
Also, added WIN specific sections at vea_unittests.

TBR=ananta@chromium.org,avi@chromium.org,grt@chromium.org,sandersd@chromium.org,wuchengli@chromium.org

Review-Url: https://codereview.chromium.org/2173153002
Cr-Commit-Position: refs/heads/master@{#407295}

The mobile emulator was triggering a layout before it had reapplied the
original viewport parameters when it was being disabled, which with
use-zoom-for-dsf enabled was causing the wrong viewport size to be given
to various components, like plugins and scrollbars.

BUG=628501,628185

Review-Url: https://codereview.chromium.org/2168313002
Cr-Commit-Position: refs/heads/master@{#407294}

BUG=630355
NOTRY=true

Review-Url: https://codereview.chromium.org/2175903002
Cr-Commit-Position: refs/heads/master@{#407293}

Add dictionaries and seed corpora from AFL.
All of the additions were shown to significantly help afl-fuzz fuzz the target fuzzers.

BUG=611337

Review-Url: https://codereview.chromium.org/2168263005
Cr-Commit-Position: refs/heads/master@{#407292}

This CL nukes ContentBrowserClient::CreateGeolocationDelegate()
and their overrides, and transfers each embedder's callsite to the
appropriate correspondent BrowserMainParts. These embedders are
namely: android_webview,  blimp, cast, chrome and content_shell.

Continuation of https://crrev.com/2127973002/.

BUG=612334

Review-Url: https://codereview.chromium.org/2174613002
Cr-Commit-Position: refs/heads/master@{#407291}

This CL solves a problem with the side nav menu drawer staying open when
using the back/forward buttons. The drawer now closes when navigating
forward or back.

BUG=623903
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2170223002
Cr-Commit-Position: refs/heads/master@{#407290}

* Replaces the previous "Select shipping address" or "Select shipping option"
  prompts with gigantic [SELECT] and [ADD] buttons on the right of each
  incomplete section.

* Caches a copy of the SectionInformation in the relevant PaymentRequestSection
  instances so that we can determine if we need to prompt the user to SELECT
  or ADD new PaymentOptions.

* Buttons are enabled from top to bottom, with only one button enabled at a
  time.  This encourages users to move downward while filling out the form.
  When a button is visible for a section, the only way to interact with the
  section is via the button (no more clicking on incomplete sections to expand
  them).

* The shipping summary section, which combines both the shipping address and
  shipping option fields, can now display a button that shows either the
  button for the incomplete shipping address section or the incomplete shipping
  option section (prioritized in taht order).

* Get rid of and generalizes a bunch of unneeded strings.

* Because the logic is so complicated now, we consolidate most layout updates
  and view visibility checks to updateControlLayout().

* Updates the PaymentRequestDynamicShippingSingleAddressTest to account for the
  lack of summary text for incomplete sections.

* Edits the "select shipping address" string to add "and requirements" to the end.

Videos:
https://drive.google.com/open?id=0B7c8ZkXVwskDZDZWUkhDXzdvLUE
https://drive.google.com/open?id=0B7c8ZkXVwskDRm53UUhHUHZmeW8

BUG=603635

Review-Url: https://codereview.chromium.org/2170693002
Cr-Commit-Position: refs/heads/master@{#407289}

This class is mostly a stub but not quite. And it's also a stub of
LayerTreeHostSingleThreadClient. Break it up into two real stubs
of those interfaces. And it inherits from StubLayerTreeHostClient
and implements just what it needs to be the client for FakeLayerTreeHost.

Now stuff that isn't using FakeLayerTreeHost doesn't need to use
FakeLayerTreeHostClient, they can use the StubLayerTreeHostClient.

R=enne,dtrainor
TBR=miguelg
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2174653002
Cr-Commit-Position: refs/heads/master@{#407288}