- 17 Aug, 2020 40 commits
-
-
Ian Wells authored
This change makes it possible to stop capabilities from being added to feed requests by setting "enable_CAPABILITY_NAME = false" to InterestFeedV2's Finch config. Note that "enable_... = true" has no effect. Bug: 1044139 Change-Id: I5a5122affa355d4d30d15b9004554c64b7777d43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357449 Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#798676}
-
sczs authored
Adds specificProductData dictionary to UserFeedbackProvider, this is needed in order to send card data as part of sending user feedback. This is transparent and its show in the UI along the other product specific data the user is sending. Screenshot: https://drive.google.com/file/d/1Js0zW7-tNZwAPtfZRvI24OwuUSeab-8N/view?usp=sharing Bug: 1085419 Change-Id: I716345b61f87c78c7ebbfc7ce07479b84f93bde5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358482Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#798675}
-
Philip Jägenstedt authored
There were harness errors in Edge, Firefox and Safari: https://wpt.fyi/results/html/canvas/element/manual/wide-gamut-canvas/canvas-createImageBitmap-e_srgb.html?run_id=657990001&run_id=659880001&run_id=633480001&run_id=663850001 The cause for that was the convertToBlob call not correctly wrapped in a step in testCreateImageBitmapFromColorManagedBlob. That was only the first of multiple errors fixed here: - not handling image or video decode failures, causing timeouts - failures at the end of testCreateImageBitmapFromColorManagedBlob would not have failed the test because promise rejections were not handled - failing in cryptic ways if ImageData dataUnion isn't supported These issues were fixed while also modernizing the tests to use more modern APIs where available, like img.decode() and fetch(). Change-Id: Ia8d0086a2d216dd291c9429460f8a79f8f4fd1c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359991Reviewed-by:
Wan-Teh Chang <wtc@google.com> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#798674}
-
Jose Dapena Paz authored
This fixes this build error: ./../components/payments/core/android_app_description.h:51:20: error: ‘unique_ptr’ is not a member of ‘std’ 51 | std::vector<std::unique_ptr<AndroidActivityDescription>> activities; | ^~~~~~~~~~ Bug: 957519 Change-Id: I63cd3c3caa743c5b8a8ec0d91706d8655a1bbea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360080Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#798673}
-
Jose Dapena Paz authored
Fix the error found compiling with libstdc++: ../../chrome/browser/policy/messaging_layer/public/report_client.cc:174:38: required from here /usr/include/c++/9/bits/stl_vector.h:398:66: error: static assertion failed: std::vector must have a non-const, non-volatile value_type Bug: 957519 Change-Id: I8b8a306d841636882c7563edf9cdfc58464bc545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358737Reviewed-by:
Zach Trudo <zatrudo@google.com> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#798672}
-
Yunke Zhou authored
Bug: 1101318 Change-Id: I47864f53018fb7b6ca1fd675953247a6dadc1f7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352824Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#798671}
-
Dan Harrington authored
Bug: 1116919 Change-Id: I96bd5bd3e69433639550d997847d6a2bf0540744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360231 Auto-Submit: Dan H <harringtond@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#798670}
-
Xianzhu Wang authored
This reverts commit c5c632e5. Reason for revert: Revert the temporary CL after several canary builds. Original change's description: > Temporarily disable composited scrolling optimization for css-clip/clip-path > > This is to evaluate the performance improvement of the optimization in > 1 or 2 canary builds. Will revert after that. > > This disables the optimization for composited scrolling added in > crrev.com/774232. > > Bug 1113269 > > Change-Id: I2cf85fd5e550c1fef7d29f76b90e5d1b7219d579 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353066 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797532} TBR=wangxianzhu@chromium.org,pdr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: If867168bea1f3adbe2b5e23d80b19377763db027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359367Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#798669}
-
Scott Violet authored
FaviconBackend was using a mix of delegate and return values to convey results. This was mildly confusing. This patch converts to a return value. The one remaining delegate function is for redirects, which makes sense as a delegate function. BUG=1076463 TEST=covered by tests Change-Id: I9bc84e9afcb02a417b62180cae5fe5a89a09ef28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357851 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#798668}
-
Orin Jaworski authored
This CL adds concept matching data for several languages, making use of new generation capabilities in pedal_processor. Bug: 893183 Change-Id: I8fca6123ff3bdf6fe5e7ec06e759f76414c88e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358430 Auto-Submit: Orin Jaworski <orinj@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#798667}
-
Rohit Rao authored
For now, all iOS policies are marked as future_on, so we should include them in appconfig.xml to make testing policy support easier. Once policy support is launched to stable, we can revisit and omit future_on policies. Bug: 1115986 Change-Id: I057789f4eb5c558610abcb431ba9ee2a883a45b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352510Reviewed-by:
Yann Dago <ydago@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#798666}
-
Thomas Lukaszewicz authored
This CL introduces a GetCornerRadius() helper to the DialogDelegate and a GetClientCornerRadii() helper to the BubbleFrameView. This will help when implementing the rounded corners fast path for MD rounded corners in a follow-up CL. Bug: 822075 Change-Id: Ia90c56b0ba6d58d682bc9c14bae688c247d612d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359022 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#798665}
-
kylechar authored
The same transform operation is done twice in a row on identical inputs, skip doing it twice and reuse result. Bug: 1110016 Change-Id: I909c9580bb79b091f5f17b37fcd03d626124ef93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354898Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#798664}
-
Viktor Semeniuk authored
This change adds proper handling of android credentials on Password Details screen. When android credential is compromised Change Password button is hidden. Bug: 1075494 Change-Id: Ib5915988c5ccd5b0ad4e3b7b4b8457dfd5cf8631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352881Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#798663}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/29271d0eece4..064bbf297d37 2020-08-17 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Headers from 6eaf979e7366 to 99638d8d7fc6 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: Ie33ca86f28f2e861f4893dbb5950aec316e45b48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360211Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798662}
-
anthonyvd authored
This reverts commit 8444271f. Reason for revert: Causing build failures, see https://ci.chromium.org/p/chromium/builders/ci/android-archive-rel/14156? Original change's description: > Adds Desugar's jdk_libs_configuration to the build > > This contains information required for new Java 8 desugaring features. > > Bug: 1056751 > Change-Id: I87e15cd74f6a4a714fae748ed61172c000eda67c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354518 > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Peter Wen <wnwen@chromium.org> > Commit-Queue: Justin DeWitt <dewittj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798651} TBR=yfriedman@chromium.org,dewittj@chromium.org,wnwen@chromium.org,agrieve@chromium.org,echristo@google.com Change-Id: I21ea1a52845d3134339aa426e5699c452ac0e538 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1056751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358956Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#798661}
-
Bo Liu authored
Add a DumpWithoutCrashing to the sender side of URLLoaderFactory.CreateLoaderAndStart. Bug: 1028189 Change-Id: I05fcf83ebe3248b4b67c60d0ecb5c176173ad976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358478 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#798660}
-
Jonathan Mengedoht authored
Bug: 927473 Change-Id: Icf7010f41392f761117915dac92f4f390b41f2a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335289 Commit-Queue: Jonathan Mengedoht <mengedoht@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#798659}
-
Justin Miron authored
This adds use counters in both UKM and UMA for 3p cookie reads and writes. The third party metrics observer records the use counters with the other third party storage access types. These two metrics will be used to understand how third party cookie usage is on sites compared to other third party storage mechanisms and give a more complete picture of how third party storage is used across sites. Bug=1059915 Change-Id: I2c1b645c7db7dcc6a1e44f6eab1d33110c2c5506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342578 Commit-Queue: Justin Miron <justinmiron@google.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#798658}
-
Omer Katz authored
The issue below correlates to element_under_pointer_.at returning a nullptr. All calls to element_under_pointer_.at but one are prefaced with an if(element_under_pointer_.Contains(...)) check. That one call is prefaced with a DCHECK. Most likely culprit is that there is a real-world case in which the DCHECK doesn't hold and is not covered by our tests. Making the DCHECK a CHECK should confirm that. We'd still get the same number of crashes overall, but with a different stacktrace. Bug: 1114579 Change-Id: Ie28c971ed2114cf4a780f9eb5366c60d7669315c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359081Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#798657}
-
Peter Kasting authored
Mostly, converts typedef -> using per style guide. Also uses CallbackList::CallbackType more (and more systematically), and some other misc. cleanup like using stl_util.h, explicitly declaring types more, etc. Bug: none Change-Id: I63241972f5bede0c1cdb85ade8a0ba1155979cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354621 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Orin Jaworski <orinj@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#798656}
-
Robert Ma authored
Suspected root cause: https://crrev.com/c/1560083 Bug: 1116951 Change-Id: Ifd285549d2a36bad84bcc6073f65b7f659eb06c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359571 Commit-Queue: Robert Ma <robertma@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#798655}
-
Etienne Pierre-doray authored
Forwarding to base:: implementation: - JobHandle::IsCompleted() - JobDelegate::GetTaskId() - worker_count passed as argument to GetMaxConcurrency(). Bug: 1114823 Change-Id: I9348a6171c19a39081205a33fbb5e19179a4601a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354163Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#798654}
-
Ella Ge authored
This CL adds the TWA quality enforcement for the launching URL failing the digital assert link verification. Bug: 1109609 Change-Id: I459015c0a70d4c00a5c3ec4f6f4506ff914c0552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339228Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#798653}
-
Xi Han authored
Bug: 1092642 Change-Id: I1c96d5bfb0d886580c5498d7c8d1c4149ff148f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351285 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#798652}
-
Justin DeWitt authored
This contains information required for new Java 8 desugaring features. Bug: 1056751 Change-Id: I87e15cd74f6a4a714fae748ed61172c000eda67c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354518Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#798651}
-
Olesia Marukhno authored
Pedal button labels was updated when I added accessibility string for them. Updating accessibility strings to match new button labels. Bug: 1104264 Change-Id: I2381d0184dcee4a79d2e99c2a8dda8b6c2555ffa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359079Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Cr-Commit-Position: refs/heads/master@{#798650}
-
Himanshu Jaju authored
Integrates PairedKeyVerificationRunner in NearbyServiceImpl to verify remote device before receiving introduction and starting the transfer flow. Bug: 1085068 Change-Id: I73d42d9f85f3254007cdf3fdf46c6f5e05a48630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352799Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#798649}
-
Javier Ernesto Flores Robles authored
Bug: 1113120 Change-Id: I7ab59d5a262dedbc36d90e8d4f3265b269c852de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346337 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#798648}
-
Weilun Shi authored
Remove BUILD dependencies for merge_xml action and list all xmls that need to be merged in merge_xml.py instead because listing them in the sources is too verbose as we split up smaller xmls. Bug: 1116096 Change-Id: I1ba1e09feece3442a673d4ba41868f36e1135298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359231 Auto-Submit: Weilun Shi <sweilun@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#798647}
-
Chris Sharp authored
"can only" was repeated twice. Change-Id: I9acf582750dc2f01d700f2c9bacb26c95376df4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358584Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#798646}
-
kylechar authored
There is a recurring issue where bugs in browser process code introduce deserialization errors on the main viz browser-to-GPU process message pipe. The message pipe is closed and the GPU process crashes trying to reinitialize the viz thread. Without a way to differentiate message pipe closure due to a deserialization error vs the other side closing it, the crash only happens when the browser tries to reinitialize the viz thread after what it thinks is a GPU crash. There is a very little information available in these crash reports, the message pipe is shared by multiple interfaces and figuring out what IPC message the error occurred in is a guessing game. There is a global error handler that triggers for any mojo deserialization errors which includes a string containing the interface name and a message identifier. This CL adds a handler which stores the error string. If the GPU process crashes due to reinitializing the viz thread within 5 seconds after the handler fired, it populates a crash key with that error message. While it's not guaranteed the last deserialization error was what caused the viz thread to get reinitialized, deserialization errors are infrequent enough it shouldn't be an issue. Bug: 1075495 Change-Id: I3a762fd5e9d50c0c1c301b3179f08ce892ff4912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356546 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#798645}
-
Rushan Suleymanov authored
After current CL SharingMessage data type will stop on any persistent auth error from the server. Previously, it would only stop on one specific type of error (web signout). Bug: 1097054 Change-Id: I917b20343b457e513004e5ad112bf6d42d0f42dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352743Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#798644}
-
Gayane Petrosyan authored
This is a reland of d43884e1 Fix memory leak issue by cleaning selection_range member in TextFragmentSelectorGenerator on DocumentDetached. Reverted version is in patchset 1. Original change's description: > [SH-Blink] Create TextFragmentSelectorGenerator with page. > > Create TextFragmentSelectorGenerator with page and set selection > information when context menu is shown. > This is done so that Java code can just call the GenerateSelector > function without any arguments and generation can happen for the latest > selected text. > > Follow-up CL > https://chromium-review.googlesource.com/c/chromium/src/+/2341662 > will connect to browser-side component. > > Bug: 1102382 > Change-Id: I5574f5b40e5a74bef56698e2de5a9b1fea17e0d0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340734 > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Commit-Queue: Gayane Petrosyan <gayane@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797256} Bug: 1102382 Change-Id: If05b8e643627f4851dced45ce02cd78b7fa87fde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354304Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#798643}
-
Naomi Musgrave authored
chrome/services/sharing/* - Introduced StopAllEndpoints to clean up all connections to remote endpoints chrome/browser/nearby_sharing/nearby_connections_manager* - Browser side usage of StopAllEndpoints. NearbyConnectionsManager uses StopAllEndpoints to clean up when shutdown is requested, or when the nearby process is stopped. Bug: 1076008 Change-Id: Ie5cc7dedf2accad91774217be87d9e5218116594 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346673 Auto-Submit: Naomi Musgrave <nmusgrave@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#798642}
-
Alice Wang authored
This CL adds a render test for the sign-in in progress screen in the web sign-in bottom sheet. Bug: 1090356 Change-Id: Ice77509c68b54c1090351ed7962850f98bdbdb50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356025Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#798641}
-
Alice Wang authored
Change-Id: I26f79c147be2dcde083ac4f5be88267ccd2e236a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359135Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#798640}
-
Gyuyoung Kim authored
This CL is to fix the regressions caused by r785154. r785154 has been causing two regressions. One is the context menu is opened at the wrong place once right click is used inside emulation window. The other one is a crash happens when performing a right click on 'Color selector' overlay in emulation view. The first regression caused by r785154 missed clearing |host_context_menu_location_| unlike the original behavior. So, it made RenderFrameImpl::ShowContextMenu() calculate the position of the context menu with |host_context_menu_location| instead of the current window position unlike the original behavior. And, the second regresion was caused by RenderWidgetHostImpl::ShowContextMenuAtPoint calls ShowContextMenu() through the Mojo message without checking if |blink_frame_widget_| is bound. This CL fixes those regressions. Bug: 1093960, 1113088, 1115440 Change-Id: I94c3c385caeacda5561d30e6fd7ced6e86d69201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354128Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#798639}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c4245f475be7..866d2894ebd1 2020-08-17 djsollen@google.com Add android:exported values to all SkQP activities. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: stani@google.com Test: Test: successful install on device with AOSP build Change-Id: If67de613d99804be7f30f622b145844b07759b4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358408Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798638}
-
Rainhard Findling authored
Bug: 1087263 Change-Id: I2125c7072fcc9295749ff04f514e1b13d8754143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355905Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#798637}
-