- 03 Dec, 2019 40 commits
-
-
Kuo Jen Wei authored
The animation may not be properly ended if it's cancelled by hide of target element during playing. This CL caught the cancelled events and clean up the animate class. Bug: 1028678 Test: Bug is resolved. Change-Id: Id11e04da174783c5be5e977247c593815c29f284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939140 Commit-Queue: Kuo Jen Wei <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#720837}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I229f9d7feb0c8e88482f29a92ceb328a17cdfc3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948207Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720836}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/dca8df948ef5..69272c40ae6e git log dca8df948ef5..69272c40ae6e --date=short --first-parent --format='%ad %ae %s' 2019-12-03 fancl@chromium.org Reland "Remove api_key requirement for /subscriptions/match" Created with: gclient setdep -r src/third_party/catapult@69272c40ae6e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:953181 Tbr: nuskos@google.com Change-Id: I17cde80da09ca915d2a1a9b3a4514ce70570217a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948213Reviewed-by:
-
Virender Singh authored
This change fixes the incorrect scale that we apply to root transform in PdfAccessibilityTree. At present, we remove the dpi factor from root transform. This results in only zoom factor being applied when calculating bounds. For Windows, device scaling is also handled by application. This is not the case with Mac. As a result, conditional scale calculation, based on OS, should be done. Fix uses content::IsUseZoomForDSFEnabled() to find out the correct scale that needs to be applied. Bug: 1007169 Change-Id: I4cda488b8acf3823178b4ff68503b081e12aeaa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820697 Commit-Queue: Virender Singh <virens@microsoft.com> Reviewed-by:
Ian Prest <iapres@microsoft.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#720834}
-
Carlos Caballero authored
MessageLoop is going away soon. This CL was uploaded by git cl split. R=samans@chromium.org Bug: 891670 Change-Id: I15740af265a11a121228c63c6cca39541fcc6ed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946228 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#720833}
-
siyua authored
Disable the cancel button in the Webauthn verify pending dialog when the system OS authentication dialog is shown. At this moment, if user cancel the OS dialog, the verify pending dialog will also go away. After user interacts with the system OS dialog, the OS dialog will go away and the cancel button will be enabled again for users to cancel the flow if they want. Bug: 991037 Change-Id: I8760690e377e3d294832dc5278d177eb3017dc65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935493 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#720832}
-
Yuki Shiino authored
Implements support of optional arguments. Bug: 839389 Change-Id: I1e35774a52fc18786eb712b2dcc6d9456faea5d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942895Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#720831}
-
Alan Cutter authored
With the change to split WebApplicationInfo::icons into icon_infos and icon_bitmaps [1] we don't need to preserve URLs when downloading icons. This means we can simplfy the BitmapAndSource struct into just SkBitmap. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1928600/10 Bug: 926083 Change-Id: I9c36d1bf1e726aeb6d1f79f1bdab005b8032265a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936441 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#720830}
-
Archie Pusaka authored
When a user which primary account is Google corp account opts in for BT verbose logging, a D-Bus command will be sent upon sign in to enable verbose logging level 1. Logging will be stopped upon sign out or device shutdown. Bug: 1004572, 734152 Change-Id: I00b5d56d41d7df3669e1a7c73c86d4fb67226959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824721Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Archie Pusaka <apusaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#720829}
-
Tom Sepez authored
Although these are in XFA-callbacks, which we do not ship, call out other places where we'd not want to provide full support. - Remove some partial code from these functions. Change-Id: I0de38c161982e1830a9c9b51f1a0c06fb6f7e3c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947805Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#720828}
-
Kunihiko Sakamoto authored
This is a preparation change for crbug.com/1029406. Bug: 1029406 Change-Id: I361ae579f1daddc3bc82ca97ada35c87286e96ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946055Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#720827}
-
Simon Que authored
chromiumos_builder() in both ci.star and try.star use Goma RBE backend by default. Bug: 1025325 Change-Id: I5997959592a1c9d4fb629541cc603ba22e8c1a60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948008Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#720826}
-
Scott Violet authored
This patch separates out creation of WebLayer to a WebLayerFactory and has the client supply the version of chrome the client was compiled with. WebLayerFactory also offers functions to return the version of the implementation. This does not change the existing versioning checks, rather adds the real chrome version. The goal is we will eventually use the real chrome version and not the one of version we added. BUG=1025615 TEST=all tests implicitly trigger the new code paths Change-Id: Ie6330a57fd9f205504758c9cde9707537cb643f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935037 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#720825}
-
Hiroshi Ichikawa authored
This test tests a use case which is not really supported by CRWWebViewScrollViewProxy. So I believe this should rather be deleted. CRWWebViewScrollViewProxy doesn't really support setting up multiple proxies for a single UIScrollView. If you try it with a real UIScrollView, it hits an assertion here: https://cs.chromium.org/chromium/src/ios/web/web_state/ui/crw_web_view_scroll_view_proxy.mm?l=73&rcl=c8f602e2f2dae5bdbde111f556474f3373c23a3d This test currently passes just because it uses a mock UIScrollView. Change-Id: Ib85ec49db033cd894f84d53a5053d1a006b1ff59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939139 Auto-Submit: Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#720824}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bfd5c311ca87..4e899ffa92b9 Created with: gclient setdep -r src-internal@4e899ffa92b9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I09d63f13b9f423e453fbdd530b0baaaab73e41d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948039Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720823}
-
Alan Cutter authored
This feature has been enabled since M76, the flag can now be removed. Bug: 907351 Change-Id: Ia8cfc6bfd5f49ff934aa04b81dd8de6a6124f628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918911 Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#720822}
-
Julie Jeongeun Kim authored
This CL cleans up old Mojo types for mojom::DebugLogsChangeHandler using PendingRemote and ReceiverSet instead of InterfacePtr and BindingSet. Bug: 955171 Change-Id: Iffb8cb730857f8b5ea417300f0e8b9235c88ed97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939070Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#720821}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/42f2c4bd8176..dca8df948ef5 git log 42f2c4bd8176..dca8df948ef5 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 dberris@chromium.org Pinpoint: Blame only top 2 culprits Created with: gclient setdep -r src/third_party/catapult@dca8df948ef5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1021523 Tbr: nuskos@google.com Change-Id: Ie19e8ed34ccdba044a006abdcaee03704a9e90f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948033Reviewed-by:
-
Erik Jensen authored
This uses various Windows APIs to try to glean information about the current layout. Unfortunately, there appears to be no way to get some of the needed information in a clean fashion through these APIs, so the implementation uses various guesses and hacks to try to infer it. In the future, I'd like to look into reading the layout directly from the layout files, which contain mapping tables that provide all of the needed information in a known format. This currently runs in the network process. That means it can't monitor active window changes and thus never sends an updated layout after the initial connection. A follow up CL will run the monitor in the desktop process and communicate the result back via IPC. Bug: 1026029 Change-Id: Iaba9c0bb0ef2c60fac249a9af392f9434b9c5f93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918356 Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#720819}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bf6b0b251ec0..49e564e5e02c git log bf6b0b251ec0..49e564e5e02c --date=short --first-parent --format='%ad %ae %s' 2019-12-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-12-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@49e564e5e02c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bsalomon@google.com Change-Id: I2ea936a04289414c768cb1f3449caff2538627b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948032Reviewed-by:
-
siyua authored
The verify pending dialog will need to (UX decision) reuse the current webauthn dialog UX format. Since they are both using this format, and are for the same flow. It makes sense to merge the two sets of MVCs and show different content based on different dialog state This is a follow up of CL crrev.com/c/1925761 Bug: 991037 Change-Id: I4837e02adeef471d6a775587af0ab921646cdaf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931857 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ba8d15b7d9af..6aa0bcb82820 git log ba8d15b7d9af..6aa0bcb82820 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@6aa0bcb82820 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ia3dfe254f8e246a9a5ffafcf3d903d08ad055f7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948031Reviewed-by:
-
Makoto Shimazu authored
It was flaky on TSan bot. TBR=zmo@chromium.org No-Try: true Bug: 1030130 Change-Id: I3dbbe2f8e3559609bc1bac8e6504417c2a2c1b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947866Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#720815}
-
Austin Tankiang authored
This filesystem type was used by the legacy drive sync client that has now been replaced by DriveFS. Also replace all usages in tests of this filesystem type with an equivalent type. Bug: 1003238 Change-Id: I5f99a3eaca6887423cb1ec073f5f9b22e83b694b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946050Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#720814}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<SVGForeignObjectElement> as new downcast helper 2. Use IsA<SVGForeignObjectElement>(element) in place of IsSVGForeignObjectElement(element) Bug: 891908 Change-Id: I6ad9fe6116758ba05ea8e7339b71405fc1f9348b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936585 Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Reviewed-by:Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#720813}
-
Gil Dekel authored
Currently, the VA-API image decoder unittests for JPEG and WebPs are piggybacking on mjpeg_decode_accelerator_unittest.cc. This CL removes these tests from mjpeg_decode_accelerator_unittest's binary. Note that we do not lose the VA-API image decoder unittests coverage since they now have their own binary [1][2] [1] https://crrev.com/c/1881631 [2] https://crrev.com/c/1913488 Bug: 986074 Test: Existing test runs and passes locally on an Eve. Change-Id: I76e4308cb73b6cf89a468d003c0abe263336a005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946708Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Gil Dekel <gildekel@chromium.org> Cr-Commit-Position: refs/heads/master@{#720812}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Ia6cf33a7a4397502f2ea2942e800d09f887b66a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948223Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720811}
-
Miyoung Shin authored
This CL converts MediaMetricsProvider mojom interface clients in content to use BrowserInterfaceBroker. Bug: 936482 Change-Id: I767ee109dcc6a01059e26736b1c739acad321d4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941464 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#720810}
-
Alan Cutter authored
WebApplicationsInfo stores its icons' size, URL and bitmap data in one struct. This makes it impossible to check whether a site's icon manifest data has changed without undergoing the entire icon downloading process. This CL splits the struct up into two: - Icon URL + size - Icon size + bitmap data This allows us to compare the first with the latest site manifest to check for updates. This wasn't possible previously as we would only store icons that successfully loaded and would also throw away the original specified sizes. The majority of the changes in this CL derive from the change made to WebApplicationInfo splitting "icons" into "icon_infos" and "icon_bitmaps" e.g. UpdateWebAppIconsWithoutChangingLinks() is being removed because it is redundant now that icon_infos is an input to icon downloading and icon_bitmaps is an output, by retaining the icon_infos input separately no input URLs will be changed. Design doc: https://docs.google.com/document/d/1Ryd35qXIOpRHNLUy0Mz0LRILzSdZcRdiJBHNvrNPjeI/edit Bug: 926083 Change-Id: I5e52d5e05644de8a15d61dbfb70eca417c1dcfb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928600 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Cr-Commit-Position: refs/heads/master@{#720809}
-
David Tseng authored
Mojo supports enum value assignments, so there's no point in keeping around every combination of MarkerType. TBR=dcheng@chromium.org Test: accessibility_unittests Change-Id: I4e0602eb92a933f18a8b837b8bfc54fedfc9eb62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943052 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#720808}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0724e61c3c58..bfd5c311ca87 Created with: gclient setdep -r src-internal@bfd5c311ca87 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1027022 Tbr: jbudorick@google.com Change-Id: I28462b125e9850857205cec80903022f276dd3d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947820Reviewed-by:
-
Kent Tamura authored
This CL changes: - all timestamp arguments of File, - the return value of LastModifiedMS(), and - the type of snapshot_modification_time_ms_ from double to base::Optional<base::Time>. This renames - LastModifiedMS() to LastModifiedTime() and - snapshot_modification_time_ms_ to snapshot_modification_time_ and removes - File::LastModifiedDate(), - InvalidFileTime() in file_metadata.h, - IsValidFileTime() in file_metadata.h, - ToJsTimeOrNaN() in file_metadata.h, and - JsTimeToOptionalTime() in file_metadata.h. This CL fixes File.lastModified behavior for timestamps later than 275760-09-13T00:00Z by removing unnecessary double-base:Time conversions. * v8_script_value_serializer_test.cc Do not wrap test cases with |namespace { ... }| because FRIEND_TEST_ALL_PREFIXES() doesn't work with it. Change-Id: I630d869641ea033b68534f17178e78b8fc2d1953 Bug: 988343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942671 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#720806}
-
chrome://media-appTrent Apted authored
This is a reland of f8263a71 The earlier patch failed on the chromeos MSan bot only because that builder uses include_js_tests = false, so was missing a transitive dep on //chromeos/components/media_app_ui:browser_test_support . Original change's description: > Hook up chrome://media-app as a file handler for image/* > > Adds a consumer for window.launchQueue in chrome://media-app that > opens the file and sends it to the existing loadBlob(), which sends > the blob to the unprivileged guest app to load. > > Adds an integration test that ensures launch params passed via the > AppService OpenApplication() will correctly open an image in the media > app. > > SystemWebAppManagerBrowserTest is refactored away from extensions slightly. > Rather than use extensions::browsertest_util::LaunchAppBrowser(), it uses > LaunchService::OpenApplication(AppLaunchParams) directly. Mostly this just > avoids having to fetch the Extension* only to use extension->id() to get the > app_id back again. > > Bug: 996088, 1023742 > Change-Id: I85624e93618d82ccce1c80d04d21d81303579a99 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913282 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Commit-Queue: Trent Apted <tapted@chromium.org> > Cr-Commit-Position: refs/heads/master@{#720681} TBR=ortuno@chromium.org Bug: 996088, 1023742 Fixed: 1030105 Change-Id: Ifb0c66efccf0411c8bd9766e17ac61676a6a4ea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947604 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#720805}
-
Mitsuru Oshima authored
Bug: 141898654 Change-Id: If41d13054daf681f1502c3c0c2d35777ba03b261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921207 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#720804}
-
Leon Han authored
Use the following union type instead of 'any' to define NDEFRecordInit#data. " typedef (DOMString or BufferSource or NDEFMessageInit) NDEFRecordDataSource " The spec change: https://github.com/w3c/web-nfc/pull/454 BUG=520391 Change-Id: Ic917be001d5e3502caeea29ff4a3401ff7197298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941083Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#720803}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ca84a4265921..42f2c4bd8176 git log ca84a4265921..42f2c4bd8176 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 fancl@chromium.org Change the docker script to get the user using gcloud 2019-12-03 abennetts@google.com Add gitignore of *_pb2.py to dashboard/dashboard. Created with: gclient setdep -r src/third_party/catapult@42f2c4bd8176 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029242 Tbr: nuskos@google.com Change-Id: I968ed4b928d7ed6b978cf85d628b0ca448cf51de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947819Reviewed-by:
-
Julie Jeongeun Kim authored
This CL cleans up old Mojo types for media::mojom::RemotingDataStreamSender from RemotingSenderTest and CastRemotingSenderTest using Remote. Bug: 955171 Change-Id: I87a63709a4063266897cb8be585eb6ee4e8d89a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941537Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8ebac1732c99..bf6b0b251ec0 git log 8ebac1732c99..bf6b0b251ec0 --date=short --first-parent --format='%ad %ae %s' 2019-12-02 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-12-02 rosasco@google.com skqp CIPD upload infra for Fuchsia Created with: gclient setdep -r src/third_party/skia@bf6b0b251ec0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bsalomon@google.com Change-Id: I4dcf64d9df859f78db70c5572a3cfbc0ae064e83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947818Reviewed-by:
-
Piotr Pawliczek authored
The epson-inkjet-printer-escpr package was upgraded from version 1.6.23 to 1.7.6. BUG=chromium:1026359 TEST=none Change-Id: I5023723bcc49aeb1f0f2e7b21f8c80d8bd093316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928321 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
-
David Bokan authored
This was previously measured explicitly until https://crrev.com/1226828 merged that metric into the GestureScrollingThreadStatus histogram. At the time, it was expected this was equivalent. However, because multiple main thread reasons can be recorded for a single scroll, there is no way to tell what percentage of scrolls are handled on either thread. This CL adds back this simple metric that measures how many gesture scrolls are handled: - entirely on the compositor thread - on the compositor thread but must block on the main thread for event handlers - on the main thread. Bug: 1025789 Change-Id: Iffd1c67ef9841d6e79ca44ccfa9c76c8b5b9e8be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931104 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Auto-Submit: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#720798}
-
