GitLab

This patch pulls computed media query lengths values from backend.
Note: it is ok to create multiple MediaValuesDynamic objects because
they don't have any internal state and serve as a helper wrappers.

BUG=382996

Review URL: https://codereview.chromium.org/339553004

git-svn-id: svn://svn.chromium.org/blink/trunk@176445 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This also fixes small UI problems.

BUG=327641

Review URL: https://codereview.chromium.org/346583002

git-svn-id: svn://svn.chromium.org/blink/trunk@176444 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=pfeldman
BUG=354447

Review URL: https://codereview.chromium.org/347543002

git-svn-id: svn://svn.chromium.org/blink/trunk@176443 bbb929c8-8fbe-4397-9dbb-9b2b20218538

when still in the Canvas2DLayerManager list.

In order to be able to call Canvas2DLayerManager::isInList,
the method has been changed from private to public.

BUG=385141

Review URL: https://codereview.chromium.org/340093003

git-svn-id: svn://svn.chromium.org/blink/trunk@176442 bbb929c8-8fbe-4397-9dbb-9b2b20218538

for squashed layers.

Also remove the assert that the subpixel accumulation matches
the subpixel accumulation if the layer was separately
composited. This doesn't make sense, since the squashing
layer is positioned relative to the compositing ancestor
of m_owningLayer, not the squashing layer, which can have
different subpixel accumulations since subpixel
accumulation is relative to the compositing container of
the graphics layer.

BUG=369526

Review URL: https://codereview.chromium.org/343543005

git-svn-id: svn://svn.chromium.org/blink/trunk@176441 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL removes the gen/blink/platform dir in core.gyp and qualifies
all the instances that include RuntimeEnabledFeatures.h.

BUG=381876

Review URL: https://codereview.chromium.org/344593002

git-svn-id: svn://svn.chromium.org/blink/trunk@176440 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/331303002

git-svn-id: svn://svn.chromium.org/blink/trunk@176439 bbb929c8-8fbe-4397-9dbb-9b2b20218538

According to the coding guidelines for blink, we should not use
"using" declarations of any kind to import names in the C++ Standard
library. This patch removes all those "using" declarations.

Effected folder: Source/core/css

Review URL: https://codereview.chromium.org/342693003

git-svn-id: svn://svn.chromium.org/blink/trunk@176436 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Numerous IndexedDB IPC messages sent renderer->browser are defined members that are enums from Blink (public/platform), and on receipt are static_cast to types
defined in Chromium:

blink::WebIDBCursor::Direction => indexed_db::CursorDirection
blink::WebIDBDatabase::TaskType => IndexedDBDatabase::TaskType
blink::WebIDBDatabase::PutMode => IndexedDBDatabase::PutMode
blink::WebIDBDatabase::TransactionMode => uint16 => indexed_db::TransactionMode

Nothing enforces the equality of these enums at compile time.

So the approach adopted here is to move the Blink-side enums into public/platform/WebIDBTypes.h and use it everywhere.

Patch spread across chromium content side as well as on Blink side.
Chromium side: https://codereview.chromium.org/320833002
Blink side: https://codereview.chromium.org/325683002

BUG=381848
R=dglazkov@chromium.org, jsbell@chromium.org

Review URL: https://codereview.chromium.org/325683002

Patch from Pritam Nikam <pritam.nikam@samsung.com>.

git-svn-id: svn://svn.chromium.org/blink/trunk@176435 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This refactoring encapsulates sync and async microtask queues into
CustomElementMicrotaskStepDispatcher class.
Also, it renames CustomElementMicrotaskQueue to CustomElementSyncMicrotaskQueue
for clarifying the difference from the async queue.

This is a preparation for fixing crbug.com/384516

BUG=384516
TEST=none
R=dglazkov@chromium.org, dominicc@chromium.org

Review URL: https://codereview.chromium.org/334253005

git-svn-id: svn://svn.chromium.org/blink/trunk@176434 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Because HTMLFrameOwnerElement.h includes Document.h, the consequence is
mostly that Document.h includes need to be added.

Locally, this reduces the number of recompilation steps when touching
HTMLFrameOwnerElement.h from 579 to 117, and when touching Document.h
from 1214 to 1160.

There is a risk of performance regressions due to outlining
Frame::deprecatedLocalOwner().

Review URL: https://codereview.chromium.org/343593002

git-svn-id: svn://svn.chromium.org/blink/trunk@176433 bbb929c8-8fbe-4397-9dbb-9b2b20218538

A layer's absolute clip rects are no longer valid when its
transform or the transform of an ancestor changes, since the
layer moves in absolute space. This CL clears the absolute
clip rects of a layer and its descendants when the layer's
transform changes.

BUG=246965

Review URL: https://codereview.chromium.org/334373002

git-svn-id: svn://svn.chromium.org/blink/trunk@176432 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces ViewportElement.cacheHeight() method which is
called by viewport control in appropriate time to let viewportElement
cache its height. Currently, ViewportElement.willHide() method is
responsible for height caching.

ViewportElement.cacheHeight() must not invalidate DOM. This is not
the case for willHide() method due to the console.table implementation
which removes inner DataGrid views. The bug happens because of the
"scroller securing" (see ViewportElement.refresh method) being done after
the sequence of willHide() calls.

BUG=385685
R=aandrey, pfeldman

Review URL: https://codereview.chromium.org/340483003

git-svn-id: svn://svn.chromium.org/blink/trunk@176431 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Make iterator for Element's attributes more lightweight. Kill the
AttributeConstIterator class and make the iterator a simple pointer instead
(similarly to the Vector iterator). Also rename the AttributeIteratorAccessor
class to AttributeCollection as I think it looks better. This CL adds a typedef
so that the iterator is now used as AttributeCollection::const_iterator.

Also rename the attributesIterator() method to attributes() for simplicity.

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/337753005

git-svn-id: svn://svn.chromium.org/blink/trunk@176430 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=sigbjornf@opera.com
BUG=

Review URL: https://codereview.chromium.org/334623006

git-svn-id: svn://svn.chromium.org/blink/trunk@176429 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/320423004

Review URL: https://codereview.chromium.org/320423004

git-svn-id: svn://svn.chromium.org/blink/trunk@176428 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use stricter typing for NodeLists throughout the code base. This makes it
clearer what exact type we are actually dealing with. This also allows the
compiler to de-virtualize some function calls with C++11.

R=adamk@chromium.org, esprehn@chromium.org

Review URL: https://codereview.chromium.org/334713006

git-svn-id: svn://svn.chromium.org/blink/trunk@176427 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove unneeded checks in RenderTreeBuilder, the same check is done in RenderTreeBuilder::shouldCreateRenderer.

Review URL: https://codereview.chromium.org/334263007

git-svn-id: svn://svn.chromium.org/blink/trunk@176426 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=327641
R=dgozman@chromium.org

Review URL: https://codereview.chromium.org/347583003

git-svn-id: svn://svn.chromium.org/blink/trunk@176425 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=327641
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/340723005

git-svn-id: svn://svn.chromium.org/blink/trunk@176423 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=245436

Review URL: https://codereview.chromium.org/347513004

git-svn-id: svn://svn.chromium.org/blink/trunk@176422 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=361045
R=loislo@chromium.org

Review URL: https://codereview.chromium.org/339493005

git-svn-id: svn://svn.chromium.org/blink/trunk@176421 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Media query evaluator assumes that device size cannot change, which is
wrong in emulation mode.

BUG=327641,386142

Review URL: https://codereview.chromium.org/308003007

git-svn-id: svn://svn.chromium.org/blink/trunk@176420 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/340813002

git-svn-id: svn://svn.chromium.org/blink/trunk@176419 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=384556
R=yurys

Review URL: https://codereview.chromium.org/347463006

git-svn-id: svn://svn.chromium.org/blink/trunk@176418 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=vsevik

Review URL: https://codereview.chromium.org/344583003

git-svn-id: svn://svn.chromium.org/blink/trunk@176417 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Removed m_stop and length comparison as they carry different units i.e. if there are two char text then m_stop will be 1 and length 2. As do not compare, needWordSpace does not set correct value.  

Also by default condition for needSpacing has been changed to true because if first character is space it was getting omitted. 

BUG=344873
R=leviw, eae
TEST=Word spacing in RTL with different segments handling.

Review URL: https://codereview.chromium.org/343443002

git-svn-id: svn://svn.chromium.org/blink/trunk@176416 bbb929c8-8fbe-4397-9dbb-9b2b20218538

MediaController::trace() needs to have the declaration of ExecutionContext
available, so as to determine what NeedsAdjustAndMark<> resolves to for
its (weak) ExecutionContext member.

R=haraken@chromium.org,zerny@chromium.org
BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/344443008

git-svn-id: svn://svn.chromium.org/blink/trunk@176415 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This changes TimelineDetailsView to be a TabbedPane and lets us add
additional tabs for record types where we can show more details (e.g.
layer tree view or paint profiler). The old details remain in "default"
first tab. Also, for selected range stats, we now show range begin-end
as a part of details view, not in the header.

BUG=

Review URL: https://codereview.chromium.org/325313006

git-svn-id: svn://svn.chromium.org/blink/trunk@176414 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This switches trace events emitted from PlatformInstrumentation to use
trace event category consistent with the trace-based timeline.
Drive-by: fix category filter in TraceEventDispatcher.

BUG=361045

Review URL: https://codereview.chromium.org/337143002

git-svn-id: svn://svn.chromium.org/blink/trunk@176413 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=327641
NOTRY=true
R=dgozman@chromium.org

Review URL: https://codereview.chromium.org/343563003

git-svn-id: svn://svn.chromium.org/blink/trunk@176412 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We're trying to make v8::TryCatch nestable.
In preparation for that, this CL adds ReThrow for nested trycatches.

BUG=362388

Review URL: https://codereview.chromium.org/313033002

git-svn-id: svn://svn.chromium.org/blink/trunk@176411 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch updates owner document of Range objects when orphan Node object moved
to another document in new member function |Range::updateOwnerDocumentIfNeeded|.

Note: when we move non-null parent Node object to another document, it is done
by removeChild and appendChild and Range objects to reset to start of document.

The root cause of issue 350362 is boundary points of Range objects isn't
adjusted when owner document of Range and boundary points are different.

Because |Range::nodeChildrenChanged|, which adjusts boundary points for
|Node.appendChild|, is called for Range objects in another document which
isn't owner of Range.

This patch also updates "move-detached-child-in-range.html" to have right
value.

BUG=350362
TEST=LayoutTests/fast/dom/Range/range-extract-contents-after-move-to-another-document-crash.html
TEST=LayoutTests/fast/dom/move-detached-child-in-range.html

Review URL: https://codereview.chromium.org/332173003

git-svn-id: svn://svn.chromium.org/blink/trunk@176410 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=327641

Review URL: https://codereview.chromium.org/341483004

git-svn-id: svn://svn.chromium.org/blink/trunk@176409 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true

Review URL: https://codereview.chromium.org/338993006

git-svn-id: svn://svn.chromium.org/blink/trunk@176408 bbb929c8-8fbe-4397-9dbb-9b2b20218538

1) Remove more Backslash-as-JPY hacks (some encodings interpret backslash as yen
sign).

The code was added in https://bugs.webkit.org/show_bug.cgi?id=49714 (r73566).

The test used to be
editing/selection/find-yensign-and-backslash-with-japanese-fonts-expected.html

The feature was removed by https://codereview.chromium.org/27030014 (r159589),
but the removal was incomplete. This CL removes the leftover code and test
expectation files (the corresponding tests were removed by r159589).

2) Remove isJapaneseEncoding from TextEncodingRegistry.cpp; it was dead
code. There used to be bool TextEncoding::isJapanese() (see r16245) which was
used by WebCore/loader/Decoder.cpp... but TextEncoding::isJapanese no longer
exists, and isJapaneseEncoding appears not to be used any more.

BUG=
R=abarth@chromium.org, jshin@chromium.org

Review URL: https://codereview.chromium.org/335803002

git-svn-id: svn://svn.chromium.org/blink/trunk@176407 bbb929c8-8fbe-4397-9dbb-9b2b20218538

MediaQueryLists were re-evaluated for every styleResolverChanged(). The
evaluation of MediaQueryLists can only change when some media type or
features change. That is signalled through mediaQueryAffectingValueChanged().
Set m_evaluateMediaQueriesOnStyleRecalc there instead.

Since the media queries don't change this is not noticable through layout
or unit testing.

R=esprehn@chromium.org
BUG=382894

Review URL: https://codereview.chromium.org/322043008

git-svn-id: svn://svn.chromium.org/blink/trunk@176406 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TimelineUIUtils now has two descendants:
- TracingTimelineUIUtils for tracing based timeline records
- TimelineUIUtilsImpl for timeline records based on Timeline agent events
This patch moves some of UI-specific getters from TimelineModel.Record into TimelineUIUtils instance methods. In the end we should have all ui logic that depends on particular backend details to be encapsulated in TimelineUIUtils instance.

BUG=361045
R=caseq@chromium.org

Review URL: https://codereview.chromium.org/344443007

git-svn-id: svn://svn.chromium.org/blink/trunk@176405 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=aandrey, eustas, yurys

Review URL: https://codereview.chromium.org/344443003

git-svn-id: svn://svn.chromium.org/blink/trunk@176404 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Some modules, for example WebMIDI and WebCrypto, needs "Async Initializer".
The initializer should stay alive until the initialization succeeds (i.e. the
associated Promise is resolved), the initialization fails
(i.e. rejected), or the associated ExecutionContext is stopped.
This CL introduces the the constructor mode ScriptPromiseResolverWithContext.
If KeepAliveWhilePending is specified, the created resolver stays alive while
one of the above conditions meets.
Each initializer can stay alive by inheriting ScriptPromiseResolverWithContext.

This CL rewrites WebMIDI and WebCrypto async operations with it.

BUG=361041

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176381

Review URL: https://codereview.chromium.org/311733004

git-svn-id: svn://svn.chromium.org/blink/trunk@176403 bbb929c8-8fbe-4397-9dbb-9b2b20218538